File 0017-alsactl-Fix-the-va_list-initialization-in-... of Package alsa-utils

Overview Repositories Revisions Requests Users Attributes Meta

File 0017-alsactl-Fix-the-va_list-initialization-in-cerror_-an.patch of Package alsa-utils (Revision 29aa1c1ea4dfb759ef1c1be469c56fe0)

Currently displaying revision 29aa1c1ea4dfb759ef1c1be469c56fe0 , Show latest

From f4be3f88b6e80e3f3ea19ba5784cff49ab6e6277 Mon Sep 17 00:00:00 2001
From: Jaroslav Kysela <perex@perex.cz>
Date: Sun, 29 Dec 2013 20:03:21 +0100
Subject: [PATCH] alsactl: Fix the va_list initialization in cerror_() and
 dbg_()

The <ap> argument for syslog_() was uninitialized.

From: Alan Hamilton <alanh@arizonaroads.com>
Signed-off-by: Jaroslav Kysela <perex@perex.cz>
---
 alsactl/utils.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/alsactl/utils.c b/alsactl/utils.c
index 072c23998e45..b5d183cb437c 100644
--- a/alsactl/utils.c
+++ b/alsactl/utils.c
@@ -150,10 +150,10 @@ void cerror_(const char *fcn, long line, int cond, const char *fmt, ...)
 
 	if (!cond && !debugflag)
 		return;
+	va_start(ap, fmt);
 	if (use_syslog) {
 		syslog_(LOG_ERR, fcn, line, fmt, ap);
 	} else {
-		va_start(ap, fmt);
 		fprintf(stderr, "%s: %s:%ld: ", command, fcn, line);
 		vfprintf(stderr, fmt, ap);
 		putc('\n', stderr);
@@ -167,10 +167,10 @@ void dbg_(const char *fcn, long line, const char *fmt, ...)
 
 	if (!debugflag)
 		return;
+	va_start(ap, fmt);
 	if (use_syslog) {
 		syslog_(LOG_DEBUG, fcn, line, fmt, ap);
 	} else {
-		va_start(ap, fmt);
 		fprintf(stderr, "%s: %s:%ld: ", command, fcn, line);
 		vfprintf(stderr, fmt, ap);
 		putc('\n', stderr);
-- 
1.8.4.5

Places

File 0017-alsactl-Fix-the-va_list-initialization-in-cerror_-an.patch of Package alsa-utils (Revision 29aa1c1ea4dfb759ef1c1be469c56fe0)

Places