File n-0062-alpm-have-pk_alpm_update_databases-retur... of Package PackageKit

Overview Repositories Revisions Requests Users Attributes Meta

File n-0062-alpm-have-pk_alpm_update_databases-return-meaningful.patch of Package PackageKit

From 964f244ccb70adf1715f0708543ee5cffa03a7ee Mon Sep 17 00:00:00 2001
From: Aleix Pol <aleixpol@kde.org>
Date: Tue, 21 Dec 2021 05:12:09 +0100
Subject: [PATCH 062/102] alpm: have pk_alpm_update_databases() return
 meaningful information

So far it was always returning FALSE, which doesn't matter because
nobody reads that value, but it better not be random.

diff --git a/backends/alpm/pk-alpm-update.c b/backends/alpm/pk-alpm-update.c
index 284dad422..f59ae32e2 100644
--- a/backends/alpm/pk-alpm-update.c
+++ b/backends/alpm/pk-alpm-update.c
@@ -288,12 +288,12 @@ pk_alpm_update_databases (PkBackendJob *job, gint force, GError **error)
 	pk_backend_job_set_status (job, PK_STATUS_ENUM_DOWNLOAD_PACKAGELIST);
 
 	i = alpm_get_syncdbs (priv->alpm);
-	pk_alpm_refresh_databases (job, force, i, error);
+	int ret = pk_alpm_refresh_databases(job, force, i, error);
 
 	if (i == NULL)
 		return pk_alpm_transaction_end (job, error);
 	pk_alpm_transaction_end (job, NULL);
-	return FALSE;
+	return ret != 0;
 }
 
 static gboolean
-- 
2.35.1

Places

File n-0062-alpm-have-pk_alpm_update_databases-return-meaningful.patch of Package PackageKit

Places