File 0077-hipe_icode_range-Add-comment-about-side-ef... of Package erlang

Overview Repositories Revisions Requests Users Attributes Meta

File 0077-hipe_icode_range-Add-comment-about-side-effects.patch of Package erlang (Revision b921e8aed3aceafaa8c09c18784302db)

Currently displaying revision b921e8aed3aceafaa8c09c18784302db , Show latest

From af3f9ca6fa5b207e7619590723f80002d82a013a Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Magnus=20L=C3=A5ng?= <margnus1@telia.com>
Date: Tue, 28 Mar 2017 14:01:04 +0200
Subject: [PATCH 3/3] hipe_icode_range: Add comment about side-effects

---
 lib/hipe/icode/hipe_icode_range.erl | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/lib/hipe/icode/hipe_icode_range.erl b/lib/hipe/icode/hipe_icode_range.erl
index d1ffb105f..287b1c80f 100644
--- a/lib/hipe/icode/hipe_icode_range.erl
+++ b/lib/hipe/icode/hipe_icode_range.erl
@@ -395,6 +395,9 @@ analyse_call(Call, LookupFun) ->
   Args = hipe_icode:args(Call),
   Fun = hipe_icode:call_fun(Call),
   Type = hipe_icode:call_type(Call),
+  %% This call has side-effects (it might call LookupFun which sends messages to
+  %% hipe_icode_coordinator to update the argument ranges of Fun), and must thus
+  %% not be moved into the case statement.
   DstRanges = analyse_call_or_enter_fun(Fun, Args, Type, LookupFun),
   case hipe_icode:call_dstlist(Call) of
     [] ->
-- 
2.12.2

Places

File 0077-hipe_icode_range-Add-comment-about-side-effects.patch of Package erlang (Revision b921e8aed3aceafaa8c09c18784302db)

Places