File 0150-dialyzer-Warn-for-bad-type-variables-of-pa... of Package erlang

Overview Repositories Revisions Requests Users Attributes Meta

File 0150-dialyzer-Warn-for-bad-type-variables-of-parameterize.patch of Package erlang (Revision 7787e944ee03c956fdcc5c0c5c91f052)

Currently displaying revision 7787e944ee03c956fdcc5c0c5c91f052 , Show latest

From 0ec564035fb5de2c42ebb69be1d61933c79b4019 Mon Sep 17 00:00:00 2001
From: Hans Bolinder <hasse@erlang.org>
Date: Tue, 16 May 2017 16:46:55 +0200
Subject: [PATCH 2/2] dialyzer: Warn for bad type variables of parameterized
 types

As of commit 854ee8b (Erlang/OTP 18) warnings about using '_' as type
variable in parameterized types have not been output.

The code of erl_types:t_var_names() is corrected. The spec is also
corrected (thanks to Kostis for pointing out the bug).
---
 lib/hipe/cerl/erl_types.erl | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/lib/hipe/cerl/erl_types.erl b/lib/hipe/cerl/erl_types.erl
index ea8cc1677..4cfa80f15 100644
--- a/lib/hipe/cerl/erl_types.erl
+++ b/lib/hipe/cerl/erl_types.erl
@@ -5171,9 +5171,9 @@ cache_put(Key, Type, DeltaL, #cache{types = Types} = Cache) ->
 cache_put(Key, Type, DeltaL, Cache) ->
   maps:put(Key, {Type, DeltaL}, Cache).
 
--spec t_var_names([erl_type()]) -> [atom()].
+-spec t_var_names([parse_form()]) -> [atom()].
 
-t_var_names([{var, _, Name}|L]) when L =/= '_' ->
+t_var_names([{var, _, Name}|L]) when Name =/= '_' ->
   [Name|t_var_names(L)];
 t_var_names([]) ->
   [].
-- 
2.13.0

Places

File 0150-dialyzer-Warn-for-bad-type-variables-of-parameterize.patch of Package erlang (Revision 7787e944ee03c956fdcc5c0c5c91f052)

Places