File 0397-os_mon-Fix-volatile-test-cpu_sup_SUITE-uti... of Package erlang

Overview Repositories Revisions Requests Users Attributes Meta

File 0397-os_mon-Fix-volatile-test-cpu_sup_SUITE-util_api.patch of Package erlang (Revision ee5107dd2cb9269b862e70debf0422c2)

Currently displaying revision ee5107dd2cb9269b862e70debf0422c2 , Show latest

From 0c63aea9fe16372d827c93fc553148a7c92b9329 Mon Sep 17 00:00:00 2001
From: Sverker Eriksson <sverker@erlang.org>
Date: Mon, 9 Jul 2018 18:28:45 +0200
Subject: [PATCH 2/2] os_mon: Fix volatile test cpu_sup_SUITE:util_api

Don't match floats.
---
 lib/os_mon/test/cpu_sup_SUITE.erl | 11 +++++++----
 1 file changed, 7 insertions(+), 4 deletions(-)

diff --git a/lib/os_mon/test/cpu_sup_SUITE.erl b/lib/os_mon/test/cpu_sup_SUITE.erl
index 7122d23503..ba28f31f26 100644
--- a/lib/os_mon/test/cpu_sup_SUITE.erl
+++ b/lib/os_mon/test/cpu_sup_SUITE.erl
@@ -122,19 +122,19 @@ util_api(Config) when is_list(Config) ->
 
     %% util([])
     {all, Busy1, NonBusy1, []} = cpu_sup:util([]),
-    100.00 = Busy1 + NonBusy1,
+    true = tiny_diff(100.00, Busy1 + NonBusy1),
 
     %% util([detailed])
     {Cpus2, Busy2, NonBusy2, []} = cpu_sup:util([detailed]),
     true = lists:all(fun(X) -> is_integer(X) end, Cpus2),
     true = lists:all(BusyP, Busy2),
     true = lists:all(NonBusyP, NonBusy2),
-    100.00 = lists:foldl(Sum,0,Busy2)+lists:foldl(Sum,0,NonBusy2),
+    true = tiny_diff(100.00, lists:foldl(Sum,0,Busy2)+lists:foldl(Sum,0,NonBusy2)),
 
     %% util([per_cpu])
     [{Cpu3, Busy3, NonBusy3, []}|_] = cpu_sup:util([per_cpu]),
     true = is_integer(Cpu3),
-    100.00 = Busy3 + NonBusy3,
+    true = tiny_diff(100.00, Busy3 + NonBusy3),
 
     %% util([detailed, per_cpu])
     [{Cpu4, Busy4, NonBusy4, []}|_] =
@@ -142,7 +142,7 @@ util_api(Config) when is_list(Config) ->
     true = is_integer(Cpu4),
     true = lists:all(BusyP, Busy2),
     true = lists:all(NonBusyP, NonBusy2),
-    100.00 = lists:foldl(Sum,0,Busy4)+lists:foldl(Sum,0,NonBusy4),
+    true = tiny_diff(100.00, lists:foldl(Sum,0,Busy4)+lists:foldl(Sum,0,NonBusy4)),
 
     %% bad util/1 calls
     {'EXIT',{badarg,_}} = (catch cpu_sup:util(detailed)),
@@ -150,6 +150,9 @@ util_api(Config) when is_list(Config) ->
 
     ok.
 
+tiny_diff(A, B) ->
+    (abs(A - B) < 1.0e-11).
+
 -define(SPIN_TIME, 1000).
 
 %% Test utilization values
-- 
2.16.4

Places

File 0397-os_mon-Fix-volatile-test-cpu_sup_SUITE-util_api.patch of Package erlang (Revision ee5107dd2cb9269b862e70debf0422c2)

Places