File 0412-crypto-Fix-crash-in-compute_key-ecdh-.-on-... of Package erlang

Overview Repositories Revisions Requests Users Attributes Meta

File 0412-crypto-Fix-crash-in-compute_key-ecdh-.-on-badarg.patch of Package erlang (Revision aa120d3233f613ad478314c3181372c5)

Currently displaying revision aa120d3233f613ad478314c3181372c5 , Show latest

From 806a409df7cf2b07a39b3876fd36099579df126a Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?John=20H=C3=B6gberg?= <john@erlang.org>
Date: Wed, 18 Jul 2018 10:23:51 +0200
Subject: [PATCH] crypto: Fix crash in compute_key(ecdh, ...) on badarg

When term2point was passed a non-binary argument, `my_ecpoint`
would be left uninitialized and the cleanup code would free a
garbage pointer.
---
 lib/crypto/c_src/crypto.c        |  2 +-
 lib/crypto/test/crypto_SUITE.erl | 17 ++++++++++++++++-
 2 files changed, 17 insertions(+), 2 deletions(-)

diff --git a/lib/crypto/c_src/crypto.c b/lib/crypto/c_src/crypto.c
index 94a207cba6..6e855939f7 100644
--- a/lib/crypto/c_src/crypto.c
+++ b/lib/crypto/c_src/crypto.c
@@ -3501,7 +3501,7 @@ static ERL_NIF_TERM ecdh_compute_key_nif(ErlNifEnv* env, int argc, const ERL_NIF
     int i;
     EC_GROUP *group;
     const BIGNUM *priv_key;
-    EC_POINT *my_ecpoint;
+    EC_POINT *my_ecpoint = NULL;
     EC_KEY *other_ecdh = NULL;
 
     if (!get_ec_key(env, argv[1], argv[2], atom_undefined, &key))
-- 
2.16.4

Places

File 0412-crypto-Fix-crash-in-compute_key-ecdh-.-on-badarg.patch of Package erlang (Revision aa120d3233f613ad478314c3181372c5)

Places