File 0616-file_name_SUITE-Darwin-18-broke-support-fo... of Package erlang

Overview Repositories Revisions Requests Users Attributes Meta

File 0616-file_name_SUITE-Darwin-18-broke-support-for-icky-nam.patch of Package erlang (Revision 66a224e208ffe9ee89602bad56a74dfa)

Currently displaying revision 66a224e208ffe9ee89602bad56a74dfa , Show latest

From 261f171079f98c7037309fcb7b2967e9fb79cfe5 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?John=20H=C3=B6gberg?= <john@erlang.org>
Date: Mon, 25 Mar 2019 14:07:37 +0100
Subject: [PATCH 2/2] file_name_SUITE: Darwin 18 broke support for 'icky' names

---
 lib/kernel/test/file_name_SUITE.erl | 11 +++++++----
 1 file changed, 7 insertions(+), 4 deletions(-)

diff --git a/lib/kernel/test/file_name_SUITE.erl b/lib/kernel/test/file_name_SUITE.erl
index 3afc647081..26cfd187c7 100644
--- a/lib/kernel/test/file_name_SUITE.erl
+++ b/lib/kernel/test/file_name_SUITE.erl
@@ -632,10 +632,13 @@ make_icky_dir(Mod, IckyDirName) ->
 
 hopeless_darwin() ->
     case {os:type(),os:version()} of
-	{{unix,darwin},{Major,_,_}} when Major < 9 ->
-	    true;
-	_ ->
-	    false
+        {{unix,darwin},{Major,_,_}} ->
+            %% icky file names worked between 10 and 17, but started returning
+            %% EILSEQ in 18. The check against 18 is exact in case newer
+            %% versions of Darwin support them again.
+            Major < 9 orelse Major =:= 18;
+        _ ->
+            false
     end.
 
 make_very_icky_dir(Mod, DirName) ->
-- 
2.16.4

Places

File 0616-file_name_SUITE-Darwin-18-broke-support-for-icky-nam.patch of Package erlang (Revision 66a224e208ffe9ee89602bad56a74dfa)

Places