File 0626-Issue-an-error-for-improper-use-of-record_... of Package erlang

Overview Repositories Revisions Requests Users Attributes Meta

File 0626-Issue-an-error-for-improper-use-of-record_info-2-in-.patch of Package erlang (Revision 78a1bd9f697440279abb1318993fcdeb)

Currently displaying revision 78a1bd9f697440279abb1318993fcdeb , Show latest

From 23a497af427493b94739761e4d4974e12bc67579 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Bj=C3=B6rn=20Gustavsson?= <bjorn@erlang.org>
Date: Tue, 9 Apr 2019 06:37:55 +0200
Subject: [PATCH] Issue an error for improper use of record_info/2 in a fun

`record_info/2` is a pseudo-function that requires literal arguments
known at compile time. Therefore, the following usage is illegal:

f() -> fun record_info/2.

However, `erl_lint` did not issue a compilation error for this usage,
and the compiler would crash in a later pass.

https://bugs.erlang.org/browse/ERL-907
---
 lib/stdlib/src/erl_lint.erl        | 3 +++
 lib/stdlib/test/erl_lint_SUITE.erl | 6 ++++--
 2 files changed, 7 insertions(+), 2 deletions(-)

diff --git a/lib/stdlib/src/erl_lint.erl b/lib/stdlib/src/erl_lint.erl
index 00fd731e1d..e0c37ca030 100644
--- a/lib/stdlib/src/erl_lint.erl
+++ b/lib/stdlib/src/erl_lint.erl
@@ -2276,6 +2276,9 @@ expr({'fun',Line,Body}, Vt, St) ->
     case Body of
         {clauses,Cs} ->
             fun_clauses(Cs, Vt, St);
+        {function,record_info,2} ->
+            %% It is illegal to call record_info/2 with unknown arguments.
+            {[],add_error(Line, illegal_record_info, St)};
         {function,F,A} ->
 	    %% BifClash - Fun expression
             %% N.B. Only allows BIFs here as well, NO IMPORTS!!
diff --git a/lib/stdlib/test/erl_lint_SUITE.erl b/lib/stdlib/test/erl_lint_SUITE.erl
index 939cc1024c..fe98a3796d 100644
--- a/lib/stdlib/test/erl_lint_SUITE.erl
+++ b/lib/stdlib/test/erl_lint_SUITE.erl
@@ -3576,10 +3576,12 @@ basic_errors(Config) ->
 
 	  {illegal_record_info,
 	   <<"f1() -> record_info(42, record).
-	      f2() -> record_info(shoe_size, record).">>,
+	      f2() -> record_info(shoe_size, record).
+              f3() -> fun record_info/2.">>,
 	   [],
 	   {errors,[{1,erl_lint,illegal_record_info},
-		    {2,erl_lint,illegal_record_info}],[]}},
+		    {2,erl_lint,illegal_record_info},
+                    {3,erl_lint,illegal_record_info}],[]}},
 
 	  {illegal_expr,
 	   <<"f() -> a:b.">>,
-- 
2.16.4

Places

File 0626-Issue-an-error-for-improper-use-of-record_info-2-in-.patch of Package erlang (Revision 78a1bd9f697440279abb1318993fcdeb)

Places