File 2439-Clean-up-asn1ct_gen-emit-1.patch of Package erlang

Overview Repositories Revisions Requests Users Attributes Meta

File 2439-Clean-up-asn1ct_gen-emit-1.patch of Package erlang (Revision ef2f13a3fd79ccee295941d812fb0579)

Currently displaying revision ef2f13a3fd79ccee295941d812fb0579 , Show latest

From 608e04fb0bf6f88efce4aa2a5ff3cfc50f07fba0 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Bj=C3=B6rn=20Gustavsson?= <bjorn@erlang.org>
Date: Tue, 14 Mar 2017 09:19:20 +0100
Subject: [PATCH 08/10] Clean up asn1ct_gen:emit/1

Remove blank lines between clauses; use matching instead of
is_list/1 guards.
---
 lib/asn1/src/asn1ct_gen.erl | 22 +++++++---------------
 1 file changed, 7 insertions(+), 15 deletions(-)

diff --git a/lib/asn1/src/asn1ct_gen.erl b/lib/asn1/src/asn1ct_gen.erl
index 56ea28d5c..2e9dbd78d 100644
--- a/lib/asn1/src/asn1ct_gen.erl
+++ b/lib/asn1/src/asn1ct_gen.erl
@@ -958,42 +958,34 @@ emit(Term) ->
 
 do_emit({prev,Variable}) when is_atom(Variable) ->
     do_emit({var,asn1ct_name:prev(Variable)});
-
 do_emit({next,Variable}) when is_atom(Variable) ->
     do_emit({var,asn1ct_name:next(Variable)});
-
 do_emit({curr,Variable}) when is_atom(Variable) ->
     do_emit({var,asn1ct_name:curr(Variable)});
-    
 do_emit({var,Variable}) when is_atom(Variable) ->
     [Head|V] = atom_to_list(Variable),
     [Head-32|V];
-
 do_emit({asis,What}) ->
     io_lib:format("~w", [What]);
-
 do_emit({call,M,F,A}) ->
     MFA = {M,F,length(A)},
     asn1ct_func:need(MFA),
     [atom_to_list(F),"(",call_args(A, "")|")"];
-
 do_emit(nl) ->
     "\n";
-
 do_emit(com) ->
     ",";
-
+do_emit([C|_]=Str) when is_integer(C) ->
+    Str;
+do_emit([_|_]=L) ->
+    [do_emit(E) || E <- L];
+do_emit([]) ->
+    [];
 do_emit(What) when is_integer(What) ->
     integer_to_list(What);
-
-do_emit(What) when is_list(What), is_integer(hd(What)) ->
-    What;
-
 do_emit(What) when is_atom(What) ->
-    atom_to_list(What);
+    atom_to_list(What).
 
-do_emit(What) when is_list(What) ->
-    [do_emit(E) || E <- What].
 
 call_args([A|As], Sep) ->
     [Sep,do_emit(A)|call_args(As, ", ")];
-- 
2.12.0

Places

File 2439-Clean-up-asn1ct_gen-emit-1.patch of Package erlang (Revision ef2f13a3fd79ccee295941d812fb0579)

Places