File 2508-Fix-inadvertently-broad-monitor.patch of Package erlang

Overview Repositories Revisions Requests Users Attributes Meta

File 2508-Fix-inadvertently-broad-monitor.patch of Package erlang

From 37df105ad012683de1de4a1db40818dde9c7f3bd Mon Sep 17 00:00:00 2001
From: Anders Svensson <anders@erlang.org>
Date: Sun, 14 Apr 2019 13:05:50 +0200
Subject: [PATCH 1/2] Fix inadvertently broad monitor

Commit d9d918b2 added a gen_server whose purpose is to keep track of
visible nodes on which diameter_dist:attach/1 has been called to
register a node as a handler of incoming Diameter requests when
diameter_dist:route_session/2 is configured as spawn_opt MFA. The server
contacts visible nodes at init in order to request information, but
instead of monitoring visible to also be able to request information at
nodeup, it monitored on all nodes, resulting in gen_server casts even to
hidden nodes.

Monitor only on visible nodes since a hidden node may not be able to
deal with the new message.
---
 lib/diameter/src/base/diameter_dist.erl | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/lib/diameter/src/base/diameter_dist.erl b/lib/diameter/src/base/diameter_dist.erl
index 5c29ea95a4..963db71260 100644
--- a/lib/diameter/src/base/diameter_dist.erl
+++ b/lib/diameter/src/base/diameter_dist.erl
@@ -454,7 +454,8 @@ start_link() ->
 init([]) ->
     ets:new(?NODE_TABLE,    [set, named_table]),
     ets:new(?SERVICE_TABLE, [bag, named_table]),
-    ok = net_kernel:monitor_nodes(true, [{node_type, all}, nodedown_reason]),
+    ok = net_kernel:monitor_nodes(true, [{node_type, visible},
+                                         nodedown_reason]),
     ets:insert(?NODE_TABLE, [{?B(N), N} || N <- [node() | nodes()]]),
     abcast({attach, node()}),
     {ok, sets:new()}.
-- 
2.16.4

Places

File 2508-Fix-inadvertently-broad-monitor.patch of Package erlang

Places