File 3482-snmp-Dialyzer-fixes.patch of Package erlang
From 59e242ad410bb818884db4eb87d69b436ae0239f Mon Sep 17 00:00:00 2001
From: Micael Karlberg <bmk@erlang.org>
Date: Wed, 30 Sep 2020 16:36:09 +0200
Subject: [PATCH 12/21] [snmp] Dialyzer fixes
OTP-16649
---
lib/snmp/src/agent/snmp_framework_mib.erl | 8 +-------
lib/snmp/src/manager/snmpm_server.erl | 1 +
lib/snmp/src/misc/snmp_conf.erl | 2 +-
3 files changed, 3 insertions(+), 8 deletions(-)
diff --git a/lib/snmp/src/agent/snmp_framework_mib.erl b/lib/snmp/src/agent/snmp_framework_mib.erl
index cc0838fc77..fa0464c077 100644
--- a/lib/snmp/src/agent/snmp_framework_mib.erl
+++ b/lib/snmp/src/agent/snmp_framework_mib.erl
@@ -278,13 +278,7 @@ check_agent({intAgentTransports = Tag, Transports}, {_, Port} = State)
"~n Opts: ~p", [Domain, Address, Kind, Opts]),
ok = snmp_conf:check_transport_kind(Kind),
?vtrace("check_agent(intAgentTransports) -> checked kind"),
- CheckedOpts =
- case snmp_conf:check_transport_opts(Opts) of
- ok ->
- Opts;
- {ok, Opts2} ->
- Opts2
- end,
+ CheckedOpts = snmp_conf:check_transport_opts(Opts),
?vtrace("check_agent(intAgentTransports) -> checked opts: "
"~n ~p", [CheckedOpts]),
case snmp_conf:check_transport_address(Domain, Address) of
diff --git a/lib/snmp/src/manager/snmpm_server.erl b/lib/snmp/src/manager/snmpm_server.erl
index e64b11dd77..fedb1d2b32 100644
--- a/lib/snmp/src/manager/snmpm_server.erl
+++ b/lib/snmp/src/manager/snmpm_server.erl
@@ -3520,6 +3520,7 @@ nis_stop(_) ->
ok.
+-dialyzer({nowarn_function, nis_info/1}).
nis_info(NIS) when is_pid(NIS) ->
NIS ! {?MODULE, self(), info},
receive
diff --git a/lib/snmp/src/misc/snmp_conf.erl b/lib/snmp/src/misc/snmp_conf.erl
index 4e11742515..0de2490b3d 100644
--- a/lib/snmp/src/misc/snmp_conf.erl
+++ b/lib/snmp/src/misc/snmp_conf.erl
@@ -851,7 +851,7 @@ check_transport_opts(BadOpts) ->
error({bad_transport_opts, BadOpts}).
check_transport_opts([], Extra, Acc) ->
- {ok, lists:reverse(Acc) ++ Extra};
+ lists:reverse(Acc) ++ Extra;
check_transport_opts([{bind_to, BindTo} = Opt|Opts], Extra, Acc)
when is_boolean(BindTo) ->
check_transport_opts(Opts, Extra, [Opt|Acc]);
--
2.26.2