File 0259-otp-Require-complete-build-when-updating-d... of Package erlang

Overview Repositories Revisions Requests Users Attributes Meta

File 0259-otp-Require-complete-build-when-updating-deprecation.patch of Package erlang (Revision 49aa26b943fcbed41dda0b0a8caee5fb)

Currently displaying revision 49aa26b943fcbed41dda0b0a8caee5fb , Show latest

From e323866dfb77f2006e94ab6c4a53509e758fdc3d Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?John=20H=C3=B6gberg?= <john@erlang.org>
Date: Mon, 1 Feb 2021 10:44:35 +0100
Subject: [PATCH] otp: Require complete build when updating deprecations

---
 lib/stdlib/scripts/update_deprecations | 24 +++++++++++++++++++++---
 1 file changed, 21 insertions(+), 3 deletions(-)

diff --git a/lib/stdlib/scripts/update_deprecations b/lib/stdlib/scripts/update_deprecations
index 013ef33991..e6eb5326d2 100755
--- a/lib/stdlib/scripts/update_deprecations
+++ b/lib/stdlib/scripts/update_deprecations
@@ -42,8 +42,17 @@ main(["make_xml",Type,Top,Outfile]) ->
     halt(0).
 
 ebin_directories(Top) ->
-    [filename:join(Top, "erts/preloaded/ebin")] ++
-        filelib:wildcard(filename:join(Top, "lib/*/ebin")).
+    AppDirs0 = filelib:wildcard(filename:join(Top, "lib/*/ebin")),
+
+    %% Filter out erl_interface and jinterface since they lack Erlang code, and
+    %% ODBC because we can't build it on all platforms we develop on. This must
+    %% be fixed before we deprecate or remove functionality in ODBC.
+    AppDirs = [Dir || Dir <- AppDirs0,
+                      not lists:suffix("erl_interface/ebin", Dir),
+                      not lists:suffix("jinterface/ebin", Dir),
+                      not lists:suffix("odbc/ebin", Dir)],
+
+    [filename:join(Top, "erts/preloaded/ebin")] ++ AppDirs.
 
 summarize(Top) ->
     Directories = ebin_directories(Top),
@@ -51,7 +60,16 @@ summarize(Top) ->
 
 summarize_directory(Dir, Acc) ->
     Files = [filename:join(Dir, F) || F <- filelib:wildcard("*.beam", Dir)],
-    foldl(fun summarize_file/2, Acc, Files).
+    case Files of
+        [_|_] ->
+            foldl(fun summarize_file/2, Acc, Files);
+        [] ->
+            Msg = io_lib:format("~p doesn't appear to be built. Make sure to "
+                                "build all OTP applications before updating "
+                                "deprecations.\n", [Dir]),
+            io:put_chars(standard_error, [Msg]),
+            halt(1)
+    end.
 
 summarize_file(File, Acc) ->
     {ok, {Module, [Chunk]}} = beam_lib:chunks(File, [attributes]),
-- 
2.26.2

Places

File 0259-otp-Require-complete-build-when-updating-deprecation.patch of Package erlang (Revision 49aa26b943fcbed41dda0b0a8caee5fb)

Places