File 0285-Allow-State-to-be-error.patch of Package erlang

Overview Repositories Revisions Requests Users Attributes Meta

File 0285-Allow-State-to-be-error.patch of Package erlang (Revision 3df065dc3d1d0cf1c26091d19d0445f2)

Currently displaying revision 3df065dc3d1d0cf1c26091d19d0445f2 , Show latest

From cdd7200cbe47e708b62b545ccf51f88e954d093d Mon Sep 17 00:00:00 2001
From: Raimo Niskanen <raimo@erlang.org>
Date: Wed, 7 Jun 2023 17:27:35 +0200
Subject: [PATCH] Allow State to be 'error'

sys:get_state/1,2 and sys:replace_state/2,3 used an 'error' tuple
to indicate callback failure and thus mistook the state 'error'
for a failed system callback.
---
 lib/stdlib/src/sys.erl               | 78 +++++++++++++++++-----------
 lib/stdlib/test/gen_statem_SUITE.erl |  7 +++
 2 files changed, 56 insertions(+), 29 deletions(-)

diff --git a/lib/stdlib/src/sys.erl b/lib/stdlib/src/sys.erl
index 6ec29aa1ff..abd025b7f7 100644
--- a/lib/stdlib/src/sys.erl
+++ b/lib/stdlib/src/sys.erl
@@ -138,7 +138,7 @@ get_status(Name, Timeout) -> send_system_msg(Name, get_status, Timeout).
 get_state(Name) ->
     case send_system_msg(Name, get_state) of
 	{error, Reason} -> error(Reason);
-	State -> State
+	{ok, State} -> State
     end.
 
 -spec get_state(Name, Timeout) -> State when
@@ -148,7 +148,7 @@ get_state(Name) ->
 get_state(Name, Timeout) ->
     case send_system_msg(Name, get_state, Timeout) of
 	{error, Reason} -> error(Reason);
-	State -> State
+	{ok, State} -> State
     end.
 
 -spec replace_state(Name, StateFun) -> NewState when
@@ -158,7 +158,7 @@ get_state(Name, Timeout) ->
 replace_state(Name, StateFun) ->
     case send_system_msg(Name, {replace_state, StateFun}) of
 	{error, Reason} -> error(Reason);
-	State -> State
+	{ok, State} -> State
     end.
 
 -spec replace_state(Name, StateFun, Timeout) -> NewState when
@@ -169,7 +169,7 @@ replace_state(Name, StateFun) ->
 replace_state(Name, StateFun, Timeout) ->
     case send_system_msg(Name, {replace_state, StateFun}, Timeout) of
 	{error, Reason} -> error(Reason);
-	State -> State
+	{ok, State} -> State
     end.
 
 -spec change_code(Name, Module, OldVsn, Extra) -> 'ok' | {error, Reason} when
@@ -333,15 +333,19 @@ remove(Name, FuncOrFuncId, Timeout) ->
 %% The receiving side should send Msg to handle_system_msg/5.
 %%-----------------------------------------------------------------
 send_system_msg(Name, Request) ->
-    case catch gen:call(Name, system, Request) of
-	{ok,Res} -> Res;
-	{'EXIT', Reason} -> exit({Reason, mfa(Name, Request)})
+    try gen:call(Name, system, Request) of
+        {ok, Res} ->
+            Res
+    catch exit : Reason ->
+            exit({Reason, mfa(Name, Request)})
     end.
 
 send_system_msg(Name, Request, Timeout) ->
-    case catch gen:call(Name, system, Request, Timeout) of
-	{ok,Res} -> Res;
-	{'EXIT', Reason} -> exit({Reason, mfa(Name, Request, Timeout)})
+    try gen:call(Name, system, Request, Timeout) of
+        {ok, Res} ->
+            Res
+    catch exit : Reason ->
+            exit({Reason, mfa(Name, Request, Timeout)})
     end.
 
 mfa(Name, {debug, {Func, Arg2}}) ->
@@ -503,34 +507,50 @@ do_cmd(SysState, Other, _Parent, _Mod, Debug, Misc) ->
 do_get_state(Mod, Misc) ->
     case erlang:function_exported(Mod, system_get_state, 1) of
 	true ->
-	    try
-		{ok, State} = Mod:system_get_state(Misc),
-		State
-	    catch
-		Cl:Exc ->
-		    {error, {callback_failed,{Mod,system_get_state},{Cl,Exc}}}
-	    end;
+	    try Mod:system_get_state(Misc) of
+                {ok, _} = Result ->
+                    Result;
+                Other ->
+		    {error,
+                     {callback_failed, {Mod,system_get_state},
+                      {bad_return,Other}}}
+            catch
+                Cl : Exc ->
+		    {error,
+                     {callback_failed, {Mod,system_get_state},
+                      {Cl,Exc}}}
+            end;
 	false ->
-	    Misc
+	    {ok, Misc}
     end.
 
 do_replace_state(StateFun, Mod, Misc) ->
     case erlang:function_exported(Mod, system_replace_state, 2) of
 	true ->
-	    try
-		{ok, State, NMisc} = Mod:system_replace_state(StateFun, Misc),
-		{State, NMisc}
+	    try Mod:system_replace_state(StateFun, Misc) of
+		{ok, State, NMisc} ->
+                    {{ok, State}, NMisc};
+                Other ->
+		    {{error,
+                      {callback_failed, {Mod,system_replace_state},
+                       {bad_return,Other}}},
+                     Misc}
 	    catch
-		Cl:Exc ->
-		    {{error, {callback_failed,{Mod,system_replace_state},{Cl,Exc}}}, Misc}
+		Cl : Exc ->
+		    {{error,
+                      {callback_failed, {Mod,system_replace_state},
+                       {Cl,Exc}}},
+                     Misc}
 	    end;
 	false ->
-	    try
-		NMisc = StateFun(Misc),
-		{NMisc, NMisc}
+	    try StateFun(Misc) of
+		NMisc ->
+                    {{ok, NMisc}, NMisc}
 	    catch
-		Cl:Exc ->
-		    {{error, {callback_failed,StateFun,{Cl,Exc}}}, Misc}
+		Cl : Exc ->
+		    {{error,
+                      {callback_failed, StateFun, {Cl,Exc}}},
+                     Misc}
 	    end
     end.
 
diff --git a/lib/stdlib/test/gen_statem_SUITE.erl b/lib/stdlib/test/gen_statem_SUITE.erl
index d99c7e9786..8257cd3b3b 100644
--- a/lib/stdlib/test/gen_statem_SUITE.erl
+++ b/lib/stdlib/test/gen_statem_SUITE.erl
@@ -1563,6 +1563,13 @@ replace_state(Config) ->
     {state0,NState3} = sys:replace_state(Pid, Replace4),
     ok = sys:resume(Pid),
     {state0,NState3} = sys:get_state(Pid, 5000),
+    %% State 'error' does not exist but is never touched,
+    %% just verify that sys handles it as a state, not as an error return
+    {error,NState3} =
+        sys:replace_state(Pid, fun ({state0, SD}) -> {error, SD} end),
+    {error, NState3} = sys:get_state(Pid),
+    {state0,NState3} =
+        sys:replace_state(Pid, fun ({error, SD}) -> {state0, SD} end),
     stop_it(Pid),
     ok = verify_empty_msgq().
 
-- 
2.35.3

Places

File 0285-Allow-State-to-be-error.patch of Package erlang (Revision 3df065dc3d1d0cf1c26091d19d0445f2)

Places