File 0498-erl_interface-Fix-double-free-bugs.patch of Package erlang

Overview Repositories Revisions Requests Users Attributes Meta

File 0498-erl_interface-Fix-double-free-bugs.patch of Package erlang (Revision c5e180b483b62ec3dcbec1868ff03c21)

Currently displaying revision c5e180b483b62ec3dcbec1868ff03c21 , Show latest

From b6d4cf3ba571806cbf5a7823dfd7687ce6b3d077 Mon Sep 17 00:00:00 2001
From: Sverker Eriksson <sverker@erlang.org>
Date: Wed, 10 Mar 2021 12:17:06 +0100
Subject: [PATCH] erl_interface: Fix double free bugs

introduced on master by
eba460e73540d3e4efab1cfb2c739e215021f03c
---
 lib/erl_interface/src/connect/ei_connect.c | 10 +---------
 1 file changed, 1 insertion(+), 9 deletions(-)

diff --git a/lib/erl_interface/src/connect/ei_connect.c b/lib/erl_interface/src/connect/ei_connect.c
index 50cd1042c3..03175cb805 100644
--- a/lib/erl_interface/src/connect/ei_connect.c
+++ b/lib/erl_interface/src/connect/ei_connect.c
@@ -2166,15 +2166,13 @@ static int send_status(ei_socket_callbacks *cbs, void *ctx,
     if (err) {
 	EI_TRACE_ERR2("send_status","-> SEND_STATUS socket write failed: %s (%d)",
                       estr(err), err);
-	if (buf != dbuf)
-	    free(buf);        
         EI_CONN_SAVE_ERRNO__(err);
 	ret = -1;
     }
     else {
+        EI_TRACE_CONN1("send_status","-> SEND_STATUS (%s)",status);
         ret =  0;
     }
-    EI_TRACE_CONN1("send_status","-> SEND_STATUS (%s)",status);
 done:
     if (buf != dbuf)
 	free(buf);
@@ -2343,8 +2341,6 @@ static int send_name(ei_cnode *ec,
         err = EIO;
     if (err) {
 	EI_TRACE_ERR0("send_name", "SEND_NAME -> socket write failed");
-	if (buf != dbuf)
-	    free(buf);
         EI_CONN_SAVE_ERRNO__(err);
 	ret = -1;
     }
@@ -2417,8 +2413,6 @@ static int send_challenge(ei_cnode *ec,
         err = EIO;
     if (err) {
 	EI_TRACE_ERR0("send_challenge", "-> SEND_CHALLENGE socket write failed");
-	if (buf != dbuf)
-	    free(buf);
         EI_CONN_SAVE_ERRNO__(err);
 	ret = -1;
     }
@@ -2593,8 +2587,6 @@ static int send_complement(ei_cnode *ec,
             err = EIO;
         if (err) {
             EI_TRACE_ERR0("send_name", "SEND_NAME -> socket write failed");
-            if (buf != dbuf)
-                free(buf);
             EI_CONN_SAVE_ERRNO__(err);
             ret = -1;
         }
-- 
2.26.2

Places

File 0498-erl_interface-Fix-double-free-bugs.patch of Package erlang (Revision c5e180b483b62ec3dcbec1868ff03c21)

Places