File 1252-dialyzer-Fix-crash-on-formatting-warning-c... of Package erlang

Overview Repositories Revisions Requests Users Attributes Meta

File 1252-dialyzer-Fix-crash-on-formatting-warning-containing-.patch of Package erlang (Revision 0e18a0502cc8ec77c7a8a467e24ca42a)

Currently displaying revision 0e18a0502cc8ec77c7a8a467e24ca42a , Show latest

From fd2d11a657cda8e91ff8b7443041879cd9694e43 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?John=20H=C3=B6gberg?= <john@erlang.org>
Date: Mon, 24 Apr 2023 19:37:43 +0200
Subject: [PATCH] dialyzer: Fix crash on formatting warning containing unicode
 text

Fixes #7153
---
 lib/dialyzer/src/dialyzer.erl                      | 4 ++--
 lib/dialyzer/test/small_SUITE_data/results/gh_7153 | 3 +++
 lib/dialyzer/test/small_SUITE_data/src/gh_7153.erl | 5 +++++
 3 files changed, 10 insertions(+), 2 deletions(-)
 create mode 100644 lib/dialyzer/test/small_SUITE_data/results/gh_7153
 create mode 100644 lib/dialyzer/test/small_SUITE_data/src/gh_7153.erl

diff --git a/lib/dialyzer/src/dialyzer.erl b/lib/dialyzer/src/dialyzer.erl
index a502f7107d..ecfc509e34 100644
--- a/lib/dialyzer/src/dialyzer.erl
+++ b/lib/dialyzer/src/dialyzer.erl
@@ -313,8 +313,8 @@ message_to_string({app_call, [M, F, Args, Culprit, ExpectedType, FoundType]},
 		[M, F, a(Args, I), c(Culprit, I),
                  t(ExpectedType, I), t(FoundType, I)]);
 message_to_string({bin_construction, [Culprit, Size, Seg, Type]}, I) ->
-  io_lib:format("Binary construction will fail since the ~s field ~s in"
-		" segment ~s has type ~s\n",
+  io_lib:format("Binary construction will fail since the ~ts field ~ts in"
+		" segment ~ts has type ~ts\n",
                 [Culprit, c(Size, I), c(Seg, I), t(Type, I)]);
 message_to_string({call, [M, F, Args, ArgNs, FailReason,
 			  SigArgs, SigRet, Contract]}, I) ->
diff --git a/lib/dialyzer/test/small_SUITE_data/results/gh_7153 b/lib/dialyzer/test/small_SUITE_data/results/gh_7153
new file mode 100644
index 0000000000..c596a89f82
--- /dev/null
+++ b/lib/dialyzer/test/small_SUITE_data/results/gh_7153
@@ -0,0 +1,3 @@
+
+gh_7153.erl:4:1: Function t/1 has no local return
+gh_7153.erl:5:7: Binary construction will fail since the value field X in segment X/utf8 has type '原子'
diff --git a/lib/dialyzer/test/small_SUITE_data/src/gh_7153.erl b/lib/dialyzer/test/small_SUITE_data/src/gh_7153.erl
new file mode 100644
index 0000000000..ef2ef3a25b
--- /dev/null
+++ b/lib/dialyzer/test/small_SUITE_data/src/gh_7153.erl
@@ -0,0 +1,5 @@
+-module(gh_7153).
+-export([t/1]).
+
+t(X = '原子') ->
+    <<X/utf8>>.
-- 
2.35.3

Places

File 1252-dialyzer-Fix-crash-on-formatting-warning-containing-.patch of Package erlang (Revision 0e18a0502cc8ec77c7a8a467e24ca42a)

Places