File 4351-Document-squashing-of-smaller-changes-in-C... of Package erlang

Overview Repositories Revisions Requests Users Attributes Meta

File 4351-Document-squashing-of-smaller-changes-in-CONTRIBUTIN.patch of Package erlang (Revision b4f72044e1af8cfe32130ab849a401a1)

Currently displaying revision b4f72044e1af8cfe32130ab849a401a1 , Show latest

From 5f14b480dbaed00b4e76c5e398688db313576e0e Mon Sep 17 00:00:00 2001
From: Johannes Christ <jc@jchri.st>
Date: Wed, 31 May 2023 17:12:02 +0200
Subject: [PATCH] Document squashing of smaller changes in CONTRIBUTING

Via https://github.com/erlang/otp/pull/7293#issuecomment-1568293651, I
figured this may be valuable to have in the contributing docs as well.
---
 CONTRIBUTING.md | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md
index 0d7588d35c..120a14ae8a 100644
--- a/CONTRIBUTING.md
+++ b/CONTRIBUTING.md
@@ -154,7 +154,7 @@ If you want to change the setting only for the Erlang mode, you can use a hook l
 ### After you have submitted your pull request
 
 * Follow the discussion following your pull request, answer questions, discuss and implement
-changes requested by reviewers.
+changes requested by reviewers. Smaller changes should be squashed into their associated commits.
 
 * If your pull requests introduces new public functions, they need to be tagged with the
 OTP release in which they _will_ appear in the `since` tag in the functions' documentation.
-- 
2.35.3

Places

File 4351-Document-squashing-of-smaller-changes-in-CONTRIBUTIN.patch of Package erlang (Revision b4f72044e1af8cfe32130ab849a401a1)

Places