File 6891-beam_validator-Skip-unnecessary-type-updat... of Package erlang

Overview Repositories Revisions Requests Users Attributes Meta

File 6891-beam_validator-Skip-unnecessary-type-updates.patch of Package erlang (Revision 1e94e72e3f4fed1ca9cd5c2fd777ed02)

Currently displaying revision 1e94e72e3f4fed1ca9cd5c2fd777ed02 , Show latest

From e18a83f3d80882b2facc470f2437d6b31511e829 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?John=20H=C3=B6gberg?= <john@erlang.org>
Date: Fri, 3 Mar 2023 13:18:29 +0100
Subject: [PATCH] beam_validator: Skip unnecessary type updates

---
 lib/compiler/src/beam_validator.erl        |  2 ++
 lib/compiler/test/beam_validator_SUITE.erl | 19 +++++++++++++++++--
 2 files changed, 19 insertions(+), 2 deletions(-)

diff --git a/lib/compiler/src/beam_validator.erl b/lib/compiler/src/beam_validator.erl
index 98eacce0fc..b38d288f99 100644
--- a/lib/compiler/src/beam_validator.erl
+++ b/lib/compiler/src/beam_validator.erl
@@ -2299,6 +2299,8 @@ update_type(Merge, With, #value_ref{}=Ref, Vst0) ->
     case Merge(Current, With) of
         none ->
             throw({type_conflict, Current, With});
+        Current ->
+            Vst0;
         Type ->
             Vst = update_container_type(Type, Ref, Vst0),
             set_type(Type, Ref, Vst)
diff --git a/lib/compiler/test/beam_validator_SUITE.erl b/lib/compiler/test/beam_validator_SUITE.erl
index 64a356c7e4..aba3b8dfe2 100644
--- a/lib/compiler/test/beam_validator_SUITE.erl
+++ b/lib/compiler/test/beam_validator_SUITE.erl
@@ -41,7 +41,8 @@
          missing_return_type/1,will_bif_succeed/1,
          bs_saved_position_units/1,parent_container/1,
          container_performance/1,
-         not_equal_inference/1,singleton_inference/1]).
+         not_equal_inference/1,singleton_inference/1,
+         inert_update_type/1]).
 
 -include_lib("common_test/include/ct.hrl").
 
@@ -77,7 +78,8 @@ groups() ->
        missing_return_type,will_bif_succeed,
        bs_saved_position_units,parent_container,
        container_performance,
-       not_equal_inference,singleton_inference]}].
+       not_equal_inference,singleton_inference,
+       inert_update_type]}].
 
 init_per_suite(Config) ->
     test_lib:recompile(?MODULE),
@@ -1025,5 +1027,18 @@ singleton_inference(Config) ->
 
     ok.
 
+%% GH-6969: A type was made concrete even though that added no additional
+%% information.
+inert_update_type(_Config) ->
+    hello(<<"string">>, id(42)).
+
+hello(A, B) ->
+    mike([{sys_period, {A, B}}, {some_atom, B}]).
+
+mike([Head | _Rest]) -> joe(Head).
+
+joe({Name, 42}) -> Name;
+joe({sys_period, {A, _B}}) -> {41, 42, A}.
+
 id(I) ->
     I.
-- 
2.35.3

Places

File 6891-beam_validator-Skip-unnecessary-type-updates.patch of Package erlang (Revision 1e94e72e3f4fed1ca9cd5c2fd777ed02)

Places