File 6091-Eliminate-make-warning-about-ignored-old-recipe.patch of Package erlang
From fd898d5a26ebaae16c2cbe4f8bee29f835f6c419 Mon Sep 17 00:00:00 2001 From: Frej Drejhammar <frej.drejhammar@gmail.com> Date: Thu, 6 Apr 2023 08:35:34 +0200 Subject: [PATCH] Eliminate make warning about ignored old recipe The makefiles for lib/compiler/ and lib/stdlib/ both include $(ERL_TOP)/make/app_targets.mk and defines their own `test` target. As this leads to warnings about: Makefile:48: warning: overriding recipe for target 'test' $ERL_TOP/make/app_targets.mk:26:warning: ignoring old recipe for target 'test' which are annoying as even a clean build produces warnings, this patch conditionally avoids defining the default target in app_targets.mk when included from lib/compiler/Makefile and lib/stdlib/Makefile. --- lib/compiler/Makefile | 1 + lib/stdlib/Makefile | 1 + make/app_targets.mk | 2 ++ 3 files changed, 4 insertions(+) diff --git a/lib/compiler/Makefile b/lib/compiler/Makefile index a7d896f258..9394129f02 100644 --- a/lib/compiler/Makefile +++ b/lib/compiler/Makefile @@ -38,6 +38,7 @@ include $(ERL_TOP)/make/otp_subdir.mk DIA_PLT_APPS=crypto +NO_TEST_TARGET:=1 # Avoid warning about ignoring old recipe for target 'test' include $(ERL_TOP)/make/app_targets.mk # Enable feature maybe_expr in runtime when running tests diff --git a/lib/stdlib/Makefile b/lib/stdlib/Makefile index f1db3c77e3..f1a72cd6b9 100644 --- a/lib/stdlib/Makefile +++ b/lib/stdlib/Makefile @@ -39,6 +39,7 @@ include $(ERL_TOP)/make/otp_subdir.mk DIA_PLT_APPS=compiler crypto TEST_NEEDS_RELEASE=true +NO_TEST_TARGET:=1 # Avoid warning about ignoring old recipe for target 'test' include $(ERL_TOP)/make/app_targets.mk # Enable feature maybe_expr in runtime when running tests. diff --git a/make/app_targets.mk b/make/app_targets.mk index 2bf1421f80..64a5c47dfa 100644 --- a/make/app_targets.mk +++ b/make/app_targets.mk @@ -22,9 +22,11 @@ APPLICATION ?= $(basename $(notdir $(PWD))) .PHONY: test info gclean dialyzer dialyzer_plt dclean +ifndef NO_TEST_TARGET test: TEST_NEEDS_RELEASE=$(TEST_NEEDS_RELEASE) TYPE=$(TYPE) MAKE="$(MAKE)" \ $(ERL_TOP)/make/test_target_script.sh $(ERL_TOP) +endif info: @echo "$(APPLICATION)_VSN: $(VSN)" -- 2.35.3
