File 1049-mnesia-make-tests-compile-without-warnings.patch of Package erlang
From 70bb4ccdb56057e20b5a2d79659d95a7993494aa Mon Sep 17 00:00:00 2001
From: Dan Gudmundsson <dgud@erlang.org>
Date: Wed, 17 Dec 2025 15:57:44 +0100
Subject: [PATCH 2/2] mnesia: make tests compile without warnings
---
lib/mnesia/test/Makefile | 2 +-
lib/mnesia/test/ext_test.erl | 6 ++--
lib/mnesia/test/ext_test_server.erl | 34 +++++++++----------
lib/mnesia/test/mnesia_dirty_access_test.erl | 26 +++++++-------
lib/mnesia/test/mnesia_evil_coverage_test.erl | 2 ++
lib/mnesia/test/mnesia_isolation_test.erl | 4 +--
lib/mnesia/test/mnesia_registry_test.erl | 2 ++
7 files changed, 40 insertions(+), 36 deletions(-)
diff --git a/lib/mnesia/test/Makefile b/lib/mnesia/test/Makefile
index e07f7063af..02d5e6c43b 100644
--- a/lib/mnesia/test/Makefile
+++ b/lib/mnesia/test/Makefile
@@ -92,7 +92,7 @@ RELSYSDIR = $(RELEASE_PATH)/mnesia_test
# ----------------------------------------------------
# FLAGS
# ----------------------------------------------------
-#ERL_COMPILE_FLAGS +=
+ERL_COMPILE_FLAGS += +nowarn_missing_spec_documented -Werror
ERL_COMPILE_FLAGS := $(filter-out +deterministic,$(ERL_COMPILE_FLAGS))
EBIN = .
diff --git a/lib/mnesia/test/ext_test.erl b/lib/mnesia/test/ext_test.erl
index 7d57955511..5ba346bd7c 100644
--- a/lib/mnesia/test/ext_test.erl
+++ b/lib/mnesia/test/ext_test.erl
@@ -121,7 +121,7 @@ delete_table(Alias, Tab) ->
try error_if_not_initialized() of
ok ->
call({?FUNCTION_NAME, Alias, Tab})
- catch error : {backend_not_initialized, _} = Reason ->
+ catch error : {backend_not_initialized, _} ->
ok
end.
@@ -253,8 +253,8 @@ repair_continuation(Cont, Ms) ->
call(Req) ->
error_if_not_initialized(),
case gen_server:call({global, mnesia_test_lib:get_ext_test_server_name()}, Req) of
- #exception{c = Class, r = Reason, st = ST} = Ex ->
- ?DBG("call ~p resulted in an exception: ~p~n", [Req, Ex]),
+ #exception{c = Class, r = Reason, st = ST} = _Ex ->
+ ?DBG("call ~p resulted in an exception: ~p~n", [Req, _Ex]),
erlang:raise(Class, Reason, ST);
Res ->
Res
diff --git a/lib/mnesia/test/ext_test_server.erl b/lib/mnesia/test/ext_test_server.erl
index 22a1ec8f0a..d806a09734 100644
--- a/lib/mnesia/test/ext_test_server.erl
+++ b/lib/mnesia/test/ext_test_server.erl
@@ -41,8 +41,8 @@ init(_) ->
create_table(ext_ram_copies, Tab, Props, #state{tables = Tables} = State) when is_atom(Tab) ->
case maps:get(Tab, Tables, undefined) of
- #table{state = opened, tid = Tid} ->
- ?DBG("create_table, Alias: ext_ram_copies, Tab: ~p(~p) is already opened~n", [tab_to_list(Tab), Tid]),
+ #table{state = opened, tid = _Tid} ->
+ ?DBG("create_table, Alias: ext_ram_copies, Tab: ~p(~p) is already opened~n", [tab_to_list(Tab), _Tid]),
{ok, State};
_ ->
?DBG("create_table, Alias: ext_ram_copies, Tab: ~p~n", [tab_to_list(Tab)]),
@@ -62,10 +62,10 @@ create_table(ext_disc_only_copies, Tab, Props, #state{tables = Tables} = State)
?DBG("create_table Alias: ext_disc_only_copies after dets:open_file, Tab: ~p~n", [tab_to_list(Tab)]),
{ok, State#state{tables = maps:put(Tab, #table{state = opened, tid = Tab}, Tables)}}
end;
-create_table(ext_ram_copies, Tag={Tab, index, {_Where, Type}}, _Opts, #state{tables = Tables} = State) ->
+create_table(ext_ram_copies, Tag={_Tab, index, {_Where, Type}}, _Opts, #state{tables = Tables} = State) ->
case maps:get(Tag, Tables, undefined) of
- #table{state = opened, tid = Tid} ->
- ?DBG("create_table, Alias: ext_ram_copies, Tab: ~p(~p) is already opened~n", [tab_to_list(Tag), Tid]),
+ #table{state = opened, tid = _Tid} ->
+ ?DBG("create_table, Alias: ext_ram_copies, Tab: ~p(~p) is already opened~n", [tab_to_list(Tag), _Tid]),
{ok, State};
_ ->
?DBG("create_table, Alias: ext_ram_copies, Tab: ~p~n", [tab_to_list(Tag)]),
@@ -73,7 +73,7 @@ create_table(ext_ram_copies, Tag={Tab, index, {_Where, Type}}, _Opts, #state{tab
?DBG("create_table, Alias, ext_ram_copies, Tab: ~p(~p)~n", [tab_to_list(Tag), Tid]),
{ok, State#state{tables = maps:put(Tag, #table{state = opened, tid = Tid}, Tables)}}
end;
-create_table(ext_disc_only_copies, Tag={Tab, index, {_Where, Type}}, _Opts, #state{tables = Tables} = State) ->
+create_table(ext_disc_only_copies, Tag={_Tab, index, {_Where, Type}}, _Opts, #state{tables = Tables} = State) ->
case maps:get(Tag, Tables, undefined) of
#table{state = opened, tid = Tag} ->
?DBG("create_table, Alias: ext_disc_only_copies, Tab: ~p(~p) is already opened~n", [tab_to_list(Tag), Tag]),
@@ -85,10 +85,10 @@ create_table(ext_disc_only_copies, Tag={Tab, index, {_Where, Type}}, _Opts, #sta
?DBG("create_table Alias: ext_disc_only_copies after dets:open_file, Tab: ~p~n", [tab_to_list(Tag)]),
{ok, State#state{tables = maps:put(Tag, #table{state = opened, tid = Tag}, Tables)}}
end;
-create_table(ext_ram_copies, Tag={_Tab, retainer, ChkPName}, _Opts, #state{tables = Tables} = State) ->
+create_table(ext_ram_copies, Tag={_Tab, retainer, _ChkPName}, _Opts, #state{tables = Tables} = State) ->
case maps:get(Tag, Tables, undefined) of
- #table{state = opened, tid = Tid} ->
- ?DBG("create_table, Alias: ext_ram_copies, Tab: ~p(~p) is already opened~n", [tab_to_list(Tag), Tid]),
+ #table{state = opened, tid = _Tid} ->
+ ?DBG("create_table, Alias: ext_ram_copies, Tab: ~p(~p) is already opened~n", [tab_to_list(Tag), _Tid]),
{ok, State};
_ ->
?DBG("create_table, Alias: ext_ram_copies, Tab: ~p~n", [tab_to_list(Tag)]),
@@ -96,7 +96,7 @@ create_table(ext_ram_copies, Tag={_Tab, retainer, ChkPName}, _Opts, #state{table
?DBG("create_table, Alias, ext_ram_copies, Tab: ~p(~p)~n", [tab_to_list(Tag), Tid]),
{ok, State#state{tables = maps:put(Tag, #table{state = opened, tid = Tid}, Tables)}}
end;
-create_table(ext_disc_only_copies, Tag={_Tab, retainer, ChkPName}, _Opts, #state{tables = Tables} = State) ->
+create_table(ext_disc_only_copies, Tag={_Tab, retainer, _ChkPName}, _Opts, #state{tables = Tables} = State) ->
case maps:get(Tag, Tables, undefined) of
#table{state = opened, tid = Tag} ->
?DBG("create_table, Alias: ext_disc_only_copies, Tab: ~p(~p) is already opened~n", [tab_to_list(Tag), Tag]),
@@ -109,15 +109,15 @@ create_table(ext_disc_only_copies, Tag={_Tab, retainer, ChkPName}, _Opts, #state
{ok, State#state{tables = maps:put(Tag, #table{state = opened, tid = Tag}, Tables)}}
end.
-receive_data(Data, ext_ram_copies, Name, Sender, {Name, Tab, Sender} = MnesiaState, State) ->
+receive_data(Data, ext_ram_copies, Name, Sender, {Name, Tab, Sender} = _MnesiaState, State) ->
?DBG({Data, ext_ram_copies, Name, Sender, {Name, tab_to_list(Tab), Sender}}),
true = ets:insert(tab_to_tid(Tab, State), Data),
{more, State};
-receive_data(Data, ext_disc_only_copies, Name, Sender, {Name, Tab, Sender} = MnesiaState, State) ->
+receive_data(Data, ext_disc_only_copies, Name, Sender, {Name, Tab, Sender} = _MnesiaState, State) ->
?DBG({Data, ext_disc_only_copies, Name, Sender, {Name, tab_to_list(Tab), Sender}}),
ok = dets:insert(tab_to_tid(Tab, State), Data),
{more, State};
-receive_data(Data, Alias, Tab, Sender, {Name, Sender} = MnesiaState, State) ->
+receive_data(Data, Alias, Tab, Sender, {Name, Sender} = _MnesiaState, State) ->
?DBG({Data, Alias, tab_to_list(Tab), State}),
receive_data(Data, Alias, Tab, Sender, {Name, Tab, Sender}, State).
@@ -162,7 +162,7 @@ handle_call({delete_table, ext_ram_copies, Tab}, _From, #state{tables = Tables}
case ?TRY(ets:delete(Tid)) of
#exception{} = Res ->
{reply, Res, State};
- Res ->
+ _Res ->
NewState = State#state{tables = maps:remove(Tab, Tables)},
{reply, ok, NewState}
end;
@@ -395,8 +395,8 @@ handle_call({repair_continuation, ext_ram_copies, Cont, Ms}, _From, State) ->
Res = ?TRY(ets:repair_continuation(Cont, Ms)),
{reply, Res, State}.
-terminate(Reason, _State) ->
- ?DBG(Reason).
+terminate(_Reason, _State) ->
+ ?DBG(_Reason).
code_change(_OldVsn, State, _Extra) ->
{ok, State}.
@@ -425,4 +425,4 @@ tab_to_filename(Tab) ->
tab_to_tid(Tab, #state{tables = Tables}) ->
Table = maps:get(Tab, Tables),
- Table#table.tid.
\ No newline at end of file
+ Table#table.tid.
diff --git a/lib/mnesia/test/mnesia_dirty_access_test.erl b/lib/mnesia/test/mnesia_dirty_access_test.erl
index 6ba2dd80c9..c7b32881bb 100644
--- a/lib/mnesia/test/mnesia_dirty_access_test.erl
+++ b/lib/mnesia/test/mnesia_dirty_access_test.erl
@@ -919,19 +919,19 @@ add_table(CallFrom, AddNode, [Node1, Node2, Node3], Def) ->
?verify_mnesia([Node1, Node2, Node3], []).
-tracer({trace_ts, From, send, Msg, To, {_,S,Ms}}) ->
- io:format("~p:~p ~p(~p) >>~p ~w ~n",[S,Ms,From,node(From),To,Msg]);
-tracer({trace_ts, Pid, 'receive', Msg, {_,S,Ms}}) ->
- io:format("~p:~p ~p(~p) << ~w ~n",[S,Ms,Pid,node(Pid),Msg]);
-
-tracer({trace_ts, Pid, call, MFA, ST, {_,S,Ms}}) ->
- io:format("~p:~p ~p(~p) ~w ~w ~n",[S,Ms,Pid,node(Pid),MFA, ST]);
-tracer({trace_ts, Pid, return_from, MFA, Ret, {_,S,Ms}}) ->
- io:format("~p:~p ~p(~p) ~w => ~w ~n",[S,Ms,Pid,node(Pid),MFA,Ret]);
-
-tracer(Msg) ->
- io:format("UMsg ~p ~n",[Msg]),
- ok.
+%% tracer({trace_ts, From, send, Msg, To, {_,S,Ms}}) ->
+%% io:format("~p:~p ~p(~p) >>~p ~w ~n",[S,Ms,From,node(From),To,Msg]);
+%% tracer({trace_ts, Pid, 'receive', Msg, {_,S,Ms}}) ->
+%% io:format("~p:~p ~p(~p) << ~w ~n",[S,Ms,Pid,node(Pid),Msg]);
+
+%% tracer({trace_ts, Pid, call, MFA, ST, {_,S,Ms}}) ->
+%% io:format("~p:~p ~p(~p) ~w ~w ~n",[S,Ms,Pid,node(Pid),MFA, ST]);
+%% tracer({trace_ts, Pid, return_from, MFA, Ret, {_,S,Ms}}) ->
+%% io:format("~p:~p ~p(~p) ~w => ~w ~n",[S,Ms,Pid,node(Pid),MFA,Ret]);
+
+%% tracer(Msg) ->
+%% io:format("UMsg ~p ~n",[Msg]),
+%% ok.
move_table_copy_1(suite) -> [];
diff --git a/lib/mnesia/test/mnesia_evil_coverage_test.erl b/lib/mnesia/test/mnesia_evil_coverage_test.erl
index 7c470f3c49..f77fe5443a 100644
--- a/lib/mnesia/test/mnesia_evil_coverage_test.erl
+++ b/lib/mnesia/test/mnesia_evil_coverage_test.erl
@@ -51,6 +51,8 @@
-export([info_check/8, index_size/1]).
+-compile({nowarn_deprecated_function, {mnesia_registry, create_table, 2}}).
+
-define(cleanup(N, Config),
mnesia_test_lib:prepare_test_case([{reload_appls, [mnesia]}],
N, Config, ?FILE, ?LINE)).
diff --git a/lib/mnesia/test/mnesia_isolation_test.erl b/lib/mnesia/test/mnesia_isolation_test.erl
index 759735a7ea..792a300f14 100644
--- a/lib/mnesia/test/mnesia_isolation_test.erl
+++ b/lib/mnesia/test/mnesia_isolation_test.erl
@@ -629,8 +629,8 @@ sticky_sync(Config) when is_list(Config) ->
end,
%% Fill 1000 dc records. At the end all dc records should have value 1.
- {Time, ok} = timer:tc(fun() -> lists:foreach(TestFun, lists:seq(1,200)) end),
- io:format("Written, check content~n",[]),
+ {_Time, ok} = timer:tc(fun() -> lists:foreach(TestFun, lists:seq(1,200)) end),
+ io:format("Written, check content ~w~n",[_Time]),
All = fun() -> mnesia:select(dc, [ {{dc, '_', 0}, [] ,['$_']} ]) end,
?match({atomic, []}, rpc:call(N1, mnesia, sync_transaction, [All])),
?match({atomic, []}, rpc:call(N2, mnesia, sync_transaction, [All])),
diff --git a/lib/mnesia/test/mnesia_registry_test.erl b/lib/mnesia/test/mnesia_registry_test.erl
index c15b8e97af..a8b8742d57 100644
--- a/lib/mnesia/test/mnesia_registry_test.erl
+++ b/lib/mnesia/test/mnesia_registry_test.erl
@@ -29,6 +29,8 @@
-include("mnesia_test_lib.hrl").
+-compile(nowarn_deprecated_function).
+
init_per_testcase(Func, Conf) ->
mnesia_test_lib:init_per_testcase(Func, Conf).
--
2.51.0
