File 4125-megaco-Fixed-megaco-call-3-send-options.patch of Package erlang

Overview Repositories Revisions Requests Users Attributes Meta

File 4125-megaco-Fixed-megaco-call-3-send-options.patch of Package erlang (Revision 0cb618c74ff829b74bc5c7e672295bed)

Currently displaying revision 0cb618c74ff829b74bc5c7e672295bed , Show latest

From ebbbe79ff5a66540ccafc4b74c001bcdaa1bec32 Mon Sep 17 00:00:00 2001
From: Micael Karlberg <bmk@erlang.org>
Date: Thu, 21 Dec 2023 12:53:37 +0100
Subject: [PATCH 05/46] [megaco] Fixed megaco:call/3 send options

Moved the send options argument description to the function.

OTP-18920
---
 lib/megaco/doc/src/megaco.xml | 11 -----------
 lib/megaco/src/app/megaco.erl | 14 +++++++-------
 2 files changed, 7 insertions(+), 18 deletions(-)

diff --git a/lib/megaco/doc/src/megaco.xml b/lib/megaco/doc/src/megaco.xml
index 9a022a08f0..ea9e704852 100644
--- a/lib/megaco/doc/src/megaco.xml
+++ b/lib/megaco/doc/src/megaco.xml
@@ -158,17 +158,6 @@
       -->
     </datatype>
 
-    <datatype>
-      <name name="send_option"/>
-      
-    </datatype>
-
     <datatype>
       <name name="send_handle"/>
       <desc>
diff --git a/lib/megaco/src/app/megaco.erl b/lib/megaco/src/app/megaco.erl
index 5d0b165cc8..1b3a15a414 100644
--- a/lib/megaco/src/app/megaco.erl
+++ b/lib/megaco/src/app/megaco.erl
@@ -128,11 +128,6 @@
 
 -type action_reqs()       :: binary() | [action_request()].
 -type action_reps()       :: [action_reply()].
--type send_option()       :: {request_timer,         megaco_timer()} |
-                             {long_request_timer,    megaco_timer()} |
-                             {send_handle,           send_handle()} |
-                             {protocol_version,      protocol_version()} |
-                             {call_proxy_gc_timeout, non_neg_integer()}.
 -type send_handle()       :: term().
 
 
@@ -314,11 +309,16 @@ disconnect(ConnHandle, Reason) ->
 %% Sends a transaction request and waits for a reply
 %%-----------------------------------------------------------------
 
--spec call(ConnHandle, ActionRequests, Options) ->
+-spec call(ConnHandle, ActionRequests, SendOptions) ->
           {ProtocolVersion, UserReply | [UserReply]} when
       ConnHandle          :: conn_handle(),
       ActionRequests      :: action_reqs() | [action_reqs()],
-      Options             :: [send_option()],
+      SendOptions         :: [SendOption],
+      SendOption          :: {request_timer,         megaco_timer()} |
+                             {long_request_timer,    megaco_timer()} |
+                             {send_handle,           send_handle()} |
+                             {protocol_version,      protocol_version()} |
+                             {call_proxy_gc_timeout, non_neg_integer()},
       ProtocolVersion     :: protocol_version(),
       UserReply           :: Success | Failure,
       Success             :: {ok, Result} | {ok, Result, SuccessExtra},
-- 
2.35.3

Places

File 4125-megaco-Fixed-megaco-call-3-send-options.patch of Package erlang (Revision 0cb618c74ff829b74bc5c7e672295bed)

Places