File 4164-megaco-Types-and-spec-for-megaco_flex_scan... of Package erlang

Overview Repositories Revisions Requests Users Attributes Meta

File 4164-megaco-Types-and-spec-for-megaco_flex_scanner-start-.patch of Package erlang (Revision 6af34d10e5fc1c974d15399d1aade82a)

Currently displaying revision 6af34d10e5fc1c974d15399d1aade82a , Show latest

From e0bfe979b0457e44fe49a081020af2c67af2e719 Mon Sep 17 00:00:00 2001
From: Micael Karlberg <bmk@erlang.org>
Date: Mon, 8 Jan 2024 17:00:15 +0100
Subject: [PATCH 44/46] [megaco] Types and spec for megaco_flex_scanner:start/0

OTP-18920
---
 lib/megaco/doc/src/megaco_flex_scanner.xml    | 22 +++----------------
 lib/megaco/src/flex/megaco_flex_scanner.erl   |  4 ++++
 .../src/flex/megaco_flex_scanner_handler.erl  |  4 +---
 3 files changed, 8 insertions(+), 22 deletions(-)

diff --git a/lib/megaco/doc/src/megaco_flex_scanner.xml b/lib/megaco/doc/src/megaco_flex_scanner.xml
index 31ee7285bb..643590615e 100644
--- a/lib/megaco/doc/src/megaco_flex_scanner.xml
+++ b/lib/megaco/doc/src/megaco_flex_scanner.xml
@@ -84,12 +84,8 @@ megaco_version() = integer() >= 1
 
 <funcs>
 <func>
- <name since="">start() -> {ok, PortOrPorts} | {error, Reason}</name>
+ <name name="start" arity="0" clause_i="1" since=""/>
 <fsummary></fsummary>
- <type>
- <v>PortOrPorts = megaco_ports()</v>
- <v>Reason = term()</v>
- </type>
 <desc>
 This function is used to start the flex scanner. 
 	It locates the library and loads the linked in driver.
@@ -158,22 +154,10 @@ megaco_version() = integer() >= 1
 
 <func>
 <name name="scan" arity="2" clause_i="1" since=""/>
- 
 <fsummary></fsummary>
- 
 <desc>
- Scans a megaco message and generates a token list to be passed on the parser. 
+	Scans a megaco message and generates a token list to
+	be passed on the parser. 
 </desc>
 </func>
 
diff --git a/lib/megaco/src/flex/megaco_flex_scanner.erl b/lib/megaco/src/flex/megaco_flex_scanner.erl
index 721da4a89e..dbf4e4b52f 100644
--- a/lib/megaco/src/flex/megaco_flex_scanner.erl
+++ b/lib/megaco/src/flex/megaco_flex_scanner.erl
@@ -106,6 +106,10 @@ is_own_port(Port, N, Ports) when (N > 0) ->
 %% Start the flex scanner
 %%----------------------------------------------------------------------
 
+-spec start() -> {ok, PortOrPorts} | {error, Reason} when
+ PortOrPorts :: megaco_ports(),
+ Reason :: term().
+
 start() ->
 start(?SMP_SUPPORT_DEFAULT()).
 
diff --git a/lib/megaco/src/flex/megaco_flex_scanner_handler.erl b/lib/megaco/src/flex/megaco_flex_scanner_handler.erl
index c478332e1c..e6dc5571fa 100644
--- a/lib/megaco/src/flex/megaco_flex_scanner_handler.erl
+++ b/lib/megaco/src/flex/megaco_flex_scanner_handler.erl
@@ -93,9 +93,7 @@ init(_Opts) ->
 	 {ok, #state{conf = {flex, PortOrPorts}}};
 	{error, Reason} ->
 	 %% {stop, {failed_starting_scanner, Reason, Opts}};
-	 {stop, {failed_starting_scanner, Reason, []}};
-	Else ->
-	 {stop, {failed_starting_scanner, Else}}
+	 {stop, {failed_starting_scanner, Reason, []}}
 end.
 
 
-- 
2.35.3

Places

File 4164-megaco-Types-and-spec-for-megaco_flex_scanner-start-.patch of Package erlang (Revision 6af34d10e5fc1c974d15399d1aade82a)

Places