File kmscon_PR69.patch of Package kmscon_fork

Overview Repositories Revisions Requests Users Attributes Meta

File kmscon_PR69.patch of Package kmscon_fork

From 21cf668c58867a100272adea6f323cd56fc73e78 Mon Sep 17 00:00:00 2001
From: Arseny Maslennikov <ar@cs.msu.ru>
Date: Thu, 16 Sep 2021 21:31:01 +0300
Subject: [PATCH 1/3] units: Call /sbin/agetty instead of /bin/login

The versions of /bin/login usually present in Linux distros are actually
security tools; they do not really fit in too well as the login prompt.
For instance, the one used in Debian (from shadow-utils), while
prompting the user to input a username, terminates if the return key was
not pressed for 2 minutes, and does not process /etc/issue at all.

agetty itself is a bit overkill, and it would be best for util-linux to
provide a stripped-down version for VTs/pseudoterminals which does not
care about baudrates and other attributes of hardware terminals and
serial connections, but agetty works, so we use it.

The "-- -" at the end of the agetty command lines instead of a tty name
means "use the pts passed on standard input".

Following the principle of least surprise, we more or less match the
agetty invocation in container-getty@.service bundled with systemd.

Link: https://github.com/systemd/systemd/blob/219fa78b5fa2ec9c13dd87419366116e3197693f/units/container-getty%40.service.in
---
 docs/kmscon.service.in    | 2 +-
 docs/kmsconvt@.service.in | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/docs/kmscon.service.in b/docs/kmscon.service.in
index c29fe92..543463b 100644
--- a/docs/kmscon.service.in
+++ b/docs/kmscon.service.in
@@ -3,7 +3,7 @@ Description=KMS System Console
 Documentation=man:kmscon(1)
 
 [Service]
-ExecStart=@bindir@/kmscon -l /bin/login
+ExecStart=@bindir@/kmscon --login -- /sbin/agetty -o '-p -- \\u' --noclear -- -
 
 [Install]
 WantedBy=multi-user.target
diff --git a/docs/kmsconvt@.service.in b/docs/kmsconvt@.service.in
index 84b66bf..8bf56db 100644
--- a/docs/kmsconvt@.service.in
+++ b/docs/kmsconvt@.service.in
@@ -37,7 +37,7 @@ IgnoreOnIsolate=yes
 ConditionPathExists=/dev/tty0
 
 [Service]
-ExecStart=@bindir@/kmscon "--vt=%I" --seats=seat0 --no-switchvt
+ExecStart=@bindir@/kmscon --vt=%I --seats=seat0 --no-switchvt --login -- /sbin/agetty -o '-p -- \\u' --noclear -- -
 UtmpIdentifier=%I
 TTYPath=/dev/%I
 TTYReset=yes

From 3df03c33ab859705e815908758ed3645a8f6cc87 Mon Sep 17 00:00:00 2001
From: Arseny Maslennikov <ar@cs.msu.ru>
Date: Sat, 4 Mar 2023 20:26:42 +0300
Subject: [PATCH 2/3] units: Order ourselves after logins are possible

---
 docs/kmscon.service.in    | 2 ++
 docs/kmsconvt@.service.in | 1 +
 2 files changed, 3 insertions(+)

diff --git a/docs/kmscon.service.in b/docs/kmscon.service.in
index 543463b..cba1651 100644
--- a/docs/kmscon.service.in
+++ b/docs/kmscon.service.in
@@ -1,6 +1,8 @@
 [Unit]
 Description=KMS System Console
 Documentation=man:kmscon(1)
+After=systemd-user-sessions.service
+After=rc-local.service
 
 [Service]
 ExecStart=@bindir@/kmscon --login -- /sbin/agetty -o '-p -- \\u' --noclear -- -
diff --git a/docs/kmsconvt@.service.in b/docs/kmsconvt@.service.in
index 8bf56db..a496e26 100644
--- a/docs/kmsconvt@.service.in
+++ b/docs/kmsconvt@.service.in
@@ -30,6 +30,7 @@ Description=KMS System Console on %I
 Documentation=man:kmscon(1)
 After=systemd-user-sessions.service
 After=plymouth-quit-wait.service
+After=rc-local.service
 Before=getty.target
 Conflicts=getty@%i.service
 OnFailure=getty@%i.service

From 8f1f6f4ecebc141dac9a069e8a3ac3f504a7d35b Mon Sep 17 00:00:00 2001
From: Arseny Maslennikov <ar@cs.msu.ru>
Date: Sat, 4 Mar 2023 20:19:45 +0300
Subject: [PATCH 3/3] units: Order ourselves after plymouth

---
 docs/kmscon.service.in | 1 +
 1 file changed, 1 insertion(+)

diff --git a/docs/kmscon.service.in b/docs/kmscon.service.in
index cba1651..ad5600d 100644
--- a/docs/kmscon.service.in
+++ b/docs/kmscon.service.in
@@ -1,6 +1,7 @@
 [Unit]
 Description=KMS System Console
 Documentation=man:kmscon(1)
+After=plymouth-quit-wait.service
 After=systemd-user-sessions.service
 After=rc-local.service

Places

File kmscon_PR69.patch of Package kmscon_fork

Places