File firebird-gcc-warnings-fixes.patch of Package firebird
diff -ruN ../Firebird-2.1.2.18118-0/examples/empbuild/empbuild.e ./examples/empbuild/empbuild.e
--- ../Firebird-2.1.2.18118-0/examples/empbuild/empbuild.e 2005-12-09 18:17:25.000000000 +0800
+++ ./examples/empbuild/empbuild.e 2009-05-27 21:01:12.000000000 +0900
@@ -145,7 +145,7 @@
*
**************************************/
TEXT job_code[6], job_country[16];
-TEXT line[81];
+TEXT line[100]; //fixed destbufferoverflow
TEXT lang_array[5][16];
int i, job_grade, rec_cnt = 0;
@@ -211,7 +211,7 @@
*
**************************************/
TEXT job_code[6];
-TEXT line[82], job_country[16];
+TEXT line[100], job_country[16]; //fixed destbufferoverflow
int len;
ISC_QUAD job_blob;
int job_grade, rec_cnt = 0;
@@ -288,7 +288,7 @@
*
**************************************/
TEXT proj_id[6];
-TEXT line[82];
+TEXT line[100]; //fixed destbufferoverflow
int len;
ISC_QUAD proj_blob;
int rec_cnt = 0;
@@ -363,7 +363,7 @@
**************************************/
TEXT proj_id[6], dept_no[4];
int yr;
-TEXT line[81];
+TEXT line[100]; //fixed destbufferoverflow
int hcnt[4];
int rec_cnt = 0;
diff -ruN ../Firebird-2.1.2.18118-0/src/burp/restore.epp ./src/burp/restore.epp
--- ../Firebird-2.1.2.18118-0/src/burp/restore.epp 2008-12-06 00:30:07.000000000 +0800
+++ ./src/burp/restore.epp 2009-05-27 21:09:44.000000000 +0900
@@ -5574,6 +5574,7 @@
break;
}
}
+ return true; // fixed no-return-in-nonvoid-function
}
bool get_sql_roles(BurpGlobals* tdgbl)
diff -ruN ../Firebird-2.1.2.18118-0/src/qli/compile.cpp ./src/qli/compile.cpp
--- ../Firebird-2.1.2.18118-0/src/qli/compile.cpp 2007-02-22 17:58:56.000000000 +0800
+++ ./src/qli/compile.cpp 2009-05-27 21:23:02.000000000 +0900
@@ -865,7 +865,7 @@
qli_nod* list = node->nod_arg[e_fun_args];
- qli_nod** ptr = ptr = list->nod_arg;
+ qli_nod** ptr = list->nod_arg; //fixed undified operation, maybe
for (const qli_nod* const* const end = ptr + list->nod_count; ptr < end; ptr++)
compile_expression(*ptr, request, true);
diff -ruN ../Firebird-2.1.2.18118-0/src/qli/exe.h ./src/qli/exe.h
--- ../Firebird-2.1.2.18118-0/src/qli/exe.h 2004-05-25 02:20:44.000000000 +0900
+++ ./src/qli/exe.h 2009-05-27 21:55:22.000000000 +0900
@@ -38,7 +38,7 @@
const USHORT RLB_BUFFER_SIZE = 2048;
const USHORT RLB_SAFETY_MARGIN = 48;
-#define CHECK_RLB(in) (!in || (in->rlb_data > in->rlb_limit)) ? (in = GEN_rlb_extend (in)) : in;
+#define CHECK_RLB(in) (!in || (in->rlb_data > in->rlb_limit)) ? (GEN_rlb_extend (in)) : in; //fixed undefined operation
/* Would need gener_proto.h visible here to use this macro.
inline qli_rlb* CHECK_RLB(qli_rlb*& in)
{
diff -ruN ../Firebird-2.1.2.18118-0/src/utilities/drop.cpp ./src/utilities/drop.cpp
--- ../Firebird-2.1.2.18118-0/src/utilities/drop.cpp 2008-12-01 22:46:26.000000000 +0800
+++ ./src/utilities/drop.cpp 2009-05-29 10:24:35.000000000 +0900
@@ -223,7 +223,7 @@
if (!(strcmp(label, "lock manager"))) {
if (!(pid = vfork())) {
- execl(orig_argv[0], orig_argv[0], "-s", 0);
+ execl(orig_argv[0], orig_argv[0], "-s", NULL); //fixed missing-sentinel
_exit(FINI_ERROR);
}
// wait(pid) // this is wrong wait takes a *int anyway.
@@ -307,7 +307,7 @@
if (!(strcmp(label, "lock manager"))) {
if (!(pid = vfork())) {
- execl(orig_argv[0], orig_argv[0], "-s", 0);
+ execl(orig_argv[0], orig_argv[0], "-s", NULL); //fixed missing-sentinel
_exit(FINI_ERROR);
}
#ifdef SCO_EV /* 5.5 SCO Port: SCO needs waitpid() to function properly */