File 010-Rename-AppStream-metadata-to-rDNS-format.patch of Package virt-manager
Subject: Rename AppStream metadata to rDNS format
From: AsciiWolf mail@asciiwolf.com Fri Oct 3 13:42:54 2025 +0200
Date: Tue Nov 11 15:53:49 2025 +0100:
Git: 9e9252982dcb338fac46b2bf9dea88d625964e06
Use proper reverse DNS format for AppStream metadata id as recommended
by the spec. Also change the suffix to metainfo.xml and component type
to desktop-application
diff --git a/data/meson.build b/data/meson.build
index 360040db0..862e53836 100644
--- a/data/meson.build
+++ b/data/meson.build
@@ -2,7 +2,7 @@ fs = import('fs')
desktop_file = files('virt-manager.desktop.in')
-appdata_file = files('virt-manager.appdata.xml.in')
+metainfo_file = files('org.virt_manager.virt-manager.metainfo.xml.in')
install_data(
'org.virt-manager.virt-manager.gschema.xml',
diff --git a/data/virt-manager.appdata.xml.in b/data/org.virt_manager.virt-manager.metainfo.xml.in
similarity index 94%
rename from data/virt-manager.appdata.xml.in
rename to data/org.virt_manager.virt-manager.metainfo.xml.in
index 08bf01a5e..9554e4628 100644
--- a/data/virt-manager.appdata.xml.in
+++ b/data/org.virt_manager.virt-manager.metainfo.xml.in
@@ -1,6 +1,6 @@
<?xml version="1.0" encoding="UTF-8"?>
-<component type="desktop">
- <id>virt-manager.desktop</id>
+<component type="desktop-application">
+ <id>org.virt_manager.virt-manager</id>
<metadata_license>CC0-1.0</metadata_license>
<project_license>GPL-2.0+</project_license>
<name>Virtual Machine Manager</name>
@@ -39,6 +39,9 @@
<keyword>kvm</keyword>
</keywords>
<content_rating type="oars-1.1"/>
+ <provides>
+ <id>virt-manager.desktop</id>
+ </provides>
<launchable type="desktop-id">virt-manager.desktop</launchable>
<releases>
<release version="5.1.0" date="2025-08-26"/>
diff --git a/po/POTFILES b/po/POTFILES
index 5d5822898..ce332a702 100644
--- a/po/POTFILES
+++ b/po/POTFILES
@@ -1,4 +1,4 @@
-data/virt-manager.appdata.xml.in
+data/org.virt_manager.virt-manager.metainfo.xml.in
data/virt-manager.desktop.in
ui/about.ui
ui/addhardware.ui
diff --git a/po/meson.build b/po/meson.build
index 910909dd1..f3f029a21 100644
--- a/po/meson.build
+++ b/po/meson.build
@@ -10,7 +10,7 @@ i18n.merge_file(
)
i18n.merge_file(
- input: appdata_file,
+ input: metainfo_file,
output: '@BASENAME@',
type: 'xml',
po_dir: meson.current_source_dir(),
diff --git a/tests/meson.build b/tests/meson.build
index c1135a2b4..30f3c10e3 100644
--- a/tests/meson.build
+++ b/tests/meson.build
@@ -7,9 +7,9 @@ lint_files = [
spell_files = lint_files + [
'*.md',
'man/*.rst',
- 'data/virt-manager.appdata.xml.in',
- 'data/virt-manager.desktop.in',
'data/org.virt-manager.virt-manager.gschema.xml',
+ 'data/org.virt_manager.virt-manager.metainfo.xml.in',
+ 'data/virt-manager.desktop.in',
'virt-manager.spec.in',
]
diff --git a/tests/test_dist.py b/tests/test_dist.py
index cceb1a6ef..1b7dc1c74 100644
--- a/tests/test_dist.py
+++ b/tests/test_dist.py
@@ -120,4 +120,6 @@ def test_ui_translatable_atknames():
def test_appstream_validate():
- subprocess.check_call(["appstream-util", "validate", "data/virt-manager.appdata.xml.in"])
+ subprocess.check_call(
+ ["appstream-util", "validate", "data/org.virt_manager.virt-manager.metainfo.xml.in"]
+ )
diff --git a/virt-manager.spec.in b/virt-manager.spec.in
index 9e7fca30e..bac46d667 100644
--- a/virt-manager.spec.in
+++ b/virt-manager.spec.in
@@ -149,7 +149,7 @@ machine).
%{_datadir}/applications/%{name}.desktop
%{_datadir}/glib-2.0/schemas/org.virt-manager.virt-manager.gschema.xml
-%{_datadir}/metainfo/%{name}.appdata.xml
+%{_datadir}/metainfo/org.virt_manager.virt-manager.metainfo.xml
%files common -f %{name}.lang