File diskdump-Remove-page_size-override.patch of Package libkdumpfile.36085
From: Petr Tesarik <petr@tesarici.cz>
Date: Mon, 6 Nov 2023 20:17:47 +0100
Subject: diskdump: Remove page_size override
References: bsc#1223399
Upstream: merged
Git-commit: ae178dd1f098e484855356ccec7fbf7ff06aecb5
The page_size override was only necessary to reallocate the per-context
buffer for compressed data. With this buffer gone, also remove the
attribute override.
Signed-off-by: Petr Tesarik <ptesarik@suse.com>
---
src/kdumpfile/diskdump.c | 32 --------------------------------
1 file changed, 32 deletions(-)
--- a/src/kdumpfile/diskdump.c
+++ b/src/kdumpfile/diskdump.c
@@ -186,9 +186,6 @@ struct disk_dump_priv {
struct pfn_rgn *pfn_rgn; /**< PFN region map. */
size_t pfn_rgn_num; /**< Number of elements in the map. */
- /** Overridden methods for arch.page_size attribute. */
- struct attr_override page_size_override;
-
/** File offset mapping for flattened files. */
addrxlat_map_t *flatmap;
@@ -615,29 +612,6 @@ diskdump_get_page(kdump_ctx_t *ctx, stru
return cache_get_page(ctx, pio, diskdump_read_page);
}
-/** Reallocate buffer for compressed data.
- * @param ctx Dump file object.
- * @param attr "arch.page_size" attribute.
- * @returns Error status.
- *
- * This function is used as a post-set handler for @c arch.page_size
- * to ensure that there is always a sufficiently large buffer for
- * compressed pages.
- */
-static kdump_status
-diskdump_realloc_compressed(kdump_ctx_t *ctx, struct attr_data *attr)
-{
- const struct attr_ops *parent_ops;
- struct disk_dump_priv *ddp;
-
- ddp = ctx->shared->fmtdata;
-
- parent_ops = ddp->page_size_override.template.parent->ops;
- return (parent_ops && parent_ops->post_set)
- ? parent_ops->post_set(ctx, attr)
- : KDUMP_OK;
-}
-
static kdump_status
read_vmcoreinfo(kdump_ctx_t *ctx, off_t off, size_t size)
{
@@ -1011,10 +985,6 @@ init_private(kdump_ctx_t *ctx)
return set_error(ctx, KDUMP_ERR_SYSTEM,
"Cannot allocate diskdump private data");
- attr_add_override(gattr(ctx, GKI_page_size),
- &ddp->page_size_override);
- ddp->page_size_override.ops.post_set = diskdump_realloc_compressed;
-
ctx->shared->fmtdata = ddp;
return KDUMP_OK;
}
@@ -1240,8 +1210,6 @@ diskdump_attr_cleanup(struct attr_dict *
{
struct disk_dump_priv *ddp = dict->shared->fmtdata;
- attr_remove_override(dgattr(dict, GKI_page_size),
- &ddp->page_size_override);
}
static void
