File main-do-not-assign-NULL-if-that-value-is-not-used.patch of Package sispmctl
From: Heinrich Schuchardt <xypron.glpk@gmx.de>
Date: Fri Nov 15 17:23:09 2024 +0100
Subject: main: do not assign NULL if that value is not used
Patch-mainline: Not yet
Git-repo: https://git.code.sf.net/p/sispmctl/git
Git-commit: a86821b5ea0349afb019dbc6a2c072e78a183a2a
References:
Assigning NULL to a variable before assigning another value makes no sense
if the variable is not read in between.
Addresses-Coverity-ID: 512019 Unused value
Signed-off-by: Heinrich Schuchardt <xypron.glpk@gmx.de>
Signed-off-by: Egbert Eich <eich@suse.de>
---
src/main.c | 6 ++----
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/src/main.c b/src/main.c
index c2214e5..faa46a6 100644
--- a/src/main.c
+++ b/src/main.c
@@ -197,7 +197,7 @@ static void parse_command_line(int argc, char *argv[], int count,
int status;
int devnum = 0;
usb_dev_handle *udev = NULL;
- usb_dev_handle *sudev = NULL; //scan device
+ usb_dev_handle *sudev; //scan device
unsigned int id=0; //product id of current device
char *onoff[] = {"off", "on", "0", "1"};
#ifndef WEBLESS
@@ -316,7 +316,6 @@ static void parse_command_line(int argc, char *argv[], int count,
else
printf("%s\n", get_serial(sudev));
usb_close(sudev);
- sudev = NULL;
printf("\n");
}
break;
@@ -663,7 +662,7 @@ max_gembird:
/* get serial number of each device */
for (i = 0; i < count; ++i) {
- usb_dev_handle *sudev = NULL;
+ usb_dev_handle *sudev;
sudev = get_handle(usbdev[i]);
if (sudev == NULL) {
@@ -676,7 +675,6 @@ max_gembird:
} else {
usbdevsn[i] = strdup(get_serial(sudev));
usb_close(sudev);
- sudev = NULL;
}
}