File 2003-fix-sidebar.patch of Package okular

Overview Repositories Revisions Requests Users Attributes Meta

File 2003-fix-sidebar.patch of Package okular

diff --git a/shell/shell.cpp b/shell/shell.cpp
index 3cc933ee1e1a233e4ec7f0f452ff05bb523e6f76..4589a280d1f61ba0af611b87ade35412df6301ce 100644
--- a/shell/shell.cpp
+++ b/shell/shell.cpp
@@ -229,6 +229,7 @@ Shell::Shell(const QString &serializedOptions)
         connect(m_sidebar, &QDockWidget::visibilityChanged, this, [this](bool visible) {
             // sync sidebar visibility with the m_showSidebarAction only if welcome screen is hidden
             if (m_showSidebarAction && m_centralStackedWidget->currentWidget() != m_welcomeScreen) {
+                const QSignalBlocker blocker(m_showSidebarAction);
                 m_showSidebarAction->setChecked(visible);
             }
         });
@@ -910,7 +911,7 @@ void Shell::setActiveTab(int tab)
     Q_ASSERT(m_showSidebarAction);
     m_showSidebarAction->disconnect();
     m_showSidebarAction->setChecked(m_sidebar->isVisibleTo(this));
-    connect(m_showSidebarAction, &QAction::triggered, m_sidebar, &Sidebar::setVisible);
+    connect(m_showSidebarAction, &QAction::toggled, m_sidebar, &Sidebar::setVisible);
 
     m_printAction->setEnabled(m_tabs[tab].printEnabled);
     m_closeAction->setEnabled(m_tabs[tab].closeEnabled);

Places

File 2003-fix-sidebar.patch of Package okular

Places