File fix-ld-dynamic-symbols.patch of Package libqt4

Overview Repositories Revisions Requests Users Attributes Meta

File fix-ld-dynamic-symbols.patch of Package libqt4

From: Hans-Peter Jansen <hpj@urpla.net>
Subject: Fix ld issue with missing symbols

ld has changed behavior in handling "-Bsymbolic-functions --dynamic-list"
arguments. Before commit:

commit bb68f22c8e648032a0d1c1d17353eec599ff5e6a
Author: Fangrui Song <maskray@google.com>
Date:   Wed May 20 18:31:39 2020 -0700

ld: Handle --dynamic-list* before -Bsymbolic -Bsymbolic-functions

ld implied --dynamic-list-data. Now, without the patch applied, 
libQtCore.so misses some symbols, resulting eg. in endless loops
of meinproc4, because comparisons with QByteArray::shared_null
never succeed now. A simple check is:

objdump -T lib/libQtCore.so.4.8.7 | grep QByteArray | grep .data

being empty, while a good build would result in output similar to:

00000000002f5780 g    DO .data  0000000000000020  Base        _ZN10QByteArray11shared_nullE
00000000002f5760 g    DO .data  0000000000000020  Base        _ZN10QByteArray12shared_emptyE

Thanks to Joachim Priesner for doing the hard investigation work
and recording the upstream bug report:
https://sourceware.org/bugzilla/show_bug.cgi?id=26928

Index: b/mkspecs/features/unix/bsymbolic_functions.prf
===================================================================
--- a/mkspecs/features/unix/bsymbolic_functions.prf
+++ b/mkspecs/features/unix/bsymbolic_functions.prf
@@ -3,4 +3,6 @@
     QMAKE_LFLAGS_SHLIB += $$QMAKE_LFLAGS_BSYMBOLIC_FUNC
 
     !isEmpty(QMAKE_DYNAMIC_LIST_FILE):QMAKE_LFLAGS_SHLIB += $$QMAKE_LFLAGS_DYNAMIC_LIST$$QMAKE_DYNAMIC_LIST_FILE
+
+    !isEmpty(QMAKE_DYNAMIC_LIST_FILE):QMAKE_LFLAGS_SHLIB += $$QMAKE_LFLAGS_DYNAMIC_LIST_DATA
 }
Index: b/mkspecs/common/gcc-base-unix.conf
===================================================================
--- a/mkspecs/common/gcc-base-unix.conf
+++ b/mkspecs/common/gcc-base-unix.conf
@@ -19,3 +19,4 @@ QMAKE_LFLAGS_RPATH   = -Wl,-rpath,
 # -Bsymbolic-functions (ld) support
 QMAKE_LFLAGS_BSYMBOLIC_FUNC = -Wl,-Bsymbolic-functions
 QMAKE_LFLAGS_DYNAMIC_LIST   = -Wl,--dynamic-list,
+QMAKE_LFLAGS_DYNAMIC_LIST_DATA = -Wl,--dynamic-list-data

Places

File fix-ld-dynamic-symbols.patch of Package libqt4

Places