File OpenIPMI-2.0.16-debug-buf-overrun.diff of Package OpenIPMI

Overview Repositories Revisions Requests Users Attributes Meta

File OpenIPMI-2.0.16-debug-buf-overrun.diff of Package OpenIPMI

diff -uNrp OpenIPMI-2.0.16/lib/ipmi_lan.c OpenIPMI-2.0.16.ASMB/lib/ipmi_lan.c
--- OpenIPMI-2.0.16/lib/ipmi_lan.c	2008-12-09 19:17:58.000000000 +0100
+++ OpenIPMI-2.0.16.ASMB/lib/ipmi_lan.c	2010-02-22 16:30:01.000000000 +0100
@@ -3086,8 +3086,10 @@ handle_rmcpp_recv(ipmi_con_t    *ipmi,
 	add_stat(ipmi, STAT_BAD_SIZE, 1);
 	if (DEBUG_RAWMSG || DEBUG_MSG_ERR)
 	    ipmi_log(IPMI_LOG_DEBUG,
-		     "%sDropped message payload length doesn't match up",
-		     IPMI_CONN_NAME(ipmi));
+		     "%sDropped message (%i - %i) payload length (%i) doesn't match up",
+		     IPMI_CONN_NAME(ipmi), len, header_len, payload_len);
+	//payload_len = (len - header_len - 1)/16 * 16;
+	//ipmi_log(IPMI_LOG_DEBUG, "Set payload len to %i", payload_len);
 	goto out;
     }
 
@@ -3124,11 +3126,15 @@ handle_rmcpp_recv(ipmi_con_t    *ipmi,
 	if (rv) {
 	    add_stat(ipmi, STAT_AUTH_FAIL, 1);
 	    if (DEBUG_RAWMSG || DEBUG_MSG_ERR)
-		ipmi_log(IPMI_LOG_DEBUG, "%sIntegrity failed",
-			 IPMI_CONN_NAME(ipmi));
+		ipmi_log(IPMI_LOG_DEBUG, "%sIntegrity failed: %i %i %i %i\n",
+			 IPMI_CONN_NAME(ipmi), len, header_len, payload_len, integ_len);
 	    goto out;
-	}
-
+	} 
+#if 0	
+	    else
+		ipmi_log(IPMI_LOG_DEBUG, "%sIntegrity succeeded: %i %i %i %i\n",
+			 IPMI_CONN_NAME(ipmi), len, header_len, payload_len, integ_len);
+#endif
 	/* Remove the integrity padding. */
 	pad_len = data[integ_len-1] + 1;
 	if ((integ_len - header_len - pad_len) != payload_len) {
@@ -3390,7 +3396,9 @@ rmcpp_find_ipmi(lan_fd_t      *item,
     if ((mlen + 10 + (d-data)) > len) {
 	if (DEBUG_RAWMSG || DEBUG_MSG_ERR)
 	    ipmi_log(IPMI_LOG_DEBUG,
-		     "Dropped message payload length doesn't match up");
+		     "Dropped message (%i - 10 - %i) payload length (%i) doesn't match up",
+		     len, (d-data), mlen);
+	//mlen = len - 10 - (d-data);
 	return NULL;
     }

Places

File OpenIPMI-2.0.16-debug-buf-overrun.diff of Package OpenIPMI

Places