File aimage-3.2.5-fix-bad-compilation-warnings.patch of Package aimage
Fix compilation warnings that are bad enough to trigger OBS failures:
- Possibly undefined operation in imager.cpp:
random_page = ++(random_page) % num_pages
- int wipe(const char*) in aimage.cpp should return a value but does not.
Return value is never used, so just change its prototype to
void wipe(const char*)
Index: aimage-3.2.5/src/aimage.cpp
===================================================================
--- aimage-3.2.5.orig/src/aimage.cpp
+++ aimage-3.2.5/src/aimage.cpp
@@ -839,7 +839,7 @@ int verify_file(const char *file1,const
return 0;
}
-int wipe(const char *file1)
+void wipe(const char *file1)
{
AFFILE *af1 = af_open(file1,O_RDWR,0777);
unsigned char *zbuf = (unsigned char *)calloc(AFF_DEFAULT_PAGESIZE,1);
Index: aimage-3.2.5/src/imager.cpp
===================================================================
--- aimage-3.2.5.orig/src/imager.cpp
+++ aimage-3.2.5/src/imager.cpp
@@ -662,7 +662,7 @@ void imager::start_recover_scan()
#endif
while(missing_pages>0){
int random_page = random() % num_pages;
- while(pages[random_page]!=0) random_page = (++random_page) % num_pages;
+ while(pages[random_page]!=0) random_page = (random_page + 1) % num_pages;
printf("*** try for page %d\n",random_page);
uint64 start_sector = random_page * sectors_per_page;
uint64 end_sector = start_sector + sectors_per_page;