Sign Up
Log In
Log In
or
Sign Up
Places
All Projects
Status Monitor
Collapse sidebar
home:marec2000:cryptocoins
bitcoingold
bitcoingold.changes
Overview
Repositories
Revisions
Requests
Users
Attributes
Meta
File bitcoingold.changes of Package bitcoingold
------------------------------------------------------------------- Wed Jul 29 12:01:48 UTC 2020 - marec@detebe.org - Update to version 0.17.3: * Fix lint whitespace error * Update README.md * Change link for Responsible Disclosure * Update README_windows.txt * Reference/terminology updates. * Update keys.txt * Bump version: 0.17.3 * Rename and adjust finliazation options * Reduce maxreorgdepth to 47 * Wait until disconnected in finalize block test * Lint fix * Rolling checkpoint edge case functional test * Temporarily remove lock check * Fix lint errors * Rolling checkpoint functional tests * Finalization unit tests * Introduce rolling checkpoint * Update readme * Bump revision version 0.17.2 * Add mainnet checkpoint, update tx stats * Add include stdexcept to equihash.h * add gpg pub key to keys.txt * server name changes ------------------------------------------------------------------- Thu Jul 02 13:48:37 UTC 2020 - marec@detebe.org - Update to version 0.17.2: * Bump revision version 0.17.2 * Add mainnet checkpoint, update tx stats ------------------------------------------------------------------- Mon Feb 24 11:18:58 UTC 2020 - marec@detebe.org - Update to version 0.17.1: * Mark as release * Fix NetworkHashPS defualt lookup window * Fix bench VerifyScriptBench forkid * Fix btg_timelock test lint * Disable prefork SIGHASH_FORKID * Fix missing deps on mac * fix CVE-2019-6250 - Update zmq to 4.3.1 * Fix gitian build file names * Update keys.txt * Add PGP key EI * Change CURRENCY_UNIT to BTG * Add -fPIC to libb2 build CLFAGS * Add libb2-dev dep in travis build with system libs * Fix util test data * Better httpserver logging * Remove default fallback peers with 8333 port * Fix blockencoding unit test error * Fix lint-whitespace * Fix lint-python errors * Lint: skip trim dep validation in equihash.h * Lint: skip trim dep validation in equihash * Fix python lint errors on BTG functional tests * Fix LogPrint(...) macro lint error * Replace quote include by brackets * Lint: ifdef guards and unnecessary boost deps * Fix circular dependencies error * Ban instead of skip known bad peers * Disable native arch detection for libb2 * Add bitcoingold.dev domain as dns seed * Optimize PNGs * libb2: disable shared library build * Update BTG icons * Fix btg specific functional tests * Fix win32/win64 Travis build * Fix cross compile for libb2 * Fix libb2.mk * Replace libsodium with libb2 in configure * Add libb2 to depends, remove libsodium * Replace libsodium with libb2 package in OSX and Unix build docs * Replace libsodium with libb2 * Fix ref to high version of glibc in libsodium * Add missing quotation in gitian wrappers * Fix libsodium download path * gitain fixes * Fix gitian-build.py * Improve version blacklist description * Propogate fallback bootstrap seeds * Disconnect to known bad User Agent * Fix several minor merging errors * Fix block deserialization in benchmark * Correct minimal pow required * name of client changed * Update BTG license year 2019 * Update h4x3rotab's key with new expiration * doc: Fill in authors and changelog for 0.17.1 release notes * Stop requiring imported pubkey to sign non-PKH schemes * qa: Ensure wallet unload during walletpassphrase timeout * build: bump version to 0.17.1 * rpc: Fix wallet unload during walletpassphrase timeout * fix converttopsbt permitsigdata arg, add basic test * Add test for conversion from non-witness to witness UTXO * Add regression test for PSBT signing bug #14473 * Refactor PSBTInput signing to enforce invariant * Simplify arguments to SignPSBTInput * Add bool PSBTInputSigned * New PartiallySignedTransaction constructor from CTransction * Remove redundant txConst parameter to FillPSBT * More concise conversion of CDataStream to string * check that a separator is found for psbt inputs, outputs, and global map * [tests] Add wallet_balance.py * CreateTransaction: Assume minimum p2sh-p2wpkh spend size for unknown change * Remove stale comment in CalculateMaximumSignedInputSize * qa: Avoid race in p2p_invalid_block by waiting for the block request * Add SAFE_CHARS[SAFE_CHARS_URI]: Chars allowed in URIs (RFC 3986) * rpc: Make HTTP RPC debug logging more informative * add test demonstrating addrLocal UB * fix uninitialized read when stringifying an addrLocal * Throw error if CPubKey is invalid during PSBT keypath serialization * Bugfix: RPC: Add address_type named param for createmultisig * gui: explicitly disable "Dark Mode" appearance on macOS * travis: Remove deprecated sudo * build: Add bitcoin-tx.exe into Windows installer * build: Remove illegal spacing in darwin.mk * Fix listreceivedbyaddress not taking address as a string * wallet: Avoid potential use of unitialized value bnb_used in CWallet::CreateTransaction(...) * Tests: Fix a comment * qa: Add test to ensure node can generate all help texts at runtime * disallow oversized CBlockHeaderAndShortTxIDs * fix a deserialization overflow edge case * add a test demonstrating an overflow in a deserialization edge case * Add autogen.sh in ARM Cross-compilation * [wallet] Ensure wallet is unlocked before signing * doc: Clean out release notes after 0.17.0.1 * qt: Revert "Force TLS1.0+ for SSL connections" * Docs/Release notes: 0.17.0.1 is a minor release * travis: Pin flake8 version to 3.5.0 * build: Bump version for 0.17.0.1 * doc: Update release notes for 0.17.0.1 * [macOS] Remove DS_Store WindowBounds bytes object * Disable wallet and address book Qt tests on macOS minimal platform * descriptors.md: Refer to descriptors as describing instead of matching * doc/descriptors.md tweaks * Import CInv from correct module * qa: Run all tests even if wallet is not compiled * qa: Premine to deterministic address with -disablewallet * Test rpc_help.py failed: Check whether ZMQ is enabled or not. * test: Add tests for RPC help * qa: Use named args in some tests * scripted-diff: Use named arguments in feature_block * scripted-diff: Pass node into p2p_segwit acceptance tests * qa: Add some actual witness in rpc_rawtransaction * [qa] Use correct python index slices in example test * qa: Add TestNode::assert_debug_log * [doc] getblocktemplate: use SegWit in example * [wallet] Restore ability to list incoming transactions by label * Refine README * Add links to README * Add Responsible Disclosure to README.md * doc: Clean out release notes after release 0.17.0 * doc: Update release-notes.md from upstream devwiki * depends: fix bitcoin-qt back-compat with older freetype versions at runtime * [qa] backport: Test for duplicate inputs within a transaction * Fix crash bug with duplicate inputs within a transaction * Convert non-witness UTXOs to witness if witness sig created * Drop the unnecessary UTXO based on the UTXOs present, not on earlier wallet things * Replace duplcate reference with reference to reference doc * Adjust TODO link * Add descriptor reference documentation * test: Add test for config file parsing errors * util: Report parse errors in configuration file * doc: Update v0.17.0.0 manpages * doc: Change documentation for =0 for non-boolean options * fix walletcreatefundedpsbt deriv paths, add test * Use assert when running from multithreaded code as BOOST_CHECK_* are not thread safe * qa: Stop txindex thread before calling destructor * Docs: Fix help message typo optiona -> optional * Bugfix: NSIS: Exclude Makefile* from docs * RPCTypeCheck bip32derivs arg in walletcreatefunded * QA: add basic walletcreatefunded optional arg test * walletcreatefundedpsbt: remove duplicate replaceable arg * Allow ConstructTransaction to not throw error with 0-input txn * depends: fix qt determinism * qt: Pre-rc1 translations update * More tests of signer checks * Test that a non-witness script as witness utxo is not signed * Only wipe wrong UTXO type data if overwritten by wallet * Additional sanity checks in SignPSBTInput * Serialize non-witness utxo as a non-witness tx but always deserialize as witness * Fix PSBT deserialization of 0-input transactions * doc: regenerate manpages * build: bump version to 0.17.0 * contrib: fix GetDesirableServiceFlags typo in seeds/README.md * tests: Use explicit imports * net: Update hardcoded seeds * contrib: in makeseeds, add 0.16.x to PATTERN_AGENT, remove 0.13.x * doc: move-only release notes of individual prs * docs: fixed bitcoin-cli -help output for help2man * qt: Translations update before 0.17 branch * Ported usage of deprecated optparse module to argparse module * Replace median fee rate with feerate percentiles * qa: Add p2p_invalid_locator test * Make format string linter understand basic template parameter syntax * Use 72 byte dummy signatures when watching only inputs may be used * Use 71 byte signature for DUMMY_SIGNATURE_CREATOR * Always create 70 byte signatures with low R values * wallet: shuffle coins before grouping, where warranted * Introduce a maximum size for locators. * qa: blocktools enforce named args for amount * Use pushKV in some new PSBT RPCs. * Squashed 'src/leveldb/' changes from 64052c76c5..524b7e36a8 * Simplify comparison in rpc_blockchain.py. * [Tests] Cleanup feature_block.py, remove unnecessary PreviousSpendableOutput object * [Tests] Cleanup extra instances of create_transaction * [Tests] Rename create_tx and move to blocktools.py * qa: wait_for_verack by default * qa: Remove redundant checkmempool/checkblockindex extra_args * Trivial: Revert translated string change, clarify wallet log messages * [Docs] upgrade rescan time warning from minutes to >1 hour * Add linting of WalletLogPrintf(...) format strings * build: Add format string linter * Docs: fix GetWarnings docs to reflect behavior * shutdown: Stop threads before resetting ptrs * wallet: Catch filesystem_error and raise InitError * [docs] Reformat -help output for help2man * qa: Raise feature_help timeout to 5s * qa: Use files for stdout/stderr to support Windows * qa: Run gen_rpcauth with sys.executable * [trivial] add doxygen-compatible comments to CAffectedKeysVisitor * qa: Close stdout and stderr file when node stops * qa: Create unicode tempdir in test_runner * doc: correct versions in dependencies.md * Docs: Improve "of" grammar * [wallet] Add wallet name to log messages * use only travis jobs: instead of mix of jobs+matrix * trivial: correct typos * trivial: Fixed typos and cleaned up language * fix locale for lint-shell * qa: Quote wallet name for rpc path * gui: Pull initial 017x translations from transifex * tx: Update transifex slug 016x→017x * -prune option -help output aligned with code * qa: Extract rpc_timewait as test param * [trivial,doc] Fix memory consistency model in comment * travis: Run bench_bitcoin once * doc: Remove outdated net comment * bench: Make CoinSelection output groups pass eligibility filter * Ignore unknown config file options for now * Update ValidationInterface() documentation to explicitly specify threading and memory model * Update documentation for SingleThreadedSchedulerClient() to specify the memory model * gui: Reject options dialog when key escape is pressed * gui: Reject edit address dialog when key escape is pressed * gui: Add GUIUtil::ItemDelegate with keyEscapePressed signal * Add BIP174 to list of implemented BIPs * wallet: sum ancestors rather than taking max in output groups * doc: Fix chainTxData comment * use travis:fold in test script steps * contrib: Remove debian and rpm subfolders * [qa] Add test for too-large wallet output groups * Acquire cs_main before ATMP call in block_assemble bench * doc: add note to contributor docs about warranted PR's * Fix osslsigncode compile issue in gitian-build * [wallet] correctly limit output group size * Report when unknown config file options are ignored * chainparams: Update with data from assumed valid chain * doc: Add historical release notes for 0.16.2 * Add aarch64 qt depends support for cross compiling bitcoin-qt * refactor: Avoid locking tx pool cs thrice * Support h instead of ' in hardened descriptor paths * Add experimental warning to scantxoutset * [QA] Extend tests to more combinations * [QA] Add xpub range tests in scantxoutset tests * Swap in descriptors support into scantxoutset * Descriptor tests * Output descriptors module * Add simple FlatSigningProvider * Add more methods to Span class * Fix accidental use of the addition assignment operator ("+="). Remove newlines from error message. * Return void instead of bool for functions that cannot fail * qt: Set BLOCK_CHAIN_SIZE = 220 * Regenerate manpages * Update copyright headers to 2018 * make .travis/yml a bit more readable * net: Add missing verification of IPv6 address in CNetAddr::GetIn6Addr(...) * wallet: Fix accidental use of the comma operator * travis: Retry to fetch docker image * contrib: Fix test-security-check fail in Ubuntu 18.04 * Fix Qt's rcc determinism for depends/gitian * [net_processing] Add thread safety annotations * Annotate AssertLockHeld() with ASSERT_CAPABILITY() for thread safety analysis * scripted-diff: prefer MAC_OSX over __APPLE__ * gui: remove macOS ProgressBar workaround * gui: remove SubstituteFonts * doc: mention that macOS 10.10 is now required * release: bump minimum required macOS to 10.10 * depends: set OSX_MIN_VERSION to 10.10 * scripted-diff: Remove trailing whitespaces * depends: use MacOS friendly sed syntax in qt.mk * doc: Add release notes for -avoidpartialspends * clean-up: Remove no longer used ivars from CInputCoin * wallet: Remove deprecated OutputEligibleForSpending * test: Add basic testing for wallet groups * wallet: Switch to using output groups instead of coins in coin selection * wallet: Add output grouping * Add -avoidpartialspends and m_avoid_partial_spends * wallet: Add input bytes to CInputCoin * moveonly: CoinElegibilityFilter into coinselection.h * utils: Add insert() convenience templates * qt: Update translation source messages * Skip is_closing() check when not available. * Removes Boost predicate.hpp dependency * doc: Adjust bitcoincore.org links * trivial: remove unneeded include * tiny refactor for ArgsManager * Avoid locking mutexes that are already held by the same thread * Use the Travis python language feature on the lint build * Don't unnecessarily install shellcheck on the lint build * trivial: Replace CPubKey::operator[] with CPubKey::vch where possible * Removes the boost/algorithm/string/join dependency * Avoid unnecessarily setting env variables on the lint build * [contrib] Add automatic setup for Ubuntu Bionic * Fix bitcoin-cli --version * [bench] Add benchmark for unserialize prevector * Fix merging of global unknown data in PSBTs * Check that PSBT keys are the correct length * Avoid creating a temporary vector for size-prefixed elements * docs: Specify preferred Python string formatting technique * docs: Link to python style guidelines from developer notes * wallet: Add error handling. Check return value of ParseUInt32(...) in ParseHDKeypath(...). * wallet: Add tests for ParseHDKeypath(...) * [travis] Don't store debug info if --enable-debug is set * tests: fixes mininode's P2PConnection sending messages on closing transport * doc: Improve command to generate list of authors for release notes * doc: Update broken links to now point to gitian-build.py * lint: Add linter for circular dependencies * contrib: correct version check * Remove redundant statement * Remove redundant unused variables * Remove redundant forward declaration * Remove program options from build system * Replace boost program_options * contrib: Clone core repo in gitian-build * depends: disable Werror for zmqlib release, causes ndk build to break * Extract MakeUnique into utilmemory.h * qa: Temporarily disable test that reads the default datadir location * travis: Check that ~/.bitcoin is never created * wallet: Avoid potential null pointer dereference in CWalletTx::GetAvailableCredit(...) * bench: Remove unused variable * Tests for PSBT * Create wallet RPCs for PSBT * Create utility RPCs for PSBT * [doc] Remove outdated comment about mining code ignoring CPFP * Initialize m_next_send_inv_to_incoming * Migrate gitian-build.sh to python * Change gitian-descriptors to use bionic instead * Modified in_addr6 cast in CConman class to work with msvc. * scripted-diff: Fix references to share/rpcuser (now share/rpcauth) * [QA] Add scantxoutset test * scantxoutset: mention that scanning by address will miss P2PK txouts * scantxoutset: support legacy P2PK script type * scantxoutset: add support for scripts * Blockchain/RPC: Add scantxoutset method to scan UTXO set * wallet: Fix backupwallet for multiwallets * [moveonly] Extract RescanWallet to handle a simple rescan * bench_bitcoin: Avoid read/write to default datadir * test_bitcoin: Avoid read/write to default datadir * Bucket for inbound when scheduling invs to hide tx time * SignPSBTInput wrapper function * Refactor transaction creation and transaction funding logic * Methods for interacting with PSBT structs * Add pubkeys and whether input was witness to SignatureData * Implement PSBT Structures and un/serialization methods per BIP 174 * bitcoinconsensus: invalid flags should be set to bitcoinconsensus_error type, add test cases covering bitcoinconsensus error codes * build: add missing leveldb defines * Privatize CWallet::AddToWalletIfInvolvingMe * Extract CWallet::MarkInputsDirty * qa: Fix some TODOs in p2p_segwit * wallet: assert to ensure accuracy of CMerkleTx::GetBlocksToMaturity * Fix that CWallet::AbandonTransaction would only traverse one level * Drop dead code from Stacks * QA: Fix bug in -usecli logic that converts booleans to non-lowercase strings * [QA] add createwallet disableprivatekey test * [Qt] Disable creating receive addresses when private keys are disabled * Add disable privatekeys option to createwallet * Add option to disable private keys during internal wallet creation * Add FindScriptPubKey() to search the UTXO set * [tests] skip rpc_zmq functional test when python3 zmq lib is not present * Tools: fix BIND_NOW check in security-check.py * Add facility to store wallet flags (64 bits) * Use common SetDataDir method to create temp directory in tests. * Add depends 32-bit arm support for bitcoin-qt * Refactors `keystore.h` type aliases. * doc: Add release notes for -printtoconsole and -debuglogfile changes * tests: Use MAX_SCRIPT_ELEMENT_SIZE from script.py * Remove dead service bits code * Drop unused pindexRet arg to CMerkleTx::GetDepthInMainChain * Remove unused argument to WitnessSigOps(...) * Remove unused argument to DefaultOptions(...) * Remove unused argument to ThreadHTTP(...) * Make g_enable_bip61 a member variable of PeerLogicValidation * Remove useless mapRequest tracking that just effects Qt display. * Corrected text to reflect new[er] process of specifying fingerprints instead of individual keys. * depends: Mention RISC-V known compilation issue with gcc-7.3.x * [tests] functional test for createmultisig RPC * segwit support for createmultisig RPC * Move AddAndGetDestinationForScript from wallet to outputype module * Add outputtype module * depends: update zmq config.guess/config.sub for riscv support * depends: latest config.sub * depends: latest config.guess * Remove unused argument to ProcessGetBlockData(...) * net: Remove unused interrupt from SendMessages * Fix command line help for -printtoconsole and -debuglogfile * Use __cpuid_count for gnu C to avoid gitian build fail. * bitcoin-tx: Stricter check for valid integers * Upgrade Qt depends to 5.9.6 * Fix depends Qt5.9.4 mac build * Ugrade Qt depends to Qt5.9.4 * fix bench/prevector.cpp * RPC: Add new getzmqnotifications method. * Docs: Modify policy to not translate command-line help * Remove CombineSignatures and replace tests * Replace CombineSignatures with ProduceSignature * Make SignatureData able to store signatures and scripts * Add simple bech32 benchmarks * Docs: Improve doc of options addnode, connect, seednode * scripted-diff: Replace NET_TOR with NET_ONION * Delete double semicolon in wallet.cpp and misc.cpp * Detect if char equals int8_t * logging: avoid nStart may be used uninitialized in AppInitMain warning * Inline Sign1 and SignN * [RPC] [wallet] allow getbalance to use min_conf and watch_only without accounts. * [tests] p2p_segwit: sync_blocks in subtest wrapper. * [tests] p2p_segwit: remove unnecessary arguments from subtests. * [tests] p2p_segwit: log and assert segwit status in subtest wrapper. * [tests] p2p_segwit: Make sure each subtest leaves utxos for the next. * [tests] p2p_segwit: wrap subtests with subtest wrapper. * [tests] p2p_segwit: re-order function definitions. * [tests] p2p_segwit: standardise comments/docstrings. * [tests] p2p_segwit: Fix flake8 warnings. * Make ZMQ notification interface instance global. * [wallet] GetBalance can take a min_depth argument. * [wallet] factor out GetAvailableWatchOnlyBalance() * [wallet] deduplicate GetAvailableCredit logic * [wallet] Factor out GetWatchOnlyBalance() * [wallet] GetBalance can take an isminefilter filter. * Fix AreInputsStandard test to reference the proper scriptPubKey * [wallet] loadwallet shouldn't create new wallets. * bench: Simplify CoinSelection * tests: Fix incorrect documentation for test case cuckoocache_hit_rate_ok * [tests] Check signrawtransaction* errors on missing prevtx info * Error on missing amount in signrawtransaction* * Remove boost dependency (boost/assign/std/vector.hpp) * depends: Update Qt download url * Fix incorrect tests * depends: Add RISC-V support * Docs: More precise explanation of parameter "onlynet" * Show symbol for inbound/outbound in peer table * Use immintrin.h everywhere for intrinsics * Add SHA256 implementation using using Intel SHA intrinsics * qa: Avoid start/stop of the network thread mid-test * [qa] wallet_basic: Specify minimum required amount for listunspent * qt: Move BitcoinGUI initializers to class, fix initializer order warning * [qt] coincontrol: Remove unused qt4 workaround * Break circular dependency: init -> * -> init by extracting shutdown.h * Drop unused init.h includes * Log warning message when deprecated network name 'tor' is used (e.g. option onlynet=tor) * doc: Clarify that mempool txiter is const_iterator * travis: Build with --enable-debug (x86_64-unknown-linux-gnu) * Add -ftrapv to DEBUG_CXXFLAGS when --enable-debug is used * [Refactor] CPU feature detection logic for SHA256 * bench: Add missing pow.h header * policy: Remove promiscuousmempoolflags * [qa] mininode: Expose connection state through is_connected * [tests] Fix p2p_sendheaders race * [qa] Add a test for merkle proof malleation * Net: Fixed a race condition when disabling the network. * Document FreeBSD quirk. Fix FreeBSD build. * Restrict as much as possible in net_processing to translation unit * bugfix: Delete walletView in WalletFrame::removeWallet * Obsolete #!/bin/bash shebang * Fix parameter count check for importpubkey. * Qt: load wallet in UI after possible init aborts * [move-only] Move things only referenced in net_processing out of header file * Rescope g_enable_bip61 to net_processing * Decouple wallet version from client version * For AVX2 code, also check for AVX, XSAVE, and OS support * [tests] Remove accounts from wallet_importprunedfunds.py * [wallet] Don't use accounts when checking balance in sendmany * [wallet] deprecate sendfrom RPC method. * Test: Harden lint-filenames.sh * doc: Rewrite some validation doc as lock annotations * bugfix: Remove dangling wallet env instance * ui: Support wallets unloaded dynamically * doc: Add release notes for unloadwallet RPC * test: Wallet methods are disabled when no wallet is loaded * test: Add functional tests for unloadwallet RPC * rpc: Add unloadwallet RPC * Follow-up to #13454: Fix broken build by exporting LC_ALL=C * doc: Remove mention of Qt4 from build docs * test: Update travis to not test Qt4 anymore * gui: Remove QT_VERSION fallbacks for Qt < 5 * Move rpc/util.cpp from libbitcoin-util to libbitcoin-server * Add P2WSH destination helper and use it instead of manual hashing * Add additional unit tests for invalid IsMine combinations * Do not expose invalidity from IsMine * Docs: Improve readability of "Squashing commits" * Fix CVE-2018-12356 by hardening the regex. * build: add warning to detect hidden copies in range-for loops * cleanup: avoid hidden copies in range-for loops * doc: Add historical release notes for 0.16.1 * Fix incorrect shell quoting in FreeBSD build instructions. * validation: count blocks correctly for check level < 3 * Add linter: Enforce the source code file naming convention described in the developer notes * Avoid concurrency issue * ScanforWalletTransactions should mark input txns as dirty * have verifytxoutproof check the number of txns in proof structure * Add linter: Make sure all shell scripts opt out of locale dependence using "export LC_ALL=C" * Add "export LC_ALL=C" to all shell scripts * doc: Remove note to install all boost dev packages * build: Build system changes to support only Qt5 * expose CBlockIndex::nTx in getblock(header) * tests: Drop variadic macro * travis: Change Mac goal to all deploy so that travis can build all executables for Mac. * Add unavailable options to hidden options category * Add linter: Make sure we explicitly open all text files using UTF-8 or ASCII encoding in Python * tests: Fix lock-order-inversion (potential deadlock) in DoS_tests. Reported by TSAN. * Explicitly specify encoding when opening text files in Python code * Improve coverage of SHA256 SelfTest code * travis: Increase travis_wait time while verifying commits * rpc: Extract GetWalletNameFromJSONRPCRequest from GetWalletForJSONRPCRequest * Use python instead of slow shell script on verify-commits * Reset default -g -O2 flags when enable debug * [build] Tune wildcards for LIBSECP256K1 target * Only set fNewBlock to true in AcceptBlock when we write to disk * When build fails due to lib missing, indicate which one * qa: Log as utf-8 * scripted-diff: Avoid temporary copies when looping over std::map * rpc: Avoid "duplicate" return value for invalid submitblock * wallet: Erase wtxOrderd wtx pointer on removeprunedfunds * test: Add MempoolAncestryTests * mempool: Calculate descendant maximum thoroughly * wallet: Switch to using ancestor/descendant limits * wallet: Strictly greater than for ancestor caps * Remove deprecated TransactionWithinChainLimit * Switch to GetTransactionAncestry() in OutputEligibleForSpending * Add GetTransactionAncestry to CTxMemPool for general purpose chain limit checking * mempool: Fix max descendants check * mempool: Add explicit max_descendants * validation: check the specified number of blocks (off-by-one) * Removed unused == operator from CMutableTransaction. * Fix compiler warnings emitted when compiling under stock OpenBSD 6.3 * Drop ParseHashUV in favor of calling ParseHashStr * qa: Remove portseed_offset from test runner * Make ReceivedBlockTransactions return void * crypto: cleanup sha256 build * speed up of tx_validationcache_tests by reusing of CTransaction. * lint: Add linter to error on #include <*.cpp> * Clarify include recommendation * Enforce the use of bracket syntax includes ("#include <foo.h>") * Use bracket syntax includes ("#include <foo.h>") * docs: Mention lint-locale-dependence.sh in developer-notes.md * build: Add linter for checking accidental locale dependence * Document validationinterace callback blocking deadlock potential. * utils: checking for bitcoin addresses in translations * Drop uint 256 not operator * index: Move index DBs into index/ directory. * index: Remove TxIndexDB from public interface of TxIndex. * MOVEONLY: Move BaseIndex to its own file. * index: Generalize logged statements in BaseIndex. * index: Extract logic from TxIndex into reusable base class. * db: Make reusable base class for index databases. * db: Remove obsolete methods from CBlockTreeDB. * cli: Ignore libevent warnings * Enable double-SHA256-for-64-byte code on 32-bit x86 * Rename “OS X” to the newer “macOS” convention * build: Guard against accidental introduction of new Boost dependencies * bench: Use non-throwing ParseDouble(...) instead of throwing boost::lexical_cast<double>(...) * Add stdin, stdout, stderr to ignored export list * Use IN6ADDR_ANY_INIT instead of in6addr_any * GCC-7 and glibc-2.27 compat code * [docs] update transifex doc link * doc: split FreeBSD build instructions out of build-unix.md * Add option to use docker for gitian-build.sh * qa: Increase includeconf test coverage * [wallets] [docs] Add release notes for createwallet RPC. * [wallet] [tests] Add tests for `createwallet` RPC. * Fix "gmake check" under OpenBSD 6.3 (probably *BSD): Avoid using GNU grep specific regexp handling * bench: Don't return a bool from main * qa: Fixup setting of PATH env var * qa: Avoid checking reject code for now * wallet: Prevent segfault when sending to unspendable witness * [tests] Add logging to provide anchor points when debugging failures. * Test gArgs erroring on unknown args * Give an error and exit if there are unknown parameters * Use a struct for arguments and nested map for categories * Generic TransactionSignatureCreator works with both CTransaction and CMutableTransaction * travis: Skip cache for lint stage * Stop translating command line options * doc: update bitcoin-dot-org links in release-process.md * refactor: add a function for determining if a block is pruned or not * Remove template matching and pseudo opcodes * [MOVEONLY] Move unused Merkle branch code to tests * 8-way AVX2 implementation for double SHA256 on 64-byte inputs * 4-way SSE4.1 implementation for double SHA256 on 64-byte inputs * Use SHA256D64 in Merkle root computation * Specialized double sha256 for 64 byte inputs * policy: Treat segwit as always active * Ensure gitian-build.sh uses bash * doc: remove leftover check-doc documentation * [wallet] [rpc] Add `createwallet` RPC * test: Output should be unlocked when spent * wallet: Unlock spent outputs * Travis: Build tests on Ubuntu 18.04 with docker * Make handling of invalid in IsMine more uniform * test: Move linters to test/lint, add readme * Fix FreeBSD build by including utilstrencodings.h * Do not use uppercase characters in source code filenames * docs: Add a note about the source code filename naming convention * qa: Fix wallet_listreceivedby race * build: split warnings out of CXXFLAGS * Tests: Add data file * Tests: Test new getblockstats RPC * RPC: Introduce getblockstats * wallet: Use shared pointer to retain wallet instance * qa: Initialize lockstack to prevent null pointer deref * docs: Update OpenBSD build instructions for OpenBSD 6.3 * Declare TorReply parsing functions in torcontrol_tests * [wallet] Fix incorrect comment for DeriveNewSeed. * Drop the chain argument to GetDifficulty * trivial: Mark overrides as such. * Increased max width of amount field to prevent number overflow bug. * [docs] Add release notes for HD master key -> HD seed rename * [rpc] [wallet] Add 'hdmasterkeyid' alias return values. * [refactor] manually change remaining instances of master key to seed. * scripted-diff: Rename master key to seed * Qt: use [default wallet] as name for wallet with no name * Drop UpdateTransaction in favor of UpdateInput * Qt/Bugfix: fix handling default wallet with no name * Add Unit Test for SingleThreadedSchedulerClient * fixup! ui: Support wallets loaded dynamically * wallet: Exit SyncMetaData if there are no transactions to sync * [qt] Added satoshi unit "Satoshi (sat)" will be displayed in dropdowns and status bars. "sat" will be used when appended to numbers. * [qt] BitcoinUnits::format with zero decimals Formatting with zero decimals will now result in 123 instead of 123.0 * doc: Bump to Ubuntu Bionic 18.04 in build-windows.md * break circular dependency: random/sync -> util -> random/sync * Wallet: Refactor ReserveKeyFromKeyPool for safety * RPCAuth Detection in Logs * Revert "Merge #12870: make clean removes src/qt/moc_ files" * GUI: Allow generating Bech32 addresses with a legacy-address default * GUI: Rephrase Bech32 checkbox text/tooltip * Add circular dependencies script * [wallet] [docs] Update release notes for removing `getlabeladdress` * [wallet] [rpc] Remove getlabeladdress RPC * ui: Support wallets loaded dynamically * ui: Remove unnecessary variable fFirstWallet * [docs] Add release notes for `loadwallet` RPC. * [wallet] [tests] Test loadwallet * [wallet] [rpc] Add loadwallet RPC * [wallet] Pass error message back from CWallet::Verify() * [wallet] Add CWallet::Verify function * Add unit tests for signals generated by ProcessNewBlock() * [gui] Add proxy icon in statusbar * [wallet] setup wallet background flushing in WalletInit directly * [wallet] Fix potential memory leak in CreateWalletFromFile * [qt] OptionsDialog: add prune setting * net: Serve blocks directly from disk when possible * Break circular dependency: chain -> pow -> chain * Add compile time checking for all cs_wallet runtime locking assertions * doc: Mention disabling BIP61 in bips.md * net: Add option `-enablebip61` to configure sending of BIP61 notifications * bench: Add block assemble benchmark * travis: Rename the build stage "check_doc" to "lint" * Bump wallet version for pre split keypool * Use a keypool of presplit keys after upgrading to hd chain split * Allow -upgradewallet to upgradewallets to HD * Test sethdseed * Add 'sethdseed' RPC to initialize or replace HD seed * Fix concurrency-related bugs in ActivateBestChain * Do not unlock cs_main in ABC unless we've actually made progress. * Enable Travis checking for two Python linting rules we are currently not violating * Enable W191 and W291 flake8 checks. Remove trailing whitespace from Python files. Convert tabs to spaces. * test: Ensure that recursive -includeconf produces appropriate warnings * util: warn about recursive -includeconf arguments in configuration files * [tests] Remove spurious error log in p2p_segwit.py * [qa] Handle disconnect_node race * [qa] Avoid printing to console during cache creation * Make gArgs aware of the arguments * Bugfix: ensure consistency of m_failed_blocks after reconsiderblock * [tests] Allow stderr to be tested against specified string * [Tests] Use LIBC_FATAL_STDERR_=1 in tests * [Tests] Write stdout/stderr to datadir instead of temp file. * wallet: Improve logging when BerkeleyDB environment fails to close * [bitcoin-11004] creating another jobs for the CHECK_DOC=1, separated from the core jobs * [tests] Fixed intermittent failure in p2p_sendheaders.py. * [qt]: changes sendcoinsdialog's box layout for improved readability. * qa: Remove unused option --srcdir * Refactor SHA256 code * Benchmark Merkle root computation * Bugfix: the end of a reorged chain is invalid when connect fails * RPC Docs: gettxout*: clarify bestblock and unspent counts * Fix typos * Refactor: RPC: Separate GetBlockChecked() from getblock() * Remove enum specifier (to avoid re-declare scoped enum as unscoped) * replace modulus with FastMod * Add Clang thread safety analysis annotations * Fix missing locking in CTxMemPool::setSanityCheck(double dFrequency) * Fix missing locking in CTxMemPool::check(const CCoinsViewCache *pcoins) * Add compile time checking for all ::mempool.cs runtime locking assertions * Separate HaveKey function that checks whether a key is in a keystore * Cache witness hash in CTransaction * Make CMutableTransaction constructor explicit * qa: Pad scriptPubKeys to get minimum sized txs * Policy to reject extremely small transactions * Add transaction tests for constant scriptCode * Add constant scriptCode policy in non-segwit scripts * Fix MAX_STANDARD_TX_WEIGHT check * doc: Mention good first issue list in CONTRIBUTING.md * Make it clear which functions that are intended to be translation unit local * Add some checks for invalid recursion in IsMine * Simplify IsMine logic * Make IsMine stop distinguishing solvable/unsolvable * Make coincontrol use IsSolvable to determine solvability * [logging] Don't incorrectly log that REJECT messages are unknown. * Fix rescanblockchain rpc to property report progress * wallet: Reset BerkeleyDB handle after connection fails * Print a log message if we fail to shrink the debug log file * refactor: Avoid extra lookups of mapAddressBook in listunspent RPC * rpc: Reduce cs_main lock in listunspent * [tests] Remove 'account' API from wallet functional tests * Trivial: s/SetBestChain/ChainStateFlushed in comments after #13106 * devtools: Make linter check LogPrint calls * Add missing newlines to LogPrint debug logging * Make sure initialization occurs in the constructor * wallet: Interrupt rescan on shutdown request * Handle unsuccessful fseek(...):s * logging: remove unused return value from LogPrintStr * logging: Fix potential use-after-free in LogPrintStr(...) * doc: Add release notes for -includeconf * test: Test includeconf parameter. * rpcauth: Make it possible to provide a custom password * [doc] qt: fixes broken link on readme * [tests] Fix flake8 warnings in several wallet functional tests * Revert #12769: Add systemd service to bitcoind in debian package * Add Windows shutdown handler * Remove python2 from configure.ac * [Docs] Add version footnote to tor.md * [tests] Fix race in rpc_deprecated.py * wallet: Add Clang thread safety annotations for variables guarded by cs_db * nit: descendent should be spelled descendant even in the release-notes * scheduler: Add Clang thread safety annotations for variables guarded by m_cs_callbacks_pending * nit: fix typo for entry description string * Remove script to clean up datadirs * util: Store debug log file path in BCLog::Logger member. * scripted-diff: Rename BCLog::Logger member variables. * util: Refactor GetLogCategory. * Add Clang thread safety annotations for variables guarded by cs_warnings * Add Clang thread safety annotations for variables guarded by cs_nTimeOffset * Add Clang thread safety annotations for variables guarded by cs_rpcWarmup * Add missing cs_KeyStore lock * Add locking annotations for variables guarded by cs_KeyStore * util: Encapsulate logCategories within BCLog::Logger. * util: Move debug file management functions into Logger. * util: Establish global logger object. * Use --failfast when running functional tests on Travis * Add --failfast option to functional test runner * Simplify semantics of ChainStateFlushed callback * scripted-diff: Rename SetBestChain callback ChainStateFlushed * Remove "rpc" category from GetWarnings * rpc: Move RPC_FORBIDDEN_BY_SAFE_MODE code to reserved section * tests: Add test for 64-bit PE, modify 32-bit test results * build: sync ax_boost_chrono/unit_test * Remove Safe mode * -includeconf=<path> support in config handler, for including external configuration files * Don't test against min relay fee information in mining_prioritisetransaction.py * Add compile time checking for all cs_KeyStore runtime locking assertions * [doc] Include txindex changes in the release notes. * [test] Simple unit test for TxIndex. * [rpc] Public interfaces to GetTransaction block until synced. * [index] Move disk IO logic from GetTransaction to TxIndex::FindTx. * [validation] Replace tx index code in validation code with TxIndex. * [init] Initialize and start TxIndex in init code. * [index] TxIndex method to wait until caught up. * [index] Allow TxIndex sync thread to be interrupted. * [index] TxIndex initial sync thread. * [index] Create new TxIndex class. * [db] Migration for txindex data to new, separate database. * [db] Create separate database for txindex. * [wallet] [rpc] Fix importaddress help text * [tests] [qt] Add tests for address book manipulation via EditAddressDialog * [tests] [qt] Introduce qt/test/util with a generalized ConfirmMessage * [qt] Display more helpful message when adding a send address has failed * Add purpose arg to Wallet::getAddress * test: add rpcauth-test to AC_CONFIG_LINKS to fix out-of-tree make check * [tests] Make rpcauth.py testable and add unit tests * qa: Clarify documentation for send_txs_and_test * wallet: Make vpwallets usage thread safe * List support for BIP173 in bips.md * Make tests pass after 2020 * wallet: Make fee settings non-static members * Add logging and error handling for file syncing * qt: Don't log to console by default * test: Add rpcauth pair that generated by rpcauth * trivial: Fix relevent typo * qa: Normalize executable location * [tests] Fix feature_block flakiness * [tests] tidy up blocktools.py * [tests] Fix flake8 warnings in blocktools.py * [doc][trivial] no retargeting in regtest mode * Add systemd service for bitcoind * Sync contrib/debian from Matt Corallo's PPA * Use anonymous namespace instead of static functions * Mention removal of bare multisig IsMine in release notes * Do not treat bare multisig as IsMine * Optimization: only test for witness scripts at top level * Track difference between scriptPubKey and P2SH execution in IsMine * Switch to a private version of SigVersion inside IsMine * Do not expose SigVersion argument to IsMine * Output values for "min relay fee not met" error * Fix for utiltime to compile with msvc. * [wallet] [tests] Test disallowed multiwallet params * [wallet] Fix zapwallettxes/multiwallet interaction. * [qa] Attach node index to test_node AssertionError and print messages * trivial: Improve include comment in src/interfaces/wallet.h * node: Removed unused wallet-related methods from the Node interface. * benchmark: Removed bench/perf.cpp * Remove unused IsMine overload * Make CScript -> CScriptID conversion explicit * Consistently log CValidationState on failure * wallet: Add HasWallets * wallet: Add AddWallet, RemoveWallet, GetWallet and GetWallets * MOVEONLY: Move logging code from util.{h,cpp} to new files. * refactor: Drop CWalletRef typedef * scripted-diff: Rename CChainState::g_failed_blocks to m_failed_blocks * Add new fee structure with all sub-fields denominated in BTC * bench: Amend mempool_eviction test for witness txs * bench: Move constructors out of mempool_eviction hot loop * [doc] Add comments for chainparams.h, validation.cpp * [docs] Add release notes for deprecated 'account' API * [wallet] [tests] Add tests for accounts/labels APIs * test: Fix dangling wallet pointer in vpwallets * [wallet] [rpc] Deprecate wallet 'account' API * [wallet] [rpc] Deprecate account RPC methods * Make --enable-debug to pick better options * Print to console by default when not run with -daemon * qa: Add test for orphan handling * Hold cs_main while calling UpdatedBlockTip() and ui.NotifyBlockTip * net: Minor accumulated cleanups * [tests] Set -deprecatedrpc=accounts in tests * [tests] Rename rpc_listtransactions.py to wallet_listtransactions.py * [wallet] [rpc] Remove duplicate entries in rpcwallet.cpp's CRPCCommand table * qt:Show the entire Window when double clicking on taskbar * Default to defining endian-conversion DECLs in compat w/o config * [doc] build-windows: Switch to Artful, since Zesty is EOL * tests: Remove redundant bytes² * Enable additional flake8 rules * Minor Python cleanups to make flake8 pass with the new rules enabled * tests: Remove compatibility code not needed now when we're on Python 3 * correcting the array name from pnSeeds6 to pnSeed6 * Avoid launching as admin when NSIS installer ends. * Fix inconsistent namespace formatting guidelines * Note new weight field in release-notes. * Test new weight field in p2p_segwit * Expose a transaction's weight via RPC * [contrib] convert test-security-check to python3 * add lint tool to check python3 shebang * [MOVEONLY] Turn CScript::GetOp2 into a function and move to cpp * [MOVEONLY] Move CSCript::FindAndDelete to interpreter * Delete unused non-const-iterator CSCript::GetOp overloads * Make iterators in CScript::FindAndDelete const * [qa] Test that v0 segwit outputs can't be spent pre-activation * Always enforce SCRIPT_VERIFY_WITNESS with P2SH * [qa] Remove some pre-activation segwit tests * Separate NULLDUMMY enforcement from SEGWIT enforcement * Use P2SH consensus rules for all blocks * wallet: Refactor g_wallet_init_interface to const reference * wallet: Make WalletInitInterface members const * test: Add rpc_bind test to default-run tests * Avoid std::locale/imbue in DateTimeStrFormat * Drop dead code CScript::Find * macOS: Prevent Xcode 9.3 build warnings * Tighten up bech32::Decode(); add tests. * logging: bypass timestamp formatting when not logging * Give an error when rescan is aborted by the user * Add cancel button to rescan progress dialog * Add assertion to guide static analyzers. Clang Static Analyzer needs this guidance. * Fix dead stores. Values were stored but never read. Limit scope. * [doc] Fix comment in FindForkInGlobalIndex * tests: Avoid copies of CTransaction * bitcoin-tx: Remove unused for loop * speed up wallet_hd.py and clarify/augment checks * debug log number of unknown wallet records on load * depends: Fix Qt build with XCode 9.3 * Add shell script linting: Check for shellcheck warnings in shell scripts * Add config changes to release notes * [tests] Unit tests for -testnet/-regtest in [test]/[regtest] sections * ArgsManager: special handling for -regtest and -testnet * [tests] Unit tests for network-specific config entries * ArgsManager: Warn when ignoring network-specific config setting * ArgsManager: limit some options to only apply on mainnet when in default section * [tests] Use regtest section in functional tests configs * [tests] Unit tests for config file sections * ArgsManager: support config file sections * ArgsManager: drop m_negated_args * depends: Add 'make clean' and 'make clean-all' rules * Document how FlushStateMode::NONE is handled * Call FlushStateToDisk(...) regardless of fCheckForPruning * rpc: Drop redundant testing of signrawtransaction prevtxs args * Remove redundant initializations from the constructor * Ignore macOS daemon() depracation warning * ArgsManager: keep command line and config file arguments separate * test: Fix sign for expected values * Extract consts for WITNESS_V0 hash sizes * [docs] Add release notes for wallet 'label' API. * [wallet] [rpc] introduce 'label' API for wallet * Fix illegal default `addProxy` and `addrSeparateProxyTor` settings. * Refine travis check for duplicate includes * Make DummySignatureCreator a singleton * Make BaseSignatureCreator a pure interface * wallet: Remove redundant lambda function arg in handleTransactionChanged * Increase entropy in test temp directory name * Reorder travis builds * tests: run tests in parallel * tests: split up actual tests and helper files * Initialize non-static class members where they are defined * Initialize editStatus and autoCompleter. Previously not initialized where defined or in constructor. * Docs: fixed link, replaced QT with Qt * added logging line back that was accidentally removed with #10762 * [qa] Delete cookie file before starting node * Logprint the start of a rescan * util: Remove designator initializer from ScheduleBatchPriority * util: Pass pthread_self() to pthread_setschedparam instead of 0 * [doc] devtools: Setup ots git integration * Add Travis check for duplicate includes * Remove duplicate includes * test: Assert on correct variable * Introduce BigEndian wrapper and use it for netaddress ports * qa: Windows fixups for functional tests * [qa] Ensure bitcoind processes are cleaned up when tests end * Use std::bind instead of boost::bind to re-lock the wallet * [rpcwallet] Clamp walletpassphrase value at 100M seconds * list the types of scripts we should consider for a witness program * Add m_ prefix to WalletBatch::m_batch * Update walletdb comment after renaming. * scripted-diff: Rename wallet database classes * [logging] add lint-logs.sh to check for newline termination. * [logging] Comment all continuing logs. * doc: add qrencode to brew install instructions * scripted-diff: Avoid `interface` keyword to fix windows gitian build * Asserts that the tx version number is a signed 32-bit integer. * tests: Add check for test suite name uniqueness in lint-tests.sh * tests: Add note about uniqueness requirement for test suite names * tests: Avoid test suite name collision in wallet crypto_tests * build: Show enabled sanitizers in configure output * [test] fundrawtransaction: lock watch-only shared address * docs: Fix conflicting statements about initialization in developer notes * wallet: Refactor to WalletInitInterface* const g_wallet_init_interface * wallet: Make WalletInitInterface and DummyWalletInit private * [tests] Add additional unit tests for -nofoo edge cases * [tests] Check GetChainName works with config entries * [tests] Add unit tests for ReadConfigStream * ReadConfigStream: assume the stream is good * Separate out ReadConfigStream from ReadConfigFile * [tests] Add unit tests for GetChainName * Move ChainNameFromCommandLine into ArgsManager and rename to GetChainName * Get rid of ambiguous OutputType::NONE value * Support serializing Span<unsigned char> and use that instead of FLATDATA * Add Slice: a (pointer, size) array view that acts like a container * wallet: Initialize m_last_block_processed to nullptr. Initialize fields where defined. * doc: Use bitcoind in Tor documentation * Tests: Add Metaclass for BitcoinTestFramework * Add developer notes about blocking GUI code * Use WalletBalances struct in Qt * Remove direct bitcoin calls from qt/sendcoinsdialog.cpp * Remove direct bitcoin access from qt/guiutil.cpp * Remove direct bitcoin calls from qt transaction table files * Remove direct bitcoin calls from qt/paymentserver.cpp * Remove direct bitcoin calls from qt/addresstablemodel.cpp * Remove direct bitcoin calls from qt/coincontroldialog.cpp * Remove most direct bitcoin calls from qt/walletmodel.cpp * Remove direct bitcoin calls from qt/optionsdialog.cpp * Remove direct bitcoin calls from qt/rpcconsole.cpp * Remove direct bitcoin calls from qt/bantablemodel.cpp * Remove direct bitcoin calls from qt/peertablemodel.cpp * Remove direct bitcoin calls from qt/intro.cpp * Remove direct bitcoin calls from qt/clientmodel.cpp * Remove direct bitcoin calls from qt/splashscreen.cpp * Remove direct bitcoin calls from qt/utilitydialog.cpp * Remove direct bitcoin calls from qt/bitcoingui.cpp * Remove direct bitcoin calls from qt/optionsmodel.cpp * Remove direct bitcoin calls from qt/bitcoin.cpp * [trivial] Add newlines to end of log messages. * Modernize best block mutex/cv/hash variable naming * Fix csBestBlock/cvBlockChange waiting in rpc/mining * Add src/interface/README.md * make clean removes src/qt/moc_ files * [tests] simplify binary and hex response parsing in interface_rest.py * [tests] only use 2 nodes in interface_rest.py * [tests] refactor interface_rest.py to avoid code repetition * [tests] Make json request building more consistent in interface_rest.py * [tests] improve logging and documentation in interface_rest.py * [tests] fix flake8 warnings in interface_rest.py test * [wallet] [rpc] [doc] importprivkey: hint about importmulti * Adding logging for loop iteration level in p2p_sendheaders.py * [moveonly] Extract HelpRequested to dry up the help options testing * [tests] Stop feature_block.py from blowing up memory. * Bugfix: Include <memory> for std::unique_ptr * [tests] Remove Comparison Test Framework * [tests] Remove bip9-softforks.py * doc: Add testmempoolaccept to release-notes * Avoid travis lint-include-guards error * Add P2P, Network, and Qt categories to the desktop icon * qa: Match full plain text by default * travis: Run verify-commits only on cron jobs * rpc: fix type mistmatch in listreceivedbyaddress * [tests] Test starting bitcoind with -h and -version * test: Remove travis checkout depth * Enable flake8 warning F841 ("local variable 'foo' is assigned to but never used") * Remove assigned but never used local variables * [verify-commits] Add some additional useful documentation. * Increase LevelDB max_open_files unless on 32-bit Unix. * Bugfix: RPC: savemempool: Don't save until LoadMempool() is finished * [contrib] fixup symbol-check.py Python3 support * [contrib] fixup security-check.py Python3 support * adapt bumpfee change discard test to be more strict and add note on p2sh discrep * [tests] Fix intermittent rpc_net.py failure. * Add --with-sanitizers option to configure * Improve formatting of developer notes * Add Marco-expired-key-signed-commits to allow-revsig-commits * Revert "test: Update trust git root". * init: Remove help text for non-existent -fuzzmessagestest arg * contrib: Remove unused import string * contrib: Fix check-doc script regexes * [Tests] fix a typo in TestNode.assert_start_raises_init_error() * test: List any failed tests at the end of test_runner output * Make base58 python contrib code work with python3 * test: Make summary row bold-red if any test failed * Track negated arguments in the argument paser. * Add additional tests for GetBoolArg() * qa: Fix function names in feature_blocksdir * Fix error in memory usage calculation (unintended integer division) * [wallet] Add dummy wallet init class * [wallet] Use global g_wallet_init_interface to init/destroy the wallet. * doc: Add note about our preference for scoped enumerations ("enum class") * Set SCHED_BATCH priority on the loadblk thread. * Use explicit casting in cuckoocache's compute_hashes(...) to clarify integer conversion * doc: Refer to witness reserved value as spec. in the BIP * init: Fix help message for checkblockindex * Change all python files to use Python3 * do not truncate .dat extension for wallets in gui * qt: Avoid resetting on resetguisettigs=0 * [wallet] Create wallet init interface. * [wallet] Move wallet init functions into WalletInit class. * [Tests] Use blockmaxweight where tests previously had blockmaxsize * rpc: Adjust ifdef to avoid unreachable code * Qt: hide RPCConsole wallet selector when no wallets are present * Qt: show wallet name in request dlg in case of multiwallet * Qt: show wallet name in send confirmation dlg in case of multiwallet * GUI: RPCConsole: Log wallet changes * Qt: Get wallet name from WalletModel rather than passing it around * Qt: When multiple wallets are used, include in notifications the name * Qt: QComboBox::setVisible doesn't work in toolbars, so defer adding it at all until needed * Qt: Add wallet selector to debug console * Reduce variable scopes * [RPC] Remove field in getblocktemplate help that has never been used * Introduce interface for signing providers * Qt: Remove unused method setupAmountWidget(...) * Add username and ip logging for RPC method requests * [REST] Handle UTXO retrieval when ignoring the mempool * Make CTxMemPool::isSpent() const * rpc: Add testmempoolaccept * Move CKeyStore::cs_KeyStore to CBasicKeyStore * Inline CKeyStore::AddKey(const CKey &) in CBasicKeyStore * [CI]: bump travis timeout for make check to 50m * add release note for sendmany output shuffling * shuffle sendmany recipients ordering to shuffle tx outputs * Docs: Improve documentation on standard communication channels * Add lint-include-guards.sh which checks include guard consistency * Fix missing or inconsistent include guards * Document include guard convention * [config] Remove blockmaxsize option * [tests] Change feature_csv_activation.py to use BitcoinTestFramework * [tests] Move utility functions in feature_csv_activation.py out of class. * [tests] Remove nested loops from feature_csv_activation.py * Move compressor utility functions out of class * Add native support for serializing char arrays without FLATDATA * Replace boost::call_once with std::call_once * feebumper: discard change outputs below discard rate * shuffle selected coins before transaction finalization * Qt: Warn users about invalid-BIP21 URI bitcoin:// * Fix typos * tests: Remove unused argument max_invalid from check_estimates(...) * Fix typos * Make FastRandomContext support standard C++11 RNG interface * use base58 map instead of strchr() * Support serialization as another type without casting * Remove unnecessary NONNEGATIVE_SIGNED * -blocksdir: keep blockindex leveldb database in datadir * tests: Test connecting with non-existing RPC cookie file * tests: Test connecting to a non-existing server * qa: Allow for partial_match when checking init error * scripted-diff: rename TestNode to TestP2PConn in tests * [tests] Improve assert message when wait_until() fails * [tests] Change feature_block.py to use BitcoinTestFramework * qa: Use node.datadir instead of tmpdir in test framework * Rename wallet_accounts.py test * Rename account to label where appropriate * Remove unreachable help conditions * [tests] Add logging to feature_block.py * [tests] Tidy up feature_block.py * [tests] Fix flake8 warnings in feature_block.py * tests: Add lint-tests.sh which checks the test suite naming convention * tests: Rename test suits not following the test suite naming convention * tests: Add note about test suite naming convention * Qt: remove "new" button during receive-mode in addressbook * Avoiding 'file' function name from python2 with more descriptive variable naming * [tests] improve logging in feature_csv_activation.py * [tests] fix flake8 nits in feature_csv_activation.py * [Tests] Require exact match in assert_start_raises_init_eror() * [Tests] Move assert_start_raises_init_error method to TestNode * QA: Add -blocksdir test * wallet: Change output type globals to members * Append scripts to new test_list array to fix bad assignment * [Trivial] Simplify if-else blocks and more descriptive variable naming * Make verify-commits.sh test that merges are clean * test: Use os.path.join consistently in feature_pruning tests * test: Use wait_until in tests where time was used for polling * Add static_assert to prevent VARINT(<signed value>) * Document RPC method aliasing * Test that BnB is not used when there are preset inputs * Remove redundant checks for MSG_* from configure.ac * Do not check for main() in libminiupnpc * ax_boost_{chrono,unit_test_framework}.m4: take changes from upstream * Actually disable BnB when there are preset inputs * Remove unused variable in SortForBlock * Provide relevant error message if datadir is not writable. * Polish interfaces around PeerLogicValidation * Apply hardening measurements in bitcoind systemd service file * Support deserializing into temporaries * Merge READWRITEMANY into READWRITE * Fix ComputeTimeSmart test failure with -DDEBUG_LOCKORDER * travis: Clone depth 1 unless $CHECK_DOC * Add a test to make sure that negative effective values are filtered * Benchmark BnB in the worst case where it exhausts * Have SelectCoinsMinConf and SelectCoins use BnB or Knapsack and use it * Add a GetMinimumFeeRate function which is wrapped by GetMinimumFee * Move original knapsack solver tests to coinselector_tests.cpp * Move current coin selection algorithm to coinselection.{cpp,h} * Add tests for the Branch and Bound algorithm * Remove coinselection.h -> wallet.h circular dependency * Use a struct for output eligibility * Move output eligibility to a separate function * Implement Branch and Bound coin selection in a new file * [qa] util: Remove unused sync_chain * qt: Avoid querying unnecessary model data when filtering transactions * rpc: Update createrawtransaction examples * Split up and sanitize CAccountingEntry serialization * Ubuntu xenial first dependencies * Increase signal-to-noise ratio in debug.log by adjusting log level when logging failed non-manual connect():s * Allow to optional specify the directory for the blocks storage * configure: UniValue 1.0.4 is required for pushKV(, bool) * Log fatal LevelDB errors more verbosely * Store effective value, fee, and long term fee in CInputCoin * Calculate and store the number of bytes required to spend an input * Split up and sanitize CWalletTx serialization * scripted-diff: Convert 11 enums into scoped enums (C++11) * Format timestamps using ISO 8601 formatting (e.g. "2018-02-28T12:34:56Z") * bitcoin-cli: Provide a better error message when bitcoind is not running * [wallet] Get rid of CWalletTx default constructor * [wallet] Construct CWalletTx objects in CommitTransaction * qa: Cache only chain and wallet for regtest datadir * [rpc] createrawtransaction: Accept sorted outputs * CheckMinimalPush comments are prescriptive * Simplify Base32 and Base64 conversions * [gitian] Add kallewoof key for signing * [gitian] Re-order keys by owner first name alphabetic order * Add tests of listreceivedbyaddress address filtering * Add address filtering to listreceivedbyaddress * qt: Remove TransactionTableModel::TxIDRole * Generalize ConvertBits * qa: Fix some tests to work on native windows * Limit the number of IPs we use from each DNS seeder * depends: biplist 1.0.3 * Give hint about gitian not able to download * [tests] bind functional test nodes to 127.0.0.1 * p2wpkh, p2wsh and p2sh-nested scripts in decodescript * doc: Mention configure without wallet in FreeBSD instructions * net: Correct addrman logging * Add LookupBlockIndex function * Add documentation to PeerLogicValidation interface and related functions * Add missing cs_lock in CreateWalletFromFile * Fix cs_main lock in LoadExternalBlockFile * Lock cs_main while loading block index in AppInitMain * Assert cs_main is held when accessing mapBlockIndex * Add test-before-evict discipline to addrman * gui: Show messages as text not html * depends: Remove ccache * qt: Set modal overlay hide button as default * doc: SIGNER can contains space inside now. * test: Update trust git root * Add DynamicMemoryUsage() to LevelDB * Bugfix: RPC: Add missing UnregisterHTTPHandler for /wallet/ * Qt: Ensure UI updates only come from the currently selected walletView * Qt: Add a combobox to toolbar to select from multiple wallets * Qt: Load all wallets into WalletModels * depends: patch pthread_set_name_np out of zeromq * depends: zeromq 4.2.3 * [Depends] Fix Qt build with Xcode 9.2 * depends: Only use D_DARWIN_C_SOURCE when building miniupnpc on darwin * Shut down if trying to connect a corrupted block * Add a test for large tx output scripts with segwit input. * Create new wallet databases as directories rather than files * Allow wallet files not in -walletdir directory * Allow wallet files in multiple directories * Remove deprecated PyZMQ call from Python ZMQ example * docs: Update osx brew install instruction * Fix typos and cleanup * Fix ListCoins test failure due to unset g_wallet_allow_fallback_fee * Show a transaction's virtual size in its details dialog. * gitian-build.sh: fix signProg being recognized as two parameters * [qt] Improved "custom fee" explanation in tooltip * [qt] navigate to transaction history page after send * Consensus: Fix bug when compiler do not support __builtin_clz* * [script] lint-whitespace: improve print linenumber * Add tests for HexStr std::reverse_iterator cases * Add tests for HexStr corner cases * [test] Add tests for self usage in arith_uint256 * [arith_uint256] Do not destroy *this content if passed-in operator may reference it * Allow dustrelayfee to be set to zero * [arith_uint256] Avoid unnecessary this-copy using prefix operator * Remove redundant includes. Conform to header include guidelines. * Use memset() to optimize prevector::resize() * Reduce redundant code of prevector and speed it up * Add new prevector benchmarks. * fix version typo * Add build support for 'gprof' profiling. * [docs] Minor improvements to Compatibility Notes * test: Use wait_until to ensure ping goes out * Fix typos * doc: Add historical release notes for 0.16.0 * [Tests] Check output of parent/child tx list from getrawmempool, getmempooldescendants, getmempoolancestors, and REST interface * [RPC] Add list of child transactions to verbose output of getrawmempool * [QA] add wallet-rbf test * Disable wallet fallbackfee by default on mainnet * Avoid unintentional unsigned integer wraparounds in tests * rpc: Allow typeAny in RPCTypeCheck * Don't test against the mempool min fee information in mempool_limit.py * test: Plug memory leaks and stack-use-after-scope * createmultisig no longer takes addresses * Declare CMutableTransaction a struct in rawtransaction.h * [depends] Allow depends system to support armv7l * Bugfix: respect user defined configuration file (-conf) when open conf. file from QT settings * init: Remove translation for `-blockmaxsize` option help * [test] Round target fee to 8 decimals in assert_fee_amount * Split off key_io_tests from base58_tests * Split key_io (address/key encodings) off from base58 * Stop using CBase58Data for ext keys * Replace CBitcoinSecret with {Encode,Decode}Secret * qa: Fix python TypeError in script.py * docs: clarified systemd installation instructions in init.md for Ubuntu users. * Add test for signrawtransaction * scripted-diff: change signrawtransaction to signrawtransactionwithwallet in tests * Split signrawtransaction into wallet and non-wallet * Add setter for g_initial_block_download_completed * fixes #12465 added missing terminating newline character in log message * Revert "[tests] bind functional test nodes to 127.0.0.1" * Assert CPubKey::ValidLength to the pubkey's header-relevent size * [doc] dev-notes: Members should be initialized * test: Fix bip68 sequence test to reflect updated rpc error message * scripted-diff: validateaddress to getaddressinfo in tests * Create getaddressinfo RPC and deprecate parts of validateaddress * [rpc] Move DescribeAddressVisitor to rpc/util * Only call NotifyBlockTip when the active chain changes * [tests] Add a (failing) test for waitforblockheight * Squashed 'src/leveldb/' changes from c521b3ac65..64052c76c5 * rpc: Interrupt block generation on shutdown request * test: Add missing signal.h header * [rpc] split wallet and non-wallet parts of DescribeAddressVisitor * gitian: bump descriptors for (0.)17 * travis: Full clone for git subtree check * qa: Improve getchaintxstats functional test * rpc: Refactor blockhash parse in getchaintxstats * devtools: Exclude patches from lint-whitespace * qa: Move common args to bitcoin.conf * Fix overly eager BIP30 bypass * test: Add unit test for LockDirectory * util: Fix multiple use of LockDirectory * fixme: depends: Add D_DARWIN_C_SOURCE to miniupnpc CFLAGS * [depends] latest config.guess and config.sub * [depends] miniupnpc 2.0.20180203 * [depends] ccache 3.4.1 * [depends] expat 2.2.5 * Fix typo in test_runner.py causing error * [qt] send: Clear All also resets coin control options * Make signrawtransaction accept P2SH-P2WSH redeemscripts * Update mac_alias to 2.0.7 * Delete mac_alias patch * [tests] Change invalidblockrequest to use BitcoinTestFramework * [tests] Fix flake8 warnings in invalidblockrequest * [test] Fix nits leftover from 11771 * qt: Initialize members in WalletModel * Remove useless string initialization. * Add some script tests related to BOOL ops and odd values like negative 0. * Fix rescan test failure due to unset g_address_type, g_change_type * fix possible shutdown assertion with -reindex-shutdown * Fix Windows build errors introduced in #10498 * Interrupt loading thread after shutdown request * Reset pblocktree before deleting LevelDB file * Fix a-vs-an typos * rpc: Reject deprecated reserveChangeKey in fundrawtransaction * Improve "Turn Windows Features On or Off" step * scripted-diff: Use UniValue.pushKV instead of push_back(Pair()) * Squashed 'src/univalue/' changes from 07947ff2da..51d3ab34ba * [scripts] gitian-builder.sh: fix --setup doc, LXC is default * [QA] add NODE_NETWORK_LIMITED address relay and sync test * [QA] fix mininode CAddress ser/deser * [QA] Allow addrman loopback tests (add debug option -addrmantest) * Connect to peers signaling NODE_NETWORK_LIMITED when out-of-IBD * Accept addresses with NODE_NETWORK_LIMITED flag * Fix ignoring tx data requests when fPauseSend is set on a peer * Refactor: One CBaseChainParams should be enough * boost: drop boost threads for [alert|block|wallet]notify * boost: drop boost threads from torcontrol * boost: remove useless threadGroup parameter from Discover * boost: drop boost threads for upnp * [wallet] Indent only change of CWallet::AvailableCoins * [wallet] Make CWallet::ListCoins atomic * Consistently use FormatStateMessage in RPC error output * Add test for 'mempool min fee not met' rpc error * Fix 'mempool min fee not met' debug output * [RPC] Remove deprecated addmultisigaddress return format * [RPC] Remove deprecated createmultisig object * [tests] Remove test for deprecated createmultsig option * qt: Poll ShutdownTimer after init is done * qt: Clarify some comments * qt: Make sure splash screen is freed on AppInitMain fail * http: Remove numThreads and ThreadCounter * Bech32 addresses in dumpwallet * Add gitian PGP key: akx20000 * Fix fast-shutdown crash if genesis block was not loaded * Fix fast-shutdown hang on ThreadImport+GenesisWait * Add braces to meet code style on line-after-the-one-changed. * http: Remove WaitExit from WorkQueue * http: Join worker threads before deleting work queue * Hold mempool.cs for the duration of ATMP. * add fivepiece key fingerprint * wallet: Disallow abandon of conflicted txes * [tests] Update README after filename change * Add AbsPathForConfigVal to consolidate datadir prefixing for path args * Clarify help messages for path args to mention datadir prefix * [rpc] Remove deprecated getmininginfo RPC option * [rpc] remove deprecated estimatefee RPC * Use ptrdiff_t type to more precisely indicate usage and avoid compiler warnings. * Extend #11583 to include the most common message generated by non-contributing peers (port scanners?) 37% of the log default log entries for a node that has been up for ~24hrs was "version handshake timeout..." * [tests] Remove estimatefee from rpc_deprecated.py test * [tests] Remove tests for deprecated estimatefee RPC * [tests] Fix style warnings in feature_fee_estimation.py * Document method for reviewers to verify chainTxData * Properly alphabetize output of CLI --help option. * [rpc] Reduce scope of cs_main and cs_wallet locks in listtransactions * [gui] Defer coin control instancing * net: don't retry failed oneshot connections forever * net: initialize socket to avoid closing random fd's * Remove suggestion to make cloned repository world-writable for Windows build. * QA: segwit.py: s/find_unspent/find_spendable_utxo/ * doc: Explain how to update chainTxData in release process * contrib: Add support for out-of-tree builds in gen-manpages.sh * Fix missing cs_main lock for GuessVerificationProgress() * Organise Linux build instructions to be categorised by distro * Add NetBSD build instruction links * test: Make ua_comment test pass on 0.16.0 * [tests] Change invalidtxrequest to use BitcoinTestFramework * [tests] Fix flake8 warnings in invalidtxrequest * [tests] Add P2PDataStore class * doc: Update manpages to 0.16.99 * build: Bump version to 0.16.99 * qt: Periodic translations update * [tests] Require all tests to follow naming convention * [build] Add NETBSD leveldb target to configure.ac * [doc] Create build-netbsd.md * Refactor HaveKeys to early return on false result * feebumper: Use PreconditionChecks to determine bump eligibility * Add special error for genesis coinbase to gettransaction * Enable flake8 warnings for all currently non-violated rules * tests: Fix accidental redefinition of previously defined variable via list comprehension * Enable flake8 warning for "list comprehension redefines 'foo' from line N" (F812) * [net] add seed.bitcoin.sprovoost.nl to DNS seeds * [tests] Reduce NodeConn connection logging from info to debug * [build] Add db4_cxx to bitcoin_find_bdb48.m4 * [rpc] Mention that HD is enabled if hdmasterkeyid is present * [tests] Fix names of excluded extended tests for travis * Remove redundant code in MutateTxSign(CMutableTransaction&, const std::string&) * [wallet] Remove duplicate mapWallet lookups * Fix typos * Avoid leaking prioritization information when relaying transactions * fee estimator: avoid sorting mempool on shutdown * Build: Add a makefile target for Doxygen documentation * Update chainTxData for 0.16 * Move scheduler/threadGroup into common-init instead of per-app * Update defaultAssumeValid according to release-process.md. * qa: Add missing syncwithvalidationinterfacequeue to tests * Fix intermittent failure in p2p-versionbits-warning.py * Improve comments/logging in p2p-versionbits-warning.py * Fix flake8 warnings in p2p-versionbits-warning.py * [tests] Remove EXPECTED_VIOLATION_COUNT * [tests] Rename misc functional tests. * [tests] Rename rpc_* functional tests. * [tests] Rename p2p_* functional tests. * [tests] Rename wallet_* functional tests. * [tests] Rename feature_* functional tests. * qa: Prepare functional tests for Windows * net: Update hardcoded seeds * contrib: Update ATTERN_AGENT to include 0.15.x * initwallet: Do not translate highly technical addresstype help * [qa] Use address type in addmultisigaddress to avoid addwitnessaddress * qt: Bump BLOCK_CHAIN_SIZE to 200GB * [Trivial] link mentioned scripted-diff-commit * [qa] Test fundrawtransaction with change_type option * [rpc] Add change_type option to fundrawtransaction * [wallet] Add change type to CCoinControl * qt: Update translation source file * tx: Update transifex slug for 0.16 * [rpc] Add address type option to addmultisigaddress * net: Move misbehaving logging to net logging category * Mention that other RPC calls report keys as "imported" while txns are still missing * Reduce cs_main lock in ReadBlockFromDisk, only read GetBlockPos under the lock * Make sure WalletRescanReserver has successfully reserved the rescan * Add RAII wallet rescan reserver * Avoid pemanent cs_main/cs_wallet lock during wallet rescans * move more bumpfee prechecks to feebumper::PreconditionChecks * qa: Make TestNodeCLI command optional in send_cli * qa: Rename cli.args to cli.options * Make CKey::Load references const * [wallet] use P2WPKH change output if any destination is P2WPKH or P2WSH * [trivial][docs] Fix incorrect link in /test/ README.md * Update chainparams comment for more info on service bits per dnsseed * Fall back to oneshot for DNS Seeds which don't support filtering. * Use GetDesireableServiceFlags in static seeds, document this. * test_runner: Readable output if create_cache.py fails * Updating benchmarkmarking.md with an updated sample output and help options * Correct mempool mapTx comment * Use PACKAGE_NAME instead of hardcoding application name in log message * Don't allow relative -walletdir paths * wallet: Deprecate addwitnessaddress * Trivial: Fix spelling in zapwallettxes test description * qa: Sync with validationinterface queue in sync_mempools * Avoid potential null dereference in ReceiveCoinsDialog constructor * rpc: Add deprecation error for `getinfo` * [qt] receive tab: bech32 address opt-in checkbox * [tests] bind functional test nodes to 127.0.0.1 * Log debug build status and warn when running benchmarks * Abstract directory locking into util.cpp * Make .walletlock distinct from .lock * Generalise walletdir lock error message for correctness * Add a test for wallet directory locking * Add a lock to the wallet directory * Use flexible font size for QRCode image address * [docs] Clarify -walletdir usage * Use mempool's ancestor sort in transaction selection * trivial: fix address_type help text of getnewaddress and getrawchangeaddress * Add test for new ancestor feerate sort behavior * Trivial: Fix #include sys/fcntl.h to just fcntl.h (without sys/) * Make segwit failure due to CLEANSTACK violation return a SCRIPT_ERR_CLEANSTACK error code. * Test walletpassphrase timeout bounds and clamping * Clamp walletpassphrase timeout to 2^(30) seconds and check its bounds * Use the character based overload for std::string::find. * Disallow using addresses in createmultisig * Fix ListCoins test failure due to unset g_address_type, g_change_type * [Doc] Fix link for bip 159 pull request * Add address_types test * Support downgrading after recovered keypool witness keys * SegWit wallet support * Implicitly know about P2WPKH redeemscripts * [test] Serialize CTransaction with witness by default * Support P2WPKH and P2SH-P2WPKH in dumpprivkey * Support P2WPKH addresses in create/addmultisig * Fix rare failure in p2p-segwit.py * Sort mempool by min(feerate, ancestor_feerate) * Refactor CompareTxMemPoolEntryByDescendantScore * Remove unused mempool index * Allow multiwallet.py to be used with --usecli * [tests] allow tests to be run with --usecli * TestNodeCLI batch emulation * Prevent TestNodeCLI.args mixups * Improve TestNodeCLI output parsing * [scripts] lint-whitespace: check last N commits or unstaged changes * Remove the ending slashes from RPC URI format. * [Refactor] Remove unused fQuit var from checkqueue.h * fix nits: variable naming, typos * [qa] Improve prioritisetransaction functional test * [scripts] lint-whitespace: use perl instead of grep -P * [contrib] Add --disable-replication to install_db4 * [contrib] Use BDB_LIBS/CFLAGS in install_db4 * Fix incorrect Markdown link * Replaces numbered place marker %2 with %1. * Adding test case for SINGLE|ANYONECANPAY hash type in tx_valid.json * [qt] Add support to search the address book * [tests] util_tests.cpp: actually check ignored args * Extend validateaddress information for P2SH-embedded witness * Expose method to find key for a single-key destination * Improve witness destination types and use them more * [refactor] GetAccount{PubKey,Address} -> GetAccountDestination * Abstract out IsSolvable from Witnessifier * [tests] Remove redundant import in blocktools.py test * Fixes issue #12067 `sendmany` curl example is wrong. * Increment MIT Licence copyright header year on files modified in 2017 * [scripts] Add missing univalue file to copyright_header.py * [qt] Simplifies boolean expression model && model->haveWatchOnly() * [Trivial] Update license year range to 2018 * bips: add bip176 (Bits Denomination) * Implements a virtual destructor on the BaseRequestHandler class. * [rpc] Adding ::minRelayTxFee amount to getmempoolinfo and updating mempoolminfee help description * Use best-fit strategy in Arena, now O(log(n)) instead O(n) * [qt] change µBTC to bits * remove brew c++ flag * Add helper to wait for validation interface queue to catch up * Block ActivateBestChain to empty validationinterface queue * Add an interface to get the queue depth out of CValidationInterface * Require no cs_main lock for ProcessNewBlock/ActivateBestChain * Avoid cs_main in net_processing ActivateBestChain calls * Refactor ProcessGetData in anticipation of avoiding cs_main for ABC * bluematt's testnet-seed now supports x9 (and is just a static list) * [Doc] Clarify the meaning of fee delta not being a fee rate in prioritisetransaction RPC * Removed CCheckQueueSpeed benchmark * Improved microbenchmarking with multiple features. * [build] .gitignore: add QT Creator artifacts * doc: Update OpenBSD build instructions for 6.2 * [Wallet] Use RBF by default in QT only * depends: fix libzmq's needless linking against libstdc++ * qa: Note on test order in test_runner * Improve readability by removing redundant casts to same type (on all platforms) * clientversion: Use full commit hash for commit-based version descriptions * doc: Update FreeBSD build instructions to use bdb4 * contrib: FreeBSD compatibility in install_db4.sh * [Doc] Fix link to installation script * Add script birthtime metadata to dump and import wallet * Add script dump note to RPC help text and release notes * Add test for importwallet * Add dumpwallet scripts test * Add scripts to importwallet RPC * Add CScripts to dumpwallet RPC * Add GetCScripts to CBasicKeyStore * Add configuration/argument testing * Squashed 'src/univalue/' changes from fe805ea74f..07947ff2da * [tests] refactor node_network_limited * [tests] remove redundant duplicate tests from node_network_limited * [tests] node_network_limited - remove race condition * [tests] define NODE_NETWORK_LIMITED in test framework * [tests] fix flake8 warnings in node_network_limited.py * Remove dead feeest-file read code for old versions * [docs] initial QT documentation, move Qt Creator instructions * test: Fix rawtransactions test * contrib: Remove xpired 522739F6 key * tests: Remove unused variable (firstAddrnServices) * contrib: Make X=Y arguments work in install_db4 * contrib: New clang patch for install_db4 * contrib: fix typo in install_db4.sh help message * [build] Warn that only libconsensus can be built without boost * contrib: Replace developer keys with list of pgp fingerprints * remove unused fNoncriticalErrors variable from CWalletDB::FindWalletTx * [net] add seed.testnet.bitcoin.sprovoost.nl to testnet DNS seeds * Typo fix * Create new mutex for orphans, no cs_main in PLV::BlockConnected * Use std::thread::hardware_concurrency, instead of Boost, to determine available cores * Add required package dependencies for depends cross compilation [skip-ci] * simplify CheckMinimalPush checks, add safety assert * [wallet] Make CWallet::FundTransaction atomic * [wallet] Tidy up CWallet::FundTransaction * Drop extra script variable in ProduceSignature * Clarify getbalance meaning a tiny bit in response to questions. * test: Add createrawtransaction functional tests * test: Add multidict to support dictionary with duplicate key (laanwj) * Remove unused include in hash.cpp * Update files.md for new wallets/ subdirectory * Cleanups for walletdir PR * net: use CreateSocket for binds * net: pass socket closing responsibility up to caller for outgoing connections * net: Move IsSelectableSocket check into socket creation * net: split socket creation out of connection * Stop special-casing phashBlock handling in validation for TBV * [tests] remove redundant univalue_tests.cpp * rpc: Validate replaceable type in createrawtransaction * wallet: Remove unnecessary mempool lock in ReacceptWalletTransactions * Do not un-mark fInMempool on wallet txn if ATMP fails. * [tests] Add NetworkThread assertions * [tests] Fix network threading in functional tests * [tests] Use network_thread_start() in tests. * [tests] Add network_thread_ utility functions. * add test for unconfirmed balance between restarts * don't attempt mempool entry for wallet transactions on startup if already in mempool * Add Travis check for unused Python imports * Remove unused Python imports * Fix string concatenation to os.path.join and add exception case * Split up key and script metadata for better type safety * gui: Fix proxy setting options dialog crash * [tests] Check tests conform to naming convention * Make boost::multi_index comparators const * [Doc] Update bip.md, add support for BIP 159 * [QA] Add node_network_limited test * [build] Add missing stuff to clean-local - test/functional/test_framework/__pycache__ - test/cache * doc: Update release notes for share/rpcauth/rpcauth.py rename * qa: Add getrawtransaction in_active_chain=False test * Rename rpcuser.py to rpcauth.py * Avoid leaking the prune height through getdata (fingerprinting countermeasure) * Always set NODE_NETWORK_LIMITED bit * Add NODE_NETWORK_LIMITED flags and min block amount constants * [verify-commits] Fix gpg.sh's echoing for commits with '\n' * Always return true if AppInitMain got to the end * rpcuser.py: Use 'python' not 'python2' * Test datadir in conf file exists * [test] Add tests for getrawtransaction with block hash. * [rpc] Allow getrawtransaction to take optional blockhash to fetch transaction from a block directly. * Avoid calling GetSerializeSize on each tx in a block if !fTxIndex * Move some additional variables into CChainState private * Create initial CChainState to hold chain state information * Move block writing out of AcceptBlock * Move txindex/undo data disk location stuff out of ConnectBlock * Make DisconnectBlock unaware of where undo data resides on disk * [docs] Fixed outdated link with archive.is * test: Add tests for `-debuglogfile` with subdirs * doc: Update release notes for `-debuglogfile` * test: Add test for `-debuglogfile` * Loop through the bip9 soft fork deployments instead of hard coding * Add `-debuglogfile` option * [tests] README.md nit fixes * Docs: Bump OSX version to 10.13 in build-osx.md * Prefix leveldb debug logging * Trivial: fix comments for ZeroMQ bitcoind args * [tests] Rename NodeConn and NodeConnCB * [tests] Add combinedlogslen argument to test_runner.py * [tests] [travis-ci] Move Travis functional test log post processing to test_runner * [tests] Improve logging shutdown and add hint for combine_logs * depends: fix zmq build with mingw < 4.0 * [depends] ZeroMQ 4.2.2 * [rpc] Fix fVerbose parsing (remove excess if cases). * [tests] Move version message sending from NodeConn to NodeConnCB * [tests] Make NodeConnCB a subclass of NodeConn * [tests] Move only: move NodeConnCB below NodeConn * [tests] Tidy up mininode * Fix shutdown in case of errors during initialization * threads: add a thread_local autoconf check * [tests] Remove mininode periodic (half-hour) ping messages * Add Clang thread safety analysis annotations * [Docs] Bump minimum required version of GCC to 4.8 * [Tests] Adding unit tests for GetDifficulty in blockchain.cpp. * [tests] Remove rpc property from TestNode in p2p-segwit.py. * clarify abortrescan rpc use * Fix: Open files read only if requested * trivial: Fix unsuccessful typo * net: Add missing locks in net.{cpp,h} * Remove redundant locks * Fix sendrawtransaction hang when sending a tx already in mempool * Document partial validation in ConnectBlock() * [docs] links to code style guides * Improve help text and behavior of RPC-logging * Call BannedListChanged outside of cs_setBanned lock * Switched sync.{cpp,h} to std threading primitives. * tests: move pwalletMain to wallet test fixture * [Qt] Improved copy: RBF checkbox, tooltip and confirmation screen * [tests] Test that mempool rejects coinbase transactions * Fix for mismatched extern definition in wallet test classes which was breaking msvc linking. * Add help-console command to Qt debug console * [tests] address review comments * tests: Remove unused mininode functions deser_int_vector(f) and ser_int_vector(l) * Remove unused imports * scripted-diff: Orthogonalize string quoting * bitcoin_qt.m4: Add missing dollar sign for variable. * bitcoin_qt.m4: Add missing braces around variables in autoconf messages. * bitcoin_qt.m4: Use correct M4 quoting characters. * bitcoin_qt.m4: Improve QT_VERSION tests. * cli: Reject arguments to -getinfo * doc: Specify required source location for Windows WSL builds * Make debugging test crash easier * Create walletdir if datadir doesn't exist and fix tests * Default walletdir is wallets/ if it exists * Add release notes for -walletdir and wallets/ dir * Add test for -walletdir * Add -walletdir parameter to specify custom wallet dir * Remove includes in .cpp files for things the corresponding .h file already included * [docs] Add reference to install_db4.sh in OS X build instructions * [build] Add a script for installing db4 * [tests] fix flakiness in sendheaders.py * [tests] refactor check_last_announcement() in sendheaders.py * [tests] tidy up BaseNode in sendheaders.py * Make default issue text all comments to make issues more readable * [tests] fix flake8 warnings in sendheaders.py * Add gitian PGP key: willyko * [travis-ci] Only run linters on Pull Requests * Remove trailing whitespace causing travis failure * Recommend #include<> syntax in developer notes * refactor: Include obj/build.h instead of build.h * test: refactor: Use absolute include paths for test data files * qt: refactor: Changes to make include paths absolute * build: Remove -I for everything but project root * qt: refactor: Use absolute include paths in .ui files * scripted-diff: Replace #include "" with #include <> (ryanofsky) * qa: Add multiwallet prefix test * fix the StartupWMClass for bitoin-qt, so gnome-shell can recognize it * [build] Add temp_bitcoin_locale_qrc to CLEAN_QT to fix make distcheck * [docs] Add instructions for lcov coverage report generation * Make ISSUE_TEMPLATE a bit shorter, mention hardware tests * trivial: Fix typo – "Ubutntu" → "Ubuntu" * Update WSL installation for Fall Creators update * qa: Remove unused NodeConn members * Initialize recently introduced non-static class member lastCycles to zero in constructor * qa: Only allow disconnecting all NodeConns * contrib/init: Update openrc-run filename * Add note about Valgrind suppressions file in developer-notes.md * doc: Add getreceivedbyaddress release notes * doc: Add historical release notes for 0.15.1 * During IBD, when doing pruning, prune 10% extra to avoid pruning again soon after * GUI: Receive: Remove option to reuse a previous address * [wallet] Change feebumper from class to functions * [refactor] Make feebumper namespace * [trivial] Rename feebumper variables according to project code style * [wallet] getreceivedbyaddress should return error if address is not mine * [tests] Tidy up receivedby.py * [tests] Tidy up mininode.py module * [tests] Move test_framework Bitcoin primitives into separate module * tests: Add missing locks to tests * Explicitly state assumption that state.m_chain_sync.m_work_header != nullptr in ConsiderEviction * Qt: Enable searching by transaction id * Qt: Avoid invalidating the search filter, when it doesn't really change * Qt: Rename confusingly-named "address prefix" to "search string" * Do not make it trivial for inbound peers to generate log entries * Revert "Remove unused variable in shell script" * Minimal code changes to allow msvc compilation. * Require a steady clock for bench with at least micro precision * Update ban-state in case of dirty-state during periodic sweep * Use MakeUnique<Db>(...) * Use MakeUnique<T>(...) instead of std::unique_ptr<T>(new T(...)) * Add MakeUnique (substitute for C++14 std::make_unique) * Use unique_ptr for pcoinscatcher/pcoinsdbview/pcoinsTip/pblocktree * Use unique_ptr for pdbCopy (Db) and fix potential memory leak * Use unique_ptr for dbenv (DbEnv) * Use unique_ptr for pfilter (CBloomFilter) * Use unique_ptr for sem{Addnode,Outbound} (CSemaphore) * Use unique_ptr for upnp_thread (boost::thread) * Use unique_ptr for dbw (CDBWrapper) * Use unique_ptr:s for {fee,short,long}Stats (TxConfirmStats) * Use unique_ptr for httpRPCTimerInterface (HTTPRPCTimerInterface) * Use unique_ptr for pwalletMain (CWallet) * Fix qt build broken by 5a5e4e9 * [Tests] check specific validation error in miner tests * [tests] Explicitly disallow support for p2p versions below 60001 * [tests] Remove support for p2p alert messages * [tests] Remove support for bre-BIP31 ping messages * [tests] Remove dead code from mininode.py * [tests] use TestNode p2p connection in tests * [tests] Add p2p connection to TestNode * [tests] fix TestNode.__getattr__() method * trivial: Fix typo – alreardy → already * [net] De-duplicate connection eviction logic * bench: prefer a steady clock if the resolution is no worse * bench: switch to std::chrono for time measurements * Fix -disablewallet default value * Improve -disablewallet parameter interaction * Docs: Change formatting for sequence of steps * rpc: Make logging RPC public * Add missing cs_main locks when calling blockToJSON/blockheaderToJSON * Have SegWit active by default * Unit tests for always-active versionbits. * Always-active versionbits support * [consensus] Pin P2SH activation to block 173805 on mainnet * Improve handling of BIP9Deployment limits * Add mutex requirement for AddToCompactExtraTransactions(…) * Use -Wthread-safety-analysis if available (+ -Werror=thread-safety-analysis if --enable-werror) * Fix -Wthread-safety-analysis warnings. Change the sync.h primitives to std from boost. * [build] .gitignore: add background.tiff * [build] Don't fail when passed --disable-lcov and lcov isn't available * Add sjors gitian key * [trivial] Fix error messages in CFeeBumper * Move RPC registration out of AppInitParameterInteraction * rpc: further constrain the libevent workaround * [test] Verify node doesn't send headers that haven't been fully validated * Add unit test for stale tip checking * Add CConnmanTest to mutate g_connman in tests * Connect to an extra outbound peer if our tip is stale * rpc: work-around an upstream libevent bug * Track tip update time and last new block announcement from each peer * net: Allow connecting to extra outbound peers * [Wallet] always show help-line of wallet encryption calls * Make p2p-acceptablock not an extended test * [qa] test that invalid blocks on an invalid chain get a disconnect * Reject headers building on invalid chains by tracking invalidity * Accept unrequested blocks with work equal to our tip * Stop always storing blocks from whitelisted peers * Rewrite p2p-acceptblock in preparation for slight behavior changes * addrman: Add missing lock in Clear() (CAddrMan) * Do not send (potentially) invalid headers in response to getheaders * net: Add missing lock in ProcessHeadersMessage(...) * Fix warnings when building with DEBUG_ADDRMAN * [Util] Update tinyformat.h * Fixed a couple small grammatical errors. * Disconnect outbound peers relaying invalid headers * moveonly: factor out headers processing into separate function * Add unit test for outbound peer eviction * Permit disconnection of outbound peers on bad/slow chains * Disconnecting from bad outbound peers in IBD * [trivial] (whitespace only) fix getblockchaininfo alignment * [rpc] Add initialblockdownload to getblockchaininfo * Make listsinceblock refuse unknown block hash * [tests] Add fuzz testing for BlockTransactions and BlockTransactionsRequest * [Docs] Update OpenBSD Build Instructions for OpenBSD 6.2 * Sanity-check script sizes in bitcoin-tx * Improve wallet-accounts test * qa: Fix race condition in sendheaders.py * [Build] Add AM_OBJCXXFLAGS and QT_PIE_FLAGS to OBJCXXFLAGS to future-proof darwin targets * Fix automake warnings when running autogen.sh * [verify-commits] Allow revoked keys to expire * qa: Fix replace-by-fee race condition failures * Add comment explaining forced processing of compact blocks * qa: add test for minchainwork use in acceptblock * Don't process unrequested, low-work blocks * Add share/rpcuser to dist. source code archive * Avoid slow transaction search with txindex enabled * Avoid opening copied wallet databases simultaneously * Remove my testnet DNS seed as I currently don't have the capacity to keep it up to date. * Wrap dumpwallet warning and note scripts aren't dumped * [ui] Add toggle for unblinding password fields * Revert "travis: filter out pyenv" * travis: move back to the minimal image * Add test cases covering the relevant key length boundaries: 64 bytes +/- 1 byte for HMAC-SHA256 and 128 bytes +/- 1 byte for HMAC-SHA512 * Add quotes to variable assignment (as requested by @TheBlueMatt) * Fix valid path output * Use bash instead of POSIX sh. POSIX sh does not support arrays. * Fix incorrect quoting of quotes (the previous quotes had no effect beyond unquoting) * Add required space to [[ -n "$1" ]] (previously [[ -n"$1" ]]) * Add error handling: exit if cd fails * Remove "\n" from echo argument. echo does not support escape sequences. * Remove unused variables * Updated instructions for Windows 10 Fall Creators Update. * Add Sent and Received information to the debug menu peer list * move human-readable byte formatting to guiutil * [tests] Don't subclass from object for Python 3 * [tests] authproxy.py: tidy up __init__() * [tests] fix flake8 warnings in authproxy.py * [tests] use python3 for authproxy.py * Init: Remove redundant exit(EXIT_FAILURE) instances and replace with return false * Fix crash via division by zero assertion * Updated Windows build doc for WSL/Xenial workarounds. * [wallet] Fix leak in CDB constructor * Add wallet backup text to import*, add* and dumpwallet RPCs * Add missing comma from rescanblockchain * Remove redundant pwallet nullptr check * Add a dev notes document describing the new wallet RPC blocking * Give ZMQ consistent order with UpdatedBlockTip on scheduler thread * Fix wallet RPC race by waiting for callbacks in sendrawtransaction * Also call other wallet notify callbacks in scheduler thread * Use callbacks to cache whether wallet transactions are in mempool * Add calls to CWallet::BlockUntilSyncedToCurrentChain() in RPCs * Add CWallet::BlockUntilSyncedToCurrentChain() * Add CallFunctionInQueue to wait on validation interface queue drain * Add ability to assert a lock is not held in DEBUG_LOCKORDER * Call TransactionRemovedFromMempool in the CScheduler thread * Add a CValidationInterface::TransactionRemovedFromMempool * [trivial] Make namespace explicit for is_regular_file * Switch DNSSeed-needed metric to any-automatic-nodes, not services * Clarify docs for requirements/handling of addnode/connect nodes * Rename fAddnode to a more-descriptive "manual_connection" * Replace relevant services logic with a function suite. * qa: Remove never used return value of sync_with_ping * qa: Make tmpdir option an absolute path * Avoid division by zero in the case of a corrupt estimates file * [QA] Add RPC based rescan test * [Wallet] add rescanblockchain <start_height> <stop_height> RPC command * Diagnose unsuitable outputs in lockunspent(). * [rpc] mempoolinfo should take ::minRelayTxFee into account * [tests] Add uacomment tests * Check subtree consistency in Travis * Improve git-subtree-check.sh * Fix importmulti bug when importing an already imported key * Improve ZMQ functional test * [tests] Add -walletnotify functional test * [tests] Add -blocknotify functional test * [tests] Tidy up forknotify.py * [tests] move witness util functions to blocktools.py * [tests] [docs] update README for new test naming scheme * Ensure backupwallet fails when attempting to backup to source file * Use range-based for loops (C++11) when looping over map elements * fix typo in comment of chain.cpp * Remove accidental stray semicolon * [tests] Make comp test framework more debuggable * Use nullptr instead of NULL * Update importprivkey named args documentation * Fix a vs. an typo * [depends] native_ds_store 1.1.2 * [depends] native_mac_alias 2.0.6 * Fix code style in keystore.cpp/crypter.cpp * scripted-diff: rename assert_raises_jsonrpc to assert_raises_rpc error * [tests] do not allow assert_raises_message to be called with JSONRPCException * [tests] remove direct testing on JSONRPCException from individual test cases * CCrypter: move relevant implementation out of the header * CKeystore: move relevant implementation out of the header * Scope the ECDSA constant sizes to CPubKey / CKey classes * build: Make "make clean" remove all files created when running "make check" * Add test for multiwallet batch RPC calls * Add missing batch rpc calls to python coverage logs * Add missing multiwallet rpc calls to python coverage logs * [gui] reset addrProxy/addrSeparateProxyTor if colon char missing * Make AuthServiceProxy._batch method usable * Limit AuthServiceProxyWrapper.__getattr__ wrapping * Fix uninitialized URI in batch RPC requests * [test] P2P functional test for certain fingerprinting protections * [net] Ignore getheaders requests for very old side blocks * [Docs] Update Windows build instructions for using WSL and Ubuntu 17.04 * Fix validationinterface build on super old boost/clang * Avoid NULL pointer dereference when _walletModel is NULL (which is valid) * Use two boolean literals instead of re-using variable * Remove duplicate uriParts.size() > 0 check * Remove redundant check (!ecc is always true) * Remove redundant NULL checks after new * qa: Fix lcov for out-of-tree builds * Add new step to clean $PATH var by removing /mnt specific Window's %PATH% paths that cause issues with the make system * qa: check-rpc-mapping must not run on empty lists * qa: Restore bitcoin-util-test py2 compatibility * Remove unused fTry from push_lock * Verify DBWrapper iterators are taking snapshots * [rpc] getblockchaininfo: add size_on_disk, prune_target_size, automatic_pruning * add functional test for mempoolreplacement command line arg * Squashed 'src/secp256k1/' changes from 84973d393..0b7024185 * Squashed 'src/univalue/' changes from 16a1f7f6e..fe805ea74 * Fix launchctl not being able to stop bitcoind * Add error string for CLEANSTACK script violation, preventing an "unknown error" if the CLEANSTACK error condition is set. * Correct typo in comments * [Qt] tolerate BIP173/bech32 addresses during input validation * [RPC] Wallet: test importing of native witness scripts * Use BIP173 addresses in segwit.py test * Support BIP173 in addwitnessaddress * Implement BIP173 addresses and tests * Add regtest testing to base58_tests * Convert base58_tests from type/payload to scriptPubKey comparison * Import Bech32 C++ reference code & tests * [docs] Remove partial gitian instructions from descriptors dir * script: Change SignatureHash input index check to an assert. * Add test for bitcoin-cli -getinfo * rpc: Handle `getinfo` locally in bitcoin-cli w/ `-getinfo` * Change getmininginfo errors field to warnings * Unify help text for GetWarnings output in get*info RPCs * Add warnings field to getblockchaininfo * Fix bip68-sequence rpc test * Fix parameter name typo in ErasePurpose walletdb method. * Add state message print to AcceptBlock failure message. * [rpc] [tests] Add deprecated RPC test * [rpc] Deprecate estimatefee RPC * rpc: Prevent `dumpwallet` from overwriting files * net: Improve and document SOCKS code * doc: move gitian building to external repo * [docs] document scripted-diff * fix link error * Remove lxcbr0 lines from gitian-build.sh * Implement {Encode,Decode}Destination without CBitcoinAddress * qt: Backup former GUI settings on `-resetguisettings` * Use static_cast instead of C-style casts for non-fundamental types * Remove some unused functions and methods * Rename out to m_tx_out in CScriptCheck * [script] Unit tests for IsMine * [script] Unit tests for script/standard functions * Replace save|restoreWindowGeometry with Qt functions * Remove extremely outdated share/certs dir * Add tests for CMerkleBlock usage with txids specified * Consolidate CMerkleBlock constructor into a single method * Disallow uncompressed pubkeys in bitcoin-tx [multisig] output adds * Near-Bugfix: Reestablish consensus check removed in 8d7849b * Introduce CheckInputsAndUpdateCoins static wrapper in txmempool.cpp * Optimization: Minimize the number of times it is checked that no money is created * [test] Add getblockchaininfo functional test * [test] Add restart_node to BitcoinTestFramework * doc: Add release notes for 0.15.0.1 * [Tests] Add Qt GUI tests to Overview and ReceiveCoin Page * Tests for zmqpubrawtx and zmqpubrawblock * Remove nBlockMaxSize from miner opt struct as it is no longer used. * net: remove now-unused functions * net: remove now-superfluous numeric resolve * net: separate resolving and conecting * [Qt] Add delay before filtering transactions Fixes 3141 * Small refactor of CCoinsViewCache::BatchWrite() * Refactor: Modernize disallowed copy constructors/assignment * [tests] Check connectivity before sending in assumevalid.py * Remove custom fee radio group * Trivial: Fix validation comments * Fix code constness in CBlockIndex::GetAncestor() overloads * Fix Qt 0.14.2->0.15.0 segfault if "total at least" is selected * Trivial: Fix comments for DEFAULT_WHITELIST[FORCE]RELAY * contrib: Ignore historical release notes for whitespace check * doc: add release-notes for 0.15.0 to master * Fix uninitialized g_connman crash in Shutdown() * Add tab char lint check and exclude imported dependencies * Add a lint check for trailing whitespace. * mininode: add an optimistic write and disable nagle * qa: Fix bug introduced in p2p-segwit.py * qa: Treat mininode p2p exceptions as fatal * Put back inadvertently removed copyright notices * [qt] Add use available balance in send coins dialog * Add listwallets RPC test to multiwallet.py * [qa] zapwallettxes: Wait up to 3s for mempool reload * travis: Revert default datadir check * Ignore transactions added to mempool during a reorg for fee estimation purposes. * Do not reject based on mempool min fee when bypass_limits is set. * Change AcceptToMemoryPool function signature * wallet: Display non-HD error on first run * doc: Update release notes for 0.16.0 * doc: Bump manpages to 0.15.99 * range-based loops and const qualifications in net.cpp * Force explicit double -> int conversion for CFeeRate constructor * Make float <-> int casts explicit outside of test, qt, CFeeRate * Remove countMaskInv caching in bench framework * Add release notes describing blockmaxweight deprecation * Use a sensible default for blockmaxweight * Deprecate confusing blockmaxsize, fix getmininginfo output * remove unused IsArgSet check * add m_added_nodes to connman options * More user-friendly error message when partially signing * Fix invalid memory access in CScript::operator+= * Make sure ~/.bitcoin doesn't exist before build * Make fUseCrypto atomic * [depends] Don't build libevent sample code * [Docs] Fix broken Markdown table in dependencies.md. Cleanups. * Add -usehd to excluded args in check-doc.py * Update CONTRIBUTRING.md to reduce unnecesarry review workload * rpc: make estimatesmartfee argument naming consistent with documentation * rpc: update cli for estimatefee argument rename * Remove usehd option and warn when it is used * Bump wallet version number to 159900 * [trivial] fixup comment for VerifyWallets() * [wallet] Add StartWallets() function to wallet/init.cpp * [wallet] Add RegisterWalletRPC() function to wallet/init.cpp * [wallet] Add CloseWallets() function to wallet/init.cpp * [wallet] Add StopWallets() function to wallet/init.cpp * [wallet] Add FlushWallets() function to wallet/init.cpp * [wallet] Rename WalletVerify() to VerifyWallets() * [wallet] Rename InitLoadWallet() to OpenWallets() * Ignore old format estimation file * Changing &vec[0] to vec.data(), what 9804 missed * test: Check RPC argument mapping * travis: filter out pyenv * net: stop both net/net_processing before destroying them * Fix CTxMemPoolEntry::UpdateAncestorState: modifySigOps param type int -> int64_t * [macOS] remove Growl support, remove unused code * Typo in optionsdialog.ui Tooltip displayed ampersand incorrectly, & should be in text. * Ensure that data types are consistent * Proper indentation for CheckTxInputs and other minor fixes * Consistent parameter names in txdb.h * Make fReindex atomic to avoid race * Fix race for mapBlockIndex in AppInitMain * [test] Add bitcoin-cli -stdin and -stdinrpcpass functional tests * [test] Replace check_output with low level version * [test] Add assert_raises_process_error to assert process errors * [test] Add support for custom arguments to TestNodeCLI * [test] Improve assert_raises_jsonrpc docstring * Fix style in -stdin and -stdinrpcpass handling * net: drop unused connman param * net: use an interface class rather than signals for message processing * (finally) remove getinfo in favor of more module-specific infos * net: pass CConnman via pointer rather than reference * Remove duplicate destination decoding * Remove unused GetKeyID and IsScript methods from CBitcoinAddress * travis: Assert default datadir isn't created, Run scripted diff only once * Create dependencies.md, and link dependencies file from README & build docs * Switch memory_cleanse implementation to BoringSSL's to ensure memory clearing even with link-time optimization. * Move CBitcoinAddress to base58.cpp * Introduce wrappers around CBitcoinAddress * [qa] TestNode: Add wait_until_stopped helper method * Document assumptions that are being made to avoid NULL pointer dereferences * [docs] explain how to recompile only what bitcoind tests need * Add savemempool RPC * Add return value to DumpMempool * [Qt] Terminate string *pszExePath after readlink and without using memset * when clearing addrman clear mapInfo and mapAddr * Add test for decoderawtransaction bool * Add iswitness parameter to decode- and fundrawtransaction RPCs * Refactor tipUpdate as per style guide * Fix division by zero in time remaining * qt: Use IsMine to validate custom change address * github-merge: Coalesce git fetches * [qa] Test nMinimumChainWork * Allow setting nMinimumChainWork on command line * Improve signmessages functional test * Add translation note to CONTRIBUTING.md * Remove redundant testutil files * Fix currency/fee-rate unit string in the help text * [tests] fixup dbcrash interaction with add_nodes() * [mempool] Mark unaccepted txs present in mempool as 'already there'. * wallet: update stored witness in AddToWallet * Refactor: make the read function simpler * Update hmac_sha256.h * [tests] fixups from set_test_params() * [tests] Functional tests must explicitly set num_nodes * [tests] don't override __init__() in individual tests * [tests] Avoid passing around member variables in test_framework * [tests] TestNode: separate add_node from start_node * [tests] fix - use rpc_timeout as rpc timeout * Stop test_bitcoin-qt touching ~/.bitcoin * Fix include path for bitcoin-config.h in crypto/common.h * qa: rpc test for wtxid in mempool entry * RPC: add wtxid to mempool entry output * Add python3 to list of dependencies on some platforms * [Qt] Fix display of package name on 'open config file' tooltip * [Refactor] Combine scriptPubKey and amount as CTxOut in CScriptCheck * rpc: Push down safe mode checks * RPC: gettxout: Slightly improve doc and tests * Add getmininginfo functional test * Use for-loop instead of list comprehension * Use the variable name _ for unused return values * Remove unused variables and/or function calls * Avoid reference to undefined name: stderr does not exist, sys.stderr does * Use print(...) instead of undefined printf(...) * Use sys.exit(...) instead of exit(...): exit(...) should not be used in programs * build: Mention use of asm in summary * build: Rename --enable-experimental-asm to --enable-asm and enable by default * Document assumptions that are being made to avoid division by zero * Remove redundant explicitly defined copy ctors * Improve versionbits_computeblockversion test code consistency * Make tabs toolbar no longer have a context menu * Fix boost headers included as user instead of system headers * Fix memory leaks in qt/guiutil.cpp * Trivial: Documentation fixes for CVectorWriter ctors * Add meshcollider gitian key * Fix header guards using reserved identifiers * Output a bit more information for fee calculation report. * Fix rounding errors in calculation of minimum change size * Move local include to before system includes * Trivial: Improve #endif comments * Simplify bswap_16 implementation * [doc] Add RPC response notes * rpc: Write authcookie atomically * Add some tests for getchaintxstats * Fix getchaintxstats() * [tests] Make p2p-leaktests.py more robust * Acquire cs_main lock before cs_wallet during wallet initialization * Improve readability of DecodeBase58Check(...) * Add option -stdinrpcpass to allow RPC password to be read from standard input * [tests] fix timeout issues from TestNode * [doc] build-windows: Mention that only trusty works * Document the non-strict-DER-conformance of one test in tx_valid.json. * Fix potential null dereferences * Add recommendation: By default, declare single-argument constructors `explicit` * Changing -txindex requires -reindex, not -reindex-chainstate * Drop upgrade-cancel callback registration for a generic "resumeable" * test: Increase initial RPC timeout to 60 seconds * gitian: quick hack to fix version string in releases * Build with --enable-werror under OS X * Docs: Hash in ZMQ hash is raw bytes, not hex * Comments: More comments on functions/globals in standard.h. * Document the preference of nullptr over NULL or (void*)0 * Fix combinerawtransaction RPC help result section * Add length check for CExtKey deserialization * Pass serialization flags and whether to include hex to TxToUniv * doc: Update build-openbsd for 6.1 * Assert that CWallet::SyncMetaData finds oldest transaction. * qa: Move wait_until to util * Remove dead store in ecdsa_signature_parse_der_lax. * Prefer compile-time checking over run-time checking * [wallet] Add logging to MarkReserveKeysAsUsed * [wallet] Remove keypool_topup_cleanups * contrib: Add Valgrind suppressions file * Declare single-argument (non-converting) constructors "explicit" * Use nullptr instead of zero (0) as the null pointer constant * doc: spelling fixes * Remove vchDefaultKey and have better first run detection * [tests] Add bitcoin_cli.py test script * [tests] add TestNodeCLI class for calling bitcoin-cli for a node * Clean up getbalance RPC parameter handling * disable jni in builds * [tests] Introduce TestNode * Update developer notes after params.size() cleanup * Avoid treating null RPC arguments different from missing arguments * Get rid of redundant RPC params.size() checks * wallet: Avoid second mapWallet lookup * wallet: Fix memory leak when loading a corrupted wallet file * tests: Remove OldSetKeyFromPassphrase/OldEncrypt/OldDecrypt * Skip sys::system(...) call in case of empty command * Check that -blocknotify command is non-empty before executing * Don't use pass by reference to const for cheaply-copied types (bool, char, etc.). * Remove redundant nullptr checks before deallocation * gitian: bump descriptors for master * build: bump version to 0.15.99 * MOVEONLY: Init functions wallet/wallet.cpp -> wallet/init.cpp * MOVEONLY: Fee functions wallet/wallet.cpp -> wallet/fees.cpp * Move some static functions out of wallet.h/cpp * [Trivial] Add a comment on the use of prevector in script. * Improve shutdown process * Only return hex field once in getrawtransaction * Bugfix: Use testnet RequireStandard for -acceptnonstdtxn default * Expose more parallelism with relaxed atomics (suggested in #9938). Fix a test to check the exclusive or of two properties rather than just or. * Remove unused variables in shell scripts. * Remove the virtual specifier for functions with the override specifier * [wallet] Close DB on error. * Enable disablesafemode by default. * Fix typos. * [qt] Fix potential memory leak in newPossibleKey(ChangeCWallet *wallet) * Travis: Test build against system libs (& Qt4) * Travis: Remove bc tool from dependencies * changed regtest RPCport to 18443 to avoid conflict with testnet 18332 * Pass SendCoinsRecipient (208 bytes) by const reference * Avoid returning a BIP9Stats object with uninitialized values * Use the noexcept specifier (C++11) instead of deprecated throw() * Update init.md: Fix section numbering. * Use compile-time constants instead of unnamed enumerations (remove "enum hack") * Add const to methods that do not modify the object for which it is called * Fix constness of ArgsManager methods * add missing lock to crypter GetKeys() * keystore GetKeys(): return result instead of writing to reference * Add vConnect to CConnman::Options * Update init.md: Fix line breaks in section 3b. * Ensure that ECDSA constant sizes are correctly-sized * Remove redundant `= 0` initialisations * Specify ECDSA constant sizes as constants * Update Debian copyright list * Add comments * Fix potential overflows in ECDSA DER parsers * Add attribute [[noreturn]] (C++11) to functions that will not return * Enable devirtualization opportunities by using the final specifier (C++11) * optim: mark a few classes final * Remove unreachable code * Reorder C{,Mutable}Transaction for better packing * [tests] Avoid redundant assignments. Remove unused variables. * Properly comment about shutdown process in init.cpp file * Fix MD formatting in REST-interface.md and spelling mistake in test_runner.py * Simplify tx validation tests * Add a test that all flags are softforks * Make all script verification flags softforks * Move the AreInputsStandard documentation next to its implementation * RPC Docs: addmultisigaddress is intended for non-watchonly addresses * Fix inconsistencies and grammar in various files * Improve bitcoind systemd service file * [bench] Replace 0.00(000)1 with MICRO/MILLI #defines in validation.cpp. * [bench] Include ms/blk stats in Connect* benchmarks. * [tests] Add libFuzzer support. * [wallet] Remove CTransaction&() helper conversion operator from wallet implementation. * Skip precompute sighash for transactions without witness ------------------------------------------------------------------- Wed Sep 19 19:14:21 UTC 2018 - marec@detebe.org - Update to version 0.15.2: * Bump the version to 0.15.2 * [qa] Test for duplicate inputs within a transaction * Fix crash bug with duplicate inputs within a transaction * fixed typo * Bump the version * Mainnet fork at 536200 * Fix CVE-2018-12356 by hardening the regex. * Relex libsodium version requirement * Bumped the version (#274) * Add 32x32 (256 color) logo to ico file * Fixed bitcoin.ico to make deterministic gitian windows builds * Change version to v0.15.0.2 * Revert `-bootstrap` #4 * Revert `-bootstrap` #3 * Revert `-bootstrap` #2 * Revert `-bootstrap` #1 * Correct block seriliazation in mininode * Fix the bad conditions to skip premine whitelist for regtest mode. (#254) * Fixed icons * Fixed log output, removed unneeded cast and reverted variable type change * Fixed more integer comparison and removed useless const qualifier * Fixed integer comparison errors in equihash * Add pgp key for wilson * Add pgp key for h4x3rotab * Updated website url. * Rollback some changes * Remove lxcbr0 lines from gitian-build.sh * Fix inconsistencies and grammar in various files & remove old md guide * Fix naming of build artifacts to bitcoin-gold-... * Add gitian PGP key: wjcloud * Clean gitian PGP keys from Core * Fixed gitian build * fix typo * Update README.md * Fix linearize-data.py for BTG block format. * Change 'Bitcoin server' to 'BitcoinGold' server * Rename configuration file * Update README.md * Mark as release. ------------------------------------------------------------------- Fri Jun 29 10:47:13 UTC 2018 - marec@detebe.org - Update to version 0.15.1: * Bump the version * Mainnet fork at 536200 * Fix CVE-2018-12356 by hardening the regex. * Relex libsodium version requirement * Fork at 14300 * 100x difficulty reduction with the PoW hardfork * Switch to better LWMA params for testnet * Nit fix * Add 6*T solve time limitation * Fix LWMA param k and denominator * Bumped the version (#274) * Add 32x32 (256 color) logo to ico file * Fixed bitcoin.ico to make deterministic gitian windows builds * Change version to v0.15.0.2 * Revert `-bootstrap` #4 * Revert `-bootstrap` #3 * Revert `-bootstrap` #2 * Revert `-bootstrap` #1 * Correct block seriliazation in mininode * Fix the bad conditions to skip premine whitelist for regtest mode. (#254) * Fixed icons * Fixed log output, removed unneeded cast and reverted variable type change * Fixed more integer comparison and removed useless const qualifier * Fixed integer comparison errors in equihash * Add pgp key for wilson * Add pgp key for h4x3rotab * Updated website url. * Rollback some changes * Remove lxcbr0 lines from gitian-build.sh * Fix inconsistencies and grammar in various files & remove old md guide * Fix naming of build artifacts to bitcoin-gold-... * Add gitian PGP key: wjcloud * Clean gitian PGP keys from Core * Fixed gitian build * fix typo * Update README.md * Fix linearize-data.py for BTG block format. * Change 'Bitcoin server' to 'BitcoinGold' server * Rename configuration file * Update README.md * Mark as release. ------------------------------------------------------------------- Thu Dec 21 19:10:05 UTC 2017 - marec@detebe.org - Update to version 0.15.0.2: * Replace Core's windows codesign cert by a self-signed one. (#275) * Bumped the version (#274) * Bumped the version (#274) * Update README.md * Correct wrong repo name in sentence * Removed ".git" suffix from regex * Missing quotes and new parameters * Add 32x32 (256 color) logo to ico file * Fixed bitcoin.ico to make deterministic gitian windows builds * Change version to v0.15.0.2 * Revert `-bootstrap` #4 * Revert `-bootstrap` #3 * Revert `-bootstrap` #2 * Revert `-bootstrap` #1 * Correct block seriliazation in mininode * Fix the bad conditions to skip premine whitelist for regtest mode. (#254) * Fixed icons * Fixed log output, removed unneeded cast and reverted variable type change * Fixed more integer comparison and removed useless const qualifier * Fixed integer comparison errors in equihash * Add pgp key for wilson * Add pgp key for h4x3rotab * Updated website url. * Rollback some changes * Remove lxcbr0 lines from gitian-build.sh * Fix inconsistencies and grammar in various files & remove old md guide * Fix naming of build artifacts to bitcoin-gold-... * Add gitian PGP key: wjcloud * Clean gitian PGP keys from Core * Fixed gitian build * fix typo * Update README.md * Fix linearize-data.py for BTG block format. * Change 'Bitcoin server' to 'BitcoinGold' server * Rename configuration file * Update README.md * Mark as release. ------------------------------------------------------------------- Mon Oct 16 18:29:07 UTC 2017 - marec@detebe.org - initial package build
Locations
Projects
Search
Status Monitor
Help
OpenBuildService.org
Documentation
API Documentation
Code of Conduct
Contact
Support
@OBShq
Terms
openSUSE Build Service is sponsored by
The Open Build Service is an
openSUSE project
.
Sign Up
Log In
Places
Places
All Projects
Status Monitor
