Sign Up
Log In
Log In
or
Sign Up
Places
All Projects
Status Monitor
Collapse sidebar
home:marec2000:cryptocoins:ports
bitcoinabc
bitcoinabc.changes
Overview
Repositories
Revisions
Requests
Users
Attributes
Meta
File bitcoinabc.changes of Package bitcoinabc
------------------------------------------------------------------- Thu May 02 20:05:48 UTC 2024 - marec@detebe.org - Update to version 0.29.3: * [ecash-lib] Add SLP support * [Automated] Update electrum checkpoints * [integration tests] Don't override the ipc timeout * [chronik-client] Git-ignore the coverage directory * Add release notes for Chronik's LOKAD ID index * [Chronik] Add `-chronikcors` * [Cashtab] Add support for Malaysian Ringgit * [Cashtab] Patch bug caused by wallet change from Tokens page * [Cashtab] Use latest chronik-client * Bypass headers anti-DoS checks for NoBan peers * [e.cash] Add Guarda Wallet back * [ecash-lib] Add `TestRunner` * [ecash-lib] Fix: Built JS files are in `dist/src`, not `dist` * refactor: make active_chain_tip a reference * refactor: move CBlockIndex#ToString() from header to implementation * CDiskBlockIndex: rename GetBlockHash() to ConstructBlockHash() * DiskBlockIndex: remove unused ToString() class member * CBlockIndex: ensure phashBlock is not nullptr before dereferencing * Remove unused SetTip(nullptr) code * Bump version to 0.29.3 * Fix implicit-integer-sign-change in verifychain * [Automated] Update chainparams * [Automated] Update timing.json * [Cashtab] Upgrade NFT Page and add support for sending NFTs * [Cashtab] Remove settings page alerts about moved features * [Cashtab] Support min fee sends for holders of 1000 Cachet * [Cashtab] Correctly render amount of received txs with no change * [Cashtab] Patch tx history rendering of NFT Collection genesis txs * [Cashtab + token-server] Bump icon upload size and validate icon size before token creation * [explorer] Make the specification a clickable link * [explorer] SLPv2 -> Type2 * [ecash-lib] Enable NodeJS support * [ecash-lib] Move ecash-lib-wasm back to root workspace * [Cashtab] Support minting NFTs * [ecash-lib] Add ALP support * Reduce port range in functional tests * [Chronik] Add LOKAD ID index * [ecash-lib] Bump integration-tests timeout * [Cashtab Extension] Increase height to improve app->extension UX * [chronik-docs] Trim to version number in installation steps * [chronik-docs] Patch dockerfile so that chronik links are not broken * [chronik.e.cash] Docs site for chronik * [e.cash] Fix non-clickable button on /get-ecash * [e.cash] Switch back to Wealth Redefined video * [avalanche] Remove finalized txs upon block finalization * [ecash-lib] Add `TxBuilder` to build Bitcoin transactions * [Automated] Update seeds * [Automated] Update chainparams * [Automated] Update timing.json * [Cashtab] Stop notifying on every avalanche finalized block * [Cashtab] Improve OnBoarding component * [Cashtab] Show whether token supply is fixed or variable in create token preview modal * [Cashtab] Support for creating NFT Collections * [Cashtab] Improve scrolling and header minification * [token-server] Support creating tokens with icons from locally run cashtab * [Cashtab] Word-break for validation msgs * [Cashtab] Stop using passLoadingStatus * [ecash-herald] Parse new miner AnandrajSingh Pool * [Cashtab] Improve Token component tests * blockstorage: Adjust fastprune limit if block exceeds blockfile size * test: simplify tests by using the pre-mined chain * test: remove redundant blocks generation logic * test: add `rescan_utxos` in MiniWallet's initialization * test: Remove from_node from create_self_transfer* MiniWallet helpers * [avalanche] Fix a potential race in the quorum functional test * [BPF] Fix the interface_usdt_utxocache.py test * [test] fix broken interface_usdt_utxocache.py test * [ecash-herald] Group Cashtab rewards separately * [Cashtab] Searchable, alphabetical token list * validation: Stricter assumeutxo error handling when renaming chainstates * Replace pindex pointer with block reference * Add BlockManagerOpts::chainparams reference * refactor: Add and use PRUNE_TARGET_MANUAL constexpr * Pass fImporting to ImportingNow helper class, Move ::fImporting to BlockManager * Move ::fPruneMode into BlockManager * Move ::nPruneTarget into BlockManager * Remove reindex special case from the progress bar label * [Cashtab] Fix airdrop tx render issue * [ecash-lib] Add `UnsignedTx` and `UnsignedTxInput` * [Cashtab] Start reward countdown automatically after claiming rewards * [token-server] Use ecash-coinselect from npm * [Cashtab + token-server + ecash-coinselect] Implement token rewards for Cashtab users * validation tests: Use existing {Chainstate,Block}Man * [Cashtab] Show cursor pointer for extension open in tab button * [Cashtab] Better validation for token document url * [Cashtab] Add unimplemented functions to support NFT minting and sending * [Cashtab] Better formdata organization in create token form * [Cashtab] Organize styles in own file for Token screen * [Cashtab] Faster transition for opening and closing hamburger menu * [Cashtab] Better organization for create token form * [Cashtab] Do not render mint switch on token page unless user has mint baton * [Cashtab] Add functions to build and broadcast NFT1 parent fan-out txs * [explorer] Update README to chronik-native instance * [Cashtab] Better hamburger menu ------------------------------------------------------------------- Wed Apr 17 19:58:33 UTC 2024 - marec@detebe.org - Update to version 0.29.2: * [Cashtab] Change route and component for SendToken to Token * [Cashtab] Add animation for avalanche finalized txs * [e.cash] Build page updates * [ecash-lib] Add `SigHashType` * [avalanche] Cleanup deprecated 'sharing' RPC field * [Cashtab] Debounce scroll event handler * [electrum] fix flaky tear-down in functional tests * [Cashtab] Patch use of legacy const missed in rebase * Bump version to 0.29.2 * [Cashtab] Handle multiple token types on token action screen * [Cashtab] Add function to generate target outputs for an slpv1 nft parent mint tx * [Cashtab] Stop redirecting to /wallet route from cashtab home * [Cashtab] Patch minify menu flicker * [Cashtab] Use dust for dust throughout app * [Cashtab] Do not render reply option to eCash chat * [Cashtab] Update airdrop icon * [Cashtab] Improve focus-visible for wallet dropdown menu * test: Combine sync_send_with_ping and sync_with_ping * [explorer] Massage column priority in the address history * [explorer] Show finalization status in the transaction page * [explorer] Show the finalization status in the block page * [explorer] Show invalid token txs as such * [Automated] Update seeds * [Automated] Update chainparams * [Automated] Update timing.json * [Cashtab] No scrolling of no content below fold * [Cashtab] Add function to get target outputs for NFT1 parent genesis tx * [Cashtab] Fix svg icons * [Cashtab] After importing a wallet, automatically close the import wallet modal * [explorer] Show block finalization on blocks page * [Cashtab] Get token info from cache in airdrop calc screen * [Cashtab] Minify and pin wallet header on scroll * [e.cash] Remove uneeded halving banner * [ecash-lib] Add a bunch of helpers for `Script` * [explorer] Switch to new chronik * Faster -reindex by initially deserializing only headers * util: add CBufferedFile::SkipTo() to move ahead in the stream * Add LoadExternalBlockFile() benchmark * [Cashtab] Do not specify change address in getSlpGenesisTargetOutput * [explorer] Simplify JsonToken * [Cashtab] After a token is created, automatically navigate to its actions screen * [Cashtab] Better switch mgmt in send token * [explorer] Deduplicate the token action strings * [explorer] Remove the raw header * [explorer] Don't show the block nonce * [explorer] Update the txs page size list * [explorer] Add Cargo.lock * [Cashtab] Standardize svg icon buttons * [Cashtab] Do not change text color on hover for link button * [ecash-lib] Add `pushBytesOp` to make a minimal bytes pushop * [ecash-lib] Add `Op`, opcode consts, readOp, writeOp * [chronik] fix ChronikBridge::load_raw_tx and compress_script * [ecash_lib_wasm] Exclude from the workspace * [Cashtab] Remove data-testid from everything but Select menus * Remove unused char serialize * Use spans of std::byte in serialize * span: Add BytePtr helper * refactor: [index] Replace deprecated char with uint8_t in serialization * [Cashtab] Remove antd pointerevents shim from tests * [Cashtab] Deprecate the rest of antd * [token-server] Add method to get token inputs and outputs for a token reward tx * [Cashtab] Upgrade tx parsing * [ecash-lib] Add ecash-lib-wasm, a WebAssembly module for ecash-lib * refactor: Switch serialize to uint8_t * [ecash-lib] CI improvements for typescript projects * [ecash-lib] Basic primitives for building txs * [Chronik] Add `parse_tx_lokad_ids` to parse LOKAD IDs * tests: remove flaky mocktime test * [Cashtab] Upgrade Aliases screen * Remove unused CDataStream methods * [Cashtab] Remove obsolete css from Configure page * [Cashtab] Move wallet mgmt to its own screen * [e.cash] Fix copy pasta typo * [Cashtab] Deprecate antd select from Configure screen * [Automated] Update seeds * [Automated] Update chainparams * [Automated] Update timing.json * [Cashtab] Correct routing for sending to contact * [Cashtab] Do not show parsed op return raw field if no input * [Cashtab] Add ecash logo as icon for price notifications * [Cashtab] Remove unused validation function * [Cashtab] Move contact lists to own screen * [Cashtab] Show notifications for price milestones * [Cashtab] Improvements to modal component * [e.cash] Add halving banner to navbar * [e.cash] Get ecash page - reverse staking section image and text * [e.cash] Prevent navbar api calls on every page load * [electrum] push notification for release 5.2.12 * [e.cash] Add Staking to get-ecash page * [e.cash] Retrieve the latest version from github and use it on the upgrade page * Generalize/simplify VectorReader into SpanReader * [e.cash] Fix small typo on Staking page * [e.cash] Bump latest version to 0.29.1 on Upgrade page * scripted-diff: Move bloom to src/common * bloom: use Span instead of std::vector for `insert` and `contains` ------------------------------------------------------------------- Fri Apr 05 18:51:17 UTC 2024 - marec@detebe.org - Update to version 0.29.1: * Improve release note for 0.29.1 * [net] Don't create outbound connection to the same ip as an inbound * Bump version to 0.29.1 * [Cashtab] Improvements to app handling of new blocks * [Cashtab] Better label for show seed switch * Rename Developers page to Build on eCash * [e.cash] Improve indexer description on the roadmap * [e.cash] Mark Chronik as complete on the roadmap * [e.cash] Upgrade announcement for May 2024 * span: Add std::byte helpers * refactor: Use ignore helper when unserializing an invalid pubkey * Use value_type in CDataStream where possible * [Cashtab] Add formatting unit test for locale with multibyte thousands * [Cashtab] Support locale display for locales with no thousands separator * [electrum] build: fix incompatible dependencies ------------------------------------------------------------------- Thu Apr 04 18:37:40 UTC 2024 - marec@detebe.org - Update to version 0.29.0: * Add a release note for chronik * [Cashtab] Add op return raw field to send xec screen * [Cashtab] Use cursor not-allowed when select menu is disabled * [ecash-herald] Add a countdown for the eCash halving * [Cashtab] Move seed phrase to dedicated wallet backup screen * [Cashtab] Patch proptypes issues * [chronik] Show the chronik options * [avalanche] Reduce aggressivity when connecting to avalanche peers * [e.cash] Use constant for old version on Upgrade page * [chronik] Don't show "Stopping Chronik..." in the log when chronik is not enabled * [doc] Update the release process to use GUIX instead of Gitian * [electrum] Bump version to 5.2.12 and add release notes * [electrum] Progress on AppImage reproducibility * [electrum] Use native architecture when building on macos * [electrum] bump python dependencies * [electrum] build: remove deprecated apt-key for winehq key * Bump replay protection to November 2024 * Bump version to 0.29.0 * [Cashtab] Move App to components/App and remove lingering relative imports * [Cashtab] Deprecate hooks directory and move hooks to where they are used * [net] Consistently check for existing connection based on ip:port * [avalanche] Increase the delay for a proof to be eligible to staking rewards * [avalanche] Account for network propagation time for staking rewards * [Cashtab] Improve switches on Configure screen * [Cashtab] Improvements to send to many switch * [Cashtab] Add circulating supply to token stats * [Cashtab] Revamp UX and remove antd from SignVerifyMsg * [Cashtab] Improve UX for sending cashtab msg * [website] Add links to FAQ * [electrum] add the option to always add new addresses to wallet when scanning beyond gap * Bump the minimum block count for makeseeds.py * [electrum] minor cleanup of scan_beyond_gap.py * Bump makeseeds version filter * [Cashtab] Patch bug in disable send logic * [avalanche] Fix a race in abc_p2p_avalanche_remote_proofs.py * [electrum] fix historical fiat prices via CoinGecko * [Cashtab] Parse mint txs * [Cashtab] Keep upgrade modal title from overflow breaking onto next line * [token-server] Remove debug logs * [Cashtab] use correct validation for max genesis token amounts * [Cashtab] Add some clarifying comments on the confusing use of BN in slpv1 tx building * [token-server] Test patch for tg admin bot msgs * [Automated] Update electrum checkpoints * [Automated] Update chainparams * [Automated] Update seeds * [Automated] Update timing.json * [token-server] Add debug log for troubleshooting admin token bot * [Cashtab] Support slpv1 mint txs * [Cashtab] Better display of seed phrase * [test] allow passing test checkpoints to ContextualCheckBlockHeader * [Cashtab] Standardize padding and wrapping of app components * [Cashtab] Better validation functions for token send or burn amounts * [Cashtab] Improve UI for SendToken screen * [Cashtab] Parse eCash Chat prefixed messages * Move ::fCheckBlockIndex into ChainstateManager * Move ::fCheckpointsEnabled into ChainstateManager * Move ::nMinimumChainWork into ChainstateManager * Move ::hashAssumeValid into ChainstateManager * Move ::nMaxTipAge into ChainstateManager * refactor: use chainman instead of chainParams for DeploymentActive* * get config via chainstatemanager when possible (5/5) * get config via chainstatemanager when possible (4/n) * make checkpoints_tests work with the same Config as the rest of the validation code * [Cashtab] Replace all console.log statements with error or info and remove debug logs * [Cashtab] Support slpv1 genesis txs for mint batons * [token-server] Initialize wallet methods * [Cashtab] Patch - cleanup rebase miss * [Cashtab] Patch send to many with improved validation * [Cashtab] Remove unused hook files * [token-server] Remove unnecessary assertion from unit test file * [Cashtab] Remove legacy antd form components from CreateTokenForm * [Cashtab] Build custom switch to deprecate antd switch * [e.cash] Add Subnets as a key feature * [Cashtab] Improve and standardize cashtab token cache * [e.cash] Remove Governance item from core-tech page * [explorer] Make explorer always display current year for Copyright notice * [e.cash] Tighten up wording on core-tech page * fix chronikbridge_tests * get config via chainstatemanager when possible (3/n) * get config via chainstatemanager when possible (2/n) * get config via chainstatemanager when possible (1/n) * refactor: move *index constants out of validation * [CI] Make sure to upload the artifacts upon failure * [mock-chronik-client] Support history() calls without pageNumber and pageSize specified * refactor: add kernel/cs_main.* * Move CTxMemPoolEntry class to its own module and inline class's function * remove coinbase spend tracking in CTxMemPoolEntry * cleanup more unused code after removal of chained-tx logic (TestLockPointValidity) * [chronik-client] Return number type for timeFirstSeen returned from chronik.token calls * Move DisconnectedBlockTransactions to its own file * [mempool] Make DisconnectedBlockTransactions responsible for removing txs from the mempool after a block is connected * Remove ::dustRelayFee global * [Cashtab] Implement custom Input elements in Send, SendToken, and Configure * [avalanche] Reject blocks that contains txs conflicting with finalized txs * remove ::fAcceptDatacarrier global * fix includes in standard.{h|cpp} * [e.cash] Mark CashFusion as complete * [avalanche] Check the node can mine a finalized tx * Remove ::GetVirtualTransactionSize() alias * Remove ::fIsBareMultisigStd global * Remove ::IsStandardTx(tx, reason) alias * test: Remove unused cs_main * Remove ::minRelayTxFee global * Remove ::fRequireStandard global * Return optional error from ApplyArgsManOptions * [Cashtab] Autosize the wallet select based on text width * [Automated] Update timing.json * [Cashtab] Use latest chronik-client * [Cashtab] Better error handling for rendering txs * [Automated] Update seeds * [Automated] Update chainparams * [Cashtab] Replace antd notifications and pop-up modals with react-toastify * [chronik-client] Add timeout failure to ws connections * [Cashtab] Clean up upgrade modal component * [Cashtab] Use in-node chronik to calculate airdrops * [Cashtab] Change wallet from dropdown menu in header * [CI] Use non gold linker for the AUR packages * [Cashtab] Update dependencies * [token-server] Support token icon creation from extension and dev sites * Fix DNS seed dump flushing * [Cashtab] Remove css typo * [Cashtab] Standardize modal size for upgrades * [Cashtab] Remove debug log for token icons * [token-server] stop logging ws events * [token-server] Update directory structure to use one volume * [Cashtab] Patch tx times in history for in-node chronik * [token-server] Accept uploaded token icons * [Cashtab] Render onboarding screen if user does not have a wallet ------------------------------------------------------------------- Thu Mar 21 18:15:57 UTC 2024 - marec@detebe.org - Update to version 0.28.12: * [guix] Always use the same user name in the container * [e.cash] Mobile nav menu improvments * [avalanche] Consistently use the default constant when checking for preconsensus * [guix] Don't use empty string with git clean * [guix] Fix guix-clean on CI * [avalanche] Allow for yes-voting several winners * [avalanche] Prepare the data structure to hold several staking reward winners * validationcaches: Use size_t for sizes * [e.cash] Add link to Devs and builders Telegram group on Developers page * validationcaches: Add and use ValidationCacheSizes * cuckoocache: Check for uint32 overflow in setup_bytes * validationcaches: Abolish arbitrary limit * cuckoocache: Return approximate memory size * tests: Reduce calls to InitS*Cache() * [test] remove unneeded InitScriptExecutionCache * [cmake] Explicitely exclude the CI build directory from the source package * [Cashtab] Handle unknown tokens * [Cashtab] Build our own modal to stop using antd * [Cashtab] Update ws onmessage handler so latest cashtabState is always available * [chronik] Make chronik_serve bind once to the same ip * [Cashtab] Default chronik server to ABC instance * [standards] Reserve op_return prefix for eCash Chat platform * [Cashtab] Bump extension version for in-node chronik-client * [e.cash] Add a motivating intro to the Developers page * Bump version to 0.28.12 * [Cashtab] Use in-node chronik * [Cashtab] Patch improper useNavigate usage * Move {Load,Dump}Mempool to kernel namespace * Move DEFAULT_PERSIST_MEMPOOL out of libbitcoinkernel * LoadMempool: Pass in load_path, stop using gArgs * test/fuzz: Invoke LoadMempool via Chainstate * Move FopenFn to fsbridge namespace * mempool: Use NodeClock+friends for LoadMempool * Rename m_is_loaded -> m_load_tried * DumpMempool: Pass in dump_path, stop using gArgs * DumpMempool: Use std::chrono instead of weird int64_t arthmetics * test/mempool_persist: Test manual savemempool when -persistmempool=0 * fuzz: Rework strong and weak net enum fuzzing * [Automated] Update seeds * [Automated] Update chainparams * [Automated] Update timing.json * [token-server] Serve token icons (or blockie if unset) * fuzz: Add fuzzing harness for LoadMempool(...) and DumpMempool(...) * [electrum] fix error when cached password is forwarded to subwidget * [electrum] prefill the delegator key in the delegation editor when possible * [Cashtab] Clean up how fiat price for min token creation is displayed * [chronik] Prevent potential port collision in chronik_serve * [chronik] Don't ever use mainnet on tests * Make combine_logs.py executable * [chronik] Fix a race in chronik_ws * [Cashtab] Improve and simplify fiat API * [mock-chronik-client] Match shape of subs in ws to ChronikClientNode for ChronikClientNode methods * Use GetConflictTx() where possible * rpc: Add EnsureArgsman helper * rpc: Move mempool RPCs to new file * [mock-chronik-client] Support in-node websocket subscription methods * [Cashtab] Better css for configure options * [Cashtab] Bump extension version * [chronik-client] Support for confirmedTxs and unconfirmedTxs in script * [Cashtab] Improve Cashtab wallet shape * [Cashtab] Create custom modal for version upgrades * [token-server] Add endpoint to check address eligiblity for token rewards * [Cashtab] Remove parenthesis around buttons * test: add functional test for `-maxtipage` parameter * [Cashtab] Consolidate send xec validation functions * Extend bilingual_str support for tinyformat * [Cashtab] Simplify and standardize buttons * [Cashtab] Faster onboarding for new users * [Cashtab] Move domain names for alias and token icons * [gui] stop migrating QSettings from BitcoinABC 0.14.6 or Bitcoin Core * [CI] Add CI configuration for the GUIX builds * refactor: Move ChainstateManager options into m_options struct * [chronik-client] Do not use buffer type to support browser builds without webpack Buffer fallbacks * [Cashtab] Better function to convert user-entered fiat prices to satoshis * [Cashtab] Add and implement new helper function to get user locale * [chronik-client] Add line breaks to README changelog * [Automated] Update seeds * [Automated] Update chainparams * [Automated] Update timing.json * [token-server] Add Dockerfile for CI deployments * [e.cash] Add extension to wallet page * [Cashtab] Cleaner state setting in activateWallet * [Cashtab] Deprecate api-only app mgmt methods * [Cashtab] Remove passLoadingStatus from components that do not require UI locking * [Cashtab] Remove rename active wallet option from header * [guix] Create a print the SHA256SUMS file * [mock-chronik-client] Patch repo path in package.json * [Cashtab] Cashtab 2.0.0 - Migrate to new wallet management API * [chronik-client] Fix dependency org issue * [mock-chronik-client] Configure for automated npm publishing * [token-server] Add function to get tx history after a given timestamp * [guix] build the the source package only once * [cmake] Fix git short length * [guix] Fix source package * [guix] Remove unused geniso override * [guix] Deduplicate the tar options and sort the source package * [token-server] Add function getTxTimestamp to get best timestamp from a chronik Tx_InNode * [mock-chronik-client] Move to modules * [chronik-client] Improve organization of subscriptions in ws object * [token-server] Upgrade chronik-client to get latest types * [Chronik] Add `TxNumCache` to speed up `prepare_indexed_txs` * [guix] Make x86_64-w64-mingw32 builds reproducible * [guix] Make the OSX DMG generation with xorrisofs deterministic ------------------------------------------------------------------- Thu Mar 07 18:14:12 UTC 2024 - marec@detebe.org - Update to version 0.28.11: * Bump version to 0.28.11 * [guix] make guix-clean remove also var and output * [cmake] Ignore empty directories during source packaging * [token-server] Add new function to determine if a given tx involves an address receiving a given tokenId * [mock-chronik-client] Support ws.unsubscribe * [token-server] Add function hasInputsFromOutputScript * [mock-chronik-client] Support sub/unsub address method for ws * Revert "[mock-chronik-client] Publish as npm pkg and install where used" * [chronik-client] Improve type definition * [guix] delete rustup-init script after use * [CI tests] Rename ecash-coinselect to ecash-coinselect-tests * [mock-chronik-client] Install mock-chronik-client dependencies before running tests that require them * [guix] unset EMULATE_FHS when not needed * [Chronik] Update README.md * [chronik-client] Patch comment * [token-server] Remove legacy use strict * [token-server] Add doc comments to files * [electrum] build: Update to Python 3.11.8 * [chronik-client] Sub and unsub to and from addresses for websocket * [token-server] update gitignore * [Chronik] Remove lifetime from `MemberSer` in `Group` * [token-server] Implement typescript * [Automated] Update seeds * [Automated] Update chainparams * [mock-chronik-client] Publish as npm pkg and install where used * [Automated] Update timing.json * [Cashtab] Replace conflicting functions with more comprehensive validation function * [chronik-client] Improve and standardize integration tests * [token-server] Initialize a new app to manage rewards tokens * [mock-chronik-client] Support for setting and getting history and utxos by address * [mock-chronik-client] Make sure assert rejects is called properly in tests * [Cashtab] Fix bugs in parseChronikTx * [Cashtab] Create and test new wallet creation and validation functions * [Cashtab] Remove references to legacy ticker * [guix] Build the OSX DMG * [guix] produce the NSIS installer when building for Windows * [guix] Fix the build for OSX * [electrum] bump docker to ubuntu 20.04 for AppImage building * [Cashtab] Move cashtabCache to cashtabState * [Cashtab] Implement header throughout * [Cashtab] Deprecate legacy token checker function * [Cashtab] Combine css into one file * [Cashtab] Move GA component out of utils and into components/Common * [mock-chronik-client] Add subscribeToBlocks and isSubscribedBlocks to match in-node chronik-client * [Cashtab] Move wallet context from utils to wallet * [Cashtab] Remove line breaks from test vectors * [Cashtab] Better organization for alias functions * [mock-chronik-client] Add tests to CI * [Cashtab] Move icon helper functions to components/Etokens * [Cashtab] Delete unused utils * [depends] darwin.mk backports to support newer clang versions * [Automated] Update electrum checkpoints * [Cashtab] Combine useWallet hook tests in one file * misc cleanups for symbol-check * [cmake] Properly locate the linker when cross building for OSX * [Cashtab] Clean up mock files and standardize mock imports for component integration tests * [Cashtab] Patch syntax error in useEffect * [Cashtab] Enable min fee sends for users with 1 million grumpy * [Cashtab] Standardize price api mocks in test wrappers * [cc-tests] Standardize format of integration tests * [Chronik] Optimize `prepare_indexed_txs` by using batch queries and removing redundancy * [guix] build chronik on Windows * [GUIX] Build Chronik for Linux * [Cashtab] Update tests and patch bug in SendByUrlParams.test.js * [Cashtab] Implement standardized test wrappers in Receive.test.js * [Cashtab] Remove obsolete cache dependencies * [depends] allow NO_OPENSSL=1 * [Automated] Update timing.json * [Cashtab] Upgrade signverifymsg tests * [Cashtab] Adjust TRIGGER_UTXO_REFRESH_INTERVAL_MS to prevent multiple calls to update * [Chronik] Optimize `GroupUtxoWriter` using merge ops and compaction filters * [Cashtab] Move settings to new cashtabState * [Cashtab] Remove proptypes from component with no props * [Cashtab] Improve styling for settings items * [Cashtab] Update SendToken tests to new standardized wrapper * [Cashtab] Calculate max send amount in appropriate way using updated ecash-coinselect * [Cashtab] Standardize and improve SendXec.test.js * [ecash-coinselect] Remove double defined const * [Chronik] Non-allocating `ScriptGroupIter` for `ScriptGroup` * [Cashtab] Increase txHistoryCount to 20 * [ecash-coinselect] Export new function getMaxSendAmountSatoshis * [Cashtab] Move const to top of file instead of breaking up function docs * [Chronik] Upgrade to Rust 1.76, fix lints * [Chronik] Check rustup-init.sh hash before executing * [Chronik] Optimize `Subs` by short-circuiting if empty * [Chronik] Use `merge_cf` in `reverse_lookup.rs` to speed up indexing. * [Chronik] `ReverseLookup`: Remove redundant `lookup_cf_name` * [Chronik] Move `abort_node` and `shutdown_requested` into `ChronikBridge` * [Chronik] Move `load_(raw_)tx` into `ChronikBridge` * [Cashtab] Replace address function with equivalent lib function * [chronik-client] Add support for token info endpoint to ChronikClientNode * [Cashtab] Fix flaky tests by changing how we wait for elements expected to render asynchronously * [Cashtab] Delete all functions, files, and mocks related to legacy tx building * [Chronik] Refactor: Split `load_block_undo` out of `bridge_block` * [cmake] don't include check-electrum in check-all target * [Automated] Update seeds * [Automated] Update chainparams * [Chronik] Fix one coinbase height in `chronik_spent_by.py` test * [Cashtab] Improve alias error handling * [Cashtab] Bump extension version * [Cashtab] Update loadCashtabState to not take params * [Cashtab] Support for explicit slpv1 burn txs * [Cashtab] Upgrade slpv1 burn txs * [Cashtab] Move QRCode.js to Receive * [Chronik] Call `SyncWithValidationInterfaceQueue` in `/broadcast-tx(s)` * [Chronik] Order txs in order of the test in `chronik_token_alp.py` * [Cashtab] Upgrade slpv1 send txs * [chronik-client test scripts] Remove debug logs and correct step orders * [chronik-client] Return script for tokenId utxos * [ecash-coinselect] Support specified input utxos * [Cashtab] Upgrade some dev dependencies used in testing * [chronik-client] Support new tokenId endpoints * [doc] document the procedure to backport from subtree projects * [Cashtab] Include mocked chronik for render tests of useWallet hook * [Cashtab] Standardize and improve Home integration tests * [ecash-coinselect] Add support for utxo format of chronik-client in-node * [Cashtab] Notification instead of modal for upgrades * [Cashtab] Better helper function to clear localforage between tests * doc: Simplify guix install doc, after 1.4 release * [Cashtab] Bump jest timeout * [Cashtab] Pass localforage as a param in cashtab test initializer function * [Cashtab] Upgrade SLPv1 genesis txs * [Cashtab] Improve useWalletStorage tests * [cmake] Fetch Corrosion * [chronik] Bump corrosion to latest version * guix: switch from guix environment to guix shell * [chronik-client] Enable all integration tests in CI * [ci] Also remove .walletlock files from the artifacts * [chronik-client] Add support for getting tx history and utxos by address * [Cashtab] Improve rendering of from contact name in tx history * [Cashtab] Combine app integration tests into one file * [chronik-client] Return token data for tx inputs and outputs * [chronik-client] Support websockets in ChronikClientNode * [packaging] Enforce python >= 3.9 for the debian/ubuntu packages * [chronik-client] Support token data in tx * [Cashtab] Pass contactList to tx history using updated format * [Cashtab] Improve and standardize CreateToken tests * guix: update time-machine * [Cashtab] Update incoming txs with direct calls to antd ------------------------------------------------------------------- Sat Feb 24 15:27:08 UTC 2024 - marec@detebe.org - Update to version 0.28.10: * Bump version to 0.28.10 * [CI] Remove .lock files if some are persistent after the build. * [Cashtab] Standardize getter and setter functions for db and state * [Cashtab] Apply best practices to improve BalanceHeader integration tests * [Cashtab] Bring QRCode tests in line with rest of react testing lib tests * [chronik-client] Enforce header with eslint plugin * [Cashtab] Bump jest timeout to 30s * [Cashtab] Apply standardized test wrappers to App.test.js * guix: consolidate glibc & gcc packages * guix: pre time-machine bump changes (Windows) * [Chronik] Upgrade to axum 0.7 * [Automated] Update seeds * [Automated] Update chainparams * [Automated] Update timing.json * [Cashtab] Remove unused state param in Config * [guix] Build for arm-linux-gnueabihf and aarch64-linux-gnu * [Chronik] Fix WebSocket emitting Error messages * [Cashtab] Update airdrop.js with direct antd calls * [guix] Don't look for dependencies when building the source package * [depends] Properly remove the native protobuf libraries * [cmake] Enable noexecstack if hardening is set * lint: add new python script to check file names and permissions * [guix] Build for windows * [Cashtab] Simplify and standardize Configure integration tests * [Cashtab] Create a standardized wrapper for test rendering * [chronik] Fix websocket subscription in tests * [Chronik] Improve logs in ws.rs * [Chronik] Add `Display` impl for `ScriptVariant` * [Cashtab] Helper method for initializing integration tests * [lint] remove executable flag and shebang on non-script python files * [Automated] Update timing.json * [chronik] Bump timeout for chronik_ws_ordering * [CI] Build the chronik plugins for the automated timing update * [chronik-client] Support for broadcast-tx and broadcast-txs endpoints * [chronik] Build the experimental release for all Linux platforms * [Automated] Update seeds * [Automated] Update chainparams * [Chronik] Emit WS messages in a more deterministic order * [e.cash] Update strapi scorecard data * [Cashtab] Improve AppIntegrations unit tests * [electrum] make the python interpreter explicit when running setup.py * [lint] relax the PythonShebangLinter and apply it on electrum * [CI deps] Fix hash in nodejs install script * Revert "[guix] disable BIP70 for the guix build" * [Cashtab] Remove missed debug log from ismobile * [ci deps] Bump node to 20 * [depends] Don't remove the include directory for native_protobuf * [guix] Properly set the toolchain environment based on the CROSS_* environment variables * remove unneeded includes when building without BIP70 * build: disable more optional components when building qt * build: Make $(package)_*_env available to all $(package)_*_cmds * depends: Add file-based logging for individual packages * [Cashtab] Do not show new wallet msg for not-new wallets * [chronik-client] Update chronikNode.ts proto file * [Chronik] Add `-chroniktokenindex=0` to disable the token index * [Cashtab] Bump timeout for jest tests * [electrum] rename icons without whitespaces and capital letters * build, refactor: Drop useless `call` Make function * [Cashtab] Update configure.js with direct antd calls * dependencies: pinpoint lief version in install-dependencies-bullseye.sh * [Chronik] Deduplicate indentical consecutive WebSocket messages * Fix permission on numerous files. * [Chronik] Move `chronik-plugin` to `chronik-plugin-impl`, add `chronik-plugin` multiplex crate * [Chronik] Fix `TxTokenData::from_db` * [Chronik] Add `WsSubTokenId` to WS subscribe to txs with a given token ID * [Chronik] Add `/token-id/...` endpoints * [Chronik] Add `UtxoData` and `UtxoProtobuf` to allow storing UTXOs' scripts in the DB * make chronik-client_blocktxs_and_tx_and_rawtx work even when the wallet is not compiled * [Chronik] Add `/validate-tx` endpoint * [Chronik] Add `/broadcast-tx(s)` endpoints * [Cashtab] Do not auto-open the QR code scanner in the extension * [Cashtab] Move jest settings to own config file * [Cashtab] Remove react router mocks from tests * [Cashtab] Use context instead of mixed approach for managing contacts in Configure * [chronik-client] Support for script endpoints * Revert "Revert "[Cashtab] Upgrade react-router-dom to latest version"" * [Cashtab] Upgrade react-ga implementation * [Chronik] Bridge `calc_fee` and `default_max_raw_tx_fee_rate_per_kb` to Rust * remove dependency to OpenSSL when building without BIP70 support * [Chronik] Add `type Aux` to `Group` to assist with grouping members * test: Avoid rpc timeout in p2p_headers_sync_with_minchainwork * [Automated] Update electrum checkpoints * [Cashtab] Hide scrollbar again after antd update * Revert "[Cashtab] Upgrade react-router-dom to latest version" * [Cashtab] Upgrade react-router-dom to latest version * [Cashtab] Add eslint plugin for react testing library * [chronik-client] Update comments in py setup scripts * [ecashaddrjs] Add types so typescript apps can import without having to declare * [ecashaddrjs] Update changelog for missed version numbers * [electrum] show a warning when a BIP21 URI sets a significant amount in the send tab * [electrum] make get_merkle_root.py work on computers were Electrum ABC was never used * [electrum] use existing util.get_interfaces function for get_merkle_root * [mock-chronik-client] Support setting and getting tx history from specific type and hash values * [Chronik] Move `BUILD_BITCOIN_CHRONIK_PLUGINS` so we can access it from functional tests * [electrum] support parsing multi-output URIs * [electrum] don't open a blocking popup when an invalid URI is pasted in the Pay To field * [electrum] set dark-mode automatically for ShowPopupLabel * [linter doc] Specify prettier version to install globally * [linters] Bump required black version in CONTRIBUTING.md * [Cashtab] Pass chronik as a prop to useWallet hook * [Cashtab] Specify latest stable version of nodejs * [Cashtab] Dockerfile improvements for faster deployments * [lint] bump black to >=24 * bump minimum python version to 3.9 * [Automated] Update seeds * [Automated] Update chainparams * [Automated] Update timing.json * [Cashtab] Parse PayButton txs in tx history * [Chronik] Add `/token/:txid` endpoint * [Chronik] Enable SLP/ALP index, add protobuf messages & fields * [Cashtab] Update Token components with direct calls to antd notifications * [Cashtab] Upgrade @bitgo/utxo-lib * [monorepo] Add CONTRIBUTING.md to .prettierignore * [Cashtab] Remove obsolete chain of functions handling initial wallet load ------------------------------------------------------------------- Sun Feb 04 17:00:59 UTC 2024 - marec@detebe.org - Update to version 0.28.9: * Bump version to 0.28.9 * [chronik] Fix flaky chronik_avalanche test * [electrum] rename scripts with .py extension, and fix misc lint errors * [electrum] run flake8 on python scripts missing the .py extension * [electrum] run isort on python scripts with no extension * [electrum] run black linter on scripts * [electrum] remove bip70 script * [Cashtab] Update SendXec with direct calls to antd notifications * [Cashtab] Upgrade webpack * [Cashtab] Better testing of useWallet hook * [chronik-client] Support raw-tx endpoint in ChronikClientNode * [avalanche] Don't reject orphan txs * [electrum] add an option to show more verbose output for get_merkle_root * [Cashtab] Upgrade to React 18 * guix: Remove librt usage from release binaries * guix: Clean up manifest * guix: remove cURL from build env * [electrum] fix get_merkle_root when Electrum ABC is not installed * [e.cash] add rss feed for blog * [Cashtab] Upgrade antd * [Cashtab] Improve isValidContactList function and tests * [Cashtab] Update SignVerifyMsg with direct calls to antd notifications * [Cashtab] Improve formatting of useWallet tests * [Cashtab] Upgrade qrcode.react * [Cashtab] Remove unused dependency * [Cashtab] Remove async useEffect methods * [chronik-client] Support tx and block-txs endpoints in ChronikClientNode * [chronik-client] Bump timeout for mocha tests * [Cashtab] Wrap useWallet hook test in act * [electrum] add a script to automate updating of checkpoints * [avalanche] Fix documentation for the reconsideravalancheproof RPC * [Cashtab] Add tests for routing * [Cashtab] Deprecate react-device-detect * [Cashtab] Do not clearTimeout when alias component unmounts * [Cashtab] Move app tests to appropriate dir level * guix: document when certain guix patches can be dropped, remove redundant glibc patches * guix: use python-minimal (3.9) * guix: use gcc tool wrappers * guix: combine and document enable_werror * guix/gitian: update python-lief package to 0.13.2 * guix: use osslsigncode 2.5 * build: Add `-no-mimetype-database` option to qt package in depends * [Cashtab] Deprecate getDeviceNotificationStyle * [Cashtab] Upgrade testing-library/react-hooks * Consistently use trigger_avaproofs in abc_p2p_avalanche_remote_proofs * Add CSerializedNetMsg::Copy() helper * Make fs.h C++20 compliant and improve fs::PathToString documentation * scheduler: Capture ‘this’ explicitly in lambda * [e.cash] add style rule for blog code blocks * Remove confusing P1008R1 violation in ATMPArgs * Use designated initializers for ChainstateManager::Options and move into kernel:: namespace * refactor: remove references to deprecated values under std::allocator * init: Remove redundant -*mempool* queries * mempool: Pass in -mempoolexpiry instead of referencing gArgs * mempool: Pass in -maxmempool instead of referencing gArgs * pool: Add and use MemPoolOptions, ApplyArgsManOptions * scripted-diff: Rename DEFAULT_MAX_MEMPOOL_SIZE to indicate SI unit * ArgsMan: Add Get*Arg functions returning optional * Remove the unused TX_RECENT_CONSENSUS_CHANGE tx validation result * Add test util to populate mempool with random transactions * Move MakeNoLogFileContext to common libtest_util, and use it in bench * scripted-diff: Rename MakeFuzzingContext to MakeNoLogFileContext * scripted-diff: Rename PROVIDE_MAIN_FUNCTION -> PROVIDE_FUZZ_MAIN_FUNCTION * fix flaky addrman_is_terrible test * [Automated] Update seeds * remove unused and undefined CheckPackageLimits * [Cashtab] Receive screen improvements * [Automated] Update chainparams * [Automated] Update timing.json * [Cashtab] Standardize wallet refresh interval * [Cashtab] Better fb logo in social * [Cashtab] Use ecash-script lib for op return tx parsing * scripted-diff: Rename nUnconnectingHeaders and fPreferHeaders * [net processing] Annotate m_recently_announced_{invs|proofs} as guarded by g_msgproc_mutex and move to Peer * [net processing] Annotate fPreferHeaders as guarded by g_msgproc_mutex and move to Peer * [net processing] Annotate m_headers_sync_timeout as guarded by g_msgproc_mutex and move to Peer * [net processing] Annotate nUnconnectingHeaders as guarded by g_msgproc_mutex and move to Peer * [validation] Annotate ChainstateManager::m_best_header as guarded by cs_main * net_processing: add thread safety annotation for m_highest_fast_announce * net: add NetEventsInterface::g_msgproc_mutex * [e.cash] Update header for 2024 * Clarify the transaction validation result * [avalanche] Build a radix tree of finalized txs * [Cashtab] Remove websocketDisconnectedRefreshInterval * [Cashtab] Fixate header * [Cashtab] Add github link to social icons on Settings page * [e.cash] remove eTokens from electrum * [Cashtab] Display Cashtab webapp version on settings page if available * [ecashaddrjs] Patch function doc param name * [Cashtab] Handle parsing errors for off-spec alias registrations * [Cashtab] Support bip21 param from URL * [Cashtab] Delete function that is handled better by lib * [Cashtab] Update ScanQRCode.js * miner: Make mempool optional for BlockAssembler * [ecash-herald] Parse v0 paybutton txs * [avalanche] Poll for transactions added to the mempool * [avalanche] Use a constant for the default of -avalanchepreconsensus * [e.cash] Fix preview builds * [Cashtab] Remove unreachable loadStoredWallet migration helper fn * [e.cash] Add Arctic wallet back * [e.cash] modify CSP headers for dev mode * [Cashtab] Stop supporting no-API loading of legacy wallet formats * [electrum] fix cashaddr prefix for fulcrum donation address * qt: Avoid crash on startup if int specified in settings.json * Do not use `LocalTestingSetup` in getarg_tests test file. * Avoid wallet code writing node settings file * [Cashtab] Refactor unit tests for parseChronikTx * [Cashtab] Move chronik out of utils * [Cashtab] Add used dependency to dev dependencies * [Cashtab] Patch proptypes in BalanceHeader * [chronik-client] Add block and blocks methods to in-node chronik-client * [Cashtab] Do not generate sourcemaps at npm start * [Cashtab] Remove babel settings from package.json * [Cashtab] Improve eslint settings * [Cashtab] Move file not in right dir * [avalanche] Sanitize the thread safety checks in the processor * [Cashtab] Move dev dependencies to dev dependencies * [Cashtab] Remove unused deps * [Cashtab] Move dependency key next to devDependencies * [Cashtab] Do not disable amount if value from params is undefined * [Cashtab] Improvements to token balance header * [electrum] drop support for "bitcoincash:..." addresses * [Cashtab] Update dependencies ------------------------------------------------------------------- Tue Jan 23 19:33:54 UTC 2024 - marec@detebe.org - Update to version 0.28.8: * [lint] Lint everything * [electrum] escape special chars in URI for op_return message * [electrum] add tests for BIP21 parsing and creation * [electrum] rename tests in test_bip21 * [electrum] move BIP21 parsing tests to their own file * [electrum] fix import of urllib in web.py * [paybutton spec] Updates to spec * [e.cash] Wallets page design update * Update Copyright year to 2024 * [e.cash] Enable CSP header * [Cashtab] Upgrade to latest chronik-client * [e.cash] Header implementation bug fix * [Cashtab] Implement unified balance header * [e.cash] Add recommended security headers * [chronik-client] Do not try next server if error is unrelated to server outage * [electrum] remove support for signed payment requests in URIs * [Automated] Update seeds * [Automated] Update chainparams * [Automated] Update timing.json * [Cashtab] Deprecate all duplicated legacy implementations of toXec and toSatoshis * [Cashtab] Replace cashMethods toSatoshis with new wallet toSatoshis * [Cashtab] If timeFirstSeen is 0, use block timestamp in tx history * [Cashtab] Improve CreateTokenForm component and add integration tests * [Cashtab] Remove obsolete SendToken snapshot tests and replace with existing validation integration tests * [Cashtab] Bump extension version to publish with bip21 op_return_raw support * [Cashtab] Remove obsolete migration unit tests * [Cashtab] Have refreshes update version for PWA users on update * [chronik-client] Patch missed changelog update * [PayButton Spec] Patch lokad ambiguity on second ref * [standards] Add spec for PayButton txs * [Cashtab] Better testing for Home.js screen * [Cashtab] Support op_return_raw in SendXec * [Cashtab] Update bip21 parsing to match latest spec, op_return_raw vs opreturn * [Chronik] Plugins: Add `Tx`, `TokenTxEntry` and other tx related objects * [chronik-client] Add chronik-info endpoint to in-node chronik-client * [Cashtab] Implement address validation from ecashaddrjs lib * Fix a race in validationinterface_tests * [Cashtab] Add more wallet helper functions * [Cashtab] Move validation out of utils * [bip21] Allow unprefixed ecash addresses * [Cashtab] Refactor parseAddressForParams to support all address and bip21 validation * Fix a -Wshadow warning in net_processing.cpp * [electrum] bump minimum required version of trezorlib to 0.13.8 * [electrum] build-wine: Update xvfb and winbind to latest security patch * [electrum] network_dialog: Validate hosts and ports * [avalanche] Make the BlockFinalized validation callback asynchronous * [bip21 spec] use op_return_raw instead of opreturn * [herald] Parse Cminors-Pools * [Cashtab] Create new getBalanceSats function in wallet dir * [Cashtab] Better conditions for disabling amount in SendXec * [CI] Restore cashtab preview * [Cashtab] Do not disable amount field if null is passed * [Cashtab] Add social links to Settings page * [Cashtab] Ignore immature coinbase utxos in sendXec function * [Cashtab] Add missing input param to unit test * [Cashtab] Add function to filter out unspendable coinbase utxos from utxo set * [Cashtab] Add chaintip blockheight to wallet context * [bip21] Support multiple outputs * [Cashtab] Improve isAliasFormat function and add unit tests * [Chronik] Plugins: Add `__init__`, `__eq__` and `__repr__` methods * [Chronik] Fix: Missing entry for "burned" NFT1 GROUP token for NFT1 CHILD GENESIS txs * add release notes for the headers presyn feature * ui: show header pre-synchronization progress * Make validation interface capable of signalling header presync * Test large reorgs with headerssync logic * Track headers presync progress and log it * Expose HeadersSyncState::m_current_height in getpeerinfo() * Test headers sync using minchainwork threshold * Add unit test for HeadersSyncState * Reduce spurious messages during headers sync * Require callers of AcceptBlockHeader() to perform anti-dos checks * Utilize anti-DoS headers download strategy * Add functions to construct locators without CChain * Add bitdeque, an std::deque<bool> analogue that does bit packing. * fuzz: Introduce CallOneOf helper to replace switch-case * [Cashtab] Sync utxo set on load * [Cashtab] Replace magic number with constant * [Chronik] Add `SlpScript` Python helper for functional tests * [e.cash] Remove QUIC from roadmap * [Cashtab] Improve handling of URL populated txs * Remove mempool txs in reverse topological order * Turn mempool entry ref into a RCU pointer * Avoid a copy when inserting a mempool entry * Migrate the mempool to hold shared pointers * [Chronik] Add `MempoolTokens` to index mempool token txs * [Chronik] Plugins: Add `Script` and `Op` objects * [Automated] Update seeds * [Automated] Update chainparams * [Automated] Update timing.json * [Cashtab] Show timeFirstSeen in tx history * [Cashtab] Better extension popup size * [bip21] Specify index location of opreturn param * [Cashtab] Improve unit test organization for isValidAlias * [Cashtab] Remove duplicated code * [Cashtab] Better button sizing, spacing, and hover * fuzz: Link all targets once * Bugfix: Wallet: Soft-fail exceptions within ListWalletDir file checks * wallet: Make -wallet setting not create wallets * Bump version to 0.28.8 * Update wallet_multiwallet.py for descriptor * fuzz: Configure check for main function * Add function to validate difficulty changes * [Cashtab] Additional mitigation for legacy wallet addresses * [Chronik] Add `TokenTxEntry::burn_summary` for a nice human-readable burn summary * [Chronik] Plugins: Add a bare-bones Python `PluginContext` * [Cashtab] Use vectors for parseAddressForParams unit tests * [herald] shorter identifier for anon-ish miner * [Cashtab] Stop using a function that isnt really used in SignVerify component * [Cashtab] Implement latest chronik-client * [Cashtab] Clean up conditions for disabling Send button * qt: Revamp ClientModel code to handle core signals * [Cashtab] Add missing dep to dev deps * [Cashtab] Improve Send screen handling of address input * [Cashtab] Implement CSP header * [Cashtab] Remove references to legacy fork from Send component * [Cashtab] Sort tokens alphabetically by token ticker * [Cashtab] Sort saved wallets alphabetically * [Cashtab] Better component organization and routing for etokens * [Cashtab] Update getSlpSendTargetOutputs to match optimizations of getSlpBurnTargetOutput * [Cashtab] Add function to generate burn targetOutputs * [Cashtab] Add CSP report only header * [herald] Patch bug in unidentified miner * [herald] Print ascii string for unknown miners with well-pushed ascii in coinbase * [herald] Abbreviate some replayed memo msgs ------------------------------------------------------------------- Wed Jan 10 18:17:45 UTC 2024 - marec@detebe.org - Update to version 0.28.7: * Bump version to 0.28.7 and add a release note * [avalanche] Reduce remote proofs verbosity * [Cashtab] Update param parsing function to support opreturn param * [herald] Call slpv2 empp txs ALP instead of slp v2 * remove unnecessary sync_blocks in p2p_compactblocks * log improvements in p2p_compactblocks * [Cashtab] Update jest * [Cashtab] Remove faulty unit tests * [addrman] add tests for IsTerrible * Make adjusted time type safe * refactor: Use type-safe std::chrono for addrman time * Rename addrman time symbols * refactor: Remove not needed std::max * [Automated] Update seeds * [Automated] Update chainparams * [Automated] Update timing.json * [e.cash] Remove Arctic Wallet * [Cashtab] Add useful security headers * [Chronik] Remove an unnecessary copy of CChainParams in chronik::Start * refactor: Replace global find_value function with UniValue::find_value method * Fix a -Wmaybe-uninitialized warning in cuckoocache_tests * Remove no-op TIME_INIT on deser * Get time less often in AddrManImpl::ResolveCollisions_() * Remove redundant addrman time checks * addrman: Fix AddrMan::Add() return semantics and logging * wallet: Replace confusing getAdjustedTime() with GetTime() * rpc: Use steady_clock for getrpcinfo durations * [Chronik] Add `TokenWriter` and `TokenReader` * [Chronik] Send regular pings from WebSocket to prevent disconnects * [Cashtab] Add function to create targetOutput from opreturn as param input * [Cashtab] Remove bignumber.js library * [Chronik] Add `lookup_spent_coins` and `uncache_coins` to `ChronikBridge` * [Chronik] Add `VerifyContext`, `verify` and `TokenTx` to bitcoinsuite-slp * [chronik] Don't sync after each generate in chronik_avalanche * [Cashtab] Default to ABC chronik servers * [Cashtab] Update webpack to support cjs * p2p: Make block stalling timeout adaptive * [Cashtab] Deprecate parsing encrypted msgs in tx history * [Cashtab] Upgrade cashtab msg bytecount function * [Cashtab] Get outputs for SLP v1 send txs * [chronik-client] Deprecate client-side ping keepAlive * [Cashtab] Fix typo in aliasByteCount unit test * settings: Add resetSettings() method * init: Remove Shutdown() node.args reset * settings: Add update/getPersistent/isIgnored methods * util: Make ArgsManager::GetPathArg more widely usable * bench: Represents paths with fs::path instead of std::string * [Cashtab] Deprecate legacy transaction functions * [Cashtab] Generate targetOutputs for SLP genesis tx * [Cashtab] Deprecate legacy alias bytecount function * [chronik-client] Support ping / pong in browser environment * [Cashtab] Add new validation function for parsing opreturn as a bip21 parameter * Remove LOCKTIME_MEDIAN_TIME_PAST constant * [doc] Complete instructions to run the user systemd service on boot * [chronik-client] Update axios * [Cashtab] Remove google analytics call from extension * [ecash bip21] Make empty OP_RETURN out of spec * [Cashtab] Use new sendXec function to register aliases * [Cashtab] Use correct jest syntax in unit tests * [chronik-client] Add docker images required for ci deployments * [Automated] Update seeds * [Automated] Update chainparams * [Automated] Update timing.json * [Chronik] Format Rust code with the latest nightly + update CI * [Cashtab] Stop using port object to prevent port disconnect errors * [Cashtab] Create standalone component for Etokens * [electrum] push release notification for 5.2.11 ------------------------------------------------------------------- Tue Dec 26 16:54:57 UTC 2023 - marec@detebe.org - Update to version 0.28.6: * Bump version to 0.28.6 * [Chronik] Add `ColoredTx` to `bitcoinsuite-slp` * validation: access chainparams via chainstatemanager * use static constexpr and braced initialization in policy.h * [electrum] handle the password cancellation more gracefully * [Automated] Update chainparams * [Automated] Update timing.json * [Cashtab] Remove render-only snapshot tests * [ecashaddrjs] Copy all files to support prepublish command in CI * [Chronik] Don't ignore SLP and ALP mixups when parsing * remove unused CScript::IsCommitment * Add ChainstateManagerOpts, using as ::Options, pass it an adjusted_time_callback * [Cashtab] Add new helper function to generate to-spec targetOutputs for alias registration txs * [Cashtab] Extend alias validation to include any input * [Cashtab] Move extension-specific functions to conditionally loaded component * [Cashtab] Move webapp specific functions to conditionally loaded component * [kernel 1/n] Introduce initial libbitcoinkernel * [kernel 0/n] Introduce bitcoin-chainstate * [ecashaddrjs] Add unit tests and support autodeploy * remove unused BlockValidationResult::BLOCK_RECENT_CONSENSUS_CHANGE * [explorer] Fix the build * [Chronik] Add `alp::parse` to parse GENESIS, MINT, SEND and BURN * [Chronik] Add support for BURN txs in `slp::parse` * [Chronik] Add support for SEND txs in `slp::parse` * [Chronik] Add support for MINT txs in `slp::parse` * [electrum] disable generate key button in the delegation editor for non-HD and watch-only wallets * remove unused BlockValidationResult::BLOCK_FINALIZED * [Chronik] Add `slp::parse`, with support for SLP GENESIS txs * [Cashtab] Integer validation for satoshi amounts * [Chronik] Change `empp::parse` to return `None` for ignorable results * [ecash-herald] Extend support for recognizing Hathor-MM * [Cashtab] Implement better tx functions on Send screen * [Chronik] Add basic structs and consts for SLP and ALP txs * [Chronik] Add `TxId::new` and `TxId::hash` * [Chronik] Add `Script::put_pushdata` and `Script::put_slp_pushdata` * [Chronik] Make `TxId` and the hashes serde serializable * test: Change background_cs from pointer to reference in validation_chainstate_tests * [e.cash] Sort blogs by publish date * [Chronik] Add `should_ignore` to `empp::ParseError` * [Cashtab] Add function to generate targetOutputs for multisend tx from user input * prune, import: allows pruning to work during the loadblock import process * refactor: Add BlockManager getters * Make static nLastFlush and nLastWrite Chainstate members * refactor: Make mapBlocksUnknownParent local, and rename it * [explorer] fix DataTables warning about Reinitialise DataTable * fix incorrect blk file size calculation during reindex * assumeutxo: catch and log fs::remove error instead of two exist checks * [Automated] Update chainparams * [Automated] Update timing.json * [e.cash] Change status of UTXO Commitments to Underway * [Cashtab] Trim address strings in multisend input * refactor: Replace std::optional<bilingual_str> with util::Result * Introduce generic 'Result' class * [electrum] move checkpoint data to a json file * [electrum] add a script to get the merkle root for a block height * [CI] Bump QEMU version * [chronik] Disable the Write Ahead Log for rocksdb * [Chronik] Add a merge lock to avoid a race in the tests * [Cashtab] Improve multisend validation * test: Fix intermittent failure in ChainStateManager tests * [Cashtab] Use only one app.css for webapp and extension * [Cashtab] Make sure send button is not disabled for airdrop txs * [chronik-client] Add in-node ChronikClientNode object and handle standard endpoints * [Automated] Update timing.json ------------------------------------------------------------------- Wed Dec 13 19:46:45 UTC 2023 - marec@detebe.org - Update to version 0.28.5: * [avalanche] fix timestamp flakiness in abc_p2p_avalanche_remote_proofs.py * [electrum] make contrib/sign_packages support multi digits in version numbers * |contrib] fix update-timings.sh * [electrum] bump version to 5.2.11 and add release notes * [e.cash] Update discord link * [avalanche] Lower the remote proofs threshold * [avalanche] Remote proofs: account for our local proof if we are a staker * [avalanche] Request the compact proofs from all peers * [Cashtab] Update npm deps * [avalanche] Clarify some conflicting options for stakers * [avalanche] Let -maxavalancheoutbound takes precedence over -maxconnections * [CI] Run the chronik client integrations tests on diffs * [e.cash] Rename Subchain to Subnet * [contrib] Remove Upstart from service configuration files * [doc] Fix formatting in init.md * [electrum] fix handling of a single block reorg * [electrum] resolve past single-block reorg * [electrum] add more docstrings and typehint to network and interface code * [electrum] bump checkpoint to 822000 * Update npm dependencies * [Cashtab] Disable google analytics in extension using env var * [avalanche] Remote proofs: only account for the stakes * [avalanche] Remote proofs: only account for the stake once when a peer has several nodes * [Node Daemon ] Updating the outdated bitcoind.service. * [Automated] Update chainparams * [Cashtab] Remove remote code from extension * [chronik-client] Add support for integration tests * [avalanche] Inline getPeerScoreFromNodeId * [electrum] start adding typehints and documentation to network.py * [electrum] add more typehints for blockchain related functions * [Cashtab] Do not give a change address to opreturn outputs * [Cashtab] Better validation for multisend txs * [electrum] define and annotate Interface attributes in __init__.py * [electrum] typehints and minor cleanup in blockchain.py * [electrum] typehints and minor cleanup in interface.py * doc: add release note for error handling when VerifyDB dosn't finish successfully * [Cashtab] Handle port disconnects in extension * [ecash-coinselect] Patch bug where returned outputs could be non-integer * [ecash-herald] Parse iceberg lowercase * validation: report if pruning prevents completion of verification * init, validation: Improve handling if VerifyDB() fails due to insufficient dbcache * validation: return VerifyDBResult::INTERRUPTED if verification was interrupted * validation: Change return value of VerifyDB to enum type * Bump version to 0.28.5 * log: Log VerifyDB Progress over multiple lines * validation: Skip VerifyDB checks of level >=3 if dbcache is too small * [e.cash] Refer to upgrade in the past tense on staking page * [e.cash] Tell people not to use Tor for avalanche staking nodes * [ecash-herald] Parse miner p2p-spb * [ecash-coinselect] Add Dockerfile for running npm publish in ci * [ecash-herald] Fix unit test changes from updated chronik-client syntax * [Chronik] Fix: "Inconsistent mempool" when reorging with chained txs * [Chronik] Improve error message when a UTXO couldn't be removed from the mempool * [explorer] Switch back to chronik.fabien.cash * [Cashtab][Alias] Simplify alias taken msg * [Cashtab][Alias] Utilize existing isValidAliasString to gatekeep alias status checks * [Cashtab] Validate multisend amounts for decimal places * [standards] Collect eCash-specific variations to BIP21 in a spec * [Cashtab][Alias] Update the alias available input message * Reduce bandwidth during initial headers sync when a block is found * Don't send getheaders message when another request is outstanding * [Cashtab][Alias] Add trimmed input null check after input clearance * [Cashtab][Alias] Status check upon alias registration input pause * Add mockable clock type and TicksSinceEpoch helper * Cleanup received_new_header calculation to use WITH_LOCK * Move peer state updates from headers message into separate function * Move headers-direct-fetch logic into own function * Move additional headers fetching to own function * Add helper function for checking header continuity * Move handling of unconnecting headers into own function * Reduce CTxMemPool constructor call sites * refactor: Pass Peer& to Misbehaving() * [Explorer] Update README with openssl and protoc dependencies * rename UNIQUE_NAME macro to UNIQUE_LOG_NAME * [e.cash] Remove guarda wallet from /wallets * [Cashtab] Run all unit tests and update snapshots on npm test * Move minRelayTxFee to policy/settings * Remove unused excessUTXOCharge config option * doc: Update developer notes * sync.h: Imply negative assertions when calling LOCK * sync.h: Add GlobalMutex type * propagate negative thread safety annotations for avalanche code * thread safety annotation for m_tx_relay_mutex and m_cached_tip_mutex * util, refactor: Add UNIQUE_NAME helper macro * Sync chain more readily from inbound peers during IBD * [Cashtab][Alias] Deprecate Check Alias button * [Automated] Update chainparams * [Automated] Update timing.json * [chronik] Get the websocket to ping/pong automatically * Respond to getheaders if we have sufficient chainwork * [Cashtab][Alias] Open the pending aliases dropdown by default * [chronik-client] Apply standardized-ish commenting * refactor: replace RecursiveMutex m_most_recent_block_mutex with Mutex * use cached most recent compact block when available * [e.cash] Bump latestVersion to 0.28.4 on upgrade page * refactor: Improve thread safety analysis by propagating some negative capabilities * strengthen AssertLockNotHeld assertions * [alias-server] Implement chronik with backup connections * [mock-chronik-client] Update syntax to match chronik-client 0.9.0 * [ecash-herald] Implement chronik-client 0.9.0 with failover proxy * [net processing] Rename CNodeState compact block members * [net processing] Remove fSupportsDesiredCmpctVersion and simplify sendcmpct processing * [test] Overhaul p2p_compactblocks.py * scripted-diff: Rename PeerManagerImpl members * [net processing] Move nHighestFastAnnounce into PeerManagerImpl * [net processing] Move block cache state into PeerManagerImpl * [net processing] Move nPreferredDownload into PeerManagerImpl * [net processing] Move mapNodeState into PeerManagerImpl * [net processing] Move CNodeState declaration above PeerManagerImpl ------------------------------------------------------------------- Fri Dec 01 15:13:03 UTC 2023 - marec@detebe.org - Update to version 0.28.4: * Add some release notes for 0.28.4 * [seeder] handle CAddress-without-nTime logic * [e.cash] Update instant exchanges scoring criteria * [seeder] Fix the net magic not being found * [guix] disable BIP70 for the guix build * [electrum] use the progress bar when broadcasting multiple transactions * [electrum] show a single popup dialog when broadcasting multiple transactions * [chronik hotfix] use chronik.be.cash servers for live apps * [Automated] Update seeds * [Automated] Update chainparams * [Automated] Update timing.json * [chronik-client] Default true for websocket keepAlive * [electrum] move-only: move the early exit conditions before the broadcast functions in broadcast_transaction * [electrum] misc cleanups of ElectrumWindow.broadcast_transaction * [avalanche] Prevent a potential test failure in abc_p2p_avalanche_remote_proofs * [electrum] fix the flaky reorg test * [electrum] don't hardcode coinbase amount in test_balance * Cleanup the Nov. 15 2023 activation code and prepare for the May 15 2024 upgrade * [ecash-herald] Show peerName for staking reward winner, if available * [electrum] don't show error if the Aux Key Dialog's password prompt is cancelled * [electrum] regtest: refactor poll_for_answer * Update the activation tests to work with overloaded activation functions * [herald] Simplify price api to add specific urls to mocks * [chronik-client] Implement keepAlive to preserve longlived connections * [avalanche] Fix a couple issue from D14833 * [avalanche] Add coverage for the avapeers dump file deserialization error behavior * [electrum] extract get_fulcrum_stat from poll_for_answer * [avalanche] Actually dump/load the peers list upon shutdown/startup * Use std::chrono for the time to rotate destination of addr messages + tests * refactor: make GetRand a template, remove GetRandInt * Bump version to 0.28.4 * [Cashtab][Alias] Sync pricing on new blocks * [avalanche] Fix a use after free bug in the peer manager unit tests * refactor: use Span in random.* * refactor: Replace &foo[0] with foo.data() * [Cashtab] app.js format improvements * [chronik-client] Organize code to prepare for additional in-node class * [avalanche] Add dump and load functions to save/load the avalanche peers to/from a file * [electrum] push release notification for 5.2.10 * [chronik-client] Generate proto file for in-node chronik * [e.cash] Add FAQ to staking page * [electrum] bump version to 5.2.10 and add release notes * [electrum] fix signature updating in fusion code * [avalanche] Don't log all the avahello we send * [electrum] replace all len(tx.inputs()) with len(tx.txinputs()) * [Automated] Update seeds * [Automated] Update chainparams * [Automated] Update timing.json * [ecash-herald] Add amount for staking rewards * [Cashtab] Do not try to parse outputscript of coinbase txs * [e.cash] Fix typo on staking page * [chronik] Test: make sure the tx reached the mempool before asserting on the ws message * [e.cash] Flesh out requirements section on staking page * [electrum] fix and add tyephints in base58 decoding code * [electrum] only increment the aux key index if we know it has been used * [electrum] fix auxiliary key dialog initialization on first use * [electrum] fix delegator key detection when building multi-level delegation * [e.cash] Use fancy headers on staking page * [chronik-client] Improve websocket failover proxy * [chronik-client] Remove test dependency on reindexing node * Dramatically speed up the abc_p2p_compactproofs test * [chronik] Don't erase the default websocket timeout un chronik_ws_script * [CI] Unbreak the wine installation * [cashtab] remove chronik server while reindexing * [electrum] Performance: Speed up loading of very large wallets * [electrum] Performance: make receive_history_callback faster for larger histories * [electrum] add a functional test for a reorg situation * [electrum] fix Transaction.from_io in fusion.util * [e.cash] Bump latestVersion to 0.28.3 on upgrade page * [e.cash] Modify static announcment bar * [e.cash] Remove old countdown from anoucment bar * [ecash-herald] Patch use of float vs int for sats ------------------------------------------------------------------- Thu Nov 16 20:18:42 UTC 2023 - marec@detebe.org - Update to version 0.28.3: * Add some release note for the new checkpoints * Add a checkpoint after the November 15, 2023 activation * [ecash-herald] Include staking rwd winner in msgs * [e.cash] Update upgrade page for completed upgrade * [e.cash] Improve network upgrade banner * [linter] Lint everything * [electrum] fix address resolving and building transaction from hex in RPC commands * [CI] Double the functional tests timeout for coverage and emulator builds * [electrum] fix integer overflow for the Proof total amount * [e.cash] Add styles to staking warning box * p2p: Serialize cmpctblock at most once in NewPoWValidBlock * [electrum] update notification for 5.2.9 * [e.cash] Sort blog articles by reverse publication date * [chronik] Apply the timeout factor to the chronik connections * [chronik] Remove some boilerplate from the test_framework * net, refactor: Rename CNetMessage::m_command with CNetMessage::m_type * Rename and move PoissonNextSend functions * fix OSX build failure related to Span deduction guide in macro * More Span simplifications * Replace MakeSpan helper with Span deduction guide * [Automated] Update seeds * [Automated] Update chainparams * [Automated] Update timing.json * [e.cash] Add staking page * Remove some debug leftover from D14614 * [CI] Unbreak the win64 build * [e.cash] Rename CustomLink to ExternalLink * [electrum] log: only log in verbose mode in CachedWalletPasswordWidget * [electrum] bump version to 5.2.9 and add release notes * [electrum] implement removal of coins in the proof editor * [electrum] refactor: extract stakes widget from proof editor * [net_processing] fix compact block related comment * [net processing] Dont request compact blocks in blocks-only mode * [Cashtab] Add function to generate an OP_RETURN output for an airdrop tx * [Cashtab][Swap] Add swap component with SideShift integration * [net processing] Remove CNode::nLocalServices * [net] Return CService from GetLocalAddrForPeer and GetLocalAddress * [net processing] Remove CNode::nServices * [net processing] Remove fClient and m_limited_node * [tests] Connect peer in outbound_slow_chain_eviction by sending p2p messages * [net processing] Add m_our_services and m_their_services to Peer * remove unused CAddress::Init() definition * refactor: move CAddress-without-nTime logic to net_processing * Introduce well-defined CAddress disk serialization * fuzz: Check for addrv1 compatibility before using serializers * [CI] Fix the Win64 build failing due to wine issue * [avalanche] Add invalidateavalancheproof and reconsideravalancheproof RPCs * [electrum] tests: raise on RPC error with proper error message * [electrum] regtest: fix fulcrum stats query and raise timeout error in poll_for_answer * [net processing] remove proof_relay parameter from Peer ctor * [net processing] Don't initialize TxRelay for non-tx-relay peers. * [net processing] Comment all TxRelay members * [net processing] [refactor] Move m_next_send_feefilter and m_fee_filter_sent * [avalanche] Move the invalid proofs filter to the peer manager * [Automated] Update seeds * [Automated] Update chainparams * [Automated] Update timing.json * [Chronik-client] - Cycle through backup instances on outage * [Cashtab] Create targetOutput for a Cashtab Msg tx * Replace RecursiveMutex cs_addrLocal with Mutex, and rename it * [e.cash] Use camelCase for constant * [electrum] detect the master private key when loading a proof * [electrum] clear the wallet password from memory when no longer needed * [Cashtab][Alias] Check Alias function * refactor: replace RecursiveMutex m_cs_callbacks_pending with Mutex (and rename) * wallet: Avoid locking cs_wallet recursively * [e.cash] Filter out low exchange scores * [Cashtab][Alias] Increase pending warning emphasis on confirmation modal * [avalanche] Consolidate the proofs recent finalization state memorization * Bump version to 0.28.3 * [Cashtab] Seed warning confirmation check * [ecash-herald] CashFusion with no space * [ecash-herald] Fix legacy chronik client mock import * [Cashtab] Remove encrypted msg sending * [Cashtab][Alias] Pending Aliases * [e.cash] Use constant for latest version on upgrade page * net_processing: move CNode data access out of lock * scripted-diff: rename TxRelay & TxProof members * [net processing] Move tx & proof relay data to Peer * [net] Add CNode.m_relays_txs and CNode.m_bloom_filter_loaded * tests: add feature_bind_port_*.py to EXTRA_PRIVILEGES_TESTS * [e.cash] Bump version to 0.28.2 on upgrade page ------------------------------------------------------------------- Sat Nov 04 17:10:14 UTC 2023 - marec@detebe.org - Update to version 0.28.2: * Add some release notes for v0.28.2 * [Cashtab] Patch line break issue with comment in send.js * [avalanche] Fix the return status of the setstakingreward RPC * [electrum] secp256k1: Improve warning message by adding path and exception details * [electrum] Fix various strings that were wrong, inconsistent or not translatable * [e.cash] getScores edit * [e.cash] Open external links in new tab - mining page * [avalanche] Make sure the finalization status is maintained when a proof is promoted from dangling * Bump version to 0.28.2 * [Cashtab Extension] Close open pop-ups before opening a new one * [Cashtab Extension] Migrate to v3 manifest * [chronik] Add new endpoint to check chronik version * [Automated] Update seeds * [Automated] Update chainparams * net: fix GetListenPort() to derive the proper port * [e.cash] Remove mention of bits for the denomination * [e.cash] Add code block component * [Prettier] Use prettier on Cashtab extension files * refactor: Treat CDataStream bytes as uint8_t * [alias-server] Return pending registrations for a specified alias * [e.cash] Bump version to 0.28.1 on upgrade page * validation: add ChainMan logic for completing UTXO snapshot validation * move-only-ish: init: factor out chainstate initialization * validation: add CChainState::m_disabled and ChainMan::isUsable * coinstats: Separate hasher/index lookup codepaths * coinstats: Extract in-members to in-params, return purely out-param CCoinsStats * fuzz: Remove useless GetUTXOStats fuzz case * rpc: various fixups for dumptxoutset * log: Move validation option logging to LoadChainstate() * doc: add assumeutxo notes * test: add testcases for snapshot initialization * validation: remove snapshot datadirs upon validation failure * test: add reset_chainstate parameter for snapshot unittests * move-only: test: make snapshot chainstate setup reusable * init: add utxo snapshot detection, allow on-disk coins and block tree dbs in tests * validation: rename snapshot chainstate dir * [electrum] don't raise RuntimeError for system thread limitations * [examples] Update dependencies * [mock-chronik-client] Update dependencies * [e.cash] Add mining page * [e.cash] Change Twitter logo to X ------------------------------------------------------------------- Sat Nov 04 17:08:32 UTC 2023 - marec@detebe.org - Update to version 0.28.1: * Add some release notes for 0.28.1 * [avalanche] Don't send peers with no node attached in compact proofs * [avalanche] Pass our local proof to the peer manager at construct time * [avalanche] Reconcile the proofs pulled back from dangling * [avalanche] Use the remote proof status to confirm the presence/absence of a proof * [avalanche] Evaluate the presence of a proof based on remotes * [avalanche] Update the remote proofs upon receipt of compact proofs * [avalanche] Save the remote proofs from our avalanche outbound peers * [avalanche] Limit the remote proofs per peer * [avalanche] Clear the remote proofs upon node removal * [avalanche] Add a remote proof container to retain the proof set of our peers * [avalanche] Remember the dangling proofs * [cashtab-components] Update dependencies * [Cashtab] Bump extension version * [dependencies] Update dependencies for JS modules * [e.cash] Resolve dependency alerts * [arclint] Lint web/e.cash * [Automated] Update seeds * [Automated] Update chainparams * [Automated] Update timing.json * [avalanche] Add getter and setter RPCs to retrieve/set the staking reward winner * [avalanche] Remove dead code from previous iterations of the staking rewards feature * [avalanche] Factor code for staking rewards activation * Bump version to 0.28.1 * [electrum] fix hardware wallet decryption * Fix chain tip data race and corrupt rest response * [Cashtab[Alias] Clear registration input after broadcast * [alias-server] Use helmet to improve express security * [Cashtab][Ailas] Remove aliasToRegister and aliasLength state vars * sync: Use decltype(auto) return type for WITH_LOCK * util/check: stop using lambda for Assert/Assume * init: add missing cs_main lock * [Automated] Update seeds * [Automated] Update chainparams * [Automated] Update timing.json * [Cashtab][Alias] Remove redundant node error translation in handleAliasRegistrationError * [herald] Update dependencies * [Cashtab] Update dependencies * [alias-server] Run npm audit fix to patch dependency issue * Remove obsolete seeders * [e.cash] Language selector CSS * [e.cash] Add weglot exclusion classname * Replace ... single char with 3 dots * [e.cash] Add instructions on how to upgrade a node * [test] Make abc_p2p_avalanche_voting more robust * [e.cash] Change theme * [e.cash] Modify announcement bar for network upgrade ------------------------------------------------------------------- Wed Oct 11 17:20:25 UTC 2023 - marec@detebe.org - Update to version 0.28.0: * [avalanche] Document the staking rewards enable flag * [e.cash] Fix typo on upgrade page * [e.cash] Add upgrade page * Bump replay protection to May 15th 2024 * refactor: Reduce number of LoadChainstate parameters and return values * [electrum] better handle timeouts in test_interface * [electrum] release notification for 5.2.8 * [avalanche] Make the staking rewards activation chain dependent * [avalanche] Activate staking rewards on Nov. 15th, 2023 * Increase the minerfund IFP reward * [electrum] fix hardware wallets (except Trezor) * [avalanche] Update the staking rewards ratio * Bump version to 0.28.0 * [Automated] Update seeds * [Automated] Update chainparams * [Automated] Update timing.json * [electrum] bump version to 5.2.8 and add release notes * [Apps][Examples] Refactor sendXec demo to use updated API in ecash-coinselect v2.0.1 * [electrum] fix pubkey sorting when signing multisig * [electrum] fix x_pubkey format in multisig wallet * [electrum] never suggest the same proof master key or delegation key twice * [electrum] minor improvements to proof editor * Update makeseeds.py to support 0.28.x * [electrum] remove last usages of int_to_le_hex and rev_hex * [electrum] progress converting keystore.py to using bytes * [electrum] fix OldKeyStore.get_pubkey_derivation * Do not call global Params() when chainman is in scope * Do not pass CChainParams& to PeerManager::make * Do not pass CChainParams& to BlockAssembler constructor * Do not pass Consensus::Params& to Chainstate helpers * Do not pass time getter to Chainstate helpers * [Cashtab][Alias] Patch silent bugs introduced by spec change * [Cashtab] Add deprecation announcement for encrypted msgs * validation: add Config to ChainstateManager * [e.cash] Swpazone widget edits * [electrum] fix get_tx_derivations for regular keystores and imported keys keystores * refactor: Post-"Chainstate loading sequence coalescence" fixups * test: call VerifyLoadedChainstate during ChainTestingSetup * streams: Add AutoFile without ser-type and ser-version ------------------------------------------------------------------- Thu Oct 05 17:35:04 UTC 2023 - marec@detebe.org - Update to version 0.27.15: * [qt] Remove assignment in if statement * [Cashtab] Add test cases for one-to-many xec sends * [Cashtab] Replace obsolete log statement in unit test * [Cashtab] Refactor new tx function to accept targetOutputs * [avalanche] Fix occasional failures in abc_p2p_avalanche_voting * [e.cash] Add Swapzone widget * [avalanche] Fix the local proof status when it is already registered * [avalanche] Move the processor updatedBlockTip logic to a private method * Lighten the net logging * [electrum] avoid unneccessary bytes <-> hex conversion for block header * [electrum] use bytes for pubkey in keypairs arg for tx.sign() * [electrum] public_key_from_private_key return bytes * [electrum] return bytes in tx.serialize_preimage() * [avalanche] Remove some useless logs * [avalanche] Rationalize the local proof status in getavalancheinfo * Bump version to 0.27.15 * [electrum] let CoinChooser.make_tx take a list of TxInput * [electrum] coinchooser bucket refactoring * [Automated] Update seeds * [Automated] Update chainparams * [Automated] Update timing.json * [alias-server] Update README in line with current API endpoints * [avalanche] Fix a bug in the avalanche logs * [ecash-coinselect] Improve dust error msg * [Cashtab] Commence refactor of transaction building * [avalanche] Don't ban for polling cooldown not elapsed * [avalanche] Remove TimePoint in favor of SteadyMilliseconds * [Chronik] Optimize SpentByWriter using merge ops * [Chronik] Fix `catch_merge_errors` by keeping intermediate results * [electrum] use a WaitingDialog to resolve aliases * [electrum] support eCash aliases in the "Pay To" field * [electrum] implement adding eCash alias to contacts * [Cashtab] Better UI for param sends * [explorer] Patch error failures on slp v2 txs * [avalanche] Use SteadyMilliseconds where possible * [avalanche] Rename CNode's last_poll member to m_last_poll * [avalanche] Move the last poll time out of the node state * [avalanche] Add coverage for the cooldown feature * [avalanche] Make the network more resilient to temporary network slow downs * [ecash-coinselect] Simplify to match functionality of coinselect library * [electrum] add a new type of contact for ecash aliases * [lint] exclude icons.py from more linters * [electrum] remove unused do_update_signal signal * [electrum] finish removing main_window references in ContactList * [electrum] move get*Filename wrappers out of MainWindow * [electrum] move delete_contacts to ContactList * [electrum] remove more uses of main_window in ContactList * [electrum] pass a wallet.contacts reference to ContactList * [electrum] move ElectrumWindow.set_contact method to ContactList * [electrum] move new contact dialog to contact_list.py * [electrum] start supporting oa1:xec and stop supporting oa1:bch as openalias prefix * [Cashtab] Load settings page with saved wallets collapse open * [electrum] rename tx_from_str to rawtx_from_str * [electrum] store and serialize tx data as bytes * [electrum] consolidate compact_size code * [electrum] fix error dialogs in main_window * [electrum] start using tx.txinputs() in the wallet * [Cashtab] Support UAE Dirham currency * [Automated] Update seeds * [Automated] Update chainparams * [Automated] Update timing.json * [electrum] restore tx notification * [e.cash] Add stub developers page * [e.cash] Add Guarda wallet * [electrum] minor cleanup of Transaction.fetch_input_data * [electrum] fix OutPoint.__str__ * [apps and Cashtab] Implement monorepo chronik mock and deprecate repo-specific implementations * [alias-server] Deprecate local script lib * [chronik] Add support for HTTPS connection to the test framework python client * [Cashtab] Clear input forms when user toggles between single and multi-send * [apps] Consistently apply naming convention for mocha unit test files * [Cashtab] Deprecate unused function * [alias-server] remove redundant address validation from db function * [electrum] check output type in Transaction and fix a callsites that still passes a regular tuple * [electrum] use TxInput (almost) everywhere in transaction.py * [electrum] add prev_tx to TxInput * [electrum] convert var_int to return bytes * [alias-server] Add API endpoint to get pending aliases by address * [electrum] convert Transaction.update_signatures to take bytes * [electrum] fix return type handling of transaction.deserialize in trezor and keepkey plugins * [electrum] move Transaction.serialize_output() to TxOutput.serialize() * [electrum] move Transaction.serialize_input to TxInput.serialize * [electrum] cache scriptsig for complete inputs, invalidate it for incomplete inputs ------------------------------------------------------------------- Tue Sep 19 16:15:19 UTC 2023 - marec@detebe.org - Update to version 0.27.14: * [electrum] move get_preimage_script from Transaction to TxInput * [electrum] support coins with only x_pubkeys and no pubkeys defined * [gitian] Fix log2 symbol versioning * Bump version to 0.27.14 * [avalanche] Fix a use after out-of-scope in peermanager tests * [avalanche] Use the new staking reward algorithm * [avalanche] Add a new staking reward selection algorithm * [electrum] move some methods from Transaction to TxInput * [electrum] make TxInput properly support non serialized inputs * [Automated] Update seeds * [Automated] Update chainparams * [Automated] Update timing.json * [electrum] use Transaction.estimated_size() in consolidate.py * [electrum] make the coin consolidator use schnorr sigs if enabled * [electrum] fix int to bytes conversion for curve points when gmpy is installed * [Cashtab] Run suggested react update to bring browserslist up to date * [Cashtab] Deprecate parseXecSendValue * [Cashtab] Show total send amount in modal for one-to-many send txs * [ecash-coinselect] Update getInputUtxos to support N x p2pkh outputs * [Cashtab] Check if user has browser extension installed * [alias-server] Support for pending alias txs * [ecash-herald] Restrict length of unknown op-return msgs * [avalanche] Fix wrong init of the chain work in tests * [electrum] update the release procedure regarding the version tag * [electrum] clarify the concept of number of sigs in a TxInput * [avalanche] Improve the staking reward proof age selection * [electrum] push release notification for 5.2.7 * [Cashtab] Fix NaN render bug in paybutton links without specified amount * [electrum] make parse_input return a TxInput * [electrum] don't return dict in Transaction.serialize() * [electrum] bump the version 5.2.7 and add release notes * [electrum] implement TxInput.to_coin_dict and TxInput.is_complete * [electrum] remove parse_scriptSig function * [electrum] implement scriptSig parsing for TxInput * [electrum] replace match_decoded function with more explicit functions * [electrum] delete unused code that raises on linux and windows * [electrum] fix NameError in keepkey.py * [alias-server] Make unconfirmed txs available to handleBlockConnected * [electrum] remove more bytes <--> hex conversions in bitcoin.py * [electrum] remove uneccessary hex <--> bytes conversions in bitcoin.py * [electrum] remove unnecessary hex conversion when converting int to bytes * [Automated] Update seeds * [Automated] Update chainparams * [Automated] Update timing.json * [electrum] remove unused Transaction.is_memory_compact * [e.cash] Add media link to blog post * [e.cash] Revert twitter image url * [explorer] Add test chains address support to the explorer * [avalanche] Reject blocks that don't have the staking rewards output * [avalanche] Add the staking rewards to the coinbase outputs * [avalanche] Compute staking rewards winner for each block * [explorer] Fix pagination for larger page counts * [explorer] Properly handle the search bar * [electrum] use bytes internally for pubkeys * [electrum] use the default sequence as fallback for Transaction.txinputs() * [mock-chronik-client] minor README formatting updates * [e.cash] Use a different source for the twitter image * [electrum] estime tx size without serializing * [electrum] fix compact_size_nbytes for 0-length scripts * [mock-chronik-client] Add module to monorepo * [CI] Run the chronik-client unit tests on diffs * [linter] Fix flake8 E721 warnings ------------------------------------------------------------------- Tue Sep 05 20:38:47 UTC 2023 - marec@detebe.org - Update to version 0.27.13: * [electrum] let unittest discover all test cases * [electrum] fix sweep and add a test * [Automated] Update seeds * [Automated] Update chainparams * [Automated] Update timing.json * [ecash-herald] Tighter token send descriptions * [electrum] use an IntEnum for script types * [electrum] add a TxInput class * [electrum] remove dead servers * [electrum] Interface: Use check_hostname instead of match_hostname * [electrum] don't hack sys.path in setup.py * [electrum] Rename and move COutPoint to transaction.py:OutPoint * [electrum] move serialize.py out of avalanche * [electrum] implement size computation for TxOutput * [electrum] don't use an alias for the OpCodes class * [Chronik] Shut down node after errors in merge operators gracefully * [alias-server] Handle SIGTERM and SIGINT events for graceful app shutdown * remove unused SERIALIZE_TRANSACTION const * show amounts in XEC for CTransaction in logs * [avalanche] Deterministically select a payout script from the previous block hash * [Chronik] Use Rust `compress_script_variant` to speed up indexing * [Chronik] Add `compress_script_variant` to compress script variants * [Chronik] Add `Script::variant` * [e.cash] Fix twitter image tag * [electrum] move DUST_THRESHOLD constant to transaction.py * [electrum] remove "dust_to_fee" ephemeral value * [electrum] access TxOutput value by attribute name rather than index in coinchooser * [Automated] Update seeds * [Automated] Update chainparams * [Automated] Update timing.json * [ecash-coinselect] Fix byte count calculation logic * [ecash-herald] Support new miner, solopool.org * [CI] Add support for the ecash-coinselect lib on CI * Fix wrong RPC timeout in all the tests * Fix a potential race in p2p_inv_download * rpc: Keep default argument value in correct type * [Chronik] Update Rust version to 1.72.0 and nightly to 2023-08-23 * [ecash-herald] Parse zergpool miner * refactor: remove redundant fOnlySafe argument * rpc: include_unsafe option for fundrawtransaction * [Chronik] Optimize `GroupHistoryWriter` using batching and RocksDB's merge operator * refactor: remove c-string interfaces for DecodeBase58{Check} * Bump version to 0.27.13 * Make AnalyzePSBT next role calculation simple, correct * [Chronik] Update Cargo.lock dependencies to latest version * Consolidate all uses of the fast range mapping technique in util/fastrange.h * [Chronik] Add `-chronikperfstats` flag to write performance stats into <datadir>/perf ------------------------------------------------------------------- Tue Aug 22 16:05:36 UTC 2023 - marec@detebe.org - Update to version 0.27.12: * faster HexStr => 13% faster blockToJSON * test: Change feature_config_args.py not to rely on strange regtest=0 behavior * Replace boost::variant with std::variant * [Automated] Update timing.json * [Automated] Update seeds * [Automated] Update chainparams * [ecash-herald] Cleaner OP_RETURN parsing * psbt: Assert that tx has a value in UpdatePSBTOutput * Update TSan suppressions * test: Avoid intermittent issues due to async events in validationinterface_tests * sync: detect double lock from the same thread * build: Drop unneeded ApplicationServices framework dependency * [electrum] fix BIP 21 URI handling * [chronik] Keep required Rust version in one place * [ecash-herald] Add CoinMinerz.com to parsing support * [contrib] skip the first conflict when rebasing the electrum history * [Chronik] Fix: Race condition when re-orging a block with txs * [Chronik] Add `/pause` and `/resume` endpoints * [electrum] add tests for command line preprocessing * [Automated] Update timing.json * [Automated] Update seeds * [Automated] Update chainparams * [Cashtab] Deprecating ticker.js * [Cashtab] Replace currency object with appConfig for everything except alias settings * [e.cash] Remove env vars from repo * [Cashtab][Alias] Upgrade Alias UI * [explorer] Fix ordering of paginated txs * Cleanup remaining -deprecatedrpc=whitelisted * Remove the -deprecatedrpc=softforks option * Remove the -deprecatedrpc=getblocktemplate_sigops rpc option * Remove deprecated isfinalxxx options * Bump version to 0.27.12 * [e.cash] Rename "ecash-brand" page to "brand" * [Apps][Examples] Sending XECs * [Cashtab] Move settings validation and supported fiat currency list out of Ticker.js and to settings * [Apps][Examples] Update examples list * [Apps][Examples] Add pubkeyhash and privkey to the createWallet example * [Automated] Update timing.json * [Automated] Update seeds * [Automated] Update chainparams * [Cashtab] Move defaultCashtabCache out of Ticker.js ------------------------------------------------------------------- Fri Aug 11 05:47:57 UTC 2023 - marec@detebe.org - Update to version 0.27.11: * Bump version to 0.27.11 * [Apps][Examples] Create a websocket to listen for confirmation on a transaction * [Automated] Update timing.json * [Automated] Update seeds * [Automated] Update chainparams * [e.cash] Switch theme * [e.cash] Rearrange quote order * [Apps] [Examples] Improve README layout * [e.cash] Fix typo in FAQ * [e.cash] Escape quotation marks * [e.cash] Update FAQ item about Avalanche * [e.cash] weglot fix * [e.cash] Update FAQ question about claiming split BCH * [e.cash] Reorder FAQ * Remove shortened timeouts in p2p_invalid_messages * [eCash library][ecash-coinselect] Initial npm module for basic utxo selection * [e.cash] camel case hrefLang tag * [doc] Add suggestion to use Phorge Arcanist to CONTRIBUTING file * [Cashtab][Alias] Add alias status check to wallet contacts * [Automated] Update timing.json * [e.cash] Announcement bar edits * [Automated] Update seeds * [Automated] Update chainparams * [doc] Tweak CONTRIBUTING file * [Cashtab] Remove tech debt around checking token names for scams * [chronik] Bump the RocksDb crate version to 0.21.0 * [Cashtab][Alias] Add chronik mock * [ecash-herald] Add docker files for automated prod deployments * [Cashtab] Use XEC and not XECs * [Cashtab][Alias] Deprecate alias caching mechanism * [Cashtab][Alias] Deprecate getAddressFromAlias * [Cashtab][Alias] Switch alias registration fee lookup to api * [e.cash] Add /get-ecash link to navbar price box * [Cashtab][Alias] Update SendToken.js to use api endpoint in place of getAddressFromAlias * [Cashtab][Alias] Deprecate getPendingAliases * [alias-server] Only add aliases to db if blockheight is avalanche confirmed * [alias-server] Return price and price expiration blockheight from /alias endpoint for unregistered aliases * [Cashtab] Remove unnecessary wrapper function * [doc/standards] Improve op return prefix guidelines * [Cashtab][Alias] Deprecate getAliasServerState * [Cashtab][Alias] Deprecate isAliasRegistered * [Cashtab][Alias] Deprecate isAliasAvailable * [Cashtab][Alias] Deprecate isAddressRegistered * fix chronik bridgeprimitives_tests * Remove buggy and confusing IncrementExtraNonce * [Automated] Update timing.json * [Automated] Update seeds * [Automated] Update chainparams * Fix a possible message ordering issue in abc_rpc_getavalancheinfo * [e.cash] add image sharp package * [contrib] don't manage merge conflict in extract-electrum.sh * [Cashtab][Alias] Refactor Alias.js to use new alias-server endpoints * [ecash-herald] Parse token ids for slp2 * [alias-server] Pricing by blockheight * [e.cash] Add redirect for /roadmap-explained ------------------------------------------------------------------- Sat Jul 29 15:47:54 UTC 2023 - marec@detebe.org - Update to version 0.27.10: * [avalanche] Fix the finalized proof count being wrong when pending nodes reconnect * [electrum] publish release notification for 5.2.6 * [electrum] make the derivation path scanner report number of txs on timeout * [e.cash] Add social card image * Bump version to 0.27.10 * [e.cash] Add anchor links to sections * [electrum] bump the version to 5.2.6 and add release notes * [electrum] use correct Electrum ABC version for DMG filename * [Automated] Update timing.json * [e.cash] Add roadmap page * [Automated] Update seeds * [Automated] Update chainparams * [e.cash] Add id to weglot script * [e.cash] Add Weglot * [electrum] fix broken hidapi build * [electrum] AppImage: Remove glib libraries from bundle to make QR scanner work * [chronik-client] Add prepublish command to prevent unbuilt npm deployments * [alias-server] Enable telegram announcements of alias registrations * [lint] remove the --preview flag when running black * [electrum] restart the Electrum ABC daemon with a fresh datadir for every test * [electrum] use the docker-compose command for functional tests * [Automated] Update timing.json * [Automated] Update seeds * [Automated] Update chainparams * [e.cash] Add google analytics script * [e.cash] Glitch text updates * [buildbot] support electroncash# and electrum# PR urls * [tests] double the RPC timeout for feature_blockfilterindex_prune.py * [electrum] specify language for code blocks in markdown * [electrum] add a "Backporting" section to CONTRIBUTING.md * [electrum] convert the plugin's README.rst to markdown * [electrum] always close the socket object in is_tor_port * [ecash-herald] Show address for self-send txs when there is only 1 address * [e.cash] Remove theme switch * [electrum] fix the temp datadir removal for functional tests * [electrum] install also the basic dependencies when running functional tests * [electrum] add a build configuration for functional tests * [chronik-client] Bump version number * [alias docs] Better language and implementation rule for possible price changes * [ecash-herald] Add txids to mocks instead of blocks * [electrum] make functional tests works for python < 3.10 * [electrum] make the functional tests current-working-directory agnostic * [electrum] always test the latest Bitcoin ABC and fulcrum in functional tests * [electrum] be selective about ignoring errors * [Cashtab][Alias] Update Send.js to use api endpoint in place of getAddressFromAlias * [e.cash] Add image priority * [Automated] Update timing.json * [Automated] Update seeds * [Automated] Update chainparams * [electrum] refactor make_unsigned_transaction to not generate the unspent coins every call * [electrum] split get_addr_io into get_address_unspent and get_address_spent * [electrum] don't run the unit tests twice * [electrum] add a basic test for setup.py * contrib: add an extract-electrum.sh script to mirror monorepo commits to github * [electrum] documentation overhaul and dedicated CONTRIBUTING.md * [electrum] README.md follow-ups * [cmake] Use the protobuf supplied cmake file instead of the cmake supplied one * [electrum] convert README to markdown * [e.cash] Add animations to site * [e.cash] Stealth theme tweaks * [e.cash] Reduce animation file sizes * [Cashtab][Alias] Deprecate isAliasServerOnline * [alias-server] Deprecate isRegistered: true * [e.cash] Add blog post page * [ecash-herald] Update var name to better reflect purpose * [ecash-herald] Show sent amount for Cashtab msgs * [e.cash] Add animation package and reusable settings * [Cashtab][Alias] Move getAliasRegistrationFee into aliasUtils * [e.cash] Fix footer issues * [alias-server] Add endpoint to display prices * [electrum] move JSON related classes and function from util to json_util * [ecash-herald] Use saved mocks if available ------------------------------------------------------------------- Wed Jul 12 12:02:12 UTC 2023 - marec@detebe.org - Update to version 0.27.9: * [electrum] update links in the documentation * [electrum] storage: speed up write() by using faster compression setting * [electrum] write compact JSON for unencrypted wallet files * [Cashtab][Alias] Deprecate reserved aliases * [Cashtab][Alias] Deprecate appendWithPendingAliases * [alias-server] Remove noise from logs * [Cashtab][Alias] Update alias-server wrappers to return JSON * [electrum] remove unused objects and methods in wallet * [e.cash] Homepage buttons * [chronik-client] Add example for chronik.token call * [electrum] fix storage.requires_upgrade and test it * [electrum] increase the max number of get_merkle requests in the network queue * [ecash-herald] Add directory of known-ish addresses * [Automated] Update timing.json * [Automated] Update seeds * [Automated] Update chainparams * [e.cash] Careers page * [CI] Install git-filter-repo from the backport debian apt repository * [ecash-herald] Add basic validation checks to make app robust against unexpectedly formed OP_RETURN txs * use git filter-repo instead of git filter-branch for the secp256k1 repository * wallet: fix segfaults related to ScriptPubKeyMan managing code * wallet: importdescriptors update existing * [Cashtab][Alias] Deprecate getAliasServerHistory * [ecash-herald] Prelim parsing for alias registration txs * [alias-server] Verify database is appropriately populated in unit tests * [ecash-herald] Limit number of displayed xec send txs * [Cashtab][Alias] Deprecate getLatestAliases * [Cashtab][Alias] Implement getAliasesForAddress * [Cashtab][Alias] Implement getAliasDetails * [ecash-herald] Sort msgs by amount of xec sent * [ecash-herald] Remove spacer bracket from xec send msg descriptions * [electrum] add a check-electrum target * [ecash-herald] Only show to/from addresses if sender or receiver are kinda $$$ * [ecash-herald] Standardize headers for msg sections * [electrum] extract sorting helper methods from MyTreeWidget to mixin class * [electrum] no need to pass parent to MyTreeWidget * [electrum] move-only: extract MyTreeWidget and related code to its own module * [Cashtab][Alias] Deprecate alias history refresh in handleUpdateWallet * [ecash-herald] Patch sync functions defined as async in utils unit test * [ecash-herald] Improve formatting of xec send msgs * [ecash-herald] Display token amounts as locale strings * [Apps][Examples] Create wallet * [Cashtab] Improve isValidStoredWallet validation * [alias-server] Error response handling patch * [Cashtab] Updating processChronikWsMsg unit test * [ecash-herald] Log success msgs by blockheight * [Apps][Examples] Get eToken Info * [Apps][Examples] Get Utxos from address * [Cashtab][Alias] Deprecate alias specific BlockConnected websocket events * [Apps][Examples] Remove chronik url input arg from getDetailsFromTxid * [Apps][Examples] Remove chronik url input arg from getTxHistoryFromAddress * [e.cash] Add dates to blog * [ecash-herald] Remove useless info from prod logs * [ecash-herald] Only use others if more than 1 others * [ecash-herald] Patch import error for secrets * [ecash-herald] Remove toLowerCase by using latest ecashaddrjs * [ecashaddrjs] Support use of lowercase types for encoding addresses * [ecash-herald] Handle error if getTokenInfoMap is provided with a non-tokenId txid * [ecash-herald] Patch bug in determining tokenId from SWaP txs * [ecash-script] Export the getStackArray function * [ecashaddrjs] Return type as lowercase for use with chronik * [Apps][Examples] getTxHistoryFromAddress * [contrib] fix extract-secp256k1.sh to support spaces in filenames * [e.cash] Add blog page * [electrum] document the release procedure * [ecash-herald] Patch error in parsing burn txs * [test] Prevent feature_block spurious timeout * Add a gettime RPC * Bump version to 0.27.9 * [Automated] Update timing.json * [Automated] Update seeds * [Automated] Update chainparams * [Cashtab] Improve cashtabCacheKeys validation logic * [ecash-herald] Comment patch * [ecash-herald] Add tx fee display to self send XEC txs * [ecash-herald] Improve readability of tx fees * [alias-server] Add endpoint for looking up registered aliases by address * [electrum] push notification for 5.2.5 * [electrum] remove redundant parameters for command-line arguments * [electrum] add command line option to test the update_checker * [ecash-herald] Improve error handling comments in token id info function * [ecash-herald] Remove one-off promise building function from utils and add to its parent function * [ecash-herald] Label addresses with emoji based on balance * [alias-server] Add endpoint to get alias info and availability from alias * [Apps] [Examples] Initial mocha framework and getDetailsFromTxid example * [electrum] bump version to 5.2.5 and add release notes * [electrum] update CONTRIBUTING.md * [electrum] fix test_runner.py failure when PyQt5 is not installed * [electrum] move run_tests.py -> test_runner.py * [cmake] move make_link function to a new MakeLink module * [e.cash] Naming tweak for fetch blog function * [alias-server] Add new database function to lookup registered aliases by address * [alias-server] Add quotes to make error log less ambiguous * [alias-server] Update getAliasInfoFromAlias to not return _id field * [electrum] rely on pycryptodomex being installed in hash_160 * [electrum] use pycryptodomex everywhere, drop pycryptodome * [electrum] remove winconsole ------------------------------------------------------------------- Wed Jun 28 09:08:56 UTC 2023 - marec@detebe.org - Update to version 0.27.8: * [electrum] add missing encodings to open() calls and enable linter * [Automated] Update timing.json * [Automated] Update seeds * [Automated] Update chainparams * [electrum] automate test discovery * [e.cash] Get blog posts * [alias-server] Clean up README as prep for documenting API endpoints * Bump version to 0.27.8 * [Cashtab] Move parseAddressForParams out of Ticker.js * [Cashtab] Move defaultSettings out of Ticker.js * [Cashtab] Move explorer config out of Ticker * [electrum] bump some versions in deterministic requirements * [Cashtab] Add unit tests for parseAddressForParams * [Cashtab] Move chronik pagination config out of Ticker * [Cashtab] Deprecate xecApiBatchSize * [Cashtab] Move the opreturn config out of Ticker.js * [ecash-herald] Reduce test blocks * [alias-server] Refactor to support unit testing of API endpoints * [Cashtab] Move the token urls config out of Ticker.js * [Cashtab] Move the websocket config out of Ticker.js * [electrum] fix flake8-comprehensions warnings and enable flake8 for electrum * [lint] add a .isort.cfg file contrib/buildbot * [cashtab] Add chronik2.fabien.cash as a backup * [cashtab] Move the chronik urls config out of Ticker.js * [Cashtab] Constant locale for jest snapshots * [alias-server] Add function to query database by alias * [e.cash] Fix button text color * [electrum] fix flake8-builtins errors * [electrum] initial monorepo integration * [e.cash] Add mining section * test: Remove false coinstatsindex test * [Automated] Update timing.json * [Automated] Update seeds * [Automated] Update chainparams * [chronik apps] Revert back to chronik.fabien.cash as primary chronik backend * [alias-server] Ignore tx history before aliases active * [cmake] Link with pthreads * refactor: introduce single-separator split helper `SplitString` * [ecash-herald] Support for configurable emojis in msgs * [e.cash] Add wallets page * Bump the timeout of the blockfilter index test * [alias-server] Update aliasConstants import in index.js * [ecash-herald] Clean up comments for fusion tx parsing * [ecash-herald] Remove hardcoded string from function * [ecash-herald] patch bug in satsToFormattedXec * [ecash-herald] display amounts in fiat if prices are available * [ecash-script] Add new function getStackArray * [chronik-swap] switch default chronik servers * [explorer] Temporary switch to be.cash chronik instance * [alias-server] Bring generateMocks script up to date with app * [e.cash] Add tile section to homepage * [ecash-herald] Format sent xec amounts * [ecash-herald] Miner parsing for molepool * [ecash-herald] parse etoken burn txs * [e.cash] Expand scope of linter to include other files and directories that should be linted * [e.cash] Add header using default next lint settings * [e.cash] Add strict linting for next.js * [e.cash] Fetch exchanges and services and render on get ecash page * [alias-server] Use ecash-script to parse alias registrations according to latest spec * Add Cowperthwaite activation logic * Activate wellington by block height * [ecash-herald] Preliminary parsing of empp and slp v2 txs * [ecash-herald] Support encrypted cashtab msgs * guix: use proper compiler in cmake toolchain * build, qt: Use mkspecs/bitcoin-linux-g++ for all Linux hosts * [e.cash] Typo fix in RoadmapSection styled component * [e.cash] Center H2 image * [Chronik] Add `Node`, a wrapper struct to access the node from Chronik * [ecash-herald] Remove debug log in parseTests.js * [ecash-herald] Remove obsolete app constants from op_return.js * [ecash-herald] parse airdrop txs * [e.cash] Add functions to fetch exchanges and score and sort them * [e.cash] Fix subpage hero display issue * [Automated] Update timing.json * [Automated] Update seeds * [Automated] Update chainparams * [e.cash] Add id param and better comments to H3 component * [alias-server] Remove reserved aliases from aliasConstants * [alias-server] Move aliasConstants out of config and into constants dir * Fix arm64 darwin package def for OpenSSl * [guix] remove a reference to a ppc64 patch * [ecash-herald] Parse SwAP txs * [CI] Increase the gitian build timeout * Reject 0.26.x nodes from the seeds * [depends] bump jemalloc to 5.3.0 ------------------------------------------------------------------- Thu Jun 15 17:04:33 UTC 2023 - marec@detebe.org - Update to version 0.27.7: * Distribute the chronik protobuf file in the gitian release * [alias-server] Run npm audit fix to update dependencies * [alias] spec overview before alias-server implementation * [depends] Use more recent config.guess and config.sub in various packages * build: copy config.{guess,sub} post autogen in zmq package * depends: bump openssl to 1.1.1t * [Automated] Update timing.json * depends: couple of fixes * [Automated] Update chainparams * [Automated] Update seeds * [chronik] Install the protobuf file * Workaround jemalloc printing warnings to stderr with qemu * [ecash-herald] Parse cash fusion txs * [ecash-herald] Add new script to support testing, sendMsgByBlock * [ecash-herald] Remove deprecated function * Fix parallel make of OpenSSL * Remove the miner fund consensus code * Remove tx MIN_STANDARD_VERSION and MAX_STANDARD_VERSION * [ecash-script] Add option to return pushdata to existing consumeNextPush function * [ecash-herald] Parse memo txs using ecash-script library * [ecash-herald] Prep OP_RETURN strings for tg parsing depending on content * Cleanup remaining chained-tx related code and comments * depends: update the native_*.mk files * Remove tx chained limit from the coin selection algorithm * Rewrite OutputGroups to be clearer and to use scriptPubKeys * Explicitly filter out partial groups when we don't want them * Move OutputGroup positive only filtering into Insert * depends: use latest config.(guess|sub) * build: add -fstack-clash-protection to hardening flags * build: use macOS 11 SDK (Xcode 12.2) * Move EligibleForSpending into GroupOutputs * Move fee setting of OutputGroup to Insert * Move GroupOutputs into SelectCoinsMinConf * Remove OutputGroup non-default constructors * build: add -fcf-protection=full to hardening options and test for control flow instrumentation * [ecash-script] Add unit tests to CI * scripts: make security checks architecture independent * [Automated] Update timing.json * [Automated] Update seeds * [Automated] Update chainparams * [e.cash] Add get ecash page * [ecash-herald] Implement ecash-script for OP_RETURN parsing * [ecash-script] Add util function swapEndianness * Revert to finding and linking boost headers * Fix a warning with GCC 13.1 * Optimization: Coin&& to UndoCoinSpend * refactor: Do not discard try_lock() return value * Add time helpers for std::chrono::steady_clock, Remove unused GetTimeSeconds * [ecash-opreturn] New npm library for parsing OP_RETURN in ecash app dev * [arclint] prettier to more of the monorepo p4 of 4 - add more directories to prettier for .arclint * [arclint] prettier to more of the monorepo p3 - lint modules/ * [arclint] prettier to more of the monorepo p2 - lint apps/ * [arclint] prettier to more of the monorepo p1 - lint doc/standards * build: header-only Boost * [tests] remove nullptr workaround for boost < 1.64 * [depends] remove atomic,date_time from Boost config_libraries * bump minimum required boost version to 1.64 * build: Update Boost to 1.81.0 in depends * [Chronik] Add `broadcast_tx` to `ChronikBridge` * [Chronik] Fix: Indexed block size is 0 when running `-chronikindex` * build, refactor: Improve package version usage * build: fix unoptimized libraries in depends * Make `node::BroadcastTransaction` take `const NodeContext &`, remove unused `Config` param * [guix] bump glibc to 2.8 * Remove remaining chained tx stats * Remove the fee delta statistics for ancestors and decendants * Bump version to 0.27.7 * Remove the unused mempool ancestor/descendant update facilities * Remove the mempool policy constants that are no longer used * Remove the mempool chained txs limit checks when calculating a tx ancestors * scripts: use LIEF for ELF security & symbol checks * devtools: Correctly extract symbol versions in symbol-check * bump glibc to 2.28 * misc updates security-check and symbol-check * refactor: Drop boost/algorithm/string/replace.hpp dependency * [alias-server] Remove debug logging * [alias-server] push parsing for op return * [build] link boost * refactor: use std::shared_mutex & remove Boost Thread * depends: Split boost into build/host packages + bump + cleanup * build: use a static .tiff for macOS .dmg rather than generating * build: mac deployment unification * Remove mempool tx package limits * [herald] Improved miner parsing * [alias-server] add consume function in new script parsing file * [Automated] Update timing.json * [Automated] Update seeds * [Automated] Update chainparams * lint: don't forget to lint .bash files * [Chronik] Fix "Node and Chronik diverged" when both are fully synced * [Chronik] Fix build: Add `Clone` derive to `DataError` * [Chronik] Add eMPP (eCash Multi Pushdata Protocol) * Drop Darwin version for better maintainability * symbol-check: Check requested ELF interpreter ------------------------------------------------------------------- Wed May 31 15:19:48 UTC 2023 - marec@detebe.org - Update to version 0.27.6: * Build an experimental chronik release * build: don't compress macOS DMG * Remove the obsolete mempool and wallet chained tx limit options * replace $(AT) with .SILENCE. * [Chronik] Fix: "Segmentation fault" during shutdown * [Chronik] Add `BitcoinSer::deser` to deserialize messages encoded in the Bitcoin protocol * [Chronik] Add `TxId::from_tx` * [Chronik] Add `Hashed::digest` + implementations * [Chronik] Stop re-sync if `ShutdownRequested` is true * build: Remove spaces from variable-printing rules * [guix] build dmg as a static binary and skip cmake RPATH patching * depends: Improve id string robustness * refuse to overwrite an existing file with extract_xcode.py * Remove the mempool internal wellington upgrade latch * build, qt: backport patches * build, qt: bump Qt5 version to 5.15.5 * build: Qt 5.15.2 * depends: progress on Apple ARM support * [herald] Move non-config constants to separate file * [e.cash] Add faq page * [e.cash] H2 style tweak * build: patch qt to explicitly define previously implicit header include * build: Do not build unused CoreWLAN stuff in depends for macOS * depends: Do not force Precompiled Headers (PCH) for building Qt on Linux * Add a test-only createwallettransaction RPC * build, qt: Ditch `no_sdk_version_check.patch` * build: Cleanup depends build system * build: Use Qt top-level build facilities * [Automated] Update timing.json * [Automated] Update seeds * [Automated] Update chainparams * [e.cash] Add brand page content * [e.cash] Add start of brand page * [doc] Add Elon Musk's 5-step process to CONTRIBUTING document * [e.cash] Add content for core tech page * [e.cash] Update README to use npm ci * [lint] relax black version requirement * [e.cash] Add page content for wealth redefined * Bump version to 0.27.6 * build: Makes rcc output always deterministic * build, qt, refactor: Drop sed commands for win32-g++/qmake.conf * depends: Qt 5.12.11 * [e.cash] Sub-page hero section * [e.cash] Add footer to layout * index: Commit DB_MUHASH and DB_BEST_BLOCK to disk together * index: Avoid async shutdown on init error * index: Improve robustness of coinstatsindex at restart * [Automated] Update timing.json * [Automated] Update seeds * [Automated] Update chainparams * rename abc-parkedchain.py -> abc_feature_parkedchain.py * reset m_best_fork_tip if the fork becomes the main chain ------------------------------------------------------------------- Wed May 17 19:43:03 UTC 2023 - marec@detebe.org - Update to version 0.27.5: * index, rpc: Coinstatsindex follow-ups * Unpark the checkpointed blocks * [Cashtab] Remove unused chronik param from Ticker.js * [Cashtab] Remove unused param from Ticker.js * Add a checkpoint after the May 15th, 2023 upgrade * [e.cash] Add navbar background change on scroll * [e.cash] Fix font imports * [lint] remove references to autopep8 * [Automated] Update seeds * [Automated] Update chainparams * Temporarly disable lint checks in automated commits * [e.cash] Add roadmap section * [lint] replace autopep8 with black (contrib/buildbot) * [lint] support optional newlines when linting python's open function * [lint] replace autopep8 with black (contrib/devtools) * [lint] replace autopep8 with black (contrib minus buildbot and devtools) * [lint] replace autopep8 with black (everything but contrib) * [lint] replace autopep8 with black (test_framework) * Bump version to 0.27.5 * [lint] replace autopep8 with black (test/functional/wallet_*) * [lint] replace autopep8 with black (test/functional/rpc_*) * [lint] replace autopep8 with black (test/functional/p2p_*) * [lint] replace autopep8 with black (test/functional/interface_*) * [lint] replace autopep8 with black (test/functional/feature_*) * [lint] replace autopep8 with black (test/functional/[mempool,mining,misc]) * [lint] fix deprecation warning printed to stderr by black * [Automated] Update timing.json * [alias-server] replace util with lib * [ecashaddrjs] Add function to get outputScript from address * [Cashtab] Support alias registration of user input addresses * [alias spec] Add Usage section * [lint] replace autopep8 with black (test/functional/chronik_*) * [lint] replace autopep8 with black (test/functional/abc_*) * [lint] replace autopep8 with black (test/functional/abc-*) * Remove Makefile * [e.cash] Refactor global css * [e.cash] Add story section content * [herald] parse etoken send txs * [herald] Patch bug in splitOverflowTgMsg * [cmake] Improve EVP_MD_CTX_new detection * [Cashtab] Broadcast alias registration txs per latest spec * [Chronik] Add `/block-txs/:hash_or_height` HTTP endpoint * [Chronik] Refactor: Add `HashOrHeight` enum * [e.cash] Add H2 component * add missing #include <cstdint> where needed * [backport#26924] refactor: Add missing includes to fix gcc-13 compile error * [Chronik] Add `Tx.size` to protobuf * [Chronik] Add various block stats to `BlockInfo` protobuf message * [Chronik] Add `BlockStatsReader` and `BlockStatsWriter` * [e.cash] Add hand image to hero section * [Automated] Update timing.json * [Automated] Update seeds * [Automated] Update chainparams * [Chronik] Add `size` to `ffi::Block` * [herald] Handle messages longer than Telegram max * [prettier linter] lint cashtab * [Chronik] Add `/raw-tx/:txid` endpoint * [chronik] Bump the RPC timeout in tests * [release] Stop building Ubuntu Bionic packages * [Chronik] Add `BitcoinSer` impl for `Tx` and dependencies * [Cashtab] Add function to create alias op_return outputScript * [linter] Avoid unreachable code in shell scripts * [explorer] Lint the explorer * [Cashtab] [OP_RETURN msg upgrade] - Pt3 - Use bytecount for encrypted messages * [Cashtab] [OP_RETURN msg upgrade] - Pt2 - Use bytecount for unencrypted airdrop messages * [Cashtab] [OP_RETURN msg upgrade] - Pt1 - Use bytecount for unencrypted messages * [e.cash] Stealth theme video speed * [e.cash] Remove social icon container width * Add CashAddr specification * [alias spec] Add Version * [e.cash] Add button component * [linter] Bump prettier minimum version to 2.6.0 * [Chronik] Add `BitcoinSer` and `BitcoinSerializer` * [Chronik] Add `load_raw_tx` to chronik-bridge * [Chronik] Add `/blocks/:start_height/:end_height` HTTP endpoint * [linter] Match clang-format version from homebrew * [linter] Add a linters.md documentation * [Chronik] Add `/blockchain-info` HTTP endpoint ------------------------------------------------------------------- Tue May 02 16:23:57 UTC 2023 - marec@detebe.org - Update to version 0.27.4: * [Chronik] Add `Script::iter_ops` and `ScriptOpIter` * [herald] Parse XEC send txs * [alias-server] Add mock telegram bot to support unit tests of planned telegram bot msg features * [buildbot] Add a deployment Dockerfile * [alias-server] Patch unit test name error * [alias-server] Dont call serverState object an array * [alias-server] Remove obsolete log * [alias-server] Remove debug logging from unit tests * [alias-server] Deprecate custom log function * Fix a bug in blockencoding_tests * build: MacOS toolchain bump * [Automated] Update seeds * [Automated] Update chainparams * [lint] address new errors introduced by flake8-comprehensions 3.12.0 * [Chronik] Add `block_tx_num_range` to `TxReader` * [Chronik] Send `TX_FINALIZED` msg for txs that are in a block that have been finalized by Avalanche * [Chronik] Prefix WS protobuf enum entries with `BLK_` or `TX_` * [Chronik] Add `Opcode::N` to get a constant with the opcode's number * test: Fix out-of-range port collisions * [alias-server] implement new db functions in handleBlockConnected to fetch and store aliases * scripts: add checks for minimum required OS versions * Revert "[arclint] Expand scope of `prettier` linter" * [buildbot] Migrate out of flask.JSONEncoder * build: use -isysroot over --sysroot on macOS * [chronik-client] Add to arc lint * [arclint] Expand scope of `prettier` linter * [arclint] Lint .arclint file with prettier * Fix the filesystem library check on GCC8 and Clang8 * Make the Amount constructor noexcept * build: split native_cctools * build: Replace genisoimage with xorriso * [Automated] Update timing.json * [e.cash] Add more complete README info to run the site locally * [e.cash] Use shorter Telegram link * [e.cash] Add hero section content * [e.cash] Add styled components * Fix QPainter non-determinism on macOS * [Chronik] Allow subscribing to WebSocket script updates * [Chronik] Require subscribing to WebSocket block updates * [Chronik] Add `read_bytes` and `read_array` * [Chronik] Make `u8` in `Opcode` pub * [Chronik] Add all push opcodes to opcode.rs * [Cashtab] Lose the one address format reminder * [Chronik] Refactor: Split out `parse_*` functions into their own module * [Chronik] Refactor: Change to `Mempool::remove_mined` * [chronik-client] Add existing package to the monorepo as-is * [Chronik] Add `/script/:type/:payload/utxos` HTTP endpoint * [Chronik] Add `MempoolGroupUtxos` to store mempool UTXOs by group * [GUIX] Let cmake use the environment variable for (C|CXX|LD)FLAGS * [Chronik] Use `is_final_height` in `make_tx_proto` * [GUIX] Git ignore the GUIX build files * [chronik] Fix chronik_spent_by test * [chronik] Fix running the functional tests with no chronik dependencies * [Chronik] Refactor: Add `make_outpoint_proto` * [Chronik] Index spent_by + add `spent_by` to `Tx` protobuf * [Chronik] Refactor `QueryTxs::tx_by_id`: remove Cow etc. * [guix] implement guix build for linux * [explorer] Fix line break issues for Script Decoded section on transaction page * depends: Pin clang search paths for darwin host * [Chronik] Add `MempoolSpentBy` * build: set minimum supported macOS to 10.14 * Bump version to 0.27.4 * [Chronik] Add `SpentByWriter` and `SpentByReader` * [linter] Work around a shellcheck issue * [Chronik] Add `Avalanche::is_final_height` * [Chronik] Add missing copyright notice in `mem/group_history.rs` * [alias spec] Rename from XEC to eCash * [docs] fix broken link in CONTRIBUTING.md file * [build] don't link boost::filesystem * [lint] Fix remaining variables shadowing python builtins and enable detection of shadowed variables going forward * [lint] Fix variables shadowing python builtins in zmq_sub.py * [lint] Ignore shadowing of ord() and chr() builtins in testgen/base58.py * [lint] Fix variables shadowing python builtins in linearize-data.py * build: remove boost::filesystem and boost::system usages * util: Work around libstdc++ create_directories issue * Drop StripRedundantLastElementsOfPath() function * refactor: replace boost::filesystem with std::filesystem * [cmake] link necessary lib for std::filesystem * [lint] Fix variables shadowing python builtins in gen-ninja-deps.py * [Automated] Update timing.json * [alias spec] Reword specification to make it more descriptive * [alias spec] Remove info about non-alphanumeric aliases * [chronik mock] Make sure history function is async so Promise.all() tests work * [lint] Fix variables shadowing python builtins in interface_zmq.py * [lint] Fix variables shadowing python builtins in the test framework * [lint] Fix variables shadowing python builtins in abc_p2p_avalanche_transaction_voting.py * [lint] Fix variables shadowing python builtins in rpc_generateblock.py * [lint] Require flake8-builtins to ensure we do not add shadowing of python builtins * [lint] Fix remaining arguments shadowing python builtins * util: Avoid buggy std::filesystem:::create_directories() call * [alias spec] Remove comment about refunds * [alias spec] Remove section on reserved aliases * [linter] Lint the buildbot import files ------------------------------------------------------------------- Wed Apr 19 17:47:00 UTC 2023 - marec@detebe.org - Update to version 0.27.3: * Work around a bug with std::filesystem::temp_directory_path() with some MinGw * depends: Fix compile error for Qt when using newer GCC 11+ * [Cashtab] [Alias] - Accept aliases as eCash address in contact list * [Cashtab] Update utxo-lib to latest version * [alias-server] Helper function to get array of strings with just alias names * [alias-server] Modify getValidAliasRegistrations to work with partial tx history * [ecashaddrjs] Ensure README displays at npmjs page * [herald] Remove unused flag from `parsedTx` data * [herald] Remove unnecessary flag variable * [herald] Clean up code commenting in parse.js * [herald] Move telegram function to telegram.js * Add missing include in fs.cpp * [Chronik] Add `GroupUtxoWriter` and `GroupUtxoReader` * [Chronik] Refactor `Group`, add `input_members` and `output_members` * Bump version to 0.27.3 * [alias-server] Deprecate reserved aliases * [alias-server] Do not use toLowerCase() * [Chronik] Add block WebSocket messages at `/ws` * [monorepo org] Move cashtab-components to modules * [alias-server] Better organization for db unit tests * [alias-server] Add new database methods for getting and storing aliases * [Chronik] Add `IndexTx` and `prepare_indexed_txs` * [e.cash] add video background component * [monorepo org] Move standards folder from web to doc * [alias-server] Initialize serverState database collection with read and write helper methods * [alias-server] Deprecate confirmedTxs collection from database * [Monorepo org] Remove all dependency libraries that have been replaced by Bitgo utxo-lib and bitcoinjs-message * [herald] Create msg lines while iterating over parsed txs * [ecashaddrjs] Patch bug in README link to correct display at npm listing * [Cashtab] Extension version bump * [CI] Add support for cashtab preview * [Cashtab] Replace xecjs-message with bitcoinjs-message * [Cashtab] Deprecate ecashjs-lib * [Chronik] Add avalanche support * [Chronik] Use struct init for `QueryTxs` instead of `new` * [ecashaddrjs] Add isValidCashAddress function * [herald] patch bug in file renaming * [alias-server] Prevent reentrency in handleBlockConnected * [CI] Use 80 as a default port for previews * [CI] Add explorer to the preview * [Automated] Update timing.json * [Automated] Update seeds * [Automated] Update chainparams * [e.cash] Add navbar component * Call `SyncWithValidationInterfaceQueue` after RPCs * [ecashaddrjs] Version bump * [ecashaddrjs] Add unit tests to CI * [Chronik] Refactor: Add `QueryBlocks`, instead of using `BlockReader` directly * [Chronik] Add `/script/:type/:payload/history` * [Chronik] Refactor tests: add genesis coinbase consts * [Chronik] Add general-purpose python `ChronikClient` * [node apps with websocket] Rename websocket handler file * [alias-server] Bump avalancheCheckCount * [bullseye-deps] Install nodejs 16 instead of 15 * [herald] Add price info to sent tg msgs * [herald] New formatPrice function to prep prices for tg msgs * [herald] Improve getCoingeckoPrices to return tickers and ecash price first * [herald] Improve sendTestTgMsgs script * [herald] Improve generateMocks script calling * [herald] Improve mocked chronik * [herald] Fix instantiation of new telegramBot mock in websocket unit tests * [tg bot] Improve how mocks are generated and stored * [herald] Default msg should be in HTML, not markdown * [herald] Refactor handleBlockConnected to support multiple api calls later * [herald] function to handle block connected msg * [herald] Remove un-needed .js from scripts in package.json * [tg bot] Unit test for main() * [herald] Unit tests for parseWebsocketMessage * [herald] Unit tests for initializing websocket * [herald] Rename unit test file * [herald] Rename chronik src file to websocket.js * [alias-server] Unit tests for main.js * [alias-server] Implement mock mongo db and test it * [alias-server] Check avalanche isFinalBlock in handleBlockConnected * [alias-server] Add avalancheCheckWaitInterval as a parameter to prevent 10s delays in unit tests * [alias-server] Get block height in handleBlockConnected * [alias-server] get tipHash and tipHeight on app startup * [alias-server] Implement better chronik mock * [explorer] Display decoded scripts in tx details * [CI] Fix the preview timeout potential failure * [test framework] use an Enum instead of typing.Literal for PortName * [e.cash] Improve website description * Cleanup unused TEST_RUNNER_TEMPLATE variable * [CI] Fix diff regex for JS Mocha templates * [buildbot] Advertise a preview url is available * [CI] Use a random port for the website preview * [buildbot] Disallow non ABC members from summoning builds with a docker configuration * Fix shadowing of python builtins in tests * Rename hash to txid for COutPoint in the test framework * depends: Use more legible qmake commands in qt package * [avalanche] Rename variables shadowing builtins in avatools * Bump minimum supported mypy version to 0.910 * [ecashaddrjs] Support ecregtest prefix * depends: Drop workaround for a fixed bug in Qt build system * build: use C++17 in depends * [ecashaddrjs] Add function to support conversion to legacy format * build: document and cleanup Qt hacks * [buildbot] Extract the build configuration retrieval and parsing to its own function * [CI] Add support for running website containers * [avalanche] Unify finding a hash in poll into can_find_inv_in_poll via avatools * Cleanup unused Jefferson activation time * Add layout component * [monorepo prettier] Prettier should ignore yml files * [e.cash] Add a Dockerfile to deploy the website * [CI] Templatize the js mocha projects unit tests * [lint] run mypy with --install-types and --non-interactive options * [lint] require plugin flake8-comprehensions * [lint] bump flake8 to >5 * [lint] run mypy on contrib * use dict literals to initialize python dictionaries * [lint] run flynt on contrib * [lint] run isort on contrib * devtools: Improve *-check.py tool detection * [alias-server] match output scripts for p2pkh or p2sh registration address * [alias-server] Remove irrelevant comments * [alias-server] Improve mocked chronik class * [alias-server] Use address as parameter instead of hardcoded p2pkh and hash parameter * contrib: Add tests for symbol-check * Add base next.js files for ecash site * [Cashtab] [Alias] Confirmation modal on registration * contrib: use LIEF symbol-check * contrib: use LIEF for security checks * [alias-server] replace optionalMocks param with mocked instance of chronik * [alias-server] Chronik functions take chronik as a param to support future mocking * [alias-server] Handle startup case with its own callback in parseWebsocketMessage * [herald] add copyright header to files * [node apps using mocha] suppress console.log output from passed unit tests * [lint] don't add newline to empty python files * [lint] fix parsing of severity in mypy output * contrib: Parse ELF directly for symbol and security checks * scripts: add PE dylib checking to symbol-check.py * scripts: add MACHO dylib checking to symbol-check.py * [Automated] Update timing.json * [Automated] Update seeds * [Automated] Update chainparams * [alias-server] add copyright header to lint * [herald] add function to get crypto price info * [monorepo js formatting] Add .prettier files to top level * [tg bot] deprecate unused and obsolete utils function * devtools: Add security check for separate_code * build: add -Wl,-z,separate-code to hardening flags * [ecashjs-message] Fix unit tests * [alias-server] move to apps/ folder * [alias-server] Removing untested logic from parseWebsocketMessage * [cmake] Check the linker flags against the actual linker * scripts: security-check.py refactors * [herald] Organize repo with src dir * [Cashtab] Move directory out of web and to top level * [herald] Add unit tests to CI * [monorepo organization] rename xecjs-message to ecashjs-message * [Chronik] Add `/script/:type/:payload/unconfirmed-txs` * [flynt] remove buggy --transform-concats option * [Chronik] Add `/script/:type/:payload/confirmed-txs` * scripts: add MACHO Canary check to security-check.py * [alias-serve] Replace utils address function with now-available ecashaddrjs function * [monorepo dir org] Move ecashaddrjs to modules * [Lint] Lint everything, apply some of the patches * [Chronik] Remove `Network` proto enum * scripts: rename test_64bit_PE to test_PE * [alias-server] Initialize telegram bot in index.js and pass as function parameter to websocket functions * [herald] add to arc lint * [herald] Lint the repo * [Chronik] Add `GroupHistoryWriter::member_num_pages_and_txs` * scripts: add MACHO NX check to security-check.py * scripts: add MACHO tests to test-security-check.py * [Lint] Also catch `log!` and `log_chronik!` in .rs files in LogLinter * [Chronik] Move proto logic from `QueryTxs::tx_by_id` to `make_tx_proto` * [Chronik] Remove `chronik-bridge` dependency from `chronik-db` * scripts: add MACHO PIE check to security-check.py * [Chronik] Add `ScriptGroup` to group txs by script * [alias-server] Add RPC call for isFinalBlock * [ecash-herald] Rename ecash-telegram-bot to ecash-herald * [tg bot] Better organization for unit tests * [ecashaddrjs] Adding to arc lint * [ecashaddrjs] linting with eslint * [Cashtab] Update out of date readme * [Chronik] Add \n to logs in error.rs * Remove shift-base:net-processing from ubsan suppressions * Replace RecursiveMutex cs_mapLocalHost with Mutex, and rename it * Use block policy state instead of parked state to determine if a policy was violated * [ecashaddrjs] Support encoding outputScript to address * [ecashaddrjs] Return address decode results ready for chronik * Log the reason for a block policy violation * [Chronik] Add `Group::ser_member`, remove `Into<Vec<u8>>` bound on `Group::Member` * [Chronik] Add `compress_script` and `decompress_script` to `chronik-bridge` FFI * [Chronik] Add `ScriptVariant` and `ScriptType` * test: Use self.wait_until over wait_until_helper * [depends] Force PIC/PIE in native protobuf * [avalanche] Sort txs to poll by modified fee rate * [Chronik] Add `PubKeyVariant` to `bitcoinsuite-core` * [Chronik] Fix script capacities in script.rs & dead code in script_mut.rs (again) ------------------------------------------------------------------- Tue Apr 04 12:31:47 UTC 2023 - marec@detebe.org - Update to version 0.27.2: * [Chronik] Add `bitcoinsuite_core::Tx` et al., move away from `chronik_bridge::ffi::Tx` et al. * [Chronik] Add `OP_RETURN` opcode and `Script::is_opreturn` * [Chronik] Add `Script` and `ScriptMut` * [Automated] Update timing.json * [Automated] Update chainparams * [Automated] Update seeds * [Chronik] Add `UncompressedPubKey` * [tg bot] Improve msg sending tests * [tg bot] Improve mock generation * [tg bot] Improve construction of tg msg * [Chronik] Add `PubKey` struct * [Chronik] Move `HashedError` to `error` module, rename to `DataError` * [Chronik] Add `Opcode` struct * [chronik] Fix chronik_tx flakiness * [alias-server] Patch import refs in generateMocks.js * [alias-server] deprecate return of pending alias txs from getValidAliasRegistrations function * [alias-server] change function name getAllAliasTxs to getAliasTxs * build: libevent 2.1.12-stable * [alias-server] Rename secrets.js.sample so that it can be linted and formatted * [Cashtab] Deprecate husky * [alias-server] rename unit test files * [alias-server] Organizing files into src folder * [Cashtab] [Alias] Disable alias registrations if alias server is unavailable * [Cashtab] [Alias] Handle bad server response in `getLatestAliases()` on block routine * [ecashaddrjs] Support returning hash160 as string instead of uint8array * [alias-server] Add alias-server to arc lint * [alias-server] Linting repo with eslint * depends: CMake invocation cleanup * [alias-server] node unit test CI integration * [Chronik] Add `MempoolGroupHistory` * [Automated] Update timing.json * [Automated] Update seeds * [Automated] Update chainparams * [Cashtab] [Alias] pt 19 - Pre-prod update - Update getLatestAliases to use the State endpoint * [Chronik] Move `mempool` module to `chronik-db` * [Chronik] Return `TxNum` from `TxWriter::delete` * [Chronik] Add `Group` and `GroupHistoryReader/-Writer` to index the tx history of a group * [Chronik] Add `Default` derive to ffi structs in `chronik-bridge` * [Cashtab] [Alias] pt 18 - Pre-prod update - Remove residual dev logs * [Chronik] Fix: `tx_writer.insert` in `handle_block_disconnected` * [depends] Don't build shared libs in native protobuf * [lint] add the flynt linter for python f-strings * [ecashaddrjs] Update readme to latest repo info * [ecashaddrjs] Sort copyrights by date * [Chronik] Add `Mempool`, make `/tx/:txid` return mempool txs * [Chronik] Index txs; add `/tx/:txid` HTTP endpoint * [ecashaddrjs] Version bump * [ecashaddrjs] Remove version number from minified builds * [ecashaddrjs] Update licensing refs * [ecashaddrjs] Change comment references to bitcoincash: to ecash: in cashaddr.js * [ecashaddrjs] Support decoding prefixless addresses if checksum is correct * [ecashaddrjs] Use ecash: addresses in unit tests * remove glibc < 2.27 compat code * [Cashtab] [Alias-server] - pt 2 - Incorporate pending aliases endpoint * [Cashtab] [Alias-server] - pt 1 - Alias server api integration * [symbol-check] bump glibc to 2.27 and gcc to 8.3 * build: Disallow dynamic linking against c++ library * [Chronik] Move compiled `proto` module from `chronik-http` into new crate `chronik-proto` * [Chronik] Add `load_tx` * [ecashaddrjs] Fixing dependency tree * [ecashaddrjs] Move linting to monorepo standard * [ecashaddrjs] Adding existing library to monorepo as-is * [cashtab-components] Upgrade to storybook 7 to fix dependency tree * [Chronik] Bridge txs in `bridge_block` * [Chronik] Add `TxReader` and `TxWriter` * [avalanche] Make peer availability score accessible via getavalanchepeerinfo * [Chronik] Add `TxId` to bitcoinsuite-core * [Gitian] don't untar the source package * [cmake] Don't select an alternative linker for the native build * Improve the mempool check method * Remove a useless iterator cast in txmempool.cpp * [Chronik] Add reverse lookup index, allow hashes in `/block/:hash_or_height` * Factorize the tx use count checks in blockencodings_tests * Simplify entryToJSON * Fix chronik with no IPv6 * Fix port collision detection in functional tests * [Automated] Update timing.json * [Automated] Update seeds * [Automated] Update chainparams * Bump version to 0.27.2 * [Chronik] Fix: Err db deserialization if there's any leftover * More block template creation simplifications * Prevent copies in mempool_tests * Remove the non longer used epoch member ------------------------------------------------------------------- Sat Mar 25 12:02:31 UTC 2023 - marec@detebe.org - Update to version 0.27.1: * [Automated] Update timing.json * [Automated] Update timing.json * [Automated] Update seeds * [Automated] Update chainparams * Let BlockAssembler::AddToBlock take a mempool entry * [net processing] Default initialize m_recent_confirmed_transactions * scripted-diff: Rename recentRejects * [net processing] Default initialize recentRejects * [net processing] Add Orphanage empty consistency check * [tg bot] add function returnAddressPreview * [tg bot] port outputScriptToAddress function * Bump version to 0.27.1 * Fix the makeseeds.py version filter * refactor: replace RecursiveMutex cs_SubVer with Mutex (and rename) * Refactor: Uses c++ init convention for time variables * Refactor: Changes remaining time variable type from int to chrono * Change time variable type to std::chrono::seconds in src/net_processing.cpp * p2p: Always serialize local timestamp for version msg * p2p: Don't use timestamps from inbound peers * [test] improve style for abc-version-message.py and rename to abc_p2p_version_timestamp.py * refactor: various RecursiveMutex replacements in CConnman * scripted-diff: rename node vector/mutex members in CConnman * [avalanche] Limit polling of finalized items of all types * refactor: net: avoid duplicate map lookups to `mapLocalHost` * net: use member clientInterface rather than global uiInterface in CConman * p2p, rpc: address relay fixups * [Chronik] Add metadata and schema version to DB * [Cashtab] Bump webpack to resolve dependabot issue * [alias-server] add cors support * [alias-server] log API requester and hostname * [alias-server] Patch bug in log.js * [chronik websockets] Deprecate onReconnect logs for node server apps * [tg bot] support for parsing alias registration txs * p2p: refactor: tidy up `PeerManagerImpl::Misbehaving(...)` * [alias-server] Add function to get only unprocessed txs from chronik tx history * [alias-server] get count of txs that server has processed * [alias-server] Determine most recently processed blockheight on new block found * [Automated] Update timing.json * [Automated] Update seeds * [Automated] Update chainparams * [avalanche] Add a peer availability score that aggregates node availability scores * [Chronik] Pass `--locked` to cargo commands to lock dependencies * Randomize message processing peer order * Protect last outbound HB compact block peer * [Chronik] Disallow combining -prune and -chronik * Replace spaces with tabs in test/CMakeLists.txt * net: remove unnecessary check of CNode::cs_vSend * p2p: pass strings to NetPermissions::TryParse functions by const ref * [Chronik] Require at least Protobuf 3.0.0 for Chronik functional tests * [Chronik] Add `-chronikreindex` to only reindex Chronik * [Chronik] Wipe Chronik db when `-reindex` is set * Zero out wallet master key upon lock * [alias-server] Cache confirmed tx history of registration address * [alias-server] Add new function to remove unconfirmed txs from a set of chronik txs * [alias-server] enforce alphanumeric aliases * [tg bot] Support for utf8 memo actions * [tg bot] standardize line breaks between conditionally rendered sections * [tg bot] introduce app parsing for op_return msgs with cashtab msg parsing * remove cs_main extern declaration from net_processing.h * scripted-diff: rename NetPermissionFlags enumerators * p2p, refactor: make NetPermissionFlags a uint32 enum class * scripted-diff: add NetPermissionFlags scopes where not already present * p2p, bugfix: use NetPermissions::HasFlag() in CConnman::Bind() * net: Avoid calling getnameinfo when formatting IP addresses * [lint] improve handling of escaped % in lint-format-strings * [Cashtab] [Alias] Hyperlink the alias address preview * [Chronik] Resync index * [Chronik] Add `ChronikBridge::load_block` * [cashtab-componets] npm module maintenance * remove indentation level in ProcessGetBlockData * net: Simplify ProcessGetBlockData execution by removing send flag. * log: Clarify that block request below NODE_NETWORK_LIMITED_MIN_BLOCKS disconnects * refactor: Pass PeerManagerImpl members only once * [net processing] Remove unused CNodeState.address member * [Chronik] Generate Chronik port for functional test * net: Log to net debug in MaybeDiscourageAndDisconnect except for noban and manual peers * [net processing] Remove CNodeState ctor body * Use C++11 member initializer in CNodeState * [Chronik] Add missing `ArrayToHash` function * [Chronik] Add `get_block_info` * [Chronik] Make `ChronikBridge::get_chain_tip` return `CBlockIndex` * [Chronik] Add `ChronikBridge::find_fork`, for `CChain::FindFork` * [Chronik] Add `get_block_ancestor` for `CBlockIndex::GetAncestor` * [Chronik] Add `ChronikBridge::lookup_block_index` * [Chronik] Move ffi::Block into chronik-bridge, use CBlockIndex and CBlock * refactor, net: Relocate CNode private members and increase data member encapsulation * [Cashtab] [Alias] Real time update of Registered Aliases list upon new registration * [Cashtab] [Alias] - Alias address preview upon valid input * [Cashtab] [Alias] Enforce alphanumeric inputs * [tg bot] Parse OP_RETURN msgs * [tg bot] Pass txid to link etoken name to genesis tx * [tg bot] Clean strings that could contain special characters before adding to telegram html msg * [tg bot] add estimated miner based on coinbase string * [tg bot] remove extra line break from tg msgs * [tg bot] change link name for token document url * [tg bot] conditionally render tx or txs depending on txcount * [tg bot] use token instead of etoken in variables * [tg bot] change msg format from markdown to html * [tg bot] Add test script for sending messages * [tg bot] Remove commented out code * [Chronik] Minor fixes in chronik_block.py * remove unused code related to removed deprecated RPC fields * [net] Move RecordBytesSent() call out of cs_vSend lock * Expose integral m_conn_type in CNodeStats, remove m_conn_type_string * net: Remove unused cs_feeFilter * Make Amount trivially copyable * [ecash-telegram-bot] Add etoken and genesis tx info in block msgs * [Chronik] Add `/block/:height` HTTP endpoint * refactor: Remove defunct attributes.h includes * refactor: make MainSignalsInstance() a class, rename it to MainSignalsImpl * [cmake] Disable ABI changes warnings * [Automated] Update timing.json * [Automated] Update seeds * [Automated] Update chainparams * [Cashtab] [alias-server] [ecash-telegram-bot] Update chronik-client to patch bug in chronik.block * [Cashtab] [Alias] pt 16 - Resolve reserved aliases to aliasPaymentAddress * [explorer] Add backlink to e.cash in footer * [alias-server] Add USD price info to telegram bot msgs * [alias-server] Add util functions for getting byte count, use them to patch tg bot bytecount bug * [alias-server] Improve code organization, generate mocks from script * [Cashtab] [Alias] pt 17 - Enforce lowercase inputs * [Cashtab] [Alias] Emoji parsing edge case * [Cashtab] Improve SEO per marketing recs * Bump protobuf version from 2.61 to 21.12 in native_protobuf.mk + enable Chronik build again * scripted-diff: replace non-standard fixed width integer types (u_int... -> uint...) * Sanity assert GetAncestor() != nullptr where appropriate * refactor: remove use of boost::algorithm::replace_first * Wrap boost::replace_all ------------------------------------------------------------------- Fri Mar 10 16:58:03 UTC 2023 - marec@detebe.org - Update to version 0.27.0: * [Cashtab] [Alias] pt 15 - Reserved Aliases * [alias-server] Telegram bot to announce new alias registrations * [alias-server] Support for reserved ABC aliases * [ecash-tg-bot] Show blockheight and tx count in block update msgs * [ecash-telegram-bot] MVP example telegram bot using chronik to announce blocks found * [gitignore] Add secrets.js to monorepo .gitignore to support js apps that use keys * [Cashtab] [Alias] pt 14 - Frontend bytesize validation * Bump replay protection to Nov 15th 2023 * Don't assume any banscore in abc_p2p_avalanche_voting * Fix a typo in abc_rpc_avalancheproof * [consensus + avalanche] Move miner fund from consensus to policy * Fix a flakiness in abc_p2p_avalanche_proof_voting * [avalanche] Do not poll avalanche invalidated blocks more than once * [alias-server] Reject alias registrations that are case variants of previously registered valid aliases * [Standards] Spec for xec aliases * [Cashtab] [Alias] pt 13 - real time alias char length and registration fee display * [alias-server] Isolate valid registrations not in db before adding * Remove magic number for tx version in bitcoin-tx * fix multiprocessing part of interface_rpc test on MacOS * Improve the performance of removeForBlock * [CI] Unbreak the cross builds * [Automated] Update timing.json * [Automated] Update seeds * [Automated] Update chainparams * [Chronik] Fix build for Windows, fix `util/hash.h` * [Chronik] Build proto for python + HTTP 404 proto fallback * use f-strings in test_framework (long lines) * [tests] use f-string instead of .format(*tuple) * interface_rpc: improve reliability of test_work_queue_exceeded with multiprocessing * [alias-server] Accept overpaid tx fees * fix formatting of header for functional test results * [Chronik] Protobuf & HTTP error response handling * [Chronik] Move `HashToArray` to util/hash.cpp/h * use f-string in test_runner.py * use f-strings in functional tests (long lines) * [Chronik] Add `parse_error_status` to parse error msgs as HTTP status * Remove dead code in mempool * [isort linter]: relax line length (88 instead of 79) * flynt: use f-strings in all remaining python files (excluding contrib) * test: use f-strings in the test framework * test: use f-strings in wallet_* tests * test: use f-strings in rpc_* tests * test: use f-strings in p2p_* tests * test: use f-strings in mempool_* and mining_* tests * test: use f-strings in interface_* tests * test: use f-strings in abc_* tests * test: use f-strings in abc-* tests * test: use f-strings in feature_* tests (part 3, with flynt) * [autopep8] set max line length to 88 * skip subtest test_work_queue_exceeded in interface_rpc.py when CLI is not compiled * [alias-server] [p17] Add API endpoint, MVP of app * [alias-server] [p16] Update database on block * [alias-server] [p15] Only add alias records if alias is unique * [alias-server] [p14] Write alias data to database * [alias-server] [p13] Initialize mongodb * [alias-server] [p12] Add mocks and unit tests including unconfirmed txs * [alias-server] [p11] Complete function set to achieve final alias registration result * [alias-server] [p10] Store blockheight in parsed alias txs * [alias-server] [p9] Refactor functions to accept constants as input params * [alias-server] [p8] Complete getAliases function * [alias-server] [p7] parseAliasTx and unit tests * [alias-server] [p6] outputScriptToAddress function and unit tests * [alias-server] [p5] Commenced getAliases function * [alias-server] [p4] Timestamped logging * [alias-server] [p3] Support promise.all to fetch full tx history of address * [alias-server] [p2] Add chronik function to get txhistory for last 25 txs * [alias-server] [p1] Template node app * util: Handle HTTP_SERVICE_UNAVAILABLE in bitcoin-cli * validation, test, bench: make CScriptCheck and prevector swap member functions noexcept * Deprecate the mempool ancestor and descendant limit options * test: use f-strings in feature_* tests (part 2). * test: check for RPC error 'Transaction already in block chain' (-27) * [Chronik] Fix a comment in `ChronikIndexerError` * test: resolve bug in test/functional/interface_bitcoin_cli.py * test: use f-strings in feature_* tests (part 1) * Avoid double copy when emplacing into DisconnectedBlockTransactons::txInfo * mempool: Slight performance nit when erasing from setEntries * Disable the chained-tx limit after wellington * Latch the wellington activation in the mempool * Fix wait_for_debug_log acting as a noop * [Consensus] Allow only tx versions 1 and 2 by consensus * Fix randomly failing scheduler_tests test * Remove needless timeout in functional test * Fix rpc_deprecated with wellington activated * Revert "Fix the deprecation warnings from new boost versions" * Fix the deprecation warnings from new boost versions * Deprecate the tx ancestors fields in listunspent * [Cashtab] Support parsing p2sh addresses in tx history * [Cashtab] [Alias] pt 12 - Upgrade tx history to recognize alias registration txs * [Cashtab] [Alias] pt 11 - Enable alias input for Send Token txs * Remove unused block height in mempool removeForBlock * remove most of versionbits / BIP9 related code * deprecate softforks from getblockchaininfo RPC * remove unused BIP9 code * [Cashtab] [Alias] pt 10 - Enable alias inputs for one to one Send XEC txs * [avalanche] Disable test framework default proof expiry * [avalanche] Log when a proof becomes invalid * Bump version to 0.27.0 ------------------------------------------------------------------- Fri Feb 24 15:46:11 UTC 2023 - marec@detebe.org - Update to version 0.26.13: * Update version to 0.26.13 * [Automated] Update timing.json * [Automated] Update seeds * [Automated] Update chainparams * [avalanche] Add regression testing for flip flopping votes on blocks * [avalanche] Reduce scope of block tips being checked in avalanche voting test * [Refactor] Rename `nLockTimeCutoff` in `ContextualCheckTransaction` to `nMedianTimePast` * [Cashtab] [Alias] pt 9 - Retain tokenInfoById upon alias validation * [Cashtab] [Alias] pt 8 - Activation flag in prod * [Cashtab] [Alias] pt 7 - Mitigate edge cases for registration records * [Cashtab] [Alias] pt 6.6 - Render list of Aliases owned by active wallet in Alias.js * [Cashtab] [Alias] pt 6.5 - Optimize getAllTxHistory to only make API calls for uncached tx history pages * [Cashtab] [Alias] pt 6.4 - Update getAliases() to extract both alias and address * [Cashtab] [Alias] pt 6.3 - Implement updateAliases * [Cashtab] [Alias] pt 6.2 - Implement getAliasesFromLocalForage * [Cashtab] [Alias] pt 6.1.1 - Apply Promise.All approach for alias history retrieval * [Cashtab] [Alias] pt 6.1 - Get latest alias tx count from payment address * [Cashtab] [Alias] pt 5 - Implement getAddressFromAlias function * [Cashtab] [Alias] pt 4 - Implement isAddressRegistered function * [Cashtab] [Alias] pt 3 - Implement isAliasAvailable function * [Cashtab] [Alias] pt 2 - Implement registerNewAlias() to handle alias registration * [Cashtab] [Alias] pt 1 - Create scaffold for new Alias component * Fix the OSX build * Introduce facility to evaluate miner fund as a block parking policy * mempool & mining: Use the topological ordering to break ties * mempool: Remove ancestor/descendant related stats from RPC * mempool: Save & restore mempool entry acceptance height on reorg * mempool: Add topological index, enforce consistency, updated reorg logic * Update nightly version in CONTRIBUTING.md to 2023-02-17 * [Explorer] Add support for BURN tx type * [Chronik] Update Rust version to 1.67.1, nightly to 2023-02-17 * [explorer] revert to abc hosted chronik * [RPC] Remove deprecated fee-related mempool entry fields * Bump version to 0.27.0 * [explorer] Temporary update to chronik instance * [Automated] Update timing.json * [Automated] Update seeds * [Automated] Update chainparams * [Automated] Update seeds * mempool: Removed the ancestor_score index * miner: Misc small refactor and renaming * mempool: Evict transactions by modified feerate * Improve miner fund whitelist test coverage * Dramatically reduce mempool_updatefromblock.py duration * Improvements to mempool_updatefromblock.py * [tests] use uint256_hex instead of repeating the string formatting pattern * scripted-diff: rename CChainState -> Chainstate * Pass lifetimebound reference to SingleThreadedSchedulerClient * [tests] show the proofid when representing a proof * miner: Remove use of CPFP in CreateNewBlock * Call CHECK_NONFATAL only once where needed * fix CTxMemPool::TrimToSize including too many things in pvNoSpendsRemaining * Rename mempool method queryHashes to getAllTxIds * Cleanup unnecessary empty set variable in minerfund test * Fixup unbackported comment in ConnectTip * mempool: Add new index for sorting txs by fee * [Automated] Update timing.json * [Automated] Update chainparams * mempool: ModifiedFeeRate getter for mempool entry * [consensus] Move miner fund logic into its own function * Return a set instead of a vector for the miner fund whitelist * [Explorer] fix copy address issue * Bench: Add mempool eviction benchmark for chained tx's * bench: Reorg benchmarks without mempool removal * bench: CreateNewBlock with long tx chains * bench: Reorgs of blocks with long tx chains * [buildbot] Fix the buildbot not updating the build status ------------------------------------------------------------------- Sat Feb 11 14:11:41 UTC 2023 - marec@detebe.org - Update to version 0.26.12: * [Automated] Update timing.json * [Automated] Update seeds * [Automated] Update chainparams * bench: Mempool acceptance for chained transactions * [explorer] Fix table sorting issues * [buildbot] Add links to bchn repo when porting code * [tests] bump timeout for receiving proof in get_ava_p2p_interface * validation: Prune UnloadBlockIndex and callees * make pindexBestForkTip and pindexBestForkBase private CChainState members * refactor: Introduce GetFirstStoredBlock helper function * util/check: Add CHECK_NONFATAL identity function and a NONFATAL_UNREACHABLE macro * validation: No mempool clearing in UnloadBlockIndex * style-only: Use std::clamp for check_ratio, rename * style-only: Use for instead of when loading Chainstate * init: Reset mempool and chainman via reconstruction * validation: default initialize and guard chainman members * [avalanche] initialize g_avalanche after loading the block chain * [Automated] Update timing.json * [Automated] Update seeds * [Automated] Update chainparams * [explorer] Update README * [Cashtab] Remove obsolete docs link * Add miner fund whitelist unit tests * Move SetMTP into test utils * [Explorer] Fix css rule for token table padding * Make BlockManager::LoadBlockIndex private * Remove superfluous landing page * [avalanche] Add transaction management to the processor core * [avalanche] Rationalize the options in the processor tests * [avalanche] Add facility to build a vote item from an inventory * Remove 10-block rolling finalization * [avalanche] Rewind Avalanche finalization if a finalized block is found to be invalid * Bump version to 0.26.12 * [Automated] Update timing.json * [Automated] Update seeds * [Automated] Update chainparams * wallet: drop anti-fee-sniping feature, set locktime = 0 * [avalanche] Simplify the processor test item providers by removing addToReconcile specialization * [avalanche] Simplify the processor test item providers by removing registerVotes specialization * [avalanche] Clarify the processor includes * [Cashtab] Match transaction input sequence to node and ElectrumABC ------------------------------------------------------------------- Sat Jan 28 10:30:16 UTC 2023 - marec@detebe.org - Update to version 0.26.11: * rpc: reduce LOCK(cs_main) scope in gettxoutproof * rpc: reduce LOCK(cs_main) scope in GetUndoChecked and getblockstats * rpc: reduce LOCK(cs_main) scope in blockToJSON * rpc: reduce LOCK(cs_main) scope in GetBlockChecked and getblock * zmq: remove LOCK(cs_main) from NotifyBlock * rest: reduce LOCK(cs_main) scope in rest_block * [avalanche] Add field to the getavalancheinfo RPC to monitor if our proof is shared * [Automated] Update timing.json * [Automated] Update seeds * [Automated] Update chainparams * [avalanche] Delay the local proof announcement until we have inbounds * [avalanche] Allow for overwriting a null delegation with another avahello * [avalanche] Fix a wrong test in abc_rpc_avalancheproof * Move txoutproof RPCs to txoutproof.cpp * scripted-diff: Rename pindexBestHeader, fHavePruned to m_best_header and m_have_pruned * Clear fHavePruned in BlockManager::Unload() * move-mostly: Make fHavePruned a BlockMan member * Clear pindexBestHeader in ChainstateManager::Unload() * move-mostly: Make pindexBestHeader a ChainMan member * validation: Load pindexBestHeader in ChainMan * [avalanche] Fix type error in abc_p2p_avalanche_peer_discovery * Remove extra semicolon * Add benchmark to write JSON into a string * Fix BlockToJsonVerbose benchmark * Guard CBlockIndex::nStatus/nFile/nDataPos/nUndoPos by cs_main * Require IsBlockPruned() to hold mutex cs_main * Require CBlockIndex::IsValid() to hold cs_main * Require CBlockIndex::IsAssumedValid() to hold cs_main * Require CBlockIndex::RaiseValidity() to hold cs_main * Require CBlockIndex::GetUndoPos() to hold mutex cs_main * Require WriteUndoDataForBlock() to hold mutex cs_main * Require CBlockIndex::GetBlockPos() to hold mutex cs_main * Bump version to 0.26.11 * [avalanche] Sync proofs when functional tests call sync_all * Add and use BlockManager::GetAllBlockIndices * Add and use CBlockIndexHeightOnlyComparator * Only load BlockMan in BlockMan member functions * style-only: No need for std::pair for vSortedByHeight * refactor: more const annotations for uses of CBlockIndex* * fix outdated comment * [avalanche] Leverage AnyVoteItem to have a single VoteItemUpdate object * style: Modernize range-based loops over m_block_index * refactor: Rewrite InsertBlockIndex and AddToBlockIndex with try_emplace * tests: Remove now-unnecessary manual Unload's * blockstorage: Make m_block_index own CBlockIndex's * Consistently use args/argsman in init.cpp * [avalanche] Add a facility for managing the command line options in the processor tests * [avalanche] Processor event loop: make sure we test what we expect * [avalanche] Drop unused reverse_iterator header from the processor * [avalanche] Consistently use the supplied ArgsManager * [avalanche] Improve test coverage of availability scoring * [avalanche] Move statistics constants into their own header * [avalanche] Using C++17 structured bindings to make unit tests more readable * [avalanche] Make unit test cases const * Fix getpeerinfo help text reference to availability score * [avalanche] Use the clear() method where applicable in the processor tests * Move the overloaded template to its own header/namespace * [avalanche] Make the finalization tip pointer const * [Automated] Update timing.json * [Automated] Update seeds * [Automated] Update chainparams * Fix a missing lock when accessing the block status * validation, refactoring: remove ChainstateManager::Reset() * validation: replace lock with annotation in UnloadBlockIndex() * [avalanche] Merge the block and proof vote records into a single data structure * Access miner fund destinations by reference in getblocktemplate * Make blockReward const when checking miner fund * [avalanche] Don't hold cs_main when adding a block to reconcile * [avalanche] Create a generic vote map that can have any kind of item being voted on * [Cashtab] Make sure snapshot changes are included in code review * [Explorer] Fix `chrono` deprecation warning for `Utc.timestamp` * [explorer] Add a Dockerfile for running the explorer * Add miner fund regression test around Wellington activation * [avalanche] Move the vote items to the update structure * Update copyright year for explorer * [Automated] Update seeds * [Automated] Update chainparams * Cleanup unused nodes in abc_mining_basic.py * [doc] Add notes on how to activate bash completion for locally built binaries * [avalanche] Vote on transactions * [avalanche] Remove explicit enable of avalanche in tests * [avalanche] Make the GetAvalancheVoteForBlock method const * Remove obsolete hidden arg ------------------------------------------------------------------- Tue Jan 10 17:46:52 UTC 2023 - marec@detebe.org - Update to version 0.26.10: * [Automated] Update timing.json * [Automated] Update seeds * [Automated] Update chainparams * [secp256k1] Update macOS image for CI * [secp256k1] ci: Run ASan/LSan and reorganize sanitizer and Valgrind jobs * Use explicit types for the Amount * Update Copyright year to 2023 * [secp256k1] Update the CI docker to Debian Bullseye * refactor, miner: Delete call to UpdatePackagesForAdded at beginning of addPackageTxs * refactor: remove duplicate code from BlockAssembler * miner: bug fix? update for ancestor inclusion using modified fees, not base * policy: Remove unused locktime flags * Remove unused MTP from ContextualCheckTransaction * wallet: Actually treat (un)confirmed txs as (un)confirmed * Fix a -Wreturn-type warning with GCC * [avalanche] Add logging when a block is parked due to conflict with avalanche finalized blocks * [Automated] Update timing.json * [Automated] Update seeds * [Automated] Update chainparams * [cmake] Fix a potential version mismatch in BerkeleyDB * [avalanche] Improve test coverage of existing parking behavior * [avalanche] Add test coverage for parking against avalanche finalized chaintip * [avalanche] Add the local proof verification status details to getavalancheinfo * Bump version to 0.26.10 * [Automated] Update timing.json * [Automated] Update seeds * [Automated] Update chainparams * Bump the p2p_blockfilters initial block sync timeout * [Cashtab] Deprecate biometric authentication ------------------------------------------------------------------- Fri Dec 30 16:17:34 UTC 2022 - marec@detebe.org - Update to version 0.26.9: * Bump version to 0.26.9 * [linter] Run prettier on the explorer * [Automated] Update timing.json * [Automated] Update seeds * [Automated] Update chainparams * Adding the explorer to the monorepo * [Cashtab] Updating snapshots * [linter] Remove and disallow js commented code * [linter] Use eslint to lint the javascript files * [cashtab] Remove unused vars * [cashtab] Ignore eslint false positive for jest import * [cashtab] Avoid loss of precision eslint error * [linter] Fix a linter issue * Use CTransactionRef where applicable in coins_tests * Use no test fixture for the RCU unit tests * Copy the smart pointer rather then the raw tx when adding a mempool tx to the wallet * [Cashtab] Improve vertical centering of QRCode in Receive.js * [Cashtab Docs] Removing docs from the monorepo * [Cashtab] [notification permission 2 of 2] Show modal after user notification decision * [Cashtab] [notification permission 1 of 2] Ask for notification permission if peristent storage is not granted * log: Remove GetAdjustedTime from IBD header progress estimation * Add missing thread safety lock assertions in validation.{h|cpp} * Fix unsigned integer overflow in LoadMempool * AcceptPackage fixups * [doc] more detailed explanation for deduplication * Remove cs_main lock annotation from ChainstateManager.m_blockman * Improve mempool trimming performance * bench: update nanobench add -min_time * Drop boost/preprocessor dependencies * bench, doc: benchmarking updates and fixups * test: update nanobench from release 4.0.0 to 4.3.4 * [Cashtab] Bump extension version * [Cashtab + libraries] ecashjs-lib to 1.0.3 and Cashtab to latest * Remove the txHashes structure from the mempool * [Automated] Update timing.json * [Automated] Update seeds * [Automated] Update chainparams * [backport#19379] tests: Add fuzzing harness for SigHasLowR(...) and ecdsa_signature_parse_der_lax(...) * [avalanche] Cleanup unnecessary timeout values in block voting test * [doc] Add suggestions in functional test documentation for improving debugging iteration speed * [doc] Fix incorrect argument syntax for --timeout-factor ------------------------------------------------------------------- Sat Dec 17 14:36:10 UTC 2022 - marec@detebe.org - Update to version 0.26.8: * Fix nits in txmempool.h/cpp * [Cashtab] Removing debug logging missed in prev stack * [avalanche] Optimize block parking * [avalanche] Clear finalization when manually switching chaintips * [Cashtab][extn] fix placement of popout button in extension * [eCash dev libraries] Improve README for ecashjs-lib * [eCash dev libraries] [p16 ecash ops] Upgrade dependencies throughout * [eCash dev libraries] [p15 ecash ops] Upgrade ecash-ops * [eCash dev libraries] [p14 ecash ops] Patch typo in readme and publish new version to correct * [eCash dev libraries] [p13 ecash-ops] ecash dependencies all the way down * [eCash dev libraries] [p12 ecash-ops] Typo fix in ecash-minimaldata * [eCash dev libraries] [p11 ecash-ops] Update ecash-minimaldata for correct dependencies * [eCash dev libraries] [p10 ecash-ops] Update package name and deps for pushdata-ecash 1.0.0 * [eCash dev libraries] [p9 ecash-ops] Change folder name from pushdata-bitcoin to pushdata-ecash * [eCash dev libraries] [p8 ecash-ops] Add pushdata-bitcoin * [eCash dev libraries] [p7 ecash-ops] Update package.json repo info * [eCash dev libraries] [p6 ecash-ops] Change folder name from minimaldata to ecash-minimaldata * [eCash dev libraries] [p5 ecash-ops] Clone minimaldata from bitcoinjs * [eCash dev libraries] [p4 ecash-ops] Adding OP_CODE from the actual published version of the repo * [eCash dev libraries] [p3 ecash-ops] Change name of npm module in package.json * [eCash dev libraries] [p2 ecash-ops] Change name of folder to ecash-ops * [eCash dev libraries] [p1 ecash-ops] Starting from existing module * [paymentservertests] fix certificates and payment requests * [avalanche] Actually finalize block in voting functional test * [Cashtab] Prompt for auth only if enabled - p2/2, implementing * [Cashtab] Prompt for auth only if enabled - p1/2, typo fix * Fix a typo in the release notes * [Automated] Update timing.json * [Automated] Update chainparams * [Automated] Update seeds * [ubsan] tentatively remove suppressions for txmempool and serialize * fuzz: Avoid -fsanitize=integer warnings in fuzzing harnesses, add UBSan suppressions * [eCash webdev libraries p3] Replace bitcoincashjs-lib with ecashjs-lib in Cashtab * [eCash webdev libraries p2] Rename to ecashjs-lib * [eCash webdev libraries] bitcoincashjs-lib as starting point for eCash stack * [Cashtab] Better code comments in parseChronikTx * [Cashtab] Running npm audit fix * [Cashtab] [wallet mgmt improvements p9] Patch async function call bug in useEffect * [Cashtab] [wallet mgmt improvements p8] Remove or improve debug logging * [Cashtab] [wallet mgmt improvements p7] Do not set renamed active wallet in state unless storage update succeeded * [Cashtab] [wallet mgmt improvements p6] Rename wallet param to activeWallet in renameActiveWallet * [Cashtab] [wallet mgmt improvements p5] activateWallet takes currently active wallet as a param * [Cashtab] [wallet mgmt improvements p4] Add UI locking to useWallet.js functions that change local storage * [Cashtab] [wallet mgmt improvements p3] Get all wallet context variables in the same call * [Cashtab] [wallet mgmt improvements p2] Only update wallet when user has changed wallets * [Cashtab] [wallet mgmt improvements p1] Add UI locking to settings page * [Cashtab] [final countdown bch param p4 thru p7] * [Cashtab] [final countdown bch param p3] Change name of send tx error code object * [Cashtab] [final countdown bch param p2] Delete getRestUrl function * [Cashtab] [final countdown bch param p1] Delete getBCH function * remove integer sanitizer suppression in validation.cpp * test: Avoid testing negative block heights * Fix implicit-integer-sign-change in bloom * zmq: Fix implicit-integer-sign-change * refactor: Make MessageBoxFlags enum underlying type unsigned * Avoid integer sanitizer warnings in chain.o * Avoid unsigned integer overflow in bitcoin-tx * Fix implicit-integer-sign-change in arith_uint256 * Fix implicit integer sign changes in strencodings and reduce size of strencodings decode tables * refactor: Fix implicit-signed-integer-truncation in cuckoocache.h * refactor: Remove implicit-integer-sign-change suppressions in validation.cpp * rpc: Replace boost::variant with std::variant for RPCArg.m_fallback * ci: ubsan report_error_type=1 and add suppressions * [Automated] Update timing.json * Temporarly unbreak the payment server tests * Fix automated timings updates * Remove NO_THREAD_SAFETY_ANALYSIS from non-test/benchmarking code * Rename sigop to sigcheck in getblocktemplate * Deprecate -bytespersigop in favor of -bytespersigcheck * refactor: Detach wallet transaction methods (followup for move-only) * Rename sigOps to sigChecks in functional tests * [Chronik Add empty HTTP server, take two * test: Print stderr when subprocess fails * [Cashtab] [Cashtab] [final bch-api deprecation p7] Use real chronik URLs * [Cashtab] [Cashtab] [final bch-api deprecation p6] Update API error component to be more descriptive * [Cashtab] [Cashtab] [final bch-api deprecation p5] Stop trying to reconnect to bad websockets * [Cashtab] [Cashtab] [final bch-api deprecation p4] Refactor tryNextApi function to try next chronik instance * [Cashtab] [Cashtab] [final bch-api deprecation p3] Initialize ChronikClient as a state variable * [Cashtab] [Cashtab] [final bch-api deprecation p2] Change chronikUrl to chronikUrls array * [Cashtab] [bch-api deprecation p1]Remove bch-api node check from useWallet.js * [Automated] Update seeds * [Automated] Update chainparams * Rename the remaining sigOps to sigChecks * Remove sigops count related dead code in the test framework * Rename sigOps to sigCheks in the policy files * Rename sigOps to sigCheks in the miner * Rename sigOps to sigChecks in txmempool * Remove unused method in settings.h * [Cashtab] Deprecate BCH from parseChronikTx * MOVEONLY: Move wallet backup and encryption RPCs out of rpcwallet * Add a new RPC command: restorewallet * [Cashtab] Remove documentation link from settings * Revert "[Chronik] Add empty HTTP server" * rpc: Add HelpExampleRpcNamed and HelpExampleCliNamed and use them for `createwallet` doc * MOVEONLY: Move utility functions from rpcwallet to wallet/rpc/util * wallet: Split signmessage from rpcwallet * [Chronik] Add empty HTTP server * [Cashtab] Prevent .map error in TxHistory * MOVEONLY: CWallet transaction code out of wallet.cpp/.h * Move CBlockFileInfo::ToString method where class is declared * [Cashtab] Add XBT to banned token ticker array * [CI] Remove obsolete setup script for Debian Buster * [chronik] Bump Corrosion to 0.3.0 * [chronik] use the node:: namespace for NodeContext * Add src/node/* code to node:: namespace * scripted-diff: Move miner to src/node * [Cashtab] [no BigNumber in indexedDb p2/2] Remove debug logging * [Cashtab] [no BigNumber in indexedDb p1/2] Store etoken balances as strings * [Chronik] Add `-chronik` and `-chronikbind` command line options * [doc] Fix the coin amount type in tracing.md * test: USDT tracepoint interface tests * Move WalletImpl from interfaces/wallet.cpp to wallet/interfaces.cpp * Move ChainImpl from interfaces/chain.cpp to node/interfaces.cpp * Move NodeImpl from interfaces/node.cpp to node/interfaces.cpp * [Cashtab] Create new wallets with ecash address * [Cashtab] [Remove BCH param from wallet derivation p3/3] Delete unused mocks * [Cashtab] [Remove BCH param from wallet derivation p2] Deprecate BCH param from deriveWallet * [Cashtab] [Remove BCH param from wallet derivation p1] Remove use of slpAddress from Cashtab * [Cashtab] Patch error when activating saved wallet for first time * [Chronik] Add `ChronikPort` to `CBaseChainParams`, use RPC-1 as port * [Cashtab] Patch addr validation error not displaying DestinationAddressMulti * test: Return new_utxo from create_self_transfer in MiniWallet * test: Use MiniWallet in feature_coinstatsindex * rpc: use peer_id, blockhash for FetchBlock * rpc: more detailed errors for getblockfrompeer * rpc: turn already downloaded into error in getblockfrompeer * remove unused includes in abc.cpp * rpc: Fail to return undocumented return values * rpc: getblockfrompeer * test: use MiniWallet for rpc_scantxoutset.py * test: Remove MiniWallet mempool_valid option * test: Return the largest utxo in MiniWallet.get_utxo * test: MiniWallet: more deterministic coin selection for coinbase UTXOs (oldest first) * test: MiniWallet: skip mempool check if `mempool_valid=False` * test: use MiniWallet for p2p_filter.py * [Linter] Fix all the lint warnings * [Linter] Fix MyPy linter with version 0.991 * [Cashtab] Remove broken link from README * tracing: utxocache tracepoints * refactor: Pass block reference instead of pointer to PeerManagerImpl::BlockRequested * [Cashtab] [Simplify wallet structure p8] Remove debug logging * [Cashtab] [Simplify wallet structure p7] Patch bug in variable definition * [Cashtab] [Simplify wallet structure p6] Ensure last final variable calcs match final variable names * [Cashtab] [Simplify wallet structure p5] Remove function specific variable name change * [Cashtab] [Simplify wallet structure p4] Remove parent artifact object slpBalancesAndUtxos * [Cashtab] [Simplify wallet structure p3] Remove unused utxos array * [Cashtab] [Simplify wallet structure p2] Remove duplicate tokens array * [Cashtab] [Simplify wallet structure p1] Show desired end state * scripted-diff: rename MarkBlockAs functions * [net processing] Tidy up MarkBlockAsReceived() * [net processing] Add IsBlockRequested() function * [net processing] Remove QueuedBlock.hash * scripted-diff: rename nPeersWithValidatedDownloads * [net processing] Remove CNodeState.nBlocksInFlightValidHeaders * [net processing] Remove QueuedBlock.fValidatedHeaders * [net processing] Remove unnecessary hash arg from MarkBlockAsInFlight() * [Automated] Update timing.json * [Automated] Update seeds * [Automated] Update chainparams * tests: Add fuzzing harness for CConnman * ConnectBlock: don't serialize block hash twice * tracing: drop block_connected hash.toString() arg * Enable clang-tidy bugprone-argument-comment and fix violations * [doc] explain why CheckBlock() is called before AcceptBlock() * refactor: Remove unused validation includes * [doc] Bump fuzzer child process memory limit * rpc: move Ensure* helpers to server_util.h * refactor: Add and use EnsureConnman in rpc code * refactor: Mark member functions const * Bump version to 0.26.8 * [Cashtab] Remove BCH param artifact from Configure snapshot tests * [Cashtab] Remove qr fallback artifact * [Cashtab] [deprecate BCH from token send p3] Remove from createToken and related components * [Cashtab] [deprecate BCH from token send p2] Remove from Send, Burn, and SendToken * [Cashtab] [deprecate BCH from token send p1] Remove BCH param from generateTokenTxInput * [Cashtab] Remove unused screenshots folder * [Cashtab] Deprecate BCH from getMintAddress * [Cashtab] Add local function to convert hash160 to ecash: address * [Cashtab] Deprecate BCH param from sendXec * [Cashtab] Deprecate BCH param from getRecipientPublicKey function * [Cashtab] Deprecate BCH param from signAndBuildTx function * [Cashtab] Deprecate BCH param from generateTxOutput function * [Cashtab] Deprecate BCH param from getChangeAddressFromInputUtxos function * [Cashtab] Deprecate BCH param from generateTxInput function * [Cashtab] Use XEC balance change to unock UI after token sends and burns * bitcoin-cli: Correct docs (no "generatenewaddress" exists) * [Cashtab] [deprecate etoken addresses p4] Add temp info blurb to Receive * [Cashtab] [deprecate etoken addresses p3] Remove address switch on receive screen * [Cashtab] [deprecate etoken addresses p2] Remove type-specific address descriptors from placeholders and error msgs * [Cashtab] [deprecate etoken addresses p1] Support token sends to ecash: addresses * [Cashtab] Remove unused imports from test file * [Lint] Refactor check-doc.py to have a list of folders * [Cashtab] Improve SEO * [Cashtab] Patch overlapping text on amount input error Send.js ------------------------------------------------------------------- Sun Dec 04 16:16:03 UTC 2022 - marec@detebe.org - Update to version 0.26.7: * [Cashtab] [Deprecate toLegacyCash p3/3] Remove now-unused functions, unit tests, and mocks * [Cashtab] [Deprecate toLegacyCash p2] Stop converting ecash addresses to bitcoincash in Send.js for one-to-many * [Cashtab] [Deprecate toLegacyCash p1] Stop converting ecash addresses to bitcoincash in Send.js * [Cashtab] [Address simplification p4/4] Remove unused toLegacyToken function * [Cashtab] [Address simplification p3/4] Deprecate BCH param from generateTokenTxOutput * [Cashtab] [Address simplification p2/4] Stop converting to legacy format for Burn Token * [Cashtab] [Address simplification p1/4] Stopconverting to BCH formats for Send Token * [Cashtab] [xecjs-message upgrade p3/3] Remove debug logging and tests * [Cashtab] [xecjs-message upgrade p2/3] Sign msgs with ecash prefix in xecjs-message * [Cashtab] [xecjs-message upgrade p1/3] Deprecate segwit support from xecjs-message * [Cashtab] Fallback to block time if timeFirstSeen is zero * [avalanche] Enable avalanche by default * Remove unused MaybeSetAddrName * build: improve detection of eBPF support * [Cashtab] [local opreturn encode p2/2] Simplify function * [Cashtab] [local opreturn encode p1/2] Deprecate BCH.script.encode * [Cashtab] [Deprecate BCH msg signing p3/3] Deprecate msg signing with bchObj * [Cashtab] [Deprecate BCH msg signing p2/3] Implement local msg signing * [Cashtab] [Deprecate BCH msg signing p1/3] Correct async bug * [Cashtab] Patch dependency webpack error for local-ecpair * test: Fix wait_for_debug_log UnicodeDecodeError * index: make indices robust against init aborts * test: bump timeouts for feature_block and feature_abortnode * [Cashtab] Patch address input height in Send.js * test: Fix feature_init intermittent issues * test: Remove random line number feature from feature_init.py * [test] feature_init: prevent UnicodeDecodeError errors when opening log file * test: enable txindex in feature_init * test: feature_init: retain debug.log and improve detection * test: feature_init: tweak all .ldb files of a certain type * test: feature_init: include more interruptions points * eBPF Linux tracepoints * [Cashtab] Temp revert local ecpair * [Cashtab] [ECPair from wif p3/3] Consistent camel case for ECPair * [Cashtab] [ECPair from wif p2/3] Deprecate BCH method * [Cashtab] [ECPair from wif p1/3] Add local method * [Cashtab] [BCH deprecation] [TxBuilder] Pt 8/8 - Deprecate remaining BCH.TransactionBuilder references * [Cashtab] [BCH deprecation] [TxBuilder] Pt 7/8 - Add local TxBuilder to burnToken * [Cashtab] [BCH deprecation] [TxBuilder] Pt 6/8 - Deprecate BCH.TransactionBuilder in sendToken * [Cashtab] [BCH deprecation] [TxBuilder] Pt 5/8 - Add local TxBuilder to sendToken * [Cashtab] [BCH deprecation] [TxBuilder] Pt 4/8 - Deprecate BCH.TransactionBuilder in createToken * [Cashtab] [BCH deprecation] [TxBuilder] Pt 3/8 - Add local TxBuilder to createToken * [Cashtab] [BCH deprecation] [TxBuilder] Pt 2/8 - Deprecate BCH.TransactionBuilder in sendXec * [Cashtab] [BCH deprecation] [TxBuilder] Pt 1/8 - Localize Transaction Building module * Mempool Update Cut-Through Optimization * Replace `struct update_lock_points` with lambda * document and clean up MaybeUpdateMempoolForReorg * [Automated] Update timing.json * [Automated] Update seeds * [Automated] Update chainparams * rpc: add return message to savemempool RPC * test: add stress tests for initialization * test: get and decode tx with a single `gettransaction` RPC call * Replace struct update_fee_delta with lambda * doc: Remove fee delta TODO from txmempool.cpp * [Cashtab] Migrate validateMnemonic from useWallet to validation * [Cashtab] Deprecate address validator artifact * [Cashtab] [BCH Deprecation] [Mnemonic] Pt 7/7 - Unwrap validateMnemonicWordList * [Cashtab] [BCH Deprecation] [Mnemonic] Pt 6/7 - Optimize bip39 bundle via webpack IgnorePlugin * [Cashtab] [BCH Deprecation] [Mnemonic] Pt 5/7 - Deprecate BCH.Mnemonic * [Cashtab] [BCH Deprecation] [Mnemonic] Pt 4/7 - Implement BCH.Mnemonic.validate locally * [Cashtab] [BCH Deprecation] [Mnemonic] Pt 3/7 - Implement BCH.Mnemonic.wordLists locally * [Cashtab] [BCH Deprecation] [Mnemonic] Pt 2/7 - Implement BCH.Mnemonic.generate locally * [Cashtab] [BCH Deprecation] [Mnemonic] Pt 1/7 - Implement BCH.Mnemonic.toSeed locally * style-only: Remove redundant scope in *Chainstate * Remove all #include // for * comments * test/setup: Use LoadChainstate * node/chainstate: Add options for in-memory DBs * node/caches: Remove intermediate variables * node/caches: Extract cache calculation logic * validation: LoadChainstate only needs Consensus::Params * node/chainstate: Decouple from ShutdownRequested * node/chainstate: Decouple from GetTime * init: Delay RPC block notif until warmup finished * log: improve some validation log messages to include hashPrevBlock * Move -checkblocks LogPrintf to AppInitMain * node/chainstate: Reduce coupling of LogPrintf * node/chainstate: Decouple from concept of uiInterface * Split off VerifyLoadedChainstate * node/chainstate: Remove do/while loop * Move init logistics message for BAD_GENESIS_BLOCK to init.cpp * Move mempool nullptr Assert out of LoadChainstate * node/chainstate: Decouple from concept of NodeContext * node/chainstate: Decouple from ArgsManager * Move common package version code to init/common * Move common logging start code to init/common * Move common logging GetArgs code to init/common * Move common logging AddArg code to init/common * Move common sanity check code to init/common * Move common global init code to init/common * [Cashtab] Parse edge case eToken tx * [Cashtab] [Extension] [Code cleanup p5 retry] Update comments and function name for triggerApprovalModal * [Cashtab] [Extension] [Code cleanup p4 retry] Update comments and function name for triggerUi * [Cashtab] [Extension] [Code cleanup p3 retry] Remove commented out testing code from background.js * [Cashtab] [Extension] [Code cleanup p2 retry] Remove unused window variable from background.js * [Cashtab] [Extension] [Code cleanup p1 retry] Remove unused variables from background.js * node/chainstate: Decouple from stringy errors * node/chainstate: Decouple from GetTimeMillis * node: Extract chainstate loading sequence * Remove GetAdjustedTime from init.cpp * test: improve rpc_blockchain.py tests and assert on time and mediantime * bitcoind: Add -daemonwait option to wait for initialization * [Cashtab][Move Msg Switch pt3] Add transition effect to address inputs * [Cashtab][Move msg switch p2] Advanced collapse in Send.js re-titled to Message * [Cashtab][Move msg switch p1] Move multi recipients switch out of the Advanvced Collapse on Send Screen * rpc: Return block time in getblockchaininfo * Bump version to 0.26.7 * test: check rejected future block later accepted * [Cashtab] Improve Sign and Verify collapse labels * [Cashtab] Visual navigation aid added for hamburger menu options * [Cashtab] Request persistent storage * scripted-diff: Remove redundant sync_all and sync_blocks * test: Properly set sync_fun in NodeNetworkLimitedTest * Per-Peer Message Capture * init: Signal-safe instant shutdown * net: ignore block-relay-only peers when skipping DNS seed * test: Replace MiniWallet scan_blocks with rescan_utxos * [Cashtab] Add support for Nigerian Naira * [avalanche] decrease the number of GETAVAADDR spamming iterations and bump the timeout * [avalanche] make the mocktime increase monotonically * test: Implicitly sync after generate*, unless opted out * test: Delete generate* calls from TestNode * scripted-diff: Rename touched member variables * Make blockstorage globals private members of BlockManager * doc: Clarify nPruneAfterHeight * test: Load genesis block to allow flush * Move blockstorage-related unload to BlockManager::Unload * move-only: Create WriteBlockIndexDB helper * Move functions to BlockManager * [validation] de-duplicate package transactions already in mempool * [validation] package accept + mempool submission, require packages to be child-with-unconfirmed-parents * [Automated] Update timing.json * [Automated] Update chainparams * [Automated] Update seeds * [Cashtab] Improve extension build script error handling * remove declaration for unused pcoinsTip * Move BlockManager to node/blockstorage * Move pindexBestInvalid and pindexBestParked to ChainstateManager * Move m_failed_blocks to ChainstateManager * Move AcceptBlockHeader to ChainstateManager * Move FindForkInGlobalIndex from BlockManager to CChainState * [packages/doc] define and document package rules * [Cashtab] chronik server back to abc * [Cashtab] chronik temp switch ------------------------------------------------------------------- Thu Nov 17 18:12:59 UTC 2022 - marec@detebe.org - Update to version 0.26.6: * Add a checkpoint after the Nov. 15th, 2022 upgrade * [Cashtab] [p8 local msg verify] Deprecate legacy verification function * [Cashtab] [p7 local msg verify] Install published dependency * [Cashtab] [p6 local msg verify] Removed unused functions from xecjs-message verify * [Cashtab] [p5 local msg verify] Support for verifying ecash signed msgs in xecjs-message verify * [Cashtab] [p4 local msg verify] Deprecate segwit support from xecjs-message verify * [Cashtab] [p3 local msg verify] Support xec addresses * [Cashtab] [p2 local msg verify] Add stub local method * [Cashtab] [p1 local msg verify] Verify function is not async * [Cashtab] [BCH Deprecation] [HD Node] Pt 3/3 - Deprecate BCH.HDNode * [Cashtab] [BCH Deprecation] [HD Node] Pt 2/3 - Localize downstream logic from new masterHDNode * [Cashtab] [BCH Deprecation] [HD Node] Pt 1/3 - Implement separate masterHDNode creation logic * [Automated] Update timing.json * [packages] add static IsChildWithParents function * [Automated] Update seeds * [Automated] Update chainparams * scripted-diff: Use generate* from TestFramework * [avalanche] Use the generate* functions from test_framework in avatools * test: Add generate* calls to test framework * zmq test: fix sync-up by matching notification to generated block * validation, log: improve logging of ChainstateManager snapshot persistance * log: improve checkaddrman logging with duration in milliseconds * Remove CTxMemPool params from ATMP * [avalanche] Give peer discovery functional test class a unique name * [avalanche] Fix typo in test comments * test: check abandoned tx in listsinceblock * cover DisconnectBlock with lock annotation * Remove GetSpendHeight * MOVEONLY: update_lock_points to txmempool.h * change TestLockPointValidity to take a const reference * move check_final_and_mature lambda from CTxMemPool::removeForReorg to DisconnectedBlockTransactions::updateMempoolForReorg * [mempool] always assert coin spent and do it only once in a row * [refactor] put finality and maturity checking into a lambda * remove unnecessary casts, use braced initialization and add an assertion * TestLockPointValidity to txmempool * add missing lock assertion to removeForReorg * p2p: Rename fBlocksOnly, Add test * test: use MiniWallet for p2p_blocksonly.py * test: Run feature_cltv with MiniWallet * test: run mempool_reorg.py even with wallet disabled * [Automated] Update timing.json * [Automated] Update seeds * [Automated] Update chainparams * Fix rpc_blockchain flakiness * Improve the getblock test in rpc_blockchain * test: Speed up mempool_spend_coinbase.py * test: Speed up rpc_blockchain.py by removing miniwallet.generate() * [Cashtab] Patched vertical alignment of NavItems in hamburger menu * [Cashtab][Pt 4/4] Move message signing and verification to new screen - Create snapshot test * [Cashtab][Pt 3/4] Move message signing and verification to new screen - create new SignVerifyMsg component * [Cashtab][Pt 2/4] Move message signing and verification to new screen - Remove Verification & Signing from Send.js * [Cashtab][Pt 1/4] Move message signing and verification to new screen - Create icon & NavItem * rpc: calculate fees in getblock using BlockUndo data * Bump version to 0.26.6 * Make TxToUniv take a BlockHash instead of a raw uint256 * test: run mempool_resurrect.py even with wallet disabled * test: run mempool_expiry.py even with wallet disabled * [Cashtab] Token balance should show full decimals ------------------------------------------------------------------- Tue Nov 08 18:00:29 UTC 2022 - marec@detebe.org - Update to version 0.26.5: * Bump version to 0.26.5 * Crash debug builds when mempool ConsensusScriptChecks fails * doc: Tidy up nMinDiskSpace comment * [Automated] Update timing.json * [Automated] Update seeds * [Automated] Update chainparams * [Cashtab] [BCH deprecation] Pt 1/2 - Implement local generateBurnOpReturn function * [Cashtab] [BCH deprecation] Pt 2/2 - Deprecate BCH.SLP.TokenType1.generateSendOpReturn * [Cashtab] Remove testnet instantiations and unit tests * [Cashtab] Disabled scroll wheel within input fields * [Automated] Update timing.json * [Automated] Update seeds * [Automated] Update chainparams * [Cashtab] Remove all unused imports in chronik.test.js * [Cashtab] [Chronik] Upgrade OP_RETURN messaging size * [Cashtab] [BCH deprecation] Pt 2/2 - Deprecate BCH.SLP.TokenType1.generateGenesisOpReturn * [Cashtab] Removed isGenesisTx console.log from chronik.js * [Cashtab] [BCH deprecation] Pt 2/2 - Deprecate BCH.Address.isCashAddress from cashMethods * [Cashtab] [BCH deprecation] Pt 1/1 - Deprecate BCH.Address.toCashAddress from cashMethods * [Cashtab] Expand mintAddress hash160 extraction unit tests to include BUX self mint txs * [Cashtab] [BCH deprecation] Pt 2/2 - Deprecate BCH.Address.toHash160 * [Cashtab] [BCH deprecation] Pt 1/2 - Implement local toHash160 logic * [Cashtab] Patch balance toggle initializing hidden * [Cashtab] Added toggle hide balance switch * [avalanche] Add compile and runtime assertions that cs_main is not held for some avalanche Processor functions * [cashtab-components] Updating readme * [Cashtab] Improvements to token blacklist * [Cashtab] Lessen spacing between from and contactName in Tx.js * [Cashtab] [extension address passing p12] Version bump for extension and cashtab-components * [[Cashtab] [extension address passing p11]Remove debug logging * [Cashtab] [extension address passing p10] Add a prompt for the user to approve or deny the address request * [Cashtab] [extension address passing p9] Display the received address in the GetAddress.tsx component * [Cashtab] [extension address passing p8] Add listener function to contentscript.js and GetAddress.tsx * [Cashtab] [extension address passing p7] Actually fetch the address from storage in the background.js function * [Cashtab] [extension address passing p6] Extension runs an address fetch function when requested to do so * [Cashtab] [extension address passing p5] Add detection of Cashtab installation to GetAddress.tsx * [Cashtab] [extension address passing p4] Create GetAddress.tsx stub with stories * [Cashtab] [extension address passing p3] Add storage permissions to extension and add address to extension storage * [Cashtab] [extension address passing p2] Get wallet address in ecash: format from extension version of App.js * [Cashtab] [extension address passing p1] Move getCashtabProviderStatus function out of CashtabBase * [Cashtab] Add blacklist for token name and token ticker fields * [Cashtab] [airdrop chronik for mint address p2/2] Deprecate bch-api for getting minting address * [Cashtab] [airdrop chronik for mint address p1] Get minting address with chronik and compare to bch-api result * [Cashtab] [p3 remove BCH.getByteCount] Move calcFee to cashMethods * [Cashtab] [p2 remove BCH.getByteCount] Replace BCH.getByteCount in calcFee * [Cashtab] [p1 remove BCH.getByteCount] Create an equivalent function with unit tests * Upgrade bitcoin-abc-dev to debian bullseye * [Automated] Update timing.json * [Automated] Update seeds * [Automated] Update chainparams * [Cashtab][Pt 2/2] Parse Airdrops in TxHistory - using cashtabCache to get airdrop token name * [Cashtab][Pt1/2] Parse Airdrops in TxHistory * [Cashtab] Rename WalletInfo Component in Receive.js * [avalanche] Fix a data race where updating availability scores can coincide with initialization of state * test: a test to check descendant limits * [Cashtab] Fix formatting issue for Cashtab msgs containing long strings * [Cashtab] [Chronik] [Tx Gen] Token transaction refactor - part 1 createToken * [Cashtab Extension] fixed roaming nav menu when extension popped out * [avalanche] Record peers that have avalanche enabled * test: avoid non-determinism in asmap-addrman test * [test] call CheckPackage for package sanitization checks * MOVEONLY: move package unit tests to their own file * MOVEONLY: mempool checks to their own functions * clean up MemPoolAccept aliases * document workspace members * [validation/rpc] cache + use vsize calculated in PreChecks * validation: have LoadBlockIndex account for snapshot use ------------------------------------------------------------------- Sat Oct 22 13:36:35 UTC 2022 - marec@detebe.org - Update to version 0.26.4: * addrman: Log too low compat value * p2p: Avoid InitError when downgrading peers.dat * [doc] Add a release note about the removal of the default port preference for outbound connections * [Cashtab] Remove unused imports useBCH.test.js * Deduplicate call to PreChecks in AcceptSingleTransaction * [validation/refactor] store precomputed txdata in workspace * [validation] case-based constructors for ATMPArgs * net: open p2p connections to nodes that listen on non-default ports * Make AddrMan support multiple ports per IP * Make CAddrman::Select_ select buckets, not positions, first * log: improve addrman logging * scripted-diff: Rename CAddrInfo to AddrInfo * scripted-diff: Rename CAddrMan to AddrMan * [includes] Fix up included files * [doc] Update comments * [refactor] Update GetAddr_() function signature * [move-only] Move constants to test-only header * [addrman] Change CAddrInfo access * [move-only] Move CAddrInfo to test-only header file * [net, addrman] Remove external dependencies on CAddrInfo objects * [addrman] Introduce CAddrMan::Impl to encapsulate addrman implementation. * [move-only] Match ordering of CAddrMan declarations and definitions * [move-only] Move CAddrMan function definitions to cpp * Make CAddrMan nKey private * net: don't bind on 0.0.0.0 if binds are restricted to Tor * [avalanche] Cleanup old usage of legacyavaproof in functional test framework * test: add addpeeraddress "tried", test addrman checks on restart with asmap * rpc, test: addpeeraddress test coverage, code simplify/constness * [Automated] Update timing.json * [Automated] Update seeds * [Automated] Update chainparams * test: Remove option to make TestChain100Setup non-deterministic * test: Use compressed keys in TestChain100Setup * addrman: Avoid crash on corrupt data, Force Check after deserialize * test: Add addrman deserialization error tests * Raise InitError when peers.dat is invalid or corrupted * Remove confusing CAddrDB * [addrman] Move peers.dat parsing to init.cpp * validation: don't modify genesis during snapshot load * doc: Various validation doc fixups * validation: fix CheckBlockIndex for multiple chainstates * chain: add and set ASSUMED_VALID_FLAG for assumeutxo * validation: change UpdateTip for multiple chainstates * validation: add chainman ref to CChainState * log: Clarify log message when file does not exist * refactor: move update_* structs from txmempool.h to .cpp file * [Cashtab] [Chronik] Upgrade private message decryption error handling * [Cashtab] Deprecate API wrapper - signPkMessage * [Cashtab] [Chronik] [Tx Gen] generateTokenTxOutput - part 1 token genesis tx * addrman: Fix format string in deserialize error * [addrman] Make m_asmap private * [addrman] Set m_asmap in CAddrMan initializer list * [net] Remove CConnMan::SetAsmap() * [init] Read/decode asmap before constructing addrman * [avalanche] Separate pubkey from AvalancheState * simplify ValidDeployment check to avoid gcc warning * [Cashtab] Tx History should immediately update to include newly added contacts * [refactor] [addrman] Update constant comments * [move-only] Extract constants from addrman .h to .cpp * [addrman] Change addrman #define constants to be constexprs * [addrman] Move CAddrMan::Unserialize to cpp file * [addrman] Move CAddrMan::Serialize to cpp file * addrman: detect on-disk corrupted nNew and nTried during unserialization * [addrman] Merge the two Add() functions * [MOVEONLY] [tests] Move addrman ser/deser tests to addrman_tests.cpp * test: refactor: separate CreateBlock in TestChain100Setup * test: move CreateAndActivateUTXOSnapshot into test/util/chainstate.h * refactor: remove unused assumeutxo methods * p2p: log addrman consistency checks * [addrman] Make addrman consistency checks a runtime option * [tests] Make deterministic addrman use nKey = 1 * Add missing const to CAddrMan::Check_() * validation: don't try to invalidate genesis block * Make addrman random context private * refactor: Mark CAddrMan::Select and GetAddr const * Remove txindex migration code * Move pblocktree global to BlockManager * refactor: move GetTransaction(...) to node/transaction.cpp * Move LoadBlockIndexDB to BlockManager * addrman: Fix new table bucketing during unserialization * log: Remove unnecessary timing logs for Callbacks bench * refactor: Make CAddrMan::cs non-recursive * move-only: Group and re-order CAddrMan members by access type * refactor: Do not expose CAddrMan members as protected without need * addrman: improve performance by using more suitable containers * [net] remove fUpdateConnectionTime from FinalizeNode * [net] remove CConnman::AddNewAddresses * [net] remove CConnman::MarkAddressGood * [net] remove CConnman::SetServices * [net_processing] Keep addrman reference in PeerManager * [net] Construct addrman outside connman * Remove AcceptToMemoryPoolWithTime * [validation] Always call mempool.check() after processing a new transaction * [validation] Add CChainStateManager::ProcessTransaction() and use it outside validation * [logging/documentation] Remove reference to AcceptToMemoryPool from error string * [validation] Remove comment about AcceptToMemoryPool() * [test] Don't set bypass_limits to true in txvalidation[cache]_tests.cpp * wallet: Reorder locks in dumpwallet to avoid lock order assertion * [Cashtab] Extension version bump 1.1.2 * [Cashtab] [Chronik] [Tx Gen] generateTokenTxInputs part 2 - SEND/BURN tokenAction * [refactor] Move ComputeBlockVersion into VersionBitsCache * [refactor] versionbits: make VersionBitsCache a full class * deploymentinfo: Add DeploymentName() * Fix the chronikbridge test * [move-only] Rename versionbitsinfo to deploymentinfo * scripted-diff: rename versionbitscache * [refactor] Add versionbits deployments to deploymentstatus.h * [refactor] Add deploymentstatus.h * versionbits: Use dedicated lock instead of cs_main * versionbits: correct doxygen comments * refactor: move UpdateTip into CChainState * refactor: no mempool arg to GetCoinsCacheSizeState * validation: make CChainState::m_mempool optional * [Automated] Update timing.json * [Automated] Update seeds * [Automated] Update chainparams * Replace RecursiveMutex m_cs_chainstate with Mutex, and rename it * Increase timeout in wallet_multiwallet * test: add tests for bad-txns-prevout-null reject reason * [avalanche] Fix tests flakiness with manual connections * test: Bump timeouts to avoid valgrind failures * [GetTransaction] remove unneeded `cs_main` lock acquire * [Cashtab] [pub key fetch from chronik p2] Deprecate bch-api * [Cashtab] [pub key fetch from chronik p1] Get recipient public key from chronik instead of bch-api * [Cashtab] [Chronik] Airdrop block height retrieval * prefer to use txindex if available for GetTransaction * Add LIFETIMEBOUND attributes where needed * Small fix to the node broadcast logic * Move RelayProof to PeerManager * [net processing] Move RelayTransaction into PeerManager * p2p: Limit m_block_inv_mutex * Bump version to 0.26.4 * refactor: Remove chainparams arg from CChainState member functions * refactor: Remove ::Params() global from inside CChainState member functions * [avalanche] Avoid connecting via addavalanchenode in tests * [linter] Fix css code style issues * Fix localhost typo in addresses directed at addnode rpc * Refactor ProcessNewBlock calls to reduce code duplication and take a CBlock reference ------------------------------------------------------------------- Sat Oct 15 07:54:02 UTC 2022 - marec@detebe.org - Update to version 0.26.3: * [Automated] Update timing.json * [Automated] Update chainparams * [Automated] Update seeds * [linter] Bump clang-format to version 12 * Remove -feefilter option, factor its logic out and relase cs_main * p2p: Don't send FEEFILTER in blocksonly mode * Reject invalid coin height and output index when loading assumeutxo * consensus: move amount.h into consensus * [avalanche] Cleanup the proof voting test * [refactor] pass coinsview and height to check() * [mempool] simplify some check() logic * [validation/mempool] use Spend/AddCoin instead of UpdateCoins * MOVEONLY: remove single-use helper func CheckInputsAndUpdateCoins * [mempool] use coins cache and iterate in topo order in check() * [bench] Benchmark CTxMemPool::check() * [mempool] check ancestor/descendant limits for packages * [Cashtab] Equal airdrop distribution ratio option * test: Remove intermittently failing and not very meaningful `BOOST_CHECK` in `cnetaddr_basic` * Fix BlockAssembler::AddToBlock logging * Use C++11 member initializer in CTxMemPoolEntry * [Cashtab] Fix reply button not showing * [Cashtab] [chronik tx history p22] remove debug logging * [Cashtab] [chronik tx history p21] Better token burn parsing * [Cashtab] [chronik tx history p20] update token info cache in tx history routine * [Cashtab] [chronik tx history p19] remove legacy object from tx parsing * [Cashtab] [chronik tx history p18] remove legacy tokenTx param * [Cashtab] [chronik tx history p17] Remove legacy outgoingTx param * [Cashtab] [chronik tx history p16]Remove legacy amountSent and amountReceived * [Cashtab] [chronik tx history p15] parsing token burn txs * [Cashtab] [chronik tx history p14]Remove legacy tx parsing functions, tests, and mocks * [Cashtab] [chronik tx history p13] add unit tests for airdrop and encrypted msgs * [Cashtab] [chronik tx history p12] Render tx history from chronik * [Cashtab] [chronik tx history p11] Update incoming tx notifications parsing to use new function * [Cashtab] [chronik tx history p10] Parse etokenAmount for token decimals * [Cashtab] [chronik tx history p9] Correctly calculate etoken amount for genesis txs * [Cashtab] [chronik tx history p8] Add replyAddress to legacy object * [Cashtab] [chronik tx history p7] duplicate most legacy tx data * [Cashtab] [chronik tx history p6] Detect OP_RETURN msgs and run through existing parse function * [Cashtab] [chronik tx history p5] get reply hash160 * [Cashtab] [chronik tx history p4] move parseChronikTx from cashMethods to chronik * [Cashtab] [chronik tx history p3] Add a function to sort chronik tx history of all addresses by blockheight and timeFirstSeen * [Cashtab] [chronik tx history p2] Add a function to combine chronik tx history for all addresses into a single array * [Cashtab] [chronik tx history p1] Get the last 10 txs of all addresses in the wallet * MOVEONLY: add helper function for calculating ancestors and checking limits * extract/rename helper functions from rpc_packages.py * misc package validation doc improvements * [Cashtab] Patch issue with burn all of a token locking UI * Increase max ipv4 seeds per ASN * Improve clarity of makeseeds and increase max ipv6 ASNs * [test framework] simplify bytes to hex encoding * test: Replace getmempoolentry with testmempoolaccept in MiniWallet * RPC: Add ancestor{count,size,fees} to listunspent output * Add generic SaltedSipHasher * MOVEONLY: context-free package policies * Remove suspicious hosts list from makeseeds * Add .gitignore for dns seeds * Move Hashers to util/hasher.{cpp/h} * [refactor] comment/naming improvements * [policy] detect unsorted packages * [test] functional test for packages in RPCs * [rpc] allow multiple txns in testmempoolaccept * [policy] limit package sizes * [validation] package validation for test accepts * [policy] Define packages * Refactor & improve makeseeds * [util] Introduce a SetMockTime that takes chrono time * [util] Change GetMockTime to return chrono type instead of int * [test] Throw error instead of segfaulting in failure scenario * test: Remove spurious double lock tsan suppressions by bumping to clang-12 * Close minor startup race between main and scheduler threads * [Cashtab] Patched nav menu being cut off on some mobile views * [CI] Install the required windows test executables * [CI] Properly set the alternative gcc/g++ for arm/aarch64 * [CI] Unbreak the windows cross builds * [CI] Install the gcc/g++ multilib package for building on 32 bits * [Chronik] Add minimal `ChronikIndexer`, to sort bitcoind's blocks and txs into Chronik's db * Prepare for using debian 11 for the regular builds * Migrate gitian builds to Debian Bullseye * [validation] explicit Success/Failure ctors for MempoolAcceptResult * [validation] make CheckSequenceLocks context-free * gui: Add NAT-PMP network option * net: Add -natpmp command line option * net: Add NAT-PMP to port mapping loop * net: Add libnatpmp support * [Chronik] Add `ChronikBridge` to access the node from Rust * Switch scheduler to steady_clock * QA: Run tests with UPnP disabled * [qa] Avoid printing to console during cache creation * doc: Convert depends options list from html to markdown * [Automated] Update timing.json * [Automated] Update seeds * [Automated] Update chainparams * [avalanche] Add immature_stake_amount to getavalancheinfo * [avalanche] Make ProofPool's for each proof logic public * [Cashtab] Patch font color for One To Many Airdrop Payment Outputs input * [avalanche] Cleanup redundant proof count getters in PeerManager API * [avalanche] Cleanup redundant argument in getavalancheinfo test * [avalanche] Add getavalancheproofs RPC to retrieve tracked proof ids * [CMAKE] fix a typo in FindMiniUPnPC * [Cashtab] Match hover effect for all icons on settings page * [Cashtab] Add hamburger menu to taskbar * [avalanche] Fix a abc_feature_proof_cleanup potential failure * [avalanche] Clarify the abc_p2p_compactproofs test * Build the release package for Ubuntu 22.04 Jammy * gui: Apply port mapping changes on dialog exit * scripted-diff: Rename UPnP stuff * net: Add flags for port mapping protocols * net: Keep trying to use UPnP when -upnp=1 * refactor: Replace magic number with named constant * refactor: Move port mapping code to its own module * log, sync: add LOCK logging category, apply it to lock contention * test: Fix intermittent issue in p2p_feefilter * Fix mismatching types for setDirtyBlockIndex * [Cashtab] fix antd error in console when user clicks Create eToken * [Cashtab] fix antd syntax issue * refactor: Cleanup thread ctor calls * [Cashtab] Comments in loadContactList should refer to contactList, not settings * rpc: Return total fee in mempool * Bump version to 0.26.3 * [Cashtab] currency.prefixes & currency.tokenPrefixes converted to strings * [avalanche] Improve const correctness of ProofPool::countProofs() * [Chronik] Rename `setup_bridge` to `setup_chronik` * Run with wellington activated in the tests * Replace Gluon activation time with the actual block height * [Cashtab] Deprecate handleEncryptedOpReturn * [Cashtab] Move token burn UI lock to same as other token tx method * [Cashtab] [Chronik] [Tx Gen] SendXec() refactor * [Cashtab] [Chronik] getTokenStats refactor * [Chronik] Add `Chronik`, connect it to `CValidationInterface` ------------------------------------------------------------------- Fri Sep 23 16:38:27 UTC 2022 - marec@detebe.org - Update to version 0.26.2: * add a release note for debug log changes * logging: move checkpoint log into VALIDATION debug category * validation: put coins cache write log into bench debug log * blockstorage: use debug log category * log: sort logging categories alphabetically * log: Move block file log messages to debug category * validation: move header validation error logging to VALIDATION debug category * validation: include block hash when reporting prev block not found errors * move-only: Move constants and functions to blockstorage * refactor: Move block storage globals to blockstorage * refactor: Move pruning/reindex/importing globals to blockstorage * [Cashtab] [service worker fix p3] Add modal to load latest version on app update * [Cashtab] [service worker fix p2] install create react app default service worker * [Cashtab] [service worker fix p1] remove cache-first service worker * [Cashtab] Force API switch if full node is offline * [avalanche] Add a BlockFinalized callback to the validation interface * [avalanche] Create a type alias for proof id sets * [Chronik] Add `log!` and `log_chronik!` macros * [avalanche] Fix an abc_p2p_proof_inventory flakiness * p2p: Put disconnecting logs into BCLog::NET category * [Automated] Update timing.json * [Automated] Update seeds * [Automated] Update chainparams * Fix an occasional failure in abc_p2p_fullblocktest * [Chronik] Add `Eq` derives for `BlocksError` and `SerError` * [Chronik] Upgrade rocksdb dependency to 0.19 * [avalanche] Fix abc_p2p_compactproofs flakiness * [avalanche] Increase mock time delay for addr responses in abc_p2p_getavaaddr * [Chronik] Refactor bridge: Split into `chronik-bridge` and `chronik-lib` * [Cashtab] Remove console.log statement * [Cashtab] [p4 upgrading deps] upgrade minimal-slp-wallet * [Cashtab] [p3 upgrading deps] upgrading @svgr/webpack * [Cashtab] [p2 upgrading dependencies] Upgrading etoken-list * [Cashtab] Running npm upgrade * [cashtab-components] upgrading jest * [cashtab-components] Running npm upgrade * [Cashtab-components] Upgrade to webpack 5 * [avalanche] Let isfinaltransaction raise an error when the transaction is not found * [Cashtab + docs] Bump node version * fs: consistently use fsbridge:: for ifstream / ofstream * GUI: Write PSBTs to file with binary mode * [avalanche] Add a way to retrieve all proof ids in a proofpool * [Cashtab] [chronik utxo handling p15] Remove debug logging statements used in testing for earlier diffs in this stack * [Cashtab] [chronik utxo handling p14] Force update to chronik format of utxo storage before wallet can be used * [Cashtab] [chronik utxo handling p13] Unlock SendToken screen only after utxo set is updated * [Cashtab] [chronik utxo handling p12] etoken send txs with chronik formatted utxos * [Cashtab] [chronik utxo handling p11] chronik token burns * [Cashtab] [chronik utxo handling p10] chronik token minting * [Cashtab] [chronik utxo handling p9] Update sendXec functions for new utxo storage format * [Cashtab] [chronik utxo handling p8] Remove obsolete bch-api functions, unit tests, and mocks * [Cashtab] [chronik utxo handling p7] Drop bch-api utxo storage and replace with chronik * [Cashtab] [chronik utxo handling p6] Cache token info in local storage * [Cashtab] [chronik utxo handling p5] Add support for caching token info to limit chronik API calls to unseen tokens * [Cashtab] [chronik utxo handling p4] Collect and apply required token metadata * [Cashtab] [chronik utxo handling p3] Add a function to create a preliminary `tokens` wallet state object, before getting token info * [Cashtab] [chronik utxo handling p2] Add a function to split utxos by slp, nonSlp to match current storage model * [Cashtab] [chronik utxo handling p1] Add chronik utxo fetch functionality * [Docs] Upgrade dependencies * Cleanup the deprecated RPC fields * Bump version to 0.26.2 ------------------------------------------------------------------- Fri Sep 16 15:04:26 UTC 2022 - marec@detebe.org - Update to version 0.26.1: * [avalanche] Add a RPC to check if a block/tx is finalized by avalanche * [avalanche] Make sure we remember the avalanche addresses we sent * Bump version to 0.26.1 * [Cashtab] Switch primary bch-api server * [Automated] Update timing.json * [Automated] Update seeds * [Automated] Update chainparams * convert unsafe fs::path std::string conversion call * Replace fs::absolute calls with AbsPathJoin calls * test: Clear forced -walletdir setting after wallet init_tests * Introduce GetUniquePath(base) helper method to replace boost::filesystem::unique_path() which is not available in std::filesystem. * [avalanche] Rename proof filter to match rest of the code base ------------------------------------------------------------------- Wed Sep 14 16:28:55 UTC 2022 - marec@detebe.org - Update to version 0.26.0: * [avalanche] Add a release note for the avalanche support * [Cashtab] Replace direct svg imports with CustomIcons imports * [Automated] Update timing.json * [Automated] Update chainparams * Remove `GetDataDir(bool fNetSpecific = true)` function * scripted-diff: Replace GetDataDir() calls with `gArgs.GetDataDirNet()` calls * Make ArgsManager.GetDataDirPath private and drop needless suffix * scripted-diff: Change ArgsManager.GetDataDirPath() to `ArgsManager.GetDataDirBase()` in tests * Add `ArgsManager.GetDataDirBase()` and `ArgsManager.GetDataDirNet()` as an intended replacement for `ArgsManager.GetDataDirPath(net_identifier)` * Make `m_cached_blocks_path` mutable. Make `ArgsManager::GetBlocksDirPath()` const. * [avalanche] Don't show the -avasessionkey option in the help * [Automated] Update seeds * [linter] fix check-doc * Rename overloaded int GetArg to GetIntArg * Fix (inverse) meaning of -persistmempool * [avalanche] Cleanup comment referring to legacy proofs * [avalanche] Deduplicate the log message when an avapoll is received * [avalanche] Fix potential wrong error message in the sendavalancheproof RPC * Bump version to 0.26.0 * [linter] Always assign a path to arcanist linter messages * [avalanche] remove proofid from StakeCommitment ctor * [avalanche] remove StakeSigner class * [avalanche] Fix proof_tests potential failure * [avalanche] Fix abc_rpc_avalancheproof on slow machines * [automation] Manually add some nodes to the seeds * [avalanche] Show the avalanche options in the help * [avalanche] Deprecate the -enableavalanche flag * [avalanche] Deprecate the legacy proof format * [avalanche] Deprecate the -enableavalancheproofreplacement flag * [Automated] Update timing.json * [Automated] Update chainparams * [avalanche] Make the payout script mandatory in the proof builder * [avalanche] Use sane default for the minimum number of nodes that sent compact proofs * [avalanche] Use sane default for the quorum minimum connected stake ratio * [avalanche] Set the quorum minimal stake to a sane default * [avalanche] Deprecate the enablepeerdiscovery flag * [Cashtab] Use correct type for comparison to dustSats * [Cashtab] [p4] send token fee issue * [Cashtab] [p3] Patch fee falc in sendToken * [Cashtab] [p2] Patch fee falc in sendToken * [Cashtab] [p1] Patch fee falc in sendToken * [test] convert amount to XEC * [Cashtab] [p1 match wif to address] Align sendXec()s XEC utxo signing approach * [linter] Make flake8 version >= 5 happy * [Chronik] Add short README + logo * [linter] Move the clang format config file to the root so it applies to chronik cpp as well * [Cashtab] Patch edit svg size FF * Bump replay protection to may 15th 2023 * [avalanche] Fix a race in the processor tests * [Cashtab] Add ability to rename active wallet * [Chronik] Add minimal Rust <-> C++ bridge * [Chronik] Fix `CARGO_BUILD_DIR`, incorrectly based on CMAKE_CURRENT_BINARY_DIR instead of CMAKE_BINARY_DIR * [Cashtab] Only test staged files * Update makeseeds.py for 0.26.x * [Automated] Update timing.json * [Automated] Update seeds * [Automated] Update chainparams * [Cashtab-components] Running npm upgrade * [Cashtab-components] Upgrade storybook by running npx sb upgrade * [Cashtab] Upgrading dependencies * [Cashtab Docs] Running npm upgrade * [Cashtab] Patch overflow from error string in send one to many input * [Cashtab] Fix OpReturnMsg overflow ------------------------------------------------------------------- Thu Sep 01 15:57:01 UTC 2022 - marec@detebe.org - Update to version 0.25.13: * [Automated] Update timing.json * [Automated] Update chainparams * Bump version to 0.25.13 * test: speedup wallet tests by whitelisting peers (immediate tx relay) * Center loading icon * [Cashtab] Hide amount in error msg if it is undefined DestinationAddressMulti * [Cashtab] Cleanup interval from 30s to 5s * [avalanche] Add log message when dangling proofs get dropped * [avalanche] Reuse code to fetch the processor's local proof during proof cleanup * test: test availability of ports before assigning them * [Automated] Update timing.json * [Automated] Update chainparams * [Cashtab] Patch typo in ScanQRCode * [Cashtab] Convert `balance` to string throughout app * [Cashtab] Match return type in unit conversion functions * [Cashtab] Patch selectedCurrency ticker reading as XEC in send confirmation modal * [avalanche] Implement proof expiration time * [Cashtab] Hide msgs from unknown senders option * [Cashtab] [p2 rename smallestDenomination] Rename toSmallestDenomination to fromXecToSatoshis * [Cashtab] [p1 rename smallestDenomination] Rename fromSmallestDenomination to fromSatoshisToXec ------------------------------------------------------------------- Sat Aug 20 16:38:40 UTC 2022 - marec@detebe.org - Update to version 0.25.12: * [Automated] Update timing.json * [Automated] Update chainparams * [avalanche] Do same checks on local proof as peer proofs in getavalancheinfo functional test * [avalanche] Fix flakiness where finalization of the newly mature proof was not checked along with the other finalized proofs * [avalanche] Poll for our local proof * [avalanche] Complete renaming from orphan to immature where applicable * [avalanche] Rename the orphan pool to immature pool * [avalanche] Rename the orphan API accessors to immature * [avalanche] Make sure AlreadyHaveProof always returns true for the local proof * [avalanche] Update the getrawavalancheproof RPC to return 'immature' instead of 'orphan' * [test framework] Add a facility to format an uint256 in hex * [Cashtab] Patch mnemonic input color OnBoarding.js * [Chronik] Install Rust platform targets required for CI * [Automated] Update timing.json * [Automated] Update chainparams * [Cashtab] Remove tooltip from mnemonic inputs * [avalanche] Increase proof dust threshold * [avalanche] Make proof dust threshold configurable * [Cashtab] Update block explorer to explorer.e.cash * [Cashtab] Validation function for new wallet name length * [avalanche] Improve the getavalancheinfo RPC * Bump version to 0.25.12 * [Chronik] Add minimal `chronik::Start` and `chronik::Stop` to init.cpp * [Chronik] Add /chronik to existing lints * [avalanche] Don't poll blocks who are ancestors of a vote finalized block * [avalanche] Fix comment related to proof requests * [Cashtab] [p6 and final of normalizeBalance improvements] Remove double definition of this function in useWallet * [Cashtab] [p5 normalizeBalance fix] Improve name of normalizeBalance function * [Cashtab] [p4 normalizeBalance fix] Change function input to nonSlpUtxos * [Cashtab] [p3 normalizeBalance fix] Add unit tests * [Cashtab] [p2 normalizeBalance fix] Remove unused import from cashMethods.test.js * [Cashtab] [p1 normalizeBalance fix] Remove extra spaces from cashMethods.test.js * [avalanche] Bump the peer replacement cooldown * [avalanche] Hide the master and session keys in the debug log and console * [Automated] Update timing.json * [Automated] Update chainparams * Revert "[avalanche] Ban peers that send conflicting proofs repeatidly" * [Cashtab] Remove color change of address on hover in contact list * [avalanche] Fix getavaaddr on OSX * [avalanche] Remove the network bypass flag, make it default for avalanche outbounds * Fix a race in the net tests * [avalanche] Fix abc_p2p_getavaaddr flakiness * Add unit test for the outbound connection logic * Add a method to make addrman deterministic * [Cashtab] Remove classNames from Tx.js * [Automated] Update timing.json * [Automated] Update chainparams * [avalanche] Bump stake used in proof deserialization tests * [avalanche] Add coins directly instead of using coinbases in processor unit tests * [avalanche] Use MIN_VALID_PROOF_SCORE where appropriate ------------------------------------------------------------------- Fri Aug 05 14:06:23 UTC 2022 - marec@detebe.org - Update to version 0.25.11: * [Automated] Update timing.json * [Automated] Update chainparams * Bump version to 0.25.11 * [avalanche] Don't download proofs during IBD * [avalanche] Don't ban a peer sending a proof with an unknown utxo * [avalanche] Request more peers for their avalanche nodes * [avalanche] Fix flaky loops in abc_p2p_compactproofs * [avalanche] Fix flaky check for finalized proofs in abc_rpc_getavalancheinfo * [cashtab-components] Replace SLPA references with eToken * [avalanche] Simplify the wait_for_proof test facility * [cashtab-components] Remove all references to BCHA and replace with XEC * [linter] Sanitize the headers include guard * [Automated] Update timing.json * [Automated] Update chainparams * [avalanche] Return all the status in getrawavalancheproof RPC * [avalanche] Fix flakiness in the stale vote functional test * [Chronik] Add `ENABLE_CHRONIK` #define macro * [avalanche] Verify that polling has started on an item before verifying that it has stopped * [Cashtab] Hide QR popup setting * [Chronik] Set Chronik C++ standard to C++17 * [Cashtab] Hide spinner in Send.js Amount input on Firefox * [avalanche] Account for the avalanche outbound when checking for outbound eviction * [avalanche] Add a way to pass avalanche config values around * [avalanche] Request more node addresses upon receipt of a dangling proof * [avalanche] Don't consider our quorum valid if we don't have enough nodes connected * [Chronik] Add `BlockReader` to read blocks from `Db` * [Chronik] Refactor serialization, add `db_serialize` and `db_deserialize`. * doc/style followups in MempoolAcceptResult * [Chronik] Use lint! macro in chronik-db * [Chronik] Add `BlockWriter`, storing block data in RocksDB using postcard * [Chronik] Add `abc-rust-error` crate for convenient error handling * [Chronik] Refactor Rust crates and CMake targets * [avalanche] Fix occasional invalid node count in getavalancheinfo * Avoid UBSan warning in ProcessMessage(...) and disallow negative mocktime * Simplify GetTime * util: Use std::chrono for time getters * time: add runtime sanity check * [Chronik] Add lint macro to prevent having to repeat common lints in every crate * [refactor] improve style for touched code * [refactor] const ATMPArgs and non-const Workspace * [refactor] return MempoolAcceptResult * [refactor] clean up logic in testmempoolaccept * [build] Fix doxygen documentation issues and enable -Wdocumentation * [avalanche] Fix a race condition in a unit test where proof registration time could be off by one * Remove obsolete --runbarelyexpensive parameter * Remove dead code in abc_p2p_fullblocktests * [avalanche] Add the dangling proofs count to the getavalancheinfo RPC * validation: Guard all chainstates with cs_main * validation: remove redundant check on pindex * locks and docs in ATMP and CheckInputsFromMempoolAndCache * [cmake] Double the functional test timeout when a sanitizer is enabled * Fix tsan suppression with Clang 14 * [Cashtab] Mock getRawTransaction API calls in unit tests * [Automated] Update timing.json * [Automated] Update seeds * [Automated] Update chainparams ------------------------------------------------------------------- Fri Aug 05 14:05:37 UTC 2022 - marec@detebe.org - Update to version 0.25.10: * [Automated] Update timing.json * [Automated] Update chainparams * [Automated] Update seeds * [mempool] Remove unnecessary try-block * only load unbroadcast tx if it exists in loaded mempool * Revert "[Cashtab] Route to onboarding if no wallet present" * [avalanche] Request more avalanche peers if we have dangling proofs * Bump version to 0.25.10 * [Cashtab] Add parseInvalidSettingsForMigration function * [avalanche][trivial] Fix bad wording in log * Add linter to ensure chrono::duration is always initialized * [avalanche] Fix conflict time initializer to zero * [avalanche] Improve RPC fields names and description in getavalanchepeerinfo * [avalanche] Add count of finalized proofs to getavalancheinfo * [avalanche] Fix an log error during proof rejection * [avalanche] Print the proofid in getavalancheoeerinfo * Fix outdated comments referring to ::ChainActive() * validation: Farewell, global Chainstate! * qt/test: Reset chainman in ~ChainstateManager instead * make FindBlockToFinalize a CChainState member * refactor: Replace uses ChainActive() in interfaces/chain.cpp (follow-up) * [avalanche] Fix the inboud requesting functional test * [avalanche] Request addresses and proofs from our inbounds while the quorum is not established * [avalanche] Don't rely on the service bit for sending the avalanche message * use m_chain in CChainState::UpdateFlagsForBlock and CChainState::FinalizeBlock * pass active_chainstate to buildRandomProof * [avalanche] pass chainman to Proof::verify * [avalanche] Fix typo in dust threshold validation result type * [avalanche] Use proof dust threshold in unit tests instead of low coin amounts * [avalanche] Don't consider our local proof as dangling * [Automated] Update chainparams * [avalanche] Ban peers that send conflicting proofs repeatidly * [Cashtab] [Chronik] [Tx Gen] Sign and build Tx * use existing chainstate reference in various places * [Cashtab] [Chronik] [Tx Gen] Generate Tx Output * [Cashtab] [Chronik] [Tx Gen] Generate Tx Input * use local chainman in peermanager_tests * [Cashtab] [Chronik] [Tx Gen] Generate encoded OP_RETURN script * [Cashtab] [Chronik] [Tx Gen] Get change address from input UTXOs * [Cashtab] [Chronik] [Tx Gen] Parse XEC send value * [cashtab-components] Replace all instances of CashTab with Cashtab * [avalanche] Pass chainman to PeerManager * [avalanche] Pass chainman to Processor * [avalanche] Send a avahello message when no proof is supplied * [avalanche] Don't register known dangling proofs * [Automated] Update seeds * [avalanche] Fix flaky checks after orphaning a valid proof * [avalanche] Hold the peer manager lock during the peer cleanup * [avalanche] Fix a lock order inversion * [Chronik] Remove `dead_code`, `elided_lifetimes_in_paths` and `single_use_lifetimes` lints * [Cashtab] contactList PropType error patch * [cashtab-components] update storybook logo * [cashtab-components] update node version * [Cashtab] Migrate to ABC chronik instance * [avalanche] Make the orphan pool only accept proofs that have valid but immature utxos * [Chronik] Add `BlockHash` struct wrapping `Sha256d` to avoid mixing kinds of hashes * [avalanche] Get rid of the compact proof cleanup log * [build] replace the BCH logos in the Windows install wizard * [docker] Run the install script in its own directory * [Chronik] Add fallible `Hashed` methods for parsing byte slices and hex string * [Automated] Update timing.json * [Automated] Update seeds * [Automated] Update chainparams * [Cashtab] [WS update engine Part 4] On successful websocket connection, change wallet utxo refresh interval from 1s to 30s * [Cashtab] [WS Update Engine Part 3] On websocket tx seen message, refresh the wallet utxo set * [Cashtab] [WS Update Engine Part 2] Deprecate useAsyncTimeout in favor of useInterval hook to support dynamic changes wallet utxo refresh interval * [Cashtab] [WS Update Engine Part 1] Convert wallet utxo refresh interval from hardcoded number to a state variable * [avalanche] Remove unused hash verifier in avahello deserialization ------------------------------------------------------------------- Fri Jul 08 05:52:55 UTC 2022 - marec@detebe.org - Update to version 0.25.9: * [Chronik] Add line to CONTRIBUTING.md and install-dependencies.sh ensuring rustfmt when installing nightly * [avalanche] Fix ambiguous casts from size_t to UniValue * Prepare release notes for 0.25.9 * [avalanche] Add count of orphan proofs to getavalancheinfo * [avalanche] Add count of conflicting proofs to getavalancheinfo * [Chronik] Add `build-chronik` to CI builds * [Chronik] Add hash structs for type-safe and endian-safe handling of hashes * [Chronik] Add clippy linter as build target * [Automated] Update timing.json * [Automated] Update chainparams * [Automated] Update seeds * Bump version to 0.25.9 * [Chronik] Add Rust install instructions to CONTRIBUTING.md * [Chronik] Add `rustfmt` linter, to style check Rust files * [avalanche] Correctly flag the inflight compact proofs request * [Chronik] Install nightly rust toolchain dependency (as "abc-nightly") * scripted-diff: tree-wide: Remove all review-only assertions * tree-wide: Remove stray review-only assertion * qt/test: Use existing chainman in ::TestGUI * scripted-diff: wallet/test: Use existing chainman * fuzz: Initialize a TestingSetup for test_one_input * [avalanche] Skip processing compact proofs with no shortid * [avalanche] Poll for unorphaned proofs * [avalanche] Add a facility for building an compact proofs message in tests * [avalanche] Don't attempt to register the same proof several times during orphan rescan * [Automated] Update timing.json * [Automated] Update seeds * [Automated] Update chainparams * [avalanche] Simplify the proof reconciliation logic * [linter] Fix a outdated comment on clang format version * fuzz: Initialize a full TestingSetup where appropriate * fuzz: Consolidate fuzzing TestingSetup initialization * [Automated] Update timing.json * [Automated] Update seeds * [Automated] Update chainparams * [arcanist] Untrack and ignore the arc liberate cache file * [Chronik] Add minimal bitcoinsuite-core Rust crate + CMake to `cargo test` it * [avalanche] Don't process proofs that are not worth polling * [avalanche] Run the proofs cleanup on a schedule * [avalanche] Aggressively request compact proofs * [Cashtab] Replaced all instances of react-copy-to-clipboard * [avalanche] Use immature UTXO to orphan the proof in known_score_tracking test * [avalanche] Enforce min UTXO age in avalanche proofs * [avalanche] Cleanup dangling proofs * [avalanche] Add height parameter to buildRandomProof * Install dependencies for Chronik: Rust and Corrosion * [avalanche] Don't request compact proofs during IBD * [avalanche] Run the quorum functional test with the new proof format * tests: trivial simplification in pad_tx * [Cashtab] Airdrop OP_RETURN patch * Ignore lint check on randbytes since it's wrapped in a version check * Add argument to mypy linter to always show error codes * [Automated] Update timing.json * [Automated] Update seeds * [Automated] Update chainparams * [avalanche] Make IsWorthPolling a private method of the processor * scripted-diff: test: Use existing chainman in unit tests * miner_tests: pass chainman and active_chainstate to helper functions * test: Pass in CoinsTip to ValidateCheckInputsForAllFlags * test/miner_tests: Pass in chain tip to CreateBlockIndex * test/util: Use existing chainman in ::PrepareBlock * init: Use existing chainman * [avalanche] Make proper use of p2p_lock in avalanche tests * [avalanche] Deduplicate the getavaproofs response test * index: Add chainstate member to BaseIndex * [avalanche] Reorder processor's methods to match the header * Update the seeder list * [Cashtab] Reply To Message button should just read Replyr * bench: Use existing NodeContext and chainman * rpc/blockchain: Use existing blockman in gettxoutsetinfo * [Cashtab] Upgrade chronik-client to patck new block msgs * [Automated] Update timing.json * [Automated] Update seeds * [Automated] Update chainparams * [Cashtab] Patch bracket color for Documentation link * [LINT] Fix trailing whitespaces in the contributing doc ------------------------------------------------------------------- Tue Jun 14 16:51:04 UTC 2022 - marec@detebe.org - Update to version 0.25.8: * [Automated] Update timing.json * [avalanche] Integrate the IBD check into the quorum check * [avalanche] Improve the avalanche quorum functional test * doc: coinstatsindex related touchups * rpc: gettxoutsetinfo rejects hash_serialized for specific height * rpc: Allow gettxoutsetinfo and getblockstats for stale blocks and add test for coinstatsindex behavior in reorgs * index, rpc: Add use_index option for gettxoutsetinfo * test: Test coinstatsindex robustness across restarts * test: Add tests for block_info in gettxoutsetinfo * rpc, index: Add verbose amounts tracking to Coinstats index * rpc: Add Coinstats index to getindexinfo * rpc: gettxoutsetinfo can be requested for specific blockheights * index: Coinstats index can be activated with command line flag * index: Add Coinstats index * refactor: Simplify ApplyStats and ApplyHash * refactor: Pass hash_type to CoinsStats in stats object * [Cashtab] Upgrade to latest chronik-client * [Cashtab] Patch collapse proptype error * [avalanche] Simplify the quorum functional test by unsing the gen_proof facility * [avalanche] Remove unused mock time from the quorum functional test * [avalanche] Use the number nodes from which we've received avaproofs as a criterion for quorum readiness * [avalanche] Limit the size of the orphan proof pool * [avalanche] Send getavaproofs periodically to one random peer * [avalanche] Cleanup unrequested radix tree after a timeout * [Cashtab] Added received from address to txHistory display * Bump version to 0.25.8 * rpc/rest: Take and reuse local Chain/ChainState obj * rpc: Remove unnecessary casting of block height * rpc: Tidy up local references (see commit message) * rpc: refactor Ensure* functions * rest: Pass in NodeContext to rest_block and use it * [avalanche] Respond to missing proof indices request * [avalanche] Request missing proofs from short ids * Leverage Empty Base Optimization for the radix tree Adapter * [Cashtab] Patch API error handling * [Automated] Update seeds * [Automated] Update chainparams * [README] Updated comments on stacked diff procedure * [Cashtab] Prevent caching of index.html * [Cashtab] Extension version bump * Extract the compact block processing into a generic helper class * [fuzzer] No longer attempt to deserialize PrefilledTransaction * [Cashtab] [Chronik Websocket Notifications] [Part 11] Ignore tx confirmed messages * [Cashtab] [Chronik Websocket Notifications] [Part 10] If ws connection active, hide api notifications * [Cashtab] [Chronik Websocket Notifications] [Part 9] Display eToken notifications from websocket msg * [Cashtab] [Chronik Websocket Notifications] [Part 8] Check cache for eToken info * [Cashtab] [Chronik Websocket Notifications] [Part 7] Display XEC notifications from ws msg * [Cashtab] [Chronik Websocket Notifications] [Part 6] Parse eToken txs from websocket msg * [Cashtab] [Chronik Websocket Notifications] [Part 5] Parse XEC txs from websocket msg * [Cashtab] [Chronik Websocket Notifications] [Part 4] Unsubscribe to Hash160s when active wallet changes * [Cashtab] [Chronik Websocket Notifications] [Part 3] Subscribe to Hash160s * [Cashtab] [Chronik Websocket Notifications] [Part 2] Get Hash160s from wallet * [Cashtab] [Chronik Websocket Notifications] [Part 1] Connect to websocket * Use the DifferentialIndexedItemFormatter for the compact blocks * [Cashtab] Route to onboarding if no wallet present * Drop JSONRPCRequest constructors * drop network.{h|cpp} * remove unneeded includes of core_io.h and network.h * Consistently use the calculate_shortid facility in functional tests * [avalanche] Add a way to get the lowest scoring proof in a pool * [avalanche] Add a way to count the number of proofs in a ProofPool * [Cashtab] Copy own address from Sign Message collapse in Send.js * Extract the PrefilledProof::Formatter so it can be reused for compact blocks * [avalanche] Request compact proofs from our avalanche outbound peers * [avalanche] Extract the compact proofs functional test to its own file * [avalanche] Answer getavaproofs message with short proof ids * [avalanche] Introduce a CompactProofs class for managing the short proof ids * Fix off by one errors in the difference fomatter serialize_tests * [Cashtab] Run npm test before commit * remove unused class util::Ref and its unit test * refactor: replace util::Ref with std::any (C++17) * refactor: Improve use of explicit keyword * [Cashtab] Add a copy address feature to contact list * Fix includes in net.h related to past avalanche refactors * Clarify that m_tx_relay and m_proof_relay are thread safe * [Cashtab] Fix unit tests * [Automated] Update timing.json * [Automated] Update seeds * [Automated] Update chainparams * [avalanche] Make stale voting parameters configurable * [Cashtab] Button labeling & positioning in Contact List patch * [Casthab] Remove classNames from Tx.js ------------------------------------------------------------------- Wed Jun 01 15:02:21 UTC 2022 - marec@detebe.org - Update to version 0.25.7: * [Cashtab] Hide Add To Contacts option if sender is a contact * update headers for BIP70 payment request * Bump version to 0.25.7 * [Cashtab] Fix typo in TxHistory * [avalanche] Use argsman instead of gArgs throughout processor * [avalanche] Drop stale votes and stale proofs * [avalanche] Extract proof reception logic out of the avaproof message handling * [Cashtab] Tx receipt icon added to Tx dropdown menu * [Automated] Update timing.json * [Automated] Update seeds * [Automated] Update chainparams * [avalanche] Maintain a radix tree of the proofs * [avalanche] Set voterecord_tests node ID using a fixture * [avalanche] Add a way to check if a VoteRecord is stale * Fix an exception message in blockencodings_tests when the compact size MAX_SIZE is not the limiting factor * Deduplicate the HasReason class * Move the DifferenceFormatter to serialize.h * [RCU] Make it possible to serialize/deserialize a RCUPtr * rpc/rawtx: Use existing NodeContext * rpc/mining: Use existing NodeContext * rpc/blockchain: Use existing NodeContext * net_processing: Move comments to declarations * miner: Add chainstate member to BlockAssembler * validation: Make BlockManager::LookupBlockIndex const * [avalanche] Turn ProofRef into a RCUPtr * [RCU] Add an implicit converting constructor * [avalanche] Remove unnecessary code path in addNodeToQuorum * [avalanche] Add some tests to check that duplicate votes are not counted * [Cashtab] [chronik] Add hash160 strings to wallet state * Move the Uint256RadixKey to its own header * scripted-diff: net_processing: Use existing chainman * move getAvalancheVoteForBlock to PeerManagerImpl * net_processing: Move some static functions to PeerManager * [avalanche] Move VoteRecord tests to their own file * [avalanche] Use the ProofComparator for sets and maps * [radix] Adds the capability to use an adapter for key manipulation * txorphanage: comment improvements * net_processing: move AddToCompactExtraTransactions into PeerManagerImpl * scripted-diff: Update txorphanage naming convention * txorphanage: Move functions and data into class * orphanage: Extract EraseOrphansForBlock * txorphanage: Extract OrphanageAddTx and drop AddOrphanTx * txorphanage: Extract GetOrphanTx * txorphanage: Extract HaveOrphanTx * txorphanage: Extract AddChildrenToWorkSet * txorphanage: Add lock annotations * txorphanage: Pass txid by reference instead of value * move-only: Add txorphanage module * [Automated] Update timing.json * [Automated] Update seeds * [Automated] Update chainparams * [avalanche] Ensure nullptr safety on proccesor's public interface * [avalanche] Remove unecessary timeout in the abc_p2p_getavaaddr.py test * Rename the Uint256KeyWrapper struct * [Cashtab] Address content jumping for Send button * Update CONTRIBUTING.md with new link to development group * [Cashtab] Remove separate block explorers for token txs ------------------------------------------------------------------- Mon May 16 15:24:28 UTC 2022 - marec@detebe.org - Update to version 0.25.6: * [Automated] Update timing.json * [Automated] Update seeds * [Automated] Update chainparams * Add a checkpoint after the May 15th, 2022 upgrade * Bump version to 0.25.6 * seeder: don't ignore connection errors * [avalanche] Rename the ProofComparator * [avalanche] Don't assume shared_ptr for ProofRef * Stop parsing the radix tree if the callback function returns false * [RCU] Run a lazy round of cleanup when unlocking the RCULock * [avalanche] Fix logging of vote statuses * [avalanche] Fix proof voting response type * [Automated] Update timing.json * [Automated] Update seeds * [Automated] Update chainparams * Remove redundant lock annotations in net processing * test: Add missing syncwithvalidationinterfacequeue * test: Misc cleanup for p2p_blockfilters * test: style changes for p2p_blockfilters * Fix thread safety error: negative handling capability * Let the radix tree work with 256 bits keys * [avalanche] Remove dead code in the delegation tests * net_processing: move MaybeSetPeerAsAnnouncingHeadersAndIDs into PeerManagerImpl * net_processing: move FindTxForGetData and ProcessGetData to PeerManagerImpl * net_processing: move MarkBlockAs*, TipMayBeStale, FindNextBlocksToDL to PeerManagerImpl * net_processing: move AlreadyHaveTx into PeerManageImpl * net_processing: move some globals into PeerManagerImpl * Make iteration type explicit, this is very important here. * node/ifaces: ChainImpl: Use existing NodeContext member * node/ifaces: NodeImpl: Use existing NodeContext member * node: Use existing NodeContext * node/coinstats: Pass in BlockManager to GetUTXOStats * [avalanche] Consolidate duplicate code for moving proofs to conflicting pool * [Cashtab] Embed token ID into airdrop OP_RETURN outputs * Add a traversal method for the radix tree * [avalanche] Improve logging of the vote status update * bench: use the node context & chain from the TestSetup instead of creating a new one * [Cashtab] Signature Copied text color patch * [Cashtab] Airdrop modal percentage color patch * test: Remove no longer needed MakeChain calls * refactor: Replace uses ChainActive() in interfaces/chain.cpp * refactor: Get rid of more redundant chain methods * test: Add pure Python RIPEMD-160 and use it instead of OpenSSL * [Automated] Update timing.json * [Automated] Update seeds * [Automated] Update chainparams * Rename radix typename for key type to something searchable * [Cashtab] Parse amount param in XEC ------------------------------------------------------------------- Wed May 04 14:31:45 UTC 2022 - marec@detebe.org - Update to version 0.25.5: * [Cashtab] Center collapse headers in Send.js * Bump version to 0.25.5 * [Automated] Update timing.json * [Automated] Update chainparams * [Cashtab] Add a saved wallet to contact list * [Automated] Update seeds * [Cashtab] Fresh browser/wallet fix for contact list * use c++ 17 structured binding in cashaddr related code * Use incrementRefCount and decrementRefCount in the radix code too * Reflow eCash section of the README * Change the name of the refcount operations on RCU elements * [avalanche] Limit the number of delegation levels * Implement COW for the radix tree * [Automated] Update timing.json * [Cashtab] Adding airdrop hex prefix and OP_RETURN msg to airdrop payments * [Automated] Update seeds * [Automated] Update chainparams * Use using instead of typedef int he radix code * [Cashtab] Patch character limit counter font color * doc: Remove irrelevant link to GitHub * blockstorage: [refactor] Use chainman reference where possible * move-only: Move *Disk functions to blockstorage * retire support of pre-0.22.8 block index upgrade * Move AbortNode to shutdown and fix an error message * move-only: Move ThreadImport to blockstorage * refactor: Move load block thread into ChainstateManager * [Cashtab] Replace hardcoded length limit with settings param * Rewrite README intro to be more objective * [Cashtab] Flag msgs received from addresses not in contact list * [Cashtab] Manually adding contacts * [Cashtab] Export contact list * [Cashtab] Delete contacts * Rename Bitcoin Cash to eCash in backporting instructions + minor fixes * Fix missed renaming to eCash * Fix typo in disclosure * [Automated] Update timing.json * [Automated] Update seeds * [Automated] Update chainparams ------------------------------------------------------------------- Thu Apr 21 17:06:08 UTC 2022 - marec@detebe.org - Update to version 0.25.4: * Use the actual config in the RPC console * Fix ambiguous amount multiplication * [Automated] Update chainparams * [Automated] Update timing.json * [Automated] Update seeds * [avalanche] Add an easy to use shortcut flag to turn on avalanche * Make the seeder dump interval settable by commandline argument * [avalanche] Account for our own proof in the connected stake computation * [avalanche] Always send an avahello message if we have a proof * [avalanche] Ignore duplicated avahello messages * [avalanche] Bump our avalanche outbound connections * Fix the osx build issue in the peer manager tests * [avalanche] Introduce a Proof::ToHex() shortcut * [avalanche] Don't ban peers sending us unsolicited avalanche messages * [avalanche] Make the max number of outbound connection configurable * [avalanche] Simplify the peermanager tests by factoring the buildProof lambdas * [Cashtab] Stop content from jumping in saved wallet & contact lists * Fix the util_tests.cpp build on OSX * Fix a bug in ParseMoney that prevents from parsing large numbers * [Automated] Update seeds * [Automated] Update chainparams * Bump version to 0.25.4 * [Cashtab] Add mock API call to unit test * [Automated] Update timing.json * [avalanche] Simplify the peermanager tests by deduplicating the addCoin lambdas * rpc: remove scantxoutset EXPERIMENTAL warning * rpc: Properly document return values (submitblock, gettxout, getblocktemplate, scantxoutset) * rpc, test: document {previous,next}blockhash as optional * Deduplicate some block-to-JSON code. * [Cashtab] Rename contacts * Add an option to allow for bypassing the network group limit on outbound connections * refactor: Avoid magic value of all-zeros in assumeutxo base_blockhash * validation: run VerifyDB on all chainstates * doc: remove potentially confusing ChainstateManager comment * test: Add tests with maleated snapshot data * tests: add snapshot activation test * simplify ChainstateManager::SnapshotBlockhash() return semantics * [Cashtab] Contact List * [Cashtab] remove unnecessary constant keys * chainparams: add allowed assumeutxo values * move-only: Add util/hash_type * [test] test regtest deterministic chain setup * tests: add deterministic chain generation unittest fixture * txdb: don't reset during in-memory cache resize * [avalanche] Send getavaaddr messages to the manually added nodes * [avalanche] Don't fallback too quickly to regular outbound when looking for an avalanche one * [avalanche] Handle tx inv polls with a stub handler. * [avalanche] Consistently use the FromHex methods in tests * [Cashtab] Patch obsolete docs link * [test] add typehints to create_block and create_coinbase * [test] remove unnecessary transaction rehashing * [Cashtab] adjust airdrop totalHolders type * mempool: apply rule of 5 to epochguard.h, fix compiler warnings * [Automated] Update timing.json * [Automated] Update chainparams * [Cashtab] Match seed phrase collapse title position * [refactor] txmempool: split epoch logic into class * [Cashtab] Copy OP_RETURN message button added to Tx collapse ------------------------------------------------------------------- Thu Apr 07 18:20:43 UTC 2022 - marec@detebe.org - Update to version 0.25.3: * [avalanche] Erase the avalanche nodes that get disconnected * [avalanche] Properly remove pending node when possible * txmempool: add thread safety annotations * refactor: return std::nullopt instead of {} * [Cashtab] Airdrop Option - minimum etoken holder balance eligibility * [Cashtab] Airdrop Option - exclusion list * [Cashtab] Airdrop Option - ignore eToken creator address * [Cashtab] Airdrop Option - ignore airdrops below dust * [Cashtab] Airdrop Option - ignore own address * [Cashtab] Airdrop text area header css patch * Update DISCLOSURE.md contact info * [Cashtab] Move collapse styled components from Tx.js to StyledCollapse.js * add release notes for blockfilterindex compatibility with prune * Bump version to 0.25.3 * add a copyright header in blockdb.cpp * doc: add explanations for assert in index and magic numbers in test * Allow maintaining the blockfilterindex when using prune * net: Restrict period when cs_vNodes mutex is locked * Remove duplicated (and misplaced) node disconnection logging * [Cashtab] Verify Message feature * [Cashtab] Upload token icon info and airdrop alert css patch * [Automated] Update seeds * [Cashab] Corrected proptype in QRCode * [Cashtab] Add disabled button component & use in Send.js * [avalanche] Reduce the getavaaddr message sending interval * [avalanche] Use constants for delays in abc_p2p_getavaaddr * [avalanche] Fix an always true assertion in abc_p2p_getavaaddr * [avalanche] Always allow for downloading our local proof if it has been advertised * [Cashtab] CSS patch font color of alerts in Configure.js * [avalanche] Broadcast our local proof once it's been verified * [avalanche] Return addresses of nodes we did not poll yet * [avalanche] Keep sending getavaaddr until the qorum is established * [avalanche] Add a flag to indicate if the node started voting in getavalanchinfo * [avalanche] Fix missing doc entry in getavalancheinfo * [avalanche] Reduce abc_p2p_proof_inventory.py test duration * [Automated] Update timing.json * [Automated] Update chainparams * [.gitignore] Add .netlify folder for webdev * [Cashtab] Remove titles from send.svg & cog.svg * [Cashtab] Send token amount input field css patch * [Cashtab] Finalize webpack upgrade * [Cashtab] Patching proptype validation error * [Cashtab] Bump required node version * [Cashtab] Webpack upgrade for extension script * [Cashtab-v2] Address linting errors throughout the app * [Cashtab-v2] Webpack 5 CSS patch: ant-descriptions-title * [cashtab] fix useWallet test * [cashtab] Fix broken tests which rendered antd Input components after jest 27 upgrade * [Cashtab] Run tests in UTC timezone * [Cashtab] Support migration to jest 27 * [Automated] Update timing.json * [Automated] Update seeds * [Automated] Update chainparams * [Cashtab] webpack upgrade p13 * [Cashtab-v2] Patch Send Confirmations text color in Configure.js * [Cashtab-v2] Fix Tx component width * [Cashtab] Webpack upgrade p10, first working version * [Cashtab] Webpack upgrade part 9, fix import order * [Cashtab] Webpack upgrade part 8, rework absolute imports * [Cashtab] Webpack upgrade step 7, add scripts to package.json * [Cashtab] Webpack upgrade part 6, feature freeze and source code copy * [Cashtab] Advanced Tooling + Airdrop facility * [Cashtab] Token burn functionality ------------------------------------------------------------------- Wed Mar 23 16:45:27 UTC 2022 - marec@detebe.org - Update to version 0.25.2: * Fix the build on some platforms by using an explicit cast for Univalue type * [Cashtab] Make disabled send button more explicit * [avalanche] Add a verifyavalanchedelegation RPC * [avalanche] Add a decodeavalanchedelegation RPC * [avalanche] Don't poll or vote definitively until we have quorum. * [Cashtab] Moved param alert above send button * [Cashtab] Support param parsing in QR scanned addresses * move-onlyish: break out CreateUTXOSnapshot from dumptxoutset * [CMAKE] Fix name collisions causing potential infinite recursion * miner: Pass in chainstate to BlockAssembler::CreateNewBlock * validation: CVerifyDB::VerifyDB: Use locking annotation * [avalanche] Track registered and allocated scores in PeerManager. * scripts: add PE .reloc section check to security-check.py * [CMAKE] Prevent linker segfault with recent MinGw version * build: fix ASLR for bitcoin-cli on Windows * [Cashtab] Ensure browserify is installed before extension build * [Cashtab] Webpack upgrade, part 5 * [Cashtab] Webpack upgrade part 4, dependencies * [Cashtab] Improve handling of priceApiError in Send.js * [Cashtab] Send XEC/eToken confirmation modal w/ settings switch * validation: Use existing chain member in CChainState::AcceptBlock and LoadGenesisBlock * validation: Pass in chain to FindBlockPos+SaveBlockToDisk * validation: Use *this in CChainState::ActivateBestChainStep * validation: Pass in chainstate to CTxMemPool::check * validation: Use *this in CChainState::InvalidateBlock * validation: Move LoadBlockIndexDB to CChainState * validation: Move invalid block handling to CChainState * validation: Pass in chainstate to CVerifyDB::VerifyDB * [Cashtab] BalanceHeaderFiat component handles null value for fiatPrice * validation: Remove global ::VersionBitsTip{State,SinceHeight,Statistics} * validation: Pass in chainstate to ::PruneBlockFilesManual * validation: Pass in chainstate to UpdateTip * remove unused UpdateCoins declaration * validation: Remove global ::UnparkBlock(AndChildren) * validation: Remove global ::PreciousBlock,ResetBlockFailureFlags * validation: Remove global ::LoadGenesisBlock * validation: Check chain tip is non-null in CheckFinalTx * validation: Use *this in CChainState::LoadMempool * validation: Pass in chainstate to UpdateMempoolForReorg * validation: Pass in chainstate to CTxMemPool::removeForReorg * validation: Pass in chain to ::TestLockPointValidity * validation: Pass in chainstate to ::AcceptToMemoryPool * validation: Pass in chainstate to ::LoadMempool * validation: Pass in chainstate to AcceptToMemoryPoolWithTime * validation: Add chainstate member to MemPoolAccept * validation: Pass in chainstate to ::CheckSequenceLocks * [Automated] Update timing.json * [Automated] Update seeds * [Automated] Update chainparams * Fix the CONTRIBUTING for clang-format-11 * [Cashtab] Display fiat price in local currency * [doc] Update Doxygen to mention eCash instead of Bitcoin Cash * [Cashtab] Webpack upgrade part 3, polyfill support * validation: Pass in chain tip to ::ContextualCheckTransactionForCurrentBlock * validation: Pass in coins tip to CheckInputsFromMempoolAndCache * validation: Pass in coins cache to CTxMemPool::LimitSize * Remove redundant sentence in ActivateBestChain comment * validation: Use existing chainstate in ChainstateManager::ProcessNewBlockHeaders * validation: Move LoadExternalBlockFile to CChainState * validation: Remove global ::ActivateBestChain * validation: Pass in chainstate to ::NotifyHeaderTip * validation: Pass in chainstate to TestBlockValidity * validation: Make CChainState.m_blockman public * [avalanche] Add helper function Proof::amountToScore(). * validation: Pass in blockman to ContextualCheckBlockHeader * validation: Move GetLastCheckpoint to BlockManager * validation: Move GetSpendHeight to BlockManager * validation: Move FindForkInGlobalIndex to BlockManager * validation: Move global LookupBlockIndex method to BlockManager * validation: Guard the active_chainstate with cs_main * test: Add new ChainTestingSetup and use it * qt/test: [FIX] Add forgotten Context setting in RPCNestedTests * [Cashtab] Hide notification when switching apps/wallets * interface: remove unused estimateSmartFee method * crypto: Make MuHash Remove method efficient * [Cashtab] Remove unused styled import from TokenIcon.js * [Cashtab] Remove api call unit test * [avalanche] Add the availability score to the node statistics * [avalanche] Fix potential abc_rpc_getavalancheinfo test failure on slow machines * rpc: Add hash_type MUHASH to gettxoutsetinfo and add a test * make ApplyHash and ApplyStats take a TxId * refactor: Separate hash and stats calculation in coinstats * refactor: Improve encapsulation between MuHash3072 and Num3072 * bench: Add Muhash benchmarks * Add MuHash3072 implementation * Bump version to 0.25.2 * Add a CHashWriter::GetSHA256() method to compute a single sha256 * [avalanche] Add a getavalancheinfo RPC for general status info * Update the suggested key type in the contributing file * [Automated] Update seeds * [avalanche] Add the score and staked amount to the decodeavalancheproof RPC * [Automated] Update chainparams * [avalanche] Optionally select a proof id in the getavalanchepeerinfo RPC * [Automated] Update timing.json * refactor: replace (sizeof(a)/sizeof(a[0])) with C++17 std::size * [Cashtab] Webpack upgrade part 2, ejecting create react app * [Cashtab] Correct proptypes validation for settings * [Cashtab] Fix fee calculation for one to many txs * Revert "[Cashtab] Add privacy policy" * [Cashtab] Webpack upgrade part 1 * [arclint] Ignore spelling for generated package-lock.json files ------------------------------------------------------------------- Mon Mar 07 17:39:44 UTC 2022 - marec@detebe.org - Update to version 0.25.1: * [Automated] Update seeds * [Automated] Update chainparams * [avalanche] Decode the stake address in the decodeavalancheproof RPC * test: refactor: remove unneeded bytes<->hex conversions in `byte_to_base58` * test: replace remaining binascii method calls in functional tests * test: refactor: remove hex_str_to_bytes helper * [SECP256K1] [RFC] Remove OpenSSL testing support * Migrate seeder to use node's sleep utility function * [avalanche] Add an accessor for the staked amount from a proof * [avalanche] Add an accessor to the node count * [avalanche] Add an accessor to the pending nodes count * [Cashtab] Tx History collapse menu * rpc: enable filtering getnodeaddresses by network * p2p: enable GetAddr() and GetAddresses() by network * rpc: add network field to rpc getnodeaddresses * Bump version to 0.25.1 * [avalanche] Convert the remaining tests to run with the new proof format * [avalanche] Let the avalanche functional tests run both with and without the legacy proof format * [Automated] Update timing.json * [Cashtab] Bump extension version * [Cashtab] Remove comment code from useWallet.js * [avalanche] Test framework: don't assume the p2p avaproof messages are using the legacy format * [avalanche] Don't assume the legacy proof format in get_proof_ids * [TEST] Remove useless trailing parenthesis in class declaration * [TRIVIAL] Make the release notes mardown link project absolute * [Cashtab] p8 of 8 for improved utxo mgmt * Remove unnecessary versions from comments * [Cashtab] [p7 of 8] Only hydrate changed utxos * [Cashtab] Add privacy policy * [Cashtab] Create TokenIcon Component * Remove the ASERT anchor walk and caching * Replace Axion activation time with the actual block height * [Cashtab] Only hydrate changed utxos part 6 of 8 * Remove SCRIPT_VERIFY_CHECKDATASIG_SIGOPS flag * Bump to clang-11 and clang-format-11 * [LINTER] Remove LogPrintf from the false positive list in linrt-format-strings.py * [Linter] Update some PHP files to simplify the phpcs rules * [avalanche] Cache the peer score * [avalanche] Order the peer set by score * Declare de facto const member functions or reference variables as const * Don't make "in" parameters look like "out"/"in-out" parameters: pass by ref to const instead of ref to non-const * [Automated] Update timing.json * [Automated] Update seeds * [Automated] Update chainparams * [Cashtab] [utxo opt. part 5 of 8] Add function removeConsumedUtxos * [Cashtab] Do not open scanner on Send screen when value and address are prepopulated ------------------------------------------------------------------- Wed Feb 23 17:46:55 UTC 2022 - marec@detebe.org - Update to version 0.25.0: * Run the activated tests using the next upgrade * Update the miner fund address * [Cashtab] [utxo opt. part 4 of 8] Add function addNewHydratedUtxos * test: Fix inconsistent lock order in wallet_tests/CreateWallet * test: Add testing of ParseInt/ParseUInt edge cases with leading +/-/0:s * net: Treat raw message bytes as uint8_t * [avalanche] Fix potential failure in abc_p2p_avalanche_proof_voting * Force port 0 in I2P * [Cashtab] [utxo opt. part 3 of 8] Add function whichUtxosWereConsumed * [Cashtab] Removed obsolete dev note from Token.js * scripted-diff: Rename touched CNode member variables * Use mockable time for peer connection time * refactor: Use type-safe std::chrono in net * test: add missing netaddress include headers * test: remove duplicate assertions in util_tests * util: add ParseUInt16(), use it in SplitHostPort() * test: add ParseUInt8() unit and fuzz test coverage * p2p, refactor: pass and use uint16_t CService::port as uint16_t * net, doc: Doxygen updates and fixes in netbase.{h,cpp} * net: Make DNS lookup code testable * Remove unused upgrade activation times * Add a facility to check if the May 15, 2022 upgrade is activated * Simplify the abc_mining_basic.py test * p2p, refactor: performance improvements to ProtectEvictionCandidatesByRatio() * p2p: update inbound eviction protection for multiple networks, add I2P peers * doc: warn that incoming conns are unlikely when not using default ports * [avalanche] Request for more avalanche nodes when needed * [avalanche] Detect when more nodes are needed * [avalanche] Send a getavaaddr message to our avalanche outbound peers * [avalanche] Extend our outbound connections with avalanche enabled peers * Bump replay protection activation time to Nov. 15. 2022 * [LINTER] Get rid of cppcheck * [Automated] Update timing.json * [Automated] Update seeds * [Automated] Update chainparams * [Cashtab] Re-implement 11008 after UI landing * [Cashtab] UI Updates * [avalanche] Bump the proof vote finalization timeout in the functional test * p2p: Refactor sock to add I2P unit test * doc: add basic I2P documentation * net: recognize I2P from ParseNetwork() so that -onlynet=i2p works, do not skip I2P in GetNetworkNames() * net, rpc: return NET_UNROUTABLE as not_publicly_routable, automate helps * doc: tor.md updates * doc: tor.md updates (19961) * doc: update -onlynet help in src/init.cpp * net: add I2P to the reachability map, make outgoing and accept incoming connections from CConnman * init: introduce I2P connectivity options * Bump version to 0.25.0 * [Cashtab] [utxo optimization part 2 of 8] Add function whichUtxosWereAdded * Update makeseeds.py to support 0.25.x * [avalanche] Merge the avalanche voting tests * [Cashtab] [utxo optimization part 1] Add function isExcludedUtxo * net: implement the necessary parts of the I2P SAM protocol * [Cashtab] Remove extra space on eToken creation error msg * [Cashtab] Add support for Swiss Franc * [avalanche] Split the abc_p2p_avalanche_proof_voting test into sub-cases * [avalanche] Extract the facilities to the test object to simplify the abc_p2p_avalanche_proof_voting test * Improve the ReattempInitalBroadcast interval computation * net: extend Sock with a method to check whether connected * net: extend Sock with methods for robust send & read until terminator * net: extend Sock::Wait() to report a timeout * net: dedup MSG_NOSIGNAL and MSG_DONTWAIT definitions * net: move the constant maxWait out of InterruptibleRecv() * net: extend CNetAddr::SetSpecial() to support I2P * net: avoid unnecessary GetBindAddress() call * net: isolate the protocol-agnostic part of CConnman::AcceptConnection() * net: check for invalid socket earlier and get the bind address earlier in CConnman::AcceptConnection() * util: fix ReadBinaryFile() and WriteBinaryFile() return status * util: extract {Read,Write}BinaryFile() to its own files * [Automated] Update timing.json * [Automated] Update seeds * [Automated] Update chainparams * [avalanche] Add a peer replacement cooldown * [avalanche] Fix a potential use after free issue * [avalanche] Update our position according to the vote * [avalanche] Poll for the new proofs * [avalanche] Simplify the updatedBlockTip handler * [avalanche] Add a method to reject a proof * [avalanche] Make it possible to replace a proof * [avalanche] Limit the conflicting proof rate * [avalanche] Fix a reversed lock order in ReattemptInitialBroadcast * [Cashtab] Mock getPubKey for unit tests * style: rename hSocket to sock * net: use Sock in InterruptibleRecv() and Socks5() * net: add RAII socket and use it instead of bare SOCKET, add Sock unit tests * net: move CloseSocket() from netbase to util/sock * net: move MillisToTimeval() from netbase to util/time * Move the add_outbounds helper to the test object in p2p_add_connections.py * [avalanche] Improvements to the getavaaddr functional test * Add include for std::bind. * net: compat.h related cleanup * [avalanche] Add a getavaaddr message * include cmath in util_tests * [avalanche] Add proof-poll responses * refactor: remove boost::thread_group usage * init: Setup scheduler in tests and init in exactly the same way * refactor: Drop boost::thread stuff in CCheckQueue * bench: Use CCheckQueue local thread pool * Add local thread pool to CCheckQueue and use it in tests * refactor: Use member initializers in CCheckQueue ------------------------------------------------------------------- Sat Feb 05 12:53:30 UTC 2022 - marec@detebe.org - Update to version 0.24.11: * specify the type when constructing unordered_set from iterator * Fix CNode construction in fuzz tests * Protect onion+localhost peers in ProtectEvictionCandidatesByRatio() * Refactor EraseLastKElements to be a special case of EraseLastKElementsIf * Add unit tests for ProtectEvictionCandidatesByRatio() * Use std::unordered_set instead of std::vector in IsEvicted() * Move peer eviction tests to a separate test file * Extract ProtectEvictionCandidatesByRatio from SelectNodeToEvict * Increase our max number of outbound peers * Bump the timeout for the debug log messages in test_seed_peers * fix CNode construction in denialofservice_tests.cpp * net: make CNode::m_inbound_onion public, initialize explicitly * [Cashtab] fix stale cached data * Refactor p2p_add_connections * net: assert CNode::m_inbound_onion is inbound in ctor, add getter, unit tests * test: add check_node_connections in util * p2p: Make timeout mockable and type safe, speed up test * Add "Last Block" and "Last Tx" rows to peer details area * Display fRelayTxes and bip152_highbandwidth_{to, from} in peer details * net, rpc: expose high bandwidth mode state via getpeerinfo * Add network to peers window and peer details * [Automated] Update timing.json * [Automated] Update seeds * [Automated] Update chainparams * test: Disable automatic connections by default * test: check anchors.dat when node starts for the first time * test: add functional test for anchors.dat * scripted-diff: rename GetSystemTimeInSeconds to GetTimeSeconds * p2p: Use mocktime for ping timeout * test: Set peertimeout in write_config * [net] Changes to RunInactivityChecks * scripted-diff: Rename m_last_send and m_last_recv * test: convert docs into type annotations * log: Prefix log messages with function name if -logsourcelocations is set * [p2p] Small follow-ups to 21528 * test: remove assert_blockchain_height * Set type for "nodes". * [net processing] Remove dropmessagestest * Clean up logging of outbound connection type * Remove m_is_manual_connection from CNodeState * p2p, rpc, test: address rate-limiting follow-ups * Rate limit the processing of incoming addr messages * [avalanche] Use the proof registration state in net processing * [avalanche] Output a proof registration state * [net processing] Do not request transaction relay from feeler connections * test: Move test framework specific constants from messages.py to p2p.py * test: store subversion (user agent) as string in msg_version * Add bounds checking to seeder arguments with integer base types * [p2p] Reduce addr blackholes * [avalanche] Add send_proof test helper. * test: add addr-fetch peer connection state and timeout coverage * [refactor] Remove unused ForEachNodeThen() template * scripted-diff: rename address relay fields * [net processing] Move addr relay data and logic into net processing * [net processing] Make RelayAddress() a member function of PeerManagerImpl * [net processing] Take NodeId instead of CNode* as originator for RelayAddress() * p2p: AddrFetch - don't disconnect on self-announcements * Cleanup of -debug=net log messages * Remove unused access to addpeeraddress RPC output dict element * Net processing: Only call PushAddress() from net_processing * [net processing] Refactor MaybeSendAddr() * [net processing] Refactor MaybeSendAddr() - early exits * [net processing] Change MaybeSendAddr() to take a reference * [net processing] Extract `addr` send functionality into MaybeSendAddr() * [net] Change addr send times fields to be guarded by new mutex * [net processing] Only call GetTime() once in SendMessages() * Only select from addrv2-capable peers for torv3 address relay * Make tx relay data structure use std::chrono types * Make all Poisson delays use std::chrono types * test: Avoid connecting to real network when running tests * test: Use mocktime in test_seed_peers * [p2p] No delay in adding fixed seeds if -dnsseed=0 and peers.dat is empty. Add -fixedseeds arg. * Bump version to 0.24.11 * [Automated] Update seeds * [Automated] Update chainparams * [Cashtab] Added bg color to styled collapse * Periodically make block-relay connections and sync headers * Convert block/header sync timeouts to std::chrono types * Change all ping times to std::chrono types * net: use std::chrono throughout maxOutbound logic * Fix yet another cppcheck issue * util: Allow use of C++14 chrono literals * Handle rename failure in DumpMempool(...) by using RenameOver(...) return value * Remove obsolete NODISCARD ifdef forest. Use [[nodiscard]] * span: update constructors to match c++20 draft spec and add lifetimebound attribute * Rename ping members * [net processing] Move ping data fields to net processing * test: Use Popen.wait instead of RPC in assert_start_raises_init_error * test: fix timeout decrease in feature_assumevalid * test: Remove or explain syncwithvalidationinterfacequeue * tests: Test that a fully signed tx given to signrawtx is unchanged * test: Fix intermittent p2p_fingerprint issue * [Cashtab] Standardize testing regime * Fix a reversed bool flag in the getpeerinfo RPC * [net processing] Move ping timeout logic to net processing * [net processing] Move send ping message logic into function * [net] Add RunInactivityChecks() * [net processing] Add Peer& arg to MaybeDiscourageAndDisconnect() * net_processing: move Peer definition to .cpp * net_processing: move PeerManagerImpl into cpp file * net_processing: split PeerManager into interface and implementation classes * net_processing: make more of PeerManager private * refactor: Remove nMyStartingHeight from CNode/Connman * net: Remove g_relay_txes * net, net_processing: move NetEventsInterface method docs to net.h * net: Move SocketSendData lock annotation to header * net: Move CConnman/NetEventsInterface after CNode in header file * net: Remove unused interrupt from SendMessages * Fix a potential race where the wallet is deleted before stopping the scheduler * [refactor] [net] Clean up InactivityCheck() * [Cashtab] Improve error handling in validation.js * [net processing] Guard m_continuation_block with m_block_inv_mutex * [net processing] Move hashContinue to net processing * Rename vBlockHashesToAnnounce and vInventoryBlockToSend * [net processing] Move block inventory data to Peer * [net processing] Rename nStartingHeight to m_starting_height * [net processing] Move nStartingHeight to Peer * [net processing] Improve documentation for Peer destruction/locking * net processing: Remove nStartingHeight check from block relay * net processing: Move peer_map to PeerManager * [Cashtab] Add css prop to TxLink in TxHistory.js * [Cashtab] Standardize use of Promise.all in useBCH.js * test: Extend functional tests for addr relay * net: don't relay to the address' originator * Clear m_addr_known before our periodic self-advertisement * addrman: Improve performance of Good * util: Make Assume() usable as unary expression * test: speedup wallet_listtransactions by whitelisting peers (immediate tx relay) * [Cashtab] Add bg color ant select-selector * [Cashtab] Add custom styling to Antd Descriptions * Increase the timeout for sending a large block in abc_p2p_fullblocktest * doc, test: Improve setup_clean_chain documentation * [Cashtab] Replace hardcoded colors with references to theme.js * [Cashtab] Extension version bump ------------------------------------------------------------------- Fri Jan 21 18:39:33 UTC 2022 - marec@detebe.org - Update to version 0.24.10: * [tests] Don't restrict MAX_NODES based on the list of pre-computed addresses * fs: Make compatible with boost 1.78 * [Automated] Update timing.json * [Automated] Update seeds * [Automated] Update chainparams * added timezone constant for all npm tests * [Cashtab] Moved opReturnMsg string conversion logic from Tx.js to parseTxData in useBCH.js * [Cashtab] cache api calls with Service Worker * Wrap seeder options in a namespace * Move SetupSeederArgs out of parsing code to make it easier to test * [test] Fix wait condition in disconnect_p2ps * locks: Annotate CTxMemPool::check to require cs_main * refactor: Clean up CTxMemPool initializer list * refactor: Make CTxMemPool::m_check_ratio a const and a constructor argument * refactor: Avoid double to int cast for nCheckFrequency * [tests] Allow outbound & block-relay-only connections in functional tests. * [seeder] Add some useful information about testing in the README * qt: unlock wallet "OK" button bugfix * Bump version to 0.24.10 * [Cashtab] Move parseOpReturn and unit tests to cashMethods * [avalanche] Add a mode to the proof registration to force accept it as a peer * [Cashtab] Add correct dev dependency for ESlint types in jest * Fix an unsigned issue in the availability score calculation * Add an option to override the max addr sent in response to a getaddr message * Unbreak the build with boost 1.78 * [Cashtab] Update snapshots without manual input * [Automated] Update timing.json * [Automated] Update seeds * Update copyright year to 2022 * [Automated] Update chainparams * [Automated] Update chainparams * [Cashtab] formatDate function patch * Make CDnsSeedOpts unit testable * refactor: Extract ParseOpCode from ParseScript * net: Use Span in ReceiveMsgBytes * qt: Hide peer detail view if multiple are selected * Call unicode API on Windows * Make format string linter understand basic template parameter syntax * [Cashtab] Format XEC on send form * test: run mempool_spend_coinbase.py even with wallet disabled * test: use wait_for_{block,header} helpers in p2p_fingerprint.py * test: fix creation of std::string objects with \0s * docs/descriptors.md: Remove hardened marker in the path after xpub * Block unsafe fs::path std::string conversion calls [7/7] * convert unsafe fs::path std::string conversion calls [6/7] (wallet) * convert unsafe fs::path std::string conversion calls [5/7] (util) * convert unsafe fs::path std::string conversion calls [4/7] (test, fuzz, wallet/test) * convert unsafe fs::path std::string conversion calls [3/7] (interfaces, qt, rpc) * convert unsafe fs::path std::string conversion calls [2/7] * convert unsafe fs::path std::string conversion calls [1/7] * refactor: Add fs::PathToString, fs::PathFromString, u8string, u8path functions ------------------------------------------------------------------- Tue Jan 11 18:28:09 UTC 2022 - marec@detebe.org - Update to version 0.24.9: * Remove the deprecated banscore field from the getpeerinfo RPC * Deduplicate deprecation tests * error if settings.json exists, but is unreadable * [net] Remove asmap argument from CNode::CopyStats() * [asmap] Make DecodeAsmap() a utility function * [asmap] Remove SanityCheckASMap() from netaddress * Revert "refactor: remove use of boost::algorithm::replace_first" * [net] Remove CConnman::Options.m_asmap * [avalanche] Move block-vote decision into getAvalancheVoteForBlock. * [Cashtab] Move formatting functions and tests to their own util files * [Cashtab] Disable localization in unit tests * refactor: remove use of boost::algorithm::replace_first * fix client name in dumpwallet output * Fix build with Boost 1.77.0 * [Automated] Update timing.json * [Automated] Update seeds * [avalanche] Store the next possible conflict time for each peer * [avalanche] Return if a proof is bound to a peer in getrawavalancheproof * [Cashtab] Remove dirty param from SendToken formData * [Cashtab] Removed unused var from Send.js. * [Cashtab] Change date format * Remove pointer cast in CRPCTable::dumpArgMap * refactor: Add RPC server ExecuteCommands function * refactor: Replace JSONRPCRequest fHelp field with mode field * [avalanche][trivial] Avoid repeated getId() during proof registration * rpc: Remove duplicate name and argNames from CRPCCommand * rpc: Use RPCHelpMan for check-rpc-mappings linter * rpc: [refactor] Use concise C++11 code in CRPCConvertTable constructor * Change ClearDataDirPathCache() to ArgsManager.ClearPathCache(). * Change GetBlocksDir() to ArgsManager.GetBlocksDirPath(). * scripted-diff: Modify unit tests to use the ArgsManager in the BasicTestingSetup class instead of implicitly relying on gArgs * BasicTestingSetup: Add ArgsManager. * scripted-diff: Replace m_args with m_local_args in getarg_tests.cpp * Modify "util_datadir" unit test to not use gArgs. * Move GetDataDir(fNetSpecific) implementation to ArgsManager. * Move StripRedundantLastElementsOfPath before ArgsManager class. * [Cashtab] Remove legacy prefix validation functions * [Cashtab] Increase Transaction History to 10 transactions * [avalanche][trivial] Fix an obsolete comment in net processing * [Cashtab] OP_RETURN prefix protocols * CConnman: initialise at declaration rather than in Start() * remove CRPCCommand constructor that takes rpcfn_type function pointer * remove dead rpc code * Assert that RPCArg names are equal to CRPCCommand ones (abc, avalanche) * fix mismatching arg names in avalanche RPC commands * [Cashtab] Replace hardcoded param with variable * [Cashtab] Option to send encrypted messages * [Automated] Update timing.json * [Automated] Update seeds * [Automated] Update chainparams * qt, wallet: Drop unused parameter in WalletModel::setWalletEncrypted * qt, wallet: Drop unused parameter in Wallet{Frame|View}::encryptWallet * qt, wallet: Remove unused AskPassphraseDialog::Decrypt * [upgradewallet] removed unused warning param * p2p: avoid calculating onion address checksum when version is not 3 * refactor: use constexpr and remove template * qt: Make transaction notification queue wallet specific * move-only: Define TransactionNotification before TransactionTablePriv * tests: Remove no longer needed UBSan suppressions * cast bool operands to int to silence compiler warning * [secp256k1]refactor: Use (int)&(int) in boolean context to avoid compiler warning * Avoid signed integer overflow when loading a mempool.dat file with a malformed time field * Remove references to CreateWalletFromFile * [Automated] Update timing.json * [Automated] Update seeds * [Automated] Update chainparams * [Cashtab] Refactor address validation to accept prefixless addresses * tests: increase timeout in getnettotals test * Fix change detection of imported internal descriptors * tsan: Suppress epoll_ctl data race * wallet: fix importdescriptor silent fail * net, rpc, test, bugfix: update GetNetworkName, GetNetworksInfo, regression tests * Ignoring (but warn) on duplicate -wallet parameters * minor feerate improvements * [Cashtab] Clear form data on eToken send * cli -netinfo: print oversized/extreme ping times as "-" * cli -netinfo: handle longer tor v3 local addresses * cli -netinfo: make age column variable-width * cli -netinfo: various quick updates and fixes * wallet: Fix bug when just created encrypted wallet cannot get address * [tests] Remove getnettotals/getpeerinfo consistency test * [addrman] Fix Connected() comment * util: Add StripRedundantLastElementsOfPath function * [net] Consolidate logic around calling CAddrMan::Connected() * Avoid test-before-evict evictions of current peers * Call CAddrMan::Good() on block-relay-only peer addresses * Refactor test for existing peer connection into own function * Avoid calling CAddrMan::Connected() on block-relay-only peer addresses * [Cashtab] Add note to alert users to OP_RETURN msg visibility. * [Cashtab] Remove dirty param from formData * [avalanche] Make send_poll test helper accept optional type argument. * test: Fix intermittent wallet_multiwallet issue with got_loading_error * QA: Use getblocktemplate to get block versions correct * QA: blocktools: Accept block template to create_block * [Cashtab] fetchTxDataForNullUtxos array threshold fix * Bump version to 0.24.9 * Disable some tests for tool_wallet when descriptors * Do addmultisigaddress tests in legacy wallet mode in wallet_address_types.py * Make raw multisig tests legacy wallet only in rpc_rawtransaction.py * [Automated] Update timing.json * [Automated] Update seeds * [Automated] Update chainparams * [Cashtab] Remove url checker to complete migration to cashtab.com * [avalanche] Make removeProof easier to reason about by taking a proofid * Refactor ProofPool::addProofIfPreferred * p2p: don't add AlreadyHave transactions to recentRejects * qt: Add WalletFrame::sizeHint * test: Add test for -blockversion * test: Default blockversion to 4 in feature_block * test: Remove unused -blockversion from tests * qt: Wrap tooltips in the intro window * Use importdescriptors when in descriptor wallet mode in wallet_createwallet.py * [Cashtab] Clear amount & address fields on send * Remove createPeer * [Cashtab] New token URL validation * [avalanche] Select the favorite orphan in case of a conflict during a rescan * [Cashtab] Added eToken icon to send page * T1920 - fix excessive API Calls on Tx History Fetching * [Cashtab] Full refactor of the OP_RETURN parsing logic to revolve around bytecounts * [Cashtab] Remove unused imports from Send.js * [Cashtab] Change notification position on mobile * [Cashtab] removed extra spaces on currency ticker * [Docs] Updated app URL at docs.cashtabapp.com ------------------------------------------------------------------- Mon Dec 13 18:07:15 UTC 2021 - marec@detebe.org - Update to version 0.24.8: * [Automated] Update seeds * [Automated] Update chainparams * [Automated] Update timing.json * [avalanche] Select the favorite conflicting proof * [avalanche] Select the favorite orphan in case of a conflict * [avalanche] Create a conflicting proof pool * run rpc_signrawtransaction with --descriptors * Move import and watchonly tests to be legacy wallet only in wallet_balance.py * Avoid dumpprivkey in wallet_listsinceblock.py * Bump version to 0.24.8 * [avalanche] Add a facility to replace a proof in the pool * Make import tests in wallet_listtransactions.py legacy wallet only * Use a separate watchonly wallet in rpc_fundrawtransaction.py * Update wallet_importprunedfunds to avoid dumpprivkey * [Cashtab] Remove unused var from useBCH * [Cashtab] Renamed FormItemWithMaxAddon * [Cashtab] Send multi-recipient XEC transaction * [Cashtab] Support New Zealand Dollar * Add testnet status.cash seeder to chainparams * [Cashtab] Removed unused var from useWallet.js * tests: fix a few misuses of Decimal * Use decimal objects for fees in mempool_accept.py * Implement SQLiteDatabase::MakeBatch * Implement SQLiteDatabase::Verify * Implement SQLiteDatabase::Rewrite * Implement SQLiteDatabase::TxnBegin, TxnCommit, and TxnAbort * Implement SQLiteDatabase::Backup * [Cashtab] Overhaul the addGenerated.sh script * [avalanche] Use the ProofPool multi index to store the orphan proofs * gui: Call setWalletActionsEnabled(true) only for the first wallet * [Cashtab] Added support for AUD * [avalanche] Make the proof pool internal container private * [Cashtab] Rename FormItemWithQRCodeAddon * [Cashtab] Support Saudi Riyal * [Cashtab] fix typo on new wallet screen * [Cashtab] Add reply message function * [Cashtab] add publicKey property for each of the Path in the wallet * [Cashtab] update "Migrate legacy wallet on testnet" unit test * [Cashtab] Support Bahraini Dinar * [Automated] Update timing.json * net: fix output of peer address in version message * [avalanche] Improve the peer manager verify() method * build: remove mingw linker workaround from win gitian descriptor * [avalanche] Add a rescan method to the ProofPool * [avalanche] Add a ProofPool getProof accessor to retrieve a proof from its id * [avalanche] Add wrappers to add and remove a proof from a proof pool * [Cashtab] Bumping extension version and synchronizing styles * [Cashtab] Add support for HKD * zmq test: fix flakiness by using more robust sync method * zmq test: accept arbitrary sequence start number in ZMQSubscriber * zmq test: dedup message reception handling in ZMQSubscriber * zmq test: deduplicate test setup code (node restart, topics subscription) * [avalanche] Move the ProofPool definition to its own header * add the ability to lock / unlock the wallet with user's device platform autheticator * [Cashtab] Refactor token icon link * [Cashtab] Add support for New Taiwan Dollar * [Cashtab] Remove unused imports from useWallet * fix gitian-win build * test: Move (dis)?connect_nodes globals into TestFramework * test: Replace (dis)?connect_nodes globals with TestFramework methods * test: Replace use of (dis)?connect_nodes globals * [Cashtab] Implement standardized eCash prefixes in OP_RETURN transactions * Support NODE_NETWORK_LIMITED filtering by default * [Cashtab] Instructions for adding icon to pre-existing token * [Cashtab] Add support for Chilean Peso * [Cashtab] run auto @generated script posttest * [Cashtab] Add support for ILS * test: Add BerkeleyDatabase tsan suppression * [avalanche] Introduce the ProofPool multi index structure * [avalanche] Rename isValid => isBoundToPeer * [avalanche] Simplify the proof verification code in the peer manager * [avalanche] Don't create invalid proofs in the conflicting_proof_selection test * Implement SQLiteBatch::StartCursor, ReadAtCursor, and CloseCursor * Implement SQLiteBatch::ReadKey, WriteKey, EraseKey, and HasKey * Add SetupSQLStatements * Implement SQLiteBatch::Close * Implement SQLiteDatabase::Close * Implement SQLiteDatabase::Open * Initialize and Shutdown sqlite3 globals * Constructors, destructors, and relevant private fields for SQLiteDatabase/Batch * Implement SQLiteDatabaseVersion * Add SQLiteDatabase and SQLiteBatch dummy classes * add a wallet dependency to sqlite3 * [Cashtab] Support custom eToken icons * [Cashtab] Add support for Philippine Peso * Warn on unknown rw_settings * Fix intermittent issue in wallet_import_rescan & wallet_send * random: fixes read buffer resizing in RandAddSeedPerfmon * refactor: Clean up -Wlogical-op warning * scripted-diff: rename vRecvGetData * Guard vRecvGetData (now in net processing) with its own mutex * Move vRecvGetData to net processing * Lock before checking if orphan_work_set is empty; indicate it is guarded * Move m_orphan_work_set to net_processing * [Rename only] Rename orphan_work_set to m_orphan_work_set. * test: add logging for mining_getblocktemplate_longpoll.py * test: remove unused helpers random_transaction(), make_change() and gather_inputs() * test: use MiniWallet for mining_getblocktemplate_longpoll.py * Only update the updateSmartFeeLabel once in sync ------------------------------------------------------------------- Thu Nov 25 17:44:44 UTC 2021 - marec@detebe.org - Update to version 0.24.7: * [avalanche] Rename the peer set tag proof_index => by_proofid for consistency * [Cashtab] Interim fix for invalid hex behaviors * [Automated] Update timing.json * [Automated] Update seeds * [Cashtab] Additional tests on OP_RETURN utxos to confirm they can be included in non-eToken utxo set * [Automated] Update chainparams * [Cashtab] Convert OP_RETURN input into TextArea * [Cashtab] move newTokenDocumentUrl to Ticker.js * RPC: getpeerinfo: Deprecate "whitelisted" field (replaced by "permissions") * refactor: enable -netinfo to add future networks (i2p, cjdns) * refactor: promote some -netinfo localvars to class members * cli: simplify -netinfo using getpeerinfo network field * rpc, test: expose CNodeStats network in RPC getpeerinfo * net: add peer network to CNodeStats * doc: Add anchors.dat to files.md * p2p: Try to connect to anchors once * p2p: Fix off-by-one error in fetching address loop * p2p: Integrate DumpAnchors() and ReadAnchors() into CConnman * p2p: Add CConnman::GetCurrentBlockRelayOnlyConns() * p2p: Add ReadAnchors() * p2p: Add DumpAnchors() * [avalanche] Turn fetchOrCreatePeer into createPeer * Fix several -Wdeprecated-copy warnings * test: Remove unused nVersion=1 in p2p tests * [Cashtab] Enhance message display UI * [Cashtab] corrected link in CreateTokenForm.js * [Cashtab] Add ability to send an OP return msg in a tx * [Cashtab] Fix DOM warnings in browser console for message signing properties * [Cashtab] Upgrade transaction history to parse and display OP_RETURN messages * -[Docs] copyedit docs title * [doc] Add two articles to CONTRIBUTING.md * [doc] Fix link to article in CONTRIBUTING.md * [avalanche] Make `isConflictingProofPreferred` a comparator * [avalanche] Store proofs associated with utxos instead of peer ids * [avalanche] Improve the conflicting proof selection algorithm * [avalanche] Remove getPeerId * [Automated] Update seeds * [Automated] Update chainparams * [Cashtab] Add transparent padding to eCash logo * net: Send post-verack handshake messages at most once * wallet: remove db mode string * [validation] Remove absurdfee from accepttomempool * update max-fee-exceeded error message to include RPC * [rpc/node] check for high fee before ATMP in clients * [BroadcastTransaction] Remove unsafe move operator * Bump version to v0.24.7 ------------------------------------------------------------------- Tue Nov 16 18:07:00 UTC 2021 - marec@detebe.org - Update to version 0.24.6: * Add a release note for the 0.24.6 checkpoint * Add a checkpoint for the november 15th 2021 upgrade * Bump version to 0.24.6 * test: Add tests for CNode::ConnectedThroughNetwork * net: Add CNode::ConnectedThroughNetwork member function * net: Add CNode::m_inbound_onion data member * test: add p2p_lock acquires in p2p_leak_tx.py * test: use MiniWallet for p2p_leak_tx.py * Avoid the use of abs64 in timedata * [Cashtab] Cosmetic update for message signing component * [Automated] Update timing.json * [Automated] Update seeds * [Automated] Update chainparams * doc: Update onion service target port numbers in tor.md * net: Extend -bind config option with optional network type * net, refactor: Move AddLocal call one level up * net: Pass onion service target to Tor controller * refactor: Rename TorController::target to m_tor_control_center * net, refactor: Refactor CBaseChainParams::RPCPort function * net: Add alternative port for onion service * net: Use network byte order for in_addr.s_addr * BIP155 follow-ups * rpc: change no wallet loaded message to be clearer * [Cashtab] Bump extension version * [Cashtab] add message signing function * Revert "[Cashtab] Auto add latest commit hash to configure" * [Cashtab] Auto add latest commit hash to configure * [Cashtab]edited readme copy * [Automated] Update timing.json * [Automated] Update seeds * [Automated] Update chainparams * RPC: remove duplicate line in getblock help * util: Do not use gArgs global in ArgsManager member functions * net: rename CNetAddr scopeId to m_scope_id, improve code doc * test: add test coverage for CNetAddr ipv6 scoped addresses * Improve invalid vout value rpc error message * test: Get rid of default wallet hacks * test, refactor: add default_wallet_name and wallet_data_filename variables * doc: Clarify scope of eviction protection of outbound block-relay peers * rpc: Set HTTP Content-Type in bitcoin-cli * [tests] Replace bytes literals with hex literals * [tests] Remove unused optional verify_checksum parameter * ProcessOrphanTx: Remove aliases * ProcessOrphanTx: Remove outdated comment * ProcessOrphanTx: remove useless setMisbehaving set * ProcessOrphanTx: remove useless done variable * [net processing] Add doxygen comments for orphan data and function * Fix misleading error message: Clean stack rule * [Cashtab] updated screenshots * [Cashtab]Auto add @generated to top of updated snapshot files * [avalanche] Slightly reduce cs_main scope in registerVotes * [avalanche] Avoid O(n2) when voting on proofs * Improve docs about feeler connections * [Cashtab] Styling Update * [Cashtab] notification duration set as app parameter * log: Remove static log message "Initializing chainstate Chainstate [ibd] @ height -1 (null)" ------------------------------------------------------------------- Fri Oct 29 16:58:08 UTC 2021 - marec@detebe.org - Update to version 0.24.5: * net: Print error message if -proxy is specified without arguments (instead of continuing without proxy server) * Send RPC and touch-ups * [Cashtab] Update hardcoded references to the old cashtabapp.com domain * [Cashtab] Convert calculated fiat amount string to locale string * [Cashtab] Nav menu fix post label rebrand * [Cashtab] Make the header balance a localeString * [Cashtab]css bug patch * [Cashtab] notification success & notification error added to Notifications.js * [rpc] Deprecate getpeerinfo addnode field * [refactor] Rename test file to allow any getpeerinfo deprecations. * [rpc] Add connection type to getpeerinfo RPC, update tests * [log] Add connection type to log statement * [Automated] Update seeds * [avalanche] Select if a conflicting proof should be preferred * [avalanche] Factorize the inflight request timeout handling * [avalanche] Make the proof builders build a ProofRef * [avalanche] Determine proof acceptance status from the peer manager * [avalanche] Orphan the conflicting proofs rather than ignoring them * [avalanche] Refactor the vote records to inv extraction loop * [avalanche] Remove the invalid peers before the orphans rescan * [avalanche] Clarify the proof accessor API * Overwrite db services with version message results * Add status.cash seeder to chainparams * [Cashtab] Do not throw API error utxo with null isValid * Bump version to 0.24.5 * [Automated] Update timing.json * [Automated] Update seeds * [Automated] Update chainparams * [Cashtab] Rebranding Token menu/button labels into eToken * [Cashtab] Remove Prettier from dependency tree and align formatting in Web folder * [avalanche] Check utxos integrity in the peer manager * [avalanche] Decode the payout script and proof signature in the decodeavalancheproof RPC * [avalanche] Don't reserve a slot for block voting ------------------------------------------------------------------- Fri Oct 22 11:43:19 UTC 2021 - marec@detebe.org - Update to version 0.24.4: * [Automated] Update timing.json * [Automated] Update seeds * [Automated] Update chainparams * Remove extra brackets * [avalanche] Split the AvalancheProof class into legacy and regular in the test framework * Move the current release notes to the doc folder * Move `GetAllOutputTypes()` to rpc/utils * [avalanche] Make ProofRef a shared pointer to a const proof * [avalanche] Introduce ProofRef as an alias for std::shared_ptr<Proof> * [avalanche] Make the proof comparator able to work with proofs and proof pointers * test: Check that invalid peer traffic is accounted for * [Cashtab] Disable cash address highlighting and copying * Set result_emulated to a value that is known to be wrong in intmath_tests.cpp * [avalanche] Convert the test utils to use proof shared pointers * Use using instead of typedef for CTransactionRef * feature: Added ability for users to add a startup command * test: remove unused constants in functional tests * test: use _ variable for unused loop counters (follow-up) * test: use explicit p2p objects where available * Assert that RPCArg names are equal to CRPCCommand ones (net, rpcwallet) * fix CRPCCommand args in rpcwallet.cpp * [avalanche] Only sign the subset of data we want to commit the stakes to * fix a flake8 vs autopep8 interference * test: various style improvements to abc-segwit-recovery.py * [test] remove confusing p2p property * replace p2p with p2ps[0] in p2p_invalid_tx * [doc] sample code for test framework p2p objects * [refactor] clarify abc* tests by referencing p2p objects directly * [refactor] clarify tests by referencing p2p objects directly * zmq: Add support to listen on multiple interfaces * [avalanche] Sign the avalanche proof * add a release note for -zmqpubsequence * test: test mempool rejection in interface_zmq.py * contrib: correct version check * Update zmq notification documentation and sample consumer * Add functional tests for zmq sequence topic and mempool sequence logic * Use Flags enum in AddArg() (follow-up) * Add 'sequence' zmq publisher to track all block (dis)connects, mempool deltas * zmq test: Actually make reorg occur * Fix the check-seeds.sh wrong evaluation of the live nodes * alert for browsers not using english language * test: Add race:SendZmqMessage tsan suppression * zmq: enable tcp keepalive * [Cashtab] Domain move * prevent translation of wallet names * Remove an old boost workaround * Assert that RPCArg names are equal to CRPCCommand ones (rawtransaction) * Assert that RPCArg names are equal to CRPCCommand ones (blockchain) * test: add parameterized constructor for msg_sendcmpct() * Do not include util/system.h and util/translation.h from proof.h * Rename voteItemTestingContexts => voteItemProviders, because they provide vote items * Remove the remove_reference_t business from VoteItemUpdate * Fix abc-invalid-message.py flakiness * [avalanche] Use a consistent and well known proof master in proof tests * [avalanche] Limit the number of inflight proof poll requests * [avalanche] Clear timed out proof poll requests * [avalanche] Register votes on conflicting proofs * [avalanche] Convert the poll_and_response test to use context * [avalanche] Retrieve the acceptance status and confidence of the proof vote records * [avalanche] Convert the multi_block_register test to use the context * [avalanche] Introduce a test context in the processor tests * [avalanche] Extract a template class from BlockUpdate * Clarify blocksonly whitelistforcerelay test * test: remove copy-pasted tip() function when unused * Refactor p2p_getaddr_caching.py * Address nits in ADDR caching * Add indexing ADDR cache by local socket addr * Justify the choice of ADDR cache lifetime * test: gettxoutproof duplicate txid * test: Test empty array in gettxoutproof * test: Run rpc_txoutproof.py even with wallet disabled * test: MiniWallet: Default fee_rate in send_self_transfer, Pass in utxo_to_spend * test: Mockwallet * make pad_tx produce the correct size when possible * Rename SendMessage to SendZmqMessage. * Replace zmqconfig.h by a simple zmqutil. * Use std::unique_ptr for CZMQNotifierFactory. * Simplify and fix notifier removal on error. * Various cleanups in zmqnotificationinterface. * gui: Improve thread naming * [rpc] Return fee and size from testmempoolaccept * [rpc] add send method * [rpc] add snake case aliases for transaction methods * [rpc] walletcreatefundedpsbt: allow inputs to be null * [avalanche] Split the poll_and_response test in two * [avalanche] Split block_register test in two cases * Remove the automatic creation and loading of the default wallet * [Cashtab] Add domain migration alert pop-up * [Cashtab] Prevent translation of address prefix * test: use OP_TRUE p2sh address in p2p_permissions * Bump version to 0.24.4 * use the correct rounding in assert_fee_amount * convert amounts to XEC in RPC examples * [Cashtab] display balances for saved wallets * [avalanche] Turn the vote registration logic into a generic lambda * bugfix: make LoadWallet assigns status always * wallet: Remove path checking code from bitcoin-wallet tool * wallet: Remove path checking code from createwallet RPC * wallet: Remove path checking code from loadwallet RPC * refactor: Pass wallet database into CWallet::Create * wallet: Remove Verify and IsLoaded methods * refactor: Use DatabaseStatus and DatabaseOptions types * wallet: Add MakeDatabase function * Remove WalletLocation class * Add a --descriptors option to various tests * Test batch rpc with params * Change CSipHasher's count variable to uint8_t ------------------------------------------------------------------- Tue Oct 05 05:26:54 UTC 2021 - marec@detebe.org - Update to version 0.24.3: * [avalanche] Extract the vote status in an enum class * [avalanche] Move the vote eror codes to its own enum class * [avalanche] Fix some naming nits * [avalanche] Add conflicting proofs to the vote * [avalanche] Add a comparator for proof shared pointers * remove unused create_tx_with_script in a couple of tests * doc: update PyZMQ installation instructions, ZeroMQ link * Use constants in seeder help text * [avalanche] Make regular proof format deserialization tests in par with the legacy * [avalanche] Rename vote_records to blockVoteRecords in the processor * [Automated] Update timing.json * [Automated] Update seeds * [Automated] Update chainparams * Add --address, bind to specific address * add a linter for python imports * sort python imports in remaining test_framework and misc files * sort python imports in wallet_* functional tests * sort python imports in rpc_* functional tests * sort python imports in p2p_* functional tests * Sort imports in interface_*, mining_* and mempool_* functional tests * sort python imports in feature_* functional tests * sort python imports in abc* functional tests with isort * refactor: Add BerkeleyDatabaseVersion() function * [avalanche] Explicitely set the legacy format where expected * test: Remove RPCOverloadWrapper boilerplate * [avalanche] Introduce the StakeCommitment class * Do not pass chain params to CheckForStaleTipAndEvictPeers twice * wallet: fix scanning progress calculation for single block range * Recommend port 15353 when running in user space * wallet: Reload previously loaded wallets on GUI startup * Add loadwallet and createwallet RPC load_on_startup options * Remove mapLinks in favor of entry inlined structs with iterator type erasure * remove CChainParams from wallet methods that don't need it * wallet: Avoid multiple BerkeleyBatch in DelAddressBook * Fix incorrect comment in intmath_tests.cpp * [CI] Fix the OSX cross build * [SECP256K1] Use the appropriated debian version on CI * Add AddInt63Overflow and SubInt63Overflow * refactor: Remove negative lock annotations from globals * [avalanche] Let buildavalancheproof take a payout address * [avalanche] Add a payout script to the proof * refactor: remove unused header <arpa/inet.h> in protocol.cpp * test: Fix flaky wallet_basic test * Increase the ip address relay branching factor for unreachable networks * refactor: Avoid duplicate map lookup in ScriptToAsmStr * rpc, cli: add network in/out connections to getnetworkinfo and -getinfo * [Automated] Update timing.json * [Automated] Update seeds * [Automated] Update chainparams * [cashtab docs] preliminary rebrand * rawtransaction: fix argument in combinerawtransaction help message * Avoid locking CTxMemPool::cs recursively in simple cases * wallet: Avoid deserializing unused records when salvaging * test: Remove unused lock arg from BitcoinTestFramework.wait_until * test: Rename wait until helper to wait_until_helper * Remove unused LockAssertion struct * Replace LockAssertion with a proper thread safety annotations * refactor: Use explicit function type instead of template * doc: Add best practice for annotating/asserting locks * sync.h: Make runtime lock checks require compile-time lock checks * Do not hide compile-time thread safety warnings * Add missed thread safety annotations * Use LockAssertion utility class instead of AssertLockHeld() * Remove -zapwallettxes * Bump version to 0.24.3 * Avoid callback when -blocknotify is empty * Add Muhash3072 implementation in Python ------------------------------------------------------------------- Tue Sep 21 11:40:19 UTC 2021 - marec@detebe.org - Update to version 0.24.2: * rpc: Assert that RPCArg names are equal to CRPCCommand ones (rpcdump) * factor two very similar error messages * rpc: Assert that RPCArg names are equal to CRPCCommand ones (zmq) * rpc: Assert that RPCArg names are equal to CRPCCommand ones (mining) * rpc: Remove unused return type from appendCommand * Fix RPC help for dumptxoutset * remove unnecessary newline at the start of RPC help descriptions * [rpc] fundrawtransaction, walletcreatefundedpsbt lock manually selected coins * gui refactor: Inline SplashScreen::ConnectWallet * refactor: Move wallet methods out of chain.h and node.h * refactor: Create interfaces earlier during initialization * Make all CRPCCommand actors take a const Config & * doc: Document differences in bitcoind and bitcoin-qt locale handling * test: Add tsan supp for leveldb::DBImpl::DeleteObsoleteFiles * Add visual accenting for the 'Create new receiving address' button * Remove old check for 3-byte shifted IP addresses from pre-0.2.9 node messages * Send BIP37 fRelay as false * [Cashtab] Patch decimal parsing of params in wallet, extension, and components * Fix spelling of "unreachable" in OP_CHECKMULTISIG * test: Update wait_until usage in abc tests not to use the one from utils * test: Update wait_until usage in tests not to use the one from utils * chain: Remove UB CChain comparison * gui: Clarify block height label * rpc: Validate provided keys for query_options parameter in listunspent * test: nits in TestChain100Setup * [test] Add test for getblockheader verboseness * Remove a trailing comma in a linter * [Automated] Update timing.json * [Automated] Update chainparams * [Automated] Update seeds * docs: Correct description for getblockstats's txs field * Move comment about BaseIndex::DB from TxIndex::DB * rpc: Add getindexinfo RPC * test: Remove unused classes from p2p_leak.py * fix compiler warning "Declaration shadows a local variable" * doc: Fix getmempoolancestor RPC result doc * refactor: make EncodeBase58{Check} consume Spans * build: Enable some commonly enabled compiler diagnostics * Move only: Move CDiskTxPos to its own file * test: p2p_feefilter improvements (logging, refactoring, speedup) * test: Remove confusing and broken use of wait_until global * Fix a compiler warning: unused GetDevURandom() * Cleanup Bitcoin Cash user agents in seeder tests * Set seeder user agent in a similar way to the node * Rebrand seeder to eCash * rpc generate: print useful help and error message * -maxapsfee: follow-up fixes * [avalanche] Fix extended tests that use buildavalancheproof * wallet: Avoid recursive lock in IsTrusted * wallet, refactor: Immutable CWalletTx::pwallet * wallet: IsChange requires cs_wallet lock * wallet: IsMine overloads require cs_wallet lock * wallet: GetWalletTx requires cs_wallet lock * wallet, refactor: Remove duplicate map lookups in GetAddressBalances * [avalanche] Improve invalid-signature error message accuracy * [avalanche] Pass a CKey to the proof builder * [avalanche] Add an error message for duplicated stakes in buildavalancheproof * [avalanche] Consistently check ProofBuilder::addUTXO return value * [avalanche] Use an ordered container for stakes in the proof builder * [avalanche] Sort the stakes inside a proof * [Cashtab] correct error in parsing tx history for op ret txs * remove argName nBlocks from estimatefee RPC command registration * [Cashtab] Ignore tx history for large-input txs * rpc: document returned error fields as optional if applicable * Refactor OutputGroups to handle effective values, fees, and filtering * Use real value when calculating OutputGroup value * wallet: Don't override signing errors * rpc: Assert that RPCArg names are equal to CRPCCommand ones (misc) * rpc: Limit echo to 10 args * refactor: Use C++11 range based for loops to simplify rpc code * rpc: Treat all args after a hidden arg as hidden as well * rpc: Update server to use new RPCHelpMan * rpc: Add option to hide RPCArg * rpc: Assert that passed arg names are equal to hardcoded ones * rpc: Add CRPCCommand constructor which takes RPCHelpMan * [avalanche] Add some test coverage for the buildavalancheproof RPC * [avalanche] Remove dead test code in the proof builder * Add TX_INPUTS_NOT_STANDARD to TxValidationResult * [Automated] Update timing.json * [Automated] Update seeds * [Automated] Update chainparams * rpc: Improve addnode remove command error message * Cap listsinceblock target_confirmations param * [net] Add addpeeraddress RPC method * [test] Test that getnodeaddresses() can return all known addresses * [addrman] Specify max addresses and pct when calling GetAddresses() * refactor: test: use _ variable for unused loop counters * Deduplicate missing parents of orphan transactions * Rewrite parent txid loop of requested transactions * test: Wait for 'cmpctblock' in p2p_compactblocks when it is expected * test: Wait until is_connected in add_p2p_connection * test: use the correct DISCOURAGEMENT_THRESHOLD * doc: Replace `hidden service` with `onion service` * util: use HAVE_FDATASYNC to determine fdatasync() use * Preserve the LockData initial state if "potential deadlock detected" exception thrown * rpc: Document getwalletinfo's unlocked_until field as optional * Test addr response caching * Add addr permission flag enabling non-cached addr sharing * Cache responses to addr requests * Remove useless 2500 limit on AddrMan queries * Move filtering banned addrs inside GetAddresses() * Remove Reference Links * rpc: RPCResult Type of MempoolEntryDescription should be OBJ. * Clean message_count and last_message * walletdb: Ensure that having no database handle is a failure * Remove BDB dummy databases * Introduce DummyDatabase and use it in the tests * walletdb: Remove BerkeleyBatch friend class from BerkeleyDatabase * No need to check for duplicate fileids in all dbenvs * walletdb: Move Db->open to BerkeleyDatabase::Open * walletdb: track database file use as m_refcount within BerkeleyDatabase * Combine BerkeleyEnvironment::Verify into BerkeleyDatabase::Verify * Update the signed message prefix to eCash * Bump version to 0.24.2 * [Cashtab] Patch bug in address display ------------------------------------------------------------------- Mon Sep 06 06:14:40 UTC 2021 - marec@detebe.org - Update to version 0.24.1: * tests: use common NodeContext in wallet_tests.cpp::ZapSelectTx * tests: Represent proof IDs as hex strings when sync_proofs fails * walletdb: Introduce WalletDatabase abstract class * walletdb: Add BerkeleyDatabase::Open dummy function * walletdb: Introduce AddRef and RemoveRef functions * walletdb: Move BerkeleyDatabase::Flush(true) to Close() * log: Avoid treating remote misbehvior as local system error * replace MAX_BLOCKS_ONLY_CONNECTIONS with MAX_BLOCK_RELAY_ONLY_CONNECTIONS * test: fix intermittent p2p_ibd_txrelay race, add test_framework.py#wait_until * Remove unnecessary blockfile SetPos * [avalanche] Make gen_proof facility return the key object * [avalanche] Move gen_proof to avatools * rpc: deduplicate WriteHDKeypath() used in decodepsbt * [test] feefilter during and after IBD * Dump transaction version as an unsigned integer in RPC/TxToUniv * [Automated] Update timing.json * [Automated] Update seeds * [Automated] Update chainparams * rename movie folder to animation * gui: Show permissions instead of whitelisted * rpc: Check that left section is not multiline * [Cashtab] Add props validation and clean up resulting lint errors * qt: Get rid of cursor in out-of-focus labels * Call SHA256AutoDetect in benchmark setup * walletdb: Add MakeBatch function to BerkeleyDatabase and use it * walletdb: Refactor DatabaseBatch abstract class from BerkeleyBatch * test: improve mempool_updatefromblock efficiency by using getmempoolentry for specific txns * [LINTER] Replace unsigned short with uint16_t * test: Speed up wallet_resendwallettransactions test with mockscheduler RPC * refactor: Use uint16_t instead of unsigned short * Fix rebase issue that introduced a linter error * [rpc] refactor: consolidate sendmany and sendtoaddress code * log: Properly log txs rejected from mempool * [Cashtab] Standard component for API error msg * doc: Add non-thread-safe note to FeeFilterRounder::round() * Disable the main window toolbar when the modal overlay is shown * wallet: Fix typo in comments; Simplify assert * walletdb: don't reinitialize desc cache with multiple cache entries * Fix ZapSelectTx to sync wallet spends * cli: reduce DefaultRequestHandler memory allocations * qt: Reset toolbar after all wallets are closed * qt: increase console command max length * wallet: Replace CDataStream& with CDataStream&& where appropriate * wallet: Remove confusing double return value ret+success * Revert "test: Show debug log on unit test failure" * test: Test gettxouttsetinfo hash_type option * rpc: Add hash_type NONE to gettxoutsetinfo * rpc: gettxoutsetinfo can specify hash_type (only legacy option for now) * refactor: Extract GetBogoSize function * test: Show debug log on unit test failure * trivial: Suggested cleanups to surrounding code * wallet: Minimal fix to restore conflicted transaction notifications * lint: Add std::locale::global to list of locale dependent functions * refactor: Remove confusing OutputType::CHANGE_AUTO * remove use of getDefaultChangeType in paymentserver.cpp * doc: Remove outdated comment in TransactionTablePriv * test: Add test for conflicted tx notifications * refactor: Fix clang compile failure * doc: Use precise permission flags where possible * net: Remove forcerelay of rejected txs * walletdb: Handle cursor internally * doc: Span pitfalls * gui: change combiner for signals to optional_last_value * test: improve functional tests compatibility with BSD/macOS * wallet: Handle concurrent wallet loading * doc/REST-interface: Remove stale info * doc: Switch scheduler to doxygen comments * scheduler: Replace stop(true) with StopWhenDrained() * doc: Remove unused documentation about unimplemented features * doc: Switch boost::thread to std::thread in scheduler * test: Remove unused scheduler.h include from the common setup * scheduler: Remove unused REVERSE_LOCK * wallet: Check size after unserializing a pubkey * doc: add release note for bitcoin-cli -generate * Bump version to 0.24.1 * refactor: Make CScriptVisitor stateless * rpc: add missing space in JSON parsing error message, update test * test: add multiwallet tests for bitcoin-cli -generate * cli: add multiwallet capability to GetNewAddress and -generate * test: add tests for bitcoin-cli -generate * cli: create bitcoin-cli -generate command * cli: extract ParseResult() and ParseError() * cli: create GenerateToAddressRequestHandler class * cli: create GetNewAddress() * rpc: make generatetoaddress locals const * rpc: create rpc/mining.h, hoist default max tries values to constant * remove [[mabye_unused]] annotation for GetWalletBalances * Change docs for walletcreatefundedpsbt RPC method * Make SeparatorStyle a scoped enum * Add means to handle negative capabilities in thread safety annotations * wallet: error if an explicit fee rate was given but the needed fee rate differed * [Automated] Update timing.json * [Automated] Update chainparams * [Automated] Update seeds * [Cashtab] Bring extension in line with latest prod version * [tests] move generate_wif_key to wallet_util.py * gui: Add Close All Wallets action * qt: Display warnings as rich text * wallet: Fix for exported confirmation field in payment to self transactions * Always define the raii_event_tests test suite * qt: Ensure that ModalOverlay is resized properly * qt: Remove QFont warnings with QPA=minimal * Add AddInt63OverflowEmulated and SubInt63OverflowEmulated * gui: Disable unavailable context menu items in transactions tab * qt: Rename slot to updateDisplayUnit() * qt: Overhaul ReceiveRequestDialog * qt: change BCH to XEC in QLabel's default text * test: Add p2p test for forcerelay permission * qt: Add privacy feature to Overview page * qt: Add BitcoinUnits::formatWithPrivacy() function * Do not expose and consider -logthreadnames when it does not work * test: Bump timeout in wallet_import_rescan * test: Explain why test logging should be used * doc: Describe log files + consistent paths in test READMEs * Prevent processing duplicate payment requests * GUI: If BIP70 is disabled, attempt to fall back to BIP21 parsing * Set init stop timeout to 10 min * [rpc] Fix broken bitcoin-cli examples * util: Filter out macOS process serial number * [doc] developer-notes.md: point out that UniValue deviates from upstream * docs: Update Transifex and doxygen links * test: add missing #include * gui: Fix unintialized WalletView::progressDialog * [Cashtab] Better looking notifications * [Cashtab] Support token tx parsing from HD wallet * [Cashtab] Remove legacy utxos state field from useWallet.js * [Cashtab] Deprecate obsolete websocket support * [Cashtab] Show fiat amount of incoming XEC txs ------------------------------------------------------------------- Wed Aug 25 08:23:48 UTC 2021 - marec@detebe.org - Update to version 0.24.0: * Bump version to 0.24.0 * [Cashtab] Remove legacy walletState parameter * [Cashtab] Replace SLP with eToken in token tx notification * [Cashtab] Add space before ticker in tx history * [Cashtab] Deprecate cashaddrjs for ecashaddrjs * [Cashtab] Handle unconfirmed genesis tx * Bump replay protection to may 2022 * [Cashtab] Fix bug where new user sees permanent loading screen * [Cashtab] Move price API to coingecko rebrand * [Cashtab] Remove unused function export * [Cashtab] remove unused imports and functions from Wallet.js * [Cashtab] Match UI locking pattern of rest of app in Tokens.js * [Cashtab] Standardize use of wallet state parameters * refactor: use structured binding instead of first/second in processor_tests * refactor: allow constructing a valid CKey in place * [Automated] Update timing.json * [Automated] Update seeds * [Automated] Update chainparams * [Cashtab] Remove support for sending to BCH or SLP addresses * [Cashtab] Remove unused artifact params from Send.js * [Cashtab] Remove legacy address display * [Cashtab] add support for BRL and INR fiat * [avalanche] Move the VoteRecord to its own header * Replace boost::shared_mutex and shared_lock with their std:: equivalent in rwcollection.h * [Cashtab] Lock full UI when utxo set is loading after send * ecash: make XEC/eCash the default * tests: make bitcoin-tx test using ecash=1 * Prepare docs for 0.24.0 * [Cashtab] Lock nav UI while new settings are loading * [Cashtab] Clean up react component code * [avalanche] Protect nodes with high availability score from eviction * Remove outdated comment in radix.h * [Automated] Update timing.json * [Automated] Update seeds * [Automated] Update chainparams * [Cashtab] Bump min tx fee to preserve extra token check * [Cashtab] Move balance header fiat to its own component * Introduce EraseLastKElementsIf to simplify the node eviction code * [Cashtab] Moving BalanceHeader to stand alone component * [avalanche] Reduce dependency to net.h from avalanche * [avalanche] Clarify processor dependency to net.h * [avalanche] Remove the (node) PeerManager member from the avalanche processor * [avalanche] Complete the full node eviction test * [CMAKE] Prevent a false positive warning due to CMP0116 ------------------------------------------------------------------- Tue Aug 10 13:50:30 UTC 2021 - marec@detebe.org - Update to version 0.23.10: * Bump version to 0.23.10 * [Cashtab] Prevent auto-capitalization of mnemonic seeds * [cashtab] Remove fbt and I18n from app and extension * [Cashtab] add support for additional fiat currencies * [avalanche] Compute a node activity score * [Cashtab] remove price api order of magnitude error check * [avalanche] Move testing the getavalanchepeerinfo RPC to its own test * [Automated] Update timing.json * [Automated] Update seeds * [Automated] Update chainparams * [Cashtab] Show correct fiat on token creation error msg * [Automated] Update timing.json * [Automated] Update chainparams * [Automated] Update seeds * [doc] start a developer documentation for avalanche * [avalanche] Protect from eviction nodes that relayed new proofs * [avalanche] Fix the getavalanchepeerinfo help * Do not specify a line/char for prettier when not apropriate * [LINTER] Handle errors from the Prettier linter * [Cashtab] Add support for multiple fiat currencies ------------------------------------------------------------------- Sun Aug 01 17:16:01 UTC 2021 - marec@detebe.org - Update to version 0.23.9: * add some release notes for 0.23.9 * init: use std::thread for ThreadImport() * Improve the p2p_inv_download test by using a mocked time * [Automated] Update timing.json * [Automated] Update chainparams * [Automated] Update seeds * test: whitelist rpc_rawtransaction peers to speed up tests * make copyright headers more consistent * rpc_net.py: sync blocks before mining a new block on node1 * validation: Remove review-only comments + assertions * docs: Move FindFilesToPrune{,Manual} doxygen comment * validation: Move FindFilesToPrune{,Manual} to BlockManager * validation: Move PruneOneBlockFile to BlockManager * validation: Pass in chainman to UnloadBlockIndex * validation: Move ~CMainCleanup logic to ~BlockManager * [avalanche] Track the time of the last new proof received * [avalanche] Fix downloading proofs from peers that just inv'ed us * Rebrand the comments in wallet_avoidreuse.py * Rebrand comments from C++ source files * copyright-header: add two expected holder names * scripted-diff: Add missed copyright headers * doc: Add missed copyright headers * scripts: update copyright_header script to include additional files * Include Objective-C source files * Scripts and tools: Drop no-longer-relevant copyright holder names * Scripts and tools: Fix devtools/copyright_header.py to always honor exclusions * Rename the test unspendable address * Rebrand miscellaneous comments * Rebrand comments in functional tests * [cashtab-components] disable token send from badge and button * [avalanche] Activate automated peer discovery * [avalanche] Remember nodes pending a proof and bind them when available * Update the seed pattern to accept 0.23 or 0.24 version * Remove the 1s timeouts in p2p_inv_download * [avalanche] create an avalanche log category and use it * Bump version to 0.23.9 * [cashtab-components] rebrand support * [avalanche] Improve error messages from the addavalanchenode RPC * [avalanche] Check the utxo limit using the verifyavalancheproof RPC * [avalanche] Supply an optional delegation to the addavalanchenode RPC * [Cashtab] prevent translation of user mnemonics * Remove mempool global * Remove mempool global from p2p * Remove mempool global from init * [avalanche] Fix a lock order inversion on shutdown * [avalanche] Make the error code consistent in addavalanchenode * [avalanche] Improve coverage for the addavalanchenode RPC * Remove mempool global from interfaces * rpc: Avoid useless mempool query in gettxoutproof * Pass mempool reference to chainstate constructor * [avalanche] Improve the delegateavalancheproof error messages * [Automated] Update timing.json * [Cashtab] icon improvements for PWA * [core#19724 9/9][doc] Follow developer notes, add comment about missing default. * [core#19724 8/9][doc] Describe connection types in more depth. * [core#19724 7/9][refactor] Simplify connection type logic in ThreadOpenConnections * [core#19724 6/9][refactor] Simplify check for block-relay-only connection. * [core#19724 5/9][test] Add explicit tests that connection types get set correctly * [core#19724 4/9][doc] Explain address handling logic in process messages * [core#19724 3/9][refactor] Restructure logic to check for addr relay. * [core#19724 2/9][net] Remove unnecessary default args on OpenNetworkConnection * [core#19724 1/9] scripted-diff: Rename OUTBOUND ConnectionType to OUTBOUND_FULL_RELAY * [avalanche] register local proof at first tip update * [avalanche] Do not bucket brigade (orphan) proof accessor * [avalanche] Do not bucket brigade proof registration * [avalanche] Move the proof accessor tests to the peer manager tests * [avalanche] Remove the unused processor addNode() method * [LINTER] Work around a cppcheck false positive * [avalanche] Do not bucket brigade broadcast handling * Remove Processor::forNode * TDOD -> TODO ------------------------------------------------------------------- Sat Jul 10 12:53:30 UTC 2021 - marec@detebe.org - Update to version 0.23.8: * functional tests: Remove portseed_offset from test runner * Pass mempool pointer to GetCoinsCacheSizeState * Pass mempool pointer to UnloadBlockIndex * test: Simplify cs_main locks * [avalanche] Fix an edge case that can assert when updating a node * [avalanche] Minor simplification in the fetchOrCreatePeer method * Simple cleanup in net_processing.cpp * [avalanche] More bucket brigading removal in the Processor * Broadcast proofs from the network layer * [avalanche] Remove some bucket brigading in the Processor * [avalanche] Move code around in the peer manager * [Automated] Update timing.json * [avalanche] Use proof registration time instead of "proof time" * remove boost::noncopyable dependency * Remove the deprecated setexcessiveblock RPC * Prevent setting -blockmaxsize and -excessiveblocksize <= 0 * [avalanche] Improve readability of the multi index container definitions * [avalanche] Don't check the delegation in the peer manager * [avalanche] Move the pubkey storage from the node to the network layer * [LINTER] Switch to clang-format 10 * [LINTER] Enforce mypy >= 0.780 * [core#19011 3/3] Reduce cs_main lock accumulation during GUI startup * [core#19104] gui, refactor: Register Qt meta types in application constructor * [core#19011 2/3] Add BlockAndHeaderTipInfo to the node interface/appInit * [core#19011 1/3] RPCConsole, take initial chaintip data as parameter * reduce size of bg file for better load times * [Cashtab] Get change address from sending utxo * Fix mistakenly swapped lock orders in logging * Fix dead link to Schnorr spec * Update Bitcoin Cash to eCash in secp256k1 README * [Cashtab] Support for eCash rebrand * net: Add -networkactive option * [Automated] Update timing.json * [Automated] Update seeds * [Automated] Update chainparams * Bring README logo graphic into repo * Update README from BCHA to eCash * Bump version to 0.23.8 * Work around memory-aliasing in descriptor ParsePubkey * Fix the fuzzer for FormatVersion and FormatUserAgent * Add -uaclientname and -uaclientversion config options to set the client name and version of the user agent in the version message. * move buildRemoteSighash out of the avalanche codebase * [avalanche] Don't require the proof when adding an avalanche node ------------------------------------------------------------------- Mon Jun 28 20:48:07 UTC 2021 - marec@detebe.org - Update to version 0.23.7: * Add some release notes for 0.23.7 * Bump version to 0.23.7 * [avalanche] Extract out a method to add or update a node * [avalanche] Consistently use node as a shortcut for self.nodes[0] * [avalanche] Remove unnecessary peer lookup after modifying the peer set * [avalanche] Generate a single block in tests * [avalanche] Fix a couple typo in comments * [Automated] Update timing.json * [Automated] Update seeds * [Automated] Update chainparams * [avalanche] Optionally assert a new proof orphan state * [avalanche] Fix the abc_p2p_proof_inventory test * [avalanche] Add an unbroadcast set of proofs * [tests] Remove unnecessary cs_mains in denialofservice_tests * [Automated] Update timing.json * [Automated] Update seeds * [Automated] Update chainparams * Fix the processor_tests spurious segmentation fault * [avalanche] Check the return value of the delegation addLevel() at startup * [avalanche] Add an option to import a delegation * [avalanche] split abc_p2p_avalanche into 2 tests * net: Add unit testing of node eviction logic * Make it easier to reason about node eviction by removing unused NodeEvictionCandidate::addr (CAddress) * net: Assume that SetCommonVersion is called at most once per peer * util: Add Assume() identity function * util: Make Assert work with any value * [test refactoring] move AvaP2PInterface to avatools.py * Protect localhost and block-relay-only peers from eviction * [avalanche] Check the delegation generated at startup is valid ------------------------------------------------------------------- Mon Jun 14 17:47:53 UTC 2021 - marec@detebe.org - Update to version 0.23.6: * [avalanche] Keep track of the rejected proofs * Add some release notes for 0.23.6 * add a getcurrencyinfo RPC command * refactor: consolidate both ecash CLI options under "-ecash" * ecash: add XEC option to the GUI * use XEC or BCH for bitcoin-qt depending on CLI setting * Fix p2p_inv_download test * [refactor] CURRENCY_UNIT into Currency class * [avalanche] Fix the avalanche_proof_inventory test * [avalanche] Manage proof reception * [avalanche] Don't request orphaned proofs * [avalanche] Make sure the master key matches the proof master * [refactor] use MAX_MONEY constant instead of magic number * [avalanche] Capitalize the init error messages and add a dot * [avalanche] Add a facility to build a delegation from a hex string * [eCash] adapt functional tests to the XEC base unit and test it by default * [eCash] add the XEC base unit and test it by default * [avalanche] Add a getrawproof RPC * [avalanche] Improve proof verification test coverage * [avalanche] Send proof inventories * Extract out the next inventory send time computation * [refactor] encapsulate a unit's denomination in a class * [refactor] set the -ecash CLI argument earlier in startup * [Automated] Update timing.json * [Automated] Update seeds * [Automated] Update chainparams * [avalanche] Fix the avalanche test on slow machines * [avalanche] Add a sendavalancheproof RPC shell * [avalanche] Extract a proof verification facility from the RPC * [avalanche] Make the deserialization error code consistent between RPCs * [avalanche] Add a facility to check if avalanche is enabled * [avalanche] Move the global definitions into their own header * [avalanche] Send avalanche proofs upon request * [avalanche] Keep track of the peer creation time * [avalanche] Keep a rolling bloom filter of our recently announced proofs * [CMAKE] Hint to user to the option flags when an optional dependency is not found * walletdb: Remove unused static functions from walletdb.h * wallettool: Have RecoverDatabaseFile return errors and warnings * walletdb: Don't remove database transaction logs and instead error * Call RecoverDatabaseFile directly from wallettool * [refactor] deduplicate AmountFromValue * Split SetWalletFlags into Add/LoadWalletFlags * Split SetActiveScriptPubKeyMan into Add/LoadActiveScriptPubKeyMan * Split SetHDChain into AddHDChain and LoadHDChain * Add FormatSubVersionUserAgent. * [avalanche] Fix threading issue in processor_tests.cpp * [avalanche] Download the proof from our peers that send avahello * [avalanche] Add a facility to check if a peer is preferred for DL * [avalanche] Reset the proof tracking state on peer disconnection * [avalanche] Manage the notfound messages from a proof request * [avalanche] Answer proof invs with getdata proof requests * [avalanche] make delegateavalancheproof take a limited id rather than a whole proof * [avalanche] use the OrphanProofPool * Use smart pointer in the orphan proof pool * [avalanche] Add an avaproof network permission for bypassing the inv tracking limit * Update the unspendable address in the wallet test lib * Remove wallet related constant from the mining util test lib * rpc: remove deprecated getaddressinfo fields * Extract inv saturation check and data request time computation * Bump version to 0.23.6 * [Automated] Update timing.json * [Automated] Update chainparams * [Automated] Update seeds * [avalanche] Add an API to store and retrieve a proof * [avalanche] Make the processor methods use a shared pointer to proof * [avalanche] Make the peermanager methods use a shared pointer to proof * RPC: Rephrase generatetoaddress help, and use PACKAGE_NAME * [avalanche] Make the peer hold a shared pointer to the proof * Remove WalletDatabase::Create, CreateMock, and CreateDummy * scripted-diff: Replace WalletDatabase::Create* with CreateWalletDatabase * Add Create*WalletDatabase functions * walletdb: refactor Read, Write, Erase, and Exists into non-template func * [CashAddr] adds eCash prefixes to the node behind a -ecash CLI argument * Make SetMiscWarning() accept bilingual_str argument * [LINTER] Exclude a cppcheck false positive * [avalanche] verify signature on avahello reception * [avalanche] include proof master and limited proofid in the delegation * [avalanche] Add a LimitedProofId::computeProofId method * refactor: Remove unused BlockAssembler::pblock member var * [LINTER] Exclude a new rule that enforce naming convention on classes ------------------------------------------------------------------- Tue Jun 01 17:54:55 UTC 2021 - marec@detebe.org - Update to version 0.23.5: * [Cashtab] Extension version bump * [Cashtab] Replace web hosted pkg with npm module * [refactor] get ValueFromAmount via an implicit Amount::operator UniValue() * Change format of log2_work for uniform output (zero-padded) * [avalanche] rename parameters in DelegationBuilder::addLevel * Update comment on TxRequestTracker in net_processing.h * Rename public interfaces from Tx to Inv in InvRequestTracker * Rename txrequest.h/cpp to invrequest.h/cpp * Rename `tx` to `inv` in the TxRequestTracker * Turn InvRequestTracker into a template class * Abstract out the TxRequestTracker public interface * [LINTER] Add an exception for a cppcheck false positive * [Cashtab] Patch bug in fee calculation for token creation * Split cs_main lock when sending getdata between inv types * Move the getdata content flush and logging to a lambda * Split the inv message reception processing in logical blocks by inv type * Extract out the inventory logging to a lambda * [avalanche] Remove unused getProof() method in the avalanche processor * [avalanche] Fix nits in peermanager.h comments * [Automated] Update timing.json * [Automated] Update seeds * [Automated] Update chainparams * Make the implementation details of TxRequestTracker use an uint256 * refactor: Remove confusing BlockIndex global * Drop unused CDBWrapper methods * banlist: log post-swept banlist size at startup * [cashtab] update REST endpoint url * Rename p2p_tx_download to p2p_inv_download * Pick better names for the tests in p2p_tx_download.py * Add the inventory type to p2p_tx_download context and use it * Add a context for running the p2p_tx_download test * Add missing <optional> headers * [test] Remove final references to mininode * test: resort imports * scripted-diff: Rename mininode to p2p * scripted-diff: Rename mininode_lock to p2p_lock * [Cashtab] Reduce bundle size by about ~50% * [avalanche] introduce LimitedProofId * [avalanche] change how the proof id is computed * Split the cs_main lock in SendMessages * Report and verify expirations * Delete limitedmap as it is unused now * Expedite removal of tx requests that are no longer needed * Reduce MAX_PEER_TX_ANNOUNCEMENTS for non-PF_RELAY peers * Change transaction request logic to use txrequest * Add txrequest fuzz tests * Add txrequest unit tests * Add txrequest module * [Automated] Update timing.json * [Automated] Update chainparams * [Automated] Update seeds * [Cashtab] Reduce default fee * test: Check that peers with forcerelay permission are not asked to feefilter * Fix a race in abc_mining_basic * Use mockable time everywhere in net_processing * Bump version to 0.23.5 * [avalanche] remove proof details from getavalanchepeerinfo RPC * [avalanche] add a decodeavalancheproof RPC * [backport#19272] net, test: invalid p2p messages and test framework improvements * [avalanche] Consistently use Proof::FromHex() for deserializing a proof * [avalanche] Add a verifyavalancheproof RPC ------------------------------------------------------------------- Sun May 16 12:26:13 UTC 2021 - marec@detebe.org - Update to version 0.23.4: * Add some release notes for the version 0.23.4 * Add a checkpoint for the Tachyon activation * Bump version to 0.23.4 * unbreak windows build * util: Don't reference errno when pthread fails. * test: disconnect_nodes should warn if nodes were already disconnected * Remove unused boost/thread * [Cashtab] Compare latest utxo set to stored wallet state * [backport#19489] test: Fail wait_until early if connection is lost * [backport#19304] test: Check that message sends successfully when header is split across two buffers * [backport#19252] test: wait for disconnect in disconnect_p2ps + bloomfilter test followups * [backport#19260] p2p: disconnect peers that send filterclear + update existing filter msg disconnect logic * [backport#19264] [tests] Don't import asyncio to test magic bytes * [backport#19177] test: Fix and clean p2p_invalid_messages functional tests * [backport#19083] test: msg_mempool, fRelay, and other bloomfilter tests * [backport#16756] test: Connection eviction logic tests * [Automated] Update timing.json * [Automated] Update chainparams * [Automated] Update seeds * [Cashtab] Bugfix in haveUtxosChanged * p2p: ensure inv is GenMsgTx before ToGenTxid in inv processing * p2p: make gtxid(.hash) and fAlreadyHave localvars const * p2p: use CInv block message helpers in net_processing.cpp * [net processing] Change AlreadyHaveTx() to take a GenTxid * [net processing] Change AlreadyHaveBlock() to take block_hash argument * [net processing] Remove mempool argument from AlreadyHaveBlock() * [net processing] Split AlreadyHave() into separate block and tx functions * p2p: add CInv block message helper methods * p2p, refactor: add CInv transaction message helpers; use in net processing * [avalanche] don't ignore avapoll and avaresponse while importing * [Cashtab] Show token info on Send Token screen * [Cashtab] Change dust param from BCHA to sats * Factorize flushing the inventory buffer when it reaches its max size * Add missing lock annotation to the tx inventory send buffer * remove misleading comment * [Cashtab] Patch z-index css issue in forms vs footer * [Cashtab] standardize balance header components * [Cashtab] Reduce bundle size by 70kb (10%) * [Cashtab] MVP token creation * [Automated] Update timing.json * [Automated] Update seeds * [Automated] Update chainparams * [Cashtab] Patch validation bug on settings page * [backport#20016] uint256: 1 is a constant * [avalanche] add an OrphanProofPool class * [cashtab] enable gzip compression when serving cashtab * [trivial] fix return value not using alias for SchnorrSig * [Cashtab] Reduce bundle size * [cashtab] replace deprecated eslint-loader, bump eslint version * [Cashtab] Use live wallet.state tokens obj if present ------------------------------------------------------------------- Sat May 01 17:25:30 UTC 2021 - marec@detebe.org - Update to version 0.23.3: * Add some release notes for the 0.23.3 release * Bump version to 0.23.3 * Fix proof id computation in the test framework * Ensure Axion can be reactivated consistently in abc_mining_basic * [Cashtab] bug fix in utxo diff check * refactor: Drop ::HasWallets() * refactor: Remove unused request.fHelp * wallet: Make RPC help compile-time static * refactor: Combine GetWalletForJSONRPCRequest and EnsureWalletIsAvailable functions * [Cashtab] Use wallet.state for balance on Send screen * [Automated] Update timing.json * [Automated] Update seeds * [Automated] Update chainparams * Fix minerfund in GBT when cashaddr is disabled * [avalanche] set a minimum amount for a proof * refactor: Use Mutex type for some mutexes in CNode class * refactor: Replace RecursiveMutex with Mutex in rpc/server.cpp * refactor: Use Mutex type for g_cs_recent_confirmed_transactions * [avalanche] improve stake generation in functional test * [Cashtab] load wallet from storage before calling API * [refactor] extract function for past activation tests * [backport#19178] Make mininode_lock non-reentrant * [avalanche] Don't turn on service bit if we don't have a proof * [avalanche] Move proof verification to processor * [Automated] Update timing.json * [Automated] Update chainparams * [Automated] Update seeds * Make sure unconfirmed parents are requestable * test: move sync_blocks and sync_mempool functions to test_framework.py * Drop setInventoryTxToSend based filtering * Only respond to requests for recently announced transactions * test: refactor functional tests to use restart_node * Introduce constant for mempool-based relay separate from mapRelay caching * Swap relay pool and mempool lookup * [backport#19299] remove unused variables and add missing includes * [Cashtab] Re-enable send for 9-decimal tokens * [Cashtab] Load from cache on startup * [net] Make cs_inventory nonrecursive * [avalanche] support MSG_AVA_PROOF in CInv::GetCommand ------------------------------------------------------------------- Sat Apr 17 16:04:53 UTC 2021 - marec@detebe.org - Update to version 0.23.2: * Add some release notes for 0.23.2 * Bump version to 0.23.2 * [Automated] Update timing.json * [Automated] Update seeds * [Automated] Update chainparams * Ignore .mypy_cache at all levels * [Cashtab] Cache wallet state in indexedDb * [BUILDBOT] Switch secp256k1 to Cirrus CI * [SECP256K1] Fix CI builds and badge links * [SECP256K1] Make scalar_inverse{,_var} benchmark scale with SECP256K1_BENCH_ITERS * [SECP256K1] Optimization: track f,g limb count and pass to new variable-time update_fg_var * [SECP256K1] Optimization: use formulas instead of lookup tables for cancelling g bits * [SECP256K1] Optimization: special-case zero modulus limbs in modinv64 * [SECP256K1] Remove num/gmp support * [SECP256K1] Remove unused scalar_sqr * [SECP256K1] Improve field/scalar inverse tests * [SECP256K1] Make field/scalar code use the new modinv modules for inverses * [SECP256K1] Move secp256k1_scalar_{inverse{_var},is_even} and secp256k1_fe_inverse{_var} to per-impl files * [SECP256K1] Improve bounds checks in modinv modules * [SECP256K1] Add safegcd based modular inverse modules * [SECP256K1] Add secp256k1_ctz{32,64}_var functions * [SECP256K1] ci: Switch all Linux builds to Debian and more improvements * [SECP256K1] Add support for Cirrus CI * [Cashtab] Batch utxo requests to hydrateUtxos * Add -overridednsseed for testing DNS seed behavior * [Cashtab] fix typo * [Cashtab] Temp disable token send for 9-decimal tokens * [SECP256K1] build: Add workaround for automake 1.13 and older * [SECP256K1] ctime_test: move context randomization test to the end * [SECP256K1] Use bit ops instead of int mult for constant-time logic in gej_add_ge * [avalanche] delay executing avalanche event loop until IBD is done * [SECP256K1] Add parens around ROUND_TO_ALIGN's parameter. * [SECP256K1] Add missing secp256k1_ge_set_gej_var decl. * [SECP256K1] Remove underscores from header defs. * [SECP256K1] sage: Add script for generating scalar_split_lambda constants * [SECP256K1] Remove unused secp256k1_fe_inv_all_var * [SECP256K1] Avoid casting (void**) values. * [SECP256K1] Autoconf improvements * [SECP256K1] Extract the secret key from a keypair * [SECP256K1] fixed trivial typo * [SECP256K1] Fix insecure links * [SECP256K1] docs: fix simple typo, dependecy -> dependency * [SECP256K1] Rename msg32 to msghash32 in ecdsa_sign/verify and add explanation * [SECP256K1] make test count iteration configurable by environment variable * [SECP256K1] Don't use reserved identifiers memczero and benchmark_verify_t * [SECP256K1] Convert Sage code to Python 3 (as used by Sage >= 9) * build: warn on potentially uninitialized reads * [secp256k1] initialize variable in tests * [Automated] Update timing.json * [Automated] Update seeds * [Automated] Update chainparams ------------------------------------------------------------------- Tue Apr 06 06:23:38 UTC 2021 - marec@detebe.org - Update to version 0.23.1: * Add some release notes for 0.23.1 * Add a checkpoint at block height 680140 * [avalanche tests] implement AvalancheProof serialization * [avalanche] add an inventory type and a message for proofs * [Automated] Update timing.json * [Automated] Update seeds * [Automated] Update chainparams * [Cashtab] Add latest features to browser extension * [Cashtab] Exclude slp utxos if tokenQty is 0 * Check for overflow when calculating sum of outputs * [avalanche] Add an RPC to build a delegation * [Cashtab] Add fiat price value to tx history * Bump version to 0.23.1 * increase the timeouts for abc_rpc_avalancheproof * Cleanup invalid inputs in p2sh test * [Cashtab] Parse token txs in tx history * [avalanche] Move the utxo limitation to the proof verification * [avalanche] split the test suite into 2 suites * [avalanche] refactor conditional processing in ProcessMessage * [Automated] Update timing.json * [Automated] Update seeds * [Automated] Update chainparams * Fix the abc_p2p_avalanche functional tests for ARM * [Cashtab] toggle display between tx history and tokens * [avalanche] register our proof after IBD * Verify avalanche proof at init ------------------------------------------------------------------- Mon Mar 22 17:12:06 UTC 2021 - marec@detebe.org - Update to version 0.23.0: * Drop duplicated chainparamsconstants.cpp * Drop bch network * Add -netinfo peer connections dashboard * Bump version to 0.23.0 * Move replay protection activation to Nov. 15, 2021 * net: improve nLastBlockTime and nLastTXTime documentation * net, rpc: expose nLastBlockTime/nLastTXTime as last block/last_transaction in getpeerinfo * p2p: Reduce inv traffic during IBD * net: Extract download permission from noban * doc: Extract net permissions doc * Prepare docs for the next minor version bump * Cleanup the seeder list * [Cashtab] Upgrading pkg dependencies * [avalanche] implement buildRemoteSighash and buildLocalSighash * [Cashtab] Add tx history * [avalanche] add an upper limit for the number of UTXOs in a proof * [Automated] Update timing.json * [Automated] Update seeds * [Automated] Update chainparams * [Cashtab] Move all colors to theme * [avalanche] discourage ava messages if avalanche is disabled * [Cashtab] Remove all colors from App.css * Signal the avalanche service if avalanche is enabled * assumptions: Assume C++17 * build: set Unicode true for NSIS installer * doc: install qt5 when building on macOS * [avalanche] implement getavalanchepeerinfo * [Cashtab] migrating more form css to styled components * [Automated] Update timing.json * [Automated] Update seeds * [Automated] Update chainparams * [Cashtab] Form elements to themed styled components * refactor: Replace RecursiveMutex with Mutex in netbase.cpp * refactor: Replace RecursiveMutex with Mutex in warnings.cpp * refactor: Replace RecursiveMutex with Mutex in timedata.cpp * [Cashtab] Add theming to better organize color changes * [Cashtab] remove unused qr code border css * [BUILDBOT] Remove local python-phabricator dependency * [Cashtab] Remove legacy css * Fix typo in USE_LINKER error message * Fix setting CXXFLAGS in linux build docs ------------------------------------------------------------------- Fri Mar 05 19:02:40 UTC 2021 - marec@detebe.org - Update to version 0.22.15: * [LINTER] Add mypy to the CI dependencies and exclude the contrib dir * doc: noban precludes maxuploadtarget disconnects * [Automated] Update timing.json * [Automated] Update seeds * [Automated] Update chainparams * Use correct length sig in sigcheck test * [Cashtab] Pull spinner color out of css * [QT] Restrict third party tx URL to https scheme only * [QT] Undim the validation button as the user updates the validated field * [Cashtab] Migrate some css to styled components * [Cashtab] Error handling for formatBalance * [Cashtab] Replace commas as thousands separator with space * [Cashtab] URGENT patch balance display bug in Safari * [Cashtab] Add commas to formatted displays of large numbers * validation: delay flushing undo files in syncing node case * refactor: Replace RecursiveMutex with Mutex in Shutdown() * [test] CScriptNum Decode Check as Unit Tests * doc: Add documentation for 'checklevel' argument in 'verifychain' RPC call * Increase timeout for abc_p2p_fullblocktest * [Cashtab] Improve nav buttons * [Cashtab] Move toSmallestDenomination function to utils * [Cashtab] Replace toBitcoinCash function * test: type hints in Python tests * [Automated] Update timing.json * [Automated] Update chainparams * [Automated] Update seeds * fix a potential regex search error in cdefs.py * Delete outdated "self tests" for the test framework * bump minimum python version to 3.6 * Bump version to 0.22.15 * validation: Make VerifyDB level 4 interruptible * validation: use std::chrono in CChainState::FlushStateToDisk() * test: Explain that a bug should be filed when the test fail * test: Add missing sync_blocks to wallet_hd * Limit scope of all global std::once_flag * tests: implement base58_decode * qt: Fix shutdown when waitfor* cmds are called from RPC console * Update links in CONTRIBUTE.md * [backport#18637] coins: allow cache resize after init * qt: Fix regression in TransactionTableModel * BlockTip struct created and connected to notifyHeaderTip and notifyBlockTip signals. * Added best block hash to the NotifyHeaderTip and NotifyBlockTip signals. * [buildbot] make bot link to backports of core-gui repo * wallet: descriptor wallet cleanups * qt: Use parent-child relation to manage lifetime of OptionsModel object * [Cashtab] Enable special features if wallet has specific eToken * [CI] Use a new datadir when running the windows native tests * [refactor] add alias for Schnorr signatures and remove size magic number * Remove old serialization primitives * convert all remaining serializations to new style * Convert LimitedString to formatter * Convert wallet to new serialization * Convert Qt to new serialization ------------------------------------------------------------------- Sat Feb 20 10:00:15 UTC 2021 - marec@detebe.org - Update to version 0.22.14: * Update version to 0.22.14 * [Cashtab] fix css issue with long wallet display names * test: add -getinfo multiwallet functional tests * rpc: drop unused JSONRPCProcessBatchReply size arg, refactor * cli: use GetWalletBalances() functionality for -getinfo * cli: create GetWalletBalances() to fetch multiwallet balances * cli: lift -rpcwallet logic up to CommandLineRPC() * cli: extract connection exception handler, -rpcwait logic to ConnectAndCallRPC() * [Automated] Update timing.json * [Automated] Update seeds * [Automated] Update chainparams * [Cashtab] show active wallet on home * [cashtab-components] More unit tests for helper functions * Avoid crash when g_thread_http was never started * test: Fix intermittent ETIMEDOUT on FreeBSD * [CI] Run cashtab components tests on CI * [CI] Rename teamcity messages testMeta to testMetadata * [CI] Split secp256k1 benchmarks from the node benchmarks * [CI] Integrate nanobench with Teamcity * Replace current benchmarking framework with nanobench * [Cashtab] Update cashtab docs links to point to web wallet docs * [Cashtab] Improve design on Settings page * [cashtab-components] adding unit test framework * Remove Bitcoin Cash references in CMake config files * [CI] Run the diff tests if any CMakeLists.txt file is changed * [LINTER] Prevent updating `{ (void)foo() }` to `{ ()foo }` * Faster sigcache nonce * [Cashtab] Clean up onboarding page + docs link * Revert version to 0.22.13 until 0.23 is ready for deployment * Skip hdKeypath of 'm' * addrman: ensure old versions don't parse peers.dat * tor: make a TORv3 hidden service instead of TORv2 * net: advertise support for ADDRv2 via new message * net: CAddress & CAddrMan: (un)serialize as ADDRv2 * Support bypassing range check in ReadCompactSize * [Automated] Update timing.json * [Automated] Update seeds * [Automated] Update chainparams * [cashtab-docs] remove BCH logo from twitter card * [cashtab-docs] Add google analytics * [Cashtab] Add missing meta field per errors reported by Twitter card validator * [backport#17681] wallet: Keep inactive seeds after sethdseed and derive keys from them as needed * [cashtab-docs] patch title so twitter card shows distinct title, tagline * [Cashtab] Add twitter card * [cashtab-docs] correct url to match deployment to fix tiwtter card * [docs-cashtab] night mode default and twitter preview card * test, build: Enable -Werror=sign-compare * p2p: Unify Send and Receive protocol versions * tests: Add fuzzing harness for CNode * [net] split PushInventory() * net: Use C++11 member initialization in protocol * net: recognize TORv3/I2P/CJDNS networks * Implement Keccak and SHA3_256 * net: CNetAddr: add support to (un)serialize as ADDRv2 * test: move HasReason so it can be reused * util: move HasPrefix() so it can be reused * [backport#18727] test: Add CreateWalletFromFile test * [backport#19164] ci: tsan with wallet * refactor: make EncodeBase{32,64} consume Spans * refactor: Make HexStr take a span * Bump version to 0.23.0 * Add test for param interaction b/w -blocksonly and -whitelistforcerelay * [Cashtab] Apply BigNumber to all base unit calcs in sendBch ------------------------------------------------------------------- Sun Feb 07 11:23:37 UTC 2021 - marec@detebe.org - Update to version 0.22.13: * Fix the deserialization of CoinEntry * [backport#18587] gui: Avoid wallet tryGetBalances calls in WalletModel::pollBalanceChanged * doc: elaborate on release notes wrt netmasks * Restore compatibility with old CSubNet serialization * net: change CNetAddr::ip to have flexible size * net: don't accept non-left-contiguous netmasks * net: save the network type explicitly in CNetAddr * net: improve encapsulation of CNetAddr * Serialization improvements step 6 (all except wallet/gui) * [Cashtab] Remove final instance of toSatoshi() * [Cashtab] change hover text for wallet mgmt icons * [Docusaurus] Adding docker deployment files * test: add two edge case tests for CSubNet * util: remove unused c-string variant of atoi64() * Make Hash[160] consume range-like objects * [Cashtab] Remove instance of toSatoshi from tx builder * Use npm ci instead of install for docker deployments * Do not bust cached npm-installed dependencies when source files change * Do not bust cached apt-install'd dependencies when source files change * [Cashtab] Incoming notifications use ticker variable * [Cashtab] Remove mint artifact object of arrays style input * [backport#14848] docs: Fix broken Gmane URL in security-check.py * test: Remove global wait_until from p2p_getdata # * gui: Remove un-actionable TODO * [backport#18861] Do not answer GETDATA for to-be-announced tx * [backport#16946] wallet: include a checksum of encrypted private keys * Make CHash256/CHash160 output to Span * Make MurmurHash3 consume Spans * Make CHash256 and CHash160 consume Spans * Make script/standard's BaseHash Span-convertible * Add MakeUCharSpan, to help constructing Span<[const] unsigned char> * Make uint256 Span-convertible by adding ::data() * scripted-diff: rename base_blob::data to m_data * [Automated] Update timing.json * [Automated] Update seeds * [Automated] Update chainparams * [Docs] MVP documentation * Disallow automatic conversion between disparate hash types * [Cashtab] Patch validation error preventing send of amounts with less than 8 decimal places * test: explicit imports from test_framework.messages in p2p_invalid_messages.py * test: use inventory type constant MSG_CMPCT_BLOCK * test: replace inv type magic numbers by constants * net: Remove un-actionable TODO * [Cashtab] Typo fix * [Cashtab] Replace toSatoshi method in satoshisToSend calc * [Cashtab] Replace remaining instances of CashTab with Cashtab * Fix rpc_bind flakiness * log: Remove "No rpcpassword set" from logs * refactor: Drop unused CBufferedFile::Seek() * test: Fix fuzzer compilation on macOS * fuzz: add missing overrides to signature_checker * tests: Add fuzzing harnesses for CAutoFile, CBufferedFile, LoadExternalBlockFile and other FILE* consumers * tests: Add fuzzing harness for AES{CBC,}256{Encrypt,Decrypt}, poly1305_auth, CHKDF_HMAC_SHA256_L32, ChaCha20 and ChaCha20Poly1305AEAD * tests: Add fuzzing harness for BanMan * net: Use mockable time for ping/pong, add tests * [Cashtab] Adding stub dev docs with facebook docusaurus * psbt: Include and allow both non_witness_utxo and witness_utxo for segwit inputs * [backport#18067] wallet: Improve LegacyScriptPubKeyMan::CanProvide script recognition * scripted-diff: TxoutType C++11 scoped enum class * refactor: Replace const char* to std::string * Span improvements * [Web - New] Adding cashtab-components source * test: Add capability to disable RPC timeout in functional tests. * [backport#14785] Scripts: Fix detection of copyright holders * tests: Add fuzzing harness for CHash{160,256}, C{HMAC_,}SHA{1,256,512}, CRIPEMD160, CSipHasher, etc. * refactor: Replace HexStr(o.begin(), o.end()) with HexStr(o) * tests: Add fuzzing harness for {Read,Write}{LE,BE}{16,32,64} (crypto/common.h) * Fix abc_p2p_fullblocktest timeout with TSAN * avoided os-dependant path * test: Remove const to work around compiler error on xenial * Add templated GetRandomDuration<> * [net processing] Only send a getheaders for one block in an INV * [Cashtab] replace legacy DUST param with constant * tests: Add fuzzing harnesses for functions in script/ * rpcwallet: Replace pwallet-> with wallet. * build: ensure we aren't using GNU extensions * util: Detect posix_fallocate() instead of assuming * refactor: Cleanup clientversion.cpp * miner: Avoid stack-use-after-return in validationinterface * test: Remove UninterruptibleSleep from test and replace it by SyncWithValidationInterfaceQueue * validationinterface: Rework documentation, Rename pwalletIn to callbacks * remove NETWORK_NAME * [ci] enable second_deadlock_stack for TSan * [backport#18726] test: check misbehavior more independently in p2p_filter.py * [Cashtab] Clean up unit tests * p2p: add MAX_FEELER_CONNECTIONS * gui: Fix itemWalletAddress leak when not tree mode * [doc] Add a link from ZMQ doc to ZMQ example in contrib/ * [Cashtab patch] Adjust input field step for cash or crypto * [Cashtab] Make tx fee in sats/byte a param * gui: Fix manual coin control with multiple wallets loaded * net: use CMessageHeader::HEADER_SIZE, add missing include * [docs] Improve commenting in ProcessGetData() * [BUILDBOT] Work around phabricator API change * [test] test that an invalid GETDATA doesn't prevent processing of future messages * [net processing] ignore unknown INV types in GETDATA messages * [net processing] ignore tx GETDATA from blocks-only peers * refactor: Apply override specifier consistently * wallet: Fix typo in assert that is compile-time true * [Automated] Update timing.json * [Automated] Update seeds * [Automated] Update chainparams * Get rid of BindWallet * doc: Fix typo in Coin doxygen comment * Disable CWalletTx copy constructor * Avoid copying CWalletTx in LoadToWallet * wallet: Make sure no DescriptorScriptPubKeyMan or WalletDescriptor members are left uninitialized after construction * Get rid of unneeded CWalletTx::Init parameter * Remove CWalletTx merging logic from AddToWallet * init: Remove boost from ThreadImport * Remove CCoinsViewCache::GetValueIn(...) * test: Fix p2p_leak intermittent issue * gui: Add close window shortcut * test: use unittest and test_runner for test framework unit testing * rpc: Do not advertise dumptxoutset as a way to flush the chainstate * test: fix message for ECC_InitSanityCheck test * fix: update rest info on block size and json * test: add wait_for_cookie_credentials() to framework for rpcwait tests * tests: Add fuzzing harness for CCoinsViewCache * tests: Don't limit fuzzing inputs to 1 MB for afl-fuzz (now: ∞ ∀ fuzzers) * [Automated] Update timing.json * tests: Fill fuzzing coverage gaps for functions in primitives/block.h * fuzz: use std::optional for sep_pos variable * fuzz: fix vector size problem in system fuzzer * net: remove is{Empty,Full} flags from CBloomFilter, clarify CVE fix * [net processing] Move Misbehaving() to PeerManager * Improve asmap checks and add sanity check * tests: Add fuzzing harness for MessageSign, MessageVerify and other functions in util/message.h * [net_processing] Move SendBlockTransactions into PeerManager * [Cashtab] replace BCHA decimal unit with a constant * test: Add mempool_updatefromblock.py * [net processing] Move MaybePunishPeerForTx to PeerManager * [Cashtab] Match app send min to backend send min with constant * [Cashtab] Implement BigNumber.js for crypto amounts * [net processing] Move ProcessOrphanTx to PeerManager * [net processing] Move MaybePunishNodeForBlock into PeerManager * [net processing] Move ProcessHeadersMessage to PeerManager * scripted-diff: [net processing] Rename PeerLogicValidation to PeerManager * Add Trunk Based Development link to CONTRIBUTING * bench: Start nodes with -nodebuglogfile * bench: Remove requirement that all benches use same testing setup * [Cashtab] Add unit tests for send BCHA amount validation * Bump version to 0.22.13 ------------------------------------------------------------------- Sun Jan 24 13:28:22 UTC 2021 - marec@detebe.org - Update to version 0.22.12: * test: Add fuzzing harnesses for various classes/functions in util/ * [trivial/doc] Fix comment type * [doc] Update unbroadcast description in RPC results * [trivial] Remove misleading 'const' * [test] Manage node connections better in mempool persist test * [net_processing] Pass chainparams to PeerLogicValidation constructor * [doc] Provide rationale for randomization in scheduling. * [mempool] Don't throw expected error message when upgrading * [test] Test that wallet transactions aren't rebroadcast before 12 hours * [test] updates to unbroadcast test * [docs] add release notes for new unbroadcast transaction status * [mempool] sanity check that all unbroadcast txns are in mempool * [rpc] add unbroadcast info to mempool entries and getmempoolinfo * wallet] remove nLastResend logic * test: add factor option to adjust test timeouts * script: prevent UB when computing abs value for num opcode serialize * test: Add fuzzing harnesses for various classes/functions in primitives/ * fuzz: Remove enumeration of expected deserialization exceptions in ProcessMessage(...) fuzzer * test: fix intermittent mempool_unbroadcast txn-mempool-conflict * [Cashtab] Reject transactions lower than backend dust limit * [mempool] Persist unbroadcast set to mempool.dat * [test] Integration tests for unbroadcast functionality * [refactor/test] Extract P2PTxInvStore into test framework * [wallet] Update the rebroadcast frequency to be ~1/day. * [p2p] Reattempt initial send of unbroadcast transactions * [util] Add method that returns random time in milliseconds * [mempool] Track "unbroadcast" transactions * tests: Add fuzzing harness for Golomb-Rice coding (GolombRiceEncode/GolombRiceDecode) * fuzz: fix unused variable compiler warning * Add fuzzer version of randomized prevector test * tests: Avoid fuzzer-specific nullptr dereference in libevent when handling PROXY requests * fuzz: http_request workaround for libevent < 2.1.1 * tests: Add fuzzing harness for HTTPRequest, libevent's evhttp and related functions * [backport#18754] bench: add CAddrMan benchmarks * [backport#18669] log: Use Join() helper when listing log categories * [backport#18777] wallet: Recommend absolute path for dumpwallet * tests: remove duplicate block generation * qt: remove todo bug fix for old versions of Qt * [CI] Elect more builds to run on diff depending on simple heuristic * test: Remove raw-tx byte juggling in mempool_reorg * test: Fix intermittent failure in wallet_importmulti * test: use zero-argument super() shortcut (Python 3.0+) * [Automated] Update timing.json * [Automated] Update seeds * [Automated] Update chainparams * tests: Add fuzzing harnesses for classes/functions in policy/fees.h, checkqueue.h and cuckoocache.h. Add fuzzing coverage. * tests: Add proof-of-work fuzzing harness * tests: Add fuzzing harness for functions/classes in flatfile.h, merkleblock.h, random.h, serialize.h and span.h * tests: Add fuzzing harnesses for functions/classes in chain.h and protocol.h * fuzz: Add CScriptNum::getint coverage * fuzz: Extend descriptor fuzz test * script: Remove undocumented and unused operator+ * [net processing] Move all const declarations to top of net_processing.cpp * [validation] Move all const declarations to top of validation.h * [validation] Move validation-only consts to validation.cpp * [net processing] Move net processing consts to net_processing.cpp * [Cashtab] Match number step input to token decimals * [Cashtab] Default wallet name to 1899 address * [Cashtab] Update api to /v4/ * [Cashtab] Replace step with constant * test: add coverage for -rpcwallet cli option * refactor: test: use wait_for_getdata() in p2p_compactblocks.py * test: display command line options passed to send_cli() in debug log * tests: Add fuzzing harness for classes/functions in blockfilter.h. Add integer {de,}serialization fuzzing. * tests: Don't assume presence of __builtin_mul_overflow in MultiplicationOverflow(...) fuzzing harness * tests: Add harness which fuzzes EvalScript and VerifyScript using a fuzzed signature checker * tests: Add fuzzing harnesses for classes CBlockHeader, CFeeRate and various functions * test: Check submitblock return values * fixing init.md documentation to not require rpcpassword * test: check for matching object hashes in wait_for_getdata * [Cashtab] split out backend functions from tests * Fix typo in Sighash tests * test: Remove unused, undocumented and misleading CScript.__add__ * fuzz: Add missing ECC_Start to key_io test * tests: Add fuzzing harness for CScript and CScriptNum operations * tests: Add amount compression/decompression fuzzing to existing fuzzing harness * tests: Avoid hitting some known minor tinyformat issues when fuzzing strprintf(...) * Make libfuzzer to work on macOS * [docs] use consistent naming for possible_overwrite * rpc: doc: Fix and extend getblockstats examples * scripted-diff: Rename PRUNED to SPENT in coins tests * [docs] Improve commenting in coins.cpp|h * test: add further BIP37 size limit checks to p2p_filter.py * net: limit BIP37 filter lifespan (active between 'filterload'..'filterclear') * [Cashtab] More clarity and tests for address parsing * rpc: Add doc for deactivating settxfee and respect -maxtxfee wallet setting * fuzz: Extend script fuzz test * [Cashtab] support valid addresses if no prefix included * fuzz: Add assert(script == decompressed_script) * [CI] Build the fuzzer on diffs that touch the fuzzer files * test: Replace boost::mutex with std::mutex * tests: have coins simulation test also use CCoinsViewDB * tests: don't repeat scriptPubKey value * [move only] Collect all private members of PeerLogicValidation together * [backport#16945#18181] refactor: introduce CChainState::GetCoinsCacheSizeState [plus fix] * script: Disallow silent bool -> CScript conversion * refactor: Remove unused methods CBloomFilter::reset()/clear() * test: Verify findCommonAncestor always initializes outputs * test: coverage improvements in interface-bitcoin_cli.py * test: Add various low-level p2p tests * [backport#16380] Remove unused bits from the service flags enum * [doc] Update thread information in developer docs * test: add rpc_signrawtransaction logging * [Cashtab] parse sats from scanned qr code amount param * gui: use PACKAGE_NAME in exception message * test: shift coverage from getunconfirmedbalance to getbalances * test: Extend wallet_dump test to cover comments * doc: default minconf for getbalance should be 0 * [consensus] MOVEONLY: Move single-sig checking EvalScript code to EvalChecksig * test: Check that the version message does not leak the local address of the node * Remove useless calls to setexcessiveblock in extended tests * Deprecate the `setexcessiveblock` RPC * test: Remove REJECT message code * rpc: Remove deprecated migration code * cli -getinfo: use getbalances instead of deprecated getwalletinfo balance * rpc: Make verifychain default values static, not depend on global args * [backport#17453] gui: Fix intro dialog labels when the prune button is toggled * [backport#15874] Resolve the qt/guiutil <-> qt/optionsmodel CD * Add a test for the banscore deprecation * [backport#17696] qt: Force set nPruneSize in QSettings after the intro dialog * Remove PID file at the very end * Fix a -Wunused-variable in the locale fuzzer * Moving dev dependencies to dev, removing unused deps, updates some of them * Update -blocksonly documentation * [LINTER] Fix a couple cppcheck issues * [Cashtab] hide scrollbar in extension * rpc: Make rpc documentation not depend on rpc args * [Automated] Update timing.json * [Automated] Update chainparams * [Automated] Update seeds * [Cashtab] bump extension version to support new backend per D8885 * [CashTab] Update react-copy-to-clipboard * Change Bitcoin Cash references to BCHA in README * wallet: Handle duplicate fileid exception * [Cashtab] Prepare for migration to psf bch-api with new utxo key * RPC: Fix more formatting nits * [backport#16658] validation: Rename CheckInputs to CheckInputScripts * test: listsinceblock block height checks * gui: Avoid Wallet::GetBalance in WalletModel::pollBalanceChanged * test: check that peer is connected when calling sync_* * RPC: Remove final comma for last entry of fixed-size Arrays and Objects in RPCResult * rpc: remove unused getbalances() code * test: add coverage for script parse error in ParseScript * util: Remove unused itostr * rpc: fix broken RPCExamples for waitforblock(height) * Update copyright year to 2021 * Limit decimal range of numbers ParseScript accepts * Replace std::to_string with locale-independent alternative * util: Fail to parse space-only strings in ParseMoney(...) (instead of parsing as zero) * lockedpool: avoid sensitive data in core files (FreeBSD) * [Cashtab] extension with new pkgs, version bump * lockedpool: When possible, use madvise to avoid including sensitive information in core dumps * test: Fix restart node race * test: add unit test for non-standard "scriptsig-not-pushonly" txs * [avalanche] Initiate avalanche when the service bit is present and we have a stake. * gui: display Mapped AS in peers info window * [CI] Work around LCOV stupid behavior * [CI] Add cashtab coverage report to the coverage panel * [CI] Generate a CashTab coverage summary report * gui: Avoid redundant tx status updates * [Cashtab] remove duplicate key from test mock * [mempool] Remove NotifyEntryAdded and NotifyEntryRemoved callbacks * [validation] Remove NotifyEntryRemoved callback from ConnectTrace * [validation] Remove conflictedTxs from PerBlockConnectTrace * [validation interface] Remove vtxConflicted from BlockConnected * [wallet] Notify conflicted transactions in TransactionRemovedFromMempool * [FUZZER] Fix build failure * [net] Add extra entropy to the version message * [cashtab] Remove autocomplete from address inputs * [test framework] Simplify version message handling * Bump version to 0.22.12 * [cashtab] Update to react 17 * Add bn2vch test to functional tests * rpc: add missing HelpExampleRpc for getblockfilter * Update merkle.cpp * Fix UB with bench on genesis block * [tests] remove bignum.py * [cashtab] update CI to npm7/node15 * tests: simplify next_block() function in feature_block * Fix mining to an invalid target + ensure that a new block has the correct hash internally in Python tests * rand: remove getentropy() fallback for macOS < 10.12 * rpc: Document an RPCResult for all calls; Enforce at compile time ------------------------------------------------------------------- Fri Jan 08 16:48:33 UTC 2021 - marec@detebe.org - Update to version 0.22.11: * [cashtab] use npm ci instead of install on CI * Revert "test: check custom descendant limit in mempool_packages.py" * [cashtab] Upgrade webpack modules * [cashtab] Downgrade css-loader * Remove web hosted npm module * [CI] Fix gitian script path * Fix missing header in sync.h * [CI] Generate coverage reports for cashtab * [CI] Improve cashtab reporting in case of a test failure * Implement O(1) OP_IF/NOTIF/ELSE/ENDIF logic * test: check custom descendant limit in mempool_packages.py * [refactor] interpreter: define interface for vfExec * Benchmark script verification with 100 nested IFs * [CI] Generate Junit output for the cashtab tests * [CASHTAB] Update the jest dependency * [CASHTAB] Remove the no longer needed --legacy-peer-deps install flag * [CASHTAB] Update the README * [CI] Run cashtab tests on CI * test: Add missing syncwithvalidationinterfacequeue * util: HelpExampleRpc formatting fixup * Remove redundant type information from rpc docs * [GITIAN] Remove host dependencies * test: Add bad-txns-*-toolarge test cases to invalid_txs * [CI] Allow for running arbitrary scripts * doc: Warn about wallet.dat re-use and backups * [CASHTAB] Remove the .prettierignore file * Correct linting errors * Remove unused config argument from the finalization methods * [cashtab] Upgrade mini-css-extract-plugin * [cashtab] Update css-loader * [cashtab] Update file-loader and fs-extra * [cashtab] Upgrade eslint * [cashtab] Update webpack * [cashtab] Downgrade terser-webpack-plugin to use a supported version of webpack * Do not format autogenerated files * [cashtab] Update fbt * [Automated] Update timing.json * [Automated] Update seeds * [Automated] Update chainparams * Downgrade react-test-renderer * [CashTab] Fix TerserPlugin and other npm packages with vulnerabilities * [backport#13655] bitcoinconsensus: invalid flags error should be set to bitcoinconsensus_err * Refactor from path 145/245 to path 1899 with migration support * rpc/wallet: initialize nFeeRequired explicitely to 0 * [net/net processing] check banman pointer before dereferencing * [p2p] Add Peer struct for per-peer data in net processing * rpc: Relock wallet only if most recent callback * test: add logging to wallet_listsinceblock.py * qa: Add getdescriptorinfo functional test * p2p: clean up Misbehaving() * [net processing] Reduce cs_main scope in MaybeDiscourageAndDisconnect() * Rename CheckIfBanned() to MaybeDiscourageAndDisconnect() * [net_processing] Move ProcessMessage to PeerLogicValidation * [net_processing] Change PeerLogicValidation to hold a connman reference * net: Avoid redundant and confusing FAILED log * [backport#19512] p2p: banscore updates to gui, tests, release notes * [backport#19464] net: remove -banscore configuration option * [backport#19469] rpc: deprecate banscore field in getpeerinfo * Convert blockencodings.h to new serialization framework * Add CustomUintFormatter * Add DifferenceFormatter * Make VectorFormatter support stateful formatters * Convert CCompactSize to proper formatter * Pass chain params explicitely to EncodeSecret and DecodeSecret * Add monorepo link to CONTRIBUTING.md * depends: enable lto support for Apple's ld64 * [CMAKE] Lower boost test suites verbosity * [rpc] changed MineBlocksOnDemand to IsMockableChain * test: Reduce unneeded whitelist permissions in tests * httpserver: use own HTTP status codes * Merge #12218: net: Move misbehaving logging to net logging category * refactor: test/bench: dedup SetupDummyInputs() * [avalanche] Add an handy way to build the quorum in the test * Drop unused mach time headers * random: don't special case clock usage on macOS * util: Fail to parse empty string in ParseMoney * refactor: Remove mempool global from net * Fix a violation of C++ standard rules that unions cannot be switched. * scripted-diff: Wallet: Rename incorrectly named *UsedDestination * add: test that transactions expire from mempool * gui: Fix race in WalletModel::pollBalanceChanged * Get rid of VARINT default argument * [Automated] Update timing.json * [Automated] Update seeds * [Automated] Update chainparams * Bump version to 0.22.11 * [backport#17674] tests: Add initialization order fiasco detection in Travis * [backport#17205] ci: Enable address sanitizer (ASan) stack-use-after-return checking * Support npm pkgs in extension-specific files * [BUILDBOT] Temporarly fix the 502 error with embedded shields.io link ------------------------------------------------------------------- Sun Dec 27 13:40:42 UTC 2020 - marec@detebe.org - Update to version 0.22.10: * Add some release notes for the 0.22.10 release * [backport#17162] chain: Remove CBlockIndex::SetNull helper * [backport#17328] GuessVerificationProgress: cap the ratio to 1 * [backport#16805] logs: add timing information to FlushStateToDisk() * [backport#17242] refactor: Remove unused cacheSigStore from CheckInputsFromMempooAndCache * [backport#16852] gui: When BIP70 is disabled, get PaymentRequest merchant using string search * [backport#16969] refactor: Remove Qt function to disable menu icons on macOS * [backport#16677] gui: remove unused PlatformStyle::TextColorIcon * [backport#16612] qt: Remove menu icons * [backport#17085] init: Change fallback locale to C.UTF-8 * [Automated] Update timing.json * [Automated] Update seeds * [Automated] Update chainparams * [gitian] add Marco's key * Convert undo.h to new serialization framework * Add webpage interaction to extension * Make std::vector and prevector reuse the VectorFormatter logic * Add custom vector-element formatter * Add a constant for the maximum vector allocation (5 Mbyte) * Use rolling bloom filter of recent block tx's for AlreadyHave() check * Qt: pass clientmodel changes from walletframe to walletviews * qt: Fix deprecated QCharRef usage * Update build-windows.md * util: Disallow network-qualified command line options * Tests: Use self.chain instead of 'regtest' in all current tests * gui: Drop PeerTableModel dependency to ClientModel * Walk pindexBestHeader back to ChainActive().Tip() if it is invalid * Add Epoch Guards to CTXMemPoolEntry and CTxMemPool, make UpdateTransactionsFromBlock use Epochs * [test] Add test for NODE_COMPACT_FILTER. * [net] Signal NODE_COMPACT_FILTERS if we're serving compact filters. * Apply cfilters review fixups * [net] Remove unnecessary default args on CNode constructor * [refactor] Remove IsOutboundDisconnectionCandidate * [net/refactor] Simplify multiple-connection checks * [net/refactor] Rework ThreadOpenConnections logic * [net] Fix bug where AddrFetch connections would be counted as outbound full relay * [net/refactor] Clarify logic for selecting connections in ThreadOpenConnections * [net/refactor] Remove fInbound flag from CNode * [net/refactor] Remove m_addr_fetch member var from CNode * [net/refactor] Remove fFeeler flag from CNode * [net/refactor] Remove m_manual_connection flag from CNode * [net/refactor] Add connection type as a member var to CNode * [doc] Describe different connection types * [net/refactor] Add AddrFetch connections to ConnectionType enum * [net/refactor] Extract m_addr_known logic from initializer list * [net/refactor] Add block relay only connections to ConnectionType enum * [net/refactor] Add feeler connections to ConnectionType enum * [net/refactor] Add manual connections to ConnectionType enum * [net/refactor] Introduce an enum to distinguish type of connection * scripted-diff: Rename OneShot to AddrFetch * fuzz: Stop nodes in process_message* fuzzers * Properly use TxId in txindex.cpp * Add a TSAN suppression for leveldb * doc: update release notes with getaddressinfo label deprecation * test: getaddressinfo label deprecation test * rpc: deprecate getaddressinfo label field * gui: Remove WalletView and BitcoinGUI circular dependency * test: remove getaddressinfo label tests * doc: address pr17578 review feedback * gui: Add transactionClicked and coinsSent signals to WalletView * gui: Drop ShutdownWindow dependency to BitcoinGUI * gui: Drop BanTableModel dependency to ClientModel * Add missing supported rpcs to doc/descriptors.md * Fix benchmarks filters * gui: Shortcut to close ModalOverlay * Remove BCHN related automation * Good bye BCH * Revert "[AUR] Add PKGBUILD files for the BCHN network variant" * Revert "Build the debian package for both chains" * Revert "[GITIAN] Build for both chains" * Refactor extension files to support updated antd * tests: Avoid using C-style NUL-terminated strings as arguments * net: Add tests for failure on string parameters with embedded NUL characters * net: Avoid using C-style NUL-terminated strings in the netbase interface * [Automated] Update timing.json * [Automated] Update chainparams * [CashTab] Adds webpack aliases and refactor imports * Remove disabled prop from collapse panels as antd deprecated * Update antd to fix design issues * [cmake] Allow to configure the linker used. * Make uploading the assets optional when creating a release draft * Re-enable SLPA transactions in CashTab and fix notification bug * init: Stop indexes on shutdown after ChainStateFlushed callback. * gui: Delay interfaces::Node initialization * gui: Replace interface::Node references with pointers * gui: Remove unused interfaces::Node references * gui: Partially revert #10244 gArgs and Params changes * refactor: Error message bilingual_str consistency * Remove gArgs global from init * refactor: Pass ArgsManager into functions that register args * Bump version to 0.22.10 * Add a dumpcoins RPC to dump the coins available in the wallet * nits in the wallet and descriptor code * wallet: allow transaction without change if keypool is empty * [backport#16090] Qt: Add vertical spacer to peer detail widget * [backport#16044] qt: fix opening bitcoin.conf via Preferences on macOS * [seeder] Request headers from new connections ------------------------------------------------------------------- Sat Dec 12 07:57:21 UTC 2020 - marec@detebe.org - Update to version 0.22.9: * Add a checkpoint to help users follow the right chain * [backport#16377 2/2][rpc] fundrawtransaction: add_inputs option to control automatic input adding * [backport#16377 1/2][rpc] walletcreatefundedpsbt: don't automatically append inputs * refactor: Use AbortError in FatalError * Pass bilingual_str argument to AbortNode() * Update seeds * Fix bitcoin-qt RPC when -server is used * refactor: Fix unreachable code in init arg checks (part 2) * refactor: Fix unreachable code in init arg checks * gui: Do not translate InitWarning messages in debug.log * rpc: Make gettxoutsetinfo/GetUTXOStats interruptible * test: Pass ArgsManager into getarg_tests * [seeder] Add a test to check outgoing messages in response to VERACK * [seeder] Use GetTime() utility function instead of accessing ctime directly * [Automated] Update timing.json * [Automated] Update chainparams * Dedup net message writing code in the seeder * wallet: Never schedule MaybeCompactWalletDB when -flushwallet is off * test: Avoid accessing free'd memory in validation_chainstatemanager_tests * fuzz: Disable debug log file * tests: Add deserialization fuzzing of SnapshotMetadata (utxo_snapshot). Increase fuzzing coverage. * Revert "Revert "fuzz: Add process_messages harness"" * Fix a fuzzer build failure and run the build on CI * Fix a potential data race between CConman and the PeerLogicValidation * [seeder] Use netmagic from chainparams instead of a cached global * Convert compression.h to new serialization framework * Fix seeder linking due to missing dependency in libcommon * Add FORMATTER_METHODS, similar to SERIALIZE_METHODS, but for formatters * Convert chain and blockfileinfo to new serialization * Convert VARINT to the formatter/Using approach * Add a generic approach for (de)serialization of objects using code in other classes * Work around GCC -Wmaybe-uninitialized false positive * [refactor] remove const CChainParams& object from CWallet * Fix the functional tests on platforms using select() instead of poll() * [backport#16400] refactor: Rewrite AcceptToMemoryPoolWorker() using smaller parts * Remove 0.21.x from makeseeds * [avalanche] Only select from peers which have an actual node attached * [avalanche] Refactor the PeerManager * Fix doxygen errors * gui: simplify wallet_model creation * Refactor: clean up PeriodicFlush() * wallet: Move BerkeleyBatch static functions to BerkeleyDatabase * wallet: Remove boost from PeriodicFlush * walletdb: Move BDB specific things into bdb.{cpp/h} * walletdb: moveonly: Move BerkeleyBatch Cursor and Txn funcs to cpp * walletdb: move IsWalletLoaded to walletdb.cpp * walletdb: Add IsBDBWalletLoaded to look for BDB wallets specifically * walletdb: Make SpliWalletFilePath non-static * Add release notes about salvage changes * Move RecoverKeysOnlyFilter into RecoverDataBaseFile * Move RecoverDatabaseFile and RecoverKeysOnlyFilter into salvage.{cpp/h} * Make BerkeleyBatch::Recover and WalletBatch::RecoverKeysOnlyFilter standalone * Expose a version of ReadKeyValue and use it in RecoverKeysOnlyFilter * Move BerkeleyEnvironment::Salvage into BerkeleyBatch::Recover * walletdb: remove fAggressive from Salvage * walletdb: don't automatically salvage when corruption is detected * wallet: remove -salvagewallet * Add basic test for bitcoin-wallet salvage * wallettool: Add a salvage command * Remove g_rpc_chain global * [CashTab] Only show console messages if test fails * [avalanche] Specify the proof to be used by the node via config * [avalanche] Add nodes using a verifiable delegation instead of asserting the public key * [avalanche] Add a mechanism to delegate proofs * Bump DEFAULT_MAX_PEER_CONNECTIONS to 4096 * Add a way to verify schnorr signatures from an array. * [avalanche] Fix race condition during destruction in poll_and_response test * [CashTab] Add Fbt dependencies, init script and intl to App component * [CI] Increase IBD timeout * [Automated] Update timing.json * [Automated] Update chainparams * Disabling send for SLPA tokens * [avalanche] Use more sensible banscores * Add script to build CashTab as browser extension * Run autogen on recent version bump * Bump version to 0.22.9 * Fees from 83 sat/byte to 5 sat/byte * Support backup API URLs * Docker deployment files and instructions * [avalanche] Allow to manually set the session key * rpc: Fix named arguments in documentation * rpc: Avoid initialization-order-fiasco on static CRPCCommand tables * util: Add Assert identity function * validation: Mark g_chainman DEPRECATED * validation: Make ProcessNewBlock*() members of ChainstateManager * validation: Make PruneOneBlockFile() a member of ChainstateManager * validation: Make LoadBlockIndex() a member of ChainstateManager * net: Pass chainman into PeerLogicValidation * node: Add chainman alias for g_chainman * rpc: Add generateblock to mine a custom set of transactions * Do not unpark deep reorg automatically when avalanche is enabled * [avalanche] Return more detailed errors codes * [avalanche] log block acceptance and rejection * Add cashtab to web projects * Fix buildavalancheproof RPC with bitcoin-cli ------------------------------------------------------------------- Tue Dec 01 17:22:18 UTC 2020 - marec@detebe.org - Update to version 0.22.8: * Limit the number of sigcheck added to a block when mining * protect g_chainman with cs_main * test: add basic tests for ChainstateManager * use ChainstateManager to initialize chainstate * validation: introduce unused ChainstateManager * validation: add CChainState.m_from_snapshot_blockhash * Remove propagation delay for outbound peers * [avalanche] Keep track of stacked UTXOs to avoid double staking * Fix a comment in net_processing.cpp * nits in protocol.h * [backport#15136] qt: "Peers" tab overhaul * [backport#14594] qt: Fix minimized window bug on Linux * [backport#14177] qt: Set C locale for amountWidget * [backport#13537] GUI: Peer table: Visualize inbound/outbound state for every row * [backport#13082] Tests: don't test against min relay fee information in mining_prioritisetransaction.py * [avalanche] Keep the peer set up to date as the chain tip is updated. * [avalanche] Properly validate proof in peermanager.cpp * [avalanche] Use correct avalanche proofs instead of made up ones * Fix a typo in the Proof validation enum * [avalanche] Check for height and coinbase of stakes * [Automated] Update timing.json * [Automated] Update chainparams * Merge #17096: gui: rename debug window * rpc: Remove special case for unknown service flags * util: simplify the interface of serviceFlagToStr() * Consolidate service flag bit-to-name conversion to a shared serviceFlagToStr function * GUI: Refactor formatServicesStr to warn when a ServicesFlag is missing * Drop the BITCOIN_CASH service bit * [buildbot] Add missing deepmerge dependency * Make the buildbot aware of the configuration templates * Don't specify the C++ standard explicitely for Cppcheck * [protocol] Remove unused CADDR_TIME_VERSION * Drop CADDR_TIME_VERSION checks now that MIN_PEER_PROTO_VERSION is greater * net: improve code documentation for dns seed behaviour * DNS seeds: wait for 5m instead of 11s if 1000+ peers are known * Just pass a TxId to AddInventoryKnown, rename to AddKnownTx * Add a prettier linter for the web tools * [buildbot] Set build status as passed when a target has no builds * [buildbot] Build targets should default to success when no builds are queued * Run secp256k1 tests on diffs where changes to the library are made * Only run node-related builds on diffs where the node software has changed * fix assert crash when specified change output spend size is unknown * [refactoring] eliminate Boost::Optional for std::optional * tests: Add RPCOverloadWrapper which overloads some disabled RPCs * Fix a nit in wallet_keypool.py * [avalanche] Add facility to check proof against a view of the UTXO * Add primitive to generate random 160 bits numbers for tests * [cpp] move to C++17 * [backport#18388] Make VerifyWitnessProgram use a Span stack * Functional tests for descriptor wallets * add importdescriptors RPC and tests for native descriptor wallets * Change wallet_encryption.py to use signmessage instead of dumpprivkey * Properly handle coinbase in proofbuilder * [qt] remove deprecated Qt:SystemLocale____Date * refactor: replace CConnman pointers by references in net_processing.cpp * net: Make addr relay mockable, add test * [buildbot] Support a list of regex when matching builds to changed files * [buildbot] Fix getcommitpaths result type * [buildbot] Fix missing revision_id that is expected to be strictly an integer * [buildbot] Introduce selecting diff builds based on filename regex * [Automated] Update chainparams * refactor: replace pointers by references within tx_verify.{h,cpp} * Split chainparams by network * [buildbot] Add a facility for fetching the files changed in a given revision * Return error when no ScriptPubKeyMan is available for specified type * Correctly check for default wallet * Implement CWallet::IsSpentKey for non-LegacySPKMans * refactor: replace CNode pointers by references within net_processing.{h,cpp} * net processing: Add support for getcfilters * net processing: Add support for getcfheaders * indexes: Add compact block filter headers cache * Serve cfcheckpt requests * refactor: s/command/msg_type/ in CNetMsgMaker and CSerializedNetMsg * scripted-diff: test: replace command with msgtype (naming) * scripted-diff: Replace strCommand with msg_type * [buildbot] Add revision ID as arg to /buildDiff * Add IsLegacy to CWallet so that the GUI knows whether to show watchonly * Generate new descriptors when encrypting * Be able to create new wallets with DescriptorScriptPubKeyMans as backing * Implement GetMetadata in DescriptorScriptPubKeyMan * Change GetMetadata to use unique_ptr<CKeyMetadata> * Implement FillPSBT in DescriptorScriptPubKeyMan * [Automated] Update timing.json * Set a different default PPA depending on network * Implement SignMessage for descriptor wallets * Bump version to 0.22.8 * Implement SignTransaction in DescriptorScriptPubKeyMan * Implement GetSolvingProvider for DescriptorScriptPubKeyMan * Implement GetKeypoolOldestTime and only display it if greater than 0 * test: add functional test for non-standard bare multisig txs * GUI: Use PACKAGE_NAME * test: Fix intermittent error in mempool_reorg * doc: Add separate productivity notes document * [doc] add notes on release notes * Fix an uninitialized const reference warning in hash_tests * net: Add missing cs_vNodes lock ------------------------------------------------------------------- Tue Nov 17 18:45:10 UTC 2020 - marec@detebe.org - Update to version 0.22.7: * Add a release note * Add checkpoints for Axion upgrade * Fix typos * docs: Link to python style guidelines from developer notes * qa: Fix double-negative arg test * gui: Set CConnman byte counters earlier to avoid uninitialized reads * docs: Fix conflicting statements about initialization in developer notes * Fix improper Doxygen inline comments * Implement ReturnDestination in DescriptorScriptPubKeyMan * Implement GetReservedDestination in DescriptorScriptPubKeyMan * Implement Unlock and Encrypt in DescriptorScriptPubKeyMan * Implement GetNewDestination for DescriptorScriptPubKeyMan * Implement TopUp in DescriptorScriptPubKeyMan * Implement SetupGeneration for DescriptorScriptPubKeyMan * [avalanche] Add a custom TestSetup for processor_tests * Implement writing descriptorkeys, descriptorckeys, and descriptors to wallet file * Implement several simple functions in DescriptorScriptPubKeyMan * Add IsSingleType to Descriptors * Implement loading of keys for DescriptorScriptPubKeyMan * Implement GetID for DescriptorScriptPubKeyMan * Load the descriptor cache from the wallet file * Implement IsHDEnabled in DescriptorScriptPubKeyMan * Implement MarkUnusedAddresses in DescriptorScriptPubKeyMan * Implement IsMine for DescriptorScriptPubKeyMan * Add LoadDescriptorScriptPubKeyMan and SetActiveScriptPubKeyMan to CWallet * Implement SetType in DescriptorScriptPubKeyMan * Store WalletDescriptor in DescriptorScriptPubKeyMan * Add a lock cs_desc_man for DescriptorScriptPubKeyMan * Introduce WalletDescriptor class * Create LegacyScriptPubKeyMan when not a descriptor wallet * Return nullptr from GetLegacyScriptPubKeyMan if descriptor wallet * Add WALLET_FLAG_DESCRIPTORS * Introduce DescriptorScriptPubKeyMan as a dummy class * Introduce SetType function to tell ScriptPubKeyMans the type and internal-ness of it * qt: Add LogQtInfo() function * fix autopep8 package name for ubuntu and debian * Get the OutputType for a descriptor * Revert "fuzz: Add process_messages harness" * Various nits in descriptor.cpp * fuzz: Add process_messages harness * [backport#17850] Convert addrdb/addrman to new serialization * [backport#17850] Introduce new serialization macros without casts * net: Log to net category for exceptions in ProcessMessages * Cache parent xpub inside of BIP32PubkeyProvider * Only cache xpubs that have a hardened last step * Cache the immediate derivation parent xpub * Add DescriptorCache* read_cache and DescriptorCache* write_cache to Expand and GetPubKey * Rename BIP32PubkeyProvider.m_extkey to m_root_extkey * Track the index of the key expression in PubkeyProvider * Introduce DescriptorCache struct which caches xpubs * Add adaptation of the descriptor test that are using segwit in Core * Refactor message transport packaging * Fix logic of memory_cleanse() on MSVC and clean up docs * doc: Include static members in Doxygen * TEST: Replace hard-coded hex tx with classes * [backport#16947] doc: Doxygen-friendly script/descriptor.h comments * [backport#11558] Minimal code changes to allow msvc compilation * Relayout doccomments in descriptor.h * [backport#15024] Allow specific private keys to be derived from descriptor * Add test for descriptor ranges in wallet_importmulti.py * addrdb: Remove temporary files created in SerializeFileDB. * Use qInfo() if no error occurs * speed up Unserialize_impl for prevector * rest/rpc: Make mempoolinfo atomic * [Automated] Update timing.json * [Automated] Update seeds * [Automated] Update chainparams * Split checkpoints to support multiple networks * Fix sha256sums ordering * Add prefix argument to make-sha256sums.sh * gui: Drop unused return values in WalletFrame * torcontrol: Use the default/standard network port for Tor hidden services, even if the internal port is set differently * getrawtransaction: inform about blockhash argument when lookup fails * remove out-of-date comment on pay-to-witness support * Remove manual byte editing in wallet_tx_clone func test * [doc] fix the introduction of descriptors.md * Fix out-of-bounds write in case of failing mmap(...) in PosixLockedPageAllocator::AllocateLocked * test_runner: Remove unused --force option * tests: accept unicode characters on Windows * Fix wallet selector size adjustment * rest: Improve tests and documention of /headers and /block * test: Add cost_of_change parameter assertions to bnb_search_test * Fix `bitcoin-qt -version` output formatting * clarify rpcwallet flag url change * A few minor formatting fixes and clarifications to descriptors.md * test: re-enable CLI test support by using EncodeDecimal in json.dumps() * tests: Use a default of supports_cli=True (instead of supports_cli=False) * Fix macOS files description and add macos_appnap * Add metavar to match var name in help text + Change wording for better readability * Pass export privkey DER compression flag correctly * utils: Use _wfopen and _wreopen on Windows * [doc] align items in contrib init * Fix a rare failure in the peermanager tests * test: Fix intermittent sync_blocks failures * tests: Mark functional tests not supporting bitcoin-cli (--usecli) as such * Fix default control source name in PPA release script * Add routine to upgrade the block tree db to index block size * [style] Code style fixups in GetWarnings() * gui: explicitly disable "Dark Mode" appearance on macOS * qt: Use SynchronizationState enum for signals to GUI * macOS: disable AppNap during sync * util: change GetWarnings parameter to bool * use preferred shebang approach for documentation * CNetAddr: fix IsRFC2544 comment, add tests * [qt] remove unused parameter from getWarnings() * Separate chainparams constants declarations from init * rpc: require second argument only for scantxoutset start action * Templatize ValidationState instead of subclassing * Remove ValidationState's constructor * Refactor FormatStateMessage into ValidationState * gui: Throttle GUI update pace when -reindex * fix directory path for secp256k1 subtree in developer-notes * cli: fix Fatal LevelDB error when specifying -blockfilterindex=basic twice * util: Update tinyformat to upstream * tests: reset fIsBareMultisigStd after bare-multisig tests * Simplify progress reprort for the UTXO DB upgrade * Fix constant style in txdb.h * Make id const in CCoinsViewDB::Upgrade * gui: disable File->CreateWallet during startup * ui: disable 3rd-party tx-urls when wallet disabled * test: add unit test for non-standard bare multisig txs * Add the BCHN network AUR packages to the automated version bump * Add IBD build configs for BCHN network * [CMAKE] Put the network files in a separate directory * Archive release notes * Bump version to 0.22.7 ------------------------------------------------------------------- Sun Nov 08 10:17:17 UTC 2020 - marec@detebe.org - Update to version 0.22.6: * [AUR] Add PKGBUILD files for the BCHN network variant * Build the debian package for both chains * [GITIAN] Build for both chains * Add the current chain to the version string * Support the BCHN chain. * test/fuzz: add a seed corpus generation option to the test_runner * fuzz: Pass down MAKEJOBS to test_runner * tests: Test serialisation as part of deserialisation fuzzing. Test round-trip equality where possible. Avoid code repetition. * gui: Move static placeholder texts to forms * pubkey: Assert CPubKey's ECCVerifyHandle precondition * util: remove unwanted fields from bitcoin-cli -getinfo * Fix lint issue in Grasberg * Seed RNG with precision timestamps on receipt of net messages. * test: add unit test for non-standard txs with wrong nVersion * test: use fs namespace in dbwrapper unicodepath test * gui: remove macOS start on login code * Use correct C++11 header for std::swap() * Implement Grasberg DAA * Add unit test for DB creation with unicode path * Fix comparison function signature * fuzz: Run in parallel * Various fuzz test runner improvements * test: Set -use_value_profile=1 when merging fuzz inputs * fuzz: Avoid running over all inputs after merging them * test: Properly deserialize integers in little-endian * fuzz: Add option to merge input dir to test runner * tests: Add basic fuzzing harness for CNetAddr/CService/CSubNet related functions (netaddress.h) * refactor: Remove unused COINBASE_FLAGS * Changed tooltips of receive form to highlight difference between Label and Message * fix some style issues with comments * test: add functional test for non-standard txs with too large scriptSig * tests: Add key_io fuzzing harness. Fuzz additional functions in existing fuzzing harnesses. * doc: Remove bitness from bitcoin-qt help message and manpage * test: add unit test for non-standard txs with too large scriptSig * [Automated] Update timing.json * [Automated] Update seeds * [Automated] Update chainparams * Remove unnecessary forward declaration * cli: fix -getinfo output when compiled with no wallet * test: check custom ancestor limit in mempool_packages.py * Add util_ArgParsing test * remove old bootstrap relevant code * Tests: speed up fundrawtransaction test * rpc: Remove unused boost::this_thread::interruption_point * Add missing newline in util_ChainMerge test * Improve "Hide" button tool-tip message * [SECP256K1] Prevent arithmetic on NULL pointer if the scratch space is too small * tests: Add fuzzing harness for locale independence testing * tests: Add fuzzing harness for CKey related functions * Merge CCoinsViewCache's GetOutputFor and AccessCoin * [tools] add PoissonNextSend method that returns mockable time * test: rm ascii art in rpc_fundrawtransaction * Drop support of insecure miniUPnPc versions * TestShell: Simplify default setting of num_nodes and return self from setup() * Add documentation for test_shell submodule * Add TestShell class * Move parse_args and set_test_params to __init__ * Clear TestNode objects after shutdown * tests: Add fuzzing harness for serialization/deserialization of floating-points and integrals * Add closing and flushing of logging handlers * Refactor TestFramework main() into setup/shutdown * Minor refactoring to remove implied m_addr_relay_peer. * Remove network_event_loop instance in close() * added asserts to check m_addr_known when it's used * p2p: Avoid allocating memory for addrKnown where we don't need it * tests: Add fuzzing harness for V1TransportDeserializer (P2P transport) * Add override/final modifiers to V1TransportDeserializer * Make resetting implicit in TransportDeserializer::Read() * Remove oversized message detection from log and interface * Force CNetMessage::m_recv to use std::move * Use adapter pattern for the network deserializer * Remove transport protocol knowhow from CNetMessage / net processing * Refactor: split network transport deserializing from message container * Add assertion to randrange that input is not 0 * Use std::vector API for construction of test data. * test: Bump timeouts to accomodate really slow disks * test: add rpc_fundrawtransaction logging * tests: Add --valgrind option to test/fuzz/test_runner.py for running fuzzing test cases under valgrind * contrib: remove accounts from bash completion * [qa] Add shrinkdebugfile=0 to regtest bitcoin.conf * bench: Fix negative values and zero for -evals flag * [backport#12437] [Trivial] Simplify if-else blocks and more descriptive variable naming * cli: Add "headers" and "verificationprogress" to -getinfo * test: add reason checks for non-standard txs in test_IsStandard * tests: Add fuzzing harness for AS-mapping (asmap) * util: Avoid potential uninitialized read in FormatISO8601DateTime(int64_t nTime) by checking gmtime_s/gmtime_r return value * doc: Changed MiniUPnPc link to https in dependencies.md * doc/dependencies: Fix typo libsrvg->librsvg * doc: asmap release note * [backport#12409] rpc: Reject deprecated reserveChangeKey in fundrawtransaction * [backport#12542] Remove redundant includes. Conform to header include guidelines. * [backport#12204] Fix overly eager BIP30 bypass * [backport#12573] Fix compilation when compiler do not support __builtin_clz* * [backport#12452] docs: clarified systemd installation instructions in init.md for Ubuntu users. * [backport#11577] Fix warnings (-Wsign-compare) when building with DEBUG_ADDRMAN * [backport#12187] [Docs] Updating benchmarkmarking.md with an updated sample output * [backport#12143] [Doc] Fix link for BIP-159 pull request * gui: Make polling in ClientModel asynchronous * [SECP256K1] Return NULL early in context_preallocated_create if flags invalid * Add unit testing for the CompressScript functions * config, net, test: asmap feature refinements and functional tests * Fix some asmap issues * Add extra logging of asmap use and bucketing * Return mapped AS in RPC call getpeerinfo * [gui] do not enable pruning by default * Integrate ASN bucketing in Addrman and add tests * Add asmap utility which queries a mapping * Avoid unused call to GuessVerificationProgress in NotifyHeaderTip * doc: Fix some misspellings * doc: Changed miniupnp links to https * Add testcase to simulate bitcoin schema in leveldb * tests: Remove no longer needed UBSan suppressions (issues fixed). Add documentation. * gui: Improved tooltip for send amount field * [docs] Add release notes for removal of REJECT codes in logging * [validation] Fix REJECT message comments * Send amount shows minimum amount placeholder * [validation] Remove REJECT code from CValidationState * qt: Remove "Pay only required fee" checkbox * [logging] Don't log REJECT code when transaction is rejected * [validation] Fix peer punishment for bad blocks * [SECP256K1] Make autotools check for all the used openssl functions * [backport#12075] [scripts] Add missing univalue file to copyright_header.py * [bacpkort#10677] RPC Docs: addmultisigaddress is intended for non-watchonly addresses * qt: Improve BitcoinAmountField class * Remove custom fee radio group * [backport#11686#11706] Make ISSUE_TEMPLATE a bit shorter, mention hardware tests * [backport#11419] Utils: Fix launchctl not being able to stop bitcoind * [backport#11594] Improve -disablewallet parameter interaction * [backport#11676] contrib/init: Update openrc-run filename * [backport#11690] [trivial] Fix the StartupWMClass for bitoin-qt, so gnome-shell can recognize it * [backport#11140] Trivial: Improve #endif comments * [backport#11804] [docs] Fixed outdated link with archive.is * gui: don't disable the sync overlay when wallet is disabled * [CMAKE] Add an installation target for the fuzzer executables * [Automated] Update timing.json * [docs] use CashAddr throughout sendmany help * [Automated] Update seeds * [Automated] Update chainparams * [backport#12077] [Docs] Correct `sendmany` curl example * gui: Added label & tooltip for Verify Message labels * gui: Add placeholder text to the sign message field * gui: Make RPCConsole::TabTypes an enum class * Clean systray icon menu for -disablewallet mode * test: Fix combine_logs.py for windows * gui: Add shortcuts for tab tools * doc: Add missing indexes/blockfilter/basic/ to doc/files.md * tests: Add fuzzing harnesses for various Base{32,58,64} and hex related functions * util: Don't allow Base32/64-decoding or ParseMoney(…) on strings with embedded NUL characters. Add tests. * util: Don't allow Base58 decoding of non-Base58 strings. Add Base58 tests. * tests: Add fuzzing harnesses for functions parsing scripts, numbers, JSON and HD keypaths (bip32) * Add bounds checks before base58 decoding * tests: Add fuzzing harness for CheckBlock(...) and other CBlock related functions * tests: Add fuzzing harness for various functions consuming only integrals * Reset fuzzer missing corpora * Avoids a potentially shortening size_t to int cast in strauss_wnaf_ * Show addresses for "SendToSelf" transactions * tests: Add fuzzing harness for various CTx{In,Out} related functions * fuzz: Bump timeout in test_runner to accomodate for slow arm64 CPUs * Merge #16141 and #16184: build: remove GZIP export from gitian descriptors * fuzz: Log output even if fuzzer failed * [CMAKE] Link the fuzzer test_runner.py when building a fuzz target * rpc: Auto-format RPCResult * [backport#14741] doc: Indicate -rpcauth option password hashing alg * [backport#14790] Tests: Allow running rpc_bind.py --nonloopback test without IPv6 * [backport#12510] test: Add rpc_bind test to default-run tests * [backport#13339] wallet: Replace %w by wallet name in -walletnotify script * [backport#14975] qt: Refactoring with QString::toNSString() * [backport#14375] qt: Correct misleading "overridden options" label * fix name of bench executable * util: Simplify path argument for CBlockTreeDB ctor * build: Fix #include sys/poll.h to just poll.h (without sys/) * feefilter: Compute the absolute fee rather than stored rate to match mempool acceptance logic * Move a release note that belongs in the 0.22.6 release * Bump version to 0.22.6 * rpc: Move OuterType enum to header * Output a descriptor in createmultisig and addmultisigaddress * Use BlockHash in CUpdatedBlock * doc: Clarify sendrawtransaction::maxfeerate==0 help * clarify RPC rawtransaction documentation * rpc: Clarify decodescript RPCResult doc * add newline after -stdin* * [BUILDBOT] Use tokens as an immediate feedback and anti DoS mechanism * [BUILDBOT] Add facilities to manipulate tokens * [BUILDBOT] Use phabricator version from master instead of pip * Remove the Dockerfile-doxygen file * wallet/refactor: refer to CWallet immutably when possible * cli: add -stdinwalletpassphrase for (slightly more) secure CLI * rpc: fix -rpcclienttimeout 0 option * add stdin helpers for password input support * remove redundant strprintf and add missing sentence in doc * Replace GetSigningProvider with GetSolvingProvider * Move direct calls to MessageSign into new SignMessage functions in CWallet and ScriptPubKeyMan * Move key and script filling and signing from CWallet::FillPSBT to ScriptPubKeyMan::FillPSBT * Move FillPSBT to be a member of CWallet * Fix Python Docstring to include all Args. * Clear any input_errors for an input after it is signed * rpc: set default bip32derivs to true for psbt methods * Use CWallet::SignTransaction in CreateTransaction and signrawtransactionwithwallet * refactor: deduplicate the message sign/verify code * Various nits in abc_wallet_standardness * Implement CWallet::SignTransaction using ScriptPubKeyMan::SignTransaction * Add SignTransaction function to ScriptPubKeyMan and LegacyScriptPubKeyMan * Refactor rawtransaction's SignTransaction into generic SignTransaction function * psbt: check that various indexes and amounts are within bounds * [backport#14696 2/2] New regression testing for CVE-2018-17144, CVE-2012-2459, and CVE-2010-5137. * Make SignatureExtractorChecker private to its own file * [backport#14696 1/2] Added comments referencing multiple CVEs in tests and production code. * Merge #18262: bnb: exit selection when best_waste is 0 * Correct docstring param name. * qa: Fix service flag comparison check in rpc_net test * Make signrawtransaction* give an error when amount is needed but missing * [backport#16912] doc: Move doxygen intro to file for USE_MDFILE_AS_MANPAGE * test: Replace gArgs with local argsman in bench * qt: Change default size of intro frame * doc: Improve test READMEs * gui: show watch-only balance in send screen * [RPC] Fix casing in getblockchaininfo to be inline with the rest of the response * [CMAKE] Fix doxygen generation * [gui] load PSBT * [psbt] add file size limit * [gui] save PSBT to file * Move DEFAULT_MAX_RAW_TX_FEE_RATE to node/transaction.h * [util] GetFileSize * [gui] send dialog: split on_sendButton_clicked * psbt: handle unspendable psbts * [backport#16577] util: CBufferedFile fixes * doc: replace outdated OpenSSL comment in test README * [backport#15558] Do not query all DNS seed at once * Merge #17522: test: Wait until mempool is loaded in wallet_abandonconflict * Merge #13928: qa: blocktools enforce named args for amount * [build-bot] Fix database test when an extension is not present on the database file * [BUILDBOT] Remove unecessary imports of the phabricator library * [SECP256K1] Stop treating ECDH as experimental * [SECP256K1] Consistency improvements to the comments * [SECP256K1] Reorder comments/function around scalar_split_lambda * [SECP256K1] WNAF of lambda_split output has max size 129 * [SECP256K1] Rip out non-endomorphism code * [SECP256K1] Check correctness of lambda split without -DVERIFY * [SECP256K1] Make lambda constant accessible * [SECP256K1] Add tests to exercise lambda split near bounds * [SECP256K1] Add secp256k1_split_lambda_verify * [backport#16078] replace tx hash with txid in test rawtransaction * [SECP256K1] Detailed comments for secp256k1_scalar_split_lambda * [SECP256K1] Increase precision of g1 and g2 * [SECP256K1] Switch to our own memcmp function * [SECP256K1] Add fallback LE/BE for architectures with known endianness + SHA256 selftest ------------------------------------------------------------------- Fri Oct 23 11:20:08 UTC 2020 - marec@detebe.org - Update to version 0.22.5: * Add more release notes * [backport#16465 3/3] test: minor refactoring * [backport#16465 2/3] test: Replace fragile "rng" with call to random() * [backport#16465 1/3] test: Generate one block for each send in wallet_import_rescan * doc: Fix doxygen comment for SignTransaction in rpc/rawtransaction_util * test: follow-up to rpc: default maxfeerate value as BCH/kB * rpc: Use the default maxfeerate value as BCH/kB * [CI] Fail fast the builds that print error to stdout * [Automated] Update timing.json * [Automated] Update seeds * [Automated] Update chainparams * Add <datadir>/settings.json persistent settings storage. * Merge #15772: test: Properly log named args in authproxy * Merge #14664: example_test.py: fixup coinbase height argument, derive number clearly * [build-bot] Fix skipping comments in ignore list * [build-bot] Use unittest.assert* instead of plain asserts * Merge #15631: qa: mininode: Clearer error message on invalid magic bytes * [build-bot] Persist build info between redeployments * [build-bot] Correctly match hex in ignore pattern for flaky Windows cross-builds * Revert "Revert recent coin selection changes" * [backport#16845] test: Add notes on how to generate data/wallets/high_minversion * test: Set catch_system_errors=no on boost unit tests * [CI] Build secp256k1 with endomorphism disabled * doc: Add internal interface conventions to developer notes * refactor: Change createWallet, fillPSBT argument order * refactor: Change Chain::broadcastTransaction param order * refactor: Rename Chain::Notifications methods to be consistent with other interfaces methods * refactor: Rename Node::disconnect methods * refactor: Get rid of Wallet::IsWalletFlagSet method * [backport#16865] test: add some unit tests for merkle.cpp * util: Add SetupHelpOptions() * [backport#16822 3/3] gui: fix autofocus in CreateWalletActivity::askPassphrase() * util: Add ReadSettings and WriteSettings functions * [backport#16822 2/3] gui: fix passphrase labels/tooltip in createwalletdialog/askpassphrasedialog * [backport#16822 1/3] gui: rename encrypt(), blank(), disablePrivateKeys() * [backport#16224 5/5] util: Cleanup translation.h * doc: Add detailed info about Bitcoin Core files * [backport#16224 4/5] doc: Do not translate technical or extremely rare errors * [backport#16847] doc: add comments clarifying how local services are advertised * tests: Add fuzzing harness for ProcessMessage(...). Enables high-level fuzzing of the P2P layer. * test: Remove duplicate NodeContext hacks * refactor: Remove g_rpc_node global * scripted-diff: Remove g_rpc_node references * refactor: Pass NodeContext to RPC and REST methods through util::Ref * Merge #16957: 9% less memory: make SaltedOutpointHasher noexcept * Merge #16931: test: add unittests for CheckProofOfWork * [backport#16224 3/5] Make InitError bilingual * tests: Add fuzzing harness for strprintf(…) * tests: Remove unused testing code * p2p: Remove BIP61 reject messages * Elaborate on the need to re-login on Debian-based systems to use tor following usermod * doc: describe onlynet option in doc/tor.md * Less confusing documentation for `torpassword` * [backport#16224 2/5] Make ThreadSafe{MessageBox|Question} bilingual * [backport#16224 1/5]gui: Add detailed text to BitcoinGUI::message * added note that control port must be enabled and how to do that in torrc config file * Add util::Ref class as temporary alternative for c++17 std::any * rpc: Remove mempool global from miner * [CI] Improve the error snippet in diffs when a test fails * [CI] Don't run the sanitizer against the debug build * [CI] Add a debug build configuration * test: Add generatetodescriptor RPC * [rpc] Correct reconsiderblock help text, add test * doc: Remove mention of renamed mapBlocksUnlinked * [Doc] Add documentation for the new whitelist permissions * [doc] mention whitelist is inbound, and applies to blocksonly * Doc: remove text about txes always relayed from -whitelist * doc: Fix -dustrelayfee= argument docs grammar * test: Seed test RNG context for each test case, print seed * rcp: update validateaddress RPCExamples to CashAddr * Add the python extension to the macdeployqtplus script * build: Drop macports support * [scripts] Minor improvements to `macdeployqtplus` script * [CI] Add a configuration for running on native OSX agents * [secp256k1] Enable endomorphism by default * Merge #17564: rpc: Use mempool from node context instead of global * Merge #13180: Fix re-declared scoped enum as unscoped (Causes issues with some compilers) * build: skip deploying plugins we dont use in macdeployqtplus * [backport#17999 2/2] refactor: Use psbt forward declaration * [backport#16743] refactor: move LoadChainTip/RelayBlocks under CChainState * [land-bot] Give a reasonable error when a revision cannot be found * [land-bot] Allow users to specify the branch/commit in order to determine the revision to land * bitcoin-wallet: Add a missing closing parenthesis in the help * [backport#17999 1/2] Add ChainClient setMockTime, getWallets methods * [land-bot] Add a sanity rebase after running smoke tests * [backport#16757] doc: CChainState return values * [gui] intro: enable pruning by default unless disk is big * [gui] intro: add prune preference * [gui] intro: inform caller if intro was shown * [gui] add explicit prune setter * [node] add forceSetArg to interface * tests: add a test for the 'servicesnames' RPC field * rpc/net: decode the services flags in a new entry * Fix a potential use after move * Fix missing lock in the chain interface * fix gen-manpages.sh to take into account shorter `bitcoind --version` line * log: harmonize bitcoind server logging * GUI: Remove unused menu items for Windows and Linux * Don't show addresses of P2PK in decoderawtransaction * [backport#19202] log: remove deprecated `db` log category * UTXO snapshot creation (dumptxoutset) * [backport#16443 3/3] Cover UTXO set access with lock annotations * [backport#16443 2/3] refactor: have CCoins* data managed under CChainState * [backport#16443 1/3] refactor: pcoinsTip -> CChainState::CoinsTip() * [refactor] move ReadBlockFromDisk+ from validation.cpp * [wallet] Remove locked_chain from CWallet, its RPCs and tests * [wallet] Move methods from Chain::Lock interface to simple Chain * [wallet] Move getBlockHash from Chain::Lock interface to simple Chain * [wallet] Move getBlockHeight from Chain::Lock interface to simple Chain * [wallet] Move getHeight from Chain::Lock interface to simple Chain * [build-bot] Fix character escapes in ignore list * [CI] Do not wait too long for build logs to flush * [backport#17579] [refactor] Merge getreceivedby tally into GetReceived function * [land-bot] Queue the HEAD revision by default * HTML escape the wallet name in dialogs and notifications * [backport#14862]Declare BlockValidity:HEADER reserved * Remove -upgradewallet startup option * Add upgradewallet RPC * Make UpgradeWallet a member function of CWallet * Have UpgradeWallet take the version to upgrade to and an error message out parameter * Only run UpgradeWallet if the wallet needs to be upgraded * Move wallet upgrading to its own function * Add window final block height to getchaintxstats * [backport#14879]Add warning messages to the debug window * Avoid using mutable default parameter values * doc: add default bitcoin.conf locations * [Automated] Update timing.json * [Automated] Update seeds * [Automated] Update chainparams * Merge #17251: net: SocketHandler logs peer id for close and disconnect * [CI] Add required packages for building and uploading a DEB file * [land-bot] Add basic test coverage * Merge #16470: test: Fail early on disconnect in mininode.wait_for_* * Don't enforce xvfb for generating the man pages * remove unused function parameter * fix a few mutable default arguments found in python scripts * Support serialization of std::vector<bool> * gui: Ensure tx send error highlight is visible * Merge #18487: rpc: Fix rpcRunLater race in walletpassphrase * [DOC] Update gitian instructions with the new OSX SDK version * test: add executable flag for wallet_watchonly.py * [backport#16363] test: Add test for BIP30 duplicate tx * [backport#16363] test: Properly serialize BIP34 coinbase height * [backport#15801] GUI: Set the range of pruning size before loading its value * doc: Fix typos in COPYRIGHT * qt: Fix Window -> Minimize menu item on linux * [Qt] Restore < Qt5.6 compatibility for addAction * Bump version to 0.22.5 * [backport#15163] Correct units for "-dbcache" and "-prune" * wallet: Recognize -disablewallet option early * qt: Add Window menu * Bump our minimal Qt version to 5.9.5 * doc: add note on precedence of options in bitcoin.conf * Add `doc/bitcoin-conf.md` * qt: Replace deprecated QSignalMapper by lambda expressions * Fix Qt deprectation warning on MacOS * build: Replace -Wthread-safety-analysis with broader -Wthread-safety * Remove thread anotations from rcollection * Use using rather than typedef in rwcollection.h * [qa] Fix race condition in example_test.py * Fix autostart filenames on Linux * fix: tor: Call event_base_loopbreak from the event's callback * Get rid of -Wthread-safety-precise warnings * Use template function instead of void* parameter * refactor: Rename LockGuard to StdLockGuard for consistency with StdMutex * Add thread safety annotated wrapper for std::mutex * wallet: Avoid use of Chain::Lock in CWallet::GetKeyBirthTimes * wallet: Avoid use of Chain::Lock in CWallet::CreateTransaction * wallet: Avoid use of Chain::Lock in CWallet::ScanForWalletTransactions * wallet: Add BlockUntilSyncedToCurrentChain to dumpwallet * wallet: Avoid use of Chain::Lock in rescanblockchain * wallet refactor: Avoid use of Chain::Lock in CWallet::RescanFromTime * wallet: Avoid use of Chain::Lock in listsinceblock * wallet: Avoid use of Chain::Lock in importmulti * wallet: Avoid use of Chain::Lock in importwallet and dumpwallet * wallet: Avoid use of Chain::Lock in importprunedfunds * wallet refactor: Avoid use of Chain::Lock in qt wallettests * wallet: Avoid use of Chain::Lock in tryGetTxStatus and tryGetBalances * refactor: Add interfaces::FoundBlock class to selectively return block data * [backport#17261 13/13] Refactor: Replace SigningProvider pointers with unique_ptrs * [backport#17261 12/13] Cleanup: Drop unused GUI learnRelatedScripts method * [backport#17261 11/13] Refactor: Copy CWallet signals and print function to LegacyScriptPubKeyMan * [backport#17261 10/13] Box the wallet: Add multiple keyman maps and loops * [backport#17261 9/13] refactor: define a UINT256_ONE global constant * [backport#17261 8/13] HD Split: Avoid redundant upgrades * [backport#17261 7/13] Make UpgradeKeyMetadata work only on LegacyScriptPubKeyMan * [backport#17261 6/13] Store p2sh scripts in AddAndGetDestinationForScript * [backport#17261 5/13] Always try to sign for all pubkeys in multisig * [backport#17261 4/13] List output types in an array in order to be iterated over * Remove rendundant static declaration on some functions * [backport#17261 3/13] Refactor: Allow LegacyScriptPubKeyMan to be null * [backport#17719] Document better -keypool as a look-ahead safety mechanism * [backport#17261 2/13] Locking: Lock cs_KeyStore instead of cs_wallet in legacy keyman * test: rpc_users: Make variable names more clear. * test: rpc_users: Also test rpcauth.py with specified password. * test: rpc_users: Add function for testing auth params. * test: rpc_users: Add function for auth'd requests. * docs: add reduce-memory.md * [CMAKE] Drop dependency search for the native builds * Fix start with the `-min` option * Add test for GCC bug 90348 * [DOC] Add build instructions using the bitcoin-abc-dev docker container * Remove unused guard * Remove redundant stopExecutor() signal * Use size_t in CWallet::MarkDestinationsDirty * Remove redundant stopThread() signal * Cleanup SplashScreen class * rpc: Better way to allow shutdown while in generateblocks * wallet: Prefer full destination groups in coin selection * Merge #18546: Bugfix: Wallet: Safely deal with change in the address book [part 2] * Merge #18192: Bugfix: Wallet: Safely deal with change in the address book * Cleanup superfluous newline * [backport#17056] descriptors: Introduce sortedmulti descriptor * Remove archiving release notes from release process ------------------------------------------------------------------- Fri Oct 09 16:23:07 UTC 2020 - marec@detebe.org - Update to version 0.22.4: * [backport#14161] doc/descriptors.md tweaks * Cleanup unused old_label variable * Some more release notes * [buildbot] Fix ref master to be full ref name * Merge #19756: tests: add sync_all to fix race condition in wallet groups test * [buildbot] Fix getIgnoreList dangling arg * [buildbot] Remove bot message about linking PRs * Add antialiasing to traffic graph widget * Add logpath description for getrpcinfo help * Add a 'logpath' field to getrpcinfo * rpc: Clarify that block count means height excl genesis * gui: Set progressDialog to nullptr * Add 2nd arg to signrawtransactionwithkey examples * Add a docker file to setup a build container * [CMAKE] Drop native build dependency on Openssl * wallet: always do avoid partial spends if fees are within a specified range * gui: Enable console line edit on setClientModel * qt: Remove hidden columns in coin control dialog * GUI: Move QRImageWidget to its own file-pair * GUI: Refactor actual QR code rendering into new QRImageWidget::setQR * Document assumptions about compiler, add sizeof(size_t) assumptions * [Automated] Update timing.json * [Automated] Update seeds * [Automated] Update chainparams * [backport#16821] Fix bug where duplicate PSBT keys are accepted * [backport#12461] scripted-diff: Rename key size consts to be relative to their class * [buildbot] Introduce an ignore list for known flaky errors * [backport#14934] Descriptor expansion cache clarifications * Add a docker file to help node deployment * [backport#16128] Delete error-prone CScript constructor only used with FindAndDelete * [backport#17889] wallet: Improve CWallet:MarkDestinationsDirty * [backport#17843] wallet: Reset reused transactions cache * Fix release notes that got automated out of existence * [test] combine_logs: append node stderr and stdout if it exists * tests: have combine_logs default to most recent test dir * gui: move coin control OK button to the right * [backport#17924] Bug: IsUsedDestination shouldn't use key id as script id for ScriptHash * [backport#10691] Trivial: Properly comment about shutdown process in init.cpp file. * [backport#11138] Compat: Simplify bswap_16 implementation * [backport#10842] Fix incorrect Doxygen tag (@ince → @since). Doxygen parameter name matching. * [CI] Remove the Openjdk 8 dependency * Fix passing of coin control in SendMoney() * qt: update request payment button text and tab description * QA: Avoid re-reading config.ini unnecessarily * QA/mininode: Send all headers upfront in send_blocks_and_test to avoid sending an unconnected one * rpc: Validate maxfeerate with AmountFromValue * doc: Clarify RPC versioning * Doc: add information about security to the JSON-RPC doc * doc: Add external interface consistency guarantees * Cleanup copy-pasted comment * [CI] Set default git user and email during setup * doc: Clang 8 or later is required with FORCE_USE_SYSTEM_CLANG * depends: Allow building with system clang * [CMAKE] Fix version in the man2html template * build: improve sed robustness by not using sed * [CI] Factorize the Apple SDK download * build: Drop all of the ZeroMQ patches * doc: Update macOS cross compilation dependencies for Focal * qt: Fix QFileDialog for static builds * rpc: getrpcinfo docs * doc: correct bitcoinconsensus_version in shared-libraries * Mention new PSBT RPCs in psbt.md and descriptors.md * Add PSBT documentation * check that a separator is found for psbt inputs, outputs, and global map * Add regtests for HTTP status codes. * Remove unused var * Avoid redefine warning * dead code: Remove dead option in HexStr conversion * [Automated] Update seeds * doc: explain why passing -mlinker-version is required * build: macOS toolchain simplification and bump * [backport#17015] qa: Explain QT_QPA_PLATFORM for gui tests * [refactor] replace calls to Params() CWallet chainParams member * [backport#16578] Do not pass in command line arguments to QApplication * [backport#16554] test: only include and use OpenSSL where it's actually needed (BIP70) * build: target Windows 7 when building libevent and fix ipv6 usage * Move Win32 defines to CMakeLists.txt to ensure they are globally defined * windows: Set _WIN32_WINNT to 0x0601 (Windows 7) * Avoid dh_missing warnings when building the debian package * Fix obsolete debian watch * Add bitcoin-wallet to the debian package * cli: remove duplicate wallet fields from -getinfo * cli: replace testnet with chain and return network name as per BIP70. * [backport#17617] doc: unify unix epoch time descriptions * [rpc] deriveaddresses: add range to CRPCConvertParam * remove some magic mining constants in functional tests * [CMAKE] Fix version mismatch during crosscompilation due to pkg-config * Revert recent coin selection changes * [backport#17677] Activate watchonly wallet behavior for LegacySPKM only * [gitian-builder] By default, cleanup the target after use * [backport#16944][gui] watch-only wallet: copy PSBT to clipboard * [backport#16944][wallet] add fillPSBT to interface * [backport#16944][gui] send: include watch-only * [backport#16944][wallet] ListCoins: include watch-only for wallets without private keys * [backport#17537] wallet: Cleanup and move opportunistic and superfluous TopUp()s * [backport#17578] rpc: simplify getaddressinfo labels, deprecate previous behavior * [backport#17283] rpc: improve getaddressinfo test coverage, help, code docs * [backport#13136] Fix flake8 warnings in several wallet functional tests * Fix clang-tidy error * Fix shadowing of bin Python keyword * [backport#17584] wallet: replace raw pointer with const reference in AddrToPubKey * tests: Added missing tests for RPC wallet errors * Fix assertion in CKey::SignCompact * [CMAKE] Disable Jemalloc for the native OSX build * [backport#17447] wallet: Make -walletdir network only * [backport#17437] rpc: Expose block height of wallet transactions * [backport#17410] Rename `db` log category to `walletdb` (like `coindb`) * wallet: Remove trailing whitespace from potential translation strings * [backport#17405] wallet: Remove unused boost::this_thread::interruption_point * [backport#17369] Refactor: Move encryption code between KeyMan and Wallet * wallet: Report full error message in wallettool * test: tool wallet test coverage for unexpected writes to wallet * wallet: Avoid translating RPC errors when creating txs * [backport#17373] wallet: Various fixes and cleanup to keypool handling in LegacyScriptPubKeyMan and CWallet * [backport#17237 2/2] wallet: LearnRelatedScripts only if KeepDestination * wallet: Avoid translating RPC errors when loading wallets * Remove unused OpenSSL includes to make it more clear where OpenSSL is used * doc: correct logging rpc return type and example * refactor: remove walletmodeltransaction circular dep * refactor: Cleanup headers from walletmodel.h * wallet: Fix unique_ptr usage in boost::signals2 * remove walletmodel circular dependency * refactor: Move SendCoinsRecipient in own header * [SECP256K1] Install a prebuilt cmake version on OSX * [backport#17518] refactor, wallet: Nuke coincontrol circular dependency * [Automated] Update timing.json * [backport#16766] wallet: Make IsTrusted scan parents recursively * [Automated] Update chainparams * [backport#17648] doc: rename wallet-tool references to bitcoin-wallet * Remove erroneous checks in wallet_balance test * [refactor] make the finalized BlockIndex* a private member of CChainState * [backport#17237 1/2] wallet: Lock address type in ReserveDestination * [backport#17553] wallet: Remove out of date comments for CalculateMaximumSignedTxSize * Merge #17568: wallet: fix when sufficient preset inputs and subtractFeeFromOutputs * Merge #16293: test: Make test cases separate functions * [backport#17371 2/2] Refactor: Require scriptPubKey to get wallet SigningProvider * [backport#17371 1/2] Accumulate result UniValue in SignTransaction * [backport#17444] wallet: Avoid showing GUI popups on RPC errors (take 2) * Fix the debian package build for Ubuntu Bionic * [backport#16793]refactor: Avoid locking cs_main in ProcessNewBlockHeaders * REST: add "blockhashbyheight" call, fetch blockhash by height * [CI] Increase the sanitizer builds timeout * Enable BnB coin selection for preset inputs and subtract fee from outputs * Use window() instead of obsolete topLevelWidget() * Add missing dependency for install-manpages-html * Fix 0.22.3 release notes heading * build: Propagate well-known vars into depends * Remove the config.site generation from the depends * gui: update Qt base translations for macOS release * Rename testrand functions to have test in name * Add exhaustive test for extrakeys and schnorrsig * Make pubkey parsing test whether points are in the correct subgroup * Abstract out challenge computation in schnorrsig * [backport#16774]Avoid unnecessary "Synchronizing blockheaders" log messages * Disable output buffering in tests_exhaustive.c * Support splitting exhaustive tests across cores * Give exhaustive_tests count and seed cmdline inputs * refactor: move RNG seeding to testrand * Change exhaustive test groups so they have a point with X=1 * [SECP256K1] Fix some travis issues on macOS * Select exhaustive lambda in function of order * Make the curve B constant a secp256k1_fe * Delete gej_is_valid_var: unused outside tests * Make secp256k1_scalar_b32 detect overflow in scalar_low * Move exhaustive tests for recovery to module * Make group order purely compile-time in exhaustive tests * Enable -Wundef warning * travis: run bench_schnorrsig * valgrind_ctime_test: Add schnorrsig_sign * schnorrsig: Add taproot test case * schnorrsig: Add benchmark for sign and verify * schnorrsig: Add BIP-340 compatible signing and verification * schnorrsig: Add BIP-340 nonce function * schnorrsig: Init empty experimental module * Allow initializing tagged sha256 * extrakeys: Add keypair_xonly_tweak_add * extrakeys: Add keypair struct with create, pub and pub_xonly * Separate helper functions for pubkey_create and seckey_tweak_add * extrakeys: Add xonly_pubkey_tweak_add & xonly_pubkey_tweak_add_test * Separate helper function for ec_pubkey_tweak_add * extrakeys: Add xonly_pubkey with serialize, parse and from_pubkey * extrakeys: Init empty experimental module * Make the secp256k1_declassify argument constant * [SECP256K1] travis: Explicitly set --with-valgrind * Add static assertion that uint32_t is unsigned int or wider * Check assumptions on integer implementation at compile time * [SECP256K1] Check if variable=yes instead of if var is set in travis * [SECP256K1] Make scalar/field choice depend on C-detected __int128 availability * Run a Travis test on s390x (big endian) * [SECP256K1] Add macOS to the CI * [CI] Add a regression test for the build without the GUI * [backport#13868] Remove unused fScriptChecks parameter from CheckInputs * [backport#15615] Add log output during initial header sync * [backport#12951] [doc] Fix comment in FindForkInGlobalIndex * configure: Allow specifying --with[out]-valgrind explicitly * Fix Jacobi benchmarks and other benchmark improvements * Prevent ints from wrapping around in scratch space functions * Remove the extremely outdated TODO file. * Initialize field elements when resulting in infinity * tests: Initialize random group elements fully * Add test logs to gitignore * [CI] Add a regression test for the build with BIP70 disabled * refactor: Remove unused defines in bitcoinunits.h * refactor: Remove redundant conditional * [Backport] gui: Fix start timer from non QThread * qt: Fix class name of Ui::ModalOverlay, Use proper class for Ui::ReceiveCoinsDialog * Avoid linking libcrypto in the valgrind ct test. * Use preprocessor macros instead of autoconf to detect endianness * secp256k1_gej_double_nonzero supports infinity * Improve constant-timeness on PowerPC * Fix uninitialized variables in ecmult_multi test * tests: Abort if malloc() fails during context cloning tests * Remove unnecessary sign variable from wnaf_const * Recovery signing: add to constant time test, and eliminate non ct operators * remove dead store in ecdsa_signature_parse_der_lax * Undef HAVE___INT128 in basic-config.h to fix gen_context compilation * Fix some compile problems on weird/old compilers. * Fix uninit values passed into cmov * Make ec_ arithmetic more consistent and add documentation * autoconf: Use ":" instead of "dnl" as a noop * Retry if r is zero during signing * Fix typo in ecmult_const_impl.h * build: fix OpenSSL EC detection on macOS * Make src/secp256k1/src/modules/schnorr/main_impl.h non-executable * [refactor] make InvalidChainFound part of CChainState's implementation * [backport#14193][test] Add test to check mempool consistency in case of reorgs * [backport#14193] validation: Add missing mempool locks * Remove unecessary include * [backport#14193] txpool: Make nTransactionsUpdated atomic * [CI] run ThreadSanitizer builds with clang-10 * [CI] Increase the timeout for the clang-tidy build * [CMAKE] Use proper version numbers for the shared libraries * [CMAKE] Generate the windows version info file * Cleanup .gitignore * [CI] Add a Powershell script for running tests on windows * [refactor] pass CTxMempool& to DisconnectedBlockTransactions methods * [backport#19450] ci: Add tsan suppression for race in BerkeleyBatch * [backport]Give WalletModel::UnlockContext move semantics * refactor: Remove unused CExt{Pub,}Key (de)serialization methods * refactor: Remove unused signal * refactor: Use proper MAX_SCRIPT_ELEMENT_SIZE const * refactor: Remove addrdb.h dependency from node.h * Bump version to 0.22.4 ------------------------------------------------------------------- Fri Sep 25 05:31:57 UTC 2020 - marec@detebe.org - Update to version 0.22.3: * Add some release notes * Fixup event loop comments * Cleanup unused variable in automated-commits.sh * [avalanche] Fix race condition in processor destructor test * [Automated] Update seeds * Remove misplaced Q_UNUSED and others enhancements * [fix] fix tsan zeromq flakiness * [refactor] remove #include <validation.h> from zmqnotificationinterface.cpp * [Backport]test: impl. of msg_merkleblock and wait_for_merkleblock * [backport#19041] ci: tsan with -stdlib=libc++-10 * test: add BIP37 remote crash bug [CVE-2013-5700] test to p2p_filter.py * [Backport]test: replace (send_message + sync_with_ping) with send_and_ping * [Backport]test: add BIP37 'filterclear' test to p2p_filter.py * [Backport]test: Add basic test for BIP 37 * [Automated] Update timing.json * [Automated] Update chainparams * Add heading to release notes template * Merge #13924: tests: Simplify comparison in rpc_blockchain.py * [Backport]gui: hide HD & encryption icons when no wallet loaded * [CI] Update the clang-tidy build * [CMAKE] Make clang-tidy fail the build rather than trying to auto-fix * [CMAKE] Don't enable clang tidy on native builds * Fix missing braces in validationinterface.cpp * [CI] Run the circular dependencies linter on CI for each diff * [CI] Use script paths relative to the project root in the configuration * More thread safety annotation coverage * [fix] only use horizontalAdvance for Qt versions which support it * depends: Add --sysroot option to mac os native compile flags * build: remove chrono package from depends Boost * [Backport]bug-fix macos: give free bytes to F_PREALLOCATE * [lint] update expected circular dependencies * [land-bot] Introduce an autogen amendment step and update version numbers using it * [backport#12173] [Qt] Use flexible font size for QRCode image address * [backport#16194] refactoring: remove mapBlockIndex global * [backport#16194] refactoring: make pindexBestInvalid internal to validation.cpp * [backport#16194] refactoring: add block_index_candidates arg to LoadBlockIndex * IsUsedDestination should count any known single-key address * [backport#16194] refactoring: move block metadata structures into BlockManager * wallet: Tidy CWallet::SetUsedDestinationState * Prevent UB in DeleteLock() function * Decouple archiving release notes from automated commits pipeline * Decouple updating timings from automated commit pipeline * [backport#15931 9/9] Remove getBlockDepth method from Chain::interface * wallet: Refactor WalletRescanReserver to use wallet reference * [backport#15931 8/9] Remove locked_chain from GetDepthInMainChain and its callers * [backport#15931 7/9] Use CWallet::m_last_block_processed_height in GetDepthInMainChain * [backport#15931 6/9] Only return early from BlockUntilSyncedToCurrentChain if current tip is exact match * [backport#15931 5/9] Refactor some importprunedfunds checks with guard clause * [backport#15931 4/9] Add block_height field in struct Confirmation * [backport#15931 3/9] Replace CWalletTx::SetConf by Confirmation initialization list * [backport#15931 2/9] Add m_last_block_processed_height field in CWallet * Drop deprecated and unused GUARDED_VAR and PT_GUARDED_VAR annotations * [backport#15931 1/9] Pass block height in Chain::BlockConnected/Chain::BlockDisconnected * [Backport]util: Filter control characters out of log messages * Remove extra CBlockIndex declaration * test: Try once more when RPC connection fails on Windows * [Backport]Add some general std::vector utility functions * Decouple updating seeds from automated commits pipeline * Decouple updating chainparams from automated commits pipeline * Add a check for unstaged changes when generating automated commits * [backport#14930]test: pruning: Check that verifychain can be called when pruned * [buildbot] Strip out commonly used separators when detecting backports in diff summaries * Decouple AUR patch recipe from the rest of the automated commits pipeline * [land-bot] Bail early if there's nothing to land * [CMAKE] Rename the man pages generation target * [CMAKE] Silent the man pages generation * Use pure python for functional tests schnorr computation * [CMAKE] Move the manpages generation logic to doc/man * Add ChaCha20Poly1305@Bitcoin AEAD implementation * Add Poly1305 implementation * Relayout a comment * Remove dead folder obj-test * Add ChaCha20 encryption option (XOR) * update outdated links related to UAHF and use explicit MarkDown syntax * [land-bot] Fix git HEAD after checking revision * Use heredoc for outputting help text in automated commit scripts * fix MarkDown links and code formatting * [Backport] Fix Markdown formatting issues in init.md * [LINTER] Accept hard line breaks in markdown files * [CMAKE] Rename the test wrapper util * Add missing release flag to the debian package build * use markdown syntax for links (part 2) * [land-bot] Call land-patch when generating automated commits * [land-bot] Split land bot logic into distinct scripts * [land-bot] Split arc land into distinct parts in preparation for supporting non-revision patches * Remove freebsd build instructions * use markdown syntax for links * [Automated] Update timing.json * [Automated] Update seeds * [Automated] Update chainparams * [land-bot] Use --nobranch for revisions by default * Update the debian package build to use the generated man pages * Revert "[land-bot] Add buildbot support for requests to land diff patches" * Move version comparison utility functions to their own file * Update the AUR packages builds to use the generated man pages * [CMAKE] Exclude the man pages from the install-debug target * [CMAKE] Fix NSIS installing failing to find the man pages * [backport#15699] Remove no-op CClientUIInterface::[signal_name]_disconnect. Disconnect BlockNotifyGenesisWait and RPCNotifyBlockChange properly. * Bump bitcoin-abc-qt AUR package version to 0.22.3 * Bump bitcoin-abc AUR package version to 0.22.3 * [Automated] Archive release notes for version 0.22.2 * Bump version to 0.22.3 * [CI] Add gettext-base to the base image * [CMAKE] Generate the man pages at install time * [DOC] Fix missing dependency in build-osx instructions * [CMAKE] Fix issues when looking for libraries installed with homebrew * [CI] Add the failed functional tests tmp directories to artifacts * [QT] Fix QByteArray.append(const QString) deprecation warning in 5.15.1 * [DOC] Fix various doc issues, improve the linter accordingly * Merge #18866: test: Fix verack race to avoid intermittent test failures * Merge #18496: test: remove redundant sync_with_ping after add_p2p_connection * Move man2html.sh in build/config * [build] correctly set -fstack-reuse=none only for gcc * [land-bot] Add buildbot support for requests to land diff patches * [backport#17381 5/5] Add missing SetupGeneration error handling in EncryptWallet * [backport#17381 4/5] Clean up nested scope in GetReservedDestination * [backport#17381 3/5] Get rid of confusing LegacyScriptPubKeyMan::TopUpKeyPool method * [backport#17381 2/5] Pass CTxDestination to ScriptPubKeyMan::GetMetadata * [backport#17381 1/5] Add EnsureLegacyScriptPubKeyMan and use in rpcwallet.cpp * [backport#17292] Add new mempool benchmarks for a complex pool * [land-bot] Cleanup unnecessary brace expansion * [land-bot] Cleanup unused code paths for diff patches * [land-bot] Extract revision status check code * [LINTER] Add a markdown linter ------------------------------------------------------------------- Mon Sep 14 17:29:36 UTC 2020 - marec@detebe.org - Update to version 0.22.2: * [CI] Allow to configure a post build script * [CMAKE] Make the doc-rpc target actually generate the rpc docs * [Automated] Update timing.json * [Automated] Update manpages * [Automated] Update seeds * [Automated] Update chainparams * Add a bunch of release notes * [backport#19022] test: Fix intermittent failure in feature_dbcrash * [CMAKE] Add a check rule for the buildbot test * [CMAKE] Don't ship the AUR package sources as part of the release * [CI] Split the secp256k1 build in parts * [CI] Add an option to select the generator * [backport#17280] refactor: Change occurences of c_str() used with size() to data() * [backport#14047 4/4] QA: add test for HKDF HMAC_SHA256 L32 * [backport#14047 3/4] Add HKDF HMAC_SHA256 L=32 implementations * [backport#14047 2/4] QA: add test for CKey::Negate() * [backport#14047 1/4] CKey: add method to negate the key * [backport#17318] replace asserts in RPC code with CHECK_NONFATAL and add linter * [backport#16285] rpc: Improve scantxoutset response and help message * Bump bitcoin-abc AUR package version to 0.22.2 * Bump bitcoin-abc-qt AUR package version to 0.22.2 * [CI] Move the environment variables to the configuration object * Add check-buildbot CI config * [backport#15991] Bugfix: fix pruneblockchain returned prune height * [backport#17316] refactor: Replace all uses of boost::optional with our own Optional type * [backport#16911] wallet: Only check the hash of transactions loaded from disk * [backport#16689 2/2] Add missing fields in TransactionDescriptionString and others * [backport#16689 1/2] MOVEONLY : move RPC wallets helpers to TransactionDescriptionString * [CI] Don't call the build_cmake.sh script * [CI] Migrate the OSX cross build to use no script * [CI] Add cross builds configuration * [CI] Automated commits: use nameref to get the current version * [backport#16397] doc: Clarify includeWatching for fundrawtransaction * [CI] Automated commits: fix ninja not running from the build directory * Clarify source control tools cmake flag * [backport#16866] wallet: Rename 'decode' argument in gettransaction method to 'verbose' * [CI] Archive the release notes on version change * [CI] Automatically update the AUR package version * [backport#16185 3/3] doc: Add release note for the new gettransaction argument * [backport#16185 2/3] tests: Add a new functional test for gettransaction * [backport#16185 1/3] gettransaction: add an argument to decode the transaction * [backport#16503] Remove p2pEnabled from Chain interface * [backport#16144] wallet: do not encrypt wallets with disabled private keys * [land-bot] Extract out conduit token sanitization code * Rename buildbot teamcity wrapper module * [backport#16063] rpc: Mention getwalletinfo where a rescan is triggered * [backport#15880] utils and libraries: Replace deprecated Boost Filesystem functions * [backport#16071] RPC: Hint for importmulti in help output of importpubkey and importaddress * [CI] Fix wrong extension for the configuration file in the build bot * [CI] Migrate configuration file to YAML * Add an option to the build_cmake.sh to skip the build phase * Reduce noise in check-source-control-tools * [LINTER] Add a YAML linter * Add check-source-control-tools build config * [CI] Ensure the artifact directory is always created * [CMAKE] Add a target to print the current version number * [CI] Allow for describing the build from the configuration file * [backport#15917] wallet: Avoid logging no_such_file_or_directory error * [backport#15583] wallet: Log and ignore errors in ListWalletDir and IsBerkeleyBtree * Port the abcbot code into this repository * Fix detection of binary open() calls in the Python encoding linter * [backport#15426] [Doc] importmulti: add missing description of keypool option * [backport#19507] Have zmq reorg test cover mempool txns * [backport#19507] Add zmq test for transaction pub during reorg * [backport#19507] Add test case for mempool->block zmq notification * [backport#19507] Make ordering of zmq consumption irrelevant to functional test * [backport#17445] zmq: Fix due to invalid argument and multiple notifiers * [backport#16598] test: Remove confusing hash256 function in util * [backport#16404] qa: Test ZMQ notification after chain reorg * [backport#16404] qa: Refactor ZMQ test * [backport#15209] zmq: log outbound message high water mark when reusing socket * [backport#16404] doc: Add note regarding ZMQ block notification * Merge #19632: test: Catch decimal.InvalidOperation from TestNodeCLI#send_cli * [AUR] Use SSH to clone and update the repo * Update AUR package to 0.22.1 * [CMAKE] Add an install target for the secp256k1 benchmarks * [Automated] Update timing.json * [Automated] Update manpages * [Automated] Update seeds * [Automated] Update chainparams * [backport#15390] [wallet-tool] Close bdb when flushing wallet * [backport#15122] [RPC] Expand help text for importmulti changes * [backport#15334] wallet: Log absolute paths for the wallets * [backport#15102] test: Run invalid_txs.InputMissing test in feature_block * [backport#14268] Make SafeDbt DB_DBT_MALLOC on default initialization * [backport#14268] Introduce SafeDbt to handle DB_DBT_MALLOC raii-style * [backport#14268] Drop unused setRange arg to BerkeleyBatch::ReadAtCursor * [CI] Move some more path definitions to the Configuration object * [CI] Move the project root directory to the Configuration object * [backport#14653] Test coinbase category in wallet rpcs * [backport#14653] Add all category options to wallet rpc help * [CI] Clear the artifacts directory before the build * [CI] Prevent artifacts from the same diretory to fail the build * [backport#14478] Show error to user when corrupt wallet unlock fails * [backport#14890] rpc: Avoid creating non-standard raw transactions * [backport#13966] gui: Show watch-only eye instead of HD disabled * [backport#13966] Hide spendable label if private key is disabled * [AUR] A few fixes to the update-aur.sh script * [AUR] Make the update script executable * [CI] Add pandoc to the base image * [backport#16964] gui: Change sendcoins dialogue Yes to Send * [backport#15886] Do not show list for the only recipient. * [backport#15886] Show recipient list as detailedText of QMessageBox * [backport#15886]Make SendConfirmationDialog fully fledged * [backport#14771]test: Add BOOST_REQUIRE to getters returning optional * [backport#17593][test] move wallet helper functions into test library * [backport#17593][test] move mining helper functions into test library * [backport#17593][test] move string helper functions into test library * [Automated] Update manpages * [backport#17342][refactor] Remove global int nScriptCheckThreads * [backport#17342][tests] Don't use nScriptCheckThreads in the checkqueue_tests * [backport#13551] tests: Fix incorrect documentation for test case cuckoocache_hit_rate_ok * Add miner fund address list to getblocktemplate output * Add wrapper function for miner fund amount * [Automated] Update manpages * Bump version to 0.22.2 * [CI] Run automated commit builds in separate directories * [CI] Continuously update the man pages * Add more flexibility to the update-aur.sh script * Add a script to update the AUR packages * Add the files from AUR repository to contrib/aur * [CI] Prevent stdout buffer overflow ------------------------------------------------------------------- Sat Aug 29 16:23:57 UTC 2020 - marec@detebe.org - Update to version 0.22.1: * [Automated] Update manpages * [Automated] Update timing.json * [Automated] Update seeds * [Automated] Update chainparams * [CMAKE] Flag the HTML man pages as generated * [CMAKE] Transform man pages for web rendering * [CMAKE] Don't enforce LC_ALL=C.UTF-8 for the cmake test wrapper script * Cleanup autotools workaround in apptest.cpp * Kill autotools * [GITIAN] Use the new build targets to split debug info and stripped bin * [CMAKE] Better debug install targets * [CMAKE] Fix split debug not working for libs on Debian * [CMAKE] Don't install secp256k1 by default unless it is standalone * Add test coverage for getblocktemplate's sigoplimit * [CMAKE] Fix the Info.plist template minimum version * Add test coverage for getblocktemplate's mintime * Add a test for ABC-specific getblocktemplate behavior * [CMAKE] Install stripped and debug parts of targets * build: pass -fcommon when building genisoimage * [CMAKE] Make the split-debug script template executable * [backport#15971] validation: Add compile-time checking for negative locking requirement in LimitValidationInterfaceQueue * [backport#15402] Prevent callback overruns in InvalidateBlock and RewindBlockIndex * build: Skip i686 build by default in gitian * [CI] Only build the required static dependencies * Fix comment referencing incorrect activation * [CI] Cross build and run the tests for Linux 32 bits * test: remove rapidcheck integration and tests * [Automated] Update timing.json * [Automated] Update seeds * [Automated] Update chainparams * [CMAKE] Add global installation targets * [CMAKE] Wrap documentation installation into a function * [CMAKE] Properly clean the junit reports * [CMAKE] Move the test log files to test/log * [CI] Push coverage data to Teamcity statistics * Replace phonon activation time with the height it activated at * Bump version to 0.22.1 * [CMAKE] Use new default for CMP0071 * Update makeseeds * [RPC Docs] Use .html instead of .md extension for generated RPC docs * [CMAKE] Allow for installing test executables * [backport#16849] Fix block index inconsistency in InvalidateBlock() * [thread safety] prevent double lock of cs_main in calls to CChainState::UnwindBlock * [refactor] move Park and InvalidateBlock to CChainState public API * Make descriptor test deterministic ------------------------------------------------------------------- Sun Aug 16 10:38:41 UTC 2020 - marec@detebe.org - Update to version 0.22.0: * Fix a typo in a comment * Output proper coinbase value in getblocktemplate once the new coinbase rule is active * [Automated] Update manpages * Add release notes * Add the coinbase rule * [test] A few more tests for ASERT * Add aserti3-2d support * Rename seed for bitcoinforks.org * [RPC docs] Remove unused index files * Remove Eoan from PPA releases * Cleanup and revise release process * [Automated] Update timing.json * [Automated] Update seeds * [Automated] Update chainparams * Ensure two newlines in help text between RPC command and description * Fix typo in buildavalancheproof help text * Move replay protection activation to May, 15 2021 * Document 2-complement assumption in assumption.h * [backport#17304 18/18] Refactor: Move nTimeFirstKey accesses out of CWallet * [backport#17304 17/18] Refactor: Move GetKeypoolSize code out of CWallet * [backport#17304 16/18] Refactor: Move RewriteDB code out of CWallet * [backport#17304 15/18] Refactor: Move SetupGeneration code out of CWallet * [backport#17304 14/18] Refactor: Move HavePrivateKeys code out of CWallet::CreateWalletFromFile * [backport#17304 13/18] Refactor: Move Upgrade code out of CWallet::CreateWalletFromFile * [backport#17304 12/18] Refactor: Move MarkUnusedAddresses code out of CWallet::AddToWalletIfInvolvingMe * [backport#17304 11/18] Refactor: Move GetMetadata code out of getaddressinfo * [backport#17304 10/18] Refactor: Move LoadKey LegacyScriptPubKeyMan method definition * [backport#17304 9/18] Refactor: Move SetAddressBookWithDB call out of LegacyScriptPubKeyMan::ImportScriptPubKeys * [backport#17304 8/18] refactor: Replace UnsetWalletFlagWithDB with UnsetBlankWalletFlag in ScriptPubKeyMan * [backport#17304 7/18] Refactor: Remove UnsetWalletFlag call from LegacyScriptPubKeyMan::SetHDSeed * [backport#17304 6/18] Remove SetWalletFlag from WalletStorage * [backport#17304 5/18] Refactor: Move SetWalletFlag out of LegacyScriptPubKeyMan::UpgradeKeyMetadata * [backport#17304 4/18] Refactor: Move SetAddressBook call out of LegacyScriptPubKeyMan::GetNewDestination * [backport#17304 3/18] Refactor: Add new ScriptPubKeyMan virtual methods * [backport#17304 2/18] Refactor: Declare LegacyScriptPubKeyMan methods as virtual * [backport#17304 1/18] MOVEONLY: Reorder LegacyScriptPubKeyMan methods * [backport#16383 3/3] tests: functional watch-only wallet tests * [backport#16383 2/3] rpcwallet: document include_watchonly default for watchonly wallets * [backport#16383 1/3] rpcwallet: default include_watchonly to true for watchonly wallets * Bump version to 0.22.0 * Clean up separated ban/discourage interface * [backport#18417 3/3] tests: Add fuzzing harness for functions in net_permissions.h * [backport#18417 2/3] tests: Add fuzzing harness for functions in timedata.h * [backport#18417 1/3] tests: Add fuzzing harness for functions in addrdb.h ------------------------------------------------------------------- Fri Aug 07 13:01:44 UTC 2020 - marec@detebe.org - Update to version 0.21.13: * [Automated] Update manpages * [backport#18206] tests: Add fuzzing harness for bloom filter classes (CBloomFilter + CRollingBloomFilter) * [backport#17300] LegacyScriptPubKeyMan code cleanups * [backport#17260 3/3] Refactor: Split up CWallet and LegacyScriptPubKeyMan and classes * [backport#17260 2/3] MOVEONLY: Move key handling code out of wallet to keyman file * [backport#17260 1/3] Move wallet enums to walletutil.h * [autotools] Fixed fuzzer build * Ignore cppcheck syntax errors related to prevector * Fix signed shift by 31 bits * Allow large integers to be used in maxtries * Polish release notes * Add signed right shift assumption in assumptions.h * [Automated] Update timing.json * [Automated] Update seeds * [Automated] Update chainparams * [backport#16798] Refactor rawtransaction_util's SignTransaction to separate prevtx parsing * [backport#17154 3/3][wallet] Remove `state` argument from CWallet::CommitTransaction * [backport#17154 2/3][wallet] Remove return value from CommitTransaction() * [backport#17154 1/3][wallet] Add doxygen comment to CWallet::CommitTransaction() * [backport#15894 3/3] Make AbortNode() aware of MSG_NOPREFIX flag * [backport#15894 2/3] Add MSG_NOPREFIX flag for user messages * [backport#15894 1/3] Prepend the error/warning prefix for GUI messages * Remove language sub-route from RPC doc permalinks * [backport#15457] Check std::system for -[alert|block|wallet]notify * [CI] Increase build-coverage timeout * [backport#17070] wallet: Avoid showing GUI popups on RPC errors * [backport#15450 5/5] Add Create Wallet menu action * [backport#15450 4/5] Expose wallet creation to the GUI via WalletController * [backport#15450 3/5] Add CreateWalletDialog to create wallets from the GUI * [backport#15450 2/5] Optionally allow AskPassphraseDialog to output the passphrase * [backport#15450 1/5] gui: Refactor OpenWalletActivity * [CI] Make the bench use the ENABLE_JUNIT_REPORT option and use it on CI * [backport#16394] Allow createwallet to take empty passwords to make unencrypted wallets * [backport#15896] QA: feature_filelock, interface_bitcoin_cli: Use PACKAGE_NAME in messages rather than hardcoding Bitcoin Core * [backport#16524] Wallet: Disable -fallbackfee by default * [backport#16402] Remove wallet settings from chainparams * [CMAKE] Generate textual coverage report * [TRAVIS] Install cmake version 3.16 * [CMAKE] Run the leveldb tests serially * [GITIAN] Stop distributing the *-unsigned.tar.gz archive * [backport#17203] wallet: Remove unused GetLabelName * [backport#17138 2/2][wallet] Remove pruning check for -rescan option * [backport#17138 1/2][wallet] Remove package limit config access from wallet * [CMAKE] Bump minimum cmake to 3.16 * Fix wallet_reorgsrestore functional test flakiness * [GITIAN] Build with cmake 3.16 from the backport repository * [DOC] Improve instructions for setting up shellcheck * [Automated] Update timing.json * [Automated] Update seeds * [Automated] Update chainparams * [backports#18561#18633] test: Properly raise FailedToStartError when rpc shutdown before warmup finished * [backport#17633] tests: Add option --valgrind to run the functional tests under Valgrind * [backport#15963] [tests] Make random seed logged and settable * [backport#15927] [tests] log thread names by default in functional tests * [backport#15415] [test] functional: allow custom cwd, use tmpdir as default * [backport#14519] tests: add utility to easily profile node performance with perf * [backport#14465] tests: Stop node before removing the notification file * Do not generate RPC doc index files multiple times * Fix RPC example for finalizeblock * Fixup comment regarding finalized block * [CI] Prevent copying undesired test/tmp content to the artifacts * [DOC] clang-*-8 tools are now in the backport repository for Debian 10 * Don't generate junit report for functional test unless being asked to * [CI] Enable Junit reporting via the build system and use it in scripts * Disable Jemalloc for the debian package builds * [backport#13546] wallet: Fix use of uninitialized value bnb_used in CWallet::CreateTransaction(...) * [backport#14103] docs: Fix broken Doxygen comments * [backport#16624 4/4] Add a test wallet_reorgsrestore * [backport#16624 3/4] Modify wallet tx status if has been reorged out * [backport#16624 2/4] Remove SyncTransaction for conflicted txn in CWallet::BlockConnected * [backport#16624 1/4] Encapsulate tx status in a Confirmation struct * [CMAKE] Move the functional tests junit reports to the test/junit dir * [backport#15906] [wallet] Move min_depth and max_depth to coin control * [CMAKE] Generate junit output for boost unit tests * [backport#16952] gui: make sure to update the UI when deleting a transaction * [backport#16796] wallet: Fix segfault in CreateWalletFromFile * [backport#16620] util: Move ResolveErrMsg to util/error * [backport#16745] wallet: Translate all initErrors in CreateWalletFromFile * [backport#16557] [wallet] restore coinbase and confirmed/conflicted checks in SubmitMemoryPoolAndRelay() * Set correct markdown extension for generated RPC docs * Bump version to 0.21.13 * [backport#16572] wallet: Fix Char as Bool in Wallet * Add golang to the CI base image * [backport#16451 3/3][wallet] Remove CMerkleTx serialization logic * [backport#16451 2/3][wallet] Flatten CWalletTx class hierarchy * [backport#16451 1/3][wallet] Move CMerkleTx functions into CWalletTx * Add Kent Beck link to CONTRIBUTING.md * [backport#16399 3/3] Use switch on status in RpcWallet * [backport#16399 2/3] Return error for ignored passphrase through disable private keys option * [backport#16399 1/3] Place out args at the end for CreateWallet * [backport#15901 2/2] remove extraneous scope * [backport#15901 1/2] wallet: log on rescan completion ------------------------------------------------------------------- Tue Jul 28 16:00:11 UTC 2020 - marec@detebe.org - Update to version 0.21.12: * Arc lint everything * [backport#15530] doc: Move wallet lock annotations to header * [Automated] Update manpages * Trigger DAA underflow in DAA unit tests * [backport#15853] wallet: Remove unused import checkpoints.h * [backport#15491] wallet: Improve log output for errors during load * [backport#14138] wallet: Set encrypted_batch to nullptr after delete. Avoid double free in the case of NDEBUG. * [backport#13657] wallet: assert to ensure accuracy of CMerkleTx::GetBlocksToMaturity * [backport#16502] wallet: Drop unused OldKey * [backport#15709] wallet: Do not add "setting" key as unknown * [backport#16475 2/2] wallet: Rename CWalletKey to OldKey * [backport#16475 1/2] wallet: Enumerate walletdb keys * [CMAKE] Add the test suite to the log name * Fix the expected naming violation in test_runner.py * [backport#15588 3/3] Remove ReadVersion and WriteVersion * [backport#15588 2/3] Log the actual wallet file version * [backport#15588 1/3] Remove nFileVersion from CWalletScanState * Remove the rule that prevent retargeting on regtest from the EDA * [backport#15870 3/3][doc] rpcwallet: Only fail rescan when blocks have been pruned * [backport#15870 2/3] scripted-diff: Bump copyright headers in wallet * [backport#15870 1/3] wallet: Only fail rescan when blocks have actually been pruned * [backport#15730 4/4] doc: Add release notes for 15730 * [backport#15730 3/4] rpc: Show scanning details in getwalletinfo * [backport#15730 2/4] wallet: Track current scanning progress * [backport#15730 1/4] wallet: Track scanning duration * [backport#16786] test: add unit test for wallet watch-only methods involving PubKeys * Remove BIP9 miner fund. * [Automated] Update timing.json * [Automated] Update seeds * [Automated] Update chainparams * [refactor] factor CBlockIndex out of chain.h * [backport#16361] Remove redundant pre-TopUpKeypool check * [backport#16753] wallet: extract PubKey from P2PK script with Solver * Fix OSX SDK caching in Gitian builds * [GITIAN] Use docker for the build on CI * [LINTER] Fix syntax error in the cppcheck linter * Add build config for documentation, including RPC docs * [refactor] remove global mapBlockIndex access from unparkblock RPC * [GITIAN] Add documentation for building using Docker * Renaming bswap_tests test case so that the name does not collide with the test suite name * [refactor] remove global mapBlockIndex access from parkblock RPC * [CI] Store functional tests duration with ms resolution in Junit * [GITIAN] Remove vagrant support documentation for the gitian builds * [GITIAN] Fix instructions for extracting the OSX SDK * [GITIAN] Update scripts and docs to use the local gitian version * [CMAKE] Don't distribute gitian as part of our sources package * [GITIAN] Don't ignore target-bin/ * [GITIAN] Pull gitian sources in our repo * Generate RPC docs using regtest * [lint] update Avalanche change to circular dep status * [refactor] access mapBlockIndex via function in Avalanche code * [backport#17357 2/2] tests: Add fuzzing harness for Bech32 encoding/decoding * [backport#17357 1/2] tests: Move CaseInsensitiveEqual to test/util/str * Pass chain params down to GetNextWorkRequired * Move CustomArgumentsFixture to an apropriate place * Fix providing an explicit branch/ref to land-via-bot * [backport#17051] tests: Add deserialization fuzzing harnesses * Initialize nVersionDummy in txdb.cpp * [avalanche] Add a ValidationState for Proof * [CMAKE] Optionally install bitcoin-bench * Move difficulty adjustement realted stuff in the pow folder * [backport#15040] Add workaround for QProgressDialog bug on macOS * Merge #16302: test: Add missing syncwithvalidationinterfacequeue to wallet_balance test * Merge #15866: test: Add missing syncwithvalidationinterfacequeue to wallet_import_rescan * Fix some functional test executable flags * [CI] Allow for referencing multiple templates in a build configuration * [CI] Rename environment configuration to env * [CI] Run gitian builds through the build configuration * [CI] Don't create the unused sanitizer log directory * [backport#17136] tests: Add fuzzing harness for various PSBT related functions * [CI] Fix wrong key for the environment variables in build configuration * [Automated] Update timing.json * [Automated] Update seeds * [Automated] Update chainparams * Add Doxyfile to build-master artifacts * Install base-devel by default for the example Arch Linux build in build-unix.md * Use ninja for the debian packages build * Disable optional Jemalloc for the example Arch Linux build in build-unix.md * Add --distro flag to PPA release script * [backport#10953] [Refactor] Combine scriptPubKey and amount as CTxOut in CScriptCheck * [GITIAN] Make the setup feature from gitian-build.py create a debian VM * Use cat to output help text in PPA release script * Refactor FormatStateMessage() to better match Core * Bump version to 0.21.12 * Merge #15921: validation: Tidy up ValidationState interface * Merge #17746: refactor: rpc: Remove vector copy from listtransactions * Fix uninitialized variable caught by cppcheck * [refactor] refactor FinalizeBlockAndInvalidate * [land-bot] Pass committer name/email to land bot endpoint * [validation] Remove fMissingInputs from AcceptToMemoryPool() * [avalanche] Add buildavalanchproof RPC call * [backport#17291] tests: Add fuzzing harness for ISO-8601 related functions * [backport#17083] tests: Add fuzzing harness for various CScript related functions * [avalanche] Do not add invalid proof in PeerManager * [avalanche] Generate proof that verify * [avalanche] Move makeRandomProof to the test framework * [avalanche] Change the addavalanchenode RPC so that it return if the operation succeeded * Merge #14524: Trivial: fix typo * Use RPCTypeCheck in avalanche's RPC * [backports] tests: Skip unnecessary fuzzer initialisation. Hold ECCVerifyHandle only when needed. * [correction] fix comment style for D6878 * [validation] Remove useless ret parameter from Invalid() * [avalanche] Create addavalanchenode RPC call * [backport#17018] tests: Add Parse(...) (descriptor) fuzzing harness * [backport#17113] tests: Add fuzzing harness for descriptor Span-parsing helpers * [backport#16887 3/3] test: add unit tests for Span-parsing helpers * [backport#16887 2/3] Add documenting comments to spanparsing.h * [backport#16887 1/3] Abstract out some of the descriptor Span-parsing helpers * [avalanche] Add capability to verify proofs * [validation] Remove unused first_invalid parameter from ProcessNewBlockHeaders() * [validation] Remove error() calls from Invalid() calls * [backport#17080] consensus: Explain why fCheckDuplicateInputs can not be skipped and remove it ------------------------------------------------------------------- Fri Jul 10 14:55:12 UTC 2020 - marec@detebe.org - Update to version 0.21.11: * [Automated] Update manpages * Ignore cppcheck error in EraseOrphanTx() * [avalanche] First iteration on Proof * [CI] Bump timeouts for cross builds * Improve banman behavior comments * Update -banscore and -bantime help text * Remove confusing statement from setban RPC help text * Clarify connection dropped message * [secp256k1] Do not use unitialized multiset in multiset benchmark * Report most cppcheck errors * arc lint everything * [Automated] Update timing.json * [Automated] Update chainparams * [Automated] Update seeds * [avalanche] Remove Peer::score * [avalanche] Remove ability to rescore a peer * [avalanche] Use Proof in Processor * [backport#13910] Log progress while verifying blocks at level 4 * [SECP256K1] Fix the Travis build wrong targets names * [backport#19188] test: Avoid overwriting the NodeContext member of the testing setup [-Wshadow-field] * [avalanche] Kill PeerManager::addPeer * [avalanche] Remove PeerManager::addNodeToPeer * [avalanche] Attach Proof to each Peer * [avalanche] Use ProofId instead of PeerId * Put CConnmanTest in an anonymous namespace * [backport#15245] remove deprecated mentions of signrawtransaction from fundraw help * [backport#13310] Report progress in ReplayBlocks while rolling forward * Merge #14734: fix an undefined behavior in uint::SetHex * [avalanche] Rename getSuitableNodeToQuery => selectNode * [avalanche] More namespace instead of smurfnaming * [avalanche] Use namespace instead of smurfnaming * Factor out SaltedUint256Hasher * [avalanche] Use PerrManager instead of ad hoc logic in AvalancheProcessor * [refactor] add const CChainParams& m_params to interface::ChainImpl * [CI] Add a runOnDiff flag to the build configurations * [avalanche] Factor AvalancheNode from PeerManager * [avalanche] Move AvalancheNode to its own file * [avalanche] Remove getPubkey API * [avalanche] Add a facility to update node's timeout * [avalanche] Add facilities to delete nodes from the PeerManager * [avalanche] Add node related functions to the peermanager * [avalanche] Add the notion of Peer to the PeerManager * [avalanche] Use an hash_unique key for the node/round index in QuerySet * Move NO_NODE to net.h * [backport#15267] doc: explain AcceptToMemoryPoolWorker's coins_to_uncache * [avalanche] Use std::chrono for time constants * [avalanche] Use constexpr for global constants * [CI] Improve teamcity error reporting by setting the failure message * [avalanche] Bail when selecting a peer fails too many times * [avalanche] Implement compaction for the PeerManager * Cleanup leftover phononactivationtime option * [backport#16415] Get rid of PendingWalletTx class. * [backport#16208 2/2] Restrict lifetime of ReserveDestination to CWallet::CreateTransaction * [backport#16208 1/2] CreateTransaction calls KeepDestination on ReserveDestination before success * [Automated] Update timing.json * [Automated] Update chainparams * [Automated] Update seeds * [backport#17009] tests: Add EvalScript(...) fuzzing harness * [linter] add exceptions to include guards and file name linters * [backport#17076] tests: Add fuzzing harness for CheckTransaction(...), IsStandardTx(...) and other CTransaction related functions * Cleanup unused --with-phononactivation from test_framework * Cleanup phonon activation in functional tests * [backport#16237 3/3] Add GetNewChangeDestination for getting new change Destinations * [backport#16237 2/3] Replace CReserveKey with ReserveDestinatoin * [backport#16237 1/3] Add GetNewDestination to CWallet to fetch new destinations * [backport#16542 4/4] Additional tests for other failure cases * [backport#16542 3/4] Check error messages in descriptor tests * [backport#pr16542 2/4] Give more errors for specific failure conditions * [backport#16542 1/4] Return an error from descriptor Parse that gives more information about what failed * [avalanche] Manipulate peers via PeerId * [avalanche] Make peer score an uint32_t instead of an uint64_t * [backport#15639 3/3] bitcoin-wallet tool: Drop libbitcoin_server.a dependency * [backport#15492 2/2] [cleanup] Remove unused CReserveKey * [backport#15492 1/2] [rpc] simplify generate RPC * [fix] replace leftover dustRelayFee symbols in wallet/wallet.cpp * [fix] actually move tx_check.cpp from libserver to libbitcoin consensus * [backport#15492] [rpc] remove deprecated generate method * [avalanche] Build Slot using start and score rather than start/stop * [avalanche] Early bail when no matchign slot exists * [avalanche] Track slots as start+score rather than start/stop * Add an exception for the TSAN lock-order-inversion on reverselock_tests * Add an exception for UBSAN vptr on boost::unit_test::decorator::timeout * [avalanche] Abstract the Slot infos so that layout can be changed easily * [avalanche] separate avalanche.{h|cpp} into more relevent files * Enable Axion upgrades in functional tests * Enable Axion upgrades in unit tests * Add facility and test for checking if Axion upgrade is enabled * [avalanche] Use utility method to find slots * [avalanche] Add the ability to remove and rescore peers * [avalanche] Introduce a datastructure to keep track of peers * Merge #14543: [QA] minor p2p_sendheaders fix of height in coinbase * [CI] Log sanitizers output to stdout instead of log files * Move NodeContext from TestingSetup to BasicTestingSetup * test: Check that wait_until returns if time point is in the past * refactor: Make scheduler methods type safe * [CI] Run the check target instead of a list of subtargets * [seeder] Use testutil library in seeder tests * Move avalanche in its own folder * Move minimum boost version to 1.59 * build: Create test utility library from src/test/util/ * Remove dead checkpoint test * Bump version to 0.21.11 * [CI] Increase stream buffer limit for build subprocess * [CI] Fix wrong configuration when there is no template * Add missing fi in secp256k1's travis script * [CI] Refactor the build by making it a class * [CI] Make the build configuration a class * [CI] Filter what is printed to the console and log it to files * [CI] Manage the build artifacts from the configuration * [backport#17069] tests: Pass fuzzing inputs as constant references ------------------------------------------------------------------- Sat Jun 27 11:10:40 UTC 2020 - marec@detebe.org - Update to version 0.21.10: * [Automated] Update manpages * [CI] Ensure llvm-symbolizer is available in PATH * Separate reason for premature spends (coinbase/locktime) * Assert validation reasons are contextually correct * [avalanche] Add test for the parking scenario * [refactor] Update some comments in validation.cpp as we arent doing DoS there * [refactor] Drop unused state.DoS(), state.GetDoS(), state.CorruptionPossible() * [CI] Add a templating system to the configuration * [CI] Include the teamcity-messages library and display the build name * CorruptionPossible -> TX_WITNESS_MUTATED * Fix build path in build-make-generator * Use reason for checking for sigcheck in txvalidationcache * [CI] Cleanup unused build-configurations wrapper * [CI] Make sure every build directory is under a common 'build' directory * scripted-diff: Remove DoS calls to CValidationState * [refactor] Prep for scripted-diff by removing some \ns which annoy sed. * Allow use of state.Invalid() for all reasons * Fix handling of invalid headers * [CI] Allow for setting environment variables from the configuration file * [Automated] Update timing.json * [Automated] Update chainparams * [Automated] Update seeds * Use BlockHash in net_processing.cpp * [refactor] Use Reasons directly instead of DoS codes * CorruptionPossible -> BLOCK_MUTATED * [CI] Set build timeout in the configuration file * [LINTER] Enforce shellcheck >= 0.7.0 * Merge #14051: [Tests] Make combine_logs.py handle multi-line logs * Merge #14816: Add CScriptNum decode python implementation in functional suite * Merge #14658: qa: Add test to ensure node can generate all rpc help texts at runtime * [CI] Fix a bug where CI scripts are not able to build in directories that are not one level below the project root * [CI] Convert the build-configurations.sh script to python, read config * [CI] Split build-configurations.sh into individual scripts * [CI] Extract the CI build facitilties to it's own script and source it * [land-bot] Skip sanity check during arc patch * Merge #18412: script: fix SCRIPT_ERR_SIG_PUSHONLY error string * Merge #11418: Add error string for CLEANSTACK script violation * Add jemalloc as a dependency on osx * Update .arcconfig phabricator URI to the new syntax * LookupBlockIndex -> CACHED_INVALID * [refactor] Drop redundant nDoS, corruptionPossible, SetCorruptionPossible * [refactor] Add useful-for-dos "reason" field to CValidationState * [CI] Wrap build_depends.sh on ibd.sh into functions * [CI] Setup don't need to be a function * Do not resuse state in checkpoints_tests.cpp * Make sigcheck violation report invaid rather than non standard * [backport#15751] Speed up deriveaddresses for large ranges * [backport#16326] [RPC] add new utxoupdatepsbt arguments to the CRPCCommand and CPRCConvertParam tables * [backport#15427 3/3] Add support for descriptors to utxoupdatepsbt * [backport#15427 2/3] Abstract out UpdatePSBTOutput from FillPSBT * [backport#15427 1/3] Abstract out EvalDescriptorStringOrObject from scantxoutset * [backport#16512] rpc: Shuffle inputs and outputs after joining psbts * [backport#10574] Remove includes in .cpp files for things the corresponding .h file already included * [CI] Remove duplicated `cd` to the build dir with build-make-generator * Clean up banning levels * [refactor] drop IsInvalid(nDoSOut) * [CI] Wrap the build_autotools.sh script in a function * [refactor] Refactor misbehavior ban decisions to MaybePunishNode() * [CI] Make the build_autotools.sh script take a list of targets * [CI] Wrap the build_cmake.sh environment and script path into a function * [CI] Add an option to select the compiler to build_cmake.sh * Remove double if in tx_verify.cpp * test: Add basic test for BIP34 * [CI] Make build-configurations.sh take the build name as an argument * [CI] Don't print an error if there is no sanitizer log files * [CI] Add a build plan to run clang-tidy on the changed files * Revert "[CI] Install the latest wine version from the winehq repository" * test: add invalid tx templates for use in functional tests * [refactor] rename stateDummy -> orphan_state * Merge #13418: Docs: More precise explanation of parameter onlynet * Merge #13457: tests: Drop variadic macro * [backport#16322] wallet: Fix -maxtxfee check by moving it to CWallet::CreateTransaction * [backport#14935] tests: Test for expected return values when calling functions returning a success code * [backport#16079] wallet_balance.py: Prevent edge cases * [backport#14818] Bugfix: test/functional/rpc_psbt: Remove check for specific error message that depends on uncertain assumptions * [avalanche] Increase quorum size in the test. * [avalanche] Remove blocks not worth pollling from the vote reccords rather than just ignore them * [CI] Install the latest wine version from the winehq repository * Merge #18563: test: Fix unregister_all_during_call cleanup * Merge #18551: Do not clear validationinterface entries being executed * Merge #18524: refactor: drop boost::signals2 in validationinterface * Merge #16688: log: Add validation interface logging * Merge #15999: init: Remove dead code in LoadChainTip * [backport#15559] doc: correct analysepsbt rpc doc * Merge #18338: Fix wallet unload race condition * Add cppcheck to base image setup * Merge #13577: logging: avoid nStart may be used uninitialized in AppInitMain warning * Merge #12401: Reset pblocktree before deleting LevelDB file * Merge #15486: [addrman, net] Ensure tried collisions resolve, and allow feeler connections to existing outbound netgroups * Merge #15824: docs: Improve netbase comments * Merge #16412: net: Make poll in InterruptibleRecv only filter for POLLIN events. * Fix missing braces * Merge #16355: refactor: move CCoinsViewErrorCatcher out of init.cpp * [backport#15986] Add unmodified-but-with-checksum to getdescriptorinfo * [backport#15986] Factor out checksum checking from descriptor parsing * [CI] Temporarly fix adoptopenjdk8 failure * tests: Make coins_tests/updatecoins_simulation_test deterministic * tests: Make updatecoins_simulation_test deterministic * [Automated] Update timing.json * [Automated] Update seeds * [Automated] Update chainparams * Merge #16188: net: Document what happens to getdata of unknown type * [backport#15744] refactor: Extract ParseDescriptorRange * [backport#15497] Make deriveaddresses use stop/[start,stop] notation for ranges * [backport#15497] Use stop/[start,stop] notation in importmulti desc range * [backport#15497] Add support for stop/[start,stop] ranges to scantxoutset * [backport#15497] Support ranges arguments in RPC help * [backport#15497] Add ParseRange function to parse args of the form int/[int,int] * [backport#15368] Add checksums to descriptors.md * [backport#15368] Make descriptor checksums mandatory in deriveaddresses and importmulti * [backport#15368] Add getdescriptorinfo to compute checksum * generatetoaddress should mention ABC wallet not Core * Merge #14632: Tests: Fix a comment * Leftovers from PR14119 * [backport#15368] Descriptor checksum * [CI] Make the coverage report available to Teamcity * [CI] Add a build-coverage target * [Qt] Fix deprecated QButtonGroup::buttonClicked event * [Qt] Fix deprecated QString::SplitBehavior (now Qt::SplitBehavior) * [Qt] Fix deprecated QSignalMapper::mapped event * [avalanche] Poll all candidate tips * Always enable sigcheck in the mempool admission * Use the new Check facility in wallet/rpcwallet.cpp * [backport#12727] Remove unreachable help conditions * [RPC docs] Fix build paths * [backport#15337] rpc: Fix for segfault if combinepsbt called with empty inputs * [backport#11590] [Wallet] always show help-line of wallet encryption calls * [backport#17362] test: speed up wallet_avoidreuse, add logging * [backport#16917] tests: Move common function assert_approx() into util.py * [backport#16659] refactoring: Remove unused includes * Use the new Check facility in rpc/rawtransaction.cpp * Bump version to 0.21.10 * Use the new Check facility in rpc/misc.cpp * Use the new Check facility is rpc/blockchain.cpp * Use the new Check facility in rpc/net.cpp * Use the new Check facility is wallet/rpcdump.cpp * [Qt] Fix deprecated QDateTime(const QDate &) * [Qt] Fix deprecated pixmap() return by pointer with Qt 5.15 * Use the new Check facility in rpc/mining.cpp * Merge #14719: qa: Check specific reject reasons in feature_block * Use Check facility is ZeroMQ RPC * Use the new Check facility in rpc/server.cpp * Update Bitcoin ABC RPC to use the Check facility * [backport#16227 8/8] Move WatchOnly stuff from SigningProvider to CWallet * Remove activation logic for chained transaction limit * [avalanche] Process AvalancheResponse and act based on the result. * [Qt] Remove unused WindowFlags parameters * Consistently use the QT_VERSION_CHECK macro * Cleanup Qt branches on old unsupported version * [CI] Fix wrong path to bitcoind binary on build-ibd-* * Make CLIENT_VERSION constexpr * Continue relaying transactions after they expire from mapRelay * Always repport proper sigcheck count * CBlockTreeDB::ReadReindexing => CBlockTreeDB::IsReindexing * Update avalanche integration test to use a quorum * [backport#16227 7/8] Remove CCryptoKeyStore and move all of it's functionality into CWallet * [backport#16227 6/8] Move various SigningProviders to signingprovider.{cpp,h} * [backport#16227 5/8] Move KeyOriginInfo to its own header file * [backport#16227 4/8] scripted-diff: rename CBasicKeyStore to FillableSigningProvider * [backport#16227 3/8] Move HaveKey static function from keystore to rpcwallet where it is used * [backport#16227 2/8] Remove CKeyStore and squash into CBasicKeyStore * [backport#16227 1/8]Add HaveKey and HaveCScript to SigningProvider * [CI] Prevent ccache crosstalk by building in separate directories * Merge #14700: qa: Avoid race in p2p_invalid_block by waiting for the block request * [backport#16026] Ensure that uncompressed public keys in a multisig always returns a legacy address * [backport#15831] test: Add test that addmultisigaddress fails for watchonly addresses * [LINTER] Check for missing explicit * [CMAKE] Fail early if a lib header is missing, remove garbage in version * [CMAKE] Don't require jemalloc for systems where it's the default * Fix single parameter constructors not marked "explicit" * Lint everything ------------------------------------------------------------------- Sat Jun 13 14:53:03 UTC 2020 - marec@detebe.org - Update to version 0.21.9: * [Automated] Update manpages * Add a lock on cs_main while modifying the config in setexcessiveblock * txmempool: Remove unused default value MemPoolRemovalReason::UNKNOWN * Merge #16092: Don't use global (external) symbols for symbols that are used in only one translation unit * Merge #15622: Remove global symbols: Avoid using the global namespace if possible * Merge #12980: Allow quicker shutdowns during LoadBlockIndex() * Replace automatic bans with discouragement filter * [CI] Do not enable debug for TSAN builds * [backport#13531] doc: Clarify that mempool txiter is const_iterator * [backport#16908] txmempool: Make entry time type-safe (std::chrono) * [backport#16908] util: Add count_seconds time helper * [backport#16908] test: mempool entry time is persisted * [backport#14931] test: mempool_persist: Verify prioritization is dumped correctly * [backport#14704]: doc: add detached release notes for #14060 * Drop unused reverselock.h * scheduler: switch from boost to std * sync.h: add REVERSE_LOCK * scheduler: don't rely on boost interrupt on shutdown * UninterruptibleSleep in avalanche test * test: Fix bug in blockfilter_index_tests. * [Automated] Update timing.json * [Automated] Update seeds * [Automated] Update chainparams * [backport#16117] util: Remove unused MilliSleep * [backport#16117] scripted-diff: Replace MilliSleep with UninterruptibleSleep * [backport#16117] util: Add UnintrruptibleSleep * [backport#17091] tests: Add test for loadblock option and linearize scripts * Use std::condition_variable and sync.h instead of boost in scheduler_tests.cpp * [backport#15305] [validation] Crash if disconnecting a block fails * [rpc] expose ability to mock scheduler via the rpc * Make the RPCHelpMan aware of JSONRPCRequest and add Check() helper * rpc: migrate JSONRPCRequest functionality into request.cpp * Merge #14626: Select orphan transaction uniformly for eviction * Add username and ip logging for RPC method requests * [lib] add scheduler to node context * [test] add chainparams property to indicate chain allows time mocking * [test] unit test for new MockForward scheduler method * [util] allow scheduler to be mocked * Move jsonrpcrequest to request * [backport#16239] docs: release note wording * [backport#16239] wallet/rpc: use static help text * [backport#16239] wallet/rpc/getbalances: add entry for 'mine.used' balance in results * Increase maxconnections limit when using poll. * Implement poll() on systems which support it properly. * Move SocketEvents logic to private method. * Move GenerateSelectSet logic to private method. * Introduce and use constant SELECT_TIMEOUT_MILLISECONDS. * Merge #15597: net: Generate log entry when blocks messages are received unexpectedly * Merge #15718: docs: Improve netaddress comments * [backport#16898] test: Remove unused connect_nodes_bi * [backport#16898] scripted-diff: test: Replace connect_nodes_bi with connect_nodes * [backport#16898] test: Use connect_nodes when connecting nodes in the test_framework * Merge #13503: Document FreeBSD quirk. Fix FreeBSD build: Use std::min<int>(...) to allow for compilation under certain FreeBSD versions. * Merge #16073: refactor: Improve CRollingBloomFilter::reset by using std::fill * Merge #15343: [doc] netaddress: Make IPv4 loopback comment more descriptive * Merge #15254: Trivial: fixup a few doxygen comments * Merge #15194: Add comment describing fDisconnect behavior * Merge #15078: rpc: Document bytessent_per_msg and bytesrecv_per_msg * Merge #14436: doc: add comment explaining recentRejects-DoS behavior * Merge #14054: p2p: Disable BIP 61 by default * [backport#14060] ZMQ: add options to configure outbound message high water mark, aka SNDHWM * [backport#13756] bitcoind: update -avoidpartialspends description to account for auto-enable for avoid_reuse wallets * [backport#13756] doc: release notes for avoid_reuse * [backport#13756] wallet: enable avoid_partial_spends by default if avoid_reuse is set * [backport#13756] test: add test for avoidreuse feature * [backport#13756] Wallet/rpc: add 'avoid_reuse' option to RPC commands * [backport#13756] wallet/rpc: add setwalletflag RPC and MUTABLE_WALLET_FLAGS * [backport#13756] wallet: enable avoid_reuse feature * Merge #13096: [Policy] Fix MAX_STANDARD_TX_WEIGHT check * [backport#15930] rpc: Deprecate getunconfirmedbalance and getwalletinfo balances * [backport#15930] rpc: Add getbalances RPC * [backport#15930] rpcwallet: Make helper methods const on CWallet * [backport#15930] wallet: Use IsValidNumArgs in getwalletinfo rpc * [backport#15758] test: Add reorg test to wallet_balance * [backport#15758] test: Check that wallet txs not in the mempool are untrusted * [backport#15758] test: Add getunconfirmedbalance test with conflicts * [backport#15758] test: Add wallet_balance test for watchonly * [bugfix] prevent nodes from banning other nodes in ABC tests * Merge #17931: test: Fix p2p_invalid_messages failing in Python 3.8 because of warning * Don't relay addr messages to block-relay-only peers * Add 2 outbound block-relay-only connections * [backport#18247] test: Remove redundant sync_with_ping after add_p2p_connection * [backport#18247] test: Wait for both veracks in add_p2p_connection * Merge #15697: qa: Make swap_magic_bytes in p2p_invalid_messages atomic * Merge #15330: test: Fix race in p2p_invalid_messages * [land-bot] Point land bot at bitcoinabc.org * Skip stale tip checking if outbound connections are off or if reindexing. * Fire TransactionRemovedFromMempool from mempool * scripted-diff: Replace ::mempool with m_node.mempool in tests * Explicitely pass the mempool down in some test * Have importwallet use ImportPrivKeys and ImportScripts * Optionally allow ImportScripts to set script creation timestamp * Disconnect peers violating blocks-only mode * doc: improve comments relating to block-relay-only peers * test: Replace recursive lock with locking annotations * node: Add reference to mempool in NodeContext * Check that tx_relay is initialized before access * Add comment explaining intended use of m_tx_relay * Add tests and documentation for blocksonly * Have importaddress use ImportScripts and ImportScriptPubKeys * Have importpubkey use CWallet's ImportScriptPubKeys and ImportPubKeys functions * Have importprivkey use CWallet's ImportPrivKeys, ImportScripts, and ImportScriptPubKeys * [backport#16551] test: Test that low difficulty chain fork is rejected * [backport#16551] test: Pass down correct chain name in tests * Change ImportScriptPubKeys' internal to apply_label * [backport#16839] Avoid using g_rpc_node global in wallet code * [backport#16244] Move wallet creation out of the createwallet rpc into its own function * [backport#15006] Add option to create an encrypted wallet * [backport#15713] Tidy up BroadcastTransaction() * Log when an import is being skipped because we already have it * [backport#15713 4/5] Remove unused submitToMemoryPool and relayTransactions Chain interfaces * [backport#15713 3/5] Remove duplicate checks in SubmitMemoryPoolAndRelay * [backport#15713 2/5] Introduce CWalletTx::SubmitMemoryPoolAndRelay * [backport#16839] scripted-diff: Remove g_connman, g_banman globals * net: Remove unused unsanitized user agent string CNode::strSubVer * [refactor] Change tx_relay structure to be unique_ptr * [refactor] Move tx relay state to separate structure * [backport#16839] Pass NodeContext, ConnMan, BanMan references more places * Change ismine to take a CWallet instead of CKeyStore * [backport#15728] [wallet] Refactor CWalletTx::RelayWalletTransaction() * [backport#15452] GetKeyBirthTimes should return key ids, not destinations * Move ismine to wallet module * [backport#14678] [wallet] remove redundant KeyOriginInfo access, already done in CreateSig * [backport#15452] Replace CScriptID and CKeyID in CTxDestination with dedicated types * [backport#14821] Replace CAffectedKeysVisitor with descriptor based logic * Remove unused variable * Use BlockHash for vInventoryBlockToSend * [backport#15750] [rpc] Remove the addresses field from the getaddressinfo return object * Merge #15246: qa: Add tests for invalid message headers * Simplify install instructions for linter dependencies * Add remaining linter dependencies to CI base image * [land-bot] Clarify review status error message * Batch write imported stuff in importmulti * [devtools] Use -daemon instead of backgrounding bitcoind * [backport#16898] test: Reformat python imports to aid scripted diff * Fix: importmulti only imports origin info for PKH outputs * [backport#13756] wallet: avoid reuse flags * Use a single wallet batch for UpgradeKeyMetadata * Add facility to generate RPC docs * Improve handling of INVALID in IsMine * Fix UniValue .write() changes for C++98 * [devtools] Use a trap to cleanup bitcoind instead of a background process * util: Add Join helper to join a list of strings * util: refactor upper/lowercase functions * [CI] Disable jemalloc for running the tests with wine * [CI] Let build_cmake.sh take a list of targets and use it * [backport#13756] wallet: make IsWalletFlagSet() const * [backport#13756] wallet: rename g_known_wallet_flags constant to KNOWN_WALLET_FLAGS * [refactor] add const CCoinControl& param to SendMoney * [backport#15777] [docs] Add doxygen comment for CKeyPool * Import watch only pubkeys to the keypool if private keys are disabled * blockfilter: Update BIP 158 test vectors. * rpc: Add getblockfilter RPC method. * Update multiset hash benchmark to use get_iters * init: Add CLI option to enable block filter index. * Merge #13047: [trivial] Tidy blocktools.py * Merge #12856: Tests: Add Metaclass for BitcoinTestFramework * [CI] Disable jemalloc for running the JNI bindings tests * Context isn't freed in the ECDH benchmark * Use jemalloc as a default * [CMAKE] Prevent using jemalloc with the sanitizers * Suppress a harmless variable-time optimization by clang in memczero * Remove symbols exported by jemalloc from the symbols check * Fix the build with Qt 5.15 * Remove memcpy compatibility for glibc < 2.14 * test: Create new test library * test: Add RegTestingSetup to setup_common * test: move-only ComputeFilter to src/test/lib/blockfilter * Remove fdelt_chk back-compat code and sanity check * [Automated] Update timing.json * [Automated] Update chainparams * [Automated] Update seeds * [backport#15777] [wallet] move-only: move CReserveKey to be next to CKeyPool * [backport#15780] wallet: add cachable amounts for caching credit/debit values * Rename Seeder's CAddrInfo -> CSeederAddrInfo * index: Access functions for global block filter indexes. * gui: Fix shutdown order * Add arcanist land bot workflow * [CMAKE] Fix a -Wpointer-to-int-cast when searching Jemalloc * test: Unit test for block filter index reorg handling. * test: Unit tests for block index filter. * index: Implement lookup methods on block filter index. * index: Implement block filter index with write operations. * blockfilter: Functions to translate filter types to/from names. * index: Ensure block locator is not stale after chain reorg. * index: Allow atomic commits of index state to be extended. * Use BlockHash in BlockFilter * Fix Debian package script in case signer has multiple user IDs * Merge #14426: utils: Fix broken Windows filelock * Use BlockHash and TxId in zmq * [backport#16129] Include core_io.h from core_read.cpp * [backport#16129] Make reasoning about dependencies easier by not including unused dependencies * [backport#15139] util: Make ToLower and ToUpper take a char * [backport#14599] Use functions guaranteed to be locale independent * [test] add a couple test cases to uint256_tests.cpp * Fix a comment in validation.cpp * [CMAKE] Remove the ENABLE_WERROR option * [CI] Use proper argument handling in build_cmake.sh * [CI] Enable -Werror where possible * [backport#14802] rpc: faster getblockstats using BlockUndo data * [CI] Install Clang 10 and use it for the werror build * Allow overriding default flags * [CMAKE] Rename secp256k1 test targets * Merge #13160: wallet: Unlock spent outputs * Merge #13507: RPC: Fix parameter count check for importpubkey * Merge #13535: [qa] wallet_basic: Specify minimum required amount for listunspent * Merge #13545: tests: Fix test case streams_serializedata_xor. Remove Boost dependency. * Merge #13116: Add Clang thread safety annotations for variables guarded by cs_{rpcWarmup,nTimeOffset,warnings} * Merge #16481: Trivial: add missing space * Merge #12330: Reduce scope of cs_wallet locks in listtransactions * Add land bot dependencies to base image setup script * Generate assumed blockchain and chainstate disk sizes when updating chainparams * [CMAKE] BOOST_TEST_DYN_LINK is defined twice * [CMAKE] Add a facility to add flag groups and use it for -Wformat-* * [CMAKE] Allow for checking support for several flags at the same time * [backport#15623] refactor: Expose UndoReadFromDisk in header * [backport#15932] rpc: Add lock annotations to block{,header}ToJSON * [backport#15932] rpc: Serialize in getblock without cs_main * [backport#15932] rpc: Use IsValidNumArgs in getblock * Make nChainTx private, ass facility to update it * Wrap nChainTx into GetChainTxCount * Make env data logging optional * Merge #15345: net: Correct comparison of addr count * Remove CBlockIndex::SetNull * [wallet] abort when attempting to fund a transaction above maxtxfee * Pass Consensus::Params to load block index family of functions * Fix WSL file locking by using flock instead of fcntl * Bump version to 0.21.9 * [backport#15139] util: remove unused [U](BEGIN|END) macros * [backport#15139] Replace use of BEGIN and END macros on uint256 * [backport#14518] rpc: Always throw in getblockstats if -txindex is required * [backport#15458] refactor: Drop redundant wallet reference * Prevent -Wcast-align in sha256_shani.cpp * Disable some more leveldb warnings * The -Wredundant-move warning is C++ only * Fix unused -pie flag for libs ------------------------------------------------------------------- Fri May 29 17:16:04 UTC 2020 - marec@detebe.org - Update to version 0.21.8: * [Automated] Update manpages * Fixup release notes * [backport#15365] wallet: Add lock annotation for mapAddressBook * Avoid non-trivial global constants in SHA-NI code * Fix deprecated ByteSize() for protobuf >= 3.1 * [backport#15713] Add BroadcastTransaction utility usage in Chain interface * [backport#16452] refactor : use RelayTransaction in BroadcastTransaction utility * [backport#16034] scripted-diff: Rename LockAnnotation to LockAssertion * [backport#15435] Merge #15435: rpc: Add missing #include * refactor: Fix implicit value conversion in formatPingTime * Fix deprecated copy warning for PrecomputedTransactionData * Fix shadow warning * [Automated] Update timing.json * [Automated] Update seeds * [Automated] Update chainparams * [backport#16034] Move LockAnnotation from threadsafety.h (imported code) to sync.h (our code) * [backport#15855] [refactor] interfaces: Add missing LockAnnotation for cs_main * Revert "[backport#15639] bitcoin-wallet tool: Drop libbitcoin_server.a dependency" * [wallet] Move maxTxFee to wallet * rpc: Uncouple non-wallet rpcs from maxTxFee global * [backport#15842] refactor: replace isPotentialtip/waitForNotifications by higher method * [backport#15784] rpc: Remove dependency on interfaces::Chain in SignTransaction * [backport#15670] refactor: combine Chain::findFirstBlockWithTime/findFirstBlockWithTimeAndHeight * [backport#15639] bitcoin-wallet tool: Drop libbitcoin_server.a dependency * [backport#15639] Remove access to node globals from wallet-linked code * wallet/rpc: sendrawtransaction maxfeerate * [BUILD] Search and include OpenSSL only where required * Fix CPUID subleaf iteration * fix wrong include prior to backporting 15639 * [CMAKE] Move the OpenSSL symbol detection to Qt rather than config * [refactor] make ArgsManager& parameter in IsDeprecatedRPCEnabled const * [backport#14453] rpc: Fix wallet unload during walletpassphrase timeout * [backport#15652] qa: Check unconfirmed balance after loadwallet * [backport#15652] wallet: Update transactions with current mempool after load * [backport#15652] interfaces: Add Chain::requestMempoolTransactions * [backport#15652] wallet: Move CWallet::ReacceptWalletTransactions locks to callers * [autotools-build] Disable _FORTIFY_SOURCE when enable-debug * random: Remove remaining OpenSSL calls and locking infrastructure * random: stop retrieving random bytes from OpenSSL * random: stop feeding RNG output back into OpenSSL * [build] set _FORTIFY_SOURCE=2 for -O* builds only * refactor: Add handleNotifications method to wallet * bench: Add wallet_balance benchmarks * Fix up release notes * [backport#15644] Interrupt orphan processing after every transaction * [backport#15644] [MOVEONLY] Move processing of orphan queue to ProcessOrphanTx * Test importing descriptors with key origin information and add release notes * Import KeyOriginData when importing descriptors * Implement a function to add KeyOriginInfo to a wallet * Store key origin info in key metadata * Add a method to CWallet to write just CKeyMetadata * [backport#15644] Simplify orphan processing in preparation for interruptibility * [backport#15639] bitcoin-wallet tool: Drop MakeChain calls * Remove hdmasterkeyid * Add WriteHDKeypath function and move *HDKeypath to util/bip32.{h,cpp} * Refactor keymetadata writing to a separate method * Merge #15746: rpc: RPCHelpMan: Always name dictionary keys * Merge #14417: Fix listreceivedbyaddress not taking address as a string * Merge #14129: Trivial: update clang thread-safety docs url * wallet: Get all balances in one call * doc: Add release notes for 15596 * wallet: Remove unused GetLegacyBalance * scripted-diff: wallet: Rename pcoin to wtx * rpc: Document that minconf is an ignored dummy value * [refactor] change orphan txs std::map member to use TxId instead of uint256 * rpc: Actually throw help when passed invalid number of params * RPCHelpMan: Check default values are given at compile-time * rpc: Document default values for optional arguments * random: mark RandAddPeriodic and SeedPeriodic as noexcept * Report amount of data gathered from environment * Use thread-safe atomic in perfmon seeder * Run background seeding periodically instead of unpredictably * Add information gathered through getauxval() * Feed CPUID data into RNG * [rpc] util: add deriveaddresses method * Fix code alignement in rpc/misc.cpp * [backport#15617] Do not relay banned IP addresses * netaddress: Update CNetAddr for ORCHIDv2 * Use sysctl for seeding on MacOS/BSD * [CI] Disable unsupported qemu feature by bypassing the configuration * Merge #17469: test: Remove fragile assert_memory_usage_stable * Descriptor expansions only need pubkey entries for PKH/WPKH * Merge #14522: tests: add invalid P2P message tests * [land-bot] Improve error reporting when fetching revision status fails * Add comments to descriptor tests * Add descriptor expansion cache * [refactor] Combine the ToString and ToPrivateString implementations * [refactor] Use DescriptorImpl internally, permitting access to new methods * decremented EXPECTED_VIOLATION_COUNT * [refactor] Add a base DescriptorImpl with most common logic * Add release notes for importmulti descriptor support * Add test for importing via descriptor * [wallet] Allow descriptor imports with importmulti * Gather additional entropy from the environment * [MOVEONLY] Move cpuid code from random & sha256 to compat/cpuid * Seed randomness with process id / thread id / various clocks * [tests] move wallet util functions to wallet_util.py * [tests] tidy up wallet_importmulti.py * [wallet] Refactor ProcessImport() to call ProcessImportLegacy() * [wallet] Add ProcessImportLegacy() * [MOVEONLY] Move perfmon data gathering to new randomenv module * [Automated] Update timing.json * [Automated] Update chainparams * [Automated] Update seeds * rpc: creates possibility to preserve labels on importprivkey * [backport#16349] Remove redundant WalletController::addWallet slot * [backport#16348] qt: Assert QMetaObject::invokeMethod result * [backport#16348] gui: Fix missing qRegisterMetaType(WalletModel*) * [backport#15091] Qt: Fix update headers-count * [backport#15091] Qt: update header count regardless of update delay * [backport#15462] gui: Fix async open wallet call order * [backport#16106] refactor: Rename getWallets to getOpenWallets in WalletController * [backport#16106] gui: Sort wallets in open wallet menu * [backport#16231] gui: Fix open wallet menu initialization order * [backport#16118] gui: Enable open wallet menu on setWalletController * Replace message type literals with protocol.h constants * [backport#15195] gui: Add close wallet action * [backport#15195] gui: Add closeWallet to WalletController * [backport#16995] refactor: Work around GCC 9 `-Wredundant-move` warning * Recategorize seeder connections as not manual * Removed activation logic for OP_REVERSEBYTES to pretend it was always enabled * [backport#16728] move-only: move coins statistics utils out of RPC * [backport#16995] net: Fail instead of truncate command name in CMessageHeader * [backport#15195] interfaces: Add remove to Wallet * [backport#15957] Show loaded wallets as disabled in open menu instead of nothing * [backport#15308] Piecewise construct to avoid invalid construction * [backport#14820] test: Fix descriptor_tests not checking ToString output of public descriptors * doc: minor corrections in random.cpp * random: remove call to RAND_screen() (Windows only) * gui: remove OpenSSL PRNG seeding (Windows, Qt only) * doc: correct function name in ReportHardwareRand() * net: Use mockable time for tx download * scripted-diff: use self.sync_* methods * test: Add BitcoinTestFramework::sync_* methods * test: Pass at most one node group to sync_all * scripted-diff: Rename sync_blocks to send_blocks * qa: Run more tests with wallet disabled * Reconsider checkpointed block at startup. * [wallet] Refactor ProcessImport() * [backport#15153] gui: Show indeterminate progress dialog while opening wallet * Overhaul importmulti logic * Release notes for PR14477 * [backport#15153] gui: Add OpenWalletActivity * [backport#15153] Interfaces: Avoid interface instance if wallet is null * [backport#15153] gui: Add thread to run background activity in WalletController * [backport#15153] gui: Add Open Wallet menu * Add RNG strengthening (10ms once every minute) * Add release notes * Add matching descriptors to scantxoutset output + tests * Add descriptors to listunspent and getaddressinfo + tests * [backport#16033] Hold cs_main when reading chainActive via getTipLocator(). Remove assumeLocked() * Switch memory_cleanse implementation to BoringSSL's * [testonly] [wallet] use P2WPKH change output if any destination is P2WPKH or P2WSH * Add address_types test * Add tests for InferDescriptor and Descriptor::IsSolvable * Add support for inferring descriptors from scripts * Add Descriptor::IsSolvable() to distinguish addr/raw from others * Fix dbcrash spurious failures * Fix Flake8 E741 errors * Lint everything * [backport#15153] gui: Add openWallet and getWalletsAvailableToOpen to WalletController * Cleanup useless dependency in setup-debian-buster.sh * Check for IBD completion based on existing log message instead of 100% progress * Remove legacy per transaction sigops accounting * Remove legacy per block sigops accounting * [fix] unbreak D6110 * [backport#15153] interfaces: Add loadWallet to Node * Remove legacy sigops support from miner * Kill GetSigOpCount * Do not count sigops at all anymore * MOVEONLY: Move NodeContext struct to node/context.h * scripted-diff: Rename InitInterfaces to NodeContext * [build] enforce exhaustive switch statements in BUILD_WERROR config * [Automated] Update timing.json * [backport#15153] wallet: Factor out LoadWallet * [backport#15638] [build] Move AnalyzePSBT from psbt.cpp to node/psbt.cpp * [backport#15508] Add documentation of struct PSBTAnalysis et al * [backport#15508] Refactor analyzepsbt for use outside RPC code * [backport#15508] Move PSBT decoding functions from core_io to psbt.cpp * [backport#14906] refactor: Make explicit CMutableTransaction -> CTransaction conversion. * [backport#13769] Mark single-argument constructors "explicit" * [backport#15404] Address test todos by removing -txindex to nodes. * [backport#15247] qa: Use wallet to retrieve raw transactions * [backport#15159] [RPC] Update getrawtransaction interface * [backport#13932] Implement analyzepsbt RPC and tests * Set LEEWAY to 0 in check_script_prefixes * Rename test to follow the naming convention * Bump version to 0.21.8 * Allow abc_ as a prefix for test naming convention * Fix typo related to ZMQ in build docs * Add OP_REVERSEBYTES test case * Report updated sigops count in mining RPC ------------------------------------------------------------------- Sat May 16 18:09:27 UTC 2020 - marec@detebe.org - Update to version 0.21.7: * Add checkpoints for phonon activation * Add release notes * [Automated] Update manpages * [tests] add test_address method to wallet_import.py * [tests] add test_importmulti method to wallet_import.py * [tests] add get_multisig function to wallet_importmulti.py * [tests] add get_key function to wallet_importmulti.py * Partial Merge #14454: ProcessImport() cleanup (excluding witness) * Update chainparams to a post-upgrade block * Fix incorrect mocktime set in miner fund test * Remove 0.20.x nodes from makeseeds * [tests] tidy up imports in wallet_importmulti.py * Remove white space between list in v0.21.5 release notes * Merge #9332: Let wallet importmulti RPC accept labels for standard scriptPubKeys * Bump PORT_MIN in test framework to not collide with testnet * Merge #16918: test: Make PORT_MIN in test runner configurable * Remove Core release note file, update previous release notes, and fix generate() deprecation message * Merge #18641: test: Create cached blocks not in the future * [Automated] Update timing.json * [Automated] Update seeds * Reduce memory allocations in getblocktemplate * Fix string layout in rpc/rawtransaction.cpp * [CMAKE] Improve the FindJemalloc module * Bump misbehaving factor for unexpected version message behavior * Update univalue to 1.1.1 * [tests] Give a useful error message when assert_debug_log is called with empty expected messages * [doc] since D5764, regtest requires standard txns by default * [DEPENDS] Remove the facilities for building win32 * [backport#13932] Figure out what is missing during signing * [DEPENDS] Add jemalloc to the depends * [backport#13932] Move PSBT UTXO fetching to a separate method * [backport#13932] Implement joinpsbts RPC and tests * [backport#13932] Implement utxoupdatepsbt RPC and tests * refactor: Cleanup walletinitinterface.h * scripted-diff: Make translation bilingual * Add bilingual message type * Refactor out translation.h * Remove leftover from debuging * [land-bot] Ensure changes to the land bot script do not modify its execution in-flight * [land-bot] Only operate on trusted patches * Merge #14150: Add key origin support to descriptors * Use HTTPS for LLVM repository * Add missing cs_main lock * [net] Ignore unlikely timestamps in version messages * Fix potential timedata overflow * refactoring: IsInitialBlockDownload -> CChainState * [tests] Remove ctime() call which may be unreliable on some systems * [CMAKE] Use jemalloc as an allocator * Bump version to 0.21.7 * [backport#15632] [wallet] Remove unnecessary Chain::Lock parameter from ResendWalletTransactions * [backport#15632] [wallet] Schedule tx rebroadcasts in wallet * Restrict setmocktime to non-negative integers * [backport#14690] Throw error if CPubKey is invalid during PSBT keypath serialization * [backport#14689] Require a public key to be retrieved when signing a P2PKH input * [backport#14424] Stop requiring imported pubkey to sign non-PKH schemes * [backport#15408] Remove unused TransactionError constants * [backport#14356] fix converttopsbt permitsigdata arg, add basic test * [backport#15638] [docs] Document src subdirectories and different libraries * [backport#15638] [build] Move wallet load functions to wallet/load unit * Properly handle LONG_MIN in timedata.cpp * Remove last vestige of the alert system * Merge #12764: doc: Remove field in getblocktemplate help that has never been used. ------------------------------------------------------------------- Sat May 09 12:22:58 UTC 2020 - marec@detebe.org - Update to version 0.21.6: * [Automated] Update manpages * Merge #14984: rpc: Speedup getrawmempool when verbose=true * Merge #15463: rpc: Speedup getaddressesbylabel * refactoring: FlushStateToDisk -> CChainState * Added some release notes * refactoring: introduce ChainstateActive() * [backport#15638] [build] Add several util units * move-only: make the CChainState interface public * UniValue performance speedups for .write() * Move DisconnectResult in its own header and make it an enum class * test: Bump MAX_NODES to 12 * Remove dead code in core_memusage.h * More include fixes * Add missing includes * [backport#15638][build] Move several units into common libraries * correct forward declaration in rawtransaction_util.h * prevector: avoid misaligned member accesses * [Automated] Update timing.json * [Automated] Update chainparams * [Automated] Update seeds * qa: Always refresh cache to be out of ibd * [backport#15638] [build] Move rpc rawtransaction util functions to rpc/rawtransaction_util.cpp * [backport#15638] [build] Move rpc utility methods to rpc/util * Merge #16267: bench: Benchmark blockToJSON * Merge #16299: bench: Move generated data to a dedicated translation unit * [backport#15680] [wallet] Remove ResendWalletTransactionsBefore * [tests] Move deterministic address import to setup_nodes * [rpc] add 'getnewaddress' hint to 'generatetoaddress' help text. * [wallet] Deprecate the generate RPC method * [tests] Add generate method to TestNode * [tests] Small fixups before deprecating generate * Delete globals.h and globals.cpp * [trivial] turn test runner cli output into Bitcoin Cash * [backport#15638] [build] Move policy settings to new src/policy/settings unit * tests: write the notification to different files to avoid race condition * Pure python EC * tests: Make it possible to run functional tests on Windows * Make sure we read the command line inputs using utf-8 decoding in python * [lint-circular-dependencies] changed expected dep list to establish baseline * [backport#13695] lint: Add linter for circular dependencies * [backport#15638] [build] Move CheckTransaction from lib_server to lib_consensus * qa: Make extended tests pass on native Windows * qa: Fix some tests to work on native windows * qa: Add emojis to test_runner path and wallet filename * [backport#15680] [rpc] remove resendwallettransactions RPC * wallet: Fixup rescanblockchain result doc * [trivial] comment correction on wallet_balance.py * Suggested wallet code cleanups from #14711 * [backport#15632] [wallet] Keep track of the best block time in the wallet * [backport#14845] [tests] Add wallet_balance.py * [backport#15646] [tests] Add test for wallet rebroadcasts * Finish PR14987 and clean up some functions * Pass some of wallet/rpcwallet RPC results and examples to RPCHelpMan * [land-bot] Fix a bug where the unencrypted CONDUIT_TOKEN could be logged by subshells * Clear mock time between tests * [rpc] mining: Omit uninitialized currentblockweight, currentblocktx * Update confusing names in rpc_blockchain.py * [backport#15288] moved remaining g_mempool references out of wallet.cpp * test: Adapt test framework for chains other than "regtest" * [backport#10973] Remove remaining wallet accesses to node globals * [Fix] The default whitelistrelay should be true * test: Remove incorrect and unused try-block in assert_debug_log * on startup, write config options to debug.log * QA: fix rpc_setban.py race * [Fix] Allow connection of a noban banned peer * Add functional tests for flexible whitebind/list * Replace the use of fWhitelisted by permission checks * Do not disconnect peer for asking mempool if it has NO_BAN permission * Make whitebind/whitelist permissions more flexible * Correction of unaddressed nit in previous revision * [backport#10973] Remove use of CCoinsViewMemPool::GetCoin in wallet code * Finish passing rpcwallet RPCs Results and Examples to RPCHelpMan * Pass some more (3/4) rpcwallet RPCs Results and Examples to RPCHelpMan * Remove config managed RPC user/pass * Pass more (2/4) rpcwallet RPCs Results and Examples to RPCHelpMan * [backport#10973] Remove use of CRPCTable::appendCommand in wallet code * Pass pruneblockchain RPC Results and Examples to RPCHelpMan * Pass rpc/avalanche Results and Examples to RPCHelpMan * Pass rpc/misc RPC Results and Exmaples to RPCHelpMan * Revert ContextFreeRPCCommand nonsense * Fix error messages in noui.cpp * [CI] Add a sepc256k1 specific build plan * refactor: Settings code cleanups * [CI] Run the tests for ARM * [CI] Run the tests for AArch64 * test: Add ASSERT_DEBUG_LOG to unit test framework * refactor: Remove redundant c_str() calls in formatting * Add settings_tests * Deduplicate settings merge code * Remove includeconf nested scope * Preparations for more testchains * [CMAKE] Fix missing linker wrap for fcntl64 * build: remove linking librt for backwards compatibility * [CI] Build the OSX DMG * [CI] Build the windows installer * Run tool_wallet.py with an emulator as needed * [Automated] Update timing.json * [Automated] Update chainparams * [Automated] Update seeds * Finish Passing rpc/blockchain RPC results and examples to RPCHelpMan * Link univalue in the seeder * gui: Drop boost::scoped_array and use wchar_t API explicitly on Windows * gui: Fix for Incorrect application name when passing -regtest * Reorder univalue include * Pass some rpc/blockchain RPC results and examples to RPCHelpMan * Finish Passing rpc/rawtransaction RPC results and examples to RPCHelpMan * Add util::Settings struct and helper functions. * Rename includeconf variables for clarity * Clarify emptyIncludeConf logic * [backport#14532] net: Always default rpcbind to localhost, never "all interfaces" * Fix the emulator with autotools * [CMAKE] Increase the unit test verbosity to test_suite * Make bitcoin-util use the emulator as needed * Allow for using an emulator for the functional test framework * [CMAKE] Use the crosscompiling emulator to run the tests * [CMAKE] Propagate the LFS support flags to the libraries * Pass wallet/rpcdump RPC results and examples to RPCHelpMan * Add a land bot script for running smoke tests before landing patches * [backport#10973] Remove use CValidationInterface in wallet code * [backport#15531] Merge #15531: Suggested interfaces::Chain cleanups from #15288 * [backport#15288] Remove use of IsInitialBlockDownload in wallet code * [backport#15288] Remove use of uiInterface.LoadWallet in wallet code * [backport#15288] circular-dependencies: Avoid treating some .h/.cpp files as a unit * [backport#15288] Remove use of AcceptToMemoryPool in wallet code * Bump tool_wallet timeout * [CMAKE] Fix the build with ZMQ disabled * Add test for ArgsManager::GetChainName * Fix -Wdeprecated-copy warning with GCC >= 9 * [backport#15288] Remove uses of InitMessage/Warning/Error in wallet code * Reorder various univalue include orders * Make sure we're using the same version of clang tools for everything * Merge #15947: Install bitcoin-wallet manpage * Merge #15354: doc: Add missing bitcoin-wallet tool manpages * [CI] Cross build and run tests for Linux 64 bits * Pass rpc/rawtransaction RPC results and examples to RPCHelpMan * [CI] Cross build for Linux ARM and AArch64 * [CI] Cross build for OSX * Pass rpc/mining RPC results and examples to RPCHelpMan * Pass rpc/net RPC Results and Examples to RPCHelpMan * [backport#15288] Remove uses of GetAdjustedTime in wallet code * [backport#15288] Remove use of g_connman / PushInventory in wallet code * Remove unnecessary --force-yes from installation script * [backport#15288] Remove uses of g_connman in wallet code * Backport leftovers from 15788 * bench: Add block assemble benchmark * util: make ScheduleBatchPriority advisory only * Add test for AddTimeData * Add settings merge test to prevent regresssions * Use BlockHash for CheckProofOfWork * Reduce the use of ClearArg and only guarantee that we clear forced args. * [backport#15288] Remove uses of fPruneMode in wallet code * [backport#15288] Remove use of CalculateMemPoolAncestors in wallet code * Use std::thread::hardware_concurrency, instead of Boost, to determine available cores * refactor: consolidate PASTE macros * Fix declaration order in util/system.h * [backport#15288] Remove use of GetTransactionAncestry in wallet code * scripted-diff: Replace CCriticalSection with RecursiveMutex * [CI] Build for windows 64 and run some unit tests * Merge #15069: test: Fix rpc_net.py "pong" race condition * Merge #15013: test: Avoid race in p2p_timeouts * Rename IsGood() to IsReliable() * Merge #14733: P2P: Make peer timeout configurable, speed up very slow test and ensure correct code path tested. * Add a deprecation notice for the autotools build system * Bump version to 0.21.6 * Merge #14456: test: forward timeouts properly in send_blocks_and_test * [backport#15288] Remove use of GetCountWithDescendants in wallet code * [backport#15288] Remove use of IsRBFOptIn in wallet code * Pass zmq RPC results and examples to RPCHelpMan * [backport#15288] Remove uses of CheckFinalTx in wallet code ------------------------------------------------------------------- Fri Apr 24 14:41:57 UTC 2020 - marec@detebe.org - Update to version 0.21.5: * [Automated] Update manpages * Add RPC Whitelist Feature from #12248 * Pass rpc/server RPC results and examples to RPCHelpMan * Finish up release notes * Pass rpc/abc RPC Results and Examples to RPCHelpMan * Add default THREADS to build_autotools.sh * Make sure build_* devtools scripts' default build directories always exist * Build the deb package with cmake * [backport#15864] Fix datadir handling * Update the PPA to support Ubuntu 20.04, drop 16.04 * [BENCH] Add an option to output the result as a Junit report * Remove CheckFinalTx * [CMAKE] Add a translate target * [Automated] Update timing.json * [Automated] Update chainparams * [Automated] Update seeds * Only log "Using PATH_TO_bitcoin.conf" message on startup if conf file exists. * [backport#16366] init: Use InitError for all errors in bitcoind/qt * Remove TestNode() * [build-configurations] Add build-without-cli * Merge #17497: test: skip tests when utils haven't been compiled * refactor: test/bench: dedup Build{Crediting,Spending}Transaction() * [backport#14783] qt: Call noui_connect to prevent boost::signals2::no_slots_error in early calls to InitWarning * Merge #14298: [REST] improve performance for JSON calls * [backport#12916] Introduce BigEndian wrapper and use it for netaddress ports * Docs: Modify policy to not translate command-line help * Merge #14097: validation: Log FormatStateMessage on ConnectBlock error in ConnectTip * gui: Stop translating PACKAGE_NAME * [autopatch] Do not create a new git branch when fetching upstream * core -> ABC in extract_strings_qt.py * Fix @generated marking in Phab for generate-seeds.py * Stop translating command line options (continuated) * gui: Fix window title update * Merge #17068: qt: Always generate `bitcoinstrings.cpp` on `make translate` * Fix a bug where running test_runner.py --usecli would fail when built without bitcoin-cli * Merge #14381: test: Add missing call to skip_if_no_cli() * Refactor: Replace fprintf with tfm::format * Merge #14885: rpc: Assert named arguments are unique in RPCHelpMan * Merge #17192: util: Add CHECK_NONFATAL and use it in src/rpc * [backport#15891] test: Require standard txs in regtest by default * Merge #13105: [qa] Add --failfast option to functional test runner * init: Remove deprecated args from hidden args * test: Make tests arg type specific * Revamp option negating policy * Replace IsArgKnown() with FlagsOfKnownArg() * Use ArgsManager::NETWORK_ONLY flag * Remove unused m_debug_only member from Arg struct * scripted-diff: Use ArgsManager::DEBUG_ONLY flag * scripted-diff: Use Flags enum in AddArg() * util: Explain why the path is cached * Enable PID file creation on WIN * Improve PID file error handling * Speed up OP_REVERSEBYTES test significantly * Catch exception by ref in wallettool.cpp * [cmake] Fix dependencies for functional test targets * [CMAKE] Use a cmake template for config.ini * [backport#15629] init: Throw error when network specific config is ignored * Add Flags enum to ArgsManager * Refactor InterpretNegatedOption() function * refactoring: Check IsArgKnown() early * implements different disk sizes for different networks on intro * [tools] Add wallet inspection and modification tool * [tests] Functional test naming convention * Update univalue to 1.0.5 * [backport#15335] Fix lack of warning of unrecognized section names * [backport#15087] Error if rpcpassword contains hash in conf sections * [backport#14708] Warn unrecognised sections in the config file * Backport Core PR12246 * [DOC] Update the sanitizer documentation * [DOC] Update developer notes * [CMAKE] Add support for generating test coverage reports * [backport#14618] rpc: Make HTTP RPC debug logging more informative * [backport#14628] Rename misleading 'defaultPort' to 'http_port' * Merge #15943: tests: Fail if RPC has been added without tests * Factor out combine / finalize / extract PSBT helpers * Switch away from exceptions in refactored tx code * Remove op== on PSBTs; check compatibility in Merge * Split DecodePSBT into Base64 and Raw versions * Add pf_invalid arg to std::string DecodeBase{32,64} * Simplify Base32 and Base64 conversions * Allow ConvertBits() to succeed on unpadded zeros * qt: Set AA_EnableHighDpiScaling attribute early * [Automated] Update timing.json * [Automated] Update chainparams * [Automated] Update seeds * Complete PR14796 by cleaning up some old functions and names * Finish passing the remainder of wallet/rpcwallet RPC argument descriptions to RPCHelpMan * Start passing some wallet/rpcwallet RPC argument descriptions to RPCHelpMan * Pass rpc/mining RPC argument descriptions to RPCHelpMan * Pass wallet/rpcdump RPC argument descriptions to RPCHelpMan * Pass rpc/rawtransaction RPC argument descriptions to RPCHelpMan * Pass rpc/misc RPC argument descriptions to RPCHelpMan * [avalanche] Process AvalancheResponse * Move PSBT definitions and code to separate files * Refactor PSBT signing logic to enforce invariant * Factor BroadcastTransaction out of sendrawtransaction * Merge #17121: test: speedup wallet_backup by whitelisting peers (immediate tx relay) * [release-process] Update Ubuntu PPA instruction * Pass rpc/blockchain RPC argument descriptions to RPCHelpMan * Pass rpc/net RPC argument descriptions to RPCHelpMan * Pass rpc/server RPC argument descriptions to RPCHelpMan * Extract the event loop management from the avalanche code so it can be reused. * Pass rpc/avalanche RPC argument descriptions to RPCHelpMan * Make use of ADDR_SOFT_CAP outside just the seeder test suite * Extract smoke tests from automated commits * Merge #13891: [RPC] Remove getinfo deprecation warning * Add upgraded nodes as seeds * [avalanche] Modernize the code via using instead of typedef * Remove win32 from Github release * [backport] Scripts and tools: Fix BIND_NOW check in security-check.py * [avalanche] Buffer avapoll and avaresponse * [backport] Trivial: fix references to share/rpcuser (now share/rpcauth) * Pass abc RPC argument descriptions to RPCHelpMan * Use full sanitizer options on CI * Fix race condition in avalanche test * nits: use const for loop iterrators in avalanche code * Remove 'boost::optional'-related gcc warnings * Allow to extend and override the sanitizers options * [CMAKE] Set environment variables when running tests with sanitizers * Bump copyright year to 2020 * Bump version to 0.21.5 * [backport] test: Fix AreInputsStandard test to reference the proper scriptPubKey * Merge #15201: net: Add missing locking annotation for vNodes. vNodes is guarded by cs_vNodes. ------------------------------------------------------------------- Sat Apr 11 17:12:53 UTC 2020 - marec@detebe.org - Update to version 0.21.4: * [Automated] Update manpages * Fix the avalanche tests * [Avalanche] Gather INVs before entering critical section for cs_vNodes * Remove uses of chainActive and mapBlockIndex in wallet code * tests: Fix fs_tests for unknown locales * Use a different address in Avalanche test to prevent duplicate blocks * [backport] RPCAuth Detection in Logs * [Automated] Update timing.json * [Automated] Update chainparams * [Automated] Update seeds * Clean cache and tmp directory for instegration tests * Fix Avalanche functional test when wallet is disabled * [avalanche] Require that a pubkey is associated with each avalanche peer. * Use CPubKey::PUBLIC_KEY_SIZE & al when apropriate. * depends: only use D-Bus with Qt on linux * [CMAKE] Enable DBus on Linux only * [avalanche] Poll tip candidate rather than eagerly * [avalanche] Start polling when we park of block because of reorg * bump libevent to 2.1.11 in depends * Pass CChainParams down to DisconnectTip * Pass CChainParams down to UpdateTip * depends: fix boost mac cross build with clang 9+ * Reword confusing warning message in RPC linter * depends: Consistent use of package variable * depends: don't configure xcb_proto * build: pass -dead_strip_dylibs to ld on macOS * build: don't embed a build-id when building libdmg-hfsplus * depends: add ability to skip building qrencode * Fix invalid use a memory order relaxed * Only pass --disable-dependency-tracking to packages that understand it * depends: qt: Fix C{,XX} pickup * depends: qt: Fix {C{,XX},LD}FLAGS pickup * depends: zlib: Move toolchain options to configure * depends macOS: point --sysroot to SDK * build: switch to upstream libdmg-hfsplus * depends: latest config.guess and config.sub * build: Add variable printing target to Makefiles * Add OpenSSL termios fix for musl libc * build: remove redundant sed patching * [LINTER] Remove trailing whitespaces * Add setexcessiveblock to vRPCConvertParams * Remove trailing whitespaces in old release notes * Remove trailing whitespaces in various files * Remove trailing whitespaces in cmake files * Remove trailing whitespaces in markdown files * Also track dependencies of native targets * depends: Bump QT to LTS release 5.9.8 * depends: cleanup package configure flags * build: make building protobuf optional in depends * build: remove qt libjpeg check from bitcoin_qt.m4 * depends: disable unused Qt features * Added some factors that affect the dependency list * depends: Prune X packages * packages.md: document depends build targets * build: disable libxcb extensions * .gitignore: Don't ignore depends patches * depends: expat 2.2.7 * [Automated] Update timing.json * [Automated] Update chainparams * [Automated] Update seeds * Revert "Disable thread_local for i686-mingw" * Remove Windows 32 bit build * Use ninja to generate dep files for the native build * Rebuild native executable when changes to the build system are made * build: prune dbus from depends * depends: xtrans: Configure flags cleanup. * [depends] boost: update to 1.70 * depends: Purge libtool archives * depends: add ability to skip building zeromq * Merge #15485: add rpc_misc.py, mv test getmemoryinfo, add test mallocinfo * Add version number to the seeder * depends: Make less assumptions about build env * contrib: Fix test-security-check fail in Ubuntu 18.04 * tests: Add test for 64-bit PE, modify 32-bit test results * Improve depends debuggability * Update zmq to 4.3.1 * depends: expat 2.2.6 and qt 5.9.7 * depends: native_protobuf: avoid system zlib * depends: Enable unicode support on dbd for Windows * [depends, zmq, doc] upgrade zeromq to 4.2.5 and avoid deprecated zeromq * build: Remove illegal spacing in darwin.mk * depends: Add 'make clean' and 'make clean-all' rules * [tests] Remove rpc_zmq.py * [CMAKE] Replace the test runner with a test wrapper * Clean the native directory when using the clean target * depends: zeromq 4.2.3 * [SECP256K1] Travis Don't run the constant time check with java tests * [secp256k1] Extend libsecp256k1's ctime test to check schnorr signatures * Constant-time behaviour test using valgrind memtest. * Bump version to 0.21.4 * [depends] ZeroMQ 4.2.2 * [CMAKE] Pull zmq windows library dependencies in the find module * [CMAKE] Pull miniupnpc windows library dependencies in the find module * [CMAKE] Pass the interface linked libraries to find_component ------------------------------------------------------------------- Sat Mar 28 15:48:52 UTC 2020 - marec@detebe.org - Update to version 0.21.3: * Disable thread_local for i686-mingw * [SECP256K1] Turn off ASM by default on target with no ASM support * [secp256k1] Install all packages in travis * [SECP256K1] Fix Travis missing ninja * [Automated] Update manpages * [test_runner] Fix result collector variable shadowing * [test_runner] Use the daemon property directly instead of setDaemon() * Add missing softforks help text to getblockchaininfo * Merge #14813: qa: Add wallet_encryption error tests * Fixup release notes formatting * Fix usehd release number errors in release notes * Remove rules argument from getblocktemplate help * Eliminate harmless non-constant time operations on secret data. * [depends] Don't build libevent sample code * [avalanche] sign avaresponse * wallet: Initialize stop_block to nullptr in ScanForWalletTransactions * Add stop_block out arg to ScanForWalletTransactions * Return a status enum from ScanForWalletTransactions * Make CWallet::ScanForWalletTransactions args and return value const * wallet: Avoid leaking nLockTime fingerprint when anti-fee-sniping * build: macOS toolchain update * tests: remove unused includes in tests * qt: test: Create at most one testing setup * test: Log to debug.log in all tests * test: Add test for unknown args * Ignore unknown config file options, warn instead of error * util: Log early messages * [Automated] Update timing.json * [Automated] Update chainparams * [Automated] Update seeds * [avalanche] Fix test when ran without wallet * Merge #13061: Make tests pass after 2020 * Partial Merge #14726: Use RPCHelpMan for all RPCs * Fix setexcessiveblock rpc help text * [avalanche] Add handling of ava_poll command in the network layer * [debian release] Fetch signer string from GPG rather than requiring the user to enter a perfectly formatted one * Merge #14561: Remove fs::relative call and fix listwalletdir tests * Fixup paths in wallet_multiwallet * Don't rename main thread at process level * util: Make thread names shorter * Fix portability issue with pthreads * Thread names in logs and deadlock debug tools * utils: Add fstream wrapper to allow to pass unicode filename on Windows * utils: Convert fs error messages from multibyte to utf-8 * [SECP256K1] Disable ASM for native executables * [schnorr] Add verification routine to the test framework schnorr signature facility * Add a script for setting up Debian build containers * Add another UBSAN vptr suppression * Nits in rwcollection.h * Update autotools for new seeder tests * Fix the CI gitian build script when the OSX SDK is should be downloaded * Fix the OSX gitian build * Add some unit tests for write_name() for seeder * Merge #14291: wallet: Add ListWalletDir utility function * Some left overs from PR12490 * Merge #14208: [build] Actually remove ENABLE_WALLET * build: set minimum supported macOS to 10.12 * Remove unused misc.h * [CMAKE] Fix the bench build for windows * [Automated] Update timing.json * Fix missing rename in fuzz test suite * Merge #14373: Consistency fixes for RPC descriptions * Merge #14718: Remove unreferenced boost headers * [cmake] Fix typo in error message * [CI] Do not re-download the OSX SDK if it's already available * Fix remaining test_bitcoin.cpp references (should be setup_common.cpp) * Make the fuzzer test runner compatible with cmake * Bump copyright headers in tests (part3) * Rename test_bitcoin to test/setup_common * test: Use test_bitcoin setup in bench * fuzz: Link BasicTestingSetup (shared with unit tests) * fuzz: Script validation flags * fuzz: Move deserialize tests to test/fuzz/deserialize.cpp * qa: Add test/fuzz/test_runner.py * depends: switch to secure download of all dependencies * Delete README_osx.md and move its contents into build-osx.md * [depends] expat 2.2.5, miniupnpc 2.0.20180203 * depends: Remove ccache * [depends] expat 2.2.1 * [SECP256K1] CMake: Build the ARM ASM field implementation * [CMAKE] Improve the toolchain files * [Automated] Update seeds * [Automated] Update chainparams * Release notes for D5507 * Merge #14411: [wallet] Restore ability to list incoming transactions by label * Bump copyright headers in tests (part2) * Bump copyright headers in tests (part1) * Bump copyright headers in bench * Merge #14244: amount: Move CAmount CENT to unit test header * Merge #14282: [wallet] Remove -usehd * Merge #14215: [qa] Use correct python index slices in example test * Merge #14207: doc: `-help-debug` implies `-help` * Merge #14013: [doc] Add new regtest ports in man following #10825 ports reattributions * test: Remove useless test_bitcoin_main.cpp * Bump version to 0.21.3 * Add enum for parse_name() return value * Use a sane default version for PPA releases * Add constants to dns.h ------------------------------------------------------------------- Sun Mar 15 08:50:39 UTC 2020 - marec@detebe.org - Update to version 0.21.2: * Don't use gold for the Gitian builds * Add Ubuntu PPA to release process * [Automated] Update manpages * Add << operator overload for PeerMessagingState * Update seeders list * Add some release notes * Update seeds * Added a script for building and deploying Debian packages to launchpad.net * Adds PeerMessagingState enum to seeder/bitcoin.* * Various nits in arith_uint256.h * Update dependencies in debian/control * Bump debian package compat level to 9 * Update package maintainers in debian/control * Use const in COutPoint class * [CMAKE] Use gold as a linker when available * [Automated] Update chainparams * Simplify max query name length check in parse_name() * Update package name in debian/control to bitcoinabc * [CMAKE] Improve FindZeroMQ * [CMAKE] Improve FindSHLWAPI * [CMAKE] Make the FindRapicheck module consistent with the other modules * [CMAKE] Improve FindQREncode * [CMAKE] Improve FindMiniUPnPc * [CMAKE] Improve FindGMP * Nits to streams.h * Rename DecodeDumpTime to ParseISO8601DateTime and move to time.cpp * Misuse of the Visual Studio version preprocessor macro * [CMAKE] Silent git error output when running from cmake * [CMAKE] Fix FindBerkeleyDB suffix paths * util: Add type safe GetTime * [CMAKE] Improve FindEvent * [CMAKE] Improve FindBerkeleyDB * Move PackageOptions out of cmake/modules * [cmake] check-symbols => symbol-check * [wallet] Remove CAccount and Update zapwallettxes comment * Don't enable the secp256k1 multiset module when building bitcoin abc * [wallet] Remove strFromAccount and strSentAccount * [wallet] Remove fromAccount argument from CommitTransaction() * [wallet] Delete unused account functions * [wallet] Remove CAccountingEntry class * [cmake] check-security => security-check * [wallet] Remove ListAccountCreditDebit() * [SECP256K1] Fix issue where travis does not show the logs * [SECP256K1] Add valgrind check to travis * [SECP256K1] Request --enable-experimental for the multiset module * [SECP256K1] Enable the OpenSSL tests (and benchmark) * [SECP256K1] Fix a valgrind issue in multisets * [SECP256K1] Fix the kitware PPA timeouts issues on Travis * [DOC] Update the depends README with dependencies and cmake instructions * [wallet] Don't read acentry key-values from wallet on load. * [wallet] Don't rewrite accounting entries when reordering wallet transactions and remove WriteAccountingEntry() * [wallet] Remove AddAccountingEntry() * [wallet] Remove CWallet::ListAccountCreditDebit() and GetAccountCreditDebit() * [wallet] Remove AccountMove() * [wallet] Remove 'account' argument from GetLegacyBalance() * Merge #13265: wallet: Exit SyncMetaData if there are no transactions to sync * Merge #11269: [Mempool] CTxMemPoolEntry::UpdateAncestorState: modifySiagOps param type * Merge #14023: Remove accounts rpcs * Merge #13264: [qt] Satoshi unit * [Automated] Update chainparams * [DOC] Update the subtree section from the developer notes * Move code in seeder_test.cpp close to where it is used * [backport] trivial: Mark overrides as such. #13282 * [SECP256K1] Fix Travis failures due to APT addon * [SECP256K1] Fix travis failure on ECMULT_GEN_PRECISION * [avalanche] Start event loop at node startup * Rename seeder_tests to p2p_messaging_tests * Make parse_name() fail when passed buffer size = 0 * Bump version to 0.21.2 * Fix UAHF references in dnsseed-policy.md * Spoof DISPLAY on headless build servers when generating manpages for bitcoin-qt * [CI] Run the cmake build with make as a generator * [DOC] Various updates to cmake/ninja * Enforce maximum name length for parse_name() and add unit tests * Label length unit tests for parse_name() * Add simple unit tests for parse_name() * scripted-diff: replace chainActive -> ::ChainActive() * refactoring: introduce unused ChainActive() * [CMAKE] Fix the check-bitcoin-* targets when running with Xcode * Remove secret-dependant non-constant time operation in ecmult_const. * Preventing compiler optimizations in benchmarks without a memory fence * README: add a section for test coverage * Overhaul README.md * Convert bench.h to fixed-point math * Add SECURITY.md * Clarify that a secp256k1_ecdh_hash_function must return 0 or 1 * doc: document the length requirements of output parameter. * variable signing precompute table * Docstrings * [CMAKE] Fix the build with Xcode as a generator * revert to deprecated protobuf ByteSize() due to compatibility * Stop using the deprecated google::protobuf::MessageLite::ByteSize() * [backport] qt: Remove obsolete QModelIndex::child() #16707 * [backport] qt: Replace obsolete functions of QSslSocket #16708 * [validation.cpp] update 'cousins' during UpdateFlags * rename: CChainState.chainActive -> m_chain * Fix CPack NSIS homepage * Make CPack email available for all generators * [backport] qt: Replace functions deprecated in Qt 5.13 #16701 * Fix make dist by finishing RPM cleanup * [cmake] Add comment on libsecp256k1 benchamrks * Don't park blocks when there is no actual reorg * [automated-commits] Add update-timings * Make gen-manpages.sh return non-zero if the script fails at any point * Increase robustness against UB in secp256k1_scalar_cadd_bit * Remove mention of ec_privkey_export because it doesn't exist * Remove note about heap allocation in secp256k1_ecmult_odd_multiples_table_storage_var * Make no-float policy explicit * Fix ASM setting in travis * Move lcov-filter.py to cmake/utils * [CMAKE] Fix build with make as a generator * Fix the benchmark build when wallet is disabled * JNI: fix use sig array * [cmake] Build bench by default * [CMAKE] Make the test python scripts depend on targets and not on files * Remove GotVersion() * Avoid calling secp256k1_*_is_zero when secp256k1_*_set_b32 fails. * Add a descriptive comment for secp256k1_ecmult_const. * secp256k1/src/tests.c: Properly handle sscanf return value * Fix typo ------------------------------------------------------------------- Fri Feb 28 21:51:46 UTC 2020 - marec@detebe.org - Update to version 0.21.1: * Fix missing update to bitcoin-qt manpages * Fix typo in secp256k1_preallocated.h * Make ./configure string consistent * [seeder] Various nits in the cmake build * Fix a nit in the recovery tests * typo in comment for secp256k1_ec_pubkey_tweak_mul () * scalar_impl.h: fix includes * Moved a dereference so the null check will be before the dereferencing * Fix typo in docs for _context_set_illegal_callback * [Automated] Update manpages * [backport] Qt: Replace remaining 0 with nullptr #15114 * Add unit tests for CSeederNode::ProcessMessage() * Add update-manpages to automated-commits * Update seeds * build: update RapidCheck Makefile * build: dont compile rapidcheck with -Wall * depends: latest rapidcheck, use INSTALL_ALL_EXTRAS * Integration of property based testing into Bitcoin ABC * [Automated] Update chainparams * Add update-seeds to automated-commits * [automated-commits] Make sure BUILD_DIR exists and is exported * Bump version to 0.21.1 * Make all automated commits run smoke tests prior to pushing * [CI] Run leveldb tests independently of other builds and tests * Move check-seeds from CI to general seed tools * Don't use std::quick_exit() as it is poorly supported * [secp256k1] Allow to use external default callbacks * [secp256k1] Remove a warning in multiset test * Mute self assign warning in uint256_tests.cpp * [CMAKE] Move the upgrade activated tests out of the TestSuite module * [CMAKE] Make the list of tests a property of the test suite * [CMAKE] Factorize the test suite target name construction * lcov: filter depends from coverage report * Failing functional tests stop lcov * [SECP256K1] Fix ability to compile tests without -DVERIFY. * [Automated] Update chainparams * Clear the IFP bip in the version by default to avoid accidental activation * Fix a race condition in abc-finalize-block * Merge #12035: [qt] change µBTC to bits * Merge #14307: Consolidate redundant implementations of ParseHashStr * Merge #13424: Consistently validate txid / blockhash length and encoding in rpc calls * Move github-release to appropriate contrib sub-directory * Move build_* wrapper scripts to devtools * lcov: filter /usr/lib/ from coverage reports ------------------------------------------------------------------- Tue Feb 18 14:04:42 UTC 2020 - marec@detebe.org - Update to version 0.21.0: * Update manpages for 0.21.0 release * Add missing items to release-notes + formatting fixups * Bump automatic replay protection to Nov 2020 upgrade * Change version to 0.21.0 * [sigcheck] Add per tx limit * Implement miner funding features * [sigcheck] Remove redundant sigcheck in CheckInputs * [ConnectBlock] Use an index to refers into blockundo.vtxundo rather than pusing as we go * [LINTER] Fix the doxygen linter when inline comments are multilined * fix ASAN error relating to nSigChecksBlockLimiter * [consensus rule] limit sigchecks in a block after phonon upgrade * deactivate sigops limits in phonon upgrade * Merge #12079: Improve prioritisetransaction test coverage * Enable new ancestor/descendants chains limit at fork * Merge #14460: tests: Improve 'CAmount' tests * Merge #14679: importmulti: Don't add internal addresses to address book * Add --commit to automated-commits to make local testing easier * Update seeds * [Automated] Update chainparams * Fix exit behavior in test-seeds * Merge #14720: rpc: Correctly name arguments * [CMAKE] Use the new FindPython module * Merge #14410: rpcwallet: 'ischange' field for 'getaddressinfo' RPC * Fix a race condition with rpc ports in check-seeds * [standardness] activate SCRIPT_VERIFY_INPUT_SIGCHECKS in next upgrade * [CI] Run the functional tests when wallet is disable * Add new post-fork ancestor and descendants limit. * OP_REVERSEBYTES activation logic * Revert "OP_REVERSEBYTES activation logic" * Merge #13152: [rpc] Add getnodeaddresses RPC command * OP_REVERSEBYTES activation logic * Merge #15321: doc: Add cs_main lock annotations for mapBlockIndex * Merge #14310: [wallet] Ensure wallet is unlocked before signing * Merge #14236: qa: generate --> generatetoaddress change to allow tests run without wallet * Use a temporary datadir and non-default RPC port when testing seeds * Remove updating chainparams from release process * Merge #13030: [bugfix] [wallet] Fix zapwallettxes/multiwallet interaction. * Merge #10816: Properly forbid -salvagewallet and -zapwallettxes for multi wallet. * rm cruft: contrib/rpm * Prevent arc land from failing if there is nothing to lint * Merge #10451: contrib/init/bitcoind.openrcconf: Don't disable wallet by default * RPCHelpMan fixups * Merge #14530: Use RPCHelpMan to generate RPC doc strings * rm cruft: travis-ci doc * Merge #14398: tests: Don't access out of bounds array index: array[sizeof(array)] * Merge #14822: bench: Destroy wallet txs instead of leaking their memory * Merge #17455: tests: Update valgrind suppressions * Fix nits in RPC help messages * Fix LockDirectory test failure when the Junit logger is enabled * [cmake] Add the suite name to the test runner. * Move mempool policy constants to policy/mempool.h * [Automated] Update chainparams * Add a script for building and pushing automated commits * remove SCRIPT_VERIFY_COMPRESSED_PUBKEYTYPE (aka WITNESS_PUBKEYTYPE) * [avalanche_tests] fix block index accesses * test: Build fuzz targets into seperate executables * docs: Spelling error fix on fuzzing.md * build: Allow to configure --with-sanitizers=fuzzer * tests: Use MakeUnique to construct objects owned by unique_ptrs * [tests] Add libFuzzer support. * Cache the result of chainparams.GetConsensus() in miner code * Update weird way to check for MTP in functional tests * [DOC] Update fuzzing.md to use cmake/ninja build and fix some nits * Merge #15203: Fix issue #9683 "gui, wallet: random abort (segmentation fault) * remove print-debugging statement that ended up in master * Merge #13679: Initialize m_next_send_inv_to_incoming * [python linting] tweak options * Update copyright year in COPYING file * add missing swap to CScriptCheck * Update blockchain RPC to report all BIP9 based on versionbitsinfo * Make standard flags based off consensus flags * [python linting] apply aggressive mode in autopep8 (line wrapping) * apply nontrivial changes suggested by autopep8 aggressive * [python linting] nit * Update copyright for various files * [CI] Deduplicate test_bitcoin run for the TSAN build * Make the CI record and track the unit tests * [python linting] enforce E722: do not use bare except * Merge #13823: qa: quote path in authproxy for external multiwallets * Merge #14179: qa: Fixups to "Run all tests even if wallet is not compiled" * Merge #14180: qa: Run all tests even if wallet is not compiled * Update copyright_header.py to not duplicate parts of the header * Run the linters as part of arc land * qa: Prevent concurrency issues reading .cookie file * Merge #9739: Fix BIP68 activation test * [python linting] Enforce all flake8 F codes * [LINTER] Prevent using inline doxygen comments on their own line * [python linting] enforce E731: Do not assign a lambda expression, use a def * [LINTER] Silent a shellcheck false positive * mempool_accept nits: use FromHex/ToHex * [python linting] enforce E713: Test for membership should be 'not in' * [python linting] enforce E712: Comparison to true should be 'if cond is true:' or 'if cond:' * [python linting] enforce E265: Block comment should start with '# ' * [python linting] enforce all flake8 E & W codes besides some exceptions * [lint] trailing whitespaces in python tests * add E711 to python linter (reject `== None` / `!= None`) * Merge #14964: test: Fix race in mempool_accept * Merge #14926: test: consensus: Check that final transactions are valid * Merge #14940: test: Add test for truncated pushdata script * fix whitespace lint error * Add build support for 'gprof' profiling. * [CMAKE] Get rid of ECM for running the sanitizers * fix comments //!< to //! * Consolidate check-seeds builds * Merge #14094: refactoring: Remove unreferenced local variables * Added OP_REVERSEBYTES+implementation, added (always disabled) activation flag * Bump timeouts in slow running tests * Merge #14993: rpc: Fix data race (UB) in InterruptRPC() * Merge #12153: Avoid permanent cs_main lock in getblockheader * Merge #15350: qa: Drop RPC connection if --usecli * Merge #14958: qa: Remove race between connecting and shutdown on separate connections * Merge #14982: rpc: Add getrpcinfo command * Merge #14777: tests: Add regtest for JSON-RPC batch calls * Merge #14670: http: Fix HTTP server shutdown * fix p2p_compactblocks flakiness * fix AreInputsStandard sigops counting * Merge #16538: test: Add missing sync_blocks to feature_pruning * Merge #12917: qa: Windows fixups for functional tests * Disable clang-tidy by default * Remove redundant std::move * scratch space: use single allocation * add sigchecks limiter to CheckInputs * http: add missing header bootlegged by boost < 1.72 * Remove unecessary include of iostream * Merge #13962: Remove unused dummy_tx variable from FillPSBT * Avoid redundant calls to GetChainParams and GetConsensus in CChainState::AcceptBlock * Fix the build with GCC < 8 * sigcheckcount_tests: better macro * Increase timeout in avalanche test * [CMAKE] Make ccache to work with clang-tidy * Automatically add missing braces * [CMAKE] Fix incompatibility between clang-tidy and -fstack-reuse * [CMAKE] Enable clang-tidy * rearrange ATMP in preparation for SigChecks accounting in mempool * Bump version to 0.20.13 * synchronize validation queue during submitblock * Ensure the thresold for BIP9 can be configured on a per activation basis. * Restore BIP9 RPC support in getblockchaininfo * Ressurect BIP9 style activation mechanism * Merge #14209/#17218: logging: Replace LogPrintf macro with regular function * Merge #13938: refactoring: Cleanup StartRest() * Fix ubsan failure in excessiveblock_tests * doxygen: Remove misleading checkpoints comment in CMainParams * Chainparams: Use name constants in chainparams initialization * fix a deserialization overflow edge case * Prevent wrapping in setexcessiveblock RPC * arc lint --everything * [tests] fix formatting in feature_dbcrash * ConnectBlock: fix slow usage of AddCoins * nit: functional test chmod +x * track nSigChecks in CheckInputs * Fix missing lock in txvalidationcache_tests * add sigChecks value to script cache * [CMAKE] Make Qt protobuf an object library * Add braces to unit tests files ------------------------------------------------------------------- Sat Feb 01 08:19:10 UTC 2020 - marec@detebe.org - Update to version 0.20.12: * Update manpages for 0.20.12 release * Update chainparams * Added some release notes * Update seeds * Merge #13967: [walletdb] don't report minversion wallet entry as unknown * Add braces to various files * Add braces to bench files * Add braces to wallet files * Add braces to GUI files * Add braces to crypto files * Add braces to seeder files * Add braces to bitcoin-tx and bitcoin-cli * [SECP256K1] CMake: set default build configuration and optimization * Merge #13913: qa: Remove redundant checkmempool/checkblockindex extra_args * Merge #13948: trivial: Removes unsed `CBloomFilter` constructor. * Use virtualsize for mining/mempool priority * rpc: Make unloadwallet wait for complete wallet unload * [SECP256K1] CMake: add an install target * [CMAKE] Allow for component based installation * [CMAKE] Minor improvements to the install_shared_library function * [SECP256K1] CMake: Fix in-tree build * [SECP256K1] Travis: pass extra flags to the CMake build * [SECP256K1] CMake: make the GMP bignum support optional * [SECP256K1] CMake: allow to select field and scalar implementation * Fix autotools build failure * gui: Defer removeAndDeleteWallet when no modal widget is active * wallet: Releases dangling files on BerkeleyEnvironment::Close * Remove direct node->wallet calls in init.cpp * [SECP256K1] CMake: add an option to enable endomorphism * [SECP256K1] Travis : run a 64 bits ninja for building 32 bits targets * always unpark even when -parkdeepreorg=0 * LastCommonAncestor: use skiplist when available * AreOnTheSameFork: don't actually need to find common ancestor * FinalizeBlockAndInvalidate: just use chainActive * ConnectBlock : count sigops in one place * make per-tx sigops limit contextual * rework AcceptToMemoryPoolWorker sigops counting * add test that coinbase sigops are limited * Pass chain locked variables where needed * Remove uses of cs_main in wallet code * Pass chain and client variables where needed * Add skeleton chain and client classes * Remove ENABLE_WALLET from libbitcoin_server.a * Prevent shared conf files from failing with different available options in different binaries * [Tests] Suppress output in test_bitcoin for expected errors * Add an option to set the functional test suite name * move sigops counting from CheckBlock to ContextualCheckBlock * split feature_block test into sigops and non-sigops parts * split abc-p2p-fullblocktest into sigops and non-sigops parts * add input sigchecks limit to STANDARD_SCRIPT_VERIFY_FLAGS (but not mempool flags) * add a flag that (if unset) zeroes sigchecks reported by VerifyScript * wallet: Add missing cs_wallet/cs_KeyStore locks to wallet * gui: Also log and print messages or questions like bitcoind * ui: Compile boost:signals2 only once * tests: Reduce noise level in test_bitcoin output * Merge #13982: refactor: use fs:: over boost::filesystem:: * Fix parent<->child mixup in UnwindBlock * Add last missing part from PR12954 * Increase RPC timeout for the feature_assumevalid test * build with -fstack-reuse=none * Enable context creation in preallocated memory * Make WINDOW_G configurable * [DOC] Add CMake and Ninja to the dependency list * Make last disconnected block BLOCK_FAILED_VALID, even when aborted * Use trivial algorithm in ecmult_multi if scratch space is small * Merge #9963: util: Properly handle errors during log message formatting * Add instructions for verifying download integrity against release signer keys * Bump version to 0.20.12 * [CMAKE] Attach the linker flags to target properties * [CMAKE] Bump minimum version to 3.13 * [CMAKE] Fix the native build when the target is in the current build dir * [SECP256K1] Use the cmake version from Kitware PPA on Travis * CreateNewBlock: small tweaks * CreateNewBlock: insert entries into block slightly earlier so that correct size is logged * [CMAKE] Get rid of `add_compiler_flags_to_var` * [CMAKE] Add a check_linker_flag function * [cmake] Refactor native build cmake generation * [cmake] Do not generate git_ignored_files.txt * fix a test in anticipation of SCRIPT_VERIFY_INPUT_SIGCHECKS activation * [abc-wallet-standardness] do test the signing error code * Merge #14494: Error if # is used in rpcpassword in conf * Merge #14413: tests: Allow closed rpc handler in assert_start_raises_init_error * Merge #14105: util: Report parse errors in configuration file * Merge #14146: wallet: Remove trailing separators from -walletdir arg * [CMAKE] Fix static linkage when building for Windows * Fix type mismatch for GetVirtualSizeWith<Descendants|Ancerstors> * simplify ATMP standard flag computation [2/2] - move computation to another function * simplify ATMP standard flag computation [1/2] - remove CHECKDATASIG_SIGOPS * [cmake] Only set the native build marker once * Add virtualsize computation to mempool * track descendant sigops count in mempool * tweak auto-unparking message * [validation.cpp] parking-related comment tweaks * [CMAKE] Run wallet tests as part of the check-bitcoin target * Merge #13862: utils: drop boost::interprocess::file_lock * [CMAKE] Fix getentropy detection on OSX * [CMAKE] Fix daemon() detection on OSX * Merge #14108: tests: Add missing locking annotations and locks (g_cs_orphans) * Temporary fix for recent build flakiness * Merge #13126: util: Add Clang thread safety annotations for variables guarded by cs_args ------------------------------------------------------------------- Sat Jan 18 18:24:00 UTC 2020 - marec@detebe.org - Update to version 0.20.11: * Update manpages for 0.20.11 release * Merge #12804: [tests] Fix intermittent rpc_net.py failure. * Update seeds * Update chainparams * [cmake] Always run native build standalone * Note intention of timing sidechannel freeness. * configure: Use CFLAGS_FOR_BUILD when checking native compiler * Respect LDFLAGS and #undef STATIC_PRECOMPUTATION if using basic config * Make sure we're not using an uninitialized variable in secp256k1_wnaf_const(...) * Pass scalar by reference in secp256k1_wnaf_const() * Avoid implementation-defined and undefined behavior when dealing with sizes * Guard memcmp in tests against mixed size inputs. * Use __GNUC_PREREQ for detecting __builtin_expect * Add $(COMMON_LIB) to exhaustive tests to fix ARM asm build * Switch x86_64 asm to use "i" instead of "n" for immediate values. * Allow field_10x26_arm.s to compile for ARMv7 architecture * Clear a copied secret key after negation * Use size_t shifts when computing a size_t * Fix integer overflow in ecmult_multi_var when n is large * Add trivial ecmult_multi algorithm which does not require a scratch space * Make bench_internal obey secp256k1_fe_sqrt's contract wrt aliasing. * travis: Remove unused sudo:false * Summarize build options in configure script * Portability fix for the configure scripts generated * Correct order of libs returned on pkg-config --libs --static libsecp256k1 call. * Eliminate scratch memory used when generating contexts * Optimize secp256k1_fe_normalize_weak calls. * Assorted minor corrections * Make constants static: static const secp256k1_ge secp256k1_ge_const_g; static const int CURVE_B; * secp256k1_fe_sqrt: Verify that the arguments don't alias. * Make randomization of a non-signing context a noop * add static context object which has no capabilities * Fix algorithm selection in bench_ecmult * Make use of TAG_PUBKEY constants in secp256k1_eckey_pubkey_parse * improvements to random seed in src/tests.c * Merge #15507: test: Bump timeout on tests * Merge #13861: test: Add testing of value_ret for SelectCoinsBnB * [secp256k1] [ECDH API change] Support custom hash function * Merge #14056: Docs: Fix help message typo optiona -> optional * [CMAKE] Use the same debug flags for C and C++ * [CMAKE] Remove useless remove_compile_flag in leveldb * Revert "Prevent callback overruns in InvalidateBlock and RewindBlockIndex" * [CMAKE] Add compiler flags to some build configuration only * [secp256k1] fix tests.c in the count == 0 case * Merge #13429: Return the script type from Solver * [CI] Increase the coverage for the build-diff and build-master configs * Optimization: don't add txn back to mempool after 10 invalidates * [CI] Use ninja targets instead of calling binaries * Move the functional test temporary directory under the build directory * Move the JUnit file to the temporary directory * Prevent callback overruns in InvalidateBlock and RewindBlockIndex * [CMAKE] Add compiler flags to properties rather than CFLAGS/CXXFLAGS * [CMAKE] Remove extra -fPIE flag * [secp256k1] scratch: add stack frame support * Revert "Call FinalizeBlockAndInvalidate without cs_main held" * Call FinalizeBlockAndInvalidate without cs_main held * Add a script to generate sha256sums from Gitian output * Release cs_main during InvalidateBlock iterations * Call InvalidateBlock without cs_main held * Call RewindBlockIndex without cs_main held * [wallet] Support creating a blank wallet * add a flag that restricts sigChecks per-input * save ScriptExecutionMetrics during CScriptCheck * parameterize ecmult_const over input size * Merge #12559: Avoid locking cs_main in some wallet RPC * Add some braces to policy/policy.cpp * [CI] Add a configuration to build and run the benchmarks * [CI] Split build-default into build-diff and build-master * [CMAKE] Add a check-upgrade-activated-extended target * Merge #13988: Add checks for settxfee reasonableness * Merge #13142: Separate IsMine from solvability * move ScriptExecutionMetrics to its own file * move MANDATORY_SCRIPT_VERIFY_FLAGS to policy.h * [tests] remove test_bitcoin.h dependency on txmempool.h * Fix -Wshadow warnings * test: add "diamond" unit test to MempoolAncestryTests * scripted-diff: Remove unused first argument to addUnchecked * Free BerkeleyEnvironment instances when not in use * Fix the abc-p2p-compactblocks when running whith UBSAN * Fix extra parenthesis in python .format() * Mark CTxMemPoolEntry members that should not be modified const * fix misc places that refer to virtual transaction size * Reintroduce IsSolvable * Merge #13002: Do not treat bare multisig outputs as IsMine unless watched * document MANDATORY_SCRIPT_VERIFY_FLAGS accurately * simplify checkdatasig_tests * fix scriptSig analysis in sign.cpp * [mempool_tests] add sigop counting check in TestPackageAccounting * redefine virtual transaction size to something useful * remove segwit 'sigops cost' leftovers * Add keys to source package * VerifyScript: accumulate ScriptExecutionMetrics and return them * fix inappropriate uses of virtual size * Wrap paths in codeblocks in release-process.md * Increase sparsity of pippenger fixed window naf representation * Remove unnecessary major.minor version from gitian-descriptors * Add Clang thread safety annotations for variables guarded by cs_db * [CMAKE] Actually run the seeder tests * [SECP256K1] Update Travis deprecated keywords * [SECP256k1] Add the CMake/Ninja build to Travis * [CMAKE] Add a check-extended target * Log env path in BerkeleyEnvironment::Flush * wallet: detecting duplicate wallet by comparing the db filename. * [bugfix] wallet: Fix duplicate fileid detection * [wallet] Reopen CDBEnv after encryption instead of shutting down * Make ECM error message more helpful * wallet: Reset BerkeleyDB handle after connection fails * Use best-fit strategy in Arena, now O(log(n)) instead O(n) * Nits in rpcdump * Various formating fix in validation.h * [DEPENDS] Allow to limit the jobs when building packages with ninja * [DEPENDS] Make the boost package build parallel * [SECP256K1] Move the autotools Travis build to it's own script * Added guide for OSX users on how to install clang-format-8. * Do not import private keys to wallets with private keys disabled * Add pippenger_wnaf for multi-multiplication * [DEPENDS] Make the qt package build parallel * [DEPENDS] Make bdb, dbus, event, miniupnpc, zmq packages build parallel * [DEPENDS] Make qrencode, protobuf and zlib packages build parallel * [DEPENDS] Make expat, fontconfig and freetype packages build parallel * [DEPENDS] Make all the x* packages build parallel * [DEPENDS] Make all the libX_* packages build parallel * [DEPENDS] Make all the native_* packages build parallel * [SECP256k1] Update the README to include the CMake build instructions * [SECP256K1] Add a case with Schnorr disabled to the Travis matrix * [CMAKE] Don't use C++ features for building secp256k1 * Bump version to 0.20.11 * [DEPENDS] Use parallel compilation when building packages * Add a facility to extract libsecp256k1 from the repository * Add Accelerate book to Bitcoin ABC reading list * Clean up more instances of create_transaction() * [CMAKE] Allow building secp256k1 as a standalone project * [UBSAN] Fix UBSAN issue in test_bitcon_main.cpp * [CMAKE] Cleanup secp256k1 module path * [cmake] Use list append when adding path to CMAKE_MODULE_PATH * [CI] Disable crypto assembly when building with ASAN * Avoid custom main for passing arguments to the unit tests * GUI: Change the receive button to respond to keypool state changing * [Tests] Cleanup feature_block.py, remove unnecessary PreviousSpendableOutput object * [Tests] Cleanup extra instances of create_transaction * [Tests] Rename create_tx and move to blocktools.py * Various nits in receivecoinsdialog.cpp * Various nits in walletmodel.cpp * [CMAKE] Fix DLL exports * [cmake] Make bench-secp256k1 actually run benchmarks, not simply build them. * Update secp256k1 README * add nSigChecks counting to EvalScript * [rpc] Finish backporting changes to prioritisetransaction's priority_delta argument * Revert "[mining] Rename several CBlockTemplateEntry members for clarity" ------------------------------------------------------------------- Sat Jan 04 14:03:43 UTC 2020 - marec@detebe.org - Update to version 0.20.10: * Merge #14568: build: Fix Qt link order for Windows build * Update seeds * Update manpages for 0.20.10 release * Update chainparams * Fix protobuf linking when building without the wallet * finish backporting PR9602 - misc * finish backporting PR9602 : remove unused priority number in mempool mapDeltas * finish backporting PR9602 - test_bitcoin clean up unused param * finish backporting PR9602 - remove unused and untested miner code * finish backporting PR9602 - remove unused functional test framework code * finish backporting PR9602 - remove unused modified-size computations * Add sig files to Github release * Fix nits in check-keys.sh * Fix missing newline at end of keys file * [CMAKE] Allow to run the extended functional tests * [CMAKE] Make the functional test run with upgrade activated * [CMAKE] Add a check-upgrade-activated magic target * [tests] allow BOOST_CHECK_EQUAL for ScriptErrors * [CMAKE] Separate the target for running the unit tests with upgrade * Merge #13791: gui: Reject dialogs if key escape is pressed * refactor null-signature checks in OP_CHECKSIG, OP_CHECKDATASIG * Backport PR11309: Minor cleanups for AcceptToMemoryPool * [diagnostic] perform more aggressive checking of the index during ActivateBestChain * Merge #15101: gui: Add WalletController * Merge #14451: Allow building GUI without BIP70 support * Fix heap-use-after-free in activation_tests * Remove GetPriority from CCoinsViewCache * Bump version to 0.20.10 * Remove priority from CTxMemPoolEntry * kill CTxMemPoolEntry::GetPriority * Remove deprecated startingpriority and currentpriority from RPC * CompareIteratorByHash => CompareIteratorById * Remove TxCoinAgePriorityCompare * Do not log priority when using -printpriority * [cmake] Use more sensible name for individual test targets * Merge #13844: doc: correct the help output for -prune * Merge #13412: Make ReceivedBlockTransactions return void * Rename activation tests which are now feature tests * Merge #13824: doc: Remove outdated net comment * Cleanup graviton activation * Make the tests use phonon activation instead of graviton * Merge #13776: net: Add missing verification of IPv6 address in CNetAddr::GetIn6Addr(...) * Some formatting nits in netaddress.cpp ------------------------------------------------------------------- Fri Dec 20 18:13:21 UTC 2019 - marec@detebe.org - Update to version 0.20.9: * [test-seeds] Stop the script if starting bitcoind failed * Update seeds * Filter IPv6 by ASN * Update manpages for 0.20.9 release * Update chainparams * Remove blockprioritypercentage config parameter. * Add phonon activation logic * [CMAKE] Override default flags * Merge #13451: rpc: expose CBlockIndex::nTx in getblock(header) * [backport] net: Allow connections from misbehavior banned peers * [CI] Don't override the default Junit file name * [CMAKE] Unbreak the activated tests * [CMAKE] Add a status message to inform the user that ccache is used * [AUTOTOOLS] Don't build the seeder tests if --disable-tests is set * Merge #13419: [tests] Speed up knapsack_solver_test by not recreating wallet 100 times. * Merge #13775: doc: Remove newlines from error message * Merge #13773: wallet: Fix accidental use of the comma operator * stop rewinding post-segwit blocks on startup * [backport] gui: Show messages as text not html * Fix -Wcast-align in crypto_hash.cpp * [LINTER] Enable new autopep8 rules * [LINTER] Remove empty lines at the beginning of a block * test: Add missing LIBBITCOIN_ZMQ to test_test_bitcoin_LDADD * autoconf: Sane --enable-debug defaults. * [CMAKE] Allow to run boost unit tests in parallel * Static assert with no message is a C++17 feature and warns on C++14 * [LINTER] Fix the tests linter * Add a separate executable for seeder tests * Fix enum NumConnections shadowing warning * checkmultisig: refactor nullfail check * remove priority free transactions mechanism (currently off by default) * fix some tests that rely on free transactions being submittable via RPC * Replace integer literals in dnshandle() with an enum class * clean up some tests that needlessly use -replayprotectionactivationtime * Add test-seeds CI configs * Fetch and check signature and sha256sum of debian ISO instead of comparing against a hardcoded hash * [DOC] Update build documentation and contributing to use cmake and ninja * Merge #14350: Add WalletLocation class * [CI] Always move the Gitian install and build log * Update Debian 10.x ISO link in the Gitian setup docs * We assume uint8_t is an alias of unsigned char. * Merge #14474: bitcoin-tx: Use constant for n pubkeys check * Merge #11866: Do not un-mark fInMempool on wallet txn if ATMP fails. * test: Move main_tests to validation_tests * Merge #14206: doc: Document -checklevel levels * Merge #13534: Don't assert(foo()) where foo() has side effects * Merge #13662: Explain when reindex-chainstate can be used instead of reindex * Fixes AES benchmarks * qt: Replace objc_msgSend with native syntax * [CMAKE] Fix wrong Openssl include directory variable name * add SCHNORR_MULTISIG to mandatory flags * Make more script validation flags backward compatible * fix fee estimation bug in functional tests * fix some tests that misuse MANDATORY_SCRIPT_VERIFY_FLAGS * Sanity check for mempool acceptance when doing standardness checks * Merge #13656: Remove the boost/algorithm/string/predicate.hpp dependency * Daemonize bitcoind in test-seeds.sh rather than run in a background process * Merge #13667: wallet: Fix backupwallet for multiwallets * refactor: replace qLowerBound & qUpperBound with std:: upper_bound & lower_bound * Merge #13633: Drop dead code from Stacks * [CI] Migrate the CI to use cmake and ninja * [CMAKE] Fix Qt tests when the wallet is not built * Remove unused functions in seeder/db.h * [UBSAN] Update exceptions * [CMAKE] SYS_getrandom is expected to be linux only * [CMAKE] Fix FindBerkeleyDB for FreeBSD * [CMAKE] Enable SSE4.1, SHA-NI and AVX2 for the crypto library * reduce code duplication in UpdateFlags * Merge #13298: Net: Bucketing INV delays (1 bucket) for incoming connections to hide tx time * [wallet] Add wallet name to log messages * [tests] Fix race in rpc_deprecated.py * add SCRIPT_VERIFY_MINIMALDATA to mandatory flags * Add braces to support/lockedpool.cpp * Abstract EraseBlockData out of RewindBlockIndex * [CI] Print the sanitizer logs * [CI] Move the sanitizer log directory to /tmp * [CMAKE] Add an option to promote some warnings to errors * Remove Unused CTransaction tx in wallet.cpp * Privatize CWallet::AddToWalletIfInvolvingMe * Extract CWallet::MarkInputsDirty * [CMAKE] Silent the Qt translation files generation * allow cuckoocache to function as a map * Merge #12944: [wallet] ScanforWalletTransactions should mark input txns as dirty * Log debug build status and warn when running benchmarks * bench_bitcoin: Avoid read/write to default datadir * test_bitcoin: Avoid read/write to default datadir * Merge #13074: [trivial] Correct help text for `importaddress` RPC * Merge #13500: [wallet] Decouple wallet version from client version * partial revert of tx decode sanity check backport * fix incomplete txvalidationcache_tests * Fix cuckoocache_tests -Wcast-align warnings * [cuckoocache] Use getKey and KeyType for contains * Merge #13627: Free keystore.h from file scope level type aliases * Merge #13603: bitcoin-tx: Stricter check for valid integers * [move only] Move BIP70 code together in preparation to backport PR14451 BIP70 changes * Sanity-check script sizes in bitcoin-tx * Fix unused variable warning when building with wallet disabled * Bump version to 0.20.9 ------------------------------------------------------------------- Fri Dec 06 17:15:52 UTC 2019 - marec@detebe.org - Update to version 0.20.8: * Update seeds * Update manpages for 0.20.8 release * Update chainparams * Remove errant --testnet argument in chainparams README * Fix apptest build failure on Xenial * Small fix in CONTRIBUTING.md - clang-format-7 still mentioned, but 8 is required * Small fix in backporting.md - remove unneeded trailing . for git remote add command * Fix missing blockhash cast in wallet_tests.cpp * Add wallet acceptance / mempool acceptance tests for non-standard variants * Fix a bug where test-autopatch would fail when the local master branch does not have the same HEAD as origin/master * Fix a bug where test-autopatch would fail in an env where no global git config is set * Fix ninja check with TEST_WITH_UPGRADE_ACTIVATED for newer versions of boost * [CMAKE] Make the source control tools inclusion an option * Merge #13566: Fix get balance * Remove check-source-control-tools from check and check-all targets * [cuckoocache] Use matchKey instead of the == operator. * refactoring: add a method for determining if a block is pruned or not * Integrate gArgs and chainparams into the Seeder * Various nits in cuckoocache_tests.cpp * doc: Doxygen-friendly CuckooCache comments * Rename contrib/arcanist to source-control-tools * Various nits in Seeder files * Merge #11293: Deduplicate CMerkleBlock construction code, add test coverage * Fix -Wunused-const-variable in descriptor_tests.cpp * Bugfix: Include <memory> for std::unique_ptr * fix undefined behaviour in seeder (select() aliasing) * Update the github issue template to include disclosure policy * remove NULLDUMMY * refactor: Add and use HaveTxsDownloaded() where appropriate * Added autopatch script for patching and rebasing phabricator diffs * Make TxIndex::FindTx use BlockHash * Update GetTransaction's parameters * Update mempool and compact block logic to use TxHash * tx pool: Use class methods to hide raw map iterator impl details * Update mempool's mapDelta to use TxId * Update mempool's mapTx to index from TxId. * Use TxId in setInventoryTxToSend * refactor: Drop boost::this_thread::interruption_point and boost::thread_interrupted in main thread * Use BlockHash in BlockTransactionsRequest * [cmake] link test runners by default * Drop minor GetSerializeSize template * Avoid creating a temporary vector for size-prefixed elements * Drop unused GetType() from CSizeComputer * validation: assert that pindexPrev is non-null when required * [CMAKE] Avoid rebuilding sec256k1 * [CMAKE] Fix scope issue in the remove_<lang>_compiler_flags() functions * Rationalize lock anotation in validation code * tests: Add missing cs_main locks required when accessing pcoinsdbview, pcoinsTip or pblocktree * Introduce BlockHash to represent a block hash * Add braces in block.h * Use size_t where apropriate in skiplist_tests.cpp * Add Benchmark to test input de-duplication worst case * Add const modifier to HTTPRequest methods * Add braces in txdb.cpp * Move pindexFinalized in CChainState * Explain GetAncestor check for m_failed_blocks in AcceptBlockHeader * Remove unnecessary const_cast * Fix activation_tests * Add fuzz testing for BlockTransactions and BlockTransactionsRequest * [test] Speed up fuzzing by ~200x when using afl-fuzz * [CMAKE] Build test_bitcoin_fuzzy * drop 'check3' upgrade-conditional-script-failure for Schnorr multisig * Nit in net_processing.cpp * Backport PR14897, PR15834 and PR16196 * Merge #15149: gui: Show current wallet name in window title * Update timings.json * Various nits in net_processing.cpp * p2p: Clarify control flow in ProcessMessage() * Backport of Core PR14728: fix uninitialized read when stringifying an addrLocal * previous link was dead * Merge #14784: qt: Use WalletModel* instead of the wallet name as map key * test: Fix test failures * qa: fix deprecated log.warn in feature_dbcrash test * [tests] fix block time in feature_pruning.py * [tests] make pruning test faster * [tests] style fixes in feature_pruning.py * [test] Rename rpc_timewait to rpc_timeout * Minor improvements to add_nodes * qa: Extract rpc_timewait as test param * Fix copy in loop * Trivial: Corrected comment array name from pnSeeds6 to pnSeed6 * Merge #13498: [wallet] Fixups from account API deprecation * Merge #12639: Reduce cs_main lock and avoid extra lookups of mapAddressBook in listunspent RPC * [wallet] [rpc] Remove getlabeladdress RPC * Fix wrong version in clang-format error message and update the doc * Merge #13138: [tests] Remove accounts from wallet_importprunedfunds.py * Merge #13437: wallet: Erase wtxOrderd wtx pointer on removeprunedfunds * Add test coverage for messages requesting invalid blocks * Drop IsLimited in favor of IsReachable * Remove undue lock assertion in GuessVerificationProgess * Revert use of size_t in ParseParameters * Fixes broken link to disclosure policy * [tests] Remove 'account' API from wallet_listsinceblock * [tests] Remove 'account' API from wallet_basic * Move to clang format 8 * Added support for -gravitonactivationtime to unit tests * [tests] Remove 'account' API from wallet_txn_doublespend * [tests] Remove 'account' API from wallet_txn_clone * [tests] Remove 'account' API from wallet_listtransactions * [tests] Remove 'account' API from wallet_keypool_topup * [tests] Remove 'account' API from wallet_import_rescan * Merge #13055: qt: Don't log to console by default * [cmake] Add comments to express what tests do. * [cmake] Remove useless copy of create_cache.py * [tests] Remove 'account' API from wallet_listreceivedby * Split out key-value parsing in ArgsManager into its own function * IsReachable is the inverse of IsLimited (DRY). Includes unit tests * Bump version to 0.20.8 * [cmake] Use terminal when runnign integration tests * Rename GetLogger() to LogInstance() * Add missing parts from PR12954 * Use RdSeed when available, and reduce RdRand load * Print to console by default when not run with -daemon * Improve formatting in rpcwallet.cpp * Leftover from PR13423 * Stop translating command line options * minor refactor to use ranged_for, auto and const-ness * test: Make bloom tests deterministic * qa: Increase includeconf test coverage * Bump minimum Qt version to 5.5.1 * Add BitcoinApplication & RPCConsole tests * Kill AddKeypathToMap ------------------------------------------------------------------- Mon Nov 25 20:23:56 UTC 2019 - marec@detebe.org - Update to version 0.20.7: * Update manpages for 0.20.7 release * Update chainparams * Update seeds * util: Add [[nodiscard]] to all {Decode,Parse}[...](...) functions returning bool * Make SignPSBTInput operate on a private SignatureData object * Pass HD path data through SignatureData * Implement key origin lookup in CWallet * wallet: Fix non-determinism in ParseHDKeypath(...). Avoid using an uninitialized variable in path calculation. * Generalize PublicOnlySigningProvider into HidingSigningProvider * More tests of signer checks * Update valid PSBT test vectors so that they properly use the value 0 for utxos's key * Add aarch64 qt depends support for cross compiling bitcoin-qt * [CMAKE] Migrate windows gitian build to cmake and ninja * [GITIAN] Migrate OSX Gitian builds to CMake and Ninja * [CMAKE] Migrate linux gitian build to cmake and ninja * Allow to pass the chain parameters when formatting a bitcoin URI * Move BitcoinApplication to header so it can be tested * Don't use systray icon on inappropriate systems * add a couple more Schnorr checkmultisig tests * Make SigningProvider expose key origin information * [MOVEONLY] Move ParseHDKeypath to utilstrencodings * Introduce KeyOriginInfo for fingerprint + path * Merge #9662: Add createwallet "disableprivatekeys" option: a sane mode for watchonly-wallets * Use local instance of ArgsManager in getarg_tests * [CMAKE] Add DBus support to bitcoin-qt * qt: All tray menu actions call showNormalIfMinimized * qt: Use GUIUtil::bringToFront where possible * qt: Add GUIUtil::bringToFront * Remove obj_c for macOS Dock icon menu * Use Qt signal for macOS Dock icon click event * [CMAKE] Use a NSIS custom template * Test that a non-witness script as witness utxo is not signed * Use 72 byte dummy signatures when watching only inputs may be used * Use 71 byte signature for DUMMY_SIGNATURE_CREATOR * Always create 70 byte signatures with low R values * Additional sanity checks in SignPSBTInput * Introduce a maximum size for locators. * test: Add tests for RPC help * Remove obj_c for macOS Dock icon setting * gui: Favor macOS show / hide action in dock menu * Add missing braces on key.cpp * qa: Premine to deterministic address with -disablewallet * RPC: Add new getzmqnotifications method. * Break circular dependency: init -> * -> init by extracting shutdown.h * Drop unused init.h includes * Add Windows shutdown handler * Add checkpoints for graviton upgrade * [github-release] Add optional param to specify release notes path * Fix merging of global unknown data in PSBTs * Check that PSBT keys are the correct length * Add brace in bitcoin-tx.cpp * Fix PSBT error test vectors * Add outputtype module * [CMAKE] Use a stripped binary to build the dist and DMG for OSX * [CMAKE] Only build the bitcoin-qt application bundle on OSX * [CI] Add a new build configuration to run tests with cmake and ninja * [CI] Rename build.sh to build_autotools.sh * Merge #14025: p2p: Remove dead code for nVersion=10300 * fix txvalidationcache_tests to not rely on NULLDUMMY * Various nits in the ChainParams code. * Added missing instructions for OSX gitian building * Various nits in cuckoocache.h * [CMAKE] Avoid dependencies when building native bin during cross build * Add/update copyright lines to top of seeder code * Added CMake function to detect BOOST_TEST_DYN_LINK * Add descriptor reference documentation * Swap in descriptors support into scantxoutset * Output descriptors module * [CMAKE] Actually build the DMG image * Get rid of ambiguous OutputType::NONE value * Fix unecessary copies in rpcwallet.cpp * Add scantxoutset RPC method * [CMAKE] Install DLL to bin/ by default * [CMAKE] Complete the dist directory to prepare for the DMG image build * [CMAKE] Build the background dist image on native OSX * [CMAKE] Add the background image to the dist directory * [CMAKE] Create a distribution directory with translations * [CMAKE] Prepare the application bundle for localization * Add simple FlatSigningProvider * Tests for PSBT * Create wallet RPCs for PSBT * Bump version to 0.20.7 * Document RNG design in random.h * Use secure allocator for RNG state * Encapsulate RNGState better * DRY: Implement GetRand using FastRandomContext::randrange * Remove hwrand_initialized. * Sprinkle some sweet noexcepts over the RNG code * [CI] Run the thread sanitizer as part of the CI * Switch all RNG code to the built-in PRNG. * Integrate util/system's CInit into RNGState ------------------------------------------------------------------- Sat Nov 09 13:25:24 UTC 2019 - marec@detebe.org - Update to version 0.20.6: * Updated manpages for 0.20.6 release * Updated chainparams * Updated seeds * Added a release note regarding builds needing python 3.5 * Abstract out seeding/extracting entropy into RNGState::MixExtract * Add thread safety annotations to RNG state * Rename some hardware RNG related functions * Automatically initialize RNG on first use. * Don't log RandAddSeedPerfmon details * Use FRC::randbytes instead of reading >32 bytes from RNG * [CMAKE] Generate the split-debug.sh script * Create utility RPCs for PSBT * [CMAKE] Use native strip on OSX * build: depends: Switch to python3 * depends: biplist 1.0.3 * Upgrade mac_alias to 2.0.7 * [depends] mac_alias 2.0.6, ds_store 1.1.2 * Add more methods to Span class * Fix comment layout in client.h * Deprecate wallet 'account' API * [wallet] Deprecate account RPC methods * [wallet] [rpc] Remove duplicate entries in rpcwallet.cpp's CRPCCommand table * [tests] Rename rpc_listtransactions.py to wallet_listtransactions.py * Merge #12892: [wallet] [rpc] introduce 'label' API for wallet * Merge #9894: remove 'label' filter for rpc command help * test: Remove python3.4 workaround in feature_dbcrash * build: Require python 3.5 * Run all extended tests on master for build-default * Display the default values as part of the test_runner.py help * scripted-diff: Update copyright in ./test * Fix various linter issues * scripted-diff: test: Remove brackets after assert * scripted-diff: test: Use py3.5 bytes::hex() method * [GITIAN] Sort dependencies lexically * [GITIAN] Remove symbolic link to asm for 32-bits gitian build * test: Add lint to prevent SIGNAL/SLOT connect style * [contrib] Support ARM symbol check * Migrate Gitian container to Debian 10 Buster * Various fixups for PR13557 * [CMAKE] Move FDELT_TYPE declaration to config * Update qt/optionsdialog.cpp with Qt5 connect syntax * Update qt/walletview.cpp with Qt5 syntax * Update qt/test/paymentservertests.cpp to use Qt5 connect syntax * Update qt/walletmodel.cpp with Qt5 connect syntax * Update qt/bitcoin.cpp with Qt5 connect syntax * Update qt/qvalidatedlinedit.cpp to use Qt5 connect syntax * Update qt/walletframe.cpp with Qt5 connect syntax * Update qt/bitcoingui with Qt5 connect syntax * [CMAKE] Fix missing inclusion when libbitcoinconsensus is disabled * Update qt/transactionview.cpp with Qt5 connect syntax * Update qt/sendcoinsdialog.cpp with Qt5 connect syntax * Update qt/rpcconsole with Qt5 connect syntax * Update qt/recentrequestdialog.cpp with Qt5 connect syntax * Update qt/receivecoinsdialog.cpp with Qt5 connect syntax * Update qt/transactiontablemodel.cpp with Qt5 connect syntax * Update qt/trafficgraphwidget.cpp with Qt5 connect syntax * Update qt/sendcoinsentry.cpp with Qt5 connect syntax * Update qt/qvaluecombobox.cpp to use Qt5 connect syntax * Update qt/receiverequestdialog.cpp with Qt5 connect syntax * Update user agent filter in makeseeds.py * Update qt/peertablemodel.cpp with Qt5 connect synax * Update qt/paymentserver.cpp with Qt5 connect syntax * Update qt/overviewpage.cpp with Qt5 connect syntax * Update qt/modaloverlay.cpp with Qt5 connect syntax * Update qt/intro.cpp to use Qt5 connect syntax * Update qt/guiutil.cpp to use Qt5 connect syntax * Update qt/coincontroldialog.cpp to use Qt5 connect syntax * SignPSBTInput wrapper function * Methods for interacting with PSBT structs * Add pubkeys and whether input was witness to SignatureData * Implement PSBT Structures and un/serialization methods per BIP 174 * [CMAKE] Build the OSX application bundle for bitcoin qt * [CMAKE] Create a windows installer * [CMAKE] Build bitcoinconsensus library both static and shared * Add testnet-seed.bchd.cash to seeder lists * Update qt/clientmodel.cpp to use Qt5 syntax * Merge #12924: Fix hdmaster-key / seed-key confusion * Rename master key to seed * Update qt/bitcoinamountfield.cpp to use Qt5 connect syntax * Update qt/askpassphrasedialog.cpp to use Qt5 connect syntax * Update qt/addressbookpage.cpp to use Qt5 connect syntax * rpc: Expose g_is_mempool_loaded via getmempoolinfo * Refactor transaction creation and transaction funding logic * Separate CSeederNode class declaration from definition * Move parse_name() to dns.h so it can be tested * Bump version to 0.20.6 * Merge #13481: doc: Rewrite some validation docs as lock annotations ------------------------------------------------------------------- Sat Oct 26 15:56:36 UTC 2019 - marec@detebe.org - Update to version 0.20.5: * Updated manpages for 0.20.5 release * Updated chainparams * Update seeds * bench: Benchmark MempoolToJSON * Merge #14444: Add compile time checking for cs_main locks which we assert at run time * Merge #13114: wallet/keystore: Add Clang thread safety annotations for variables guarded by cs_KeyStore * Add test_runner flag to suppress ASAN errors from wallet_multiwallet.py * [CMAKE] Move package name and copyright to the top level * Added build-werror config to error on build warnings * Merge #13248: [gui] Make proxy icon from statusbar clickable * Merge #13043: [qt] OptionsDialog: add prune setting * Fix -Wrange-loop-analysis warnings * Fix -Wthread-safety-analysis warnings * [CMAKE] Use CPack to build source packages * [CMAKE] Use CPack to build packages * mempool: remove unused magic number from consistency check * Merge #13258: uint256: Remove unnecessary crypto/common.h dependency * Merge #11491: [gui] Add proxy icon in statusbar * bugfix: Remove dangling wallet env instance and Delete walletView in WalletFrame::removeWallet * ui: Support wallets unloaded dynamically * rpc: Add unloadwallet RPC, release notes, and tests * rpc: Extract GetWalletNameFromJSONRPCRequest from GetWalletForJSONRPCRequest * [mempool] Mark mempool import fails that were found in mempool as 'already there' * [CMAKE] Propagate requirements for cmake >= 3.12 * Merge #11050: Avoid treating null RPC arguments different from missing arguments * Merge #11191: RPC: Improve help text and behavior of RPC-logging. * Merge #11626: rpc: Make `logging` RPC public * [rpc] Add logging RPC * Change CDnsSeedOpts to use std::string instead of c-strings * Introduce constant default variables to initialize seeder options * Remove strlcpy.h * Fix misnamed 0.20.4 release notes * [CMAKE] Add resource file to bitcoin-qt * Merge #13722: trivial: Replace CPubKey::operator[] with CPubKey::vch where possible * Fix --wipeignore and add message indicating if wipe options are set and successful * Decodehextx scripts sanity check * Update seeder files to use fprintf() instead of printf() * Merge #9598: Improve readability by removing redundant casts to same type (on all platforms) * Merge #13275: Qt: use [default wallet] as name for wallet with no name * Merge #13506: Qt: load wallet in UI after possible init aborts * Merge #13564: [wallet] loadwallet shouldn't create new wallets. * Merge #13097: ui: Support wallets loaded dynamically * Merge #13273: Qt/Bugfix: fix handling default wallet with no name * Version Bump to v20.5 * [gitian-build] Move manifest files to output directory * [gitian-build] Refactor to calculate output directories in fewer places ------------------------------------------------------------------- Fri Oct 11 13:04:19 UTC 2019 - marec@detebe.org - Update to version 0.20.4: * Update manpages for 0.20.4 release * Update chainparams * Update seeds * Do not cache version in cmake build * mempool, validation: Explain cs_main locking semantics * [build-configurations] Make BUILD_DIR configurable * [LINTER] Check for header guard closure comment * Merge #13058: [wallet] `createwallet` RPC - create new wallet at runtime * Update Seeder to use fsbridge::fopen() instead of fopen() * Make objects in range declarations immutable by default. Avoid unnecessary copying of objects in range declarations. * cli: Ignore libevent warnings * Merge #13252: Wallet: Refactor ReserveKeyFromKeyPool for safety * [build-configurations] Resurface the more informative error message when ABC_BUILD_NAME is not set * Added translations for new send coins dialog box * Merge #13158: [Qt]: Improve sendcoinsdialog readability * Bump wallet version for pre split keypool * Allow -upgradewallet to upgradewallets to HD and use a keypool of presplit keys after upgrading to hd chain split * Remove redundant assignments (dead stores) * Drop ParseHashUV in favor of calling ParseHashStr * Add 'sethdseed' RPC to initialize or replace HD seed and test * Remove CombineSignatures and replace tests * Replace CombineSignatures with ProduceSignature * Make SignatureData able to store signatures and scripts * Drop UpdateTransaction in favor of UpdateInput * Generic TransactionSignatureCreator works with both CTransaction and CMutableTransaction * Introduce Span type and use it instead of FLATDATA * [cmake] Create a lib specifically for script related components * Inline Sign1 and SignN * Separate HaveKey function that checks whether a key is in a keystore * Merge #13176: Improve CRollingBloomFilter performance: replace modulus with FastMod * Add native support for serializing char arrays without FLATDATA * refactor: Avoid locking tx pool cs thrice * Return void instead of bool for functions that cannot fail * Relayout comment in sign.h * Merge #11411: script: Change SignatureHash input index check to an assert. * Minor improvements to github-release script * validation: Pass tx pool reference into CheckSequenceLocks * utils: Convert Windows args to utf-8 string * Merge #12240: [rpc] Introduced a new `fees` structure that aggregates all sub-field fee types denominated in BCH * Change CI builds to use utf-8 encoding * Added support for `export LC_ALL=C.UTF-8` to the shell linter * Updated release-process to use github-release.sh * Added more explicit instructions for release tagging * Bump version to 0.20.4 * Add phpcs exclusion for strict_types declararion * Add static_assert to prevent VARINT(<signed value>) * [CMAKE] Enable Large File Support on platforms that don't enable it by default * Add support for Glibc version 2.28 * util: Replace boost::signals2 with std::function * Added a script for creating Github release drafts * doxygen: Fix member comments * [CMAKE] Use CMake built-in to set PIC and PIE * [CMAKE] Fix check-security to allow running on windows executables * Use only 3 levels for defining the version * tiny refactor for ArgsManager * Document RPC method aliasing * Add AssertLockHeld assertions in CWallet::ListCoins * Merge #13304: qa: Fix wallet_listreceivedby race * Merge #13284: gui: fix visual "overflow" of amount input. ------------------------------------------------------------------- Sat Sep 28 12:57:46 UTC 2019 - marec@detebe.org - Update to version 0.20.3: * Update seeds * Updated manpages for 0.20.3 release * Updated chainparams * Added README for generating chainparams constants * Avoid locking mutexes that are already held by the same thread * Added net debug info to IBD builds * Merge #12265: [test] fundrawtransaction: lock watch-only shared address * Added a script to generate chainparams constants from intermediate files * [CMAKE] Detect if the compiler supports visibility function attribute * [CMAKE] Install executables * [CMAKE] Install the man pages * [CMAKE] Add the check-security target * [CMAKE] Add the check-symbols target * Move cs_main locking annotations from .cpp to .h * Merge #11220: Check specific validation error in miner tests * Remove redundant variables, statements and forward declarations * Fix errant newline in make_chainparams * [CMAKE] Consistently find and use the python interpreter * [CMAKE] Migrate the python header generation scripts to python 3 * [CMAKE] Only change obj/build.h if the content has changed * Run miner_tests with fixed options * Abstract out BlockAssembler options * Fix compiler warnings emitted when compiling under stock OpenBSD 6.3 * Merge #13201: [qa] Handle disconnect_node race * Merge #13402: Document validationinterace callback blocking deadlock potential. * Revert change to PreciousBlock() comment made in D1182 * Fix missing newline in make_chainparams * [RPC] Fix header guard comment * Merge #13197: util: warn about ignored recursive -includeconf calls * Merge #13079: Fix rescanblockchain rpc to properly report progress * Merge #13012: [doc] Add comments for chainparams.h, validation.cpp * Merge #12716: Fix typos and cleanup in various files * wallet: Use shared pointer to retain wallet instance * scripted-diff: Replace boost::bind with std::bind * refactor: Use boost::scoped_connection in signal/slot, also prefer range-based loop instead of std::transform * Use TxId where apropriate in wallettests.cpp * [CMAKE] Fix linux cross compilation with the glibc compatibility * [CMAKE] Remove useless dependency for the check-rpcauth target * scripted-diff: batch-recase BanMan variables * banman: Add, use CBanEntry ctor that takes ban reason * banman: reformulate nBanUtil calculation * banman: add thread annotations and mark members const where possible * scripted-diff: batch-rename BanMan members * net: move BanMan to its own files * banman: pass in default ban time as a parameter * banman: pass the banfile path in * banman: create and split out banman * Move util files to directory * Use C++11 default member initializers * debug log number of unknown wallet records on load * Add compile time verification of assumptions we're currently making implicitly/tacitly * Use std::make_unique more consistently * bench: Use non-throwing ParseDouble(...) instead of throwing boost::lexical_cast<double>(...) * [qt] send: Clear All also resets coin control options * [qt] Replaces numbered place marker %2 with %1. * Remove unecessary obj folder * [CMAKE] Always build obj/build.h * Revert change to ActivateBestChain() comments made in D1182 * Merge #13234: Break circular dependency: chain -> pow -> chain * Partial Merge #12920: test: Fix sign for expected values * Merge #13431: validation: count blocks correctly for check level < 3 * Merge #13428: validation: check the specified number of blocks (off-by-one) * Merge #12885: Reduce implementation code inside CScript * net: split up addresses/ban dumps in preparation for moving them * depends: qt: avoid system harfbuzz and bz2 * [gitian-build] Change output file destinations to separate directories for each platform * Merge #13022: [qa] Attach node index to test_node AssertionError and print messages * Merge #15239: scripts and tools: Move non-linux build source tarballs to "bitcoin-binaries/version" directory * Fix avalanche test with boost 1.58 * Remove GetNextBlockScriptFlags's requirement to hold cs_main * Add compile time checking for all cs_main runtime locking assertions * Use C++11 default member initializers * Drop unused pindexRet arg to CMerkleTx::GetDepthInMainChain * Merge #13149: Handle unsuccessful fseek(...):s * [CI] Workaround ubsan failure in functional tests * [CI] Refactor the build configuration by moving out tests from the build * Add recommendation: By default, declare single-argument constructors `explicit` * Nits in httpserver.cpp * Move SocketHandler logic to private method. * Update the agent pattern filter in the makeseeds.py script * [CMAKE] Add support to build secp256k1 JNI binding and tests * Move InactivityCheck logic to private method. * Move DisconnectNodes logic to private method. * Move NotifyNumConnectionsChanged logic to private method. * tests: remove member connman/peerLogic in TestingSetup * [SECP256K1] Create a different library when building with JNI * Convert comments to thread safety annotations * net: Add Clang thread safety annotations for guarded variables in the networking code * Report minfeefilter value in getpeerinfo rpc * Prefer wait_until over polling with time.sleep * [SECP256K1] Build java class files out of tree * Add seed.bchd.cash to seeder lists * Bump version to 0.20.3 * net: Break disconnecting out of Ban() * Improve reliability of avalanche test * [ibd.sh] Fix IBD progress logging * [trivial,doc] Fix memory consistency model in comment * [qt] coincontrol: Remove unused qt4 workaround * [build] .gitignore: add QT Creator artifacts * Adding test case for SINGLE|ANYONECANPAY hash type in tx_valid.json * Remove TestBlockValidity's dependency on Config * Remove ConnectBlock's dependency on Config * Remove CheckBlock's dependency on Config * [net] Tighten scope in net_processing * Add documentation to PeerLogicValidation interface and related functions ------------------------------------------------------------------- Fri Sep 13 14:45:24 UTC 2019 - marec@detebe.org - Update to version 0.20.2: * [CI] Fix missing parameters transfer from ibd.sh to bitcoind * Update manpages for 0.20.2 release * Update chainparams * Merge #12159: Use the character based overload for std::string::find. * Merge #13983: rpc: Return more specific reject reason for submitblock * Merge #13399: rpc: Add submitheader * Merge #13439: rpc: Avoid "duplicate" return value for invalid submitblock * Updated seeds * Fixes compilation of leveldb tests broken in D4004 * [CI] Make IBD a standard build configuration * Remove ContextualCheckBlock's dependency on Config * Remove CheckBlockHeader's dependency on Config * [CMAKE] Fix Linux64 toolchain name * Source the Excessive block size from BlockValidationOptions * Do not construct out-of-bound pointers in SHA2 code * Avoid triggering undefined behaviour (std::memset(nullptr, 0, 0)) if an invalid string is passed to DecodeSecret(...) * Pull leveldb subtree * [CMAKE] Move version to the top level CMakeLists.txt * [CMAKE] Rename the top-level and `src/` cmake projects * Generalized ibd.sh to provide a logging tool for running similar types of tests * Modify ContextualCheckBlockHeader to accept a CChainParam rather than a Config * Remove ReadBlockFromDisk's dependency on Config * Remove dependency on Config from the PoW code * Use Consensus::Params in ContextualCheckTransaction and variations instead of Config * Activate consensus rule based on consensus params rather than config * Add warning about redundant moves * Remove redundant call to std::move * Fix the build-osx target for the depends subsystem * Merge #12853: qa: Match full plain text by default * Added a script to test seeds * Added some release notes * [CI] Improve error catching and build log verbosity * Merge #10537: Few Minor per-utxo assert-semantics re-adds and tweak * Merge #12928: qt: Initialize non-static class members that were previously neither initialized where defined nor in constructor * Merge #13747: tests: Skip P2PConnection's is_closing() check when not available * Merge #13916: qa: wait_for_verack by default * [SECP256K1] JNI tests : remove dependency to obsolete DatatypeConverter * [TRIVIAL] Cleanup the JNI test file * [Linter] Check the log prints are terminated with a newline * [LINTER] Enforce using C++ style for void parameters * Bugfix: NSIS: Exclude Makefile* from docs * Merge #12503: [RPC] createmultisig no longer takes addresses * Merge #13658: [moveonly] Extract RescanWallet to handle a simple rescan * Merge #11338: qt: Backup former GUI settings on `-resetguisettings` * [rebase] threads: fix unitialized members in sched_param * Update univalue subtree * Merge leveldb subtree * Bump leveldb subtree * Merge #13517: qa: Remove need to handle the network thread in tests * Merge #11818: I accidentally [deliberately] killed it [the ComparisonTestFramework] * Merge #13512: [qa] mininode: Expose connection state through is_connected * Fix incorrectly backported return statements in mininode.py * Increase LevelDB max_open_files unless on 32-bit Unix. * Remove extra newline that leads to linter warning * Added a script to generate chainparams intermediate files * wallet: Catch filesystem_error and raise InitError * During IBD, when doing pruning, prune 10% extra to avoid pruning again soon after * Merge #13081: wallet: Add compile time checking for cs_wallet runtime locking assertions * Merge #11044: [wallet] Keypool topup cleanups * Migrated abc-p2p-compactblocks.py off of ComparisonTestFramework * Migrated abc-p2p-fullblocktest.py off of ComparisonTestFramework * Migrated abc-mempool-coherence-on-activations.py off of ComparisonTestFramework * Migrated abc-transaction-ordering.py off of ComparisonTestFramework * Merge #13077: Add compile time checking for all cs_KeyStore runtime locking assertions * Add missing override keyword to DummySignatureCreator::CreateSig() * Merge #13159: Don't close old debug log file handle prematurely when trying to re-open (on SIGHUP) * Merge #13148: logging: Fix potential use-after-free in LogPrintStr(...) * Default to defining endian-conversion DECLs in compat w/o config * Consistently log CValidationState on failure * Remove deprecated features for the 0.20.x branch * Merge #12507: Interrupt rescan on shutdown request * Make sure LC_ALL=C is set in all shell scripts * Fix deprecated copy warnings in amount.h * Bump version to 0.20.2 ------------------------------------------------------------------- Fri Aug 30 18:44:04 UTC 2019 - marec@detebe.org - Update to version 0.20.1: * Update manpages for 0.20.1 release * Update chainparams * Merge #12923: util: Pass pthread_self() to pthread_setschedparam instead of 0 * Merge #12618: Set SCHED_BATCH priority on the loadblk thread. * Update seeds * Add some more release notes for 0.20.1 * Fix running teamcity builds when multiple configure flags are set * Fix shellcheck version >= 0.5.0 errors * [LINTER] Enforce using `#!/usr/bin/env bash` for shell scripts * Improve formatting of developer notes * Merge #12702: [wallet] [rpc] [doc] importprivkey: hint about importmulti * Merge #12709: [wallet] shuffle sendmany recipients ordering * Increase timeout on avalanche test. * [DOC] Fix out of order sections in the developer notes * Add shell script linting: Check for shellcheck warnings in shell scripts * Remove the unused git-subtree-check.sh script * Shell script cleanups * Remove unused variables in shell scripts. * Delete the contrib/verify-commits subtree * Migrate gitian-build.sh to python * [docs] Add instructions for lcov coverage report generation * Remove script to clean up datadirs * Add DynamicMemoryUsage() to LevelDB * [contrib] Add Valgrind suppressions file * Merge #12747: Fix typos * Merge #11193: [Qt] Terminate string *pszExePath after readlink and without using memset * use base58 map instead of strchr() * Disable wallet and address book Qt tests on macOS minimal platform * Merge #12305: [docs] [refactor] Add help messages for datadir path mangling * Merge #12770: Use explicit casting in cuckoocache's compute_hashes(...) to clarify integer conversion * Merge #12561: Check for block corruption in ConnectBlock() * Merge #11131: rpc: Write authcookie atomically * Merge #12721: Qt: remove "new" button during receive-mode in addressbook * Add python3 script shebang lint * Remove the ZMQ example for Python 2 * Various textual improvements in build docs * Docs: Add disable-wallet section to OSX build instructions * Remove Qt4 from the OSX build documentation * trivial: Improve include comment in src/interfaces/wallet.h * Cleanup TODOs leftover from PR14119 backporting * Cleanup reject_code in abc-schnorr.py * Cleanup reject_code in abc-segwit-recovery * trivial: Fixed typos and cleaned up language * release: require macOS 10.10+ * Rename “OS X” to the newer “macOS” convention * doc: add qrencode to brew install instructions * [docs] initial QT documentation, move Qt Creator instructions * Create dependencies.md, and link it from README & build docs * Merge #12803: Make BaseSignatureCreator a pure interface * [CMAKE] Add missing -DMAC_OSX definition * Update timing.json * Bump version to 0.20.1 * [CMAKE] Add the -commit suffix to version number through obj/build.h * Merge #12779: Qt: Remove unused method setupAmountWidget(...) * Cleanup reject_code in abc-schnorrmultisig-activation * Cleanup reject_code in abc-minimaldata-activation * docs: Update osx brew install instruction * remove brew c++ flag * Remove the tested versions from the OSX build guide * Add python3 to list of dependencies on some platforms * [doc] Minor corrections to osx dependencies * Merge #12714: Introduce interface for signing providers * Merge #12762: Make CKeyStore an interface * Merge #12752: [MOVEONLY] Move compressor utility functions out of class * Merge #12811: test: Make summary row bold-red if any test failed and show failed tests at end of table * Merge #12787: rpc: Adjust ifdef to avoid unreachable code * Migrated abc-replay-protection off of ComparisonTestFramework * Migrate abc-mempool-accept-txn.py off of ComparisonTestFramework * Migrate abc-invalid-chains off of the ComparisonTestFramework * Read more reject messages from debug logs in feature_cltv.py * Read more reject messages from debug logs in feature_dersig.py * Cleanup reject_code in feature_block.py * Merge #11200: Allow for aborting rescans in the GUI * Merge #12837: rpc: fix type mistmatch in `listreceivedbyaddress` * Merge #12650: gui: Fix issue: "default port not shown correctly in settings dialog" * Merge #11353: Small refactor of CCoinsViewCache::BatchWrite() * Merge #12621: Avoid querying unnecessary model data when filtering transactions ------------------------------------------------------------------- Thu Aug 22 16:37:57 UTC 2019 - marec@detebe.org - Update to version 0.20.0: * Update manpages for 0.20.0 release * Update chainparams * Cleanup reject_code in p2p_invalid_block.py * Cleanup reject_code in feature_csv_activation.py * recognize bare multisigs as standard only when using minimal pushes * Update seeds * Added some more release notes for 0.20.0 * [5 of 5] Style cleanup. * [4 of 5] scripted-diff: Rename CBlockDiskPos to FlatFilePos. * Bump automatic replay protection to May 2020 upgrade * Merge #11417: Correct typo in comments * make CheckMinimalPush available to codebase * Add upgrade features to release notes * Merge #13188: qa: Remove unused option --srcdir * qa: Read reject reasons from debug log, not p2p messages * Merge #14101: qa: Use named args in validation acceptance tests * [CMAKE] Fix typos in the secp256k1 CMakeLists.txt file * Merge #11422: qa: Verify DBWrapper iterators are taking snapshots * Merge #12436: [rpc] Adds a functional test to validate the transaction version number in the RPC output * Merge #14024: qa: Add TestNode::assert_debug_log * Merge #11842: [build] Add missing stuff to clean-local * Merge #12489: Bugfix: respect user defined configuration file (-conf) in QT settings * Merge #12996: tests: Remove redundant bytes(…) calls * Merge #11395: Qt: Enable searching by transaction id * Merge #11015: [Qt] Add delay before filtering transactions * [teamcity/gitian] Do not remove src tarball from results * Merge #10642: Remove obsolete _MSC_VER check * Merge #12447: test: Add missing signal.h header * Bump version to 0.20.0 * [CMAKE] Make secp256k1 build standalone * Fix missing plural form from commit reversal * Merge #9910: Docs: correct and elaborate -rpcbind doc * Merge #10085: Docs: remove 'noconnect' option * Merge #10036: Fix init README format to render correctly on github * Fix incorrect node being checked in segwit recovery test * Merge #11617: Avoid lock: Call FlushStateToDisk(...) regardless of fCheckForPruning * Merge #12969: Drop dead code CScript::Find * Merge #11573: [Util] Update tinyformat.h ------------------------------------------------------------------- Thu Aug 22 16:37:03 UTC 2019 - marec@detebe.org - Update to version 0.19.12: * Revert "macOS: Prevent Xcode 9.3 build warnings" * Revert "Bump version to 0.20.0" * [CMAKE] Avoid duplicating the compiler/linker flags * [CMAKE] Fix -Wunused-command-line-argument when adding linker flag * build: avoid getifaddrs when unavailable * build: Enable -Wredundant-decls where available * Bump version to 0.20.0 * Merge #12947: Wallet hd functional test speedup and clarification * Merge #12942: rpc: Drop redundant testing of signrawtransaction prevtxs args * Merge #13162: [net] Don't incorrectly log that REJECT messages are unknown. * Merge #13194: Remove template matching and pseudo opcodes * Updated manpages for 0.19.12 release * Update chainparams * Update seeds * Added some release notes for 0.19.12 release * Merge #12284: Remove assigned but never used local variables. Enable linter checking for unused local variables. * Merge #12569: net: Increase signal-to-noise ratio in debug.log by adjusting log level when logging failed non-manual connect():s * better error message for mandatory-flag tx rejections * Merge #12537: [arith_uint256] Make it safe to use "self" in operators * build: add missing leveldb defines * Fix leveldb compilation for NetBSD * Detect if char equals int8_t * Enforce clang-format version 7.x * Merge #12925: wallet: Logprint the start of a rescan * Merge #12918: test: Assert on correct variable * Merge #12797: init: Fix help message for checkblockindex * Fix some more copies in loops * Merge #12460: Assert CPubKey::ValidLength to the pubkey's header-relevant size * [CMAKE] Refactor the AddCompilerFlags facilities * Add -ftrapv to DEBUG_CXXFLAGS when --enable-debug is used * [CMAKE] Use plural form when multiple arguments are expected * [CMAKE] Avoid warning when checking flags * [CMAKE] Enable -Wthread-safety-analysis * [CMAKE] Refactor warnings for secp256k1 * Add a message to static_assert * [CI] Enable the undefined behaviour sanitizer * Merge #12128: Refactor: One CBaseChainParams should be enough * Merge #12225: Mempool cleanups * Merge #12118: Sort mempool by min(feerate, ancestor_feerate) * Merge #12780: Reduce variable scopes * Fix a copy in sigencoding_tests * Use a regex to determine the list of sources for check-rpc-mappings * Avoid copies in range-for loops and add a warning to detect them * scripted-diff: Avoid temporary copies when looping over std::map * macOS: Prevent Xcode 9.3 build warnings * [CMAKE] Improve link flag compiler support detection * [CMAKE] Fix OSX native build * Fix missing lock in denialofservice_tests * rpcauth: Improve by using argparse and getpass modules * Properly generate salt in rpcauth.py, update tests * rpcauth: Make it possible to provide a custom password * Tests: add usage note to check-rpc-mappings.py * Add linter: Make sure we explicitly open all text files using UTF-8 * tests/tools: Enable additional Python flake8 rules for automatic linting * [tests] simplify binary and hex response parsing in interface_rest.py * [tests] only use 2 nodes in interface_rest.py * [tests] refactor interface_rest.py to avoid code repetition * [tests] Make json request building more consistent in interface_rest.py * [tests] improve logging and documentation in interface_rest.py * [tests] fix flake8 warnings in interface_rest.py test * [REST] Handle UTXO retrieval when ignoring the mempool * [tests] Make rpcauth.py testable and add unit tests * Remove dead code in BasicTestingSetup * Use the existing config in CreateAndProcessBlock * Merge #10825: net: set regtest JSON-RPC port to 18443 to avoid conflict with testnet 18332 * Fix -Wthread-safety-analysis warnings * MINIMALDATA consensus activation * New Schnorr multisig activation * Implement new checkmultisig trigger logic and execution logic. * When build fails due to lib missing, indicate which one * build: split warnings out of CXXFLAGS * bench: Don't return a bool from main * test: Add rpcauth pair that generated by rpcauth * RPC: Introduce getblockstats to plot things * Refactor: RPC: Separate GetBlockChecked() from getblock() * Merge #11889: Drop extra script variable in ProduceSignature * Merge #11753: clarify abortrescan rpc use * Merge #12556: [Trivial] fix version typo in getpeerinfo RPC call help * Merge #10657: Utils: Improvements to ECDSA key-handling code * Merge #10682: Trivial: Move the AreInputsStandard documentation next to its implementation * Merge #11900: [script] simplify CheckMinimalPush checks, add safety assert * Merge #12693: Remove unused variable in SortForBlock * Add src/rpc/abc.cpp to the files checked by check-rpc-mappings * [LINTER] Integrate check-rpc-mappings to arcanist * Fix nits in blockchain.cpp RPC table * [tests] rename TestNode to TestP2PConn in tests * Merge #12431: Only call NotifyBlockTip when chainActive changes * Bump version to 0.19.12 * [CI] Enable debug for the ASAN build * qa: Avoid checking reject code for now * Fix undefined behavior in rcu_tests * Add phpcs to the code formatting tools in the CONTRIBUTING document ------------------------------------------------------------------- Fri Jul 26 15:46:32 UTC 2019 - marec@detebe.org - Update to version 0.19.11: * Updated seeds * Update manpages for 0.19.11 release * Update chainparams * Merge #12545: test: Use wait_until to ensure ping goes out * Make countBits available to the whole codebase * [CI] Run the functional tests when debug is enabled * Merge #12659: Improve Fatal LevelDB Log Messages * Add a facility to parse and validate script bitfields. * net: Add option `-enablebip61` to configure sending of BIP61 notifications * Fix bitcoin-cli --version * Format mm files * Make ScriptError a C++11 first class enum * Restrict CTransaction size assertion to x86 * Replace boost program_options * Move PHPCS config file where it is used * convert C-style (void) parameter lists to C++ style () * Add braces in script.h * Integrate the lint-boost-dependency.sh linter into arcanist * build: Guard against accidental introduction of new Boost dependencies * Fix phpcs warnings for unused function parameters * Don't replay the gitian initial setup at each build * Merge #8330: Structure Packing Optimizations in C{,Mutable}Transaction * Give an error and exit if there are unknown parameters * [teamcity/build] Fix a bug where CONFIGURE_FLAGS would not parse multiple flags correctly * Add circular dependencies script * Use a struct for arguments and nested map for categories * Pass WalletModel down to SendCoinsEntry by construct * Allow linters to run once * Use nullptr instead of 0 in various places in Qt code * Merge #11886: Clarify getbalance meaning a tiny bit in response to questions. * Merge #10777: [tests] Avoid redundant assignments. Remove unused variables * Remove inexistant parameter keypoolmin from integration test * Add license blurb to server_tests * test: Move linters to test/lint, add readme * Nits in Qt test * miliseconds => milliseconds * Migrate build configs from TeamCity to build-configurations.sh * Merge #11997: [tests] util_tests.cpp: actually check ignored args * Merge #11879: [tests] remove redundant univalue_tests.cpp * scripted-diff: Rename CChainState::g_failed_blocks to m_failed_blocks * Merge #11714: [tests] Test that mempool rejects coinbase transactions * Merge #11133: Document assumptions that are beoing made to avoid division by zero * [Part 5 of 5] Add a CChainState class to clarify internal interfaces * QA: Fix race condition in wallet_encryption test * [tests] [qt] Add tests for address book manipulation via EditAddressDialog * [wallet] [rpc] Add loadwallet RPC * [3 of 5] Move CDiskBlockPos from chain to flatfile. * [script_tests] improve test coverage of minimal push rules * [test_runner] Fix unidash option for junit output to be one character * [gitian-build] Fix repo directory to point at bitcoin-abc * [gitian-build] Bump default memory setting * [gitian-build] Default the number of jobs to the number of CPUs * [test_runner] Fix junitoutput typo * Fix a bug where the TeamCity build only reports one of the test_runner runs * Merge #11495: [trivial] Make namespace explicit for is_regular_file * Merge #10845: Remove unreachable code * Merge #10793: Changing &var[0] to var.data() * [script_tests] improve coverage of minimal number encoding * add SCRIPT_ENABLE_SCHNORR_MULTISIG flag for new multisig mode * [refactor multisig] remove redundant counters * [2 of 5] validation: Extract basic block file logic into FlatFileSeq class. * Error messages in LoadBlockIndexGuts() use __func__ instead of hardcoding function name. * [qt] Display more helpful message when adding a send address has failed * Add purpose arg to Wallet::getAddress * [tests] [qt] Introduce qt/test/util with a generalized ConfirmMessage * Merge #9544: [trivial] Add end of namespace comments. Improve consistency. * Merge #12298: Refactor HaveKeys to early return on false result * Add virtual transaction size to the transaction description in Qt * wallet: Change output type globals to members * Merge #11330: Trivial: Fix comments for DEFAULT_WHITELIST[FORCE]RELAY * Merge #11469: fix typo in comment of chain.cpp * [wallet] Add change type to CCoinControl * [wallet] use P2WPKH change output if any destination is P2WPKH or P2WSH * [qt] receive tab: bech32 address opt-in checkbox * Bech32 addresses in dumpwallet * fix backported comment placement * [refactor multisig] separate nullfail from stack cleanup * [refactor multisig] move nulldummy check to front * [refactor multisig] make const values up front * remove ComparisonTestFramework dependency from segwit recovery test * CONTRIBUTING.md - update instructions on linting dependencies * Use size_t for stack index in OP_MULTISIG * Merge #12988: Hold cs_main while calling UpdatedBlockTip() signal * Version number bumped to 0.19.11 ------------------------------------------------------------------- Sat Jul 13 10:52:23 UTC 2019 - marec@detebe.org - Update to version 0.19.10: * Update manpages for 0.19.10 release * Update chainparams * Enforce the use of TxId when constructing COutPoint * Update rpcwallet.cpp to use TxId * Factor out outpoint generation in transaction_tests.cpp * Use TxId in miner_tests.cpp * Update seeds for 0.19.10 release * [wallet] Pass error message back from CWallet::Verify() * Place sanitizers log into their own directory * Avoid std::locale/imbue in DateTimeStrFormat * [wallet] Add CWallet::Verify function * [wallet] setup wallet background flushing in WalletInit directly * Use txid in bloom tests * Wrap generation of randomized outpoint in tests * Remove criptolayer.net from seeder lists * outpt => output * use TxId properly in coincontroldialog * [wallet] Fix potential memory leak in CreateWalletFromFile * Rename wallet database classes * wallet: Initialize m_last_block_processed to nullptr. Initialize fields where defined. * Merge #10728: fix typo in help text for removeprunedfunds * wallet: Make vpwallets usage thread safe * Regenerate timing.json * Merge #14985: test: Remove thread_local from test_bitcoin * Rename wallet_accounts.py test * [qt] Add support to search the address book * [script_tests] add tests for pubkey encoding with strictenc + nullfail * [schnorr functional test] improve tx handling * [schnorr functional test] simplify funding logic * [schnorr functional test] change block setup logic * [schnorr functional test] remove ComparisonTestFramework dependency * Merge #10684: Remove no longer used mempool.exists(outpoint) * Merge #10581: Simplify return values of GetCoin/HaveCoin(InCache) * Merge #10685: Clarify CCoinsViewMemPool documentation. * Merge #14571: [tests] Test that nodes respond to getdata with notfound * Move CheckBlock() call to critical section * Merge #10191: [trivial] Rename unused RPC arguments 'dummy' * Update doc/release-process.md * Merge #10627: fixed listunspent rpc convert parameter * Fix scheduler test race due to BOOST_CHECK in multithreaded context * tests: Fix lock-order-inversion (potential deadlock) in DoS_tests. * Merge #13039: Add logging and error handling for file syncing * Optimize PNG images * [1 of 5] util: Move CheckDiskSpace to util. * Merge #10559: Change semantics of HaveCoinInCache to match HaveCoin * [script_tests] add small NUM2BIN case * Various nits in the wallet code * Implements a virtual destructor on the BaseRequestHandler class. * Add the sanitizers suppression files and use them in teamcity build * Fix checkqueue_tests use-after-scope * Merge #10626: doc: Remove outdated minrelaytxfee comment * Use functional tests timings from the source directory * [LINTER] Enforce source code file name conventions * doc: Make build system insert version in Doxyfile * Make various functions in src/test/ static * Merge #10347: Use range-based for loops (C++11) when looping over vector elements * Split off key_io_tests from base58_tests * Make printchunk() in support/lockedpool.cpp static * Merge #10530: Fix invalid instantiation and possibly unsafe accesses of array in class base_uint<BITS> * [LINTER] Add a linter to replace `unsigned char` with `uint8_t` * Move make check test logs out of tree * Partial backport of Core PR11167 to have similar feature in base58_tests.cpp * Merge #13145: Use common getPath method to create temp directory in tests. * Use cstdint in generated test headers * Merge #10248: Rewrite addrdb with less duplication using CHashVerifier * Merge #11737: Document partial validation in ConnectBlock() * Merge #11747: Fix: Open files read only if requested * whitespaces nits in CMakeLists * Split key_io (address/key encodings) off from base58 * Stop using CBase58Data for ext keys * Replace CBitcoinSecret with {Encode,Decode}Secret * tests: Remove compatibility code not needed now when we're on Python 3 * Change all python files to use Python3 * Rename rpcuser.py to rpcauth.py * Remove test for legacy address when parsing URL in the GUI * [coverage] Remove subtrees and benchmarks from coverage report * test: Check RPC argument mapping * Add share/rpcuser to dist. source code archive * Various nits in the Qt code * Remove EncodeDestination's overload relying on global state * Default to cashaddr in most of the Qt API * Only generate cashaddr URI from the GUI * docs: Add a note about the source code filename naming convention * Use CashAddr everywhere in the Qt interface * Take CChainParams explicitely in PaymentServer * Always use cashaddr for dummy addresses in the GUI * Only handle cashaddr prefix in OpenURIDialog * [teamcity/build.sh] Read CONFIGURE_FLAGS from environment * [ibd.sh] Store datadir and debug.log paths in variables * Fix memory access violation in tests * Fix memory leak in work_comparator_tests.cpp * Merge #10313: [Consensus] Add constant for maximum stack size * [rpc] fix verbose argument for getblock in bitcoin-cli * rpcuser.py: Use 'python' not 'python2' * [build] Warn that only libconsensus can be built without boost * [build] Don't fail when passed --disable-lcov and lcov isn't available * Use AC_ARG_VAR to set ARFLAGS. * Make CWallet IsSpent and IsLockedCoin take a COutPoint as parameter * [tests] fix flake8 nits in feature_csv_activation.py * [tests] Change feature_csv_activation.py to use BitcoinTestFramework * Move utility functions in feature_csv_activation.py out of class. * [tests] Remove nested loops from feature_csv_activation.py * [tests] improve logging in feature_csv_activation.py * fix mistake in test framework's schnorr signing module * Merge #12926: Run unit tests in parallel * Merge #12293: [rpc] Mention that HD is enabled if hdmasterkeyid is present * Activate cashaddr by default * qa: Fix python TypeError in script.py * Merge #11772: [tests] Change invalidblockrequest to use BitcoinTestFramework * RPC: Add child transactions to getrawmempool verbose output * [LINTER] Fix the python format string when dealing with arrays * [test] Round target fee to 8 decimals in assert_fee_amount * Merge #13003: qa: Add test for orphan handling * Merge #13048: [tests] Fix feature_block flakiness * Merge #11773: [tests] Change feature_block.py to use BitcoinTestFramework * Revert "Workaround to Travis-CI Wine/Mingw build hanging occasionally" * Backport base58 tests from PR11167 * Merge #12127: Remove unused mempool index * Merge #12424: Fix rescan test failure due to unset g_address_type, g_change_type * Merge #12150: Fix ListCoins test failure due to unset g_address_type, g_change_type * Merge #13163: Make it clear which functions that are intended to be translation unit local (bitcoin-cli.cpp) * Merge #13163: Make it clear which functions that are intended to be translation unit local (bitcoind.cpp) * Merge #13163: Make it clear which functions that are intended to be translation unit local (rpc/rawtransaction.cpp) * Merge #13163: Make it clear which functions that are intended to be translation unit local (init.cpp) * Prettify README title * Merge #13163: Make it clear which functions that are intended to be translation unit local (validation.cpp) * Merge #13163: Make it clear which functions that are intended to be translation unit local (wallet files) * Fix typos * qa: Move common args to bitcoin.conf * Fix 'mempool min fee not met' debug output * Merge #12861: [tests] Stop feature_block.py from blowing up memory. * Merge #10479: [trivial] Fix comment for ForceSetArg() * test: Make g_insecure_rand_ctx thread_local * Make unit tests use the insecure_rand_ctx exclusively * Handle various leftover from PR10321 * Various nits in the Qt code * Merge #11870: wallet: Remove unnecessary mempool lock in ReacceptWalletTransactions * Merge #11516: crypto: Add test cases covering the relevant HMAC-SHA{256,512} key length boundaries * Merge #14556: qt: fix confirmed transaction labeled "open" * Merge #14305: Tests: enforce critical class instance attributes in functional tests, fix segwit test specificity * Merge #11771: [tests] Change invalidtxrequest to use BitcoinTestFramework * Merge #9577: Fix docstrings in qa tests * Restore and backport missing changes from clientversion.h * Merge #10310: [doc] Add hint about getmempoolentry to getrawmempool help. * Merge #14554: qt: Remove unused `adjustedTime` parameter * Merge #13452: rpc: have verifytxoutproof check the number of txns in proof structure * Merge #11024: tests: Remove OldSetKeyFromPassphrase/OldEncrypt/OldDecrypt * wallet: Add HasWallets * qa: Prepare functional tests for Windows * Fix a-vs-an typos * wallet: Add AddWallet, RemoveWallet, GetWallet and GetWallets * wallet: Disallow abandon of conflicted txes * Fix a shadow warning in askpassphrasedialog.cpp * Add documentation on how to display python deprecation warnings * refactor: Drop CWalletRef typedef * Prevent mutex lock fail even if --enable-debug * qa: Initialize lockstack to prevent null pointer deref * Add braces in sync.{h|cpp} * Clamp walletpassphrase timeout to 2^(30) seconds and check its bounds * test: Fix dangling wallet pointer in vpwallets * Merge #13622: Remove mapRequest tracking that just effects Qt display. * Merge #11094: Docs: Hash in ZMQ hash is raw bytes, not hex * Merge #11083: Fix combinerawtransaction RPC help result section * Merge #11011: [Trivial] Add a comment on the use of prevector in script. * Merge #10912: [tests] Fix incorrect memory_cleanse(…) call in crypto_tests.cpp * Merge #10655: Properly document target_confirmations in listsinceblock * Add unit tests for signals generated by ProcessNewBlock() * Fix concurrency-related bugs in ActivateBestChain * [LINTER] Enforce flake8 W605 warning * Merge #11635: trivial: Fix typo – alreardy → already * Merge #11480: [ui] Add toggle for unblinding password fields * Enable flake8 warnings for all currently non-violated rules * qa: Add missing syncwithvalidationinterfacequeue to tests * qa: Make TestNodeCLI command optional in send_cli * qa: Rename cli.args to cli.options * test_runner: Readable output if create_cache.py fails * Fix a typo in functional tests documentation * Trivial: Fix spelling in zapwallettxes test description * Merge #10765: Tests: address placement should be deterministic by default * Merge #11210: Stop test_bitcoin-qt touching ~/.bitcoin * Bump version to 0.19.10 * add new encoding checker for Schnorr sigs * [sigencoding] refactor schnorr size check * Do not unlock cs_main in ABC unless we've actually made progress. * Do not permit copying FastRandomContexts * Simplify testing RNG code * Use a local FastRandomContext in a few more places in net * Use a FastRandomContext in LimitOrphanTxSize * Introduce a Shuffle for FastRandomContext and use it in wallet and coinselection * Bugfix: randbytes should seed when needed (non reachable issue) * Make addrman use its local RNG exclusively ------------------------------------------------------------------- Sat Jun 29 11:47:14 UTC 2019 - marec@detebe.org - Update to version 0.19.9: * Merge #10587: Net: Fix resource leak in ReadBinaryFile(...) * Merge #10408, #13291, and partial #13163 * Update manpages for 0.19.9 release * Update chainparams for 0.19.9 release * Update seeds for 0.19.9 release * [RPC] Adding ::minRelayTxFee amount to getmempoolinfo and updating help * Fix currency/fee-rate unit string in the help text * getmempool mempoolminfee is a BCH/kB feerate * Revert "add flags to VerifySignature and sigcache" * remove SCRIPT_ENABLE_SCHNORR flag and clean up tests * clean up script_tests -- move segwit recovery into static json * Merge #12287: Optimise lock behaviour for GuessVerificationProgress() * Merge #10789: Punctuation/grammer fixes in rpcwallet.cpp * Fix incorrect Markdown link * Diagnose unsuitable outputs in lockunspent(). * rename schnorr functional test (rename-only) * shuffle selected coins before transaction finalization * Fix string concatenation to os.path.join and add exception case * [rpc] mempoolinfo should take ::minRelayTxFee into account * Don't attempt mempool entry for wallet tx on start if already in mempool * [tests] Combine logs on failure * Fix the timestamp format when -logtimemicros is set * [Trivial] BTC => BCH in functional tests comments * Fix exit in generate_header.py and some formatting nits * bench: Make CoinSelection output groups pass eligibility filter * Remove unused .travis.yml file * Fix struct vs class mismatch for Amount * Reject headers building on invalid chains by tracking invalidity * wallet: shuffle coins before grouping, where warranted * Make FastRandomContext support standard C++11 RNG interface * wallet: sum ancestors rather than taking max in output groups * [CMAKE] Build checkblock benchmark * sigencoding_tests: improve test coverage * Remove unused great wall activation code * remove effect of SCRIPT_ENABLE_SCHNORR flag * Remove Schnorr activation * Backport last relevant bit of #11389 * Update importprivkey named args documentation * Improve signmessages functional test * Add getmininginfo functional test * Merge #9750: Bloomfilter: parameter variables made constant * Merge #10432: [Trivial] Add BITCOIN_FS_H endif footer in fs.h * doc: Add release notes for -avoidpartialspends * test: Add basic testing for wallet groups * wallet: Remove deprecated OutputEligibleForSpending * clean-up: Remove no longer used ivars from CInputCoin * wallet: Switch to using output groups instead of coins in coin selection * Add -avoidpartialspends and m_avoid_partial_spends * wallet: Add output grouping * Fix inconsistencies and grammar in various files * fix BIP37 processing for non-topologically ordered blocks * unsigned int -> size_t in merkleblock-related code * Remove unknown version warning from UpdateTip * Merge #13726: Utils and libraries: Removes the boost/algorithm/string/join dependency * Merge #10744: Use method name via __func__ macro * [Trivial] Docs: Capitalize bullet points * Trivial: spelling fixes * Merge #10380: [doc] Removing comments about dirty entries on txmempool * Replumb ibd.sh to prepare for better post-IBD checks * Merge #12250: Make CKey::Load references const * Fix mining_prioritisetransaction * fix linting bug in script.py * Speedup coinselector_tests by using a dummy WalletDBWrapper when apropriate * Actually disable BnB when there are preset inputs * Fix Clang Static Analyzer warnings * wallet: Make fee settings non-static members * wallet: Add input bytes to CInputCoin * moveonly: CoinElegibilityFilter into coinselection.h * utils: Add insert() convenience templates * add gdb attach process to doc/functional-tests.md * qa: Warn when specified test is not found * Use a unique index for the running jobs in case of duplicated names * [LINTER] Prevent including a source file * [consensus] Pin P2SH activation to block 173805 on mainnet * Merge #8498: Near-Bugfix: Optimization: Minimize the number of times it is checked that no money... * Merge #10196: Bugfix: PrioritiseTransaction updates the mempool tx counter * Merge #10228: build: regenerate bitcoin-config.h as necessary * Remove unecessary include of boost/version * Merge #10162: [trivial] Log calls to getblocktemplate * Merge #10088: Trivial: move several relay options into the relay help group * Merge #11237: qt: Fixing division by zero in time remaining * De-witnessing some comments * Merge #12392: Fix ignoring tx data requests when fPauseSend is set on a peer * Merge #10151: [logging] initialize flag variable to 0 (and continue if GetLogCategory() fails) * Merge #11284: Fix invalid memory access in CScript::operator+= (guidovranken, ajtowns) * [rpc] deprecate ancient softforks' information from getblockchaininfo * Merge #10376: [tests] fix disconnect_ban intermittency * Merge #10999: Fix amounts formatting in `decoderawtransaction` * [refactor] Make TransactionWithinChainLimit more flexible * clarify GetBlockScriptFlags * Clarify include guard naming convention * Improve comment in top-level CMakeLists * Restore CWallet::minTxFee * bench: Simplify CoinSelection * Add a test to make sure that negative effective values are filtered * Have SelectCoinsMinConf and SelectCoins use BnB or Knapsack and use it * tests: Avoid copies of CTransaction * Use mempool's descendent count in the wallet code * Restore minRelayTxFee * Implement getRequiredFee in the node interface and use it * Merge #12652: bitcoin-cli: Provide a better error message when bitcoind is not running * Merge #10577: Add an explanation of quickly hashing onto a non-power of two range. * Cleanup ibd.sh * Dead code removal * [LINTER] Set the rules for the phpdoc comments * Add benchmark for AES * Merge #14085: index: Fix for indexers skipping genesis block. * Fix lock reference in miner.h * Merge #14409: utils and libraries: Make 'blocksdir' always net specific * create net-specific data directory early in init process * [LINTER] Enforce using angle brackets in #include directives * Make CMutableTransaction constructor explicit * bitcoin-tx: Remove unused for loop * Remove redundant code in MutateTxSign(CMutableTransaction&, const std::string&) * Kill MAX_FREE_TRANSACTION_CREATE_SIZE * [txindex] transaction Hash -> TxId * Explicitly call out updating makeseeds.py after major releases * Directly use CMutableTransaction more often in txvaidationcache_tests.cpp * mempool: Fix missing locking in CTxMemPool::check(…) and CTxMemPool::setSanityCheck(…) * Take a CTransaction as argument for ValidateCheckInputsForAllFlags * Avoid creating transaction copies in script_tests.cpp and multisig_tests.cpp * Use MakeTransactionRef in serialize_tests.cpp * Update mempool eviction benchmark * Make m_coinbase_txns a vector of CTransactionRef * coinbaseTxns => m_coinbase_txns * Relayout comments in validation.cpp * Make float <-> int casts explicit outside of test, qt, CFeeRate * Bump version to 0.19.9 * Merge #9949: [bench] Avoid function call arguments which are pointers to uninitialized values ------------------------------------------------------------------- Fri Jun 14 12:10:09 UTC 2019 - marec@detebe.org - Update to version 0.19.8: * Add missing release notes for 0.19.8 release * Update manpages for 0.19.8 release * Update seeds for 0.19.8 release * Updated chainparams for 0.19.8 release * Move original knapsack solver tests to coinselector_tests.cpp * Move current coin selection algorithm to coinselection.{cpp,h} * Benchmark BnB in the worst case where it exhausts * Add tests for the Branch and Bound algorithm * Calculate and store the number of bytes required to spend an input * Remove coinselection.h -> wallet.h circular dependency * Implement Branch and Bound coin selection in a new file * Fix eligibilty_filter => eligibility_filter * Build wallet dependent benchmark using cmake * Fix braces in multisig_test * Fix comments in miner.h * fix `test_runner.py --help` * Remove unused DoWarning function * Merge #15471: rpc/gui: Remove 'Unknown block versions being mined' warning * Use a struct for output eligibility * Store effective value, fee, and long term fee in CInputCoin * Move output eligibility to a separate function * Add a GetMinimumFeeRate function which is wrapped by GetMinimumFee * Fix rounding errors in calculation of minimum change size * Don't create change at the dust limit, even if it means paying more than expected * Eliminate fee overpaying edge case when subtracting fee from recipients * [LINTER] Move phpcs ruleset to a test/lint/phpcs directory * [LINTER] Fix some PHP linter rules * Fix make distcheck * Merge #9350: [Trivial] Adding label for amount inside of tx_valid/tx_invalid.json * Merge #10090: Update bitcoin.conf with example for pruning * Merge #10177: Changed "Send" button default status from true to false * Merge #10404: doc: Add logging to FinalizeNode() * Merge #10460: Broadcast address every day, not 9 hours * Merge #10536: Remove unreachable or otherwise redundant code * [tests] Better stderr testing * qa: Normalize executable location * Avoid unintentional unsigned integer wraparounds in tests * [tests] Use FastRandomContext instead of boost::random::* * Don't assert(...) with side effects * [LINTER] Add a spell checker to arcanist * Add script tests with valid 64-byte ECDSA signatures. * utils: run commands using utf-8 string on Windows * Merge #10560: Remove unused constants * Merge #10524: [tests] Remove printf(...) * Update timing.json Segwit Recovery functional test name * [qa] util: Remove unused sync_chain * Merge #10568: Remove unnecessary forward class declarations in header files * Merge #9909: tests: Add FindEarliestAtLeast test for edge cases * Merge #10522: [wallet] Remove unused variables * Merge #11198: [Qt] Fix display of package name on 'open config file' tooltip * Merge #9890: Add a button to open the config file in a text editor * Cleanup remaining boost includes * Merge #13877: utils: Make fs::path::string() always return utf-8 string on Windows * Merge #12904: [qa] Ensure bitcoind processes are cleaned up when tests end * Merge #10514: Bugfix: missing == 0 after randrange * Merge #10500: Avoid CWalletTx copies in GetAddressBalances and GetAddressGroupings * Merge #10469: Fixing typo in rpcdump.cpp * Rework the wallet fees interface to make it closer to core's * Merge #9977: QA: getblocktemplate_longpoll.py should always use >0 fee tx * Merge #10911: [qt] Fix typo and access key in optionsdialog.ui * remove four duplicate tests from script_tests.json * Merge #10679: Document the non-DER-conformance of one test in tx_valid.json. * Merge #11435: build: Make "make clean" remove all files created when running "make check" * Merge #12877: doc: Use bitcoind in Tor documentation * Merge #11620: [build] .gitignore: add background.tiff * Merge #11380: Remove outdated share/certs/ directory * Merge #12843: [tests] Test starting bitcoind with -h and -version * Merge #10961: Improve readability of DecodeBase58Check(...) * Merge #10464: Introduce static DoWarning (simplify UpdateTip) * Avoid spurious boost output in scheduler_tests * Merge #11710: cli: Reject arguments to -getinfo * Fix a bunch of spelling errors * Remove unused function for fees.h exposed interface * Clean up Segwit Recovery feature * Merge #11884: Remove unused include in hash.cpp * Merge #12434: [doc] dev-notes: Members should be initialized * Merge #12501: [qt] Improved "custom fee" explanation in tooltip * Merge #12584: Fix typos and cleanup documentation * Merge #12999: qt: Show the Window when double clicking the taskbar icon * Merge #13052: trivial: Fix relevent typo * Merge #12616: Set modal overlay hide button as default * Merge #12384: [Docs] Add version footnote to tor.md * Merge #10714: Avoid printing incorrect block indexing time due to uninitialized variable * Replace childs => children in radix.h * [LINTER] Enforce using C++ headers instead of C compatible headers * Replace c compatibility header with native c++ header * Merge #11406: Add state message print to AcceptBlock failure message. * Remove useless priority calculation in wallet * Use constexpr in the RCU code * Merge #11683: tests: Remove unused mininode functions {ser,deser}_int_vector(...). Remove unused imports. * Merge #11655: net: Assert state.m_chain_sync.m_work_header in ConsiderEviction * Remove implicit parameter from GetSerializeSize * Merge #11864: Make CWallet::FundTransaction atomic * [wallet] Tidy up CWallet::FundTransaction * Merge #11337: Fix code constness in CBlockIndex::GetAncestor() overloads * Remove BIP9 from chain parameters * Fix Gitian instructions to setup LXC container networking on Debian * Move WalletRescanner to match Bitcoin Core codebase * Remove billable size from CTransaction * Remove billable size from the mempool * Do not update billable size in descendents * Do not update billable size in ancestors * Remove billable size from mining * Limit variable scope * Merge #9533: Allow non-power-of-2 signature cache sizes * Merge #10278: [test] Add Unit Test for GetListenPort * Reintroduce the concept of virtual size from core * Deprecate parts of validateaddress and introduce getaddressinfo * Merge #12198: rpc: Add deprecation error for `getinfo` * Merge #12333: Make CWallet::ListCoins atomic * Improve ZMQ functional test * Remove redundant pwallet nullptr check * Add missing locks and locking annotations for CAddrMan * [rpc] Move DescribeAddressVisitor to rpc/util * [rpc] split wallet and non-wallet parts of DescribeAddressVisitor * (finally) remove getinfo in favor of more module-specific infos * [mining] Add a test for TestCBlockTemplateEntry * Bump version number to 0.19.8 * Fix wallet RPC race by waiting for callbacks in sendrawtransaction * Also call other wallet notify callbacks in scheduler thread * Merge #14374: qt: Add "Blocksdir" to Debug window * Add tests to SingleThreadedSchedulerClient() and document the memory model * Various improvements to the scheduler * scheduler: Add Clang thread safety annotations for variables guarded by m_cs_callbacks_pending * unsigned char => uint8_t * [nit] do not capture unused `this` in wallet interface ------------------------------------------------------------------- Sat Jun 01 09:10:44 UTC 2019 - marec@detebe.org - Update to version 0.19.7: * Update seeds for 0.19.7 release * Merge #13985: [trivial] Fix slightly confusing mispelling in feature_blocksdir.py log message * Update manpages for the 0.19.7 release * Update chainparams for 0.19.7 release * Reoder various argument declarations * Remove SCRIPT_VERIFY_CHECKDATASIG_SIGOPS flag from Schnorr test * Add post-upgrade testnet checkpoint * [Tests] Require exact match in assert_start_raises_init_eror() * Give ZMQ consistent order with UpdatedBlockTip on scheduler thread * Don't use the functional test arguments in the tmp directory name * wallet: Display non-HD error on first run * Merge #10056: [zmq] Call va_end() on va_start()ed args. * Backport current GetDifficulty logic (& tests) from Core * remove chain.h dependency from txdb.h * Create new wallet databases as directories rather than files * Remove SCRIPT_VERIFY_CHECKDATASIG_SIGOPS flag from script tests * index: Move index DBs into index/ directory. * MOVEONLY: Move BaseIndex to its own file. * index: Generalize logged statements in BaseIndex. * index: Extract logic from TxIndex into reusable base class. * db: Make reusable base class for index databases. * Allow wallet files not in -walletdir directory * Support downgrading after recovered keypool witness keys * SegWit wallet support * [CMAKE] Fix Miniupnpc error message * Remove IsSolvable * Simplify "bool x = y ? true : false". Remove unused function and trailing semicolon. * Extend validateaddress information for P2SH-embedded witness * Allow wallet files in multiple directories * Bump wallet version to 190700 and remove the `usehd` option * [CMAKE] Add support for Miniupnpc * Implicitly know about P2WPKH redeemscripts * Use GetKeyForDestination in various RPCs * Merge #13396: Drop unused arith_uint256 ! operator * Add comments indicating "Schnorr" in Schnorr-related script tests. * qa: Use node.datadir instead of tmpdir in test framework * Don't create another wallet db directory in walletdb_tests * Rename SCRIPT_ENABLE_CHECKDATASIG to SCRIPT_VERIFY_CHECKDATASIG_SIGOPS. * Fixed multiple typos * Merge #14513: Avoid 1 << 31 (UB) in calculation of SEQUENCE_LOCKTIME_DISABLE_FLAG * Merge #14510: Avoid triggering undefined behaviour in base_uint<BITS>::bits() * Update prevector * Merge #13894: shutdown: Stop threads before resetting ptrs * Expose method to find key for a single-key destination * Abstract out IsSolvable from Witnessifier * Merge #10308: [wallet] Securely erase potentially sensitive keys/values * Merge #10341: rpc/wallet: Workaround older UniValue which returns a std::string temporary for get_str * [script] Unit tests for IsMine * [script] Unit tests for script/standard functions * Fix code style in keystore.cpp/crypter.cpp * Remove the virtual specifier for functions with the override specifier * db: Remove obsolete methods from CBlockTreeDB. * Set InitMessage for txindex migration * [txindex] Activate new transaction index code that runs in background * Merge #11468: [tests] Make comp test framework more debuggable * Comments: More comments on functions/globals in standard.h. * [CMAKE] Avoid displaying the console when launching bitcoin-qt.exe * [CMAKE] Add cross compiling support for ARM32 and ARM64 * [CMAKE] Add cross build toolchain files for PC Linux platform * [CMAKE] Disable OpenGL in Qt static build for OSX * [CMAKE] Add QT plugins according to the target platform * [refactor] GetAccount{PubKey,Address} -> GetAccountDestination * Merge #12425: Add some script tests * Merge #12468: Add missing newline in init.cpp log message * [qa] don't pad transactions during make_conform_to_ctor * Add a test to ensure memory isn't consumed for blocks pre-checkpoint * [rpc] Add initialblockdownload to getblockchaininfo * Interpret scripts with CHECKDATASIG opcode always valid. * tests: move pwalletMain to wallet test fixture * Merge #12151: rpc: Remove cs_main lock from blockToJSON and blockheaderToJSON * Merge #13527: policy: Remove promiscuousmempoolflags * Merge #11742: rpc: Add testmempoolaccept * Refactor walletdb_tests to use the wallet test fixture * Fix for mismatched extern definition in wallet test * Fix uninitialized atomic variables * [CMAKE] Move-only: refactor qt/CMakeLists.txt * Remove BIP9 dead code in util.py * Add CHECKDATASIG to standard flags. * re-fix feature_cltv.py * Remove AcceptToMemoryPoolWithTime default args * Merge #11872: [rpc] createrawtransaction: Accept sorted outputs * Merge #10503: Use REJECT_DUPLICATE for already known and conflicted txn * [tests] bind functional test nodes to 127.0.0.1 * Avoid calling add_nodes multiple times in functional tests * qa: Cache only chain and wallet for regtest datadir * [qa] Delete cookie file before starting node * Remove sleep in feature_config_args * Consensus: Minimal way to move dust out of consensus * Make tests independent of whether CHECKDATASIG is included in mandatory or standard flags * Merge #13522: [tests] Fix p2p_sendheaders race * Merge #13350: [tests] Add logging to provide anchor points when debugging p2p_sendheaders * Merge #13192: [tests] Fixed intermittent failure in p2p_sendheaders.py. * Merge #12849: Tests: Add logging in loops in p2p_sendhears.py * Merge #11707: [tests] Fix sendheaders * Merge #14364: doc: Clarify -blocksdir usage * New -includeconf argument for including external configuration files * Fix undefined behavior in avalanche.cpp * Simplify semantics of ChainStateFlushed callback * scripted-diff: Rename SetBestChain callback ChainStateFlushed * [index] Create new TxIndex class. * Remove config argument from blockToJSON * Merge #10095: refactor: Move GetDifficulty out of `rpc/server.h` * Consensus: Minimal way to move dust out of consensus * Merge #12564: [arith_uint256] Avoid unnecessary this-copy using prefix operator * Merge #12182: Remove useless string initializations * Merge #11877: Improve createrawtransaction functional tests * Merge #12278: Add special error for genesis coinbase to getrawtransaction * [CMAKE] Add support for libqrencode * [CI] Run functional tests both pre and post graviton * [CMAKE] Add an option to enable the glibc compatibility features * [CMAKE] Add missing files to build bitcoin-qt on OSX * [CMAKE] Fix bitcoind cross build for OSX * [CMAKE] Cleanup the OSX platform file * Use angle brackets in windows resource files * Separate version info into bitcoin-version.h from bitcoin-config.h * [tests] Remove unused variables * Make release-process.md IBD instruction more precise * Clarify comment for SCRIPT_ENABLE_CHECKDATASIG * Remove redundant items from STANDARD_SCRIPT_VERIFY_FLAGS * Have gArgs handle printing help * [docs] Reformat -help output for help2man * Fix braces in warnings.cpp * Bump version number to 0.19.7 * wallet: Refactor g_wallet_init_interface to const reference * wallet: Make WalletInitInterface members const * Move RPC registration out of AppInitParameterInteraction * Fix D2181 by including DumpRPC * [CMAKE] Allow to use sanitizers with cmake * [CMAKE] Fix missing protobuf include directory * Fix more init bugs. * Fix boost::thread::interruption_point causing build failure on Windows * Count checkdatasig for transaction entering the mempool ------------------------------------------------------------------- Wed May 15 19:44:32 UTC 2019 - marec@detebe.org - Update to version 0.19.6: * Update man pages for v0.19.6 * Update chainparams for 0.19.6 release * Merge #11385: Remove some unused functions and methods * Remove useless include of boost thread * Merge #9833: Trivial: fix comments referencing AppInit2 * Merge #10280: [test] Unit test amount.h/amount.cpp * Merge #9980: Fix mem access violation merkleblock * Update disclosure policy standards * Added missing release notes * [rpc] Move tojson.h into blockchain.h * Updated seed list for 0.19.6 release * update release notes * Merge #9804: Fixes subscript 0 (&var[0]) where should use (var.data()) instead. * [tests] Remove unused and duplicate imports * [CMAKE] Fix the prl conversion script library path issue * Merge #10045: [trivial] Fix typos in comments * build: Remove -I for everything but project root * [tests] remove txdb.h dependency from test_bitcoin.h * Merge #11351: Refactor: Modernize disallowed copy constructors/assignment * Merge #11155: Trivial: Documentation fixes for CVectorWriter ctors * Merge #12415: Interrupt loading thread after shutdown request * [CMAKE] Fix the prl conversion script linking against lib_NOTFOUND * [CMAKE] Determine the Qt library directory from a public variable * [CMAKE] Add an option to statically link libstdc++ * [CMAKE] Add an option to reduce exports * [backport PR12653] Allow to optional specify the directory for the blocks storage * Merge #10115: Avoid reading the old hd master key during wallet encryption * Merge #10258: Fixed typo in documentation for merkleblock.h * Revert "Merge #10126: Compensate for memory peak at flush time" * Merge #10126: Compensate for memory peak at flush time * refactor: Include obj/build.h instead of build.h * Merge #11281: Avoid permanent cs_main/cs_wallet lock during RescanFromTime * Merge #10489: build: silence gcc7's implicit fallthrough warning * Merge #10154: init: Remove redundant logging code * Merge #10128: Speed Up CuckooCache tests * Merge #12842: Prevent concurrent savemempool * Merge #11599: scripted-diff: Small locking rename * Merge #10351: removed unused code in INV message * Merge #10180: [trivial] Fix typos (tempoarily → temporarily, inadvertantly → inadvertently) * Merge #11578: net: Add missing lock in ProcessHeadersMessage(...) * Merge #10309: Trivial: remove extra character from comment * Merge #9794: Minor update to qrencode package builder * Support serialization as another type without casting * Support deserializing into temporaries * Merge READWRITEMANY into READWRITE * [mining] Rename several CBlockTemplateEntry members for clarity * Merge #9333: Document CWalletTx::mapValue entries and remove erase of nonexistent "version" entry. * Merge #9724: Qt/Intro: Add explanation of IBD process * Merge #9916: Fix msvc compiler error C4146 (minus operator applied to unsigned type) * Merge #13080: mempool: Add compile time checking for ::mempool.cs runtime locking assertions * Make functions in rpc/blockchain.cpp static. * Merge #9906: Disallow copy constructor CReserveKeys * Merge #9555: [test] Avoid reading a potentially uninitialized variable in tx_invalid-test (transaction_tests.cpp) * Merge #14511: doc: Remove explicit storage requirement from README.md * Merge #9962: [trivial] Fix typo in rpc/protocol.h * Merge #9960: Trivial: Add const modifier to GetHDChain and IsHDEnabled * Merge #10033: Trivial: Fix typo in key.h comment * Merge #9690: Change 'Clear' button string to 'Reset' * Merge #9952: Add historical release notes for 0.14.0 * Merge #12172: Bugfix: RPC: savemempool: Don't save until LoadMempool() is finished * Merge #11099: [RPC][mempool]: Add savemempool RPC * Merge #10265: [wallet] [moveonly] Check non-null pindex before potentially referencing * Merge #12681: Fix ComputeTimeSmart test failure with -DDEBUG_LOCKORDER * Merge #11744: net: Add missing locks in net.{cpp,h} * Revert removal of code block * Merge #12206: qa: Sync with validationinterface queue in sync_mempools * test: refactor: Use absolute include paths for test data files * qt: refactor: Changes to make include paths absolute * qt: refactor: Use absolute include paths in .ui files * Merge #12283: Fix typos * Sanitize some wallet serialization * No need to use OpenSSL malloc/free * Merge #9539: [net] Avoid initialization to a value that is never read * [trivial] Fix recently introduced typos in comments * Merge #12326: net: initialize socket to avoid closing random fd's * Merge #11252: [P2P] When clearing addrman clear mapInfo and mapAddr. * Merge #12448: Interrupt block generation on shutdown request * Merge #11585: addrman: Add missing lock in Clear() (CAddrMan) * Merge #10914: Add missing lock in CScheduler::AreThreadsServicingQueue() * Merge #11831: Always return true if AppInitMain got to the end * Merge #10057: [init] Deduplicated sigaction() boilerplate * Init: Remove redundant exit(EXIT_FAILURE) instances and replace with return false * Ignore macOS daemon() depracation warning * [LINTER] Revive the locale dependent functions linter in arcanist * Merge #9693: Prevent integer overflow in ReadVarInt. * Backport dev notes on RPC * blockfilter: Use unordered_set instead of set in blockfilter. * Disallow using addresses in createmultisig * Merge #10027: Set to nullptr after delete * Merge #10029: Fix parameter naming inconsistencies between .h and .cpp files * Merge #12349: shutdown: fix crash on shutdown with reindex-chainstate * Merge #12367: Fix two fast-shutdown bugs * Merge #11238: Add assertions before potential null deferences * Add developer notes about blocking GUI code and src/interfaces/README.md * Incremented version number to 0.19.6. * test: Plug memory leaks and stack-use-after-scope * Fix a memory leak in DoS_tests * [CMAKE] Make RelWithDebInfo the default CMake configuration * [db] Migration for txindex data to new, separate database. * [db] Create separate database for txindex. * Add additional unit tests for segwit recovery * fix out-of-bounds memory write in key_tests * blockfilter: Remove sharp edge (uninitialized m_filter_type) when using the compiler-generated constructor for BlockFilter * blockfilter: Refactor and add tests for BlockFilter construction * blockfilter: add block filters * Remove obsolete comment from MANDATORY_SCRIPT_VERIFICATION_FLAGS * Use angle bracket in include for qt tests * Use angle bracket in include for remaining qt files * Use angle bracket in include for qt pages, widgets and views * Use angle bracket in include for qt model files * Use angle bracket in include for qt dialog files * Use angle bracket in include for qt/bitcoin* files * Fix typos. ------------------------------------------------------------------- Sat May 04 17:18:29 UTC 2019 - marec@detebe.org - Update to version 0.19.5: * Added some notes for the 0.19.5 release * Updated mainnet seeds for 0.19.5 release * Merge #10569: Fix stopatheight * Updated manpages for 0.19.5 release * Update chainparams for 0.19.5 release * Merge #11880: Stop special-casing phashBlock handling in validation for TBV * Use WalletBalances struct in Qt * Remove direct bitcoin calls from qt/sendcoinsdialog.cpp * Do not allow users to get keys from keypool without reserving them * nits in lcg_tests * Merge #9517: [refactor] Switched httpserver.cpp to use RAII wrapped libevents. * [LINTER] Remove the lint-format-strings.sh script * [LINTER] Move the string formatting function list to the python script * Remove direct bitcoin access from qt/guiutil.cpp * Remove direct bitcoin calls from qt transaction table files * Remove direct bitcoin calls from qt/paymentserver.cpp * [CI] Make gitian builds run on multiple cpus * Merge #11012: Make sure to clean up mapBlockSource if we've already seen the block * Remove direct bitcoin calls from qt/addresstablemodel.cpp * [LINTER] Improve lint-format-strings.sh performance * Remove direct bitcoin calls from qt/coincontroldialog.cpp * Remove most direct bitcoin calls from qt/walletmodel.cpp * Remove direct bitcoin calls from qt/optionsdialog.cpp * Add function 'IsGravitonEnabled' * serialize: Serialization support for big-endian 32-bit ints. * [DOC] Add headers inclusion guidelines to the developer notes * Use angle bracket in include for wallet test * [qt] Simplifies boolean expression model && model->haveWatchOnly() * [qt] Avoid potential null pointer dereference in TransactionView::exportClicked() * Use angle bracket in include for seeder * Use angle bracket in include for wallet * [nit] Remove redundant parameter from `CTxMemPool::PrioritiseTransaction` * Remove direct bitcoin calls from qt/rpcconsole.cpp * Remove direct bitcoin calls from qt/bantablemodel.cpp * Remove direct bitcoin calls from qt/peertablemodel.cpp * Remove direct bitcoin calls from qt/intro.cpp * Remove direct bitcoin calls from qt/clientmodel.cpp * Remove direct bitcoin calls from qt/splashscreen.cpp * [qa] [nit] remove extranous variable in mining_prioritisetransaction.py * Extract CSipHasher to it's own file in crypto/ directory. * Use angle bracket in include for src (part 6) * Use angle bracket in include for src (part 5) * Use angle bracket in include for src (part 4) * Use angle bracket in include for src (part 3) * Use angle bracket in include for src (part 2) * Use angle bracket in include for src (part 1) * Use angle bracket in include for test (part 5) * Bump version number to 0.19.5 ------------------------------------------------------------------- Thu Apr 25 19:48:00 UTC 2019 - marec@detebe.org - Update to version 0.19.4: * Added missing notes to release notes * Use angle bracket in include for zmq * Use angle bracket in include for test (part 4) * Nits in abc-high_priority_transaction.py * [schnorr] Refactor the signature process in reusable component * Use angle bracket in rpcwallet and rpcdump * Use angle bracket in include for test (part 3) * build: Move interfaces/* to libbitcoin_server * Use angle bracket in include for tests (part 2) * Use angle bracket in include for tests (part 1) * Use angle bracket in include for support * Use angle bracket in include for script * Use angle bracket in include for rpc * Remove direct bitcoin calls from qt/utilitydialog.cpp * Use angle bracket in include for primitives * Use angle bracket in include for policy * Use angle bracket in include for crypto * Use angle bracket in include for consensus * Use angle bracket in include for compat * Use angle bracket in include for bench * Move interface -> interfaces * Add Sent and Received information to the debug menu peer list * Update seeds * Updated manpages for 0.19.4 release * Updated chainparams for 0.19.4 release * Remove the boost/algorithm/string/case_conv.hpp dependency * scripted-diff: Replace NET_TOR with NET_ONION * Log warning message when deprecated network name 'tor' is used (e.g. option onlynet=tor) * Remove Safe mode * Use angle bracket in include for net and netbase * Remove direct bitcoin calls from qt/bitcoingui.cpp * Remove direct bitcoin calls from qt/optionsmodel.cpp * Remove direct bitcoin calls from qt/bitcoin.cpp * Merge #12630: Provide useful error message if datadir is not writable. * Merge #12422: util: Make LockDirectory thread-safe, consistent * Merge #11904: Add a lock to the wallet directory * blockfilter: add GCSFilter class * streams: Implement BitStreamReader/Writer classes. * streams: Create VectorReader stream interface for vectors. * [wallet] Close DB on error. * Replace C compatibility headers by their C++ equivalent * [CMAKE] Move .h files transformed from .ui to the form subdirectory * GUI: Receive: Remove option to reuse a previous address * Merge #11041: Add LookupBlockIndex * Update release notes for 0.19.3 to include instructions for re-enabling deprecated signrawtransaction * [secp256k1] add schnorr sign jni binding * Revert "[LINTER] Integrate lint-locale-dependence.sh into arcanist" * [LINTER] Enforce custom coding standard for PHP files * Merge #11838: qa: Add getrawtransaction in_active_chain=False test * Add additional test in segwit recovery activation * Add functional tests for rejecting headers that build on invalid chains * Merge #10368: [wallet] Remove helper conversion operator from wallet * Remove much of the remaining BIP9 code * rpc: Handle `getinfo` locally in bitcoin-cli w/ `-getinfo` * Fix increment in rpc/mining.cpp when coinbase tx is skipped * Migrate MakeUnique to c++14 std::make_unique * Use c++14 generic std::rbegin() and std::rend() instead of class methods * [secp256k1] refactor nativeECDSABuffer to a more generic name * [Part 4 of 5] Add a CChainState class to clarify internal interfaces * Remove unused depends list from `getblocktemplate` transactions * Remove unused parameter `validFeeEstimates` from `CTxMempool::addUnchecked` * Fix comment in CheckInputs to match changed code * Merge #10493: Use range-based for loops (C++11) when looping over map elements * doc: update FreeBSD build guide for 12.0 * FreeBSD: Document Python 3 requirement for 'gmake check' * doc: split FreeBSD build instructions out of build-unix.md * Drop support for OpenBSD * Make c++14 standard the default for compilation * Fix signrawtransaction failing when a wallet URI is specified * [CI] Add an option to build and run unit tests with debug enabled * Remove communication style article from CONTRIBUTING.md * Add dev articles to CONTRIBUTING.md * Merge #10858: [RPC] Add "warnings" field to getblockchaininfo and unify "warnings" field in get*info RPCs * Incremented version number, moved and renamed old release-notes.d, and added new release-notes.md ------------------------------------------------------------------- Sat Apr 06 12:14:17 UTC 2019 - marec@detebe.org - Update to version 0.19.3: * Fix Windows build errors introduced in D2765 * Format the php files * qa: Improve getchaintxstats functional test * Update manpages for 0.19.3 release * Update chainparams for 0.19.3 release * Update seeds. * Document method for reviewers to verify chainTxData * Add tip to the create Debian VM instructions * [Target v0.19] Deprecate and add test for signrawtransaction * Update wallet_listsinceblock.py to use signrawtransactionwithwallet rpc * Add missing step in Debian VM creation process * Update Debian VM version link to latest * Add schnorr verify benchmark * Add schnorr sign benchmark * Use static_cast instead of C-style casts for non-fundamental types * Merge #10275: [rpc] Allow fetching tx directly from specified block in getrawtransaction * Backport remaining changes from Core PR 10742 * Bump version numbers to 0.19.3 * Lint everything * Fix arc liberate complaining about concatenation in constant definition * [LINTER] Escape the % char in the description of PythonFormatLinter * Fix comment about s in schnorr sigs * [Part 3 of 5] Add a CChainState class to clarify internal interfaces * [LINTER] Enforce a minimum version for autopep8 * [CI] Improve performance when running the tests * Improve teamcity agent setup documentation and service script * Adjusted indentation in getblockchaininfo's help text to properly align. * remove unused fnoncriticalerrors variable from cwalletdb::findwallettx * Merge #10858: [RPC] Add "warnings" field to getblockchaininfo and unify "warnings" field in get*info RPCs * [secp256k1] add schnorr verify jni binding * Allow setting an env variable to skip tests in build.sh * [Part 2 of 5] Add a CChainState class to clarify internal interfaces * [LINTER] Integrate lint-locale-dependence.sh into arcanist * Fix a potential segfault in the seeder * Remove nonnull warning when calling secp256k1_schnorr_sign with NULL noncefp * Fix unlocked_until in getwalletinfo rpc ------------------------------------------------------------------- Tue Mar 26 18:53:57 UTC 2019 - marec@detebe.org - Update to version 0.19.2: * Update seeds * [secp256k1] remove unused byte array * Fix seeder in the gitian build * Avoid slow transaction search with txindex enabled * [secp256k1] remove guava dep * Added better error reporting for running individual functional tests * Update manpages * Update chainparams for 0.19.2 release * [LINTER] Display the line number in the lint-locale-dependence.sh linter * Merge #11028: Avoid masking of difficulty adjustment errors by checkpoints * Add some release notes * Merge #8665: Assert all the things! * [secp256k1] fix java secp256k1 test * Remove unused seeder/compat.h * Added build-secp256k1.sh for running secp tests in TeamCity * Allow for running secp256k1 java build/tests out of tree * Fix braces in qt/clientmodel.cpp * Backport VerifyResult enum class * Backport FlushStateMode enum class * Backport ThresholdState enum class * Backport HelpMessageMode enum class * Backport BlockSource enum class * Backport RetFormat enum class * Merge #11027: [RPC] Only return hex field once in getrawtransaction * Merge #11565: Make listsinceblock refuse unknown block hash * refactor: remove usage of locale dependent std::isspace * [LINTER] build: Add linter for checking accidental locale dependence * [CMAKE] Harden the executables * Fix braces in utilstrencodings * Fix braces in netbase.cpp * [CMAKE] Add DEBUG and DEBUG_LOCKORDER definitions to the Debug config * test: Replace remaining sprintf with snprintf * [LINTER] Fix check doc incompatibility with BSD grep * [LINTER] Improve check-doc regex * Pass SendCoinsRecipient (208 bytes) by const reference * Remove redundant locks * Merge #12327: [gui] Defer coin control instancing * Merge #11039: Avoid second mapWallet lookup * Merge #9622: [rpc] listsinceblock should include lost transactions when parameter is a reorg'd block * Merge #10775: nCheckDepth chain height fix * Bump version to 0.19.2 * Merge #10783: [RPC] Various rpc argument fixes * Merge #11618: rpc: Lock cs_main in blockToJSON/blockheaderToJSON * [CMAKE] Use static linkage when cross compiling for windows * [CMAKE] Override the flags for the Debug CMake configuration * [CMAKE] Add an option to enable/disable hardening * [CMAKE] Check for linker flag support * [CMAKE] Fix cached variable that prevents testing for flag support * Fix feerate coin control * Cleanup unused RPCServer references in qt/bitcoin.cpp * Merge #11809: gui: Fix proxy setting options dialog crash * [wallet] Get rid of CWalletTx default constructor * [wallet] Construct CWalletTx objects in CommitTransaction * Merge #10706: Improve wallet fee logic and fix GUI bugs * Wallet: Refactor FundTransaction to accept parameters via CCoinControl * Partial backport of Core PR9681 to add CWallet::SignTransaction ------------------------------------------------------------------- Sun Mar 10 08:39:17 UTC 2019 - marec <marec@detebe.org> - Update to version 0.19.1: * Update seeds. * Limit the number of orphan considered per node. * Cleanup remaining instances of txconfirmtarget * Remove unused struct in fees.h * Update manpages for 0.19.1 release * Add braces in netaddress.{h|cpp} * Update chainparams for 0.19.1 release * Add minor note to release notes for 0.19.1 release * Deprecate nblocks from estimatefee RPC * Cleanup unused confirm target in GetMinimumFee() ------------------------------------------------------------------- Tue Feb 19 20:21:10 UTC 2019 - marec@detebe.org - Update to version 0.19.0: * Update seeds * Add a test for signrawtransaction with various sighashes parameters * Make --enable-debug to pick better options * Remove contrib/devtools/clang-format-diff.py * Update contrib/seeds scripts to use the new .format() method * Update contrib/linearize scripts to use the new .format() method * Fix feature_dbcrash failure * Update rpc_* functional tests to use the new .format() method * Update p2p_* functional tests to use the new .format() method * Update interface_* functional tests to use the new .format() method ------------------------------------------------------------------- Tue Feb 12 18:53:22 UTC 2019 - marec@detebe.org - Update to version 0.18.8: * Revert "Merge #10712: Add change output if necessary to reduce excess fee" * Update manpages for 0.18.8 * Added release note regarding hex field in tx JSON from getblock * Ban nodes providing an invalid checksum in a message header * script_tests signature function renames to add "ECDSA" * Move replay protection mempool management in ConnectTip * Update chain parameters for 0.18.8 * Fix formatting in release-process.md * clean up CheckInputs() policy-ban logic and comments * Merge #10712: Add change output if necessary to reduce excess fee ------------------------------------------------------------------- Tue Jan 29 14:16:41 UTC 2019 - marec@detebe.org - Update to version 0.18.7: * tests: Fix test_runner return value in case of skipped test * Add remaining items to release notes * Update chainparams for 0.18.7 * [Qt] replace fee slider with a Dropdown, extend conf. targets * Update man pages for v0.18.7 * Don't allow relative -walletdir paths * Allow multiwallet.py to be used with --usecli * [tests] allow tests to be run with --usecli * TestNodeCLI batch emulation * Prevent TestNodeCLI.args mixups ------------------------------------------------------------------- Fri Jan 11 19:28:06 UTC 2019 - marec@detebe.org - Update to version 0.18.6: * Update manpages for 0.18.6 * Update seeds * wallet: Refactor to WalletInitInterface* const g_wallet_init_interface * wallet: Make WalletInitInterface and DummyWalletInit private * Move SEND_CONFIRM_DELAY to sendcoinsdialog.h * Update chainparams for 0.18.6 release * contrib: Add support for out-of-tree builds in gen-manpages.sh * Move scheduler/threadGroup into common-init instead of per-app * Add CWallet::BlockUntilSyncedToCurrentChain() * Add CallFunctionInQueue to wait on validation interface queue drain ------------------------------------------------------------------- Wed Nov 21 18:07:27 UTC 2018 - marec@detebe.org - Update to version 0.18.5: * Add test case and release notes for auto finalization * Auto-finalize block once they reached a certain depth (by default 10) * Add an RPC to finalize a block * Do not unpark children of blocks outside of the RPC * Reconsider parked chains when enough works piles up * Fix block construction in abc-p2p-compactblocks.py * revert changes to abc-p2p-compactblock.py * [qa] fix abc-p2p-compactblocks to be compatible with magnetic anomaly upgrade * Cleanup redundant function in abc-p2p-compactblocks * Removed unused update_block from abc-p2p-compactblocks ------------------------------------------------------------------- Fri Nov 16 15:39:42 UTC 2018 - marec@detebe.org - Update to version 0.18.4: * Add a checkpoint for the fork block * Fix warnings about shadowing introduced in D2047 * [mining] Ensure sigops and fees follow transactions during sorting * [cleanup] De-globalize rpc configuration variables * Update README.md * Fix comment in util.py * [macOS] Remove DS_Store WindowBounds bytes object * Disable wallet and address book Qt tests on macOS minimal platform * Fix a bug with duplicate logging * Fix functional test --help raising an exception ------------------------------------------------------------------- Fri Nov 9 19:34:04 UTC 2018 - marec@detebe.org - Update to version 0.18.3: * Correct addrman logging * Fix missing argument in requestedInitialize signal for bitcoin-qt * Run checkdatasig_tests on a larger set of flags * [ci] Add IBD parameters for CI. * Add missing include in rwcollection.h * Update man page for 0.18.3 * Added responsible discloure policy * Update chainparams for release * Fix up release note on parked chain RPC * Add RWCollection, a read-write locked collection with a mostly safe API ------------------------------------------------------------------- Tue Sep 18 19:06:41 UTC 2018 - marec@detebe.org - Update to version 0.18.2: * Added 0.18.2 release notes * Connect to a new outbound peer if our tip is stale * Backport all changes related to checkqueue.h and its test from Core * Include boost/thread.hpp in validation.cpp * [Wallet] Add RPC call "rescanblockchain <startheight> <stopheight>" * Address nits from per-utxo change * Refactor duplicate input check * Changed CMessageHeader::pchCommand to use a C++11 array and updated its various uses to reflect this. * Fix bench/bench_bitcoin (Select REGTEST Params before wallet init) * Disconnect outbound peers relaying invalid headers ------------------------------------------------------------------- Tue Aug 28 07:26:59 UTC 2018 - marec@detebe.org - Update to version 0.18.1: * Add 0.18.1 release notes * [qa] fix flaky abc-magnetic-anomaly-activation.py * Create a header for TxId and TxHash * Various nits in transactiontablemodel.{h|cpp} * Use C++11 style loops in DisconnectedBlockTransactions::updateMempoolForReorg * increment version to 0.18.1 * Use TxId in AbandonTransaction * Use TxId in wallet's GetConflicts methods * Use TxId for the AddToSpends family of function * Use Txid in CWallet::GetWalletTx ------------------------------------------------------------------- Mon Aug 27 11:30:22 UTC 2018 - marec@detebe.org - Update to version 0.18.0: * Use a single round of SHA256 ont he CHECKDATASIG message. * Make max tx input script sig size 1650 a constant. * Add cleanstack check when activating magnetic anomaly * Hash the input of OP_CHECKDATASIG instead of expecting the user to do it. * [qa] make create_confirmed_utxos calculate fees * Update defaultAssumeValid and minimumChainWork. * [qa] move and rename mine_large_block from util to blocktools * [qa] add cashaddr module, and fix send_big_transactions * Update DNS seeds * [qa] Fix assertions in fundrawtransaction ------------------------------------------------------------------- Mon May 28 19:30:57 UTC 2018 - marec@detebe.org - Update to version 0.17.2: * Update chainparams for release 0.17.2 * Add test case for boundary conditions for div and mod. * Get rid of BlockStatusEnum * Use BlockStatus's modifier function to update status's value. * Use BlockStatus's accessors instead of masking. * Add failure flags handling to BlockStatus * [qa] Add a fee calculation helper for CTransaction * Use C++11 style loop in InvalidateBlock * Add braces around various control flows in validation.cpp * Add test vector for larger cashaddr ------------------------------------------------------------------- Sat Apr 28 07:37:32 UTC 2018 - marec@detebe.org - Update to version 0.17.1: * Prepare release notes, and minimum space required, for 0.17.1 * Update man pages * Update chainparams * Fix vagrant box, for gitian builds, provisioning script * Fix a couple of nits in miner.cpp * Add bench_multiset to gitignore * Update builtin seeds for node boostrap * Update devtool notes to reference the correct copyright notice. * [cmake] Check if boost::test require static or dynamic linking and act accordingly * Refactor sighash type test to go through every value possible in a transaction's signature. ------------------------------------------------------------------- Sun Apr 8 09:37:56 UTC 2018 - marec@detebe.org - Update to version 0.17.0: * Add fallback install build for libdmg and cdrkit * Fix ninja package namefor OSX reproducible build * Add note about incrementing cmake version to release process docs. * Fix bitcoin-abc website link in README.md * Update version for cmake as well. * Add note about cmake to release-notes.md * Update release files for 0.17.0 * Ban node using the wrong magic. * Update chain parameters to reflect the current state of the blockchain * Update bootstrap seeds ------------------------------------------------------------------- Tue Dec 26 17:10:49 UTC 2017 - marec@detebe.org - Update to version 0.16.2: * [Qt] Build linguist/lrelease instead of the whole linguist package * [gitian] add gperf to the gitian build * Update fontconfig dependancy * Correct `open source` to `open-source` in README.md * Properly check for builtin * [cmake] Move the option on top of src/CMakeLists.txt * Change the path cmake search for binaries in to include the custom built depends. * Detect if EVP_MD_CTX_new is supported by OpenSSL * Fix ZeroMQ build on windows using cmake/ninja * Make "maximum length of incoming protocol messages" comment match the code ------------------------------------------------------------------- Mon Nov 13 18:01:52 UTC 2017 - marec@detebe.org - Update to version 0.16.1: * Update defaultAssumeValid for 0.16.1 * Update seeds * Update version number * Convert rpcwallet.h/rpcwallet.cpp to use Amount class * Convert CWallet to use Amount class * Convert CAccountingEntry to use Amount class * Split the decoding of cashaddr in a pure decode step + a Destination creation step * Convert CMerkleTx to use Amount class * run ./gen-manpages.sh to automatically create help infomation * Delete the language resources of RBF in BCC because BCC does not support RBF ------------------------------------------------------------------- Tue Oct 31 14:23:03 UTC 2017 - marec@detebe.org - Update to version 0.16.0: * Update version in gitian descriptors * Update version for 0.16.0 release * Add activation code for the new DAA. * Implement simple moving average over work difficulty adjustement algorithm. * Convert validation.cpp/.h to use Amount class * Fix sporadic policyestimator_tests failure due to unspecified operand evaluation order * Refactor GetDifficulty from RPC * Use standard prefix in cashaddr tests * Enforce LOW_S after Nov, 13 * Add cashaddr prefix to chainparams ------------------------------------------------------------------- Sat Oct 14 16:23:26 UTC 2017 - marec@detebe.org - Update to version 0.15.1: * Reenable the gitian build for window 32 bits * Fix the gitian build for windows artifacts * Add multiarch support for xenial * Add several symbol in the whitelist for exported symbols. * Various nits in the cashaddr code * Update gitian descriptor to use xenial instead of trusty * Cashaddr decoding the raw data and checksum * Convert script package to use Amount struct (T104) * Fix compile errors in Amount caused by ambiguous instantation * Convert txmempool.cpp and txmempool.h to use Amount struct ------------------------------------------------------------------- Thu Sep 7 16:41:57 UTC 2017 - marec@detebe.org - Update to version 0.15.0: * Update release notes for 0.15.0 * Use uint32_t in script flag test utility * Deduplicate SignatureCacheHasher * Various nits in the signature cache machinery * Always use the parallel check codepath for block validation * Add a test for GetCacheSize in coins_tests.cpp * Move the CCoins abstraction in txdb.cpp * Store the UTXO set on a per output basis rather than a per transaction basis * Add estimate size to dbwrapper * Return on disk and DB independent size for the utxo set ------------------------------------------------------------------- Sat Jul 29 08:11:50 UTC 2017 - marec@detebe.org - initial package build
Locations
Projects
Search
Status Monitor
Help
OpenBuildService.org
Documentation
API Documentation
Code of Conduct
Contact
Support
@OBShq
Terms
openSUSE Build Service is sponsored by
The Open Build Service is an
openSUSE project
.
Sign Up
Log In
Places
Places
All Projects
Status Monitor
