File 0007-Revert-Fix-FormService-spec-after-merging-... of Package openproject

Overview Repositories Revisions Requests Users Attributes Meta

File 0007-Revert-Fix-FormService-spec-after-merging-from-relea.patch of Package openproject

From 4b25d9b33b1c970395c353510bd22f3fb870de18 Mon Sep 17 00:00:00 2001
From: Matthew Trescott <matthewtrescott@gmail.com>
Date: Sat, 24 Jul 2021 19:02:23 -0400
Subject: [PATCH 7/8] Revert "Fix FormService spec after merging from
 release/11.3"

This reverts commit a257edb8725d02322458ef29f49a991985e85b00.
---
 .../dynamic-form/dynamic-form.service.spec.ts | 30 ++++++++++++++-----
 1 file changed, 23 insertions(+), 7 deletions(-)

diff --git a/frontend/src/app/modules/common/dynamic-forms/services/dynamic-form/dynamic-form.service.spec.ts b/frontend/src/app/modules/common/dynamic-forms/services/dynamic-form/dynamic-form.service.spec.ts
index d896f01870..4d22d48fca 100644
--- a/frontend/src/app/modules/common/dynamic-forms/services/dynamic-form/dynamic-form.service.spec.ts
+++ b/frontend/src/app/modules/common/dynamic-forms/services/dynamic-form/dynamic-form.service.spec.ts
@@ -11,7 +11,7 @@ describe('DynamicFormService', () => {
   let httpClient:HttpClient;
   let httpTestingController:HttpTestingController;
   let dynamicFormService:DynamicFormService;
-  let formsService:FormsService;
+  let formsService:jasmine.SpyObj<FormsService>;
   const testFormUrl = 'http://op.com/form';
   const formSchema = {
     "_type": "Form",
@@ -105,10 +105,12 @@ describe('DynamicFormService', () => {
     ],
     "model": {
       "name": "Project 1",
-      "parent": {
-        "href": "/api/v3/projects/26",
-        "title": "Parent project",
-        "name": "Parent project"
+      "_links": {
+        "parent": {
+          "href": "/api/v3/projects/26",
+          "title": "Parent project",
+          "name": "Parent project"
+        }
       },
       "_meta": undefined
     },
@@ -116,6 +118,8 @@ describe('DynamicFormService', () => {
   };
 
   beforeEach(() => {
+    const formServiceSpy = jasmine.createSpyObj('FormsService', ['submit$']);
+
     TestBed.configureTestingModule({
       imports: [
         HttpClientTestingModule,
@@ -123,13 +127,13 @@ describe('DynamicFormService', () => {
       providers: [
         DynamicFormService,
         DynamicFieldsService,
-        FormsService,
+        { provide: FormsService, useValue: formServiceSpy }
       ]
     });
     httpClient = TestBed.inject(HttpClient);
     httpTestingController = TestBed.inject(HttpTestingController);
     dynamicFormService = TestBed.inject(DynamicFormService);
-    formsService = TestBed.inject(FormsService);
+    formsService = TestBed.inject(FormsService) as jasmine.SpyObj<FormsService>;
   });
 
   it('should be created', () => {
@@ -154,4 +158,16 @@ describe('DynamicFormService', () => {
     req.flush(formSchema);
     httpTestingController.verify();
   });
+
+  it('should submit the dynamic form value', () => {
+    const dynamicForm = dynamicFormConfig.form;
+
+    formsService.submit$.and.returnValue(of('ok response'));
+
+    dynamicFormService
+      .submit$(dynamicForm, testFormUrl)
+      .subscribe();
+
+    expect(formsService.submit$).toHaveBeenCalledWith(dynamicForm, testFormUrl, undefined, undefined, undefined);
+  });
 });
-- 
2.32.0

Places

File 0007-Revert-Fix-FormService-spec-after-merging-from-relea.patch of Package openproject

Places