File 0001-ndctl-monitor-use-type-simple-instead-of-t... of Package ndctl

Overview Repositories Revisions Requests Users Attributes Meta

File 0001-ndctl-monitor-use-type-simple-instead-of-type-forkin.patch of Package ndctl (Revision 0072b6e0f9a909465619c537fe406e45)

Currently displaying revision 0072b6e0f9a909465619c537fe406e45 , Show latest

From cfdd874353e2798000dc1f9ebd99882c4d373c08 Mon Sep 17 00:00:00 2001
From: Johannes Thumshirn <jthumshirn@suse.de>
Date: Mon, 7 Jan 2019 16:45:31 +0100
Subject: [PATCH] ndctl, monitor: use type=simple instead of type=forking
Patch-mainline: Submitted, Tue 8 Jan 10:15:41
References: bsc#1120931

There is no need to use Type=forking for 'ndctl monitor', Type=simple is
sufficient.

When we use Type=forking and try to run ndctl monitor on a machine without
pmem we even get the following error in the journal:

Jan 07 13:34:54 bragi systemd[1]: Starting Ndctl Monitor Daemon...
Jan 07 13:34:54 bragi ndctl[13776]: custom logging function 0x55ea57d60250 registered
Jan 07 13:34:54 bragi systemd[1]: Started Ndctl Monitor Daemon.
Jan 07 13:34:54 bragi ndctl[13777]: ndctl monitor daemon started
Jan 07 13:34:54 bragi kill[13778]: kill: cannot find process ""
Jan 07 13:34:54 bragi systemd[1]: ndctl-monitor.service: Control process exited, code=exited status=1
Jan 07 13:34:54 bragi systemd[1]: ndctl-monitor.service: Unit entered failed state.
Jan 07 13:34:54 bragi systemd[1]: ndctl-monitor.service: Failed with result 'exit-code'.

This is because the daemon exits and systemd is not able to determine
$MAINPID anymore.

Signed-off-by: Johannes Thumshirn <jthumshirn@suse.de>
---
 ndctl/ndctl-monitor.service | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/ndctl/ndctl-monitor.service b/ndctl/ndctl-monitor.service
index 342a1b1972d5..eeedbd30bb42 100644
--- a/ndctl/ndctl-monitor.service
+++ b/ndctl/ndctl-monitor.service
@@ -2,9 +2,8 @@
 Description=Ndctl Monitor Daemon
 
 [Service]
-Type=forking
-ExecStart=/usr/bin/ndctl monitor --daemon
-ExecStop=/bin/kill ${MAINPID}
+Type=simple
+ExecStart=/usr/bin/ndctl monitor
 
 [Install]
 WantedBy=multi-user.target
-- 
2.16.4

Places

File 0001-ndctl-monitor-use-type-simple-instead-of-type-forkin.patch of Package ndctl (Revision 0072b6e0f9a909465619c537fe406e45)

Places