File 005-session-vnc-Plug-leak-in-error-path.patch of Package virt-viewer

Overview Repositories Revisions Requests Users Attributes Meta

File 005-session-vnc-Plug-leak-in-error-path.patch of Package virt-viewer

Subject: session-vnc: Plug leak in error path
From: Eduardo Lima (Etrunko) etrunko@redhat.com Wed May 3 12:28:19 2023 -0300
Date: Wed May 3 12:41:02 2023 -0300:
Git: b2a50c1fe1297a9fdfefe2b4a318abf2b8000a0b

Reported in rhbz#2019858

Signed-off-by: Eduardo Lima (Etrunko) <etrunko@redhat.com>

diff --git a/src/virt-viewer-session-vnc.c b/src/virt-viewer-session-vnc.c
index 69f8ef1..6281bd0 100644
--- a/src/virt-viewer-session-vnc.c
+++ b/src/virt-viewer-session-vnc.c
@@ -302,11 +302,11 @@ virt_viewer_session_vnc_open_uri(VirtViewerSession* session,
         g_return_val_if_fail(virt_viewer_file_is_set(file, "port"), FALSE);
         g_return_val_if_fail(virt_viewer_file_is_set(file, "host"), FALSE);
 
-        portstr = g_strdup_printf("%d", virt_viewer_file_get_port(file));
-        hoststr = g_strdup(virt_viewer_file_get_host(file));
-
         if (!virt_viewer_file_fill_app(file, app, error))
             return FALSE;
+
+        portstr = g_strdup_printf("%d", virt_viewer_file_get_port(file));
+        hoststr = g_strdup(virt_viewer_file_get_host(file));
     } else {
         xmlURIPtr uri = NULL;
         if (!(uri = xmlParseURI(uristr)))

Places

File 005-session-vnc-Plug-leak-in-error-path.patch of Package virt-viewer

Places