File ipxe.1c47eb186e7e38bde2a1db528cc3557b1b300386.p... of Package xen

Overview Repositories Revisions Requests Users Attributes Meta

File ipxe.1c47eb186e7e38bde2a1db528cc3557b1b300386.patch of Package xen (Revision 9fed2f7da32a9367296ebe7dda7cc4c6)

Currently displaying revision 9fed2f7da32a9367296ebe7dda7cc4c6 , Show latest

From: Michael Brown <mcb30@ipxe.org>
Date: Sun, 8 Jul 2018 18:12:43 +0100
Subject: 1c47eb186e7e38bde2a1db528cc3557b1b300386

[build] Use positive-form tests when checking for supported warnings

Some versions of gcc seem to silently accept an attempt to disable an
unrecognised warning (e.g. via -Wno-stringop-truncation) but will then
report the unrecognised warning if any other error occurs during the
build, resulting in a potentially misleading error message.

Avoid this potential confusion by using the positive-form tests in
order to determine the workaround CFLAGS.

Signed-off-by: Michael Brown <mcb30@ipxe.org>
---
 src/Makefile.housekeeping | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

--- a/src/Makefile.housekeeping
+++ b/src/Makefile.housekeeping
@@ -165,32 +165,32 @@ CFI_TEST = $(CC) -fno-dwarf2-cfi-asm -fno-exceptions -fno-unwind-tables \
 		 -fno-asynchronous-unwind-tables -x c -c /dev/null \
 		 -o /dev/null >/dev/null 2>&1
 CFI_FLAGS := $(shell $(CFI_TEST) && \
 	       $(ECHO) '-fno-dwarf2-cfi-asm -fno-exceptions ' \
 		       '-fno-unwind-tables -fno-asynchronous-unwind-tables')
 WORKAROUND_CFLAGS += $(CFI_FLAGS)
 endif
 
 # gcc 4.6 generates spurious warnings if -Waddress is in force.
 # Inhibit this.
 #
 ifeq ($(CCTYPE),gcc)
-WNA_TEST = $(CC) -Wno-address -x c -c /dev/null -o /dev/null >/dev/null 2>&1
+WNA_TEST = $(CC) -Waddress -x c -c /dev/null -o /dev/null >/dev/null 2>&1
 WNA_FLAGS := $(shell $(WNA_TEST) && $(ECHO) '-Wno-address')
 WORKAROUND_CFLAGS += $(WNA_FLAGS)
 
 # gcc 8.0 generates warnings for certain suspect string operations. Our
 # sources have been vetted for correct usage.  Turn off these warnings.
 #
-WNST_TEST = $(CC) -Wno-stringop-truncation -x c -c /dev/null -o /dev/null \
+WNST_TEST = $(CC) -Wstringop-truncation -x c -c /dev/null -o /dev/null \
 		  >/dev/null 2>&1
 WNST_FLAGS := $(shell $(WNST_TEST) && $(ECHO) '-Wno-stringop-truncation')
 WORKAROUND_CFLAGS += $(WNST_FLAGS)
 endif
 
 # Some versions of gas choke on division operators, treating them as
 # comment markers.  Specifying --divide will work around this problem,
 # but isn't available on older gas versions.
 #
 DIVIDE_TEST = $(AS) --divide /dev/null -o /dev/null 2>/dev/null
 DIVIDE_FLAGS := $(shell $(DIVIDE_TEST) && $(ECHO) '--divide')
 WORKAROUND_ASFLAGS += $(DIVIDE_FLAGS)

Places

File ipxe.1c47eb186e7e38bde2a1db528cc3557b1b300386.patch of Package xen (Revision 9fed2f7da32a9367296ebe7dda7cc4c6)

Places