File ipxe.76338543f9e48833e7c634d947a7ae278f38aef9.p... of Package xen

Overview Repositories Revisions Requests Users Attributes Meta

File ipxe.76338543f9e48833e7c634d947a7ae278f38aef9.patch of Package xen (Revision 1b049f727c9e7d4aec4eb434d870b455)

Currently displaying revision 1b049f727c9e7d4aec4eb434d870b455 , Show latest

From: Michael Brown <mcb30@ipxe.org>
Date: Tue, 28 Jul 2015 14:11:35 +0100
Subject: 76338543f9e48833e7c634d947a7ae278f38aef9

[iscsi] Add missing "break" statements

iscsi_tx_done() is missing "break" statements at the end of each case.
(Fortunately, this happens not to cause a bug in practice, since
iscsi_login_request_done() is effectively a no-op when completing a
data-out PDU.)

Reported-by: Wissam Shoukair <wissams@mellanox.com>
Signed-off-by: Michael Brown <mcb30@ipxe.org>
---
 src/net/tcp/iscsi.c | 2 ++
 1 file changed, 2 insertions(+)

--- a/src/net/tcp/iscsi.c
+++ b/src/net/tcp/iscsi.c
@@ -1445,26 +1445,28 @@ static int iscsi_tx_data_padding ( struct iscsi_session *iscsi ) {
  * machine is about to enter the idle state.  iscsi::tx_bhs will be
  * valid for the just-completed PDU when this is called.
  */
 static void iscsi_tx_done ( struct iscsi_session *iscsi ) {
 	struct iscsi_bhs_common *common = &iscsi->tx_bhs.common;
 
 	/* Stop transmission process */
 	iscsi_tx_pause ( iscsi );
 
 	switch ( common->opcode & ISCSI_OPCODE_MASK ) {
 	case ISCSI_OPCODE_DATA_OUT:
 		iscsi_data_out_done ( iscsi );
+		break;
 	case ISCSI_OPCODE_LOGIN_REQUEST:
 		iscsi_login_request_done ( iscsi );
+		break;
 	default:
 		/* No action */
 		break;
 	}
 }
 
 /**
  * Transmit iSCSI PDU
  *
  * @v iscsi		iSCSI session
  * @v buf		Temporary data buffer
  * @v len		Length of temporary data buffer

Places

File ipxe.76338543f9e48833e7c634d947a7ae278f38aef9.patch of Package xen (Revision 1b049f727c9e7d4aec4eb434d870b455)

Places