File ipxe.8ed4e3049f5fcb3a0b32f5190940e78c61654cff.p... of Package xen

Overview Repositories Revisions Requests Users Attributes Meta

File ipxe.8ed4e3049f5fcb3a0b32f5190940e78c61654cff.patch of Package xen (Revision 9c85a36e5d114c8038b820a72e545168)

Currently displaying revision 9c85a36e5d114c8038b820a72e545168 , Show latest

From: Bruce Rogers <brogers@suse.com>
Date: Tue, 24 Apr 2018 08:47:32 -0600
Subject: 8ed4e3049f5fcb3a0b32f5190940e78c61654cff

[build] Disable gcc stringop-truncation warnings

The gcc 8 compiler introduces a warning for certain string
manipulation functions, flagging usages which _may_ not be intended.
An audit of the iPXE sources indicates all usages of strncat and
strncpy are as intended, so the warnings currently issued are not
helpful, especially if warnings are considered errors.

Fix by detecting gcc's support for -Wno-stringop-truncation and, if
detected, using that option to avoid the warning.

Signed-off-by: Bruce Rogers <brogers@suse.com>
Modified-by: Michael Brown <mcb30@ipxe.org>
Also-fixed-by: Christian Hesse <list@eworm.de>
Also-fixed-by: Roman Kagan <rkagan@virtuozzo.com>
Also-fixed-by: Bernhard M. Wiedemann <bwiedemann@suse.de>
Also-fixed-by: Olaf Hering <olaf@aepfle.de>
Signed-off-by: Michael Brown <mcb30@ipxe.org>
---
 src/Makefile.housekeeping | 10 +++++++++-
 1 file changed, 9 insertions(+), 1 deletion(-)

--- a/src/Makefile.housekeeping
+++ b/src/Makefile.housekeeping
@@ -168,24 +168,32 @@ CFI_FLAGS := $(shell $(CFI_TEST) && \
 	       $(ECHO) '-fno-dwarf2-cfi-asm -fno-exceptions ' \
 		       '-fno-unwind-tables -fno-asynchronous-unwind-tables')
 WORKAROUND_CFLAGS += $(CFI_FLAGS)
 endif
 
 # gcc 4.6 generates spurious warnings if -Waddress is in force.
 # Inhibit this.
 #
 ifeq ($(CCTYPE),gcc)
 WNA_TEST = $(CC) -Wno-address -x c -c /dev/null -o /dev/null >/dev/null 2>&1
 WNA_FLAGS := $(shell $(WNA_TEST) && $(ECHO) '-Wno-address')
 WORKAROUND_CFLAGS += $(WNA_FLAGS)
+
+# gcc 8.0 generates warnings for certain suspect string operations. Our
+# sources have been vetted for correct usage.  Turn off these warnings.
+#
+WNST_TEST = $(CC) -Wno-stringop-truncation -x c -c /dev/null -o /dev/null \
+		  >/dev/null 2>&1
+WNST_FLAGS := $(shell $(WNST_TEST) && $(ECHO) '-Wno-stringop-truncation')
+WORKAROUND_CFLAGS += $(WNST_FLAGS)
 endif
 
 # Some versions of gas choke on division operators, treating them as
 # comment markers.  Specifying --divide will work around this problem,
 # but isn't available on older gas versions.
 #
 DIVIDE_TEST = $(AS) --divide /dev/null -o /dev/null 2>/dev/null
 DIVIDE_FLAGS := $(shell $(DIVIDE_TEST) && $(ECHO) '--divide')
 WORKAROUND_ASFLAGS += $(DIVIDE_FLAGS)
 
 ###############################################################################
 #
@@ -415,25 +423,25 @@ CFLAGS		+= -diag-disable 810 # Casting ints to smaller ints
 CFLAGS		+= -diag-disable 981 # Sequence point violations
 CFLAGS		+= -diag-disable 1292 # Ignored attributes
 CFLAGS		+= -diag-disable 1338 # void pointer arithmetic
 CFLAGS		+= -diag-disable 1361 # Variable-length arrays
 CFLAGS		+= -diag-disable 1418 # Missing prototypes
 CFLAGS		+= -diag-disable 1419 # Missing prototypes
 CFLAGS		+= -diag-disable 1599 # Hidden variables
 CFLAGS		+= -Wall -Wmissing-declarations
 endif
 CFLAGS		+= $(WORKAROUND_CFLAGS) $(EXTRA_CFLAGS)
 ASFLAGS		+= $(WORKAROUND_ASFLAGS) $(EXTRA_ASFLAGS)
 LDFLAGS		+= $(WORKAROUND_LDFLAGS) $(EXTRA_LDFLAGS)
-HOST_CFLAGS	+= -O2 -g
+HOST_CFLAGS	+= $(WORKAROUND_CFLAGS) -O2 -g
 
 # Inhibit -Werror if NO_WERROR is specified on make command line
 #
 ifneq ($(NO_WERROR),1)
 CFLAGS		+= -Werror
 ASFLAGS		+= --fatal-warnings
 HOST_CFLAGS	+= -Werror
 endif
 
 # Function trace recorder state in the last build.  This is needed
 # in order to correctly rebuild whenever the function recorder is
 # enabled/disabled.

Places

File ipxe.8ed4e3049f5fcb3a0b32f5190940e78c61654cff.patch of Package xen (Revision 9c85a36e5d114c8038b820a72e545168)

Places