File ovmf.fe4a28ccbfd33cae9e1f56b174d46b4eb2329efd.p... of Package xen

Overview Repositories Revisions Requests Users Attributes Meta

File ovmf.fe4a28ccbfd33cae9e1f56b174d46b4eb2329efd.patch of Package xen (Revision 64deec46161a6604ed78bd78b28ddd99)

Currently displaying revision 64deec46161a6604ed78bd78b28ddd99 , Show latest

From: Dandan Bi <dandan.bi@intel.com>
Date: Sat, 1 Apr 2017 10:31:14 +0800
Subject: fe4a28ccbfd33cae9e1f56b174d46b4eb2329efd

MdeModulePkg/UefiHiiLib:Fix incorrect comparison expression

Fix the incorrect comparison between pointer and constant zero character.

https://bugzilla.tianocore.org/show_bug.cgi?id=416

V2: The pointer StringPtr points to a string returned
by ExtractConfig/ExportConfig, if it is NULL, function
InternalHiiIfrValueAction will return FALSE. So in
current usage model, the StringPtr can not be NULL before
using it, so we can add ASSERT here.

Cc: Eric Dong <eric.dong@intel.com>
Cc: Liming Gao <liming.gao@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Dandan Bi <dandan.bi@intel.com>
Reviewed-by: Eric Dong <eric.dong@intel.com>
---
 MdeModulePkg/Library/UefiHiiLib/HiiLib.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

--- a/MdeModulePkg/Library/UefiHiiLib/HiiLib.c
+++ b/MdeModulePkg/Library/UefiHiiLib/HiiLib.c
@@ -2192,26 +2192,27 @@ InternalHiiIfrValueAction (
   } else {
     Status = gHiiConfigRouting->ExportConfig (
                                   gHiiConfigRouting,
                                   &ConfigAltResp
                                 );
   }
   
   if (EFI_ERROR (Status)) {
     return FALSE;
   }
   
   StringPtr = ConfigAltResp;
-  
-  while (StringPtr != L'\0') {
+  ASSERT (StringPtr != NULL);
+
+  while (*StringPtr != L'\0') {
     //
     // 1. Find <ConfigHdr> GUID=...&NAME=...&PATH=...
     //
     StringHdr = StringPtr;
 
     //
     // Get Guid value
     //
     if (StrnCmp (StringPtr, L"GUID=", StrLen (L"GUID=")) != 0) {
       Status = EFI_INVALID_PARAMETER;
       goto Done;
     }

Places

File ovmf.fe4a28ccbfd33cae9e1f56b174d46b4eb2329efd.patch of Package xen (Revision 64deec46161a6604ed78bd78b28ddd99)

Places