File valgrind.remove-unhelpful-comments-from-xen-dom... of Package valgrind

Overview Repositories Revisions Requests Users Attributes Meta

File valgrind.remove-unhelpful-comments-from-xen-domctl.patch of Package valgrind (Revision 5aa2fc40d61cc0f603f275185a258b47)

Currently displaying revision 5aa2fc40d61cc0f603f275185a258b47 , Show latest

From: Olaf Hering <olaf@aepfle.de>
Date: Thu, 22 Nov 2018 17:38:49 +0100
Subject: remove unhelpful comments from xen domctl

The various interface_version numbers are self-explanatory.
And 0x7 is actually xen-4.1.

bz#390553
---
 coregrind/m_syswrap/syswrap-xen.c | 14 +++++++-------
 1 file changed, 7 insertions(+), 7 deletions(-)

--- a/coregrind/m_syswrap/syswrap-xen.c
+++ b/coregrind/m_syswrap/syswrap-xen.c
@@ -898,25 +898,25 @@ PRE(domctl)
        break;
 
    case VKI_XEN_DOMCTL_max_mem:
       PRE_XEN_DOMCTL_READ(max_mem, max_memkb);
       break;
 
    case VKI_XEN_DOMCTL_set_address_size:
       __PRE_XEN_DOMCTL_READ(set_address_size, address_size, size);
       break;
 
    case VKI_XEN_DOMCTL_test_assign_device:
       switch (domctl->interface_version) {
-      case 0x00000007: /* pre-4.6 */
+      case 0x00000007:
       case 0x00000008:
       case 0x00000009:
       case 0x0000000a:
          __PRE_XEN_DOMCTL_READ(test_assign_device, assign_device_00000007, machine_sbdf);
          break;
       case 0x0000000b:
       case 0x0000000c:
       case 0x0000000d:
       case 0x0000000e:
       case 0x0000000f:
       case 0x00000010:
       case 0x00000011:
@@ -935,25 +935,25 @@ PRE(domctl)
             break;
          default:
             bad_subop(tid, layout, arrghs, status, flags,
                          "__HYPERVISOR_domctl_test_assign_device dev",
                          domctl->u.assign_device_0000000b.dev);
             break;
          }
          break;
       }
       break;
    case VKI_XEN_DOMCTL_assign_device:
       switch (domctl->interface_version) {
-      case 0x00000007: /* pre-4.6 */
+      case 0x00000007:
       case 0x00000008:
       case 0x00000009:
       case 0x0000000a:
          __PRE_XEN_DOMCTL_READ(assign_device, assign_device_00000007, machine_sbdf);
          break;
       case 0x0000000b:
       case 0x0000000c:
       case 0x0000000d:
       case 0x0000000e:
       case 0x0000000f:
       case 0x00000010:
       case 0x00000011:
@@ -972,25 +972,25 @@ PRE(domctl)
             break;
          default:
             bad_subop(tid, layout, arrghs, status, flags,
                          "__HYPERVISOR_domctl_assign_device dev",
                          domctl->u.assign_device_0000000b.dev);
             break;
          }
          break;
       }
       break;
    case VKI_XEN_DOMCTL_deassign_device:
       switch (domctl->interface_version) {
-      case 0x00000007: /* pre-4.6 */
+      case 0x00000007:
       case 0x00000008:
       case 0x00000009:
       case 0x0000000a:
          __PRE_XEN_DOMCTL_READ(deassign_device, assign_device_00000007, machine_sbdf);
          break;
       case 0x0000000b:
       case 0x0000000c:
       case 0x0000000d:
       case 0x0000000e:
       case 0x0000000f:
       case 0x00000010:
       case 0x00000011:
@@ -1010,25 +1010,25 @@ PRE(domctl)
          default:
             bad_subop(tid, layout, arrghs, status, flags,
                          "__HYPERVISOR_domctl_deassign_device dev",
                          domctl->u.assign_device_0000000b.dev);
             break;
          }
          break;
       }
       break;
 
    case VKI_XEN_DOMCTL_settscinfo:
       switch (domctl->interface_version) {
-      case 0x00000007: /* pre-4.6 */
+      case 0x00000007:
       case 0x00000008:
       case 0x00000009:
       case 0x0000000a:
          __PRE_XEN_DOMCTL_READ(settscinfo, tsc_info_00000007, info.tsc_mode);
          __PRE_XEN_DOMCTL_READ(settscinfo, tsc_info_00000007, info.gtsc_khz);
          __PRE_XEN_DOMCTL_READ(settscinfo, tsc_info_00000007, info.incarnation);
          __PRE_XEN_DOMCTL_READ(settscinfo, tsc_info_00000007, info.elapsed_nsec);
          break;
       case 0x0000000b:
       case 0x0000000c:
       case 0x0000000d:
       case 0x0000000e:
@@ -1385,25 +1385,25 @@ PRE(domctl)
    case VKI_XEN_DOMCTL_cacheflush:
       PRE_XEN_DOMCTL_READ(cacheflush, start_pfn);
       PRE_XEN_DOMCTL_READ(cacheflush, nr_pfns);
       break;
 
    case VKI_XEN_DOMCTL_set_access_required:
       PRE_XEN_DOMCTL_READ(access_required, access_required);
       break;
 
    case VKI_XEN_DOMCTL_mem_event_op:
    //case VKI_XEN_DOMCTL_vm_event_op: /* name change in 4.6 */
       switch (domctl->interface_version) {
-      case 0x00000007: /* pre-4.6 */
+      case 0x00000007:
       case 0x00000008:
       case 0x00000009:
       case 0x0000000a:
       case 0x0000000b:
       case 0x0000000c:
       case 0x0000000d:
       case 0x0000000e:
       case 0x0000000f:
       case 0x00000010:
       case 0x00000011:
          __PRE_XEN_DOMCTL_READ(mem_event_op, vm_event_op_00000008, op);
          __PRE_XEN_DOMCTL_READ(mem_event_op, vm_event_op_00000008, mode);
@@ -2122,25 +2122,25 @@ POST(domctl){
       break;
 
    case VKI_XEN_DOMCTL_max_vcpus:
       POST_XEN_DOMCTL_WRITE(max_vcpus, max);
       break;
 
    case VKI_XEN_DOMCTL_get_address_size:
       __POST_XEN_DOMCTL_WRITE(get_address_size, address_size, size);
       break;
 
    case VKI_XEN_DOMCTL_gettscinfo:
       switch (domctl->interface_version) {
-      case 0x00000007: /* pre-4.6 */
+      case 0x00000007:
       case 0x00000008:
       case 0x00000009:
       case 0x0000000a:
          __POST_XEN_DOMCTL_WRITE(gettscinfo, tsc_info_00000007, out_info);
          POST_MEM_WRITE((Addr)domctl->u.tsc_info_00000007.out_info.p,
                         sizeof(vki_xen_guest_tsc_info_t));
          break;
       case 0x0000000b:
       case 0x0000000c:
       case 0x0000000d:
       case 0x0000000e:
       case 0x0000000f:
@@ -2398,25 +2398,25 @@ POST(domctl){
        }
        break;
    case VKI_XEN_DOMCTL_get_vcpu_msrs:
       if (domctl->u.vcpu_msrs.msrs.p)
          POST_MEM_WRITE((Addr)domctl->u.vcpu_msrs.msrs.p,
                         sizeof(vki_xen_domctl_vcpu_msr_t) *
                         domctl->u.vcpu_msrs.msr_count);
       break;
 
    case VKI_XEN_DOMCTL_mem_event_op:
    //case VKI_XEN_DOMCTL_vm_event_op: /* name change in 4.6 */
       switch (domctl->interface_version) {
-      case 0x00000007: /* pre-4.6 */
+      case 0x00000007:
       case 0x00000008:
       case 0x00000009:
       case 0x0000000a:
       case 0x0000000b:
       case 0x0000000c:
       case 0x0000000d:
       case 0x0000000e:
       case 0x0000000f:
       case 0x00000010:
       case 0x00000011:
          __POST_XEN_DOMCTL_WRITE(mem_event_op, vm_event_op_00000008, port);
          break;

Places

File valgrind.remove-unhelpful-comments-from-xen-domctl.patch of Package valgrind (Revision 5aa2fc40d61cc0f603f275185a258b47)

Places