File valgrind.xen-add-a-concept-of-use-the-latest.patch of Package valgrind

Overview Repositories Revisions Requests Users Attributes Meta

File valgrind.xen-add-a-concept-of-use-the-latest.patch of Package valgrind (Revision abbc04a9d7da8ff4ee56b8df17b6ed77)

Currently displaying revision abbc04a9d7da8ff4ee56b8df17b6ed77 , Show latest

From: Olaf Hering <olaf@aepfle.de>
Date: Fri, 16 Nov 2018 17:29:52 +0100
Subject: xen: add a concept of "use the latest"

In coregrind/m_syswrap/syswrap-xen.c the handlers of sysctl and domctl check
the current ->interface_version. If it is not yet known, an error is reported.
Otherwise the current ->cmd is processed. Several commands handle various
->interface_version. But none of these handlers have a concept of "use the
latest". If a new interface_version is added at the beginning of the list, each
and every handler must be updated with the newly added version number. I think
it would be simpler to check the supported versions as it is done now, then
each handler uses the latest layout in a "default:" case.

bz#390553
---
 coregrind/m_syswrap/syswrap-xen.c | 40 ++++++++++++++++++++++------------------
 1 file changed, 22 insertions(+), 18 deletions(-)

--- a/coregrind/m_syswrap/syswrap-xen.c
+++ b/coregrind/m_syswrap/syswrap-xen.c
@@ -632,16 +632,11 @@ PRE(sysctl) {
 	 break;
       case 0x0000000a:
       case 0x0000000b:
+      default:
 	 PRE_XEN_SYSCTL_READ(getdomaininfolist_0000000a, first_domain);
 	 PRE_XEN_SYSCTL_READ(getdomaininfolist_0000000a, max_domains);
 	 PRE_XEN_SYSCTL_READ(getdomaininfolist_0000000a, buffer);
 	 break;
-      default:
-          VG_(dmsg)("WARNING: XEN_SYSCTL_getdomaininfolist for sysctl version "
-                    "%"PRIx32" not implemented yet\n",
-                    sysctl->interface_version);
-          SET_STATUS_Failure(VKI_EINVAL);
-          return;
       }
       break;
 
@@ -906,6 +901,7 @@ PRE(domctl)
          }
          break;
       case 0x0000000e:
+      default:
          __PRE_XEN_DOMCTL_READ(gethvmcontext_partial, hvmcontext_partial_0000000e, type);
          __PRE_XEN_DOMCTL_READ(gethvmcontext_partial, hvmcontext_partial_0000000e, instance);
          __PRE_XEN_DOMCTL_READ(gethvmcontext_partial, hvmcontext_partial_0000000e, bufsz);
@@ -973,6 +969,7 @@ PRE(domctl)
          }
          break;
       case 0x0000000e:
+      default:
          __PRE_XEN_DOMCTL_READ(test_assign_device, assign_device_0000000e, dev);
          __PRE_XEN_DOMCTL_READ(test_assign_device, assign_device_0000000e, flags);
          switch (domctl->u.assign_device_0000000e.dev) {
@@ -1025,6 +1022,7 @@ PRE(domctl)
          }
          break;
       case 0x0000000e:
+      default:
          __PRE_XEN_DOMCTL_READ(assign_device, assign_device_0000000e, dev);
          __PRE_XEN_DOMCTL_READ(assign_device, assign_device_0000000e, flags);
          switch (domctl->u.assign_device_0000000e.dev) {
@@ -1077,6 +1075,7 @@ PRE(domctl)
          }
          break;
       case 0x0000000e:
+      default:
          __PRE_XEN_DOMCTL_READ(deassign_device, assign_device_0000000e, dev);
          __PRE_XEN_DOMCTL_READ(deassign_device, assign_device_0000000e, flags);
          switch (domctl->u.assign_device_0000000e.dev) {
@@ -1111,6 +1110,7 @@ PRE(domctl)
          __PRE_XEN_DOMCTL_READ(settscinfo, tsc_info_00000007, info.elapsed_nsec);
          break;
       case 0x0000000b:
+      default:
          __PRE_XEN_DOMCTL_READ(settscinfo, tsc_info_0000000b, tsc_mode);
          __PRE_XEN_DOMCTL_READ(settscinfo, tsc_info_0000000b, gtsc_khz);
          __PRE_XEN_DOMCTL_READ(settscinfo, tsc_info_0000000b, incarnation);
@@ -1149,6 +1149,7 @@ PRE(domctl)
          PRE_XEN_DOMCTL_READ(settimeoffset_0000000a, time_offset_seconds);
          break;
       case 0x0000000b:
+      default:
          PRE_XEN_DOMCTL_READ(settimeoffset_0000000b, time_offset_seconds);
          break;
       }
@@ -1196,6 +1197,7 @@ PRE(domctl)
          __PRE_XEN_DOMCTL_READ(getvcpuaffinity, vcpuaffinity_00000009, cpumap.nr_bits);
          break;
       case 0x0000000a:
+      default:
          __PRE_XEN_DOMCTL_READ(getvcpuaffinity, vcpuaffinity_0000000a, vcpu);
          if (domctl->u.vcpuaffinity_0000000a.flags & VKI_XEN_VCPUAFFINITY_HARD)
             __PRE_XEN_DOMCTL_READ(
@@ -1219,6 +1221,7 @@ PRE(domctl)
                       domctl->u.vcpuaffinity_00000009.cpumap.nr_bits / 8);
          break;
       case 0x0000000a:
+      default:
          __PRE_XEN_DOMCTL_READ(setvcpuaffinity, vcpuaffinity_0000000a, vcpu);
          __PRE_XEN_DOMCTL_READ(setvcpuaffinity, vcpuaffinity_0000000a, flags);
          if (domctl->u.vcpuaffinity_0000000a.flags & VKI_XEN_VCPUAFFINITY_HARD) {
@@ -1275,13 +1278,8 @@ PRE(domctl)
          break;
 
       case 0x00000009:
-         __PRE_XEN_DOMCTL_READ(get_ext_vcpucontext, ext_vcpucontext_00000009, vcpu);
-         break;
-
       default:
-         VG_(dmsg)("WARNING: VKI_XEN_DOMCTL_get_ext_vcpucontext  domctl version %#"
-                   PRIx32" not implemented\n", domctl->interface_version);
-         SET_STATUS_Failure(VKI_EINVAL);
+         __PRE_XEN_DOMCTL_READ(get_ext_vcpucontext, ext_vcpucontext_00000009, vcpu);
          break;
       }
       break;
@@ -1315,6 +1313,7 @@ PRE(domctl)
            break;
 
        case 0x00000009:
+       default:
            __PRE_XEN_DOMCTL_READ(set_ext_vcpucontext, ext_vcpucontext_00000009, vcpu);
            __PRE_XEN_DOMCTL_READ(set_ext_vcpucontext, ext_vcpucontext_00000009, size);
 #if defined(__i386__) || defined(__x86_64__)
@@ -1343,12 +1342,6 @@ PRE(domctl)
            }
 #endif
 	   break;
-
-       default:
-           VG_(dmsg)("WARNING: VKI_XEN_DOMCTL_set_ext_vcpucontext  domctl version %#"
-                     PRIx32" not implemented\n", domctl->interface_version);
-           SET_STATUS_Failure(VKI_EINVAL);
-           break;
        }
        break;
 
@@ -1453,6 +1446,7 @@ PRE(domctl)
          __PRE_XEN_DOMCTL_READ(mem_event_op, mem_event_op_00000007, mode);
          break;
       case 0x0000000b:
+      default:
          __PRE_XEN_DOMCTL_READ(vm_event_op, vm_event_op_0000000b, op);
          __PRE_XEN_DOMCTL_READ(vm_event_op, vm_event_op_0000000b, mode);
          break;
@@ -1483,6 +1477,7 @@ PRE(domctl)
    case VKI_XEN_DOMCTL_monitor_op:
       switch (domctl->interface_version) {
       case 0x000000b:
+      default:
           if (domctl->u.monitor_op_0000000b.op == VKI_XEN_DOMCTL_MONITOR_OP_ENABLE ||
               domctl->u.monitor_op_0000000b.op == VKI_XEN_DOMCTL_MONITOR_OP_DISABLE) {
              switch (domctl->u.monitor_op_0000000b.event) {
@@ -1919,6 +1914,7 @@ POST(sysctl)
 	 break;
       case 0x0000000a:
       case 0x0000000b:
+      default:
 	 POST_XEN_SYSCTL_WRITE(getdomaininfolist_0000000a, num_domains);
 	 POST_MEM_WRITE((Addr)sysctl->u.getdomaininfolist_0000000a.buffer.p,
 			sizeof(*sysctl->u.getdomaininfolist_0000000a.buffer.p)
@@ -1983,6 +1979,7 @@ POST(sysctl)
          POST_XEN_SYSCTL_WRITE(physinfo_0000000a, capabilities);
          break;
       case 0x00000010:
+      default:
          POST_XEN_SYSCTL_WRITE(physinfo_00000010, threads_per_core);
          POST_XEN_SYSCTL_WRITE(physinfo_00000010, cores_per_socket);
          POST_XEN_SYSCTL_WRITE(physinfo_00000010, nr_cpus);
@@ -2165,6 +2162,7 @@ POST(domctl){
                         sizeof(vki_xen_guest_tsc_info_t));
          break;
       case 0x0000000b:
+      default:
          __POST_XEN_DOMCTL_WRITE(gettscinfo, tsc_info_0000000b, tsc_mode);
          __POST_XEN_DOMCTL_WRITE(gettscinfo, tsc_info_0000000b, gtsc_khz);
          __POST_XEN_DOMCTL_WRITE(gettscinfo, tsc_info_0000000b, incarnation);
@@ -2209,6 +2207,7 @@ POST(domctl){
             break;
          }
       case 0x0000000e:
+      default:
          switch (domctl->u.hvmcontext_partial_0000000e.type) {
          case VKI_HVM_SAVE_CODE(CPU):
             if ( domctl->u.hvmcontext_partial_0000000e.buffer.p )
@@ -2257,6 +2256,7 @@ POST(domctl){
                         domctl->u.vcpuaffinity_00000009.cpumap.nr_bits / 8);
          break;
       case 0x0000000a:
+      default:
          if (domctl->u.vcpuaffinity_0000000a.flags & VKI_XEN_VCPUAFFINITY_HARD)
             POST_MEM_WRITE(
                (Addr)domctl->u.vcpuaffinity_0000000a.cpumap_hard.bitmap.p,
@@ -2306,6 +2306,7 @@ POST(domctl){
       break;
       case 0x00000009:
       case 0x0000000a:
+      default:
 	 POST_XEN_DOMCTL_WRITE(getdomaininfo_00000009, domain);
 	 POST_XEN_DOMCTL_WRITE(getdomaininfo_00000009, flags);
 	 POST_XEN_DOMCTL_WRITE(getdomaininfo_00000009, tot_pages);
@@ -2358,6 +2359,7 @@ POST(domctl){
            break;
 
        case 0x00000009:
+       default:
            __POST_XEN_DOMCTL_WRITE(get_ext_vcpucontext, ext_vcpucontext_00000009, size);
 #if defined(__i386__) || defined(__x86_64__)
            __POST_XEN_DOMCTL_WRITE(get_ext_vcpucontext, ext_vcpucontext_00000009,
@@ -2434,6 +2436,7 @@ POST(domctl){
          __POST_XEN_DOMCTL_WRITE(mem_event_op, mem_event_op_00000007, port);
          break;
       case 0x0000000b:
+      default:
          __POST_XEN_DOMCTL_WRITE(vm_event_op, vm_event_op_0000000b, port);
          break;
       }
@@ -2478,6 +2481,7 @@ POST(domctl){
 
          break;
       case 0x000000e:
+      default:
           if (domctl->u.monitor_op_0000000e.op == VKI_XEN_DOMCTL_MONITOR_OP_GET_CAPABILITIES) {
              switch(domctl->u.monitor_op_0000000e.event) {
              case VKI_XEN_DOMCTL_MONITOR_EVENT_WRITE_CTRLREG:

Places

File valgrind.xen-add-a-concept-of-use-the-latest.patch of Package valgrind (Revision abbc04a9d7da8ff4ee56b8df17b6ed77)

Places