File polly-settings.patch of Package polly

Overview Repositories Revisions Requests Users Attributes Meta

File polly-settings.patch of Package polly

From: mvyskocil@suse.com
Subject: Return default values for non-existing settings

settings.py code assumes all queried items does exists, which is not true for
the first start. So return a proper default value in case self.value is None

Index: src/polly/setting.py
===================================================================
--- src.orig/polly/setting.py
+++ src/polly/setting.py
@@ -61,7 +61,7 @@ class Setting(object):
 
 class BooleanSetting(Setting):
     def get_value(self):
-        return self.value.get_bool()
+        return self.value.get_bool() if self.value is not None else False
 
 
     def set_value(self, value):
@@ -71,7 +71,7 @@ class BooleanSetting(Setting):
 
 class IntegerSetting(Setting):
     def get_value(self):
-        return self.value.get_int()
+        return self.value.get_int() if self.value is not None else 0
 
 
     def set_value(self, value):
@@ -81,7 +81,7 @@ class IntegerSetting(Setting):
 
 class StringSetting(Setting):
     def get_value(self):
-        return self.value.get_string()
+        return self.value.get_string() if self.value is not None else ""
 
 
     def set_value(self, value):

Places

File polly-settings.patch of Package polly

Places