File 5cd92724-drivers-video-drop-constraints.patch of Package xen

Overview Repositories Revisions Requests Users Attributes Meta

File 5cd92724-drivers-video-drop-constraints.patch of Package xen (Revision 7cefad5edb09a35359b01695ee5db5fa)

Currently displaying revision 7cefad5edb09a35359b01695ee5db5fa , Show latest

# Commit 19600eb75aa9b1df3e4b0a4e55a5d08b957e1fd9
# Date 2019-05-13 10:13:24 +0200
# Author Marek Marczykowski-Górecki <marmarek@invisiblethingslab.com>
# Committer Jan Beulich <jbeulich@suse.com>
drivers/video: drop framebuffer size constraints

The limit 1900x1200 do not match real world devices (1900 looks like a
typo, should be 1920). But in practice the limits are arbitrary and do
not serve any real purpose. As discussed in "Increase framebuffer size
to todays standards" thread, drop them completely.

This fixes graphic console on device with 3840x2160 native resolution.

Suggested-by: Jan Beulich <jbeulich@suse.com>
Signed-off-by: Marek Marczykowski-Górecki <marmarek@invisiblethingslab.com>
Acked-by: Andrew Cooper <andrew.cooper3@citrix.com>

# Commit 343459e34a6d32ba44a21f8b8fe4c1f69b1714c2
# Date 2019-05-13 10:12:56 +0200
# Author Marek Marczykowski-Górecki <marmarek@invisiblethingslab.com>
# Committer Jan Beulich <jbeulich@suse.com>
drivers/video: drop unused limits

MAX_BPP, MAX_FONT_W, MAX_FONT_H are not used in the code at all.

Suggested-by: Jan Beulich <jbeulich@suse.com>
Signed-off-by: Marek Marczykowski-Górecki <marmarek@invisiblethingslab.com>
Acked-by: Andrew Cooper <andrew.cooper3@citrix.com>

--- a/xen/drivers/video/lfb.c
+++ b/xen/drivers/video/lfb.c
@@ -10,12 +10,6 @@
 #include "lfb.h"
 #include "font.h"
 
-#define MAX_XRES 1900
-#define MAX_YRES 1200
-#define MAX_BPP 4
-#define MAX_FONT_W 8
-#define MAX_FONT_H 16
-
 struct lfb_status {
     struct lfb_prop lfbp;
 
@@ -149,13 +143,6 @@ void lfb_carriage_return(void)
 
 int __init lfb_init(struct lfb_prop *lfbp)
 {
-    if ( lfbp->width > MAX_XRES || lfbp->height > MAX_YRES )
-    {
-        printk(XENLOG_WARNING "Couldn't initialize a %ux%u framebuffer early.\n",
-               lfbp->width, lfbp->height);
-        return -EINVAL;
-    }
-
     lfb.lfbp = *lfbp;
 
     lfb.lbuf = xmalloc_bytes(lfb.lfbp.bytes_per_line);

Places

File 5cd92724-drivers-video-drop-constraints.patch of Package xen (Revision 7cefad5edb09a35359b01695ee5db5fa)

Places