File 602ffae9-tools-libs-light-fix-xl-save--c-handli... of Package xen

Overview Repositories Revisions Requests Users Attributes Meta

File 602ffae9-tools-libs-light-fix-xl-save--c-handling.patch of Package xen (Revision 27bcb771578d83b4dc0a62a6f7aa33ea)

Currently displaying revision 27bcb771578d83b4dc0a62a6f7aa33ea , Show latest

Subject: tools/libs/light: fix xl save -c handling
From: Juergen Gross jgross@suse.com Fri Feb 19 15:13:37 2021 +0100
Date: Fri Feb 19 17:52:41 2021 +0000:
Git: 87a067fd8f4d4f7c6be02c3d38145115ac542017

libxl_domain_resume() won't work correctly for the case it was called
due to a "xl save -c" command, i.e. to continue the suspended domain.

The information to do that is not saved in libxl__dm_resume_state for
non-HVM domains.

Fixes: 6298f0eb8f443 ("libxl: Re-introduce libxl__domain_resume")
Reported-by: Marek Marczykowski-Górecki <marmarek@invisiblethingslab.com>
Signed-off-by: Juergen Gross <jgross@suse.com>
Reviewed-by: Jan Beulich <jbeulich@suse.com>
Tested-by: Marek Marczykowski-Górecki <marmarek@invisiblethingslab.com>
Acked-by: Wei Liu <wl@xen.org>

diff --git a/tools/libxl/libxl_dom_suspend.c b/tools/libxl/libxl_dom_suspend.c
index 25d1571895..f7823bbc8f 100644
--- a/tools/libxl/libxl_dom_suspend.c
+++ b/tools/libxl/libxl_dom_suspend.c
@@ -630,12 +630,13 @@ void libxl__domain_resume(libxl__egc *egc,
         goto out;
     }
 
+    dmrs->suspend_cancel = suspend_cancel;
+
     if (type != LIBXL_DOMAIN_TYPE_HVM) {
         rc = 0;
         goto out;
     }
 
-    dmrs->suspend_cancel = suspend_cancel;
     dmrs->dm_resumed_callback = domain_resume_done;
     libxl__dm_resume(egc, dmrs); /* must be last */
     return;

Places

File 602ffae9-tools-libs-light-fix-xl-save--c-handling.patch of Package xen (Revision 27bcb771578d83b4dc0a62a6f7aa33ea)

Places