File dont-crash-on-broken-GIF-images.patch of Package libqt4-devel-doc

Overview Repositories Revisions Requests Users Attributes Meta

File dont-crash-on-broken-GIF-images.patch of Package libqt4-devel-doc

From: Lars Knoll <lars.knoll@digia.com>
Date: Thu, 24 Apr 2014 13:33:27 +0000
Subject: Don't crash on broken GIF images
X-Git-Url: http://quickgit.kde.org/?p=qt.git&a=commitdiff&h=f1b76c126c476c155af8c404b97c42cd1a709333
---
Don't crash on broken GIF images

Broken GIF images could set invalid width and height
values inside the image, leading to Qt creating a null
QImage for it. In that case we need to abort decoding
the image and return an error.

Initial patch by Rich Moore.

Backport of Id82a4036f478bd6e49c402d6598f57e7e5bb5e1e from Qt 5

Task-number: QTBUG-38367
Change-Id: I0680740018aaa8356d267b7af3f01fac3697312a
Security-advisory: CVE-2014-0190
Reviewed-by: Richard J. Moore <rich@kde.org>
---

--- a/src/gui/image/qgifhandler.cpp
+++ b/src/gui/image/qgifhandler.cpp
@@ -357,6 +357,13 @@
                     bpl = image->bytesPerLine();
                     bits = image->bits();
                     memset(bits, 0, image->byteCount());
+                }
+
+                // Check if the previous attempt to create the image failed. If it
+                // did then the image is broken and we should give up.
+                if (image->isNull()) {
+                    state = Error;
+                    return -1;
                 }
 
                 disposePrevious(image);

Places

File dont-crash-on-broken-GIF-images.patch of Package libqt4-devel-doc

Places