File smb-call-cmb_cutime-on-the-correct-url.patch of Package kdebase4-runtime

Overview Repositories Revisions Requests Users Attributes Meta

File smb-call-cmb_cutime-on-the-correct-url.patch of Package kdebase4-runtime

From aaedd983729f85129a91d861e1e4c2cc6ad084cb Mon Sep 17 00:00:00 2001
From: Harald Sitter <sitter@kde.org>
Date: Wed, 12 Feb 2020 16:37:47 +0100
Subject: smb: call smb_cutime on the correct url to actually set mtime
 properly

Summary:
since the introduction of partial resume dstUrl would can be the .part url
whereas dstOrigUrl is the final destination url.

i.e.
we called smbc_utime on smb://foo/bar.part rather than smb://foo/bar

BUG: 356651
FIXED-IN: 19.12.3

Test Plan: moving file to smb retains mtime

Reviewers: ngraham

Reviewed By: ngraham

Subscribers: kde-frameworks-devel, kfm-devel

Tags: #dolphin, #frameworks

Differential Revision: https://phabricator.kde.org/D27351
---
 kioslave/smb/kio_smb_dir.cpp | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/kioslave/smb/kio_smb_dir.cpp b/kioslave/smb/kio_smb_dir.cpp
index 85c2576..642e5d0 100644
--- a/kioslave/smb/kio_smb_dir.cpp
+++ b/kioslave/smb/kio_smb_dir.cpp
@@ -615,7 +615,7 @@ void SMBSlave::smbCopyPut(const KUrl& ksrc, const KUrl& kdst, int permissions, K
             struct utimbuf utbuf;
             utbuf.actime = st.st_atime; // access time, unchanged
             utbuf.modtime = dt.toTime_t(); // modification time
-            smbc_utime( dstUrl.toSmbcUrl(), &utbuf );
+            smbc_utime( dstOrigUrl.toSmbcUrl(), &utbuf );
         }
     }
 #endif
-- 
cgit v1.1

Places

File smb-call-cmb_cutime-on-the-correct-url.patch of Package kdebase4-runtime

Places