File remove-metadata-from-properties-dialog.patch of Package kdelibs4-apidocs

Overview Repositories Revisions Requests Users Attributes Meta

File remove-metadata-from-properties-dialog.patch of Package kdelibs4-apidocs

commit fa58b5a00540b4697bc11cacf66fedb1ba6d22ce
Author: Vishesh Handa <me@vhanda.in>
Date:   Thu Oct 10 12:36:38 2013 +0200

KPropertiesDialog: Do not show the KFileMetaDataWidget
    
    The KFileMetaDataWidget uses Nepomuk1 which is deprecated and is buggy.
    It would be better for people to use the Nepomuk2::FileMetaDataWidget.
    
    This mostly only affect Dolphin where users can tag files via the
    Information Panel and via File->Properties. This removes the widget in
    the File->Properties
    
    BUG: 324879
    REVIEW: 113190

diff --git a/kio/kfile/kpropertiesdialog.cpp b/kio/kfile/kpropertiesdialog.cpp
index b4cd8ee..6611ee7 100644
--- a/kio/kfile/kpropertiesdialog.cpp
+++ b/kio/kfile/kpropertiesdialog.cpp
@@ -112,7 +112,6 @@ extern "C" {
 #include <kseparator.h>
 #include <ksqueezedtextlabel.h>
 #include <kmimetypetrader.h>
-#include <kmetaprops.h>
 #include <kpreviewprops.h>
 #include <krun.h>
 #include <kvbox.h>
@@ -425,7 +424,6 @@ bool KPropertiesDialog::canDisplay( const KFileItemList& _items )
             KDesktopPropsPlugin::supports( _items ) ||
             KUrlPropsPlugin::supports( _items ) ||
             KDevicePropsPlugin::supports( _items ) ||
-            KFileMetaPropsPlugin::supports( _items ) ||
             KPreviewPropsPlugin::supports( _items );
 }
 
@@ -514,11 +512,6 @@ void KPropertiesDialog::KPropertiesDialogPrivate::insertPages()
         q->insertPlugin(p);
     }
 
-    if ( KFileMetaPropsPlugin::supports( m_items ) ) {
-        KPropertiesDialogPlugin *p = new KFileMetaPropsPlugin(q);
-        q->insertPlugin(p);
-    }
-
     if ( KPreviewPropsPlugin::supports( m_items ) ) {
         KPropertiesDialogPlugin *p = new KPreviewPropsPlugin(q);
         q->insertPlugin(p);

Places

File remove-metadata-from-properties-dialog.patch of Package kdelibs4-apidocs

Places