File backgroundtab.patch of Package konqueror5

Overview Repositories Revisions Requests Users Attributes Meta

File backgroundtab.patch of Package konqueror5

From 1fc4eec5172973e39472719d5fda32331e0971f6 Mon Sep 17 00:00:00 2001
From: David Faure <faure@kde.org>
Date: Sun, 23 Oct 2016 22:20:05 +0200
Subject: Revert "Honour m_type, so that Ctrl+click opens a tab".

This actually broke the setting for every other kpart:
Remove Shift handling from konqueror, since webengine already
honours it when setting m_type.
And ensure the logic matches the setting:
 Ctrl=background tab, Shift=foreground tab
unless the user setting is to default to foreground tab, then swap it around.
---
 konqueror/src/konqmainwindow.cpp        |  4 ++--
 konqueror/webenginepart/src/webpage.cpp | 16 ++++++++++++++--
 2 files changed, 16 insertions(+), 4 deletions(-)

diff --git a/src/konqmainwindow.cpp b/src/konqmainwindow.cpp
index 5f53e0e..c86954b 100644
--- a/src/konqmainwindow.cpp
+++ b/src/konqmainwindow.cpp
@@ -1179,8 +1179,8 @@ void KonqMainWindow::slotCreateNewWindow(const QUrl &url,
 
     if (createTab && !m_isPopupWithProxyWindow) {
 
-        bool newtabsinfront = !windowArgs.lowerWindow();
-        if (KonqSettings::newTabsInFront()) {
+        bool newtabsinfront = KonqSettings::newTabsInFront();
+        if (windowArgs.lowerWindow() || (QApplication::keyboardModifiers() & Qt::ShiftModifier)) {
             newtabsinfront = !newtabsinfront;
         }
         const bool aftercurrentpage = KonqSettings::openAfterCurrentPage();
-- 
cgit v0.11.2

Places

File backgroundtab.patch of Package konqueror5

Places