File Fix-MPRIS2-DesktopEntry-value.patch of Package amarok.7817

Overview Repositories Revisions Requests Users Attributes Meta

File Fix-MPRIS2-DesktopEntry-value.patch of Package amarok.7817

From: Antonio Rojas <arojas@archlinux.org>
Date: Sat, 20 Aug 2016 11:09:02 +0000
Subject: Fix MPRIS2 DesktopEntry value
X-Git-Url: http://quickgit.kde.org/?p=amarok.git&a=commitdiff&h=9449ec56d1fd77a0bfa1f7134a2bf4f91ffd14d3
---
Fix MPRIS2 DesktopEntry value

According to the MPRIS2 spec, the DesktopEntry value should be
"the basename of the .desktop file" [1], not the desktop-file-id. So
for amarok it should be "amarok" and not "kde4-amarok", regardless of
where the desktop file is installed. This fixes displaying MPRIS
controls in the Amarok taskbar tooltip in Plasma 5.7

[1] https://specifications.freedesktop.org/mpris-spec/latest/Media_Player.html#Property:DesktopEntry

Testing done by Antonio:

Player controls are displayed again in the Amarok taskbar tooltip in Plasma 5.7.

REVIEW: 128418
BUG: 365275
FIXED-IN: 2.9
---

--- a/src/dbus/mpris2/MediaPlayer2.cpp
+++ b/src/dbus/mpris2/MediaPlayer2.cpp
@@ -94,11 +94,7 @@
 
 QString MediaPlayer2::DesktopEntry() const
 {
-    // Amarok desktop file is installed in $prefix/share/applications/kde4/
-    // rather than in $prefix/share/applications. The standard way to
-    // represent this dir is with a "kde4-" prefix. See:
-    // http://standards.freedesktop.org/menu-spec/1.0/go01.html#term-desktop-file-id
-    return QLatin1String("kde4-amarok");
+    return QLatin1String("amarok");
 }
 
 QStringList MediaPlayer2::SupportedUriSchemes() const

Places

File Fix-MPRIS2-DesktopEntry-value.patch of Package amarok.7817

Places