File dunst_bad_free.patch of Package dunst

Overview Repositories Revisions Requests Users Attributes Meta

File dunst_bad_free.patch of Package dunst (Revision 2caed69c784b55efd5ddc2e73a23788e)

Currently displaying revision 2caed69c784b55efd5ddc2e73a23788e , Show latest

From 1e477395d9c93e3ec9dd0c113eec33874442515d Mon Sep 17 00:00:00 2001
From: John Chen <johnchen902@gmail.com>
Date: Sat, 21 Jan 2017 14:38:36 +0800
Subject: [PATCH] Fix #281 bad free. Also fix a memory leak. (#282)

* Fix #281 bad free. Also fix a memory leak.

With `n->icon = r->new_icon` and later `free(n->icon)`
`r->new_icon` is wrongly freed. Fix that with strdup.
Also fix an obvious memory leak by the way.
---
 src/rules.c | 7 +++++--
 1 file changed, 5 insertions(+), 2 deletions(-)

Index: dunst-1.1.0/rules.c
===================================================================
--- dunst-1.1.0.orig/rules.c
+++ dunst-1.1.0/rules.c
@@ -15,8 +15,11 @@ void rule_apply(rule_t * r, notification
                 n->timeout = r->timeout;
         if (r->urgency != -1)
                 n->urgency = r->urgency;
-        if (r->new_icon)
-                n->icon = r->new_icon;
+        if (r->new_icon) {
+                if(n->icon)
+                        g_free(n->icon);
+                n->icon = g_strdup(r->new_icon);
+        }
         if (r->fg)
                 n->color_strings[ColFG] = r->fg;
         if (r->bg)

Places

File dunst_bad_free.patch of Package dunst (Revision 2caed69c784b55efd5ddc2e73a23788e)

Places